Integrated: 8357637: Native resources cached in thread locals not released when FJP common pool threads clears thread locals

2025-05-31 Thread Alan Bateman
On Mon, 26 May 2025 17:16:02 GMT, Alan Bateman wrote: > A ForkJoinPool can be created with worker threads that clear thread locals > between tasks, thus avoiding a build up of thread locals left behind by tasks > executed in the pool. The common pool does this. Erasing thread locals (by > writ

RFR: 8358078: javap crashes with NPE on preview class file

2025-05-31 Thread Hannes Greule
This change addresses a NPE in javap when trying to print a class with minorVersion != 0. With this change, we fall back to the methods that don't take a `ClassFileFormatVersion` in such case. - Commit messages: - fix - test Changes: https://git.openjdk.org/jdk/pull/25569/files

Re: RFR: 8351594: JFR: Rate-limited sampling of Java events

2025-05-31 Thread Markus Grönlund
On Fri, 30 May 2025 22:30:25 GMT, Erik Gahlin wrote: > Could I have review of an enhancement that adds rate-limited sampling to Java > event, including five events in the JDK (SocketRead, SocketWrite, FileRead, > FileWrite, and JavaExceptionThrow). > > Testing: test/jdk/jdk/jfr > > Thanks > E

Re: RFR: 8351594: JFR: Rate-limited sampling of Java events

2025-05-31 Thread Markus Grönlund
On Fri, 30 May 2025 22:30:25 GMT, Erik Gahlin wrote: > Could I have review of an enhancement that adds rate-limited sampling to Java > event, including five events in the JDK (SocketRead, SocketWrite, FileRead, > FileWrite, and JavaExceptionThrow). > > Testing: test/jdk/jdk/jfr > > Thanks > E

Re: RFR: 8351594: JFR: Rate-limited sampling of Java events

2025-05-31 Thread Markus Grönlund
On Fri, 30 May 2025 22:30:25 GMT, Erik Gahlin wrote: > Could I have review of an enhancement that adds rate-limited sampling to Java > event, including five events in the JDK (SocketRead, SocketWrite, FileRead, > FileWrite, and JavaExceptionThrow). > > Testing: test/jdk/jdk/jfr > > Thanks > E

Re: RFR: 8351594: JFR: Rate-limited sampling of Java events

2025-05-31 Thread Markus Grönlund
On Fri, 30 May 2025 22:30:25 GMT, Erik Gahlin wrote: > Could I have review of an enhancement that adds rate-limited sampling to Java > event, including five events in the JDK (SocketRead, SocketWrite, FileRead, > FileWrite, and JavaExceptionThrow). > > Testing: test/jdk/jdk/jfr > > Thanks > E

Re: RFR: 8351594: JFR: Rate-limited sampling of Java events

2025-05-31 Thread Markus Grönlund
On Fri, 30 May 2025 22:30:25 GMT, Erik Gahlin wrote: > Could I have review of an enhancement that adds rate-limited sampling to Java > event, including five events in the JDK (SocketRead, SocketWrite, FileRead, > FileWrite, and JavaExceptionThrow). > > Testing: test/jdk/jdk/jfr > > Thanks > E

Re: RFR: 8351594: JFR: Rate-limited sampling of Java events

2025-05-31 Thread Markus Grönlund
On Fri, 30 May 2025 22:30:25 GMT, Erik Gahlin wrote: > Could I have review of an enhancement that adds rate-limited sampling to Java > event, including five events in the JDK (SocketRead, SocketWrite, FileRead, > FileWrite, and JavaExceptionThrow). > > Testing: test/jdk/jdk/jfr > > Thanks > E

Re: RFR: 8328821: Map.of() derived view collection mutators should throw UnsupportedOperationException [v11]

2025-05-31 Thread Liam Miller-Cushon
On Fri, 30 May 2025 04:21:26 GMT, Stuart Marks wrote: > [JDK-8316493](https://bugs.openjdk.org/browse/JDK-8316493) (remove caching > fields in AbstractMap) I tested that one over Google's codebase, and unlike this change where there was no observable compatibility impact, I did see some breaka

Re: RFR: 8358217: jdk/incubator/vector/PreferredSpeciesTest.java#id0 failures - expected [128] but found [256] [v2]

2025-05-31 Thread Ian Graves
> Removing incorrect assumptions and assertions from a breaking test related to > https://bugs.openjdk.org/browse/JDK-8358218 Ian Graves has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains two commits: - Merge remote-tracking branch 'up

Re: RFR: 8358218: Problemlist jdk/incubator/vector/PreferredSpeciesTest.java#id0

2025-05-31 Thread Paul Sandoz
On Sat, 31 May 2025 13:14:17 GMT, Jaikiran Pai wrote: > Can I please get a review of this change which fixes the problem listing > entry for the `jdk/incubator/vector/PreferredSpeciesTest.java#id0` test which > has been failing in our CI? > > tier1 testing with this change is currently in prog

Re: RFR: 8358218: Problemlist jdk/incubator/vector/PreferredSpeciesTest.java#id0

2025-05-31 Thread Jaikiran Pai
On Sat, 31 May 2025 13:14:17 GMT, Jaikiran Pai wrote: > Can I please get a review of this change which fixes the problem listing > entry for the `jdk/incubator/vector/PreferredSpeciesTest.java#id0` test which > has been failing in our CI? > > tier1 testing with this change is currently in prog

Integrated: 8358218: Problemlist jdk/incubator/vector/PreferredSpeciesTest.java#id0

2025-05-31 Thread Jaikiran Pai
On Sat, 31 May 2025 13:14:17 GMT, Jaikiran Pai wrote: > Can I please get a review of this change which fixes the problem listing > entry for the `jdk/incubator/vector/PreferredSpeciesTest.java#id0` test which > has been failing in our CI? > > tier1 testing with this change is currently in prog

RFR: 8358217: jdk/incubator/vector/PreferredSpeciesTest.java#id0 failures - expected [128] but found [256]

2025-05-31 Thread Ian Graves
Removing incorrect assumptions and assertions from a breaking test related to https://bugs.openjdk.org/browse/JDK-8358218 - Commit messages: - Removing incorrect assumptions from test Changes: https://git.openjdk.org/jdk/pull/25565/files Webrev: https://webrevs.openjdk.org/?repo=

Re: RFR: 8358217: jdk/incubator/vector/PreferredSpeciesTest.java#id0 failures - expected [128] but found [256]

2025-05-31 Thread Ian Graves
On Sat, 31 May 2025 16:18:59 GMT, Ian Graves wrote: > Removing incorrect assumptions and assertions from a breaking test related to > https://bugs.openjdk.org/browse/JDK-8358218 The original test made an incorrect assumption about *MaxVector sizes that doesn't hold across every platform. The a

Re: RFR: 8358218: Problemlist jdk/incubator/vector/PreferredSpeciesTest.java#id0

2025-05-31 Thread Jaikiran Pai
On Sat, 31 May 2025 13:14:17 GMT, Jaikiran Pai wrote: > Can I please get a review of this change which fixes the problem listing > entry for the `jdk/incubator/vector/PreferredSpeciesTest.java#id0` test which > has been failing in our CI? > > tier1 testing with this change is currently in prog

Re: RFR: 8356995: Provide default methods min(T, T) and max(T, T) in Comparator interface [v6]

2025-05-31 Thread Tagir F . Valeev
> Implementation of Comparator.min and Comparator.max methods. Preliminary > discussion is in this thread: > https://mail.openjdk.org/pipermail/core-libs-dev/2025-May/145638.html > The specification is mostly composed of Math.min/max and Collections.min/max > specifications. > > The methods are

RFR: 8358218: Problemlist jdk/incubator/vector/PreferredSpeciesTest.java#id0

2025-05-31 Thread Jaikiran Pai
Can I please get a review of this change which fixes the problem listing entry for the `jdk/incubator/vector/PreferredSpeciesTest.java#id0` test which has been failing in our CI? tier1 testing with this change is currently in progress to verify that this test is excluded from execution. I'll in

Re: RFR: 8358218: Problemlist jdk/incubator/vector/PreferredSpeciesTest.java#id0

2025-05-31 Thread Ian Graves
On Sat, 31 May 2025 13:14:17 GMT, Jaikiran Pai wrote: > Can I please get a review of this change which fixes the problem listing > entry for the `jdk/incubator/vector/PreferredSpeciesTest.java#id0` test which > has been failing in our CI? > > tier1 testing with this change is currently in prog

RFR: 8351594: JFR: Rate-limited sampling of Java events

2025-05-31 Thread Erik Gahlin
Could I have review of an enhancement that adds rate-limited sampling to Java event, including five events in the JDK (SocketRead, SocketWrite, FileRead, FileWrite, and JavaExceptionThrow). Testing: test/jdk/jdk/jfr Thanks Erik - Commit messages: - Consistent annotation - Fix ty

Re: RFR: 8358015: Fix SequencedMap sequenced view method specifications [v2]

2025-05-31 Thread Jaikiran Pai
On Sat, 31 May 2025 00:47:16 GMT, Stuart Marks wrote: >> For a full explanation, see the bug report >> [JDK-8358015](https://bugs.openjdk.org/browse/JDK-8358015). >> >> This PR includes three related changes: >> * New overrides in SequencedMap view collection implementations, which >> improve

Re: RFR: 8353686: Optimize Math.cbrt for x86 64 bit platforms [v4]

2025-05-31 Thread Emanuel Peter
On Thu, 29 May 2025 22:30:57 GMT, Mohamed Issa wrote: >> Patch looks good to me, some comment included. > > @jatin-bhateja Please let me know if there's anything else to address. @missa-prime The patch looks reasonable. It would have been nice if we (from Oracle) could have tested it before in