> For a full explanation, see the bug report
> [JDK-8358015](https://bugs.openjdk.org/browse/JDK-8358015).
>
> This PR includes three related changes:
> * New overrides in SequencedMap view collection implementations, which
> improve their behavior.
> * Update to `@implSpec` clauses to reflect t
On Fri, 30 May 2025 14:38:19 GMT, Jaikiran Pai wrote:
>> Overall this looks good to me. I just have a small question about the newly
>> introduced text.
>>
>> The copyright years on BasicMap.java and SequencedMap.java will need a
>> update before integrating.
>
>> I just have a small question
On Fri, 30 May 2025 14:01:04 GMT, Roger Riggs wrote:
> Comment out assertions added in JDK-8351443 from
> AbstractStringBuilder.ensureCapacityNewCoder that increase the codesize,
> preventing some inlining, and reducing performance
>
>assert coder == newCoder || newCoder == UTF16 : "ba
On Fri, 30 May 2025 14:33:05 GMT, Jaikiran Pai wrote:
>> For a full explanation, see the bug report
>> [JDK-8358015](https://bugs.openjdk.org/browse/JDK-8358015).
>>
>> This PR includes three related changes:
>> * New overrides in SequencedMap view collection implementations, which
>> improve
On Thu, 29 May 2025 19:44:20 GMT, ExE Boss wrote:
>> For a full explanation, see the bug report
>> [JDK-8358015](https://bugs.openjdk.org/browse/JDK-8358015).
>>
>> This PR includes three related changes:
>> * New overrides in SequencedMap view collection implementations, which
>> improve thei
On Fri, 30 May 2025 02:33:27 GMT, Chen Liang wrote:
>> For a full explanation, see the bug report
>> [JDK-8358015](https://bugs.openjdk.org/browse/JDK-8358015).
>>
>> This PR includes three related changes:
>> * New overrides in SequencedMap view collection implementations, which
>> improve th
On Fri, 30 May 2025 21:36:52 GMT, ExE Boss wrote:
>> Shaojin Wen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> bug fix, from @minborg
>
> src/java.base/share/classes/java/math/BigInteger.java line 192:
>
>> 190: * zero-length mag
On Sun, 6 Apr 2025 03:48:22 GMT, Mohamed Issa wrote:
> The goal of this PR is to implement an x86_64 intrinsic for
> java.lang.Math.cbrt() using libm. There is a new set of micro-benchmarks are
> included to check the performance of specific input value ranges to help
> prevent regressions in
> Some static final arrays of BigInteger and BigDecimal are stable and
> immutable. We should add `@Stable` to give the optimizer more information
Shaojin Wen has updated the pull request incrementally with one additional
commit since the last revision:
BigInteger::mag remove Stable
On Wed, 28 May 2025 13:39:40 GMT, Shaojin Wen wrote:
>> Some static final arrays of BigInteger and BigDecimal are stable and
>> immutable. We should add `@Stable` to give the optimizer more information
>
> Shaojin Wen has updated the pull request incrementally with one additional
> commit since
On Fri, 30 May 2025 19:34:16 GMT, Mohamed Issa wrote:
>> The goal of this PR is to implement an x86_64 intrinsic for
>> java.lang.Math.cbrt() using libm. There is a new set of micro-benchmarks are
>> included to check the performance of specific input value ranges to help
>> prevent regression
On Fri, 30 May 2025 19:34:16 GMT, Mohamed Issa wrote:
>> The goal of this PR is to implement an x86_64 intrinsic for
>> java.lang.Math.cbrt() using libm. There is a new set of micro-benchmarks are
>> included to check the performance of specific input value ranges to help
>> prevent regression
On Wed, 28 May 2025 21:22:30 GMT, Ian Graves wrote:
> VectorShape#largestShapeFor is referenced in existing JavaDoc but has been
> package-private. This propose change makes it public and adds documentation
> for it.
This pull request has now been integrated.
Changeset: 09301c1d
Author:Ia
On Thu, 29 May 2025 22:03:29 GMT, Ian Graves wrote:
>> VectorShape#largestShapeFor is referenced in existing JavaDoc but has been
>> package-private. This propose change makes it public and adds documentation
>> for it.
>
> Ian Graves has updated the pull request incrementally with one addition
> Hi,
>
> Enhanced exception messages are designed to hide sensitive information such
> as hostnames, IP
> addresses from exception message strings, unless the enhanced mode for the
> specific category
> has been explicitly enabled. Enhanced exceptions were first introduced in
> 8204233 in JD
> Hi,
>
> Enhanced exception messages are designed to hide sensitive information such
> as hostnames, IP
> addresses from exception message strings, unless the enhanced mode for the
> specific category
> has been explicitly enabled. Enhanced exceptions were first introduced in
> 8204233 in JD
On Fri, 30 May 2025 19:03:00 GMT, Sandhya Viswanathan
wrote:
>> Mohamed Issa has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Add newline back to templateInterpreterGenerator_x86_64.cpp source file
>> - Add special case values to cbrt
On Fri, 30 May 2025 11:25:01 GMT, Kim Barrett wrote:
> If get0() is the intrinsic, then I think that referenced snippet from the
Compile ctor can go away?
Yes.
-
PR Review Comment: https://git.openjdk.org/jdk/pull/24315#discussion_r2116517383
> The goal of this PR is to implement an x86_64 intrinsic for
> java.lang.Math.cbrt() using libm. There is a new set of micro-benchmarks are
> included to check the performance of specific input value ranges to help
> prevent regressions in the future.
>
> The command to run all range specific
On Thu, 29 May 2025 18:56:11 GMT, Mohamed Issa wrote:
>> The goal of this PR is to implement an x86_64 intrinsic for
>> java.lang.Math.cbrt() using libm. There is a new set of micro-benchmarks are
>> included to check the performance of specific input value ranges to help
>> prevent regression
On Thu, 29 May 2025 18:56:11 GMT, Mohamed Issa wrote:
>> The goal of this PR is to implement an x86_64 intrinsic for
>> java.lang.Math.cbrt() using libm. There is a new set of micro-benchmarks are
>> included to check the performance of specific input value ranges to help
>> prevent regression
On Fri, 30 May 2025 17:02:12 GMT, Justin Lu wrote:
>> Please review this PR which cleans up some i18n tests.
>>
>> There are some i18n related tests that set the locale provider to CLDR (and
>> only CLDR). Since JDK9, this is redundant and equivalent to the default.
>> Thus, occurrences of "-D
On Thu, 29 May 2025 18:56:11 GMT, Mohamed Issa wrote:
>> The goal of this PR is to implement an x86_64 intrinsic for
>> java.lang.Math.cbrt() using libm. There is a new set of micro-benchmarks are
>> included to check the performance of specific input value ranges to help
>> prevent regression
On Fri, 30 May 2025 17:02:12 GMT, Justin Lu wrote:
>> Please review this PR which cleans up some i18n tests.
>>
>> There are some i18n related tests that set the locale provider to CLDR (and
>> only CLDR). Since JDK9, this is redundant and equivalent to the default.
>> Thus, occurrences of "-D
On Fri, 30 May 2025 14:50:28 GMT, Michael McMahon wrote:
>> src/java.base/share/conf/security/java.security line 1282:
>>
>>> 1280: # Exception messages may include potentially sensitive information
>>> such as file
>>> 1281: # names, host names, or port numbers. By default, socket related
>>>
On Thu, 29 May 2025 17:20:12 GMT, Naoto Sato wrote:
> Test refactoring stemmed from the discussion at
> https://git.openjdk.org/jdk/pull/25228#discussion_r2106755160. The test is
> now based on UTF-8 instead of ISO-8859-1
This pull request has now been integrated.
Changeset: 4fa4f151
Author:
On Thu, 29 May 2025 17:20:12 GMT, Naoto Sato wrote:
> Test refactoring stemmed from the discussion at
> https://git.openjdk.org/jdk/pull/25228#discussion_r2106755160. The test is
> now based on UTF-8 instead of ISO-8859-1
Thanks for the reviews!
-
PR Comment: https://git.openjdk.
On Thu, 29 May 2025 18:49:28 GMT, Mohamed Issa wrote:
>> test/micro/org/openjdk/bench/java/lang/CbrtPerf.java line 56:
>>
>>> 54: public static class CbrtPerfRanges {
>>> 55: public static int cbrtInputCount = 2048;
>>> 56:
>>
>> Please create separate CbrtPerfSpecialValues for +/-
On Thu, 29 May 2025 19:01:04 GMT, Justin Lu wrote:
> Please review this PR which removes the test tool `GenerateKeyList.java`
> after the COMPAT locale data removal.
>
> `LocaleDataTest.java` may optionally use the `GenerateKeyList.java` tool.
> However, this tool is manually used and was prim
On Fri, 30 May 2025 00:41:12 GMT, Naoto Sato wrote:
>> Justin Lu has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> re-add testCompat to Bug8167143.java
>
> test/jdk/java/util/TimeZone/Bug8167143.java line 102:
>
>> 100: case "
> Please review this PR which cleans up some i18n tests.
>
> There are some i18n related tests that set the locale provider to CLDR (and
> only CLDR). Since JDK9, this is redundant and equivalent to the default.
> Thus, occurrences of "-Djava.locale.providers=CLDR" are just extra noise for
> th
On Mon, 26 May 2025 17:16:02 GMT, Alan Bateman wrote:
> A ForkJoinPool can be created with worker threads that clear thread locals
> between tasks, thus avoiding a build up of thread locals left behind by tasks
> executed in the pool. The common pool does this. Erasing thread locals (by
> writ
On Fri, 30 May 2025 10:48:20 GMT, kieran-farrell wrote:
>> With the recent approval of UUIDv7
>> (https://datatracker.ietf.org/doc/rfc9562/), this PR aims to add a new
>> static method UUID.timestampUUID() which constructs and returns a UUID in
>> support of the new time generated UUID version
On Fri, 30 May 2025 13:28:34 GMT, Alan Bateman wrote:
> We will need a release note to document the behavior change.
Will do.
-
PR Comment: https://git.openjdk.org/jdk/pull/24635#issuecomment-2922804844
On Fri, 30 May 2025 12:16:15 GMT, Viktor Klang wrote:
> Bumping the (synthetic) delays to 100 seconds to ensure that they don't run
> prior to shutdown being finished.
Marked as reviewed by alanb (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/25548#pullrequestreview-288
On Fri, 30 May 2025 13:32:08 GMT, Sean Mullan wrote:
>> Michael McMahon has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fixed problem with j.n.HostPortRange
>
> src/java.base/share/conf/security/java.security line 1282:
>
>> 1280: # Exc
On Fri, 30 May 2025 14:35:00 GMT, Jaikiran Pai wrote:
> I just have a small question about the newly introduced text.
I just realized one other thing - the updated BasicMap.java fixes an issue in
an existing test. Do we already have tests that might cover the new proposed
semantics of these me
On Thu, 29 May 2025 00:21:35 GMT, Stuart Marks wrote:
> For a full explanation, see the bug report
> [JDK-8358015](https://bugs.openjdk.org/browse/JDK-8358015).
>
> This PR includes three related changes:
> * New overrides in SequencedMap view collection implementations, which
> improve their
On Fri, 30 May 2025 11:07:30 GMT, Volkan Yazici wrote:
> Passes the `Charset` read from the `stdin.encoding` system property while
> creating `InputStreamReader` or `Scanner` instances for `System.in`.
>
> `stdin.encoding` is a recently added property for Java 25 in
> [JDK-8350703](https://bug
On Tue, 27 May 2025 19:21:45 GMT, David Beaumont wrote:
>> Adding read-only support to ZipFileSystem.
>>
>> The new `accessMode` environment property allows for readOnly and readWrite
>> values, and ensures that the requested mode is consistent with what's
>> returned.
>>
>> This involved a l
Comment out assertions added in JDK-8351443 from
AbstractStringBuilder.ensureCapacityNewCoder that increase the codesize,
preventing some inlining, and reducing performance
assert coder == newCoder || newCoder == UTF16 : "bad new coder UTF16 ->
LATIN1";
assert count <= newCapacity
On Fri, 30 May 2025 13:44:08 GMT, Weijun Wang wrote:
> Have you thought about creating a helper method for this purpose even if it's
> internal? At least, for the tests you can create one in `/test/lib`.
Required changes are pretty minimal – passing
`System.getProperty("stdin.encoding")` as an
On Thu, 29 May 2025 14:18:49 GMT, Roger Riggs wrote:
>> Thomas Stuefe has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains two additional
>> commits
On Fri, 30 May 2025 11:07:30 GMT, Volkan Yazici wrote:
> Passes the `Charset` read from the `stdin.encoding` system property while
> creating `InputStreamReader` or `Scanner` instances for `System.in`.
>
> `stdin.encoding` is a recently added property for Java 25 in
> [JDK-8350703](https://bug
On Sat, 24 May 2025 05:49:43 GMT, Thomas Stuefe wrote:
> See bug description. We now unblock all signals in both FORK and POSIX_SPAWN
> launch modes. This fixes the problem and makes the behavior consistent across
> these two modes.
>
> I left the VFORK mode alone since I believe the signal st
On Tue, 27 May 2025 12:14:16 GMT, Viktor Klang wrote:
>> A ForkJoinPool can be created with worker threads that clear thread locals
>> between tasks, thus avoiding a build up of thread locals left behind by
>> tasks executed in the pool. The common pool does this. Erasing thread locals
>> (by
On Fri, 30 May 2025 10:44:11 GMT, Michael McMahon wrote:
>> Hi,
>>
>> Enhanced exception messages are designed to hide sensitive information such
>> as hostnames, IP
>> addresses from exception message strings, unless the enhanced mode for the
>> specific category
>> has been explicitly enab
On Wed, 23 Apr 2025 21:50:46 GMT, Brian Burkhalter wrote:
>> In `java.io.WinNTFileSystem::isInvalid`, replace an insufficient test for
>> file path validity with a sufficient test for file path invalidity. Also,
>> add a new test.
>
> Brian Burkhalter has updated the pull request incrementally
On Wed, 28 May 2025 14:27:40 GMT, Viktor Klang wrote:
>> A ForkJoinPool can be created with worker threads that clear thread locals
>> between tasks, thus avoiding a build up of thread locals left behind by
>> tasks executed in the pool. The common pool does this. Erasing thread locals
>> (by
Bumping the (synthetic) delays to 100 seconds to ensure that they don't run
prior to shutdown being finished.
-
Commit messages:
- Harmonizing delay for *_delayedTasks() to 100 seconds to avoid spurious
failures
Changes: https://git.openjdk.org/jdk/pull/25548/files
Webrev: https
Reverts certain [JDK-8353197](https://bugs.openjdk.org/browse/JDK-8353197)
(which implements JavaDoc improvement and precautionary naming for certain
unsafe methods in `jdk.internal.access.JavaLangAccess`) changes that are found
to be incorrect. See the JBS issue for details on the followed eval
A ForkJoinPool can be created with worker threads that clear thread locals
between tasks, thus avoiding a build up of thread locals left behind by tasks
executed in the pool. The common pool does this. Erasing thread locals (by
writing null to Thread.threadLocals) grinds with thread locals that
On Thu, 29 May 2025 18:45:20 GMT, Vladimir Ivanov wrote:
>> Yes, I find it much cleaner when intrinsic is non-virtual.
>>
>>> Or maybe that's better done as a later cleanup?
>>
>> Up to you. I'm fine with the current PR if you remove the comment referring
>> to C2.
>
> FTR the special case in
Passes the `Charset` read from the `stdin.encoding` system property while
creating `InputStreamReader` or `Scanner` instances for `System.in`.
`stdin.encoding` is a recently added property for Java 25 in
[JDK-8350703](https://bugs.openjdk.org/browse/JDK-8350703). Employing it
throughout the ent
On Thu, 29 May 2025 18:30:59 GMT, Roger Riggs wrote:
>> In terms of using another clock it could open up possiblities of passing non
>> complaint time formats to the method, but maybe thats something that could
>> be mostly prevented with input validation and clear documentation i.e.
>> “times
On Fri, 30 May 2025 10:44:11 GMT, Michael McMahon wrote:
>> Hi,
>>
>> Enhanced exception messages are designed to hide sensitive information such
>> as hostnames, IP
>> addresses from exception message strings, unless the enhanced mode for the
>> specific category
>> has been explicitly enab
> With the recent approval of UUIDv7
> (https://datatracker.ietf.org/doc/rfc9562/), this PR aims to add a new static
> method UUID.timestampUUID() which constructs and returns a UUID in support of
> the new time generated UUID version.
>
> The specification requires embedding the current times
> Hi,
>
> Enhanced exception messages are designed to hide sensitive information such
> as hostnames, IP
> addresses from exception message strings, unless the enhanced mode for the
> specific category
> has been explicitly enabled. Enhanced exceptions were first introduced in
> 8204233 in JD
On Tue, 27 May 2025 12:10:19 GMT, Viktor Klang wrote:
>> A ForkJoinPool can be created with worker threads that clear thread locals
>> between tasks, thus avoiding a build up of thread locals left behind by
>> tasks executed in the pool. The common pool does this. Erasing thread locals
>> (by
On Mon, 26 May 2025 17:16:02 GMT, Alan Bateman wrote:
> A ForkJoinPool can be created with worker threads that clear thread locals
> between tasks, thus avoiding a build up of thread locals left behind by tasks
> executed in the pool. The common pool does this. Erasing thread locals (by
> writ
On Fri, 30 May 2025 09:39:36 GMT, Michael McMahon wrote:
>> Hi,
>>
>> Enhanced exception messages are designed to hide sensitive information such
>> as hostnames, IP
>> addresses from exception message strings, unless the enhanced mode for the
>> specific category
>> has been explicitly enab
> Hi,
>
> Enhanced exception messages are designed to hide sensitive information such
> as hostnames, IP
> addresses from exception message strings, unless the enhanced mode for the
> specific category
> has been explicitly enabled. Enhanced exceptions were first introduced in
> 8204233 in JD
On Thu, 29 May 2025 14:35:11 GMT, Michael McMahon wrote:
>> Hi,
>>
>> Enhanced exception messages are designed to hide sensitive information such
>> as hostnames, IP
>> addresses from exception message strings, unless the enhanced mode for the
>> specific category
>> has been explicitly enab
> Hi,
>
> Enhanced exception messages are designed to hide sensitive information such
> as hostnames, IP
> addresses from exception message strings, unless the enhanced mode for the
> specific category
> has been explicitly enabled. Enhanced exceptions were first introduced in
> 8204233 in JD
On Tue, 20 May 2025 05:40:04 GMT, Xiaohong Gong wrote:
> > @XiaohongGong Thanks for splitting this one out, and for investigating the
> > regressions here.
> > Putting the permalink here, fixed to the current change (the link you
> > pasted will always refer to the newest, which may later on po
65 matches
Mail list logo
