Integrated: 8357561: BootstrapLoggerTest does not work on Ubuntu 24 with LANG de_DE.UTF-8

2025-05-27 Thread Matthias Baesken
On Mon, 26 May 2025 07:37:58 GMT, Matthias Baesken wrote: > On a 'german' Ubuntu 24 (LANG="de_DE.UTF-8") the jtreg test > java/lang/System/LoggerFinder/internal/BootstrapLogger/BootstrapLoggerTest > fails with > > > FEIN: hi now! > java.lang.RuntimeException: System.err does not contain: FINE

Re: RFR: 8357561: BootstrapLoggerTest does not work on Ubuntu 24 with LANG de_DE.UTF-8 [v2]

2025-05-27 Thread Matthias Baesken
On Mon, 26 May 2025 08:16:03 GMT, Matthias Baesken wrote: >> On a 'german' Ubuntu 24 (LANG="de_DE.UTF-8") the jtreg test >> java/lang/System/LoggerFinder/internal/BootstrapLogger/BootstrapLoggerTest >> fails with >> >> >> FEIN: hi now! >> java.lang.RuntimeException: System.err does not contai

RFR: 8357930: Amendment for JDK-8333664

2025-05-27 Thread Alexey Semenyuk
- Extract ExternalApplication interface from AppImageFile and add it to the model; - Move LauncherData.ModuleInfo class to the top level; - Add parent interface BundleSpec for Application and Package interfaces in the model; - Merge PackageWriter and ApplicationWriter into BundleCreator interf

Re: RFR: 8354724: Methods in java.io.Reader to read all characters and all lines [v26]

2025-05-27 Thread Stuart Marks
On Fri, 23 May 2025 18:44:42 GMT, Brian Burkhalter wrote: >> Implement the requested methods and add a test thereof. > > Brian Burkhalter has updated the pull request incrementally with one > additional commit since the last revision: > > 8354724: "input reader specific" -> "reader specific"

Re: RFR: 8357597: Proxy.getInvocationHandler throws NullPointerException instead of IllegalArgumentException for null [v2]

2025-05-27 Thread SendaoYan
On Mon, 26 May 2025 15:48:10 GMT, Steffen Nießing wrote: >> `Proxy#getInvocationHandler(Object)` throws a `NullPointerException` if the >> specified argument is `null`. This PR adds the missing `throws` declaration >> for the NPE. > > Steffen Nießing has updated the pull request incrementally w

Integrated: 8357597: Proxy.getInvocationHandler throws NullPointerException instead of IllegalArgumentException for null

2025-05-27 Thread Steffen Nießing
On Fri, 23 May 2025 16:05:08 GMT, Steffen Nießing wrote: > `Proxy#getInvocationHandler(Object)` throws a `NullPointerException` if the > specified argument is `null`. This PR adds the missing `throws` declaration > for the NPE. This pull request has now been integrated. Changeset: 4cad4379 Au

Re: RFR: 8353686: Optimize Math.cbrt for x86 64 bit platforms [v3]

2025-05-27 Thread Sandhya Viswanathan
On Tue, 6 May 2025 21:45:34 GMT, Mohamed Issa wrote: >> The goal of this PR is to implement an x86_64 intrinsic for >> java.lang.Math.cbrt() using libm. There is a new set of micro-benchmarks are >> included to check the performance of specific input value ranges to help >> prevent regressions

Re: [External] : Re: mapConcurrent() with InterruptedException

2025-05-27 Thread Jige Yu
That said, I'm still curious. Have you considered propagating cancellation, re-interrupting the current thread, and then throwing an unchecked exception upon interruption? It's going to be the most fail-fast-compatible. catch (IE interrupted) { cancel all pending futures Thread.currentThread()

RFR: 8357913: Add `@Stable` to BigInteger and BigDecimal

2025-05-27 Thread Shaojin Wen
Some static final arrays of BigInteger and BigDecimal are stable and immutable. We should add `@Stable` to give the optimizer more information - Commit messages: - BigInteger::mag add `@Stable` - add stable Changes: https://git.openjdk.org/jdk/pull/25437/files Webrev: https://we

Re: RFR: 8334015: Add Support for UUID Version 7 (UUIDv7) defined in RFC 9562 [v3]

2025-05-27 Thread Roger Riggs
On Tue, 27 May 2025 21:44:32 GMT, Roger Riggs wrote: >> spec updated in class javadoc to RFC 9562 which obsolete RFC 4122, @spec tag >> also added above the method. > > I'd say "create" instead of "retrieve" in the first line comment. (Though > that word is used in the other static factories).

Re: RFR: 8334015: Add Support for UUID Version 7 (UUIDv7) defined in RFC 9562 [v3]

2025-05-27 Thread Roger Riggs
On Tue, 20 May 2025 12:00:06 GMT, kieran-farrell wrote: >> src/java.base/share/classes/java/util/UUID.java line 195: >> >>> 193: * >>> 194: * @return A {@code UUID} generated from the current system time >>> 195: */ >> >> Seems like there should be a reference to the RFC somewher

Re: RFR: 8356891: Some code simplifications in BigInteger [v24]

2025-05-27 Thread fabioromano1
> Some changes in `Biginteger`s' bit operations that increase the code > readability and slightly optimize the execution time. fabioromano1 has updated the pull request incrementally with one additional commit since the last revision: Restored trustedStripLeadingZeroInts(int[]) -

Re: RFR: 8356891: Some code simplifications in BigInteger [v25]

2025-05-27 Thread fabioromano1
> Some changes in `Biginteger`s' bit operations that increase the code > readability and slightly optimize the execution time. fabioromano1 has updated the pull request incrementally with one additional commit since the last revision: Restore calls to trustedStripLeadingZeroInts(int[]) -

Re: RFR: 8345431: Improve jar --validate to detect duplicate or invalid entries [v15]

2025-05-27 Thread Henry Jen
> This PR check the jar file to ensure entries are consistent from the central > directory and local file header. Also check there is no duplicate entry names > that could override the desired content by accident. Henry Jen has updated the pull request with a new target base due to a merge or a

Re: RFR: 8356128: Correct documentation for --linux-package-deps [v4]

2025-05-27 Thread Alexander Matveev
On Tue, 27 May 2025 19:48:11 GMT, Stefan Lobbenmeier wrote: >> The documentation suggests that --linux-package-deps is a boolean option, >> while in fact it is a string option with dependencies separated by comma and >> space >> >> You can tell that this option is supposed to have an argument

Re: RFR: 8356128: Correct documentation for --linux-package-deps [v4]

2025-05-27 Thread Alexey Semenyuk
On Tue, 27 May 2025 19:48:11 GMT, Stefan Lobbenmeier wrote: >> The documentation suggests that --linux-package-deps is a boolean option, >> while in fact it is a string option with dependencies separated by comma and >> space >> >> You can tell that this option is supposed to have an argument

Re: RFR: 8334742: Change java.time month/day field types to 'byte' [v2]

2025-05-27 Thread Roger Riggs
On Wed, 30 Apr 2025 20:38:59 GMT, Gautham Krishnan wrote: >> In the following classes, month and day values are stored in fields of type >> 'int' or 'short'. The range of allowed values is small enough that the type >> can be 'byte' instead. >> >> java.time.YearMonth >> java.time.MonthDay >> j

Re: RFR: 8357681: Fixed the DigitList::toString method causing incorrect results during debugging

2025-05-27 Thread Roger Riggs
On Tue, 27 May 2025 19:44:55 GMT, Shaojin Wen wrote: > To test this concurrency problem, we need to build a concurrent competition > test, which is not a simple task, so I did not add it. The label `noreg-hard` would be appropriate to indicate a test was not created due to difficulty. That lab

Re: RFR: 8353686: Optimize Math.cbrt for x86 64 bit platforms [v3]

2025-05-27 Thread Srinivas Vamsi Parasa
On Tue, 6 May 2025 21:45:34 GMT, Mohamed Issa wrote: >> The goal of this PR is to implement an x86_64 intrinsic for >> java.lang.Math.cbrt() using libm. There is a new set of micro-benchmarks are >> included to check the performance of specific input value ranges to help >> prevent regressions

Re: RFR: 8357913: Add `@Stable` to BigInteger and BigDecimal

2025-05-27 Thread ExE Boss
On Sun, 25 May 2025 22:35:56 GMT, Shaojin Wen wrote: > Some static final arrays of BigInteger and BigDecimal are stable and > immutable. We should add `@Stable` to give the optimizer more information Note that `BigInteger.mag` should probably also be made `@Stable` once  `BigInteger​.largePrime

Re: RFR: 8356128: Correct documentation for --linux-package-deps [v3]

2025-05-27 Thread Stefan Lobbenmeier
On Wed, 21 May 2025 20:51:48 GMT, Alexander Matveev wrote: >> Stefan Lobbenmeier has updated the pull request incrementally with one >> additional commit since the last revision: >> >> also use in other locations > > src/jdk.jpackage/share/man/jpackage.md line 426: > >> 424: : Menu group

Re: RFR: 8357681: Fixed the DigitList::toString method causing incorrect results during debugging

2025-05-27 Thread Shaojin Wen
On Tue, 27 May 2025 19:31:44 GMT, Volkan Yazici wrote: > _Nit:_ Would it be an overkill to add a test (verifying `toString` doesn't > spoil the content) to avoid falling on the same slippery slope (i.e., _"Let > me optimize this by reusing the `SB`!"_) again? The original code that calls getSt

Re: RFR: 8356128: Correct documentation for --linux-package-deps [v4]

2025-05-27 Thread Stefan Lobbenmeier
> The documentation suggests that --linux-package-deps is a boolean option, > while in fact it is a string option with dependencies separated by comma and > space > > You can tell that this option is supposed to have an argument here: > https://github.com/openjdk/jdk/blob/fea5f2b1458cdd53f437e5

Re: RFR: 8357681: Fixed the DigitList::toString method causing incorrect results during debugging

2025-05-27 Thread Shaojin Wen
On Tue, 27 May 2025 17:11:41 GMT, Johannes Döbler wrote: >> When debugging getLong/getDouble/getDecimal of DigitList, the debugger will >> call the DigitList::toString method. At this time, DigitList::toString will >> modify tempBuilder, which will cause incorrect results. > > src/java.base/sha

Re: RFR: 8357681: Fixed the DigitList::toString method causing incorrect results during debugging

2025-05-27 Thread Volkan Yazici
On Sun, 18 May 2025 11:11:32 GMT, Shaojin Wen wrote: > When debugging getLong/getDouble/getDecimal of DigitList, the debugger will > call the DigitList::toString method. At this time, DigitList::toString will > modify tempBuilder, which will cause incorrect results. _Nit:_ Would it be an overk

Re: RFR: 8357690: Add @Stable and final to java.lang.CharacterDataLatin1 and other CharacterData classes [v3]

2025-05-27 Thread Shaojin Wen
> Classes such as java.lang.CharacterDataXXX have multiple static final arrays, > these are immutable, We should add `@Stable` and final to provide information > to the optimizer. Shaojin Wen has updated the pull request incrementally with one additional commit since the last revision: fix c

Re: RFR: 8357690: Add @Stable and final to java.lang.CharacterDataLatin1 and other CharacterData classes [v2]

2025-05-27 Thread Shaojin Wen
On Tue, 27 May 2025 16:50:40 GMT, Naoto Sato wrote: > Nice refactoring. As to C-style array rewrite, I am not so keen on that as > they only appear in the generated source files, without any actual benefit. You and @cl4es both mentioned this, and I agree, but it should be another PR to remove

Re: RFR: 8350880: (zipfs) Add support for read-only zip file systems [v15]

2025-05-27 Thread David Beaumont
> Adding read-only support to ZipFileSystem. > > The new `accessMode` environment property allows for readOnly and readWrite > values, and ensures that the requested mode is consistent with what's > returned. > > This involved a little refactoring to ensure that "read only" state was set > ini

Re: RFR: 8357145: CRC/Inflater/Deflater/Adler32 methods that take a ByteBuffer throw UOE if backed by shared memory segment

2025-05-27 Thread Per Minborg
On Tue, 20 May 2025 07:37:34 GMT, Per Minborg wrote: > This PR proposes to use ` JavaNioAccess::getBufferAdress` rather than > `DirectBuffer::address` in the package `java.util.zip` so that `Buffer` > instances backed by `MemorySegment` instances can be used. > > This PR passes tier1, tier2, a

Integrated: 8357145: CRC/Inflater/Deflater/Adler32 methods that take a ByteBuffer throw UOE if backed by shared memory segment

2025-05-27 Thread Per Minborg
On Tue, 20 May 2025 07:37:34 GMT, Per Minborg wrote: > This PR proposes to use ` JavaNioAccess::getBufferAdress` rather than > `DirectBuffer::address` in the package `java.util.zip` so that `Buffer` > instances backed by `MemorySegment` instances can be used. > > This PR passes tier1, tier2, a

Re: RFR: 8356706: Foreign tests timeout after passing on linux-x64-zero

2025-05-27 Thread Per Minborg
On Thu, 15 May 2025 09:49:10 GMT, Per Minborg wrote: > This PR improves the robustness of tests on slow machines such as "zero" > variants. The timeout was increased to 10 minutes for both tests. There are > many combinations in `TestAccessModes`, so the test takes some time even on a > fast m

Re: RFR: 8356995: Provide default methods min(T, T) and max(T, T) in Comparator interface [v5]

2025-05-27 Thread Tagir F . Valeev
On Tue, 27 May 2025 18:15:34 GMT, Roger Riggs wrote: >> Tagir F. Valeev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Update exception description; update argument names > > Re-reviewed the PR and CSR. Thanks for the updates. Looks goo

Re: RFR: 8357597: Proxy.getInvocationHandler throws NullPointerException instead of IllegalArgumentException for null [v2]

2025-05-27 Thread duke
On Mon, 26 May 2025 15:48:10 GMT, Steffen Nießing wrote: >> `Proxy#getInvocationHandler(Object)` throws a `NullPointerException` if the >> specified argument is `null`. This PR adds the missing `throws` declaration >> for the NPE. > > Steffen Nießing has updated the pull request incrementally w

Re: RFR: 8356995: Provide default methods min(T, T) and max(T, T) in Comparator interface [v5]

2025-05-27 Thread Roger Riggs
On Sat, 24 May 2025 07:34:39 GMT, Tagir F. Valeev wrote: >> Implementation of Comparator.min and Comparator.max methods. Preliminary >> discussion is in this thread: >> https://mail.openjdk.org/pipermail/core-libs-dev/2025-May/145638.html >> The specification is mostly composed of Math.min/max a

Re: RFR: 8357561: BootstrapLoggerTest does not work on Ubuntu 24 with LANG de_DE.UTF-8 [v2]

2025-05-27 Thread Daniel Fuchs
On Mon, 26 May 2025 08:16:03 GMT, Matthias Baesken wrote: >> On a 'german' Ubuntu 24 (LANG="de_DE.UTF-8") the jtreg test >> java/lang/System/LoggerFinder/internal/BootstrapLogger/BootstrapLoggerTest >> fails with >> >> >> FEIN: hi now! >> java.lang.RuntimeException: System.err does not contai

Re: RFR: 8357597: Proxy.getInvocationHandler throws NullPointerException instead of IllegalArgumentException for null [v2]

2025-05-27 Thread Roger Riggs
On Mon, 26 May 2025 15:48:10 GMT, Steffen Nießing wrote: >> `Proxy#getInvocationHandler(Object)` throws a `NullPointerException` if the >> specified argument is `null`. This PR adds the missing `throws` declaration >> for the NPE. > > Steffen Nießing has updated the pull request incrementally w

Re: RFR: 8356891: Some code simplifications in BigInteger [v23]

2025-05-27 Thread fabioromano1
> Some changes in `Biginteger`s' bit operations that increase the code > readability and slightly optimize the execution time. fabioromano1 has updated the pull request incrementally with one additional commit since the last revision: Removed needless condition Co-authored-by: Raffaello

Re: RFR: 8356891: Some code simplifications in BigInteger [v22]

2025-05-27 Thread fabioromano1
On Tue, 27 May 2025 17:25:25 GMT, Raffaello Giulietti wrote: >> @rgiulietti Because the method assumes that `a` represents a two's >> complement negative integer, so there is at least a sign bit? > > There's only one usage of `makePositive(int[])`, and only when `a[0] < 0`. > And then there's t

Re: RFR: 8356891: Some code simplifications in BigInteger [v22]

2025-05-27 Thread Raffaello Giulietti
On Tue, 27 May 2025 17:14:32 GMT, fabioromano1 wrote: >> src/java.base/share/classes/java/math/BigInteger.java line 4732: >> >>> 4730: /* Allocate output array. If all non-sign ints are 0x00, we >>> must >>> 4731: * allocate space for one extra output int. */ >>> 4732:

Re: RFR: 8357681: Fixed the DigitList::toString method causing incorrect results during debugging

2025-05-27 Thread Naoto Sato
On Sun, 18 May 2025 11:11:32 GMT, Shaojin Wen wrote: > When debugging getLong/getDouble/getDecimal of DigitList, the debugger will > call the DigitList::toString method. At this time, DigitList::toString will > modify tempBuilder, which will cause incorrect results. LGTM - Marked

Re: RFR: 8356891: Some code simplifications in BigInteger [v22]

2025-05-27 Thread fabioromano1
On Tue, 27 May 2025 15:26:42 GMT, Raffaello Giulietti wrote: >> fabioromano1 has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Correct typo in comment > > src/java.base/share/classes/java/math/BigInteger.java line 4732: > >> 4730:

Re: RFR: 8357681: Fixed the DigitList::toString method causing incorrect results during debugging

2025-05-27 Thread Johannes Döbler
On Sun, 18 May 2025 11:11:32 GMT, Shaojin Wen wrote: > When debugging getLong/getDouble/getDecimal of DigitList, the debugger will > call the DigitList::toString method. At this time, DigitList::toString will > modify tempBuilder, which will cause incorrect results. src/java.base/share/classes

Re: RFR: 8356978: Convert unicode sequences in Java source code to UTF-8

2025-05-27 Thread Naoto Sato
On Wed, 14 May 2025 14:29:23 GMT, Magnus Ihse Bursie wrote: > After we converted the source base to be fully UTF-8, we do not need to use > unicode sequences (like \u0123) in string literals. Sometimes, that might > still make sense, as for control characters, non-breaking space, etc. But for

Re: RFR: 8357681: Fixed the DigitList::toString method causing incorrect results during debugging

2025-05-27 Thread Justin Lu
On Sun, 18 May 2025 11:11:32 GMT, Shaojin Wen wrote: > When debugging getLong/getDouble/getDecimal of DigitList, the debugger will > call the DigitList::toString method. At this time, DigitList::toString will > modify tempBuilder, which will cause incorrect results. Change looks good to me, si

Re: RFR: 8356891: Some code simplifications in BigInteger [v22]

2025-05-27 Thread Raffaello Giulietti
On Wed, 21 May 2025 09:12:49 GMT, fabioromano1 wrote: >> Some changes in `Biginteger`s' bit operations that increase the code >> readability and slightly optimize the execution time. > > fabioromano1 has updated the pull request incrementally with one additional > commit since the last revision

Re: RFR: 8357798: ReverseOrderListView uses Boolean boxes after JDK-8356080

2025-05-27 Thread Stuart Marks
On Mon, 26 May 2025 17:08:45 GMT, Aleksey Shipilev wrote: > SonarCloud complains that since > [JDK-8356080](https://bugs.openjdk.org/browse/JDK-8356080) we are using > `Boolean` boxes in `ReverseOrderListView`. This change `boolean` -> `Boolean` > was made in [JDK-8356080](https://bugs.openjdk

Re: RFR: 8357690: Add @Stable and final to java.lang.CharacterDataLatin1 and other CharacterData classes [v2]

2025-05-27 Thread Naoto Sato
On Mon, 26 May 2025 13:19:08 GMT, Shaojin Wen wrote: >> Classes such as java.lang.CharacterDataXXX have multiple static final >> arrays, these are immutable, We should add `@Stable` and final to provide >> information to the optimizer. > > Shaojin Wen has updated the pull request incrementally

Re: RFR: 8356977: UTF-8 cleanups [v2]

2025-05-27 Thread Naoto Sato
On Mon, 26 May 2025 07:44:30 GMT, Magnus Ihse Bursie wrote: >> test/jdk/sun/text/resources/LocaleDataTest.java line 106: >> >>> 104: *FormatData/fr_FR/MonthNames/0=janvier >>> 105: *FormatData/fr_FR/MonthNames/1=février >>> 106: *LocaleNames/fr_FR/US=États-Unis >> >>

Re: RFR: 8356978: Convert unicode sequences in Java source code to UTF-8

2025-05-27 Thread Justin Lu
On Mon, 26 May 2025 08:25:30 GMT, Magnus Ihse Bursie wrote: >> After we converted the source base to be fully UTF-8, we do not need to use >> unicode sequences (like \u0123) in string literals. Sometimes, that might >> still make sense, as for control characters, non-breaking space, etc. But >

Re: RFR: 8356978: Convert unicode sequences in Java source code to UTF-8

2025-05-27 Thread Joe Wang
On Wed, 14 May 2025 14:29:23 GMT, Magnus Ihse Bursie wrote: > After we converted the source base to be fully UTF-8, we do not need to use > unicode sequences (like \u0123) in string literals. Sometimes, that might > still make sense, as for control characters, non-breaking space, etc. But for

Re: RFR: 8356985: Use "stdin.encoding" in Console's read*() methods [v5]

2025-05-27 Thread Naoto Sato
On Mon, 26 May 2025 07:18:59 GMT, Alan Bateman wrote: > I assume you've done some "test repeat" jobs to ensure that any variance in > the version of "expect" on test machines doesn't cause any issues. Actually I have not. Thanks for reminding. So I ran this through our internal CI on Linux x64

Re: RFR: 8356553 : Incorrect uses of {@link} in AbstractQueuedLongSynchronizer and AbstractQueuedSynchronizer

2025-05-27 Thread Nizar Benalla
On Tue, 27 May 2025 09:35:51 GMT, Viktor Klang wrote: > I had to tweak the language a bit to better reflect the intent of the text. Thanks for doing this! There are no longer any links to private types in `java.util.concurrent` - PR Comment: https://git.openjdk.org/jdk/pull/25462#

Re: RFR: 8266013: Unexpected replacement character handling on stateful CharsetEncoder [v2]

2025-05-27 Thread Edoardo Luppi
On Fri, 30 Apr 2021 16:11:30 GMT, Ichiroh Takiguchi wrote: >> When an invalid character is converted by getBytes() method, the character >> is converted to replacement byte data. >> Shift code (SO/SI) may not be added into right place by EBCDIC Mix charset. >> EBCDIC Mix charset encoder is stat

Re: RFR: 8354674: AArch64: Intrinsify Unsafe::setMemory [v8]

2025-05-27 Thread Andrew Haley
On Thu, 15 May 2025 16:03:44 GMT, Andrew Haley wrote: >> This intrinsic is generally faster than the current implementation for >> Panama segment operations for all writes larger than about 8 bytes in size, >> increasing to more than 2* the performance on larger memory blocks on >> Graviton 2,

Re: RFR: 8357531: The `SegmentBulkOperations::fill` method can be improved using overlaps [v5]

2025-05-27 Thread Per Minborg
On Mon, 26 May 2025 15:06:02 GMT, Per Minborg wrote: > > Can we remove all meaningless `!Architecture.isLittleEndian()` calls and > > use the platform-specific endianness unsafe primitives instead? For > > compensation, we can add a check in each of fill2/fill3/fill4 that `assert > > value ==

Re: RFR: 8357145: CRC/Inflater/Deflater/Adler32 methods that take a ByteBuffer throw UOE if backed by shared memory segment

2025-05-27 Thread Alan Bateman
On Tue, 20 May 2025 07:37:34 GMT, Per Minborg wrote: > This PR proposes to use ` JavaNioAccess::getBufferAdress` rather than > `DirectBuffer::address` in the package `java.util.zip` so that `Buffer` > instances backed by `MemorySegment` instances can be used. > > This PR passes tier1, tier2, a

Re: RFR: 8350880: (zipfs) Add support for read-only zip file systems [v4]

2025-05-27 Thread Daniel Fuchs
On Mon, 19 May 2025 12:24:28 GMT, Jaikiran Pai wrote: >> Hello David, I had another look at this code and after going through it, it >> looked like `readOnly` field can in fact be made `final` because of the >> refactoring changes that you did in this PR. I checked out your latest PR >> locall

Withdrawn: 8356706: Foreign tests timeout after passing on linux-x64-zero

2025-05-27 Thread Per Minborg
On Thu, 15 May 2025 09:49:10 GMT, Per Minborg wrote: > This PR improves the robustness of tests on slow machines such as "zero" > variants. The timeout was increased to 10 minutes for both tests. There are > many combinations in `TestAccessModes`, so the test takes some time even on a > fast m

Re: RFR: 8357798: ReverseOrderListView uses Boolean boxes after JDK-8356080

2025-05-27 Thread Chen Liang
On Mon, 26 May 2025 17:08:45 GMT, Aleksey Shipilev wrote: > SonarCloud complains that since > [JDK-8356080](https://bugs.openjdk.org/browse/JDK-8356080) we are using > `Boolean` boxes in `ReverseOrderListView`. This change `boolean` -> `Boolean` > was made in [JDK-8356080](https://bugs.openjdk

Integrated: 8356443: Update open/test/jdk/TEST.groups manual test groups definitions with missing manual test

2025-05-27 Thread serhiysachkov
On Wed, 21 May 2025 15:37:34 GMT, serhiysachkov wrote: > Update open/test/jdk/TEST.groups manual test groups definitions with missing > manual test This pull request has now been integrated. Changeset: b4b11d77 Author:Serhiy Sachkov Committer: Mark Sheppard URL: https://git.openjd

Re: RFR: 8357798: ReverseOrderListView uses Boolean boxes after JDK-8356080

2025-05-27 Thread Aleksey Shipilev
On Tue, 27 May 2025 11:33:28 GMT, Chen Liang wrote: > If we do use byte, please add constant static final fields instead of magic > that requires navigation from pass site to fields. My initial version did this, and IMO it was worse off: https://github.com/openjdk/jdk/pull/25456/commits/06d3f

Re: RFR: 8357531: The `SegmentBulkOperations::fill` method can be improved using overlaps [v6]

2025-05-27 Thread Per Minborg
> This PR builds on a concept John Rose told me about some time ago. Instead of > combining memory operations of various sizes, a single large and skewed > memory operation can be made to clean up the tail of remaining bytes. > > This has the effect of simplifying and shortening the code. The nu

Re: RFR: 8350880: (zipfs) Add support for read-only zip file systems [v14]

2025-05-27 Thread David Beaumont
> Adding read-only support to ZipFileSystem. > > The new `accessMode` environment property allows for readOnly and readWrite > values, and ensures that the requested mode is consistent with what's > returned. > > This involved a little refactoring to ensure that "read only" state was set > ini

Re: RFR: 8356443: Update open/test/jdk/TEST.groups manual test groups definitions with missing manual test

2025-05-27 Thread duke
On Wed, 21 May 2025 15:37:34 GMT, serhiysachkov wrote: > Update open/test/jdk/TEST.groups manual test groups definitions with missing > manual test @serhiysachkov Your change (at version a977e3ca9cc40f0a2af2d8faaf5cfd8adace60f2) is now ready to be sponsored by a Committer. - PR

Re: RFR: 8357798: ReverseOrderListView uses Boolean boxes after JDK-8356080

2025-05-27 Thread Chen Liang
On Mon, 26 May 2025 17:08:45 GMT, Aleksey Shipilev wrote: > SonarCloud complains that since > [JDK-8356080](https://bugs.openjdk.org/browse/JDK-8356080) we are using > `Boolean` boxes in `ReverseOrderListView`. This change `boolean` -> `Boolean` > was made in [JDK-8356080](https://bugs.openjdk

Re: RFR: 8356443: Update open/test/jdk/TEST.groups manual test groups definitions with missing manual test

2025-05-27 Thread Mark Sheppard
On Wed, 21 May 2025 15:37:34 GMT, serhiysachkov wrote: > Update open/test/jdk/TEST.groups manual test groups definitions with missing > manual test Marked as reviewed by msheppar (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/25360#pullrequestreview-2870691165

Re: RFC: 8357183: Improving efficiency of Writer::append(CharSequence) and Writer::append(CharSequence, int, int) / Sub Task of 8356679: Using CharSequence::getChars internally

2025-05-27 Thread Markus KARG
Writer was retrofitted to implement Appendable in JDK 5 with the 3-arg append documented to behave "in exactly the same as ..." the write(String) method. That's 20 years of subclasses that might be depending on this behavior. Also 20 years of subclasses that may depend on the 3-arg append cal

Re: RFR: 8357531: The `SegmentBulkOperations::fill` method can be improved using overlaps [v5]

2025-05-27 Thread Andrey Turbanov
On Thu, 22 May 2025 11:52:34 GMT, Per Minborg wrote: >> This PR builds on a concept John Rose told me about some time ago. Instead >> of combining memory operations of various sizes, a single large and skewed >> memory operation can be made to clean up the tail of remaining bytes. >> >> This h

Re: RFR: 8352565: Add native method implementation of Reference.get() [v7]

2025-05-27 Thread Kim Barrett
> Please review this change which adds a native method providing the > implementation of Reference::get. Referece::get is an intrinsic candidate, so > this native method implementation is only used when the intrinsic is not. > > Currently there is intrinsic support by the interpreter, C1, C2, and

Integrated: 8357797: Use StructuredTaskScopeImpl.ST_NEW for state init

2025-05-27 Thread Aleksey Shipilev
On Mon, 26 May 2025 16:37:01 GMT, Aleksey Shipilev wrote: > SonarCloud complains `ST_NEW` constant is not used. Looks to me the > constructor implicitly relies on default value for `state`. It would be > cleaner to initialize it explicitly > > Additional testing: > - [x] Linux x86_64 server f

Re: RFR: 8357797: Use StructuredTaskScopeImpl.ST_NEW for state init [v2]

2025-05-27 Thread Aleksey Shipilev
On Mon, 26 May 2025 17:17:30 GMT, Aleksey Shipilev wrote: >> SonarCloud complains `ST_NEW` constant is not used. Looks to me the >> constructor implicitly relies on default value for `state`. It would be >> cleaner to initialize it explicitly >> >> Additional testing: >> - [x] Linux x86_64 se

Re: Add `@Stable` to BigInteger and BigDecimal

2025-05-27 Thread Jaikiran Pai
Is this a duplicate of what's already being discussed here https://mail.openjdk.org/pipermail/core-libs-dev/2025-May/146692.html? -Jaikiran On 27/05/25 2:24 pm, wenshao wrote: Some final arrays of BigInteger and BigDecimal are stable and immutable. We should add `@Stable` to give the optimizer

RFR: 8356553 : Incorrect uses of {@link} in AbstractQueuedLongSynchronizer and AbstractQueuedSynchronizer

2025-05-27 Thread Viktor Klang
I had to tweak the language a bit to better reflect the intent of the text. - Commit messages: - Updating the Javadoc of AQS and AQLS to link to a public version of the method Changes: https://git.openjdk.org/jdk/pull/25462/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=2

Re: RFR: 8350880: (zipfs) Add support for read-only zip file systems [v13]

2025-05-27 Thread David Beaumont
> Adding read-only support to ZipFileSystem. > > The new `accessMode` environment property allows for readOnly and readWrite > values, and ensures that the requested mode is consistent with what's > returned. > > This involved a little refactoring to ensure that "read only" state was set > ini

Integrated: 8357647 : Stream gatherers forward upstream size information to downstream

2025-05-27 Thread Viktor Klang
On Fri, 23 May 2025 15:15:30 GMT, Viktor Klang wrote: > While it could be argued that unbounded Spliterators should not report SIZED > / SUBSIZED, GatherSink should report an unknown emission size, so switching > to downstream.begin(-1) rather than downstream.begin(size). > > Includes a regres

Re: RFR: 8357561: BootstrapLoggerTest does not work on Ubuntu 24 with LANG de_DE.UTF-8 [v2]

2025-05-27 Thread Matthias Baesken
On Mon, 26 May 2025 08:16:03 GMT, Matthias Baesken wrote: >> On a 'german' Ubuntu 24 (LANG="de_DE.UTF-8") the jtreg test >> java/lang/System/LoggerFinder/internal/BootstrapLogger/BootstrapLoggerTest >> fails with >> >> >> FEIN: hi now! >> java.lang.RuntimeException: System.err does not contai

Add `@Stable` to BigInteger and BigDecimal

2025-05-27 Thread wenshao
Some final arrays of BigInteger and BigDecimal are stable and immutable. We should add `@Stable` to give the optimizer more information - Shaojin Wen

Integrated: 8353124: java/lang/Thread/virtual/stress/Skynet.java#Z times out on macosx-x64-debug

2025-05-27 Thread Michael McMahon
On Tue, 20 May 2025 15:25:52 GMT, Michael McMahon wrote: > Hi, > > This is a simple test update which increases a timeout from 300s to 400 to > account for slow mac os test machines. > A repeat 50 test of :jdk_lang passes. I will run this a few more times before > pushing, if the change is acc

Re: RFR: 8353124: java/lang/Thread/virtual/stress/Skynet.java#Z times out on macosx-x64-debug [v2]

2025-05-27 Thread Alan Bateman
On Tue, 27 May 2025 08:16:32 GMT, Michael McMahon wrote: >> Hi, >> >> This is a simple test update which increases a timeout from 300s to 400 to >> account for slow mac os test machines. >> A repeat 50 test of :jdk_lang passes. I will run this a few more times >> before pushing, if the change

Re: RFR: 8353124: java/lang/Thread/virtual/stress/Skynet.java#Z times out on macosx-x64-debug [v2]

2025-05-27 Thread Michael McMahon
> Hi, > > This is a simple test update which increases a timeout from 300s to 400 to > account for slow mac os test machines. > A repeat 50 test of :jdk_lang passes. I will run this a few more times before > pushing, if the change is acceptable. > > Thanks, > Michael Michael McMahon has update

Re: RFR: 8357798: ReverseOrderListView allocates Boolean boxes

2025-05-27 Thread Aleksey Shipilev
On Tue, 27 May 2025 07:45:35 GMT, Alan Bateman wrote: > Does SonarCloud scan source code or class files? I'm wondering if there is > anything to feedback to them on this report. I think both. But as I said, I misunderstood the report: it tells me we are using a boxed `Boolean`, likely unnecess

Re: RFR: 8357798: ReverseOrderListView allocates Boolean boxes

2025-05-27 Thread Alan Bateman
On Mon, 26 May 2025 17:08:45 GMT, Aleksey Shipilev wrote: > SonarCloud complains that since > [JDK-8356080](https://bugs.openjdk.org/browse/JDK-8356080) we are using > `Boolean` boxes in `ReverseOrderListView`. This change `boolean` -> `Boolean` > was made in [JDK-8356080](https://bugs.openjdk

Re: RFR: 8357798: ReverseOrderListView allocates Boolean boxes

2025-05-27 Thread Aleksey Shipilev
On Mon, 26 May 2025 19:01:35 GMT, Chen Liang wrote: > How is this an allocation? I examined `javap -c -p -v > java.util.ReverseOrderListView` and confirmed this compiles to > `Boolean.valueOf` in class files, which involves no new allocation. Yeah, I brain-fogged a little here. Still, it makes

Re: RFR: 8357798: ReverseOrderListView allocates Boolean boxes

2025-05-27 Thread ExE Boss
On Mon, 26 May 2025 17:08:45 GMT, Aleksey Shipilev wrote: > SonarCloud complains that since > [JDK-8356080](https://bugs.openjdk.org/browse/JDK-8356080) we are allocating > and using `Boolean` boxes in `ReverseOrderListView`. This change `boolean` -> > `Boolean` was made in > [JDK-8356080](ht