On Sat, 10 May 2025 20:38:36 GMT, Archie Cobbs wrote:
> FYI, this issue now effectively fixes [JDK-7004476 Lint.LintCategory should
> support aliases](https://bugs.openjdk.org/browse/JDK-7004476), which happened
> to be closed as "Rejected" on Monday. Not sure if anything needs to be done.
I g
> The recent patch #23866 makes calling `ClassValue::remove()` from
> `ClassValue::computeValue()` end up in infinite loops while fixing the stale
> value risk from the method.
>
> The proposed fix is to preserve the stale value risk fix, and update the
> remove-from-compute behavior from the o
On Sat, 10 May 2025 20:28:39 GMT, Vicente Romero wrote:
>> This PR is defining a new internal annotation,
>> `@jdk.internal.RequiresIdentity`, with target types PARAMETER and
>> TYPE_PARAMETER. The @RequiresIdentity annotation expresses the expectation
>> that an argument to a given method or
On Sat, 10 May 2025 19:36:52 GMT, Chen Liang wrote:
> As much as I dislike streams, I think we will probably keep them for their
> conciseness except this one, which made things less concise.
thanks! committed
-
PR Comment: https://git.openjdk.org/jdk/pull/24746#issuecomment-28691
> This PR is defining a new internal annotation,
> `@jdk.internal.RequiresIdentity`, with target types PARAMETER and
> TYPE_PARAMETER. The @RequiresIdentity annotation expresses the expectation
> that an argument to a given method or constructor parameter will be an object
> with a unique ident
On Sat, 10 May 2025 19:32:16 GMT, Chen Liang wrote:
>> Vicente Romero has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - additional changes from Archie
>> - removing dead code
>
> src/jdk.compiler/share/classes/com/sun/tools/javac/code/L
On Sat, 10 May 2025 16:39:38 GMT, Vicente Romero wrote:
>> This PR is defining a new internal annotation,
>> `@jdk.internal.RequiresIdentity`, with target types PARAMETER and
>> TYPE_PARAMETER. The @RequiresIdentity annotation expresses the expectation
>> that an argument to a given method or
> Refactor jpackage to separate the configuration and execution phases.
> At the configuration phase, jpackage parses command-line arguments and
> validates them.
> At the execution phase, jpackage builds a bundle based on data collected at
> the configuration phase.
>
> There was no clear separ
On Sat, 10 May 2025 16:03:37 GMT, Vicente Romero wrote:
> > heh, I was doing the same, thanks anyway :)
>
> Awesome, thanks!
>
> Apologies for the mid-air collision :) I've merged your latest merge into my
> merge, leaving just a few minor fixes.
thanks!
-
PR Comment: https://gi
> This PR is defining a new internal annotation,
> `@jdk.internal.RequiresIdentity`, with target types PARAMETER and
> TYPE_PARAMETER. The @RequiresIdentity annotation expresses the expectation
> that an argument to a given method or constructor parameter will be an object
> with a unique ident
On Sat, 10 May 2025 15:31:45 GMT, Vicente Romero wrote:
>> This PR is defining a new internal annotation,
>> `@jdk.internal.RequiresIdentity`, with target types PARAMETER and
>> TYPE_PARAMETER. The @RequiresIdentity annotation expresses the expectation
>> that an argument to a given method or
On Sat, 10 May 2025 15:31:45 GMT, Vicente Romero wrote:
>> This PR is defining a new internal annotation,
>> `@jdk.internal.RequiresIdentity`, with target types PARAMETER and
>> TYPE_PARAMETER. The @RequiresIdentity annotation expresses the expectation
>> that an argument to a given method or
On Sat, 10 May 2025 15:41:18 GMT, Archie Cobbs wrote:
> > heh, I was doing the same, thanks anyway :)
>
> Awesome, thanks!
>
> Apologies for the mid-air collision :) I've merged your latest merge into my
> merge, leaving just a few minor fixes.
thanks!
-
PR Comment: https://git.
On Sat, 10 May 2025 15:31:17 GMT, Chen Liang wrote:
> Thanks. Looks good, but the Lint to all option names streaming can be
> replaced by the static map lookup/iteration.
Good point... I prototyped that in commit be160a3261b.
-
PR Comment: https://git.openjdk.org/jdk/pull/24746#is
On Sat, 10 May 2025 15:35:16 GMT, Vicente Romero wrote:
> heh, I was doing the same, thanks anyway :)
Awesome, thanks!
Apologies for the mid-air collision :) I've merged your latest merge into my
merge, leaving just a few minor fixes.
-
PR Comment: https://git.openjdk.org/jdk/pul
On Sat, 10 May 2025 15:31:17 GMT, Chen Liang wrote:
>> Vicente Romero has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> fixing bugs, removing dead code
>
> Thanks. Looks good, but the Lint to all option names streaming can be
> replaced b
On Sat, 10 May 2025 14:32:10 GMT, Chen Liang wrote:
>>> I have asked @nizarbenalla in offline communications for a list of failing
>>> hotspot tests. I aim to update them on a case-by-case basis, to determine
>>> if the compile arguments should provide a `--release ` argument or
>>> migrate cl
> This PR is defining a new internal annotation,
> `@jdk.internal.RequiresIdentity`, with target types PARAMETER and
> TYPE_PARAMETER. The @RequiresIdentity annotation expresses the expectation
> that an argument to a given method or constructor parameter will be an object
> with a unique ident
On Sat, 10 May 2025 15:24:52 GMT, Archie Cobbs wrote:
>>> That's why I was offering my existing patch which basically does that
>>> already. But it's OK to wait if you prefer.
>>
>> Sure, I think vicente is open to patches and PRs to his fork. And I can help
>> review; just remember to @liach.
On Fri, 9 May 2025 20:28:12 GMT, Vicente Romero wrote:
>> This PR is defining a new internal annotation,
>> `@jdk.internal.RequiresIdentity`, with target types PARAMETER and
>> TYPE_PARAMETER. The @RequiresIdentity annotation expresses the expectation
>> that an argument to a given method or c
On Fri, 9 May 2025 22:39:19 GMT, Chen Liang wrote:
> Sure, I think vicente is open to patches and PRs to his fork. And I can help
> review; just remember to @liach.
OK thanks. I've rebased my changes on @vicente-romero-oracle's branch to simply
any evaluation. [Here's the
diff](https://github
On Fri, 2 May 2025 17:19:11 GMT, Joe Darcy wrote:
>> I have asked @nizarbenalla in offline communications for a list of failing
>> hotspot tests. I aim to update them on a case-by-case basis, to determine if
>> the compile arguments should provide a `--release ` argument or migrate
>> class fi
> This PR implements nth root computation for BigIntegers using Newton method.
fabioromano1 has updated the pull request incrementally with two additional
commits since the last revision:
- Merge branch 'nth-root-branch' of https://github.com/fabioromano1/jdk into
nth-root-branch
- Restore nt
> This PR implements nth root computation for BigIntegers using Newton method.
fabioromano1 has updated the pull request with a new target base due to a merge
or a rebase. The pull request now contains 44 commits:
- Merge branch 'openjdk:master' into nth-root-branch
- Update to resolve conflic
> In BufferedReader.readLine and other similar scenarios, we need to use
> StringBuilder.append(char[]) to build the string.
>
> For these scenarios, we can use the intrinsic method StringUTF16.compress and
> Unsafe.copyMemory instead of the character copy of the char-by-char loop to
> improve
> See the JBS bug for some details.
Raffaello Giulietti has updated the pull request incrementally with one
additional commit since the last revision:
Addressed reviewer comments.
-
Changes:
- all: https://git.openjdk.org/jdk/pull/22737/files
- new: https://git.openjdk.org/jd
On Fri, 9 May 2025 22:58:19 GMT, Chen Liang wrote:
>> Raffaello Giulietti has updated the pull request with a new target base due
>> to a merge or a rebase. The incremental webrev excludes the unrelated
>> changes brought in by the merge/rebase. The pull request contains 14
>> additional commi
27 matches
Mail list logo
