On Sun, 4 May 2025 20:36:07 GMT, Chen Liang wrote:
> In this situation, how can we ensure a renewed discussion will actually
> attract attention? I think our guide should suggest a solution to this, like
> "prmopting a thread after 2 weeks of no reply"?
The mailing list is the right place to g
On Mon, 5 May 2025 04:50:30 GMT, Chen Liang wrote:
>> Credit to @lukellmann that the duplication arg handling in #24742 avoided
>> throwing exceptions but produced a wrong option. This patch fixes that and
>> removed stream usages in CaptureCallState to speed up bootstrap.
>>
>> Also, the prev
> Credit to @lukellmann that the duplication arg handling in #24742 avoided
> throwing exceptions but produced a wrong option. This patch fixes that and
> removed stream usages in CaptureCallState to speed up bootstrap.
>
> Also, the previous patch affected the toString display of the option; I
> Credit to @lukellmann that the duplication arg handling in #24742 avoided
> throwing exceptions but produced a wrong option. This patch fixes that and
> removed stream usages in CaptureCallState to speed up bootstrap.
>
> Also, the previous patch affected the toString display of the option; I
> Credit to @lukellmann that the duplication arg handling in #24742 avoided
> throwing exceptions but produced a wrong option. This patch fixes that and
> removed stream usages in CaptureCallState to speed up bootstrap.
>
> Also, the previous patch affected the toString display of the option; I
On Tue, 29 Apr 2025 15:56:59 GMT, Vladimir Kozlov wrote:
>> Ioi Lam has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> @vnkozlov comments
>
> src/hotspot/share/cds/metaspaceShared.cpp line 1068:
>
>> 1066: }
>> 1067:
>> 1068: // Pass
On Tue, 29 Apr 2025 15:48:12 GMT, Vladimir Kozlov wrote:
> JEP and CSR call env var :`JAVA_AOT_OPTIONS`. This description and changes
> call it `AOT_TOOL_OPTIONS`. Please, fix.
Fixed.
-
PR Comment: https://git.openjdk.org/jdk/pull/24942#issuecomment-2849668130
> This is the implementation of the draft [JEP: Ahead-of-time Command Line
> Ergonomics](https://bugs.openjdk.org/browse/JDK-8350022)
>
> - Implemented new flag `AOTCacheOutput`, which can be used to create an AOT
> cache using the "one-command workflow"
> - Added processing of the `JAVA_AOT_OPT
> This is the implementation of the draft [JEP: Ahead-of-time Command Line
> Ergonomics](https://bugs.openjdk.org/browse/JDK-8350022)
>
> - Implemented new flag `AOTCacheOutput`, which can be used to create an AOT
> cache using the "one-command workflow"
> - Added processing of the `JAVA_AOT_OPT
On Tue, 29 Apr 2025 04:50:42 GMT, Ioi Lam wrote:
> This is the implementation of the draft [JEP: Ahead-of-time Command Line
> Ergonomics](https://bugs.openjdk.org/browse/JDK-8350022)
>
> - Implemented new flag `AOTCacheOutput`, which can be used to create an AOT
> cache using the "one-command
This is the implementation of the draft [JEP: Ahead-of-time Command Line
Ergonomics](https://bugs.openjdk.org/browse/JDK-8350022)
- Implemented new flag `AOTCacheOutput`, which can be used to create an AOT
cache using the "one-command workflow"
- Added processing of the `AOT_TOOL_OPTIONS` enviro
On Sun, 4 May 2025 22:51:21 GMT, Luca Kellermann wrote:
>> Credit to @lukellmann that the duplication arg handling in #24742 avoided
>> throwing exceptions but produced a wrong option. This patch fixes that and
>> removed stream usages in CaptureCallState to speed up bootstrap.
>>
>> Also, the
On Fri, 25 Oct 2024 01:49:01 GMT, Alexander Matveev
wrote:
> - It is not clear on which macOS versions codesign fails if application
> bundle contains additional content.
> - As a result test was modified to generate only application image, since PKG
> or DMG cannot be generated if signing fai
On Sun, 4 May 2025 22:37:21 GMT, Chen Liang wrote:
> Credit to @lukellmann that the duplication arg handling in #24742 avoided
> throwing exceptions but produced a wrong option. This patch fixes that and
> removed stream usages in CaptureCallState to speed up bootstrap.
>
> Also, the previous
> On May 4, 2025, at 1:12 PM, Christoph wrote:
>
> In subcomponent:
> /private/var/folders/hn/k7g0_sh57112t0xtjxcjcm5rgn/T/jdk.jpackage2295206181121069675/images/image-11269735772913219400/JabRef.app/Contents/***Host.py
If this is the current error log the file ***Host.py (? Strange file
Credit to @lukellmann that the duplication arg handling in #24742 avoided
throwing exceptions but produced a wrong option. This patch fixes that and
removed stream usages in CaptureCallState to speed up bootstrap.
Also, the previous patch affected the toString display of the option; I added a
u
On Sun, 4 May 2025 21:43:40 GMT, Chen Liang wrote:
>> Hmm, I intentionally checked `toSet` does not reject duplicates but forgot
>> about this part. Anyways this stream code is problematic; will fix this in a
>> patch that removes this stream code wholesale.
>
> I created an issue to revisit Ca
On Sun, 4 May 2025 20:25:02 GMT, Chen Liang wrote:
>> src/java.base/share/classes/java/lang/foreign/Linker.java line 866:
>>
>>> 864: .map(CapturableState::forName)
>>> 865: .mapToInt(state -> 1 << state.ordinal())
>>> 866: .sum();
>>
> Sometimes, for version-specific feature access APIs, we wish to access the
> preview features of the current Java SE release. To reduce the impact of
> adding one preview-specific version on every site, we can add a constant
> modeling the preview features as a fake version.
Chen Liang has up
On Sun, 4 May 2025 20:33:36 GMT, Luca Kellermann wrote:
>> Don't know why you recommend this, but this aims to explain why this API is
>> reflective preview API instead of an essential preview API (that does not
>> have `reflective = true`). Particular tools wish to perform this specific
>> ch
On Sun, 4 May 2025 18:39:24 GMT, Alan Bateman wrote:
> start a discussion on core-libs-dev
Threads about this topic have been started multiple times but failed to attract
any attention on this topic, not even a rejection:
-
https://mail.openjdk.org/pipermail/core-libs-dev/2024-December/thread.
On Sun, 4 May 2025 20:29:18 GMT, Chen Liang wrote:
>> src/java.base/share/classes/java/lang/reflect/ClassFileFormatVersion.java
>> line 413:
>>
>>> 411: * ensure the program is compatible with future Java SE releases.
>>> 412: *
>>> 413: * This is a reflective preview API to all
On Sun, 4 May 2025 18:46:02 GMT, Luca Kellermann wrote:
>> Chen Liang has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains four commits:
>>
>> - Don't need to update latestSupported later
>>
>> - Merge branch 'pr/25015' of https:
> Sometimes, for version-specific feature access APIs, we wish to access the
> preview features of the current Java SE release. To reduce the impact of
> adding one preview-specific version on every site, we can add a constant
> modeling the preview features as a fake version.
Chen Liang has up
On Sun, 4 May 2025 19:35:15 GMT, Luca Kellermann wrote:
>> Chen Liang has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains five additional
>> commits
On Mon, 28 Apr 2025 14:36:33 GMT, Chen Liang wrote:
>> Perf numbers for simple main:
>> Linking of `Class::forName0` down from ~152 to ~83
>>
>> For calling little color management system
>> https://bugs.openjdk.org/browse/JDK-8313344:
>> JNI: ~45
>> baseline panama: ~164
>> patch: ~103
>>
>>
On Sat, 25 Jan 2025 07:25:40 GMT, Shaojin Wen wrote:
> Continue to complete PR #16006 and PR #21593 to improve BigDecimal::toString
> and BigDecimal::toPlainString performance and reduce duplicate code
This pull request has been closed without being integrated.
-
PR: https://git.o
On Fri, 31 Jan 2025 10:29:53 GMT, Shaojin Wen wrote:
> By using the Class File API to dynamically generate a CompositePrinterParser,
> and defining DateTimePrinterParser[] printerParsers as a specific field, C2
> can do TypeProfile optimization.
>
> Since the CompositePrinterParser is generate
On Mon, 3 Feb 2025 18:51:20 GMT, Shaojin Wen wrote:
> The following code can reproduce the problem, writing out of bounds causes
> JVM Crash
>
>
> StringBuilder buf = new StringBuilder();
> buf.append('中');
>
> Thread[] threads = new Thread[40];
> final CountD
On Sat, 3 May 2025 01:08:17 GMT, Chen Liang wrote:
>> Sometimes, for version-specific feature access APIs, we wish to access the
>> preview features of the current Java SE release. To reduce the impact of
>> adding one preview-specific version on every site, we can add a constant
>> modeling t
On Sun, 4 May 2025 16:21:41 GMT, Markus KARG wrote:
>> This Pull Requests proposes an implementation for
>> [JDK-8353795](https://bugs.openjdk.org/browse/JDK-8353795): Adding the new
>> method `public static Writer Writer.of(StringBuilder)`, providing a
>> non-synchronized Writer implementatio
On Fri, 25 Oct 2024 01:49:01 GMT, Alexander Matveev
wrote:
> - It is not clear on which macOS versions codesign fails if application
> bundle contains additional content.
> - As a result test was modified to generate only application image, since PKG
> or DMG cannot be generated if signing fai
On Thu, 1 May 2025 19:05:50 GMT, Stuart Marks wrote:
> Collections.synchronizedList() returns a List implementation that doesn't do
> proper locking. This PR does the following on the synchronized wrapper:
>
> - overrides and adds locking to SequencedCollection methods;
> - performs instance ma
On Sat, 3 May 2025 21:16:39 GMT, Michael Hall wrote:
> If the same parameters are always used indicating the parameters for each
> message probably isn?t needed.
The same parameters don't need to be logged, but having the complete list of
files signed by jpackage in the log would be good. We d
On Tue, 29 Apr 2025 11:35:29 GMT, Oliver Kopp wrote:
>> - It is not clear on which macOS versions codesign fails if application
>> bundle contains additional content.
>> - As a result test was modified to generate only application image, since
>> PKG or DMG cannot be generated if signing fails.
On Sun, 4 May 2025 16:45:11 GMT, Steffen Nießing wrote:
> This PR fixes a typo in the bytecode cast for Lookup.findGetter.
Just a tip for a newcomer: (Welcome!)
It may be useful to flag this PR as “trivial” and “documentation-only” by
saying something like “Please review this trivial, document
On Sun, 4 May 2025 16:45:11 GMT, Steffen Nießing wrote:
> This PR fixes a typo in the bytecode cast for Lookup.findGetter.
Nit: Would be nice if the PR title/description made it clear for the casual
reader that this is a documentation/Javadoc typo, as opposed to a code issue.
-
PR
On Sun, 4 May 2025 16:45:11 GMT, Steffen Nießing wrote:
> This PR fixes a typo in the bytecode cast for Lookup.findGetter.
Thanks for the mailing list communication and reply.
Check out https://openjdk.org/guide/ for more steps. For example, a patch
should usually wait 24 hours for sufficient
On Sun, 4 May 2025 14:49:35 GMT, Chen Liang wrote:
> ...you can start drafting a CSR like that for `getChars` for `CharSequence`.
Done. Kindly asking your review for the CSR:
https://bugs.openjdk.org/browse/JDK-8356123.
> One concern is that (See `HashMap.newHashMap` vs `HashMap.of`)
> `XxxWr
This PR fixes a typo in the bytecode cast for Lookup.findGetter.
-
Commit messages:
- 8356119: Correct field type for bytecode cast
Changes: https://git.openjdk.org/jdk/pull/25024/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=25024&range=00
Issue: https://bugs.openjdk.o
> This Pull Requests proposes an implementation for
> [JDK-8353795](https://bugs.openjdk.org/browse/JDK-8353795): Adding the new
> method `public static Writer Writer.of(StringBuilder)`, providing a
> non-synchronized Writer implementation optimized for writing into
> `StringBuilder`.
>
> A ba
On Sun, 4 May 2025 14:52:39 GMT, Chen Liang wrote:
>> Markus KARG has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Undone copyright update of otherwise unchanged file.
>> - Update Of.java
>>
>>Applied changnes proposed by @liac
On Sat, 5 Apr 2025 17:36:29 GMT, Markus KARG wrote:
> This Pull Requests proposes an implementation for
> [JDK-8353795](https://bugs.openjdk.org/browse/JDK-8353795): Adding the new
> method `public static Writer Writer.of(StringBuilder)`, providing a
> non-synchronized Writer implementation op
On Sat, 5 Apr 2025 17:36:29 GMT, Markus KARG wrote:
> This Pull Requests proposes an implementation for
> [JDK-8353795](https://bugs.openjdk.org/browse/JDK-8353795): Adding the new
> method `public static Writer Writer.of(StringBuilder)`, providing a
> non-synchronized Writer implementation op
On Sat, 5 Apr 2025 17:36:29 GMT, Markus KARG wrote:
> This Pull Requests proposes an implementation for
> [JDK-8353795](https://bugs.openjdk.org/browse/JDK-8353795): Adding the new
> method `public static Writer Writer.of(StringBuilder)`, providing a
> non-synchronized Writer implementation op
On Fri, 2 May 2025 08:11:05 GMT, Matthias Baesken wrote:
>> src/hotspot/share/sanitizers/ub.hpp line 39:
>>
>>> 37: #define ATTRIBUTE_NO_UBSAN
>>> __attribute__((no_sanitize("undefined","float-divide-by-zero")))
>>> 38: #endif
>>> 39: #if defined(__GNUC__) && !defined(__clang__)
>>
>> Maybe us
On Wed, 30 Apr 2025 13:04:18 GMT, Matthias Baesken wrote:
> Seems the currently used ATTRIBUTE_NO_UBSAN does not handle the exclusion of
> float divisions by zero.
> At least this is the case on AIX.
>
> (seen in the jtreg test java/lang/Math/PowTests.java )
LGTM.
-
Marked as rev
47 matches
Mail list logo
