On Mon, 14 Apr 2025 18:09:35 GMT, Chen Liang wrote:
>> Hello Per, I'm not too familiar with runtime compiler optimizations. So
>> consider this as a basic question.
>>
>>> This means the VM can trust these fields to never change which enables
>>> constant folding optimizations.
>>
>> If I'm
On Thu, 17 Apr 2025 20:51:10 GMT, Chen Liang wrote:
>> When jdeps was migrated from old classfile to ClassFile API, the parsing
>> semantic changed - error checks are now made lazily, and nested crashes from
>> malformed signature or other problems is now latent, after a `ClassModel`
>> instan
On Thu, 17 Apr 2025 20:51:10 GMT, Chen Liang wrote:
>> When jdeps was migrated from old classfile to ClassFile API, the parsing
>> semantic changed - error checks are now made lazily, and nested crashes from
>> malformed signature or other problems is now latent, after a `ClassModel`
>> instan
On Fri, 18 Apr 2025 04:08:56 GMT, Alexey Bakhtin wrote:
> Please find a trivial fix for the missing `cvc-complex-type.2.4.d.1` resource
> in the main XMLSchemaMessages.properties file.
This pull request has now been integrated.
Changeset: 4f58af0a
Author:Alexey Bakhtin
URL:
https:/
On Fri, 18 Apr 2025 22:15:10 GMT, Alexey Bakhtin wrote:
>> Please find a trivial fix for the missing `cvc-complex-type.2.4.d.1`
>> resource in the main XMLSchemaMessages.properties file.
>
> Alexey Bakhtin has updated the pull request incrementally with one additional
> commit since the last re
> This PR implements nth root computation for `BigInteger`s using Newton method
> and optimizes `BigInteger.pow(int)` method.
> [Here is a proof of convergence of the recurrence
> used.](https://github.com/user-attachments/files/19785045/nth_root_newton_proof_integers.pdf)
fabioromano1 has updat
> Please find a trivial fix for the missing `cvc-complex-type.2.4.d.1` resource
> in the main XMLSchemaMessages.properties file.
Alexey Bakhtin has updated the pull request incrementally with one additional
commit since the last revision:
Backout "Add locolizations for _de, _ja and _zh_CN"
> Some AccessFlag parsing methods throw IAE because a flag mask is not valid in
> a location. However, there is no easy way to check what flag mask bits or
> what flags are valid for a location. We need such APIs to check, specific to
> each class file format version.
>
> Also in the investigat
On Fri, 18 Apr 2025 17:40:10 GMT, Joe Wang wrote:
>> Added missed localized strings for _de, _ja and _zh_CN localities based on
>> the JDK11 localizations
>
>> Added missed localized strings for _de, _ja and _zh_CN localities based on
>> the JDK11 localizations
>
> Probably not necessary as th
On Mon, 14 Apr 2025 14:47:59 GMT, Per Minborg wrote:
> This PR proposes to add the `@Stable` annotation to `j.l.String.hash` and
> `j.l.String.hashIsZero`. This means the VM can trust these fields to never
> change which enables constant folding optimizations.
>
> This PR is tested in tier1, t
On Fri, 18 Apr 2025 21:26:23 GMT, Joe Wang wrote:
>> Fix a NPE on calling DocumentBuilderFactory::getAttribute, refer to the bug
>> report.
>>
>> Also in this patch: consolidates get and set properties to use the same Util
>> methods to reduce potential errors when code changes.
>>
>> Test:
>
Add tests for the following test cases:
- Expired certificate specified for signing;
- Multiple certificates with the same name in one keychain.
Adding the new tests revealed an issue with MacCertificate -
[JDK-8354989](https://bugs.openjdk.org/browse/JDK-8354989). This issue is also
addressed
On Fri, 18 Apr 2025 20:06:01 GMT, Naoto Sato wrote:
>> Joe Wang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> remove unused variable pName; remove unused imports
>
> src/java.xml/share/classes/com/sun/org/apache/xerces/internal/impl/Pr
> Fix a NPE on calling DocumentBuilderFactory::getAttribute, refer to the bug
> report.
>
> Also in this patch: consolidates get and set properties to use the same Util
> methods to reduce potential errors when code changes.
>
> Test:
> Tier1 - 3 passed
> JCK test passed
Joe Wang has u
On Fri, 18 Apr 2025 19:11:15 GMT, Roger Riggs wrote:
> Without over-rotating on performance concerns, [...]
Or just for the sake of silliness:
public List readAllLines() throws IOException {
String regex = "(?:\n)|(?:\r)|\r(?=\n)";
return Arrays.asList(readString().split(reg
Take the class file version to reject flags not yet defined, redefined, or
obsoleted. The non-cffv version can return the preview flags when the current
runtime is in preview.
-
Depends on: https://git.openjdk.org/jdk/pull/23095
Commit messages:
- 8297271: AccessFlag.maskToAccessF
> Implement the requested methods and add a test thereof.
Brian Burkhalter has updated the pull request incrementally with one additional
commit since the last revision:
8354724: Remove unused import
-
Changes:
- all: https://git.openjdk.org/jdk/pull/24728/files
- new: https:
On Thu, 17 Apr 2025 17:41:56 GMT, Joe Wang wrote:
> Fix a NPE on calling DocumentBuilderFactory::getAttribute. This issue was
> found during the previous JCK test (JCK-7322355). The JCK failure was from a
> different method call, but it appears this is the root cause.
>
> Also in this patch: c
On Fri, 18 Apr 2025 17:40:10 GMT, Joe Wang wrote:
>> Added missed localized strings for _de, _ja and _zh_CN localities based on
>> the JDK11 localizations
>
>> Added missed localized strings for _de, _ja and _zh_CN localities based on
>> the JDK11 localizations
>
> Probably not necessary as th
On Fri, 18 Apr 2025 19:02:26 GMT, Alan Bateman wrote:
> I don't think a readLine would make sense for Reader
If there were a `readLine` I would expect it not to be exposed in the API.
-
PR Comment: https://git.openjdk.org/jdk/pull/24728#issuecomment-2816085214
On Thu, 17 Apr 2025 23:07:35 GMT, Brian Burkhalter wrote:
>> Implement the requested methods and add a test thereof.
>
> Brian Burkhalter has updated the pull request incrementally with two
> additional commits since the last revision:
>
> - 8354724: Increment copyright year in Reader
> - 835
On Fri, 18 Apr 2025 17:35:00 GMT, Stuart Marks wrote:
> Line-oriented methods on Reader instead of BufferedReader.
I don't think a readLine would make sense for Reader but I think we can explore
a method that reads all remaining characters (to EOS) as a sequence of lines.
So a very different i
On Fri, 18 Apr 2025 13:05:24 GMT, Daniel Fuchs wrote:
> Hi,
>
> Please find here a PR for the implementation of JEP [JDK-8291976: HTTP/3 for
> the HTTP Client API](https://bugs.openjdk.org/browse/JDK-8291976).
>
> The CSR can be viewed at [JDK-8350588: Implement HTTP/3 for the HTTP Client
> A
> In `java.io.WinNTFileSystem::isInvalid`, replace an insufficient test for
> file path validity with a sufficient test for file path invalidity. Also, add
> a new test.
Brian Burkhalter has updated the pull request incrementally with one additional
commit since the last revision:
8354450: A
On Fri, 18 Apr 2025 18:15:09 GMT, Jorn Vernee wrote:
>> So just `Linker.nativeLinker().downcallHandle(MemorySegment.ofArray(new
>> byte[0]), signature)` suffices?
>
> Yes, that would work, but I was thinking just
> `Linker.nativeLinker().downcallHandle(signature)`
Yep, simplified this, the sta
> This PR implements nth root computation for `BigInteger`s using Newton method
> and optimizes `BigInteger.pow(int)` method.
> [Here is a proof of convergence of the recurrence
> used.](https://github.com/user-attachments/files/19785045/nth_root_newton_proof_integers.pdf)
fabioromano1 has updat
> Perf numbers for simple main:
> Linking of `Class::forName0` down from ~152 to ~83
>
> For calling little color management system
> https://bugs.openjdk.org/browse/JDK-8313344:
> JNI: ~45
> baseline panama: ~164
> patch: ~103
>
> Also see #24705.
Chen Liang has updated the pull request increm
On Fri, 18 Apr 2025 08:11:28 GMT, Alan Bateman wrote:
>> From experimentation with C++ code is VS, it appears that `CreateDirectoryW`
>> will create a directory with either a leading or trailing space in its name,
>> whereas `createFileW` will create a file with a leading space in its name,
>>
On Fri, 18 Apr 2025 17:39:05 GMT, Chen Liang wrote:
>> Some AccessFlag parsing methods throw IAE because a flag mask is not valid
>> in a location. However, there is no easy way to check what flag mask bits or
>> what flags are valid for a location. We need such APIs to check, specific to
>> e
On Fri, 18 Apr 2025 17:35:00 GMT, Stuart Marks wrote:
> There's logic in readLine() that terminates the current line if a CR is
> encountered, and it _also_ sets a `skipLF` flag which skips the LF if it's
> the very next character.
I will also point out here that, based on a somewhat cursory s
On Fri, 18 Apr 2025 17:56:53 GMT, Chen Liang wrote:
>> make/jdk/src/classes/build/tools/classlist/HelloClasslist.java line 190:
>>
>>> 188: JAVA_BOOLEAN, ADDRESS, ADDRESS);
>>> 189: Optional symbol =
>>> lookup.find("Java_java_lang_Class_forName0");
>>> 190: var
On Fri, 18 Apr 2025 17:49:35 GMT, Jorn Vernee wrote:
>> Perf numbers for simple main:
>> Linking of `Class::forName0` down from ~152 to ~83
>>
>> For calling little color management system
>> https://bugs.openjdk.org/browse/JDK-8313344:
>> JNI: ~45
>> baseline panama: ~164
>> patch: ~103
>>
>>
On Thu, 17 Apr 2025 19:44:07 GMT, Chen Liang wrote:
> Perf numbers for simple main:
> Linking of `Class::forName0` down from ~152 to ~83
>
> For calling little color management system
> https://bugs.openjdk.org/browse/JDK-8313344:
> JNI: ~45
> baseline panama: ~164
> patch: ~103
>
> Also see #
On Fri, 18 Apr 2025 17:09:40 GMT, Alexey Bakhtin wrote:
> Added missed localized strings for _de, _ja and _zh_CN localities based on
> the JDK11 localizations
Probably not necessary as they will be covered by L10n resource update.
-
PR Comment: https://git.openjdk.org/jdk/pull/247
> Some AccessFlag parsing methods throw IAE because a flag mask is not valid in
> a location. However, there is no easy way to check what flag mask bits or
> what flags are valid for a location. We need such APIs to check, specific to
> each class file format version.
>
> Also in the investigat
On Thu, 17 Apr 2025 23:07:35 GMT, Brian Burkhalter wrote:
>> Implement the requested methods and add a test thereof.
>
> Brian Burkhalter has updated the pull request incrementally with two
> additional commits since the last revision:
>
> - 8354724: Increment copyright year in Reader
> - 835
The current key manager is SunX509, which is configured in the java.security.
The SunX509 algorithm does not check of the local certificate. The PKIX
algorithm should be preferred now so that the default key manager could be more
robust.
-
Commit messages:
- Rework unit tests
- U
On Thu, 17 Apr 2025 23:06:04 GMT, Justin Lu wrote:
>> Please review this PR which improves the _ValidateISO4217_ Currency test by
>> adding testing of future currencies after the transition date.
>>
>> This is done by creating a patched version of Currency that replaces
>> `System.currentTimeM
On Fri, 18 Apr 2025 04:08:56 GMT, Alexey Bakhtin wrote:
> Please find a trivial fix for the missing `cvc-complex-type.2.4.d.1` resource
> in the main XMLSchemaMessages.properties file.
@alexeybakhtin also, I assigned the issue to you. Thanks.
-
PR Comment: https://git.openjdk.org/
On Fri, 18 Apr 2025 04:08:56 GMT, Alexey Bakhtin wrote:
> Please find a trivial fix for the missing `cvc-complex-type.2.4.d.1` resource
> in the main XMLSchemaMessages.properties file.
Added missed localized strings for _de, _ja and _zh_CN localities based on the
JDK11 localizations
-
> Please find a trivial fix for the missing `cvc-complex-type.2.4.d.1` resource
> in the main XMLSchemaMessages.properties file.
Alexey Bakhtin has updated the pull request incrementally with one additional
commit since the last revision:
Add locolizations for _de, _ja and _zh_CN
---
Perf numbers for simple main:
Linking of `Class::forName0` down from ~152 to ~83
For calling little color management system
https://bugs.openjdk.org/browse/JDK-8313344:
JNI: ~45
baseline panama: ~164
patch: ~103
Also see #24705.
-
Commit messages:
- Merge branch 'master' of https:
> Please review this PR which improves the _ValidateISO4217_ Currency test by
> adding testing of future currencies after the transition date.
>
> This is done by creating a patched version of Currency that replaces
> `System.currentTimeMillis()` calls with a mocked value equivalent to
> `Long.
On Wed, 16 Apr 2025 13:20:33 GMT, Alan Bateman wrote:
>> Stuart Marks has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains four additional
>> commits
On Thu, 17 Apr 2025 00:15:47 GMT, Naoto Sato wrote:
>> Please review this PR which improves the _ValidateISO4217_ Currency test by
>> adding testing of future currencies after the transition date.
>>
>> This is done by creating a patched version of Currency that replaces
>> `System.currentTime
On Thu, 17 Apr 2025 18:03:47 GMT, Vladimir Ivanov wrote:
>> Migrate Vector API math library (SVML and SLEEF) linkage from native code
>> (in JVM) to Java FFM API.
>>
>> Since FFM API doesn't support vector calling conventions yet, migration
>> affects only symbol lookup for now. But it still e
> This PR implements nth root computation for `BigInteger`s using Newton method
> and optimizes `BigInteger.pow(int)` method.
> [Here is a proof of convergence of the recurrence
> used.](https://github.com/user-attachments/files/19785045/nth_root_newton_proof_integers.pdf)
fabioromano1 has updat
Please find a trivial fix for the missing `cvc-complex-type.2.4.d.1` resource
in the main XMLSchemaMessages.properties file.
-
Commit messages:
- 8259540: MissingResourceException for key cvc-complex-type.2.4.d.1
Changes: https://git.openjdk.org/jdk/pull/24747/files
Webrev: https
> Implement the requested methods and add a test thereof.
Brian Burkhalter has updated the pull request incrementally with one additional
commit since the last revision:
8354724: Modify specification verbiage more or less as suggested
-
Changes:
- all: https://git.openjdk.org/j
> If a base class is package-private then its subclasses should have the same
> package name and defining class loader, otherwise `IllegalAccessError` is
> thrown when linking a subclass. Currently when dumping a static archive
> separate `URLClassLoader`s are used for each unregistered classes'
> This PR implements nth root computation for `BigInteger`s using Newton method
> and optimizes `BigInteger.pow(int)` method.
> [Here is a proof of convergence of the recurrence
> used.](https://github.com/user-attachments/files/19785045/nth_root_newton_proof_integers.pdf)
fabioromano1 has updat
On Thu, 17 Apr 2025 23:47:09 GMT, Alexey Semenyuk wrote:
> Rework Executor class from jpackage test lib to support separate
> configuration of stdout and stderr streams handling:
> - New `Executor.discardStdout(boolean)` and
> `Executor.discardStderr(boolean)` methods enable/disable stdout and
On Wed, 16 Apr 2025 15:00:20 GMT, Roger Riggs wrote:
>> Yeah, we already added this API to allow implementations to be more
>> consistent under race condition. So for changing char sequences, this
>> method's default implementation can throw IOOBE, but it is already specified
>> so it is well-
> This PR implements nth root computation for `BigInteger`s using Newton method
> and optimizes `BigInteger.pow(int)` method.
> [Here is a proof of convergence of the recurrence
> used.](https://github.com/user-attachments/files/19785045/nth_root_newton_proof_integers.pdf)
fabioromano1 has updat
> Some AccessFlag parsing methods throw IAE because a flag mask is not valid in
> a location. However, there is no easy way to check what flag mask bits or
> what flags are valid for a location. We need such APIs to check, specific to
> each class file format version.
>
> Also in the investigat
On Fri, 18 Apr 2025 15:47:07 GMT, Brian Burkhalter wrote:
> So you are suggesting moving `readAllLines` up from `BufferedReader` to
> `Reader`?
I think add it to the list to explore as a non-buffered Reader could support
it, esp. when it doesn't support a mark. There are advantages and disadva
On Thu, 17 Apr 2025 10:47:03 GMT, Viktor Klang wrote:
>> Per Minborg has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Address comments on original vs underlying
>
> src/java.base/share/classes/java/lang/StableValue.java line 422:
>
>> 42
On Thu, 17 Apr 2025 23:07:35 GMT, Brian Burkhalter wrote:
>> Implement the requested methods and add a test thereof.
>
> Brian Burkhalter has updated the pull request incrementally with two
> additional commits since the last revision:
>
> - 8354724: Increment copyright year in Reader
> - 835
On Fri, 18 Apr 2025 12:33:49 GMT, Jorn Vernee wrote:
>> Per Minborg has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Address comments on original vs underlying
>
> src/java.base/share/classes/java/lang/StableValue.java line 363:
>
>> 361
On Fri, 18 Apr 2025 14:46:08 GMT, Alan Bateman wrote:
> I don't think it would be too bad to have Reader define a method to read the
> remaining characters as a sequence of lines.
So you are suggesting moving `readAllLines` up from `BufferedReader` to
`Reader`?
-
PR Comment: http
On Thu, 3 Apr 2025 09:47:15 GMT, Viktor Klang wrote:
>> I think it should be "content" as only one element can be set?
>
> I'm definitely not an expert here, so I'll defer to someone more knowledgable
> :)
I asked around/looked this up, and it seems 'contents' would be more correct
here, since
On Thu, 10 Apr 2025 14:19:25 GMT, Per Minborg wrote:
>> Implement JEP 502.
>>
>> The PR passes tier1-tier3 tests.
>
> Per Minborg has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Address comments on original vs underlying
Did an initial pa
On Fri, 18 Apr 2025 13:19:05 GMT, Jorn Vernee wrote:
>> Per Minborg has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Address comments on original vs underlying
>
> src/java.base/share/classes/java/lang/StableValue.java line 454:
>
>> 452
On Fri, 18 Apr 2025 15:02:56 GMT, Glavo wrote:
>> public static String readString() throws IOException {
>> char[] chars = new char[TRANSFER_BUFFER_SIZE];
>> int n;
>> int off = 0;
>> int rest = chars.length;
>> while ((n = read(chars, off, rest)) != -1) {
On Fri, 18 Apr 2025 06:59:18 GMT, Shaojin Wen wrote:
>> Seems you want to make the `result` StringBuilder fully expanded
>> (maybeLatin1 = true, coder = UTF16) initially, so we just compress the whole
>> builder with a vectorized intrinsic instead of char-by-char loop in
>> `append`. Makes sen
On Thu, 17 Apr 2025 23:07:35 GMT, Brian Burkhalter wrote:
>> Implement the requested methods and add a test thereof.
>
> Brian Burkhalter has updated the pull request incrementally with two
> additional commits since the last revision:
>
> - 8354724: Increment copyright year in Reader
> - 835
Hi,
Please find here a PR for the implementation of JEP [JDK-8291976: HTTP/3 for
the HTTP Client API](https://bugs.openjdk.org/browse/JDK-8291976).
The CSR can be viewed at [JDK-8350588: Implement HTTP/3 for the HTTP Client
API](https://bugs.openjdk.org/browse/JDK-8350588)
This JEP proposes to
On Thu, 17 Apr 2025 23:07:35 GMT, Brian Burkhalter wrote:
>> Implement the requested methods and add a test thereof.
>
> Brian Burkhalter has updated the pull request incrementally with two
> additional commits since the last revision:
>
> - 8354724: Increment copyright year in Reader
> - 835
On Thu, 17 Apr 2025 01:36:39 GMT, Xiaohong Gong wrote:
>> How does it work now? The code in `generate_vector_math_stubs()` in
>> `stubGenerator_aarch64.cpp` only populates `VEC_SIZE_SCALABLE` shapes with
>> SVE versions.
>
> Please see the `addr` definition code in
> https://github.com/openjdk
On Fri, 18 Apr 2025 06:03:36 GMT, Alan Bateman wrote:
>> Markus KARG has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Applied changes requested by Chen and Jaikiran: Unit tests for default
>> implementation of CharSequence.getChars() and
> This Pull Request proposes an implementation for
> [JDK-8343110](https://bugs.openjdk.org/browse/JDK-8343110): Adding the new
> method `public void getChars(int srcBegin, int srcEnd, char[] dst, int
> dstBegin)` to the `CharSequence` interface, providing a **bulk-read**
> facility including a
On Thu, 17 Apr 2025 23:47:09 GMT, Alexey Semenyuk wrote:
> Rework Executor class from jpackage test lib to support separate
> configuration of stdout and stderr streams handling:
> - New `Executor.discardStdout(boolean)` and
> `Executor.discardStderr(boolean)` methods enable/disable stdout and
On Fri, 18 Apr 2025 09:33:48 GMT, Thomas Schatzl wrote:
>> Hi all,
>>
>> please review this change that implements (currently Draft) JEP: G1:
>> Improve Application Throughput with a More Efficient Write-Barrier.
>>
>> The reason for posting this early is that this is a large change, and the
On Thu, 10 Apr 2025 10:36:31 GMT, Magnus Ihse Bursie wrote:
>> As a follow-up to
>> [JDK-8354213](https://bugs.openjdk.org/browse/JDK-8354213), I found some
>> additional places where unicode characters are unnecessarily used instead of
>> pure ASCII.
>
> Magnus Ihse Bursie has updated the pul
> Hi all,
>
> please review this change that implements (currently Draft) JEP: G1:
> Improve Application Throughput with a More Efficient Write-Barrier.
>
> The reason for posting this early is that this is a large change, and the JEP
> process is already taking very long with no end in sight
On Thu, 17 Apr 2025 22:43:59 GMT, Roger Riggs wrote:
> I'm fine with moving `readString` to `Reader`.
Given that
[Reader.read(char[])](https://docs.oracle.com/en/java/javase/24/docs/api/java.base/java/io/Reader.html#read(char[]))
exists, this should be a trivial change, implementation-wise.
-
On Fri, 18 Apr 2025 01:01:50 GMT, Brian Burkhalter wrote:
> From experimentation with C++ code is VS, it appears that `CreateDirectoryW`
> will create a directory with either a leading or trailing space in its name,
> whereas `createFileW` will create a file with a leading space in its name,
>
On Fri, 18 Apr 2025 02:49:43 GMT, Chen Liang wrote:
>> `Reader` by specification works on `char`, so I think this is fine. Even if
>> a StringBuilder is UTF16, it still has to check for all-Latin1 characters at
>> the time of string creation, so not really an overhead elimination.
>
> Seems you
78 matches
Mail list logo
