Re: RFR: 8301971: Make JDK source code UTF-8 [v2]

2025-04-13 Thread Magnus Ihse Bursie
> Most of the JDK code base has been transitioned to UTF-8, but not all. This > has recently become an acute problem, since our mixing of iso-8859-1 and > utf-8 in properties files confused the version of `sed` that is shipped with > the new macOS 15.4. > > The fix is basically simple, and incl

Re: RFR: 8301971: Make JDK source code UTF-8

2025-04-13 Thread Magnus Ihse Bursie
On Thu, 10 Apr 2025 14:28:02 GMT, Magnus Ihse Bursie wrote: > Most of the JDK code base has been transitioned to UTF-8, but not all. This > has recently become an acute problem, since our mixing of iso-8859-1 and > utf-8 in properties files confused the version of `sed` that is shipped with >

RFR: 8301971: Make JDK source code UTF-8

2025-04-13 Thread Magnus Ihse Bursie
This is a WIP to move the JDK source code base to fully UTF-8, and to ensure tools knows about this. - Commit messages: - Fix flags for Windows - Mark java and native source code as utf-8 - Don't convert properties files to iso-8859-1. - Tell tools we use utf-8 - Replace iso-885

Re: RFR: 8354053: Remove unused JavaIOFilePermissionAccess

2025-04-13 Thread Weijun Wang
On Fri, 11 Apr 2025 21:26:08 GMT, Roger Riggs wrote: > The JavaIOFilePermissionAccess interface is removed from SharedSecrets and > its implementation (FilePermCompat.java) used by the test is moved to java.io > FilePermission where cross package access is not needed. > The test FilePermission

Re: RFR: 8349716: IllegalAccessError when Proxy methods return object of a package-private type

2025-04-13 Thread Chen Liang
On Sun, 13 Apr 2025 09:49:46 GMT, Chen Liang wrote: > Proxy currently places proxy classes that proxy interfaces with > package-private return types in dynamic modules. This means that if a return > value is non-null, Proxy cannot return it and throws IllegalAccessError. > > This patch changes

Re: RFR: 8354053: Remove unused JavaIOFilePermissionAccess

2025-04-13 Thread Alan Bateman
On Fri, 11 Apr 2025 21:26:08 GMT, Roger Riggs wrote: > The JavaIOFilePermissionAccess interface is removed from SharedSecrets and > its implementation (FilePermCompat.java) used by the test is moved to java.io > FilePermission where cross package access is not needed. > The test FilePermission

Re: RFR: 8349716: IllegalAccessError when Proxy methods return object of a package-private type

2025-04-13 Thread Alan Bateman
On Sun, 13 Apr 2025 09:49:46 GMT, Chen Liang wrote: > Proxy currently places proxy classes that proxy interfaces with > package-private return types in dynamic modules. This means that if a return > value is non-null, Proxy cannot return it and throws IllegalAccessError. > > This patch changes

RFR: 8349716: IllegalAccessError when Proxy methods return object of a package-private type

2025-04-13 Thread Chen Liang
Proxy currently places proxy classes that proxy interfaces with package-private return types in dynamic modules. This means that if a return value is non-null, Proxy cannot return it and throws IllegalAccessError. This patch changes strategy so proxy classes for any reference to package-private

Re: RFR: 8349716: IllegalAccessError when Proxy methods return object of a package-private type

2025-04-13 Thread Hendrik Schick
On Sun, 13 Apr 2025 09:49:46 GMT, Chen Liang wrote: > Proxy currently places proxy classes that proxy interfaces with > package-private return types in dynamic modules. This means that if a return > value is non-null, Proxy cannot return it and throws IllegalAccessError. > > This patch changes

Integrated: 8254622: Hide superclasses from conditionally exported packages

2025-04-13 Thread Hannes Wallnöfer
On Fri, 4 Apr 2025 13:36:19 GMT, Hannes Wallnöfer wrote: > Please review an enhancement to treat classes and interfaces that are not > included and not unconditionally exported as hidden. This means they do not > show up in the generated documentation even if they are implemented or > extended

Re: RFR: 8354053: Remove unused JavaIOFilePermissionAccess

2025-04-13 Thread Chen Liang
On Fri, 11 Apr 2025 21:26:08 GMT, Roger Riggs wrote: > The JavaIOFilePermissionAccess interface is removed from SharedSecrets and > its implementation (FilePermCompat.java) used by the test is moved to java.io > FilePermission where cross package access is not needed. > The test FilePermission

Withdrawn: 8349716: IllegalAccessError when Proxy methods return object of a package-private type

2025-04-13 Thread Chen Liang
On Tue, 11 Feb 2025 17:56:04 GMT, Chen Liang wrote: > The return value adaption of Proxy is problematic, that it may attempt to > access package-private types inaccessible to its package in a `checkcast` > instruction, which causes `IllegalAccessError` if the returned object is not > `null`. T