On Fri, 11 Apr 2025 13:50:04 GMT, Alexey Semenyuk wrote:
>> Escape the dollar sign.
>
> Alexey Semenyuk has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Disable tex_math_dollars extension
Thanks for getting this to the right place.
---
On Fri, 11 Apr 2025 17:02:13 GMT, Naoto Sato wrote:
> Removing old charset test cases that verify new charset implementations (as
> of JDK7). Removed tests/files are actual charset implementations used in
> pre-JDK7, which have been used for comparing the results. Since those "new"
> implement
On Fri, 11 Apr 2025 23:31:16 GMT, Brent Christian wrote:
>> Certain specific types of tests involving GC and reference processing need
>> to account for the delay between a GC completing (during which the GC clears
>> a Reference), and the Reference being added to its associated queue. At
>> p
On Fri, 11 Apr 2025 23:26:45 GMT, Brent Christian wrote:
>> test/lib/jdk/test/whitebox/WhiteBox.java line 568:
>>
>>> 566: private Method getWaitForReferenceProcessingMethod() {
>>> 567: Method wfrp = waitForReferenceProcessingMethod;
>>> 568: if (wfrp == null) {
>>
>> Racy initializa
> Streamline the extension function control in the XPath API by relying solely
> on
> [XPathFunctionResolver](https://docs.oracle.com/en/java/javase/24/docs/api/java.xml/javax/xml/xpath/XPathFunctionResolver.html),
> which provides a secure and developer-defined mechanism. Remove the feature
>
> Certain specific types of tests involving GC and reference processing need to
> account for the delay between a GC completing (during which the GC clears a
> Reference), and the Reference being added to its associated queue. At
> present, ad hoc mechanisms (with delays/timeout) are used, but c
On Fri, 11 Apr 2025 21:36:28 GMT, Roger Riggs wrote:
>> Brent Christian has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> wFRP throws InterruptedException, pass through from
>> InvocationTargetException; don't check param count
>
> test/l
Streamline the extension function control in the XPath API by relying solely on
[XPathFunctionResolver](https://docs.oracle.com/en/java/javase/24/docs/api/java.xml/javax/xml/xpath/XPathFunctionResolver.html),
which provides a secure and developer-defined mechanism. Remove the feature
FEATURE_SEC
When jdeps was migrated from old classfile to ClassFile API, the parsing
semantic changed - error checks are now made lazily, and nested crashes from
malformed signature or other problems is now latent, after a `ClassModel`
instance is available. (The old error check existed only for constructin
On Fri, 11 Apr 2025 13:50:04 GMT, Alexey Semenyuk wrote:
>> Escape the dollar sign.
>
> Alexey Semenyuk has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Disable tex_math_dollars extension
@erikj79 PTAL
-
PR Comment: https://gi
> Migrate Vector API math library (SVML and SLEEF) linkage from native code (in
> JVM) to Java FFM API.
>
> Since FFM API doesn't support vector calling conventions yet, migration
> affects only symbol lookup for now. But it still enables significant
> simplifications on JVM side.
>
> The patc
On Fri, 11 Apr 2025 20:09:10 GMT, Brent Christian wrote:
>> Certain specific types of tests involving GC and reference processing need
>> to account for the delay between a GC completing (during which the GC clears
>> a Reference), and the Reference being added to its associated queue. At
>> p
On Fri, 11 Apr 2025 13:50:04 GMT, Alexey Semenyuk wrote:
>> Escape the dollar sign.
>
> Alexey Semenyuk has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Disable tex_math_dollars extension
Maybe wait for someone else to review the build chan
The JavaIOFilePermissionAccess interface is removed from SharedSecrets and its
implementation (FilePermCompat.java) used by the test is moved to java.io
FilePermission where cross package access is not needed.
The test FilePermissionCollectionMerge is updated to access the internal
implementati
On Thu, 10 Apr 2025 22:05:04 GMT, Roger Riggs wrote:
> Remove forRemoval = true from @Deprecated annotation of Boolean, Byte,
> Character, Double, Float, Integer, Long, Short.
> And add `SuppressWarnings("deprecation") `where needed; and remove
> `SuppressWarnings("removal")`
Marked as reviewe
On Thu, 10 Apr 2025 22:05:04 GMT, Roger Riggs wrote:
> Remove forRemoval = true from @Deprecated annotation of Boolean, Byte,
> Character, Double, Float, Integer, Long, Short.
> And add `SuppressWarnings("deprecation") `where needed; and remove
> `SuppressWarnings("removal")`
LGTM
---
On Fri, 11 Apr 2025 02:25:20 GMT, Stuart Marks wrote:
>> I disagree. IMO, for a test library, it's an unnecessary burden to make
>> callers catch a checked exception.
>
> Hm. In general, if something blocks interruptibly, it should be declared to
> throw InterruptedException instead of catching
> Certain specific types of tests involving GC and reference processing need to
> account for the delay between a GC completing (during which the GC clears a
> Reference), and the Reference being added to its associated queue. At
> present, ad hoc mechanisms (with delays/timeout) are used, but c
On Fri, 11 Apr 2025 13:50:04 GMT, Alexey Semenyuk wrote:
>> Escape the dollar sign.
>
> Alexey Semenyuk has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Disable tex_math_dollars extension
Looks good.
-
Marked as reviewed by al
On Tue, 8 Apr 2025 09:02:25 GMT, Hannes Wallnöfer wrote:
>> Please review an enhancement to treat classes and interfaces that are not
>> included and not unconditionally exported as hidden. This means they do not
>> show up in the generated documentation even if they are implemented or
>> exte
On Tue, 8 Apr 2025 09:02:25 GMT, Hannes Wallnöfer wrote:
>> Please review an enhancement to treat classes and interfaces that are not
>> included and not unconditionally exported as hidden. This means they do not
>> show up in the generated documentation even if they are implemented or
>> exte
There is one form of array builder already in the JDK - Stream.builder(). This
doesn't cover off all of the use-cases, but covers some of them (notably not
the byte array case).
Thanks for pointing that out! Under-the-covers it relies on
java.util.stream.SpinedBuffer, which is built on the sam
On Fri, Apr 11, 2025 at 10:50 AM Engebretson, John
wrote:
> I would like to see JDK standard "array builders" for primitive types and
> reference types that use fixed sized (power-of-two) segments internally.
>
>
>
> I want to caution on the power-of-two idea – it leads to large objects
> faster
There is one form of array builder already in the JDK - Stream.builder().
This doesn't cover off all of the use-cases, but covers some of them
(notably not the byte array case).
-Johannes
On Fri, Apr 11, 2025 at 11:47 AM Archie Cobbs
wrote:
> To try to loop back on my original point...
>
> Th
> Escape the dollar sign.
Alexey Semenyuk has updated the pull request incrementally with one additional
commit since the last revision:
Disable tex_math_dollars extension
-
Changes:
- all: https://git.openjdk.org/jdk/pull/24585/files
- new: https://git.openjdk.org/jdk/pull/2
On Thu, 10 Apr 2025 21:50:10 GMT, Alexey Semenyuk wrote:
> Escape the dollar sign.
"`${`"
emits a slightly different warning:
[WARNING] Could not convert TeX math ) and the first following non-alphanumeric
character. Alternatively, it can be enclosed between "`, rendering as TeX:
e enclosed
To try to loop back on my original point...
The "underlying problem" that I think should be addressed by some new
internal class (or suite of classes) is the "array builder" problem. This
is where you're doing "append, append, append, ..., use read-only
thereafter".
Currently people use ArrayList
I would like to see JDK standard "array builders" for primitive types and
reference types that use fixed sized (power-of-two) segments internally.
I want to caution on the power-of-two idea – it leads to large objects faster
than the current implementation, which hurts performance as well as max
On Fri, 11 Apr 2025 11:20:30 GMT, Jan Lahoda wrote:
>> This is a patch to finalize the module imports feature. Please see:
>> https://bugs.openjdk.org/browse/JDK-8344700
>
> Jan Lahoda has updated the pull request with a new target base due to a merge
> or a rebase. The incremental webrev exclud
On Fri, Apr 11, 2025 at 8:11 AM Engebretson, John
wrote:
> It seems like a good general-purpose list but I wouldn’t recommend it as a
> direct replacement for either ArrayList or LinkedList; in the former case
> the risk is slower random accesses, and in the latter the risk is to head
> modificat
On Thu, 10 Apr 2025 10:02:40 GMT, Thomas Schatzl wrote:
>> Hi all,
>>
>> please review this change that implements (currently Draft) JEP: G1:
>> Improve Application Throughput with a More Efficient Write-Barrier.
>>
>> The reason for posting this early is that this is a large change, and the
Another option is to make the internal stored hash a long and then the first
part can be used to track whether it has been computed and then just cast the
long to an int to retrieve the value. If it has been computed, one bit is
flipped in the upper 32 bits. Then a read is just a single long rea
On Fri, 11 Apr 2025 13:50:04 GMT, Alexey Semenyuk wrote:
>> Escape the dollar sign.
>
> Alexey Semenyuk has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Disable tex_math_dollars extension
With the latest fix, the warning is gone, the raw ma
On Fri, 11 Apr 2025 13:33:09 GMT, Alexey Semenyuk wrote:
>> Escape the dollar sign.
>
> Alexey Semenyuk has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Add missing backslash character
Ironically, I came up with the same patch a few minutes
On Fri, 11 Apr 2025 13:33:09 GMT, Alexey Semenyuk wrote:
>> Escape the dollar sign.
>
> Alexey Semenyuk has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Add missing backslash character
Try this patch:
diff --git a/make/autoconf/basic_tools
> Escape the dollar sign.
Alexey Semenyuk has updated the pull request incrementally with one additional
commit since the last revision:
Add missing backslash character
-
Changes:
- all: https://git.openjdk.org/jdk/pull/24585/files
- new: https://git.openjdk.org/jdk/pull/2458
On Thu, 10 Apr 2025 21:50:10 GMT, Alexey Semenyuk wrote:
> Escape the dollar sign.
Meanwhile, I fixed a case of missing escape backslash in the following
paragraph. I verified that it is rendered properly in raw markdown and in
pandoc output.
-
PR Comment: https://git.openjdk.org
On Thu, 10 Apr 2025 21:50:10 GMT, Alexey Semenyuk wrote:
> Escape the dollar sign.
Oh, that's too bad. :( Weird that pandoc tries to modify stuff inside ``. I
think the better solution then is to pass `-tex_math_dollars` to pandoc to stop
it from trying to parse the dollar sign. We should not
On Thu, 10 Apr 2025 10:02:40 GMT, Thomas Schatzl wrote:
>> Hi all,
>>
>> please review this change that implements (currently Draft) JEP: G1:
>> Improve Application Throughput with a More Efficient Write-Barrier.
>>
>> The reason for posting this early is that this is a large change, and the
I’m prototyping the generic allocator you describe and it’s extremely effective
for Objects – but I’m hamstrung by trying to use generics on primitive byte.
I’m not aware of a way to work around that, and changing the array from byte[]
to Byte[] would be a terrible idea, so I think we’re lookin
On Thu, 10 Apr 2025 10:02:40 GMT, Thomas Schatzl wrote:
>> Hi all,
>>
>> please review this change that implements (currently Draft) JEP: G1:
>> Improve Application Throughput with a More Efficient Write-Barrier.
>>
>> The reason for posting this early is that this is a large change, and the
On Fri, 11 Apr 2025 07:11:19 GMT, Matthias Baesken wrote:
>> JLI_ReportErrorMessageSys is not used any more on Windows, so we can remove
>> it and make it UNIX-only (there are still a few remaining usages).
>
> Matthias Baesken has updated the pull request incrementally with one
> additional co
On Thu, 10 Apr 2025 08:03:58 GMT, Matthias Baesken wrote:
> JLI_ReportErrorMessageSys is not used any more on Windows, so we can remove
> it and make it UNIX-only (there are still a few remaining usages).
This pull request has now been integrated.
Changeset: b5d2e254
Author:Matthias Baeske
On Fri, 11 Apr 2025 07:11:19 GMT, Matthias Baesken wrote:
>> JLI_ReportErrorMessageSys is not used any more on Windows, so we can remove
>> it and make it UNIX-only (there a still a few remaining usages).
>
> Matthias Baesken has updated the pull request incrementally with one
> additional comm
> This is a patch to finalize the module imports feature. Please see:
> https://bugs.openjdk.org/browse/JDK-8344700
Jan Lahoda has updated the pull request with a new target base due to a merge
or a rebase. The incremental webrev excludes the unrelated changes brought in
by the merge/rebase. The
On Mon, 7 Apr 2025 16:36:07 GMT, Jorn Vernee wrote:
> `jnativescan` uses the `ClassResolver` class to find both system classes, as
> well as application classes. In principle, a class resolver supports both
> iterating over all classes from that particular source, as well as looking up
> class
On Thu, 10 Apr 2025 17:07:21 GMT, Jorn Vernee wrote:
>> `jnativescan` uses the `ClassResolver` class to find both system classes, as
>> well as application classes. In principle, a class resolver supports both
>> iterating over all classes from that particular source, as well as looking
>> up
On Fri, 11 Apr 2025 09:09:05 GMT, Kim Barrett wrote:
>> On a second thought, I think we should do this shift before this PR, so that
>> it is cleanly backportable. This bug messes with concurrent GC invariants,
>> so it would be nice to fix it in current LTSes.
>
> As far as I can tell, intrins
On Fri, 11 Apr 2025 04:07:45 GMT, Fei Yang wrote:
>> Hamlin Li has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> enable more test
>
> src/hotspot/cpu/riscv/c2_MacroAssembler_riscv.cpp line 2173:
>
>> 2171: break;
>> 2172: case B
> Hi,
> Can you help to review this patch?
> On riscv, CMoveI/L already were implemented, but there are some gap:
> 1. CMoveI/L does not support comparison with float/double, corresponding
> tests are not turn on either.
> 2. Some optimization of C2 is not turned on, e.g. `Phi -> CMove -> min_max`
On Fri, 11 Apr 2025 03:35:11 GMT, Sergey Bylokhov wrote:
>> I have checked the entire code base for incorrect encodings, but luckily
>> enough these were the only remaining problems I found.
>>
>> BOM (byte-order mark) is a method used for distinguishing big and little
>> endian UTF-16 encodi
On Fri, 28 Mar 2025 23:48:34 GMT, Vladimir Ivanov wrote:
>> The HashMap for caching was deleted. Now it use only ThreadLocal variable
>> without synchronization.
>> According to the specjvm2008::xml.transform workload the performance for low
>> threads counts was not affected and improved for h
On Thu, 10 Apr 2025 10:10:49 GMT, Magnus Ihse Bursie wrote:
> I have checked the entire code base for incorrect encodings, but luckily
> enough these were the only remaining problems I found.
>
> BOM (byte-order mark) is a method used for distinguishing big and little
> endian UTF-16 encoding
On Fri, 11 Apr 2025 10:21:32 GMT, Magnus Ihse Bursie wrote:
>> src/demo/share/java2d/J2DBench/resources/textdata/arabic.ut8.txt line 11:
>>
>>> 9: تخصص الشفرة الموحدة "يونِكود" رقما وحيدا لكل محرف في جميع اللغات
>>> العالمية، وذلك بغض النظر عن نوع الحاسوب أو البرامج المستخدمة. وقد تـم تبني
>>>
On Thu, 10 Apr 2025 21:53:39 GMT, Alexey Semenyuk wrote:
>> I filed https://bugs.openjdk.org/browse/JDK-8354320 to fix the warning
>
> Adding backslash character (``) before the dollar character (`"${"` ->
> `"${"`) suppressed the warning, and the man page looks as expected.
>
> PR https://gith
On Thu, 10 Apr 2025 21:50:10 GMT, Alexey Semenyuk wrote:
> Escape the dollar sign.
I'm not entirely sure this is a good solution. Yes, it makes pandoc happy and
removes the warning, but this is using a pandoc extension and not standard
markdown. A standard markdown renderer will show this as t
On Thu, 10 Apr 2025 17:07:21 GMT, Jorn Vernee wrote:
>> `jnativescan` uses the `ClassResolver` class to find both system classes, as
>> well as application classes. In principle, a class resolver supports both
>> iterating over all classes from that particular source, as well as looking
>> up
On Fri, 11 Apr 2025 08:51:56 GMT, Aleksey Shipilev wrote:
>> I think it would be "easier" to shift `@IntrinsicCandidate` to a private
>> `Reference.getImpl/get0` pair of methods, and intrinsify one of those
>> instead. Pretty much like current `clear` and `refersTo` are doing it now.
>> And it
> From: "Chen Liang"
> To: "Remi Forax" , "core-libs-dev"
>
> Sent: Thursday, April 10, 2025 8:16:39 PM
> Subject: Re: java.lang.String hashCode and @Stable ?
> Hi Remi,
> I think this is probably due to these fields being added too early - the
> stable
> on string byte array is also added late
On Fri, 11 Apr 2025 08:03:07 GMT, Aleksey Shipilev wrote:
>> You need to use intrinsic predicates to add runtime check for receiver. See:
>> https://github.com/openjdk/jdk/blob/master/src/hotspot/share/opto/library_call.cpp#L167
>
> I think it would be "easier" to shift `@IntrinsicCandidate` to a
> From: "Glavo"
> To: "Chen Liang"
> Cc: "Remi Forax" , "core-libs-dev"
>
> Sent: Thursday, April 10, 2025 8:54:57 PM
> Subject: Re: java.lang.String hashCode and @Stable ?
> Hi Chen,
> I think we can choose an arbitrary non-zero number and assign it to the `hash`
> field when the calculated ha
On Wed, 2 Apr 2025 18:38:17 GMT, Kim Barrett wrote:
>> Kim Barrett has updated the pull request incrementally with three additional
>> commits since the last revision:
>>
>> - remove timeout by using waitForReferenceProcessing
>> - make ill-timed gc in non-concurrent case less likely
>> - fi
> Changes for [JEP draft: Structured Concurrency (Fifth
> Preview)](https://openjdk.org/jeps/8340343). The JEP isn't on the technical
> roadmap yet. The proposal is to re-preview the API with some changes,
> specifically:
>
> - A
> [StructuredTaskScope](https://download.java.net/java/early_acc
On Thu, 10 Apr 2025 18:26:39 GMT, Vladimir Kozlov wrote:
>> src/java.base/share/classes/java/lang/ref/Reference.java line 357:
>>
>>> 355: @IntrinsicCandidate
>>> 356: public T get() {
>>> 357: return get0();
>>
>> I am looking at this now and wondering how current intrinsics ma
On Thu, 10 Apr 2025 21:50:10 GMT, Alexey Semenyuk wrote:
> Escape the dollar sign.
Thanks for jumping on this.
-
Marked as reviewed by alanb (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/24585#pullrequestreview-2759425326
On Fri, 11 Apr 2025 07:11:19 GMT, Matthias Baesken wrote:
>> JLI_ReportErrorMessageSys is not used any more on Windows, so we can remove
>> it and make it UNIX-only (there a still a few remaining usages).
>
> Matthias Baesken has updated the pull request incrementally with one
> additional comm
On Sat, 5 Apr 2025 04:49:03 GMT, Christoph Langer wrote:
>> Severin Gehwolf has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains four additional
>> c
On Wed, 9 Apr 2025 16:10:20 GMT, Severin Gehwolf wrote:
>> For JEP 493-enabled builds there are no JMODs. Certain files come from the
>> installed JDK image when a user creates a custom run-time from it. This is
>> problematic for example for files that often come from a different package
>> (
> JLI_ReportErrorMessageSys is not used any more on Windows, so we can remove
> it and make it UNIX-only (there a still a few remaining usages).
Matthias Baesken has updated the pull request incrementally with one additional
commit since the last revision:
Adjust COPYRIGHT years
On Thu, 10 Apr 2025 15:42:06 GMT, Alan Bateman wrote:
> I think this looks okay, can you update the copyright header dates before you
> integrate.
Sure, I adjusted the copyright header dates.
-
PR Comment: https://git.openjdk.org/jdk/pull/24563#issuecomment-2796041681
On Thu, 10 Apr 2025 12:08:29 GMT, Hamlin Li wrote:
>> Hi,
>> Can you help to review this patch?
>> On riscv, CMoveI/L already were implemented, but there are some gap:
>> 1. CMoveI/L does not support comparison with float/double, corresponding
>> tests are not turn on either.
>> 2. Some optimiza
71 matches
Mail list logo
