On Wed, 9 Apr 2025 03:57:10 GMT, Fei Yang wrote:
> > It's not some intermittently failure. The majority of them can't work as
> > they use pstack, open core files, use PerfData, etc.. and expected it to be
> > rv64. But core files, pstack are in host arch as we are running qemu-user.
> > I can
On Tue, 8 Apr 2025 21:03:18 GMT, Chen Liang wrote:
>> Oh, I didn't know that. I've built this with JDK 24 as the boot JDK and see
>> no problem.
>
> I think the dependency is in the CreateSymbols tool or something
Yes, we've had issues with boot cycle builds at least, Jan has the details and
I
On Tue, 8 Apr 2025 20:05:26 GMT, Viktor Klang wrote:
>> Follow up to JDK-8319447 to change the VirtualThread implementation to use
>> FJP's delayed task handling.
>>
>> The SPTE based implementation is not removed. It will continue to be used by
>> tests. If custom schedulers are exposed in th
On Fri, 28 Mar 2025 06:53:15 GMT, Robbin Ehn wrote:
> It's not some intermittently failure. The majority of them can't work as they
> use pstack, open core files, use PerfData, etc.. and expected it to be rv64.
> But core files, pstack are in host arch as we are running qemu-user. I can
> remo
On Thu, 17 Oct 2024 00:05:26 GMT, Brian Burkhalter wrote:
> Improve support for Windows directory junctions.
This pull request has been closed without being integrated.
-
PR: https://git.openjdk.org/jdk/pull/21555
On Mon, 7 Apr 2025 07:01:56 GMT, Jan Lahoda wrote:
>> src/java.base/share/classes/java/lang/IO.java line 183:
>>
>>> 181: * @return the internal BufferedReader instance
>>> 182: */
>>> 183: static synchronized BufferedReader reader() {
>>
>> Is the lock only inteneded for initiali
On Mon, 7 Apr 2025 13:55:27 GMT, Viktor Klang wrote:
>> I'm breaking this change out as a separate improvement, since it will not be
>> generally possible to adjust these limits on the j.u.c primitives since they
>> might already use a backing `long` to pack in information which needs to be
>>
On Tue, 8 Apr 2025 21:19:06 GMT, Roger Riggs wrote:
>> Certain specific types of tests involving GC and reference processing need
>> to account for the delay between a GC completing (during which the GC clears
>> a Reference), and the Reference being added to its associated queue. At
>> presen
> Finalize the KDF API.
Weijun Wang has updated the pull request incrementally with one additional
commit since the last revision:
add enum back
-
Changes:
- all: https://git.openjdk.org/jdk/pull/24520/files
- new: https://git.openjdk.org/jdk/pull/24520/files/4ff3b95b..66706a
> This proposed change would move the native objects required for NIO file
> interaction from the libnio native library to the libjava native library on
> Linux, macOS, and Windows.
Brian Burkhalter has updated the pull request with a new target base due to a
merge or a rebase. The pull request
On Tue, 8 Apr 2025 20:20:56 GMT, Brent Christian wrote:
> Certain specific types of tests involving GC and reference processing need to
> account for the delay between a GC completing (during which the GC clears a
> Reference), and the Reference being added to its associated queue. At
> presen
On Tue, 8 Apr 2025 20:20:56 GMT, Brent Christian wrote:
> Certain specific types of tests involving GC and reference processing need to
> account for the delay between a GC completing (during which the GC clears a
> Reference), and the Reference being added to its associated queue. At
> presen
On Tue, 8 Apr 2025 21:00:41 GMT, Weijun Wang wrote:
>> src/java.base/share/classes/jdk/internal/javac/PreviewFeature.java line 82:
>>
>>> 80: MODULE_IMPORTS,
>>> 81: @JEP(number=478, title="Key Derivation Function API",
>>> status="Preview")
>>> 82: KEY_DERIVATION,
>>
>
On Tue, 8 Apr 2025 19:35:33 GMT, Chen Liang wrote:
>> Finalize the KDF API.
>
> src/java.base/share/classes/jdk/internal/javac/PreviewFeature.java line 82:
>
>> 80: MODULE_IMPORTS,
>> 81: @JEP(number=478, title="Key Derivation Function API",
>> status="Preview")
>> 82: K
On Mon, 7 Apr 2025 06:34:11 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which proposes to address the
> increase in memory footprint of an application that uses signed JAR files,
> signed with `SHA-384` digest algorithm? This addresses
> https://bugs.openjdk.org/browse/
On Thu, 13 Mar 2025 10:48:14 GMT, Alan Bateman wrote:
> Follow up to JDK-8319447 to change the VirtualThread implementation to use
> FJP's delayed task handling.
>
> The SPTE based implementation is not removed. It will continue to be used by
> tests. If custom schedulers are exposed in the fu
With all dependencies of com.sun.tools.classfile in the JDK converted to the
ClassFile API, we can remove this legacy library for release 25 like how we
removed ASM.
Testing: built locally, running tier 1-3 tests
Don't know why, but GitHub is redundantly displaying changes that are already
in
On Sun, 30 Mar 2025 12:34:06 GMT, Markus KARG wrote:
>> This Pull Request proposes an implementation for
>> [JDK-8343110](https://bugs.openjdk.org/browse/JDK-8343110): Adding the new
>> method `public void getChars(int srcBegin, int srcEnd, char[] dst, int
>> dstBegin)` to the `CharSequence` i
On Tue, 8 Apr 2025 18:14:53 GMT, Weijun Wang wrote:
> Finalize the KDF API.
Changes requested by liach (Reviewer).
src/java.base/share/classes/jdk/internal/javac/PreviewFeature.java line 82:
> 80: MODULE_IMPORTS,
> 81: @JEP(number=478, title="Key Derivation Function API",
> st
Finalize the KDF API.
-
Commit messages:
- the change
Changes: https://git.openjdk.org/jdk/pull/24520/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=24520&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8353888
Stats: 42 lines in 16 files changed: 0 ins; 30 del; 12
On Sun, 22 Oct 2023 17:26:52 GMT, Laurent Bourgès wrote:
>> * improved mixed insertion sort (makes whole sorting faster)
>> * introduced Radix which sort shows several times boost of performance and
>> has linear complexity instead of n*ln(n)
>> * improved merging sort for almost sorted data
>>
On Sat, 5 Apr 2025 05:30:25 GMT, Shaojin Wen wrote:
>> Improve the performance of UUID::toString by using Long.expand and SWAR
>> (SIMD within a register) instead of table lookup. Eliminating the table
>> lookup can also avoid the performance degradation problem when the cache
>> misses.
>
> S
On Fri, 4 Apr 2025 21:25:00 GMT, Justin Lu wrote:
> Please review this PR which improves some Currency
> `IllegalArgumentException`s by including the input in the message. This could
> be a currency code, country code, or locale. This change also includes tests
> to check the messages for an i
On Tue, 8 Apr 2025 14:47:04 GMT, Per Minborg wrote:
> This PR proposes to use an anonymous class rather than a lambda in order to
> improve startup time.
>
> We need to make sure the regression is fixed by this. It might be the case
> that the regression is there because
> [JDK-8347047](https
On Tue, 8 Apr 2025 12:09:59 GMT, Timofei Pushkin wrote:
>> If a base class is package-private then its subclasses should have the same
>> package name and defining class loader, otherwise `IllegalAccessError` is
>> thrown when linking a subclass. Currently when dumping a static archive
>> sepa
LinkedBlockingDeque.clear() should preserve weakly-consistent iterators by
linking f.prev and f.next back to f, allowing the iterators to continue from
the first or last respectively. This would be consistent with how the other
node-based weakly consistent queues LinkedBlockingQueue LinkedTransf
On Tue, 8 Apr 2025 16:51:06 GMT, Alan Bateman wrote:
> I think the API docs in the latest draft looks okay. It mildly bothers me a
> bit is that getChars is JDK 1.0 API but the trade off with doing a new API is
> that it would need to be implemented by String and SB so I think the proposal
> o
On Sun, 30 Mar 2025 12:34:06 GMT, Markus KARG wrote:
>> This Pull Request proposes an implementation for
>> [JDK-8343110](https://bugs.openjdk.org/browse/JDK-8343110): Adding the new
>> method `public void getChars(int srcBegin, int srcEnd, char[] dst, int
>> dstBegin)` to the `CharSequence` i
On Tue, 8 Apr 2025 13:37:44 GMT, Per Minborg wrote:
> This PR proposes to increase the threshold for `MemorySegment::fill`
> operations on AArch-64 platforms.
>
> Performance looks good:
>
> 
>
> ![image]
On Fri, 4 Apr 2025 12:42:36 GMT, Sean Mullan wrote:
> Please review this change to terminally deprecate the following security
> related permission classes: `java.security.UnresolvedPermission`,
> `javax.net.ssl.SSLPermission`, `javax.security.auth.AuthPermission`,
> `javax.security.auth.Priva
On Tue, 8 Apr 2025 14:23:06 GMT, Sean Mullan wrote:
>> Please review this change to terminally deprecate the following security
>> related permission classes: `java.security.UnresolvedPermission`,
>> `javax.net.ssl.SSLPermission`, `javax.security.auth.AuthPermission`,
>> `javax.security.auth.P
On Tue, 8 Apr 2025 11:00:27 GMT, David Beaumont wrote:
> 8353683: j.u.l.Handler classes create deadlock risk via synchronized
> publish() method.
>
> 1. Remove synchronization of calls to publish() in Handlers in
> java.util.logging package.
> 2. Add explanatory comments to various affected me
On Tue, 8 Apr 2025 05:12:00 GMT, Jean-Noël Rouvignac wrote:
>> Viktor Klang has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains two additional
>> co
On Tue, 8 Apr 2025 06:41:41 GMT, Alan Bateman wrote:
>> Roger Riggs has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 10 additional
>> commits sin
John,
You may of course do as you like, but as a matter of personal preference I
usually find it more expedient not to file a CSR until the discussion about
what it will contain has become quiescent in the PR itself.
Cheers,
Brian
On Apr 8, 2025, at 5:51 AM, Engebretson, John wrote:
Are we
On Tue, 8 Apr 2025 14:23:06 GMT, Sean Mullan wrote:
>> Please review this change to terminally deprecate the following security
>> related permission classes: `java.security.UnresolvedPermission`,
>> `javax.net.ssl.SSLPermission`, `javax.security.auth.AuthPermission`,
>> `javax.security.auth.P
On Tue, 8 Apr 2025 13:37:44 GMT, Per Minborg wrote:
> This PR proposes to increase the threshold for `MemorySegment::fill`
> operations on AArch-64 platforms.
>
> Performance looks good:
>
> 
>
> ![image]
On Mon, 7 Apr 2025 14:23:52 GMT, Hamlin Li wrote:
> Hi,
> Can you help to review this patch?
> On riscv, CMoveI/L already were implemented, but there are some gap:
> 1. CMoveI/L does not support comparison with float/double, corresponding
> tests are not turn on either.
> 2. Some optimization of
On Tue, 8 Apr 2025 14:19:07 GMT, Jorn Vernee wrote:
> Changes look good, thanks!
>
> Please note that we will have to wait 24 hours before integrating, in order
> to give other reviews time to look as well.
Great, thanks for your review!
I will wait until tomorrow to issue the `/integrate` (a
On Tue, 8 Apr 2025 14:23:06 GMT, Sean Mullan wrote:
>> Please review this change to terminally deprecate the following security
>> related permission classes: `java.security.UnresolvedPermission`,
>> `javax.net.ssl.SSLPermission`, `javax.security.auth.AuthPermission`,
>> `javax.security.auth.P
This PR proposes to use an anonymous class rather than a lambda in order to
improve startup time.
We need to make sure the regression is fixed by this. It might be the case that
the regression is there because
[JDK-8347047](https://bugs.openjdk.org/browse/JDK-8347047) actually fixed an
issue s
> Please review this change to terminally deprecate the following security
> related permission classes: `java.security.UnresolvedPermission`,
> `javax.net.ssl.SSLPermission`, `javax.security.auth.AuthPermission`,
> `javax.security.auth.PrivateCredentialPermission`,
> `javax.security.auth.kerbe
Follow up to JDK-8319447 to change the VirtualThread implementation to use
FJP's delayed task handling.
The SPTE based implementation is not removed. It will continue to be used by
tests. If custom schedulers are exposed in the future then they will use this
implementation.
For timed-Object.wa
On Tue, 8 Apr 2025 13:51:59 GMT, Danish Nawab wrote:
>> ## Description
>>
>> https://bugs.openjdk.org/browse/JDK-8353840
>>
>> ### Existing behavior
>> Log the error message and terminate in case of missing system class
>>
>>
>> $ jnativescan --class-path reactor-core-3.7.4.jar; echo "Exit c
This PR proposes to increase the timeout values for two tests.
-
Commit messages:
- Increase timeouts
Changes: https://git.openjdk.org/jdk/pull/24511/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=24511&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8351757
Stats:
On Tue, 8 Apr 2025 09:36:09 GMT, Viktor Klang wrote:
> Updating the ReentrantReadWriteLock documentation
This pull request has now been integrated.
Changeset: 676cfae9
Author:Viktor Klang
URL:
https://git.openjdk.org/jdk/commit/676cfae91c8bd4799adfedff2ad59a9aab953ece
Stats: 2 l
> ## Description
>
> https://bugs.openjdk.org/browse/JDK-8353840
>
> ### Existing behavior
> Log the error message and terminate in case of missing system class
>
>
> $ jnativescan --class-path reactor-core-3.7.4.jar; echo "Exit code: $?"
>
> ERROR: Error while processing method:
> reactor.c
On Tue, 8 Apr 2025 12:22:40 GMT, Jorn Vernee wrote:
>> I see what you mean. Let me take a crack at it.
>
> One more thought: I think we should only print the error messages as part of
> `dumpAll` and not `printNativeAccess`, so that the result of the latter can
> still be piped directly to `--e
> ## Description
>
> https://bugs.openjdk.org/browse/JDK-8353840
>
> ### Existing behavior
> Log the error message and terminate in case of missing system class
>
>
> $ jnativescan --class-path reactor-core-3.7.4.jar; echo "Exit code: $?"
>
> ERROR: Error while processing method:
> reactor.c
On Tue, 8 Apr 2025 13:43:54 GMT, Danish Nawab wrote:
>> ## Description
>>
>> https://bugs.openjdk.org/browse/JDK-8353840
>>
>> ### Existing behavior
>> Log the error message and terminate in case of missing system class
>>
>>
>> $ jnativescan --class-path reactor-core-3.7.4.jar; echo "Exit c
This PR proposes to increase the threshold for `MemorySegment::fill` operations
on AArch-64 platforms.
Performance looks good:
;
>>> 78: ClassResolver systemCl
Brian, Alan, Markus, Chen – thank you for your feedback on this issue! At
this point we seem to agree that 1) there is merit to this idea, 2) nobody
loves a new public class (including me), and 3) this is not a subclass of
ByteArrayOutputStream. Are we ready to move this to CSR and continue
On Tue, 8 Apr 2025 08:18:36 GMT, Danish Nawab wrote:
> ## Description
>
> https://bugs.openjdk.org/browse/JDK-8353840
>
> ### Existing behavior
> Log the error message and terminate in case of missing system class
>
>
> $ jnativescan --class-path reactor-core-3.7.4.jar; echo "Exit code: $?"
On Mon, 7 Apr 2025 14:23:52 GMT, Hamlin Li wrote:
> Hi,
> Can you help to review this patch?
> On riscv, CMoveI/L already were implemented, but there are some gap:
> 1. CMoveI/L does not support comparison with float/double, corresponding
> tests are not turn on either.
> 2. Some optimization of
> This PR proposes to add some `@ForceInline` annotations in the `Module` class
> in order to assist inlining of FFM var/method handles.
>
> There are also some changes in other classes which, if implemented, can take
> us three additional levels of inlining. I drew a line there. There is a
> t
On Tue, 8 Apr 2025 12:12:36 GMT, Jorn Vernee wrote:
>> ## Description
>>
>> https://bugs.openjdk.org/browse/JDK-8353840
>>
>> ### Existing behavior
>> Log the error message and terminate in case of missing system class
>>
>>
>> $ jnativescan --class-path reactor-core-3.7.4.jar; echo "Exit co
On Tue, 8 Apr 2025 11:33:54 GMT, Per Minborg wrote:
>> This PR proposes to add some `@ForceInline` annotations in the `Module`
>> class in order to assist inlining of FFM var/method handles.
>>
>> There are also some changes in other classes which, if implemented, can take
>> us three addition
On Mon, 31 Mar 2025 10:45:54 GMT, Robbin Ehn wrote:
>> Hi, for you to consider.
>>
>> These tests constantly fails in qemu-user.
>> Either the require host to be same arch explicit or implicit (sysroot).
>> E.g. "ptrace(PTRACE_ATTACH, ..) failed for 405157: Function not
>> implemented'" for SA
On Tue, 8 Apr 2025 08:18:36 GMT, Danish Nawab wrote:
> ## Description
>
> https://bugs.openjdk.org/browse/JDK-8353840
>
> ### Existing behavior
> Log the error message and terminate in case of missing system class
>
>
> $ jnativescan --class-path reactor-core-3.7.4.jar; echo "Exit code: $?"
On Mon, 7 Apr 2025 14:23:52 GMT, Hamlin Li wrote:
> the reason is the generated code by Zicond is much larger than branch version
I'm curious about this one. It's surprising to me that we see bigger code
generated with Zicond. Do you know why that is the case?
-
PR Comment: https:
On Wed, 19 Feb 2025 14:23:04 GMT, Per Minborg wrote:
> This PR proposes to add the `final` keyword to some classes and methods in
> order to assist compiler devirtualization (e.g. in Graal native image).
>
> Passes `make test TEST=jdk_foreign`
This pull request has been closed without being in
> If a base class is package-private then its subclasses should have the same
> package name and defining class loader, otherwise `IllegalAccessError` is
> thrown when linking a subclass. Currently when dumping a static archive
> separate `URLClassLoader`s are used for each unregistered classes'
On Tue, 8 Apr 2025 11:55:58 GMT, Danish Nawab wrote:
>> Also, instead of passing `err` down to this code, I think we should define
>> an interface for `NativeMethodFinder` to log diagnostics instead. e.g.
>> something like:
>>
>>
>> interface Diagnostics {
>> void error(MethodRef context,
On Tue, 8 Apr 2025 11:45:49 GMT, Jorn Vernee wrote:
>> src/jdk.jdeps/share/classes/com/sun/tools/jnativescan/NativeMethodFinder.java
>> line 91:
>>
>>> 89: err.println("Error while processing
>>> method: " +
>>> 90: MethodRef.of
On Tue, 8 Apr 2025 11:41:15 GMT, Jorn Vernee wrote:
>> ## Description
>>
>> https://bugs.openjdk.org/browse/JDK-8353840
>>
>> ### Existing behavior
>> Log the error message and terminate in case of missing system class
>>
>>
>> $ jnativescan --class-path reactor-core-3.7.4.jar; echo "Exit co
On Mon, 7 Apr 2025 16:36:07 GMT, Jorn Vernee wrote:
> `jnativescan` uses the `ClassResolver` class to find both system classes, as
> well as application classes. In principle, a class resolver supports both
> iterating over all classes from that particular source, as well as looking up
> class
`jnativescan` uses the `ClassResolver` class to find both system classes, as
well as application classes. In principle, a class resolver supports both
iterating over all classes from that particular source, as well as looking up
classes by name. However, the `ClassResolver` for system classes do
On Fri, 7 Feb 2025 19:25:04 GMT, Chen Liang wrote:
> Make UnknownAttribute and CustomAttribute delivered in code traversal, and
> make sure stack maps update the label references after a code transform when
> it is reused. Other code-bound attributes are not updated as they cannot be
> supplie
On Mon, 7 Apr 2025 16:00:27 GMT, Ioi Lam wrote:
>> Timofei Pushkin has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Don't use URLClassPath
>
> src/hotspot/share/cds/classListParser.cpp line 534:
>
>> 532: GrowableArray specified_interf
On Tue, 8 Apr 2025 11:00:27 GMT, David Beaumont wrote:
> 8353683: j.u.l.Handler classes create deadlock risk via synchronized
> publish() method.
>
> 1. Remove synchronization of calls to publish() in Handlers in
> java.util.logging package.
> 2. Add explanatory comments to various affected me
8353683: j.u.l.Handler classes create deadlock risk via synchronized publish()
method.
1. Remove synchronization of calls to publish() in Handlers in
java.util.logging package.
2. Add explanatory comments to various affected methods.
3. Add a test to ensure deadlocks no longer occur.
Note that
On Tue, 1 Apr 2025 17:33:43 GMT, Alan Bateman wrote:
> `jmod create` maps the contents of the module to a set of packages. This
> mapping derives illegal package names when class resources are located in
> non-package locations, e.g. in the META-INF tree. `jlink` also has an issue
> in this ar
On Tue, 8 Apr 2025 07:07:12 GMT, Fei Yang wrote:
> Maybe we should check UseZicond and only enable UseCMoveUnconditionally &
> ConditionalMoveLimit conditionally?
Not sure what do you mean here.
> I don't see how enabling CMove will bring us any performance benefit without
> Zicond. It's done
On Tue, 8 Apr 2025 10:11:45 GMT, Viktor Klang wrote:
>> Updating the ReentrantReadWriteLock documentation
>
> Viktor Klang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Update
> src/java.base/share/classes/java/util/concurrent/locks/Reen
On Tue, 8 Apr 2025 10:08:26 GMT, Viktor Klang wrote:
>> Updating the ReentrantReadWriteLock documentation
>
> Viktor Klang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Update
> src/java.base/share/classes/java/util/concurrent/locks/Reen
> Updating the ReentrantReadWriteLock documentation
Viktor Klang has updated the pull request incrementally with one additional
commit since the last revision:
Update
src/java.base/share/classes/java/util/concurrent/locks/ReentrantReadWriteLock.java
Removing space
-
Changes
Updating the ReentrantReadWriteLock documentation
-
Commit messages:
- Adding links
- Updates ReentrantReadWriteLock to state the new hold capacities
Changes: https://git.openjdk.org/jdk/pull/24502/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=24502&range=00
Issue: htt
On Tue, 1 Apr 2025 00:59:57 GMT, Jason Zaugg wrote:
>> 8352642: Set zipinfo-time=false when constructing zipfs FileSystem in
>> com.sun.tools.javac.file.JavacFileManager$ArchiveContainer for better
>> performance
>
> Jason Zaugg has updated the pull request incrementally with one additional
>
Thanks for your analysis and explanation.
I took the liberty to propose a PR for JDK-8353840:
https://github.com/openjdk/jdk/pull/24499
I would really appreciate a review on this.
From: Jorn Vernee
Sent: Monday, April 7, 2025 3:46 AM
To: Danish Nawab ; core-lib
On Sat, 5 Apr 2025 00:35:35 GMT, Chen Liang wrote:
>> Hannes Wallnöfer has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Review feedback: add Utils.isVisible(TypeElement) method
>
> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclet
> Please review an enhancement to treat classes and interfaces that are not
> included and not unconditionally exported as hidden. This means they do not
> show up in the generated documentation even if they are implemented or
> extended by a documented type.
>
> This change makes the `@hidden
## Description
https://bugs.openjdk.org/browse/JDK-8353840
### Existing behavior
Log the error message and terminate in case of missing system class
### New behavior
Still log the error message about the missing system class, but continue the
analysis
## Design choices
Propagate `err` all th
On Mon, 7 Apr 2025 14:23:52 GMT, Hamlin Li wrote:
> Hi,
> Can you help to review this patch?
> On riscv, CMoveI/L already were implemented, but there are some gap:
> 1. CMoveI/L does not support comparison with float/double, corresponding
> tests are not turn on either.
> 2. Some optimization of
85 matches
Mail list logo
