Re: RFR: 8353741: Improve UUID.toString performance by using SIMD within a register instead of table lookup [v3]

2025-04-04 Thread Shaojin Wen
> Improve the performance of UUID::toString by using Long.expand and SWAR (SIMD > within a register) instead of table lookup. Eliminating the table lookup can > also avoid the performance degradation problem when the cache misses. Shaojin Wen has updated the pull request incrementally with one a

Re: RFR: 8066583: DeflaterInput/OutputStream and InflaterInput/OutputStream should explain responsibility for freeing resources [v9]

2025-04-04 Thread Lance Andersen
On Thu, 3 Apr 2025 12:55:11 GMT, Jaikiran Pai wrote: >> Can I please get a review of this doc-only change which proposes to improve >> the API documentation of `DeflaterInputStream`, `DeflaterOutputStream`, >> `InflaterInputStream` and `InflaterOutputStream` classes? >> >> As noted in https://

Re: RFR: 8353185: Introduce the concept of upgradeable files in context of JEP 493 [v2]

2025-04-04 Thread Christoph Langer
On Fri, 4 Apr 2025 15:22:10 GMT, Severin Gehwolf wrote: >> For JEP 493-enabled builds there are no JMODs. Certain files come from the >> installed JDK image when a user creates a custom run-time from it. This is >> problematic for example for files that often come from a different package >> (

Re: RFR: 8351996: Behavioral updates for ClassValue::remove [v5]

2025-04-04 Thread Chen Liang
On Fri, 21 Mar 2025 19:44:48 GMT, Chen Liang wrote: >> The recent patch #23866 makes calling `ClassValue::remove()` from >> `ClassValue::computeValue()` end up in infinite loops while fixing the stale >> value risk from the method. >> >> The proposed fix is to preserve the stale value risk fix

Re: RFR: 8353786: Migrate Vector API math library support to FFM API

2025-04-04 Thread Chen Liang
On Fri, 4 Apr 2025 22:52:24 GMT, Vladimir Ivanov wrote: > Migrate Vector API math library (SVML and SLEEF) linkage from native code (in > JVM) to Java FFM API. > > Since FFM API doesn't support vector calling conventions yet, migration > affects only symbol lookup for now. But it still enables

RFR: 8353786: Migrate Vector API math library support to FFM API

2025-04-04 Thread Vladimir Ivanov
Migrate Vector API math library (SVML and SLEEF) linkage from native code (in JVM) to Java FFM API. Since FFM API doesn't support vector calling conventions yet, migration affects only symbol lookup for now. But it still enables significant simplifications on JVM side. The patch consists of th

Re: Add "SHA-384" as a known attribute

2025-04-04 Thread Jaikiran Pai
Thank you for reporting this issue and providing the details. I have created https://bugs.openjdk.org/browse/JDK-8353787 to track this. Any fixes done related to this issue will be first done against the mainline JDK and the project members that manage the update releases (https://openjdk.org/p

Re: RFR: 8349176: Speed up Integer/Long.toString via Unsafe.allocateUninitializedArray [v2]

2025-04-04 Thread Shaojin Wen
> The byte[] allocated in Integer/Long.toString is fully filled, so we can use > Unsafe.allocateUninitializedArray to create byte[] to improve performance. Shaojin Wen has updated the pull request incrementally with one additional commit since the last revision: use StringConcatHelper.newArra

Re: RFR: 8349176: Speed up Integer/Long.toString via StringConcatHelper::newArray [v2]

2025-04-04 Thread Shaojin Wen
On Sat, 5 Apr 2025 01:19:39 GMT, Shaojin Wen wrote: >> The byte[] allocated in Integer/Long.toString is fully filled, so we can use >> StringConcatHelper::newArray to create byte[] to improve performance. > > Shaojin Wen has updated the pull request incrementally with one additional > commit si

Re: RFR: 8254622: Hide superclasses from conditionally exported packages

2025-04-04 Thread Chen Liang
On Fri, 4 Apr 2025 13:36:19 GMT, Hannes Wallnöfer wrote: > Please review an enhancement to treat classes and interfaces that are not > included and not unconditionally exported as hidden. This means they do not > show up in the generated documentation even if they are implemented or > extended

Re: RFR: 8346719: Add relaunchers to the static JDK image for missing executables

2025-04-04 Thread Magnus Ihse Bursie
On Wed, 2 Apr 2025 14:54:35 GMT, Magnus Ihse Bursie wrote: > In the static JDK image, a single humongous java executable is generated, and > no other launcher, such as javac. This makes it impossible to run our jtreg > tests, which assume these are present. > > The solution is fortunately simp

RFR: 8351740: Clean up some code around initialization of encoding properties

2025-04-04 Thread Stuart Marks
Various behavior-preserving code cleanups related to system properties related to character encodings. - Commit messages: - More minor cleanups, reversion of some extra changes. - WIP: add some non-null asserts and comments on sprops encoding members - A couple small tweaks. - Me

Re: RFR: 8304674: File java.c compile error with -fsanitize=address -O0

2025-04-04 Thread SendaoYan
On Mon, 31 Mar 2025 12:57:38 GMT, Magnus Ihse Bursie wrote: >> Hi all, >> File src/java.base/share/native/libjli/java.c compile error: control reaches >> end of non-void function [-Werror=return-type] with gcc options >> -fsanitize=address -O0. The function int JavaMain(void* _args) in this fil

Re: RFR: 8351565: Implement JEP 502: Stable Values (Preview) [v17]

2025-04-04 Thread Per Minborg
> Implement JEP 502. > > The PR passes tier1-tier3 tests. Per Minborg has updated the pull request incrementally with one additional commit since the last revision: Fix issue in StableIntFunction related to wrapped exceptions - Changes: - all: https://git.openjdk.org/jdk/pull/

Re: RFR: 8353322: Specification of ChoiceFormat#parse(String, ParsePosition) is inadequate [v3]

2025-04-04 Thread Alan Bateman
On Wed, 2 Apr 2025 19:43:29 GMT, Justin Lu wrote: >> src/java.base/share/classes/java/text/ChoiceFormat.java line 562: >> >>> 560: /** >>> 561: * Parses a {@code Number} from the input text, the subtype of >>> which is always >>> 562: * {@code Double}. The value returned is the {@

Re: RFR: 8353713: Improve Currency.getInstance exception handling [v2]

2025-04-04 Thread Justin Lu
> Please review this PR which improves some Currency > `IllegalArgumentException`s by including the input in the message. This could > be a currency code, country code, or locale. This change also includes tests > to check the messages for an invalid country via the region override as well > as

Re: RFR: 8351565: Implement JEP 502: Stable Values (Preview) [v13]

2025-04-04 Thread Per Minborg
> Implement JEP 502. > > The PR passes tier1-tier3 tests. Per Minborg has updated the pull request incrementally with one additional commit since the last revision: Improve StableMapEntrySet::toString - Changes: - all: https://git.openjdk.org/jdk/pull/23972/files - new: http

Re: RFR: 8353713: Improve Currency.getInstance exception handling

2025-04-04 Thread Naoto Sato
On Fri, 4 Apr 2025 21:25:00 GMT, Justin Lu wrote: > Please review this PR which improves some Currency > `IllegalArgumentException`s by including the input in the message. This could > be a currency code, country code, or locale. This change also includes tests > to check the messages for an i

Integrated: 8349206: j.u.l.Handler classes create deadlock risk via synchronized publish() method

2025-04-04 Thread David Beaumont
On Thu, 6 Feb 2025 12:07:57 GMT, David Beaumont wrote: > 8349206: j.u.l.Handler classes create deadlock risk via synchronized > publish() method. > > 1. Remove synchronization of calls to publish() in Handlers in > java.util.logging package. > 2. Add explanatory comments to various affected me

Re: RFR: 8351565: Implement JEP 502: Stable Values (Preview) [v8]

2025-04-04 Thread Maurizio Cimadamore
On Tue, 25 Mar 2025 16:23:20 GMT, Per Minborg wrote: > I have rewritten all the `toString()` methods. A `StableList::toString` now > produces something much more similar to a regular `List::toString`. The only > difference is that the `StableList::toString` shows ".unset" for the elements > th

RFR: 8353458: Don't pass -Wno-format-nonliteral to CFLAGS

2025-04-04 Thread Magnus Ihse Bursie
The proper way to disable warnings is to use the DISABLED_WARNINGS arguments. In this particular case, there was already a pragma but due to incorrect restrictions it did not apply to clang. - Commit messages: - 8353458: Don't pass -Wno-format-nonliteral to CFLAGS Changes: https:/

Withdrawn: JDK-8348030 : Extend Math.min and Math.max to support multiple parameters

2025-04-04 Thread duke
On Wed, 15 Jan 2025 14:26:32 GMT, Aviad Zer wrote: > This change extends the Math.min function to support multiple parameters, > improving its usability and code readability. > > Previously, finding the minimum value among multiple variables required using > nested Math.min calls or converting

Re: Reg: Proposal: Generalized Number.parseNumber(String) Method for Java

2025-04-04 Thread Volkan Yazıcı
Sathish, would you mind elaborating on your use case a bit more, please? That is, I am not able to see where and how you want to leverage `Number#parseNumber(String)` in the `testNumberMemoryUsage()` method. Example: *"I have this test method verifying this behavior of that application. Given a `Nu

RFR: 8353713: Improve Currency.getInstance exception handling

2025-04-04 Thread Justin Lu
Please review this PR which improves some Currency `IllegalArgumentException`s by including the input in the message. This could be a currency code, country code, or locale. This change also includes tests to check the messages for an invalid country via the region override as well as an invalid

Re: RFR: 8341641: Make %APPDATA% and %LOCALAPPDATA% env variables available in *.cfg files [v4]

2025-04-04 Thread Alexey Semenyuk
> jpackage app laucnher will expand environment variables in .cfg files. > > Previously jpackage app launcher only replaced `$APPDIR`, `$BINDIR`, and > `$ROOTDIR` tokens with the corresponding path values. With this patch, any > environment variable can be expanded. The syntax is shell-like > `

Re: RFR: 8315130: java.lang.IllegalAccessError when processing classlist to create CDS archive [v3]

2025-04-04 Thread Ioi Lam
On Fri, 4 Apr 2025 18:13:24 GMT, Timofei Pushkin wrote: >> src/java.base/share/classes/jdk/internal/misc/CDS.java line 446: >> >>> 444: protected Class findClass(String name) throws >>> ClassNotFoundException { >>> 445: // Unregistered classes should be found in load(...),

Re: RFR: 8315130: java.lang.IllegalAccessError when processing classlist to create CDS archive [v3]

2025-04-04 Thread Ioi Lam
On Fri, 4 Apr 2025 18:17:14 GMT, Timofei Pushkin wrote: >> src/java.base/share/classes/jdk/internal/misc/CDS.java line 420: >> >>> 418: // class loader. Thus it is safe to delegate their >>> loading to system class loader >>> 419: // (our parent) - this is what t

Re: RFR: 8351565: Implement JEP 502: Stable Values (Preview) [v41]

2025-04-04 Thread ExE Boss
On Fri, 4 Apr 2025 09:14:22 GMT, Per Minborg wrote: >> Implement JEP 502. >> >> The PR passes tier1-tier3 tests. > > Per Minborg has updated the pull request incrementally with one additional > commit since the last revision: > > Address comments on docs src/java.base/share/classes/jdk/inte

Re: RFR: 8353234: Refactor XMLSecurityPropertyManager

2025-04-04 Thread Joe Wang
On Mon, 31 Mar 2025 19:18:58 GMT, Joe Wang wrote: >> LGTM. Technically it is still March in PDT though > >> LGTM. Technically it is still March in PDT though > > Thanks. It is, tricky. Thought by the time it's out, it would be April. > @JoeWang-Java, > > Can you confirm which Mach5 tiers have

Re: RFR: 8351565: Implement JEP 502: Stable Values (Preview) [v25]

2025-04-04 Thread Maurizio Cimadamore
On Wed, 2 Apr 2025 09:13:21 GMT, Per Minborg wrote: >> src/java.base/share/classes/java/lang/StableValue.java line 52: >> >>> 50: * A stable value is a deferred holder of shallowly immutable content. >>> 51: * >>> 52: * A {@code StableValue} can be created using the factory method >> >> s/c

Re: RFR: 8341402: BigDecimal's square root optimization [v31]

2025-04-04 Thread fabioromano1
On Wed, 4 Dec 2024 14:56:02 GMT, fabioromano1 wrote: >> After changing `BigInteger.sqrt()` algorithm, this can be also used to speed >> up `BigDecimal.sqrt()` implementation. Here is how I made it. >> >> The main steps of the algorithm are as follows: >> first argument reduce the value to an in

Re: JDK-8352891 Performance improvements to ByteArrayOutputStream

2025-04-04 Thread Brian Burkhalter
I did not notice that Alan’s comment below, about adding a hint as to the maximum expected size, has been specifically addressed anywhere in this discussion. It might not be all that pertinent to the main thread of discussion, however, but it would certainly be useful for the issue [1], which I

Re: RFR: 8352046: Test testEcoFriendly() in jdk tools launcher ExecutionEnvironment.java makes no sense for aix and musl

2025-04-04 Thread Christoph Langer
On Fri, 21 Mar 2025 09:46:02 GMT, Joachim Kern wrote: >> The test `testEcoFriendly()` checks if the launcher pollutes the >> `LD_LIBRARY_PATH` environment variable. >> Because aix and musl intentionally pollute the `LD_LIBRARY_PATH`, it does >> not make sense to make this test somehow passing w

RFR: 8352533: Report useful IOExceptions when jspawnhelper fails

2025-04-04 Thread Aleksey Shipilev
When jspawnhelper fails for whatever reason, but more prominently due to [JDK-8325621](https://bugs.openjdk.org/browse/JDK-8325621), it will report the errors into stdout, but not to the relevant `IOException`. So, if the application is configured to only capture the exception logs (e.g. through

Re: RFR: 8351565: Implement JEP 502: Stable Values (Preview) [v15]

2025-04-04 Thread Per Minborg
> Implement JEP 502. > > The PR passes tier1-tier3 tests. Per Minborg has updated the pull request incrementally with one additional commit since the last revision: Add test and comments about null keys - Changes: - all: https://git.openjdk.org/jdk/pull/23972/files - new: ht

Re: RFR: 8353185: Introduce the concept of upgradeable files in context of JEP 493

2025-04-04 Thread Alan Bateman
On Thu, 3 Apr 2025 06:12:35 GMT, Bernd wrote: > What about changes to conf files, especially Java.security (for hardening TLS > settings) - or at least pointing to a include? The opposite is where weaker or insecure algorithms are enabled, wouldn't want that copied by jlink into another run-ti

RFR: 8353489: Increase Timeout and Improve Windows Compatibility in Basic.java Test

2025-04-04 Thread Oleksii Sylichenko
This PR proposes three improvements to the `Basic.java` test: 1. Increase Timeout - The current timeout is insufficient when running the test in IntelliJ IDEA. - I propose increasing it by one minute. - The timeout value was last modified on May 13, 2010 (commit [56131863a71c](https://gi

Re: RFR: 8339543: [vectorapi] laneHelper and withLaneHelper should be ForceInline

2025-04-04 Thread Paul Sandoz
On Fri, 21 Mar 2025 17:38:53 GMT, Ian Graves wrote: > Adding ForceInline to helper methods. Marked as reviewed by psandoz (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/24165#pullrequestreview-2707336821

Re: RFR: 8319447: Improve performance of delayed task handling [v12]

2025-04-04 Thread Joe Darcy
On Sat, 22 Mar 2025 11:09:03 GMT, Doug Lea wrote: >> (Copied from https://bugs.openjdk.org/browse/JDK-8319447) >> >> The problems addressed by this CR/PR are that ScheduledThreadPoolExecutor is >> both ill-suited for many (if not most) of its applications, and is a >> performance bottleneck (a

Re: RFR: 8352016: Improve java/lang/RuntimeTests/RuntimeExitLogTest.java [v2]

2025-04-04 Thread Mikhail Yankelevich
On Fri, 21 Mar 2025 09:01:01 GMT, KIRIYAMA Takuya wrote: >> test/jdk/java/lang/RuntimeTests/RuntimeExitLogTest.java line 52: >> >>> 50: private static final String TEST_JDK = >>> System.getProperty("test.jdk"); >>> 51: private static final String TEST_SRC = >>> System.getProperty("test

Re: RFR: 8353641: Deprecate core library permission classes for removal [v6]

2025-04-04 Thread Roger Riggs
> Now that the Security Manager is permanently disabled, the following > permission classes in the core libraries area can be deprecated for removal > as they are no longer useful: FilePermission, LinkPermission, > LoggingPermission, PropertyPermission, ReflectPermission, RuntimePermission, > a

Re: RFR: 8351565: Implement JEP 502: Stable Values (Preview) [v33]

2025-04-04 Thread Viktor Klang
On Thu, 3 Apr 2025 08:39:47 GMT, Per Minborg wrote: >> src/java.base/share/classes/java/lang/StableValue.java line 377: >> >>> 375: * >>> 376: * Thread Safety >>> 377: * The content of a stable value is guaranteed to be set at most once. >>> If competing >> >> Suggestion: >> >> * The cont

Re: RFR: 8353641: Deprecate core library permission classes for removal [v4]

2025-04-04 Thread Sean Mullan
On Fri, 4 Apr 2025 19:00:02 GMT, Roger Riggs wrote: >> Now that the Security Manager is permanently disabled, the following >> permission classes in the core libraries area can be deprecated for removal >> as they are no longer useful: FilePermission, LinkPermission, >> LoggingPermission, Prop

Re: RFR: 8353641: Deprecate core library permission classes for removal [v5]

2025-04-04 Thread Roger Riggs
> Now that the Security Manager is permanently disabled, the following > permission classes in the core libraries area can be deprecated for removal > as they are no longer useful: FilePermission, LinkPermission, > LoggingPermission, PropertyPermission, ReflectPermission, RuntimePermission, > a

Re: RFR: 8353585: Provide ChoiceFormat#parse(String, ParsePosition) tests

2025-04-04 Thread Naoto Sato
On Wed, 2 Apr 2025 22:27:14 GMT, Justin Lu wrote: > Please review this PR which provides unit tests for > `ChoiceFormat#parse(String, ParsePosition)` to check default, multi match, > and no match behavior. There were no existing relevant tests. Looks good. test/jdk/java/text/Format/ChoiceForm

Re: RFR: 8353641: Deprecate core library permission classes for removal [v4]

2025-04-04 Thread Sean Mullan
On Fri, 4 Apr 2025 19:00:02 GMT, Roger Riggs wrote: >> Now that the Security Manager is permanently disabled, the following >> permission classes in the core libraries area can be deprecated for removal >> as they are no longer useful: FilePermission, LinkPermission, >> LoggingPermission, Prop

Re: RFR: 8353641: Deprecate core library permission classes for removal [v4]

2025-04-04 Thread Roger Riggs
> Now that the Security Manager is permanently disabled, the following > permission classes in the core libraries area can be deprecated for removal > as they are no longer useful: FilePermission, LinkPermission, > LoggingPermission, PropertyPermission, ReflectPermission, RuntimePermission, > a

Integrated: 8351290: Clarify integral only for vector operators

2025-04-04 Thread Ian Graves
On Tue, 25 Mar 2025 20:44:31 GMT, Ian Graves wrote: > Updating Javadoc for vector operators with VO_NOFP flags, but no > corresponding "Integral only." note in docs. This pull request has now been integrated. Changeset: fe8bd756 Author:Ian Graves URL: https://git.openjdk.org/jdk/co

Re: RFR: 8351565: Implement JEP 502: Stable Values (Preview) [v33]

2025-04-04 Thread Per Minborg
On Wed, 2 Apr 2025 14:42:17 GMT, Viktor Klang wrote: >> Per Minborg has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Add info that Map#values and Map#entrySet are stable > > src/java.base/share/classes/java/lang/StableValue.java line 567:

Re: RFR: 8353234: Refactor XMLSecurityPropertyManager

2025-04-04 Thread Lance Andersen
On Mon, 31 Mar 2025 17:42:20 GMT, Joe Wang wrote: > Refactor XMLSecurityPropertyManager. > The Xerces and Xalan components each had its own XMLSecurityManager and > XMLSecurityPropertyManager. In a previous fix, the former had been unified as > part of that changeset. This change will allow fut

Re: RFR: 8351565: Implement JEP 502: Stable Values (Preview) [v21]

2025-04-04 Thread Per Minborg
On Mon, 31 Mar 2025 13:32:56 GMT, Per Minborg wrote: >> Implement JEP 502. >> >> The PR passes tier1-tier3 tests. > > Per Minborg has updated the pull request incrementally with one additional > commit since the last revision: > > Finish and clean up benchmarks Here are the latest benchmark

Re: RFR: 8353641: Deprecate core library permission classes for removal [v3]

2025-04-04 Thread Iris Clark
On Fri, 4 Apr 2025 18:21:29 GMT, Roger Riggs wrote: >> Now that the Security Manager is permanently disabled, the following >> permission classes in the core libraries area can be deprecated for removal >> as they are no longer useful: FilePermission, LinkPermission, >> LoggingPermission, Prop

Re: RFR: 8351565: Implement JEP 502: Stable Values (Preview) [v8]

2025-04-04 Thread Johannes Graham
On Tue, 25 Mar 2025 15:52:07 GMT, Per Minborg wrote: >> Implement JEP 502. >> >> The PR passes tier1-tier3 tests. > > Per Minborg has updated the pull request incrementally with one additional > commit since the last revision: > > Revamp toString() methods src/java.base/share/classes/jdk/in

Re: RFR: 8348967: Deprecate security permission classes for removal [v2]

2025-04-04 Thread Iris Clark
On Fri, 4 Apr 2025 18:04:39 GMT, Sean Mullan wrote: >> Please review this change to terminally deprecate the following security >> related permission classes: `java.security.UnresolvedPermission`, >> `javax.net.ssl.SSLPermission`, `javax.security.auth.AuthPermission`, >> `javax.security.auth.P

Re: RFR: 8348967: Deprecate security permission classes for removal [v2]

2025-04-04 Thread Roger Riggs
On Fri, 4 Apr 2025 18:04:39 GMT, Sean Mullan wrote: >> Please review this change to terminally deprecate the following security >> related permission classes: `java.security.UnresolvedPermission`, >> `javax.net.ssl.SSLPermission`, `javax.security.auth.AuthPermission`, >> `javax.security.auth.P

Re: RFR: 8351565: Implement JEP 502: Stable Values (Preview) [v25]

2025-04-04 Thread Maurizio Cimadamore
On Tue, 1 Apr 2025 13:27:34 GMT, Per Minborg wrote: >> Implement JEP 502. >> >> The PR passes tier1-tier3 tests. > > Per Minborg has updated the pull request incrementally with two additional > commits since the last revision: > > - Add lazy toSting for StableMap::values > - Make toString fo

Re: Add "SHA-384" as a known attribute

2025-04-04 Thread Ayman
Yes, I started looking into this because of a memory regression. While upgrading our project from Java 17 to Java 21, I noticed an increase in memory consumption. After dumping the heap and analyzing the differences, I found that there are a few thousand instances of the class "java.util.jar.Attrib

Re: RFR: 8352016: Improve java/lang/RuntimeTests/RuntimeExitLogTest.java [v2]

2025-04-04 Thread KIRIYAMA Takuya
> The current test program for the logging feature added in JDK-8301627 does > not fully check some important cases. > > Issue Details: > The test does not properly check cases where logging might not happen due to > different logging levels. (e.g. ALL, TRACE, WARNING, etc.) > The check for the

Re: RFR: 8351322: Parameterize link option for pthreads [v2]

2025-04-04 Thread David Holmes
On Thu, 20 Mar 2025 12:38:37 GMT, Magnus Ihse Bursie wrote: > Is there any gain then in changing away from -lpthread? That is clearly > defined, link with libpthread, with no side effects. "If it ain't broke..." True - what we have works and using `-pthread` might subtly change things. ---

Re: RFR: 8353641: Deprecate core library permission classes for removal [v3]

2025-04-04 Thread Roger Riggs
> Now that the Security Manager is permanently disabled, the following > permission classes in the core libraries area can be deprecated for removal > as they are no longer useful: FilePermission, LinkPermission, > LoggingPermission, PropertyPermission, ReflectPermission, RuntimePermission, > a

Re: RFR: 8352171: Arrays.hashCode for sub-range of byte array API addition

2025-04-04 Thread Zihao Lin
On Thu, 20 Mar 2025 11:59:58 GMT, Zihao Lin wrote: > Add the java.util.Arrays.hashCode(byte[], int start, int end). > > Hi team, I am new here, please give me some guidance. Thank you. That’s helpful to know, Let's solve this issue after creating the CSR. - PR Comment: https://git

Re: RFR: 8351565: Implement JEP 502: Stable Values (Preview) [v25]

2025-04-04 Thread Per Minborg
On Wed, 2 Apr 2025 09:34:57 GMT, Maurizio Cimadamore wrote: >> Per Minborg has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Add lazy toSting for StableMap::values >> - Make toString for reversed and sublist lazy > > src/java.base/shar

Integrated: 8353196: [macos] Contents of ".jpackage.xml" file are wrong when building .pkg from unsigned app image

2025-04-04 Thread Alexey Semenyuk
On Sat, 29 Mar 2025 16:22:30 GMT, Alexey Semenyuk wrote: > - Don't create ".jpackage.xml" file in app image for DMG or PKG bundles; > - Remove ".jpackage.xml" file from unsigned predefined app image for DMG or > PKG bundles; > - Set the value of `signed` property in ".jpackage.xml" file to "tr

Re: RFR: 8315130: java.lang.IllegalAccessError when processing classlist to create CDS archive [v3]

2025-04-04 Thread Timofei Pushkin
On Fri, 4 Apr 2025 06:15:27 GMT, Ioi Lam wrote: >> Timofei Pushkin has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - Make getResource concurrent-friendly >> - Don't use URLClassLoader > > src/java.base/share/classes/jdk/internal/misc/CD

Re: RFR: 8066583: DeflaterInput/OutputStream and InflaterInput/OutputStream should explain responsibility for freeing resources [v6]

2025-04-04 Thread Chen Liang
On Mon, 31 Mar 2025 14:48:07 GMT, Alan Bateman wrote: >> Jaikiran Pai has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains 12 additional >> commits s

Re: RFR: 8352693: Use a simpler console reader instead of JLine for System.console()

2025-04-04 Thread Jan Lahoda
On Mon, 31 Mar 2025 17:22:45 GMT, David M. Lloyd wrote: >> The `java.io.Console` has several backends: a simple on in `java.base`, a >> more convenient one in `jdk.internal.le` (with line-reading based on JLine) >> and one for JShell. >> >> The backend based on JLine is proving to be a somewha

Re: RFR: 8351565: Implement JEP 502: Stable Values (Preview) [v31]

2025-04-04 Thread Per Minborg
> Implement JEP 502. > > The PR passes tier1-tier3 tests. Per Minborg has updated the pull request incrementally with one additional commit since the last revision: Address various comments - Changes: - all: https://git.openjdk.org/jdk/pull/23972/files - new: https://git.ope

Re: RFR: 8315130: java.lang.IllegalAccessError when processing classlist to create CDS archive [v3]

2025-04-04 Thread Timofei Pushkin
> If a base class is package-private then its subclasses should have the same > package name and defining class loader, otherwise `IllegalAccessError` is > thrown when linking a subclass. Currently when dumping a static archive > separate `URLClassLoader`s are used for each unregistered classes'

Re: RFR: 8315130: java.lang.IllegalAccessError when processing classlist to create CDS archive [v3]

2025-04-04 Thread Timofei Pushkin
On Fri, 4 Apr 2025 05:58:47 GMT, Ioi Lam wrote: >> Timofei Pushkin has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - Make getResource concurrent-friendly >> - Don't use URLClassLoader > > src/java.base/share/classes/jdk/internal/misc/CD

Re: RFR: 8351565: Implement JEP 502: Stable Values (Preview) [v40]

2025-04-04 Thread Archie Cobbs
On Thu, 3 Apr 2025 14:00:00 GMT, Per Minborg wrote: >> Implement JEP 502. >> >> The PR passes tier1-tier3 tests. > > Per Minborg has updated the pull request incrementally with one additional > commit since the last revision: > > Make the sqrt example different src/java.base/share/classes/j

Re: Reg: Proposal: Generalized Number.parseNumber(String) Method for Java

2025-04-04 Thread Volkan Yazıcı
Sathish, please see my response below. On Tue, Apr 1, 2025 at 7:58 AM Sathish Kumar Thiyagarajan < sathishkumar.thiyagara...@gmail.com> wrote: > However, *Jackson (and most JSON parsers) default to Integer for whole > numbers* because they rely on Integer.parseInt(String), which is a safe > fallb

Re: RFR: 8353679: Restructure classes in jdk.jpackage.internal package

2025-04-04 Thread Alexander Matveev
On Tue, 1 Apr 2025 15:18:13 GMT, Alexey Semenyuk wrote: > - Move ConfigException, PackagerException, MsiVersion, and DottedVersion > classes from "jdk.jpackage.internal" package to "jdk.jpackage.internal.model" > package. > - Remove public ctor from DottedVersion class. It can only be construc

Re: RFR: 8348967: Deprecate security permission classes for removal [v2]

2025-04-04 Thread Sean Mullan
> Please review this change to terminally deprecate the following security > related permission classes: `java.security.UnresolvedPermission`, > `javax.net.ssl.SSLPermission`, `javax.security.auth.AuthPermission`, > `javax.security.auth.PrivateCredentialPermission`, > `javax.security.auth.kerbe

Re: RFR: 8353585: Provide ChoiceFormat#parse(String, ParsePosition) tests [v2]

2025-04-04 Thread Naoto Sato
On Thu, 3 Apr 2025 21:23:08 GMT, Justin Lu wrote: >> Please review this PR which provides unit tests for >> `ChoiceFormat#parse(String, ParsePosition)` to check default, multi match, >> and no match behavior. There were no existing relevant tests. > > Justin Lu has updated the pull request incr

Re: RFR: 8353741: Improve UUID.toString performance by using SIMD within a register instead of table lookup

2025-04-04 Thread Johannes Graham
On Mon, 6 Jan 2025 13:18:50 GMT, Shaojin Wen wrote: > Improve the performance of UUID::toString by using Long.expand and SWAR (SIMD > within a register) instead of table lookup. Eliminating the table lookup can > also avoid the performance degradation problem when the cache misses. By stepping

Usage feedback: jnativescan

2025-04-04 Thread Danish Nawab
jnativescan terminates when ran on a JAR with a missing class. Example: ``` jnativescan --class-path reactor-core-3.7.4.jar ERROR: Error while processing method: reactor.core.publisher.CallSiteSupplierFactory$SharedSecretsCallSiteSupplierFactory$TracingException::get()String CAUSED BY: System cl

Re: Add "SHA-384" as a known attribute

2025-04-04 Thread Jaikiran Pai
The caching of some attribute names in the java.util.jar.Attributes class appears to have been introduced in https://bugs.openjdk.org/browse/JDK-6805750 (RFR https://mail.openjdk.org/pipermail/core-libs-dev/2018-April/052697.html). Given the precedence, it may be OK to add "SHA-384-Digest" to

Re: RFR: 8352693: Use a simpler console reader instead of JLine for System.console() [v3]

2025-04-04 Thread Magnus Ihse Bursie
On Thu, 3 Apr 2025 18:12:54 GMT, Jan Lahoda wrote: >> The `java.io.Console` has several backends: a simple on in `java.base`, a >> more convenient one in `jdk.internal.le` (with line-reading based on JLine) >> and one for JShell. >> >> The backend based on JLine is proving to be a somewhat pro

RFR: 8254622: Hide superclasses from conditionally exported packages

2025-04-04 Thread Hannes Wallnöfer
Please review an enhancement to treat classes and interfaces that are not included and not unconditionally exported as hidden. This means they do not show up in the generated documentation even if they are implemented or extended by a documented type. This change makes the `@hidden` JavaDoc ta

RE: JDK-8352891 Performance improvements to ByteArrayOutputStream

2025-04-04 Thread Engebretson, John
I’ve split the unsynchronized BAOS into its own issue, JDK-8353729, which shows performance improvements on primitive writes. MemoryOutputStream remains superior in that case and others. John From: Engebretson, John Sent: Thursday, April 3, 2025 7:45 AM To: 'Alan Bateman' ; Markus KARG

Re: Add "SHA-384" as a known attribute

2025-04-04 Thread Jaikiran Pai
Since this is about caching values in the java.util.jar.Attributes class, the discussion is more appropriate in the core-libs-dev mailing list. I've added it to the "To" now and "Bcc"ed the jdk-dev mailing list. Please subscribe to core-libs-dev https://mail.openjdk.org/mailman/listinfo/core-li

Re: RFR: 8353741: Improve UUID.toString performance by using SIMD within a register instead of table lookup [v2]

2025-04-04 Thread Shaojin Wen
> Improve the performance of UUID::toString by using Long.expand and SWAR (SIMD > within a register) instead of table lookup. Eliminating the table lookup can > also avoid the performance degradation problem when the cache misses. Shaojin Wen has updated the pull request incrementally with one a

RFR: 8353741: Improve UUID.toString performance by using SIMD within a register instead of table lookup

2025-04-04 Thread Shaojin Wen
Improve the performance of UUID::toString by using Long.expand and SWAR (SIMD within a register) instead of table lookup. Eliminating the table lookup can also avoid the performance degradation problem when the cache misses. - Commit messages: - use Long.expand - Merge remote-trac

Re: RFR: 8353741: Improve UUID.toString performance by using SIMD within a register instead of table lookup

2025-04-04 Thread Shaojin Wen
On Tue, 14 Jan 2025 19:14:05 GMT, Johannes Graham wrote: >> The new implementation improves performance on the aarch64 architecture but >> results in a performance regression on x64. >> >> ## 1. Script >> >> git remote add wenshao g...@github.com:wenshao/jdk.git >> git fetch wenshao >> >> # b

Re: RFR: 8353741: Improve UUID.toString performance by using SIMD within a register instead of table lookup

2025-04-04 Thread Johannes Graham
On Sat, 11 Jan 2025 05:21:36 GMT, Shaojin Wen wrote: >> Improve the performance of UUID::toString by using Long.expand and SWAR >> (SIMD within a register) instead of table lookup. Eliminating the table >> lookup can also avoid the performance degradation problem when the cache >> misses. > >

Re: RFR: 8353741: Improve UUID.toString performance by using SIMD within a register instead of table lookup

2025-04-04 Thread Chen Liang
On Mon, 6 Jan 2025 13:18:50 GMT, Shaojin Wen wrote: > Improve the performance of UUID::toString by using Long.expand and SWAR (SIMD > within a register) instead of table lookup. Eliminating the table lookup can > also avoid the performance degradation problem when the cache misses. Does this e

Re: RFR: 8353741: Improve UUID.toString performance by using SIMD within a register instead of table lookup

2025-04-04 Thread Shaojin Wen
On Mon, 6 Jan 2025 13:18:50 GMT, Shaojin Wen wrote: > Improve the performance of UUID::toString by using Long.expand and SWAR (SIMD > within a register) instead of table lookup. Eliminating the table lookup can > also avoid the performance degradation problem when the cache misses. Under the x

Re: RFR: 8345431: Detect duplicate entries in jar files with jar --validate

2025-04-04 Thread Lance Andersen
On Fri, 4 Apr 2025 16:12:56 GMT, Lance Andersen wrote: >> As we checking entry uniqueness and the size match, and all LOC entries >> should be in CEN, that would means all CEN entries in LOC. >> But if we would like to be specific about the inconsistency, then we will >> have to do a little mo

Re: RFR: 8353641: Deprecate core library permission classes for removal [v2]

2025-04-04 Thread Roger Riggs
> Now that the Security Manager is permanently disabled, the following > permission classes in the core libraries area can be deprecated for removal > as they are no longer useful: FilePermission, LinkPermission, > LoggingPermission, PropertyPermission, ReflectPermission, RuntimePermission, > a

Re: RFR: 8352935: Launcher should not add $JDK/../lib to LD_LIBRARY_PATH [v3]

2025-04-04 Thread Joachim Kern
> In the JDK launcher, there is a codepath which would set/modify the > LD_LIBRARY_PATH. This happens unconditionally on AIX and Linux/musl and can > also happen on other Linux platforms if an LD_LIBRARY_PATH is pre-set which > contains a libjvm.so. > > The LD_LIBRARY_PATH is set to $JVMPATH:$J

Integrated: 8353234: Refactor XMLSecurityPropertyManager

2025-04-04 Thread Joe Wang
On Mon, 31 Mar 2025 17:42:20 GMT, Joe Wang wrote: > Refactor XMLSecurityPropertyManager. > The Xerces and Xalan components each had its own XMLSecurityManager and > XMLSecurityPropertyManager. In a previous fix, the former had been unified as > part of that changeset. This change will allow fut

Re: RFR: 8351565: Implement JEP 502: Stable Values (Preview) [v33]

2025-04-04 Thread Quan Anh Mai
On Thu, 3 Apr 2025 12:54:01 GMT, Per Minborg wrote: >> src/java.base/share/classes/java/lang/StableValue.java line 402: >> >>> 400: * race. Since stable functions and stable collections are built on >>> top of >>> 401: * {@linkplain StableValue#orElseSet(Supplier) orElseSet()} they too >>> a

Re: RFR: 8066583: DeflaterInput/OutputStream and InflaterInput/OutputStream should explain responsibility for freeing resources [v8]

2025-04-04 Thread Jaikiran Pai
On Thu, 3 Apr 2025 12:07:16 GMT, Alan Bateman wrote: >> Jaikiran Pai has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains 16 additional >> commits si

Re: RFR: 8348967: Deprecate security permission classes for removal

2025-04-04 Thread David M . Lloyd
On Fri, 4 Apr 2025 12:42:36 GMT, Sean Mullan wrote: > Please review this change to terminally deprecate the following security > related permission classes: `java.security.AllPermission`, > `java.security.UnresolvedPermission`, `javax.net.ssl.SSLPermission`, > `javax.security.auth.AuthPermissi

Re: RFR: 8351565: Implement JEP 502: Stable Values (Preview) [v36]

2025-04-04 Thread Per Minborg
> Implement JEP 502. > > The PR passes tier1-tier3 tests. Per Minborg has updated the pull request incrementally with one additional commit since the last revision: Move Serializable specs to @implNote - Changes: - all: https://git.openjdk.org/jdk/pull/23972/files - new: htt

Re: RFR: 8348967: Deprecate security permission classes for removal

2025-04-04 Thread Sean Mullan
On Fri, 4 Apr 2025 14:49:36 GMT, David M. Lloyd wrote: > `AllPermission` is an integral concept of permission sets, and thus we would > be obliged to create our own if the JDK one disappeared, causing > compatibility problems due to the class moving to a new package from the > point of view of

Re: RFR: 8345431: Detect duplicate entries in jar files with jar --validate

2025-04-04 Thread Lance Andersen
On Fri, 4 Apr 2025 16:01:40 GMT, Henry Jen wrote: >> src/jdk.jartool/share/classes/sun/tools/jar/resources/jar.properties line >> 147: >> >>> 145: in incompatible public interfaces >>> 146: warn.validator.duplicate.entry=\ >>> 147: Warning: More than one copy of {0} is detected

Re: RFR: 8345431: Detect duplicate entries in jar files with jar --validate

2025-04-04 Thread Lance Andersen
On Fri, 4 Apr 2025 16:06:07 GMT, Henry Jen wrote: >> Is the ordering required by ZIP or Jar format? We can certainly do that if >> that's under spec and not an implementation detail. > > As we checking entry uniqueness and the size match, and all LOC entries > should be in CEN, that would mean

Re: RFR: 8345431: Detect duplicate entries in jar files with jar --validate

2025-04-04 Thread Henry Jen
On Fri, 4 Apr 2025 15:59:47 GMT, Henry Jen wrote: >> src/jdk.jartool/share/classes/sun/tools/jar/Validator.java line 99: >> >>> 97: if (!entryNames.contains(entryName)) { >>> 98: missingEntryNames.add(entryName); >>> 99: } >> >> It looks like

Re: RFR: 8348967: Deprecate security permission classes for removal

2025-04-04 Thread David Lloyd
Greetings Daniel, For the sake of discussion, I will look at these classes as classifiable into two groups: classes that we use (or are useful) only in the context of a security manager, and classes that we use (or are useful) independently of any other JDK API. I would put all three of these cla

  1   2   >