On Wed, 5 Feb 2025 10:17:09 GMT, Per Minborg wrote:
> This PR proposes to add some `@ForceInline` annotations in the `Module` class
> in order to assist inlining of FFM var/method handles.
>
> There are also some changes in other classes (notably `j.l.Object`) which, if
> implemented, can take
On Tue, 25 Mar 2025 11:08:24 GMT, Timofei Pushkin wrote:
> If a base class is package-private then its subclasses should have the same
> package name and defining class loader, otherwise `IllegalAccessError` is
> thrown when linking a subclass. Currently when dumping a static archive
> separat
Please review this test-only PR which introduces testing of the unspecified but
long-standing fallback to FTP for non-local files in the 'file' URL scheme.
This in preparation for the upcoming proposal to disable the feature by default
in JDK-8353440.
Since we cannot reliably bind an FTP serve
On Wed, 2 Apr 2025 18:33:16 GMT, Kim Barrett wrote:
>> Please review this change which adds a native method providing the
>> implementation of Reference::get. Referece::get is an intrinsic candidate,
>> so
>> this native method implementation is only used when the intrinsic is not.
>>
>> Curre
On Thu, 3 Apr 2025 21:36:10 GMT, Alexey Semenyuk wrote:
> Always print error messages from the last trapped exception to stderr.
> Optionally, print its stasktrace to stdout when in verbose mode.
>
> Add relevant test.
Looks good.
-
Marked as reviewed by almatvee (Reviewer).
PR
This PR check the jar file to ensure entries are consistent from the central
directory and local file header. Also check there is no duplicate entry names
that could override the desired content by accident.
-
Commit messages:
- 8345431: Detect duplicate entries in jar files with j
On Wed, 20 Sep 2023 04:52:31 GMT, Chen Liang wrote:
> Please review this patch that:
> 1. Implemented `forEach` to optimize for 1 or 2 element collections.
> 2. Implemented `spliterator` to optimize for a single element.
>
> The default implementations for multiple-element immutable collections
On Thu, 3 Apr 2025 21:36:10 GMT, Alexey Semenyuk wrote:
> Always print error messages from the last trapped exception to stderr.
> Optionally, print its stasktrace to stdout when in verbose mode.
>
> Add relevant test.
@sashamatveev PTAL
@sashamatveev PTAL
-
PR Comment: https://
Always print error messages from the last trapped exception to stderr.
Optionally, print its stasktrace to stdout when in verbose mode.
Add relevant test.
-
Commit messages:
- Print all errors when jpackage is executed with verbose output. Prior the
fix it suppressed printing last
On Fri, 11 Oct 2024 15:49:33 GMT, Chen Liang wrote:
>> Please review this patch that:
>> 1. Implemented `forEach` to optimize for 1 or 2 element collections.
>> 2. Implemented `spliterator` to optimize for a single element.
>>
>> The default implementations for multiple-element immutable collect
On Tue, 25 Feb 2025 23:50:01 GMT, Chen Liang wrote:
> Core reflection's generic signature parsing system is used for many aspects,
> including annotations and enclosing methods, yet it is under-tested. It is
> better for us to set up tests to ensure that sensitive error behaviors of
> core ref
On Mon, 24 Mar 2025 21:29:29 GMT, Chen Liang wrote:
>> Core reflection's generic signature parsing system is used for many aspects,
>> including annotations and enclosing methods, yet it is under-tested. It is
>> better for us to set up tests to ensure that sensitive error behaviors of
>> core
On Tue, 1 Apr 2025 21:20:54 GMT, Alexey Semenyuk wrote:
>> jpackage app laucnher will expand environment variables in .cfg files.
>>
>> Previously jpackage app launcher only replaced `$APPDIR`, `$BINDIR`, and
>> `$ROOTDIR` tokens with the corresponding path values. With this patch, any
>> envi
On Fri, 28 Mar 2025 15:02:05 GMT, Alexey Semenyuk wrote:
> Make tools/jpackage/share/ErrorTest.java test safely handle the case when
> native bundling is unavailable on the test host.
>
> Additionally:
> - If native bundling is unavailable on the test host, PackageTest will throw
> `jtreg.Ski
On Tue, 1 Apr 2025 21:20:54 GMT, Alexey Semenyuk wrote:
>> jpackage app laucnher will expand environment variables in .cfg files.
>>
>> Previously jpackage app launcher only replaced `$APPDIR`, `$BINDIR`, and
>> `$ROOTDIR` tokens with the corresponding path values. With this patch, any
>> envi
> Please review this PR which provides unit tests for
> `ChoiceFormat#parse(String, ParsePosition)` to check default, multi match,
> and no match behavior. There were no existing relevant tests.
Justin Lu has updated the pull request incrementally with one additional commit
since the last revis
On Thu, 3 Apr 2025 21:03:08 GMT, Stuart Marks wrote:
> Back out commit for
> [JDK-8349206](https://bugs.openjdk.org/browse/JDK-8349206) because of build
> failure.
>
> This reverts commit ebcb9a8b128cc6411610566c8368db63d25a5127.
LGTM Thanks Stuart!
-
Marked as reviewed by dholm
Back out commit for [JDK-8349206](https://bugs.openjdk.org/browse/JDK-8349206)
because of build failure.
This reverts commit ebcb9a8b128cc6411610566c8368db63d25a5127.
-
Commit messages:
- 8353684: BACKOUT 8349206: j.u.l.Handler classes create deadlock risk via
synchronized publish
- Move ConfigException, PackagerException, MsiVersion, and DottedVersion
classes from "jdk.jpackage.internal" package to "jdk.jpackage.internal.model"
package.
- Remove public ctor from DottedVersion class. It can only be constructed with
`DottedVersion.lazy()` and `DottedVersion.greedy()` func
On Tue, 1 Apr 2025 15:18:13 GMT, Alexey Semenyuk wrote:
> - Move ConfigException, PackagerException, MsiVersion, and DottedVersion
> classes from "jdk.jpackage.internal" package to "jdk.jpackage.internal.model"
> package.
> - Remove public ctor from DottedVersion class. It can only be construc
On Wed, 2 Apr 2025 21:59:32 GMT, David Beaumont wrote:
>> 8349206: j.u.l.Handler classes create deadlock risk via synchronized
>> publish() method.
>>
>> 1. Remove synchronization of calls to publish() in Handlers in
>> java.util.logging package.
>> 2. Add explanatory comments to various affec
In this PR I added TLS groups and signature algorithms to the output of the
show settings flag. The values are printed in a single column, like the cipher
suites. There can be a lot of values so putting on a single line is ugly. I
tried putting them in columns, but it is hard to read.
-
On Thu, 3 Apr 2025 17:59:52 GMT, Jan Lahoda wrote:
>> The `java.io.Console` has several backends: a simple on in `java.base`, a
>> more convenient one in `jdk.internal.le` (with line-reading based on JLine)
>> and one for JShell.
>>
>> The backend based on JLine is proving to be a somewhat pro
> The `java.io.Console` has several backends: a simple on in `java.base`, a
> more convenient one in `jdk.internal.le` (with line-reading based on JLine)
> and one for JShell.
>
> The backend based on JLine is proving to be a somewhat problematic - JLine is
> very powerful, possibly too powerfu
On Thu, 6 Mar 2025 13:34:07 GMT, Oleksii Sylichenko wrote:
> This PR proposes three improvements to the `Basic.java` test:
>
> 1. Increase Timeout
>- The current timeout is insufficient when running the test in IntelliJ
> IDEA.
>- I propose increasing it by one minute.
>- The timeou
> Implement JEP 502.
>
> The PR passes tier1-tier3 tests.
Per Minborg has updated the pull request incrementally with one additional
commit since the last revision:
Clean up StableValue docs
-
Changes:
- all: https://git.openjdk.org/jdk/pull/23972/files
- new: https://git.op
On Wed, 2 Apr 2025 18:46:06 GMT, Viktor Klang wrote:
>> Per Minborg has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Add info that Map#values and Map#entrySet are stable
>
> test/jdk/java/lang/StableValue/StableValueFactoriesTest.java lin
On Thu, 3 Apr 2025 14:00:00 GMT, Per Minborg wrote:
>> Implement JEP 502.
>>
>> The PR passes tier1-tier3 tests.
>
> Per Minborg has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Make the sqrt example different
src/java.base/share/classes/j
On Thu, 3 Apr 2025 12:17:03 GMT, Maurizio Cimadamore
wrote:
>> Per Minborg has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Move Serializable specs to @implNote
>
> src/java.base/share/classes/java/lang/StableValue.java line 653:
>
>> 6
On Wed, 2 Apr 2025 18:49:31 GMT, Viktor Klang wrote:
>> Per Minborg has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Add info that Map#values and Map#entrySet are stable
>
> test/jdk/java/lang/StableValue/StableValueTest.java line 262:
>
> Implement JEP 502.
>
> The PR passes tier1-tier3 tests.
Per Minborg has updated the pull request incrementally with one additional
commit since the last revision:
Make the sqrt example different
-
Changes:
- all: https://git.openjdk.org/jdk/pull/23972/files
- new: https://
On Tue, 1 Apr 2025 05:38:17 GMT, Jaikiran Pai wrote:
>> @jaikiran not yet. How can I create an issue for this PR? I don't find some
>> instructions :/
>
> Hello @tisonkun,
>
>> How can I create an issue for this PR? I don't find some instructions :/
>
> In general, the OpenJDK contribution gui
On Thu, 3 Apr 2025 13:09:10 GMT, Joachim Kern wrote:
>> In the JDK launcher, there is a codepath which would set/modify the
>> LD_LIBRARY_PATH. This happens unconditionally on AIX and Linux/musl and can
>> also happen on other Linux platforms if an LD_LIBRARY_PATH is pre-set which
>> contains
On Tue, 1 Apr 2025 09:13:45 GMT, Joachim Kern wrote:
> In the JDK launcher, there is a codepath which would set/modify the
> LD_LIBRARY_PATH. This happens unconditionally on AIX and Linux/musl and can
> also happen on other Linux platforms if an LD_LIBRARY_PATH is pre-set which
> contains a li
> Implement JEP 502.
>
> The PR passes tier1-tier3 tests.
Per Minborg has updated the pull request incrementally with one additional
commit since the last revision:
Specify that an exception is thrown for illegal inputs
-
Changes:
- all: https://git.openjdk.org/jdk/pull/23972/
On Wed, 2 Apr 2025 19:22:28 GMT, Quan Anh Mai wrote:
>> Per Minborg has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Add info that Map#values and Map#entrySet are stable
>
> src/java.base/share/classes/java/lang/StableValue.java line 402:
> Can I please get a review of this doc-only change which proposes to improve
> the API documentation of `DeflaterInputStream`, `DeflaterOutputStream`,
> `InflaterInputStream` and `InflaterOutputStream` classes?
>
> As noted in https://bugs.openjdk.org/browse/JDK-8066583 some of the
> construct
On Wed, 12 Mar 2025 14:14:13 GMT, Per Minborg wrote:
>> It's true that the storage can be flatter here -- that said, this can also
>> be done as a later refactoring. One advantage of doing things the way
>> @minborg did it here, is that it's fairly easy to prove that the code below
>> is corre
> Implement JEP 502.
>
> The PR passes tier1-tier3 tests.
Per Minborg has updated the pull request incrementally with one additional
commit since the last revision:
Break out and move performance related text
-
Changes:
- all: https://git.openjdk.org/jdk/pull/23972/files
- n
On Thu, 3 Apr 2025 11:34:03 GMT, Per Minborg wrote:
>> Implement JEP 502.
>>
>> The PR passes tier1-tier3 tests.
>
> Per Minborg has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Move Serializable specs to @implNote
src/java.base/share/clas
On Thu, 3 Apr 2025 11:40:23 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this doc-only change which proposes to improve
>> the API documentation of `DeflaterInputStream`, `DeflaterOutputStream`,
>> `InflaterInputStream` and `InflaterOutputStream` classes?
>>
>> As noted in https://
On Tue, 1 Apr 2025 07:22:45 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this doc-only change which proposes to improve
>> the API documentation of `DeflaterInputStream`, `DeflaterOutputStream`,
>> `InflaterInputStream` and `InflaterOutputStream` classes?
>>
>> As noted in https://
> Can I please get a review of this doc-only change which proposes to improve
> the API documentation of `DeflaterInputStream`, `DeflaterOutputStream`,
> `InflaterInputStream` and `InflaterOutputStream` classes?
>
> As noted in https://bugs.openjdk.org/browse/JDK-8066583 some of the
> construct
On Wed, 2 Apr 2025 18:39:57 GMT, Severin Gehwolf wrote:
> For JEP 493-enabled builds there are no JMODs. Certain files come from the
> installed JDK image when a user creates a custom run-time from it. This is
> problematic for example for files that often come from a different package
> (e.g.
On Wed, 2 Apr 2025 14:58:35 GMT, Maurizio Cimadamore
wrote:
>> There are two fundamental variants. One with `CACHED_SIZE` (for list and int
>> function) and one with `CACHED_KEYS` (for map and function).
>
> Yes - but they cache different things -- the first caches results for values
> 0-9 --
Hi Remi and thank you for the feedback from JChateau (what a wonderful name!).
This is one of the issues we already have on the list for the next round of
preview. Now we know more folks are on the same page.
Best, Per
From: Remi Forax
Sent: Wednesday, April 2,
> Implement JEP 502.
>
> The PR passes tier1-tier3 tests.
Per Minborg has updated the pull request incrementally with one additional
commit since the last revision:
Address comments
-
Changes:
- all: https://git.openjdk.org/jdk/pull/23972/files
- new: https://git.openjdk.org
On Wed, 2 Apr 2025 14:30:05 GMT, Viktor Klang wrote:
>> Per Minborg has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Add info that Map#values and Map#entrySet are stable
>
> src/java.base/share/classes/java/lang/StableValue.java line 426:
On Wed, 2 Apr 2025 18:42:06 GMT, Viktor Klang wrote:
>> Per Minborg has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Add info that Map#values and Map#entrySet are stable
>
> test/jdk/java/lang/StableValue/StableMapTest.java line 143:
>
>
On Thu, 3 Apr 2025 09:46:38 GMT, Alan Bateman wrote:
> Part of me is concerned that the hidden option is a bit of an attractive
> nuisance. What would you think about just having a fixed list in a properties
> file in the repo, thus a resource in the jlink module. This would avoid the
> list i
On Wed, 2 Apr 2025 18:33:39 GMT, Viktor Klang wrote:
>> Per Minborg has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Add info that Map#values and Map#entrySet are stable
>
> test/jdk/java/lang/StableValue/StableFunctionTest.java line 147:
On Wed, 2 Apr 2025 18:39:57 GMT, Severin Gehwolf wrote:
> For JEP 493-enabled builds there are no JMODs. Certain files come from the
> installed JDK image when a user creates a custom run-time from it. This is
> problematic for example for files that often come from a different package
> (e.g.
On Wed, 2 Apr 2025 18:33:22 GMT, Viktor Klang wrote:
>> Per Minborg has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Add info that Map#values and Map#entrySet are stable
>
> test/jdk/java/lang/StableValue/StableFunctionTest.java line 136:
On Wed, 23 Oct 2024 06:06:43 GMT, tison wrote:
> Try to add clear type annotations.
>
> Please let me know how this patch can be properly reviewed >_<
This pull request has been closed without being integrated.
-
PR: https://git.openjdk.org/jdk/pull/21658
On Wed, 2 Apr 2025 18:29:06 GMT, Viktor Klang wrote:
>> Per Minborg has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Add info that Map#values and Map#entrySet are stable
>
> test/jdk/java/lang/StableValue/StableFunctionTest.java line 86:
On Wed, 2 Apr 2025 16:31:03 GMT, Viktor Klang wrote:
>> Per Minborg has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Add info that Map#values and Map#entrySet are stable
>
> src/java.base/share/classes/jdk/internal/lang/stable/StableValue
On Wed, 2 Apr 2025 15:24:47 GMT, Viktor Klang wrote:
>> Per Minborg has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Add info that Map#values and Map#entrySet are stable
>
> src/java.base/share/classes/jdk/internal/lang/stable/StableEnumF
On Wed, 23 Oct 2024 06:06:43 GMT, tison wrote:
> Try to add clear type annotations.
>
> Please let me know how this patch can be properly reviewed >_<
> _Mailing list message from [David Holmes](mailto:david.hol...@oracle.com) on
> [core-libs-dev](mailto:core-libs-...@mail.openjdk.org):_
>
>
On Tue, 1 Apr 2025 09:13:45 GMT, Joachim Kern wrote:
> In the JDK launcher, there is a codepath which would set/modify the
> LD_LIBRARY_PATH. This happens unconditionally on AIX and Linux/musl and can
> also happen on other Linux platforms if an LD_LIBRARY_PATH is pre-set which
> contains a li
On Wed, 2 Apr 2025 14:24:20 GMT, Viktor Klang wrote:
>> Per Minborg has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Add info that Map#values and Map#entrySet are stable
>
> src/java.base/share/classes/java/lang/StableValue.java line 377:
On Wed, 2 Apr 2025 21:59:32 GMT, David Beaumont wrote:
>> 8349206: j.u.l.Handler classes create deadlock risk via synchronized
>> publish() method.
>>
>> 1. Remove synchronization of calls to publish() in Handlers in
>> java.util.logging package.
>> 2. Add explanatory comments to various affec
On Wed, 2 Apr 2025 14:25:45 GMT, Viktor Klang wrote:
>> Per Minborg has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Add info that Map#values and Map#entrySet are stable
>
> src/java.base/share/classes/java/lang/StableValue.java line 384:
On Wed, 2 Apr 2025 14:24:04 GMT, Viktor Klang wrote:
>> Per Minborg has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Add info that Map#values and Map#entrySet are stable
>
> src/java.base/share/classes/java/lang/StableValue.java line 374:
On Wed, 2 Apr 2025 21:37:25 GMT, Maurizio Cimadamore
wrote:
>> Or "observably immutable"? 🤔
>
> or... "immutable"
There is a problem here: If we say it is "immutable content" people might think
that passing mutable data makes it immutable. If we say it is "shallowly
immutable content" people
> Implement JEP 502.
>
> The PR passes tier1-tier3 tests.
Per Minborg has updated the pull request incrementally with one additional
commit since the last revision:
Address doc comments
-
Changes:
- all: https://git.openjdk.org/jdk/pull/23972/files
- new: https://git.openjdk
On 02/04/2025 19:04, Engebretson, John wrote:
Apologies, human error – here’s the message I intended:
Thank you! I’ve updated the PR accordingly and summarized the
benchmarks in the description. Here’s the short version:
* For small payloads, unsynchronized and optimized versions are
On Wed, 2 Apr 2025 09:26:52 GMT, Maurizio Cimadamore
wrote:
>> src/java.base/share/classes/java/lang/StableValue.java line 461:
>>
>>> 459: * An unset stable value has no content.
>>> 460: *
>>> 461: * The returned stable value is not {@link Serializable}.
>>
>> I find the clai
On Tue, 1 Apr 2025 09:13:45 GMT, Joachim Kern wrote:
> In the JDK launcher, there is a codepath which would set/modify the
> LD_LIBRARY_PATH. This happens unconditionally on AIX and Linux/musl and can
> also happen on other Linux platforms if an LD_LIBRARY_PATH is pre-set which
> contains a li
On Tue, 1 Apr 2025 17:33:43 GMT, Alan Bateman wrote:
> `jmod create` maps the contents of the module to a set of packages. This
> mapping derives illegal package names when class resources are located in
> non-package locations, e.g. in the META-INF tree. `jlink` also has an issue
> in this ar
69 matches
Mail list logo
