On Thu, 23 Jan 2025 15:23:37 GMT, Kevin Walls wrote:
> java.util.logging.LoggingMXBean and
> java.util.logging.LogManager::getLoggingMXBean are deprecated since
> JDK-8139982 in JDK 9.
>
> These deprecations should be uprated to state they are for future removal.
>
> java.util.logging.Logging
On Tue, 1 Apr 2025 13:27:34 GMT, Per Minborg wrote:
>> Implement JEP 502.
>>
>> The PR passes tier1-tier3 tests.
>
> Per Minborg has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - Add lazy toSting for StableMap::values
> - Make toString fo
On Wed, 2 Apr 2025 14:31:46 GMT, Viktor Klang wrote:
>> src/java.base/share/classes/java/lang/StableValue.java line 455:
>>
>>> 453: * provided to the {@link #orElseSet(Supplier)} method.
>>> 454: */
>>> 455: boolean trySet(T content);
>>
>> I assume the intent is that try
On Wed, 2 Apr 2025 13:54:03 GMT, Daniel Fuchs wrote:
>> David Beaumont has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Reworking user warnings about synchronization and deadlocking based on
>> Joe's comments.
>
> src/java.logging/share/
Apologies, human error – here’s the message I intended:
Thank you! I’ve updated the PR accordingly and summarized the benchmarks in
the description. Here’s the short version:
* For small payloads, unsynchronized and optimized versions are 2-4x faster
than base
* For large payloads
On Wed, 2 Apr 2025 14:07:45 GMT, Viktor Klang wrote:
>> src/java.base/share/classes/java/lang/StableValue.java line 50:
>>
>>> 48:
>>> 49: /**
>>> 50: * A stable value is a holder of shallowly immutable content that can
>>> be lazily computed.
>>
>> This reads as if the content can only be s
On Sun, 30 Mar 2025 15:07:36 GMT, SendaoYan wrote:
> Hi all,
> File src/java.base/share/native/libjli/java.c compile error: control reaches
> end of non-void function [-Werror=return-type] with gcc options
> -fsanitize=address -O0. The function int JavaMain(void* _args) in this file
> will exe
In the static JDK image, a single humongous java executable is generated, and
no other launcher, such as javac. This makes it impossible to run our jtreg
tests, which assume these are present.
The solution is fortunately simply: we just need to add a bunch of trivial
launchers, which are thin w
On Thu, 2 Jan 2025 17:13:17 GMT, David M. Lloyd wrote:
> When loading services by class loader
> (`ServiceLoader.load(Class,ClassLoader)`), the module layers bound to the
> given class loader are searched for services, along with the layers bound to
> class loader's parent, and so on. For non-
On Wed, 2 Apr 2025 10:05:04 GMT, Alan Bateman wrote:
>> Justin Lu has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Address further comments
>
> src/java.base/share/classes/java/text/ChoiceFormat.java line 562:
>
>> 560: /**
>> 561:
On Wed, 2 Apr 2025 13:22:44 GMT, Per Minborg wrote:
>> Implement JEP 502.
>>
>> The PR passes tier1-tier3 tests.
>
> Per Minborg has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Add info that Map#values and Map#entrySet are stable
src/java
> Please review this PR which specifies the `ChoiceFormat#parse(String,
> ParsePosition)` method. A corresponding CSR is filed. The current
> specification is simply "Parses a Number from the input text" which does not
> indicate how the value is returned. The criteria for a match, as well as no
On Wed, 2 Apr 2025 13:44:47 GMT, Alan Bateman wrote:
>> Per Minborg has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Add info that Map#values and Map#entrySet are stable
>
> src/java.base/share/classes/java/lang/StableValue.java line 455:
On Wed, 2 Apr 2025 19:46:12 GMT, Justin Lu wrote:
>> Please review this PR which specifies the `ChoiceFormat#parse(String,
>> ParsePosition)` method. A corresponding CSR is filed. The current
>> specification is simply "Parses a Number from the input text" which does not
>> indicate how the va
On Mon, 31 Mar 2025 17:42:20 GMT, Joe Wang wrote:
> Refactor XMLSecurityPropertyManager.
> The Xerces and Xalan components each had its own XMLSecurityManager and
> XMLSecurityPropertyManager. In a previous fix, the former had been unified as
> part of that changeset. This change will allow fut
On Wed, 2 Apr 2025 13:22:44 GMT, Per Minborg wrote:
>> Implement JEP 502.
>>
>> The PR passes tier1-tier3 tests.
>
> Per Minborg has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Add info that Map#values and Map#entrySet are stable
Thanks f
For JEP 493-enabled builds there are no JMODs. Certain files come from the
installed JDK image when a user creates a custom run-time from it. This is
problematic for example for files that often come from a different package
(e.g. `cacerts` file for Linux distro builds of OpenJDK packaged as RPM
On Wed, 2 Apr 2025 18:33:16 GMT, Kim Barrett wrote:
>> Please review this change which adds a native method providing the
>> implementation of Reference::get. Referece::get is an intrinsic candidate,
>> so
>> this native method implementation is only used when the intrinsic is not.
>>
>> Curre
> Please review this change which adds a native method providing the
> implementation of Reference::get. Referece::get is an intrinsic candidate, so
> this native method implementation is only used when the intrinsic is not.
>
> Currently there is intrinsic support by the interpreter, C1, C2, and
On Mon, 31 Mar 2025 17:42:20 GMT, Joe Wang wrote:
> Refactor XMLSecurityPropertyManager.
> The Xerces and Xalan components each had its own XMLSecurityManager and
> XMLSecurityPropertyManager. In a previous fix, the former had been unified as
> part of that changeset. This change will allow fut
Thank you! I’ve updated the PR accordingly and summarized the benchmarks in
the description. Here’s the short version:
From: Alan Bateman
Sent: Wednesday, April 2, 2025 5:52 AM
To: Engebretson, John ; Markus KARG
; core-libs-dev@openjdk.org
Subject: RE: [EXTERNAL] JDK-8352891 Performance i
On Wed, 2 Apr 2025 16:59:16 GMT, Jan Lahoda wrote:
>> This is a patch to finalize the module imports feature. Please see:
>> https://bugs.openjdk.org/browse/JDK-8344700
>
> Jan Lahoda has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Reflecti
On Tue, 25 Mar 2025 20:36:28 GMT, Chris Plummer wrote:
> Calling ThreadGroupReference.groups() from an event handler can cause a
> deadlock. Details in first comment. Tested with :jdk_lang on all supported
> platforms and tier1, tier2, tier3, and tier5 svc testing.
This pull request has now be
On Wed, 2 Apr 2025 15:23:54 GMT, Vicente Romero wrote:
>> Jan Lahoda has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fixing test.
>
> src/jdk.jshell/share/classes/jdk/internal/jshell/tool/Startup.java line 340:
>
>> 338: */
>> 339:
In the JDK launcher, there is a codepath which would set/modify the
LD_LIBRARY_PATH. This happens unconditionally on AIX and Linux/musl and can
also happen on other Linux platforms if an LD_LIBRARY_PATH is pre-set which
contains a libjvm.so.
The LD_LIBRARY_PATH is set to $JVMPATH:$JDK/lib:$JDK/
On Mon, 31 Mar 2025 17:40:25 GMT, Jan Lahoda wrote:
>> This is a patch to finalize the module imports feature. Please see:
>> https://bugs.openjdk.org/browse/JDK-8344700
>
> Jan Lahoda has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Fixing
On Wed, 2 Apr 2025 12:00:31 GMT, Per Minborg wrote:
>> The same discrepancy is present in the list vs. map examples
>
> There are two fundamental variants. One with `CACHED_SIZE` (for list and int
> function) and one with `CACHED_KEYS` (for map and function).
Yes - but they cache different thin
On Tue, 1 Apr 2025 20:32:45 GMT, Justin Lu wrote:
>> Please review this PR which specifies the `ChoiceFormat#parse(String,
>> ParsePosition)` method. A corresponding CSR is filed. The current
>> specification is simply "Parses a Number from the input text" which does not
>> indicate how the va
On Wed, 2 Apr 2025 13:22:44 GMT, Per Minborg wrote:
>> Implement JEP 502.
>>
>> The PR passes tier1-tier3 tests.
>
> Per Minborg has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Add info that Map#values and Map#entrySet are stable
src/java
Hi Per,
last week, at JChateau, we had a one hour session about stable values, I've
build the JDK with this PR so we can discuss about it.
To present the API, i start from the double check locking, rewriting it to use
the StableValue API.
The main remark was that methods like orElseSet() or isS
On Wed, 2 Apr 2025 13:22:44 GMT, Per Minborg wrote:
>> Implement JEP 502.
>>
>> The PR passes tier1-tier3 tests.
>
> Per Minborg has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Add info that Map#values and Map#entrySet are stable
src/java
On Wed, 2 Apr 2025 11:41:30 GMT, Maurizio Cimadamore
wrote:
>> Per Minborg has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Improve examples
>
> src/java.base/share/classes/java/lang/StableValue.java line 209:
>
>> 207: * private S
On Wed, 2 Apr 2025 14:06:22 GMT, Viktor Klang wrote:
>> Per Minborg has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Add info that Map#values and Map#entrySet are stable
>
> src/java.base/share/classes/java/lang/StableValue.java line 50:
On Wed, 2 Apr 2025 13:22:44 GMT, Per Minborg wrote:
>> Implement JEP 502.
>>
>> The PR passes tier1-tier3 tests.
>
> Per Minborg has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Add info that Map#values and Map#entrySet are stable
src/java
On Wed, 2 Apr 2025 13:22:44 GMT, Per Minborg wrote:
>> Implement JEP 502.
>>
>> The PR passes tier1-tier3 tests.
>
> Per Minborg has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Add info that Map#values and Map#entrySet are stable
src/java
On Wed, 2 Apr 2025 13:39:22 GMT, David Beaumont wrote:
>> 8349206: j.u.l.Handler classes create deadlock risk via synchronized
>> publish() method.
>>
>> 1. Remove synchronization of calls to publish() in Handlers in
>> java.util.logging package.
>> 2. Add explanatory comments to various affec
On Wed, 2 Apr 2025 12:56:23 GMT, Per Minborg wrote:
>> Same in other factories...
>
> We had that originally and then I got the comment to move them to the
> factories so I am happy to do either as soon as we agree on the best way to
> do it.
I'm also puzzled as to why this is here as it becom
On Wed, 2 Apr 2025 13:22:44 GMT, Per Minborg wrote:
>> Implement JEP 502.
>>
>> The PR passes tier1-tier3 tests.
>
> Per Minborg has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Add info that Map#values and Map#entrySet are stable
src/java
> 8349206: j.u.l.Handler classes create deadlock risk via synchronized
> publish() method.
>
> 1. Remove synchronization of calls to publish() in Handlers in
> java.util.logging package.
> 2. Add explanatory comments to various affected methods.
> 3. Add a test to ensure deadlocks no longer occu
> Implement JEP 502.
>
> The PR passes tier1-tier3 tests.
Per Minborg has updated the pull request incrementally with one additional
commit since the last revision:
Mention the impact of toString and equals
-
Changes:
- all: https://git.openjdk.org/jdk/pull/23972/files
- new
On Wed, 2 Apr 2025 09:36:51 GMT, Alan Bateman wrote:
>> I'm breaking this change out as a separate improvement, since it will not be
>> generally possible to adjust these limits on the j.u.c primitives since they
>> might already use a backing `long` to pack in information which needs to be
>>
On Wed, 2 Apr 2025 09:13:32 GMT, Maurizio Cimadamore
wrote:
>> Per Minborg has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Add lazy toSting for StableMap::values
>> - Make toString for reversed and sublist lazy
>
> src/java.base/shar
On Wed, 2 Apr 2025 09:21:17 GMT, Maurizio Cimadamore
wrote:
>> Per Minborg has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Add lazy toSting for StableMap::values
>> - Make toString for reversed and sublist lazy
>
> src/java.base/shar
> Implement JEP 502.
>
> The PR passes tier1-tier3 tests.
Per Minborg has updated the pull request incrementally with one additional
commit since the last revision:
Rename variable and clarify get operations
-
Changes:
- all: https://git.openjdk.org/jdk/pull/23972/files
- ne
> Implement JEP 502.
>
> The PR passes tier1-tier3 tests.
Per Minborg has updated the pull request incrementally with one additional
commit since the last revision:
Specify what is a successful read/write operation
-
Changes:
- all: https://git.openjdk.org/jdk/pull/23972/files
> Implement JEP 502.
>
> The PR passes tier1-tier3 tests.
Per Minborg has updated the pull request incrementally with one additional
commit since the last revision:
Improve examples
-
Changes:
- all: https://git.openjdk.org/jdk/pull/23972/files
- new: https://git.openjdk.org
On Wed, 2 Apr 2025 11:42:03 GMT, Maurizio Cimadamore
wrote:
>> src/java.base/share/classes/java/lang/StableValue.java line 209:
>>
>>> 207: * private SqrtUtil(){}
>>> 208: *
>>> 209: * private static final Set CACHED_KEYS = Set.of(1, 2, 4,
>>> 8, 16, 32);
>>
>> This is not the same
On Wed, 2 Apr 2025 09:00:38 GMT, Maurizio Cimadamore
wrote:
>> Per Minborg has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Add lazy toSting for StableMap::values
>> - Make toString for reversed and sublist lazy
>
> src/java.base/shar
On Wed, 2 Apr 2025 11:37:56 GMT, Maurizio Cimadamore
wrote:
>> I've used `static` fields now to get out of the muddy waters of trusted
>> final fields, records etc.
>
> I didn't mean to say "this is not true, so use a `static final` instead".
> What I meant was more "let's not dive into VM-spe
On Wed, 2 Apr 2025 11:39:20 GMT, Per Minborg wrote:
>> Implement JEP 502.
>>
>> The PR passes tier1-tier3 tests.
>
> Per Minborg has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Improve examples
src/java.base/share/classes/java/lang/Stable
On Wed, 2 Apr 2025 11:34:24 GMT, Per Minborg wrote:
>> Now that we have removed the VM-specific handling of fields declared as
>> `StableValue`, this is true. I will take a look at improving the wording.
>
> I've used `static` fields now to get out of the muddy waters of trusted final
> fields,
On Wed, 2 Apr 2025 09:17:23 GMT, Per Minborg wrote:
>> src/java.base/share/classes/java/lang/StableValue.java line 95:
>>
>>> 93: *
>>> 94: * Note that the holder value can only be set at most once.
>>> 95: * In the example above, the {@code logger} field is declared {@code
>>> final} which
On Tue, 1 Apr 2025 13:22:47 GMT, Magnus Ihse Bursie wrote:
> The proper way to disable warnings is to use the DISABLED_WARNINGS arguments.
> In this particular case, there was already a pragma but due to incorrect
> restrictions it did not apply to clang.
This pull request has now been integra
On Wed, 2 Apr 2025 08:00:25 GMT, Julian Waters wrote:
> How does the __GNUC__ check affect clang?? Isn't that just for gcc?
No, clang disguises as gcc in several ways, and this is one of them. In effect,
you can consider `__GNUC__` to be not a check for a particular compiler, but
for complianc
On Wed, 2 Apr 2025 08:29:54 GMT, Maurizio Cimadamore
wrote:
>> Per Minborg has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Add lazy toSting for StableMap::values
>> - Make toString for reversed and sublist lazy
>
> src/java.base/shar
On Tue, 1 Apr 2025 13:27:34 GMT, Per Minborg wrote:
>> Implement JEP 502.
>>
>> The PR passes tier1-tier3 tests.
>
> Per Minborg has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - Add lazy toSting for StableMap::values
> - Make toString fo
On Tue, 1 Apr 2025 13:27:34 GMT, Per Minborg wrote:
>> Implement JEP 502.
>>
>> The PR passes tier1-tier3 tests.
>
> Per Minborg has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - Add lazy toSting for StableMap::values
> - Make toString fo
On Mon, 17 Mar 2025 02:56:11 GMT, Chen Liang wrote:
>> Per Minborg has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 246 commits:
>>
>> - Merge branch 'master' into implement-jep502
>> - Clean up exception messages and fix comment
On Tue, 1 Apr 2025 13:27:34 GMT, Per Minborg wrote:
>> Implement JEP 502.
>>
>> The PR passes tier1-tier3 tests.
>
> Per Minborg has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - Add lazy toSting for StableMap::values
> - Make toString fo
On Wed, 2 Apr 2025 02:00:39 GMT, David Holmes wrote:
> > there was already a pragma but due to incorrect restrictions it did not
> > apply to clang.
>
> How does the `__GNUC__` check affect clang?? Isn't that just for gcc?
clang has a tendency to like to pretend to be other compilers, it defin
On Tue, 1 Apr 2025 12:07:09 GMT, SendaoYan wrote:
>> Hi all,
>> File src/java.base/share/native/libjli/java.c compile error: control reaches
>> end of non-void function [-Werror=return-type] with gcc options
>> -fsanitize=address -O0. The function int JavaMain(void* _args) in this file
>> will
61 matches
Mail list logo
