On Mon, 31 Mar 2025 02:43:45 GMT, tison wrote:
>> Hello @tisonkun, is there an issue created for this?
>> https://bugs.openjdk.org/browse/JDK-8304674 against which this PR is linked
>> is for something else. The PR description too isn't clear what this change
>> is about.
>
> @jaikiran not yet
On Fri, 28 Mar 2025 15:02:05 GMT, Alexey Semenyuk wrote:
> Make tools/jpackage/share/ErrorTest.java test safely handle the case when
> native bundling is unavailable on the test host.
>
> Additionally:
> - If native bundling is unavailable on the test host, PackageTest will throw
> `jtreg.Ski
On Mon, 31 Mar 2025 17:42:20 GMT, Joe Wang wrote:
> Refactor XMLSecurityPropertyManager.
> The Xerces and Xalan components each had its own XMLSecurityManager and
> XMLSecurityPropertyManager. In a previous fix, the former had been unified as
> part of that changeset. This change will allow fut
On Mon, 31 Mar 2025 21:26:54 GMT, Alexey Semenyuk wrote:
> Move `ErrorTest.testAppContentWarning()` test case to
> `MacSignTest.testAppContentWarning()` and rework it to fail because of faulty
> app content and not invalid signing identity.
>
> MacSignTest is supposed to be a placeholder for t
Refactor XMLSecurityPropertyManager.
The Xerces and Xalan components each had its own XMLSecurityManager and
XMLSecurityPropertyManager. In a previous fix, the former had been unified as
part of that changeset. This change will allow future changes to handle
XMLSecurityManager and XMLSecurityPro
On Tue, 1 Apr 2025 00:59:57 GMT, Jason Zaugg wrote:
>> 8352642: Set zipinfo-time=false when constructing zipfs FileSystem in
>> com.sun.tools.javac.file.JavacFileManager$ArchiveContainer for better
>> performance
>
> Jason Zaugg has updated the pull request incrementally with one additional
>
On Mon, 31 Mar 2025 19:41:29 GMT, Brent Christian wrote:
>> test/jdk/java/lang/ref/FinalizerHistogramTest.java line 131:
>>
>>> 129: volatile boolean ref1Cleared = false;
>>> 130: volatile boolean ref2Cleared = false;
>>> 131: Thread thread;
>>
>> Nit: This need not be a
> 8352642: Set zipinfo-time=false when constructing zipfs FileSystem in
> com.sun.tools.javac.file.JavacFileManager$ArchiveContainer for better
> performance
Jason Zaugg has updated the pull request incrementally with one additional
commit since the last revision:
8352642: Also pass zipinfo-
On Mon, 31 Mar 2025 21:26:54 GMT, Alexey Semenyuk wrote:
> Move `ErrorTest.testAppContentWarning()` test case to
> `MacSignTest.testAppContentWarning()` and rework it to fail because of faulty
> app content and not invalid signing identity.
>
> MacSignTest is supposed to be a placeholder for t
On Mon, 31 Mar 2025 21:26:54 GMT, Alexey Semenyuk wrote:
> Move `ErrorTest.testAppContentWarning()` test case to
> `MacSignTest.testAppContentWarning()` and rework it to fail because of faulty
> app content and not invalid signing identity.
>
> MacSignTest is supposed to be a placeholder for t
On Mon, 31 Mar 2025 14:43:37 GMT, Alexey Semenyuk wrote:
>> - Don't create ".jpackage.xml" file in app image for DMG or PKG bundles;
>> - Remove ".jpackage.xml" file from unsigned predefined app image for DMG or
>> PKG bundles;
>> - Set the value of `signed` property in ".jpackage.xml" file to
On Mon, 31 Mar 2025 14:43:37 GMT, Alexey Semenyuk wrote:
>> - Don't create ".jpackage.xml" file in image for DNG or PKG bundles;
>> - Remove ".jpackage.xml" file from unsigned predefined app image for DNG or
>> PKG bundles;
>> - Set the value of `signed` property in ".jpackage.xml" file to "tr
Move `ErrorTest.testAppContentWarning()` test case to
`MacSignTest.testAppContentWarning()` and rework it to fail because of faulty
app content and not invalid signing identity.
MacSignTest is supposed to be a placeholder for tests that require a signing
environment but don't fit in any existin
On Fri, 28 Mar 2025 09:26:45 GMT, Alan Bateman wrote:
> > @AlanBateman Can you review this if this patch looks good in principle?
>
> It needs confirmation that it doesn't break the build, I haven't looked into
> which parts of Liam's change weren't backed out. So if there are no build
> issue
On Fri, 28 Mar 2025 15:02:05 GMT, Alexey Semenyuk wrote:
> Make tools/jpackage/share/ErrorTest.java test safely handle the case when
> native bundling is unavailable on the test host.
>
> Additionally:
> - If native bundling is unavailable on the test host, PackageTest will throw
> `jtreg.Ski
On Mon, 31 Mar 2025 19:18:58 GMT, Joe Wang wrote:
>> LGTM. Technically it is still March in PDT though
>
>> LGTM. Technically it is still March in PDT though
>
> Thanks. It is, tricky. Thought by the time it's out, it would be April.
@JoeWang-Java,
Can you confirm which Mach5 tiers have run wi
On Mon, 31 Mar 2025 19:11:03 GMT, Naoto Sato wrote:
> LGTM. Technically it is still March in PDT though
Thanks. It is, tricky. Thought by the time it's out, it would be April.
-
PR Comment: https://git.openjdk.org/jdk/pull/24334#issuecomment-2767177971
On Fri, 28 Mar 2025 17:04:03 GMT, Joachim Kern wrote:
>> The test `testEcoFriendly()` checks if the launcher pollutes the
>> `LD_LIBRARY_PATH` environment variable.
>> Because aix and musl intentionally pollute the `LD_LIBRARY_PATH`, it does
>> not make sense to make this test somehow passing w
On Mon, 31 Mar 2025 17:42:20 GMT, Joe Wang wrote:
> Refactor XMLSecurityPropertyManager.
> The Xerces and Xalan components each had its own XMLSecurityManager and
> XMLSecurityPropertyManager. In a previous fix, the former had been unified as
> part of that changeset. This change will allow fut
On Mon, 3 Mar 2025 10:15:53 GMT, David Beaumont wrote:
>> 8349206: j.u.l.Handler classes create deadlock risk via synchronized
>> publish() method.
>>
>> 1. Remove synchronization of calls to publish() in Handlers in
>> java.util.logging package.
>> 2. Add explanatory comments to various affec
On Mon, 31 Mar 2025 13:47:27 GMT, Per Minborg wrote:
> Here are the latest benchmarks run on an M1 (macOS):
>
> ```
> Benchmark Mode Cnt Score Error
> Units
> StableFunctionBenchmark.functionavgt 10 4.228 ? 0.172
> ns/op
>
> This change overrides mutator methods in the implementation returned by
> `Map.of().entrySet()` to throw `UnsupportedOperationException`.
Liam Miller-Cushon has updated the pull request with a new target base due to a
merge or a rebase. The pull request now contains 14 commits:
- Merge remot
> This is a patch to finalize the module imports feature. Please see:
> https://bugs.openjdk.org/browse/JDK-8344700
Jan Lahoda has updated the pull request incrementally with one additional
commit since the last revision:
Fixing test.
-
Changes:
- all: https://git.openjdk.org/j
On Sat, 29 Mar 2025 08:55:43 GMT, Alan Bateman wrote:
>> Chris Plummer has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> undo change that wasn't suppose to be committed.
>
> src/java.base/share/classes/java/lang/ThreadGroup.java line 662:
On Thu, 27 Mar 2025 20:48:22 GMT, Naoto Sato wrote:
>> src/jdk.internal.le/share/classes/jdk/internal/console/SimpleConsoleReader.java
>> line 198:
>>
>>> 196:
>>> 197: if (it.hasNext()) {
>>> 198: out.append("\n\r");
>>
>> I understand this is a simple console, bu
On Wed, 26 Mar 2025 07:54:48 GMT, Jan Lahoda wrote:
> The `java.io.Console` has several backends: a simple on in `java.base`, a
> more convenient one in `jdk.internal.le` (with line-reading based on JLine)
> and one for JShell.
>
> The backend based on JLine is proving to be a somewhat problem
On Mon, 31 Mar 2025 17:04:55 GMT, Jan Lahoda wrote:
>> src/jdk.internal.le/share/classes/jdk/internal/console/SimpleConsoleReader.java
>> line 69:
>>
>>> 67: case 4: break READ; //EOF/Ctrl-D
>>> 68: case 127:
>>> 69: //backspace:
>>
>> Is it
On Tue, 11 Mar 2025 18:32:10 GMT, Naoto Sato wrote:
> JDK has been using JLine based Console implementation, in JDK20 as opt-in,
> then in JDK22 as the default. While it has been providing rich functionality
> for Console, it is increasingly difficult to maintain as a Console
> implementation.
On Wed, 12 Mar 2025 17:02:01 GMT, Naoto Sato wrote:
>> JDK has been using JLine based Console implementation, in JDK20 as opt-in,
>> then in JDK22 as the default. While it has been providing rich functionality
>> for Console, it is increasingly difficult to maintain as a Console
>> implementat
Alan – is this what you have in mind:
ByteArrayOutputStream.getInstance() // returns existing class
ByteArrayOutputStream.getUnsynchronizedInstance() // returns subclass of BAOS
that overrides the synchronization
ByteArrayOutputStream.getInstance() // returns
the new class
Clearly naming ne
On Mon, 31 Mar 2025 13:32:56 GMT, Per Minborg wrote:
>> Implement JEP 502.
>>
>> The PR passes tier1-tier3 tests.
>
> Per Minborg has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Finish and clean up benchmarks
Here is new result of the new
> Implement JEP 502.
>
> The PR passes tier1-tier3 tests.
Per Minborg has updated the pull request incrementally with one additional
commit since the last revision:
Add MethodHandle benchmark
-
Changes:
- all: https://git.openjdk.org/jdk/pull/23972/files
- new: https://git.o
On Mon, 31 Mar 2025 15:03:42 GMT, Maurizio Cimadamore
wrote:
> > This makes the list behave differently if run normally compared to being
> > run in a debug session. So, I think the current "high impedance" strategy
> > is motivated. The downside is a bit more complex code.
>
> If this is the
On Wed, 12 Mar 2025 17:02:01 GMT, Naoto Sato wrote:
>> JDK has been using JLine based Console implementation, in JDK20 as opt-in,
>> then in JDK22 as the default. While it has been providing rich functionality
>> for Console, it is increasingly difficult to maintain as a Console
>> implementat
On Mon, 31 Mar 2025 14:22:16 GMT, Maurizio Cimadamore
wrote:
>> Per Minborg has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Finish and clean up benchmarks
>
> src/java.base/share/classes/jdk/internal/lang/stable/StableValueImpl.java
>
On Mon, 31 Mar 2025 14:03:49 GMT, Maurizio Cimadamore
wrote:
> > I have rewritten all the `toString()` methods. A `StableList::toString` now
> > produces something much more similar to a regular `List::toString`. The
> > only difference is that the `StableList::toString` shows ".unset" for the
On Mon, 31 Mar 2025 14:52:28 GMT, Per Minborg wrote:
> This makes the list behave differently if run normally compared to being run
> in a debug session. So, I think the current "high impedance" strategy is
> motivated. The downside is a bit more complex code.
If this is the concern, then havi
On Thu, 27 Mar 2025 07:23:07 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this doc-only change which proposes to improve
>> the API documentation of `DeflaterInputStream`, `DeflaterOutputStream`,
>> `InflaterInputStream` and `InflaterOutputStream` classes?
>>
>> As noted in https:/
On Mon, 31 Mar 2025 14:22:16 GMT, Maurizio Cimadamore
wrote:
>> Per Minborg has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Finish and clean up benchmarks
>
> src/java.base/share/classes/jdk/internal/lang/stable/StableValueImpl.java
>
> - Don't create ".jpackage.xml" file in image for DNG or PKG bundles;
> - Remove ".jpackage.xml" file from unsigned predefined app image for DNG or
> PKG bundles;
> - Set the value of `signed` property in ".jpackage.xml" file to "true" only
> in the app image itself is signed.
Alexey Semenyuk
On Mon, 31 Mar 2025 12:43:26 GMT, Magnus Ihse Bursie wrote:
>> The `java.io.Console` has several backends: a simple on in `java.base`, a
>> more convenient one in `jdk.internal.le` (with line-reading based on JLine)
>> and one for JShell.
>>
>> The backend based on JLine is proving to be a som
On Mon, 31 Mar 2025 13:32:56 GMT, Per Minborg wrote:
>> Implement JEP 502.
>>
>> The PR passes tier1-tier3 tests.
>
> Per Minborg has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Finish and clean up benchmarks
src/java.base/share/classes/j
On Sat, 29 Mar 2025 16:22:30 GMT, Alexey Semenyuk wrote:
> - Don't create ".jpackage.xml" file in image for DNG or PKG bundles;
> - Remove ".jpackage.xml" file from unsigned predefined app image for DNG or
> PKG bundles;
> - Set the value of `signed` property in ".jpackage.xml" file to "true"
- Don't create ".jpackage.xml" file in image for DNG or PKG bundles;
- Remove ".jpackage.xml" file from unsigned predefined app image for DNG or
PKG bundles;
- Set the value of `signed` property in ".jpackage.xml" file to "true" only in
the app image itself is signed.
-
Commit mes
Make tools/jpackage/share/ErrorTest.java test safely handle the case when
native bundling is unavailable on the test host.
Additionally:
- If native bundling is unavailable on the test host, PackageTest will throw
`jtreg.SkippedException` and mark the test as skipped instead of silently doing
On Fri, 28 Mar 2025 15:02:05 GMT, Alexey Semenyuk wrote:
> Make tools/jpackage/share/ErrorTest.java test safely handle the case when
> native bundling is unavailable on the test host.
>
> Additionally:
> - If native bundling is unavailable on the test host, PackageTest will throw
> `jtreg.Ski
On a side note, profiling shows similar issues w/ expensive growth on the
ArrayList class. The same datastructure would optimize that growth… but it’s a
far more complex implementation thanks to the random access and in-place
insertion/removal. In short, the opportunity is there but the trad
> Implement JEP 502.
>
> The PR passes tier1-tier3 tests.
Per Minborg has updated the pull request incrementally with one additional
commit since the last revision:
Finish and clean up benchmarks
-
Changes:
- all: https://git.openjdk.org/jdk/pull/23972/files
- new: https://g
On Mon, 31 Mar 2025 12:57:38 GMT, Magnus Ihse Bursie wrote:
> in this particular case I wonder if not a pragma in the LEAVE macro would be
> better?
I will try it later.
-
PR Comment: https://git.openjdk.org/jdk/pull/24318#issuecomment-2766150226
On Sun, 30 Mar 2025 15:07:36 GMT, SendaoYan wrote:
> Hi all,
> File src/java.base/share/native/libjli/java.c compile error: control reaches
> end of non-void function [-Werror=return-type] with gcc options
> -fsanitize=address -O0. The function int JavaMain(void* _args) in this file
> will exe
On Wed, 26 Mar 2025 07:54:48 GMT, Jan Lahoda wrote:
> The `java.io.Console` has several backends: a simple on in `java.base`, a
> more convenient one in `jdk.internal.le` (with line-reading based on JLine)
> and one for JShell.
>
> The backend based on JLine is proving to be a somewhat problem
> Implement JEP 502.
>
> The PR passes tier1-tier3 tests.
Per Minborg has updated the pull request incrementally with one additional
commit since the last revision:
Remove StableValueFactories
-
Changes:
- all: https://git.openjdk.org/jdk/pull/23972/files
- new: https://git.
> Implement JEP 502.
>
> The PR passes tier1-tier3 tests.
Per Minborg has updated the pull request incrementally with one additional
commit since the last revision:
Revert changes in s.m.Unsafe
-
Changes:
- all: https://git.openjdk.org/jdk/pull/23972/files
- new: https://git
> Implement JEP 502.
>
> The PR passes tier1-tier3 tests.
Per Minborg has updated the pull request incrementally with two additional
commits since the last revision:
- Remove VM optimizations for StableValue fields
- Rename factory method
-
Changes:
- all: https://git.openjdk.
> Hi, for you to consider.
>
> These tests constantly fails in qemu-user.
> Either the require host to be same arch or they are very very slow in
> emulation.
> E.g. "ptrace(PTRACE_ATTACH, ..) failed for 405157: Function not implemented'"
> for SA tests.
> This is the initial set of tests, there
On Sun, 16 Mar 2025 18:43:26 GMT, Luca Kellermann wrote:
>> Per Minborg has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 246 commits:
>>
>> - Merge branch 'master' into implement-jep502
>> - Clean up exception messages and fix co
> Implement JEP 502.
>
> The PR passes tier1-tier3 tests.
Per Minborg has updated the pull request incrementally with one additional
commit since the last revision:
Fix issue with wrapped exception
-
Changes:
- all: https://git.openjdk.org/jdk/pull/23972/files
- new: https:/
> Implement JEP 502.
>
> The PR passes tier1-tier3 tests.
Per Minborg has updated the pull request incrementally with one additional
commit since the last revision:
Fix issue with StableMap and null values
-
Changes:
- all: https://git.openjdk.org/jdk/pull/23972/files
- new:
On Sun, 16 Mar 2025 19:06:36 GMT, Luca Kellermann wrote:
>> Per Minborg has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 246 commits:
>>
>> - Merge branch 'master' into implement-jep502
>> - Clean up exception messages and fix co
On Mon, 17 Mar 2025 00:44:39 GMT, Chen Liang wrote:
>> Per Minborg has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 246 commits:
>>
>> - Merge branch 'master' into implement-jep502
>> - Clean up exception messages and fix comment
> Implement JEP 502.
>
> The PR passes tier1-tier3 tests.
Per Minborg has updated the pull request with a new target base due to a merge
or a rebase. The pull request now contains 257 commits:
- Remove link
- Merge branch 'master' into implement-jep502
- Improve exception checking
- Remove
61 matches
Mail list logo
