Re: RFR: 8326447: jpackage creates Windows installers that cannot be signed [v3]

2025-03-29 Thread Cormac Redmond
On Sat, 22 Feb 2025 14:40:39 GMT, Alexey Semenyuk wrote: >> Support the use of a custom msi wrapper executable when building an exe >> installer. >> >> Put `installer.exe` file in the resource directory and jpackage will use it >> instead of the default `msiwrapper.exe` resource for exe instal

Re: RFR: 8343110: Add getChars(int, int, char[], int) to CharSequence and CharBuffer [v4]

2025-03-29 Thread Chen Liang
On Sat, 29 Mar 2025 10:09:25 GMT, Markus KARG wrote: >> This Pull Request proposes an implementation for >> [JDK-8343110](https://bugs.openjdk.org/browse/JDK-8343110): Adding the new >> method `public void getChars(int srcBegin, int srcEnd, char[] dst, int >> dstBegin)` to the `CharSequence` i

RFR: 8352565: Add native method implementation of Reference.get()

2025-03-29 Thread Kim Barrett
Please review this change which adds a native method providing the implementation of Reference::get. Referece::get is an intrinsic candidate, so this native method implementation is only used when the intrinsic is not. Currently there is intrinsic support by the interpreter, C1, C2, and graal, wh

Re: RFR: 8352088: Call of com.sun.jdi.ThreadReference.threadGroups() can lock up target VM [v6]

2025-03-29 Thread Alan Bateman
On Fri, 28 Mar 2025 21:02:21 GMT, Chris Plummer wrote: >> Calling ThreadGroupReference.groups() from an event handler can cause a >> deadlock. Details in first comment. Tested with :jdk_lang on all supported >> platforms and tier1, tier2, tier3, and tier5 svc testing. > > Chris Plummer has upda

Re: RFR: 8351996: Behavioral updates for ClassValue::remove [v5]

2025-03-29 Thread Viktor Klang
On Fri, 28 Mar 2025 23:39:30 GMT, Chen Liang wrote: >> Chen Liang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> docs > > There shouldn't be. > > 1. This just allocates a new promise for a single-threaded computation; the > promise ju

Re: Reg: Proposal: Generalized Number.parseNumber(String) Method for Java

2025-03-29 Thread Kevin Bourrillion
I appreciate you raising this; I think it is relevant to some internal discussions we’re having about the future of Number. Here’s some personal reactions from a team member (not a team consensus opinion): Unfortunately, we’ve found many times that `Number` is a pretty deficient return type tha

Re: RFR: 8343110: Add getChars(int, int, char[], int) to CharSequence and CharBuffer [v4]

2025-03-29 Thread Markus KARG
> This Pull Request proposes an implementation for > [JDK-8343110](https://bugs.openjdk.org/browse/JDK-8343110): Adding the new > method `public void getChars(int srcBegin, int srcEnd, char[] dst, int > dstBegin)` to the `CharSequence` interface, providing a **bulk-read** > facility including a

Re: JDK-8352891 Performance improvements to ByteArrayOutputStream

2025-03-29 Thread Markus KARG
Supporting what Alan said. Would love to see a static factory for a non-synchronized byte-array backed OutputStream, like `OutputStream::newByteArrayOutputStream`. John, if you like we can team up for authoring this, I have free capacity. Am 29.03.2025 um 09:33 schrieb Alan Bateman: On 28/03/

Re: JDK-8352891 Performance improvements to ByteArrayOutputStream

2025-03-29 Thread Alan Bateman
On 28/03/2025 13:05, Engebretson, John wrote: Hi all!  This message is to discuss the proposal for a public class that is faster/cheaper than ByteArrayOutputStream.  Details are on the ticket [1] so I will only summarize here: - ByteArrayOutputStream is slower than the provided alternative,

Re: RFR: 8352171: Arrays.hashCode for sub-range of byte array API addition [v2]

2025-03-29 Thread Zihao Lin
> Add the java.util.Arrays.hashCode(byte[], int start, int end). > > Hi team, I am new here, please give me some guidance. Thank you. Zihao Lin has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the