On Thu, 27 Mar 2025 17:57:37 GMT, Hamlin Li wrote:
> I also feel annoying to see some tests fail interminently.
>
> Not sure if I understand the goal of this pr, seems it might not be the best
> solution to simply disable these tests when running with qemu. My concerns
> are: qemu is still one
> I propose some cleanups to `FinalizerHistogramTest.java` to hopefully clear
> up the intermittent failures:
>
> * run with `othervm`: this test blocks the (global) finalizer thread, and
> also requires the (global) finalizer thread to enter the test's `finalize()`
> method
> * The test uses `
On Mon, 24 Mar 2025 15:46:03 GMT, Matthias Baesken wrote:
> Seems we use already a bit of functionality from common/awt in the
> splashscreen lib
Maybe. The client team has traditionally been very conservative about doing
clean-up changes like that, so you might be entering an uphill battle if
On Tue, 18 Mar 2025 09:11:00 GMT, Dmitry Chuyko wrote:
>> Please review a tiny fix in the ForkJoinPool. Since JDK 9 (JDK-8134852 [1])
>> in one case when TC subfield in ctl field is decremented, the applied
>> masking (UMASK, upper bits) may not preserve neighbor RC subfield sometimes.
>> In J
On Thu, 27 Mar 2025 17:37:04 GMT, Doug Lea wrote:
>> (Copied from https://bugs.openjdk.org/browse/JDK-8319447)
>>
>> The problems addressed by this CR/PR are that ScheduledThreadPoolExecutor is
>> both ill-suited for many (if not most) of its applications, and is a
>> performance bottleneck (a
On Thu, 27 Mar 2025 02:10:40 GMT, Jaikiran Pai wrote:
>> `ForceGC` is already waiting for `trappedCount > 0`. And I would point out
>> that `ForceGC` will be making several `System.gc()` calls, compared to just
>> one in the original version of the test.
>>
>> But if there's concern that we wo
On Tue, 25 Mar 2025 15:19:57 GMT, Jan Lahoda wrote:
>>> There are some more new jar FileSystems created in Locations, but those
>>> only typically read one file, so probably not that big deal w.r.t. this
>>> flag.
>>
>> Agreed. I initially changed those as well but when I realized they only re
On Thu, 27 Mar 2025 19:29:53 GMT, Simon Hartley wrote:
>> Doug Lea has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Address review comments
>
> src/java.base/share/classes/java/util/concurrent/ForkJoinPool.java line 3927:
>
>> 3925:
> (Copied from https://bugs.openjdk.org/browse/JDK-8319447)
>
> The problems addressed by this CR/PR are that ScheduledThreadPoolExecutor is
> both ill-suited for many (if not most) of its applications, and is a
> performance bottleneck (as seen especially in Loom and CompletableFuture
> usages
On Thu, 27 Mar 2025 20:47:31 GMT, Serguei Spitsyn wrote:
> The fix looks okay to me. I guess new test fails with a deadlock without your
> fix.
Yes. That is the failure mode. There is no detecting the failure other than a
timeout.
-
PR Comment: https://git.openjdk.org/jdk/pull/24
On Fri, 21 Feb 2025 07:10:16 GMT, Alan Bateman wrote:
>> Nicole Xu has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - 8349944: [JMH] sun.misc.UnsafeOps cannot access class
>> jdk.internal.misc.Unsafe
>>
>>The UnsafeOps JMH benchm
On Thu, 27 Mar 2025 07:23:07 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this doc-only change which proposes to improve
>> the API documentation of `DeflaterInputStream`, `DeflaterOutputStream`,
>> `InflaterInputStream` and `InflaterOutputStream` classes?
>>
>> As noted in https:/
On Mon, 24 Feb 2025 23:47:02 GMT, Chen Liang wrote:
> Use a thread-safe ReferencedKeySet instead of a WeakHashMap key set.
We might need a general test suite to ensure behaviors around concurrent
definition/queries against a MHP instance.
-
PR Comment: https://git.openjdk.org/jdk/
On Wed, 5 Mar 2025 15:14:20 GMT, Chen Liang wrote:
>> The Type and AnnotatedType hierarchies have been enigmatic to new users:
>> users have no clue how to categorize arbitrary type objects, when it is safe
>> to cast to more specific types, and the exact conditions for method
>> contracts.
>>
On Thu, 27 Mar 2025 17:38:49 GMT, David M. Lloyd wrote:
>> Provide method overloads to the ClassFile interface of the
>> java.lang.classfile API which allow parsing of classes found in memory
>> segments, as well as allowing built class files to be output to them.
>
> David M. Lloyd has updated
On Tue, 25 Mar 2025 04:13:30 GMT, Calvin Cheung wrote:
>> Ioi Lam has updated the pull request with a new target base due to a merge
>> or a rebase. The pull request now contains six commits:
>>
>> - Fixed whitespaces
>> - clean up
>> - 8352437: -XX:+AOTClassLinking is not compatible with --
> `-XX:+AOTClassLinking` requires the CDS archived full module graph (FMG).
>
> - Before this PR, when `--add-export` is specified, FMG is disabled, so AOT
> caches created with `-XX:+AOTClassLinking` cannot be loaded.
> - After this PR, if the exact same `--add-export` flags as specified acros
On Tue, 25 Mar 2025 04:12:23 GMT, Calvin Cheung wrote:
>> Ioi Lam has updated the pull request with a new target base due to a merge
>> or a rebase. The pull request now contains eight commits:
>>
>> - @calvinccheung comments
>> - Merge branch 'master' into
>> 8352437-aot-class-linking-incom
On Thu, 27 Mar 2025 19:29:29 GMT, Naoto Sato wrote:
>> The `java.io.Console` has several backends: a simple on in `java.base`, a
>> more convenient one in `jdk.internal.le` (with line-reading based on JLine)
>> and one for JShell.
>>
>> The backend based on JLine is proving to be a somewhat pr
On Wed, 26 Mar 2025 20:50:36 GMT, Chris Plummer wrote:
>> Calling ThreadGroupReference.groups() from an event handler can cause a
>> deadlock. Details in first comment. Tested with :jdk_lang on all supported
>> platforms and tier1, tier2, tier3, and tier5 svc testing.
>
> Chris Plummer has upda
On Mon, 24 Mar 2025 21:21:20 GMT, Justin Lu wrote:
> Please review this specification update for `SimpleDateFormat` which
> explicitly specifies the behavior for 'reserved' pattern letters. This is a
> specification update and has the potential low risk of making an
> implementation non-compli
On Mon, 24 Mar 2025 23:13:48 GMT, Justin Lu wrote:
>> Please review this specification update for `SimpleDateFormat` which
>> explicitly specifies the behavior for 'reserved' pattern letters. This is a
>> specification update and has the potential low risk of making an
>> implementation non-co
> `-XX:+AOTClassLinking` requires the CDS archived full module graph (FMG).
>
> - Before this PR, when `--add-export` is specified, FMG is disabled, so AOT
> caches created with `-XX:+AOTClassLinking` cannot be loaded.
> - After this PR, if the exact same `--add-export` flags as specified acros
On Wed, 26 Mar 2025 07:54:48 GMT, Jan Lahoda wrote:
> The `java.io.Console` has several backends: a simple on in `java.base`, a
> more convenient one in `jdk.internal.le` (with line-reading based on JLine)
> and one for JShell.
>
> The backend based on JLine is proving to be a somewhat problem
On Thu, 27 Mar 2025 16:03:08 GMT, Naoto Sato wrote:
>> Those system property values on Windows were derived from Windows'
>> `GetConsoleCP()` call, but they should have been taken from
>> `GetConsoleOutputCP()`. Replacing the incorrect call with the correct one
>> won't change any behavior, as
On Thu, 27 Mar 2025 14:32:18 GMT, Robbin Ehn wrote:
>> Hi, for you to consider.
>>
>> These tests constantly fails in qemu-user.
>> Either the require host to be same arch or they are very very slow in
>> emulation.
>> E.g. "ptrace(PTRACE_ATTACH, ..) failed for 405157: Function not
>> implemen
On Wed, 26 Mar 2025 20:50:36 GMT, Chris Plummer wrote:
>> Calling ThreadGroupReference.groups() from an event handler can cause a
>> deadlock. Details in first comment. Tested with :jdk_lang on all supported
>> platforms and tier1, tier2, tier3, and tier5 svc testing.
>
> Chris Plummer has upda
On Thu, 27 Mar 2025 13:27:30 GMT, Alan Bateman wrote:
>> Personally I think it's worth it. @AlanBateman, what do you think?
>
> Right now it's hard to envisage needing to have >2B delayed tasks queued.
> Maybe in a few years we might regret this. So maybe better to change it to
> return long, I
On Thu, 27 Mar 2025 17:38:49 GMT, David M. Lloyd wrote:
>> Provide method overloads to the ClassFile interface of the
>> java.lang.classfile API which allow parsing of classes found in memory
>> segments, as well as allowing built class files to be output to them.
>
> David M. Lloyd has updated
> Provide method overloads to the ClassFile interface of the
> java.lang.classfile API which allow parsing of classes found in memory
> segments, as well as allowing built class files to be output to them.
David M. Lloyd has updated the pull request incrementally with one additional
commit sinc
On Tue, 25 Mar 2025 19:17:32 GMT, Doug Lea wrote:
>> The schedule(Runnable ..) and schedule(Callable ..) methods are a single
>> sentence in the interface. The ForkJoinPool methods has more to say about
>> cancellation and shutdown. So while it could inherit, doesn't seem to be
>> worth it her
> (Copied from https://bugs.openjdk.org/browse/JDK-8319447)
>
> The problems addressed by this CR/PR are that ScheduledThreadPoolExecutor is
> both ill-suited for many (if not most) of its applications, and is a
> performance bottleneck (as seen especially in Loom and CompletableFuture
> usages
On Thu, 27 Mar 2025 16:01:59 GMT, Adam Sotona wrote:
> As the parsing benefits are none due to the memory copy.
The main benefit on the parsing is twofold: reducing the user's boilerplate,
and the future possibility of further optimizing this case. At present the
performance is the same as mak
On Thu, 27 Mar 2025 15:59:24 GMT, Naoto Sato wrote:
>> src/java.base/windows/native/libjava/java_props_md.c line 142:
>>
>>> 140: cp = GetConsoleOutputCP();
>>> 141: } else {
>>> 142: cp = GetConsoleCP();
>>
>> Just a reminder that we should handle the case where GetConsoleX
On Thu, 27 Mar 2025 16:12:24 GMT, Alan Bateman wrote:
>> Ah, you mentioned it before which I forgot! Handled the error case too.
>
> How is NULL handled in the callers?
Those system properties will be substituted with `native.encoding`
https://github.com/openjdk/jdk/blob/dc5c4148c70ca43d0a69c326
On Thu, 27 Mar 2025 16:11:47 GMT, Alan Bateman wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Handled the error case
>
> src/java.base/windows/native/libjava/java_props_md.c line 131:
>
>> 129: }
>> 130:
>> 131: s
On Thu, 27 Mar 2025 16:03:08 GMT, Naoto Sato wrote:
>> Those system property values on Windows were derived from Windows'
>> `GetConsoleCP()` call, but they should have been taken from
>> `GetConsoleOutputCP()`. Replacing the incorrect call with the correct one
>> won't change any behavior, as
On Thu, 27 Mar 2025 15:19:37 GMT, David M. Lloyd wrote:
>> Provide method overloads to the ClassFile interface of the
>> java.lang.classfile API which allow parsing of classes found in memory
>> segments, as well as allowing built class files to be output to them.
>
> David M. Lloyd has updated
On Thu, 27 Mar 2025 07:36:07 GMT, Alan Bateman wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Reflects the review comment
>
> src/java.base/windows/native/libjava/java_props_md.c line 142:
>
>> 140: cp = Ge
> Those system property values on Windows were derived from Windows'
> `GetConsoleCP()` call, but they should have been taken from
> `GetConsoleOutputCP()`. Replacing the incorrect call with the correct one
> won't change any behavior, as both calls return the same value by default
> (`GetOEMCP
On Thu, 27 Mar 2025 14:56:17 GMT, Adam Sotona wrote:
> I'm sorry, but I'm still missing the benefits part of this change.
The benefits are that the user can parse and generate class files directly from
and to mapped files, and parse class files directly from buffers given to a
class loader (fo
On Thu, 27 Mar 2025 11:07:31 GMT, Coleen Phillimore wrote:
>> Chris Plummer has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> remove unused locals.
>
> src/java.base/share/classes/java/lang/ThreadGroup.java line 661:
>
>> 659: /**
>>
> Provide method overloads to the ClassFile interface of the
> java.lang.classfile API which allow parsing of classes found in memory
> segments, as well as allowing built class files to be output to them.
David M. Lloyd has updated the pull request incrementally with one additional
commit sinc
On Mon, 24 Mar 2025 19:34:55 GMT, Vladimir Ivanov wrote:
>> Tests that use data from the file 'cmudict-0.7b.txt' was deleted. Currently
>> these tests using empty data set that looks bad.
>
> Vladimir Ivanov has updated the pull request incrementally with one
> additional commit since the last
On Wed, 12 Mar 2025 15:53:33 GMT, Vladimir Ivanov wrote:
> Tests that use data from the file 'cmudict-0.7b.txt' was deleted. Currently
> these tests using empty data set that looks bad.
This pull request has now been integrated.
Changeset: 50ac24eb
Author:Vladimir Ivanov
Committer: Derek
On Tue, 25 Mar 2025 15:27:05 GMT, David M. Lloyd wrote:
>> Provide method overloads to the ClassFile interface of the
>> java.lang.classfile API which allow parsing of classes found in memory
>> segments, as well as allowing built class files to be output to them.
>
> David M. Lloyd has updated
On Mon, 24 Mar 2025 19:34:55 GMT, Vladimir Ivanov wrote:
>> Tests that use data from the file 'cmudict-0.7b.txt' was deleted. Currently
>> these tests using empty data set that looks bad.
>
> Vladimir Ivanov has updated the pull request incrementally with one
> additional commit since the last
On Wed, 26 Mar 2025 19:28:24 GMT, Jiangli Zhou wrote:
>> Please review following changes, thanks.
>>
>> - Add `static` to the vm_info for static JDK. The `-version` output now
>> contains `static` on static JDK, e.g.:
>>
>>
>> $ static-jdk/bin/java -version
>> openjdk version "25-internal" 20
> Hi, for you to consider.
>
> These tests constantly fails in qemu-user.
> Either the require host to be same arch or they are very very slow in
> emulation.
> E.g. "ptrace(PTRACE_ATTACH, ..) failed for 405157: Function not implemented'"
> for SA tests.
> This is the initial set of tests, there
On Tue, 25 Mar 2025 15:27:05 GMT, David M. Lloyd wrote:
>> Provide method overloads to the ClassFile interface of the
>> java.lang.classfile API which allow parsing of classes found in memory
>> segments, as well as allowing built class files to be output to them.
>
> David M. Lloyd has updated
On Wed, 26 Mar 2025 20:37:46 GMT, Chris Plummer wrote:
>> Yes, one EventHandler thread dispatching to all listeners. More details
>> below:
>>
>> There is an interface called TargetListener which declares all the event
>> callbacks. TargetAdapter implements TargetListener and provides and empt
> The test `testEcoFriendly()` checks if the launcher pollutes the
> `LD_LIBRARY_PATH` environment variable.
> Because aix and musl intentionally pollute the `LD_LIBRARY_PATH`, it does not
> make sense to make this test somehow passing with crude workarounds, which
> even do not work in any case
On Thu, 27 Mar 2025 13:28:13 GMT, Jaikiran Pai wrote:
>> Joachim Kern has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> cleanup
>
> test/jdk/tools/launcher/ExecutionEnvironment.java line 28:
>
>> 26: * @bug 4780570 4731671 6354700 636707
On Wed, 26 Mar 2025 09:52:27 GMT, Joachim Kern wrote:
>> The test `testEcoFriendly()` checks if the launcher pollutes the
>> `LD_LIBRARY_PATH` environment variable.
>> Because aix and musl intentionally pollute the `LD_LIBRARY_PATH`, it does
>> not make sense to make this test somehow passing w
On Thu, 27 Mar 2025 09:06:40 GMT, Viktor Klang wrote:
>> Arguably better, but not sure it is worth regenerating diffs for? (An int
>> was used for the same reason as in FJT.getQueueSize -- they need to be
>> valid array bounds. Which might someday allow long, but if so many things
>> would ch
On Mon, 24 Mar 2025 19:34:55 GMT, Vladimir Ivanov wrote:
>> Tests that use data from the file 'cmudict-0.7b.txt' was deleted. Currently
>> these tests using empty data set that looks bad.
>
> Vladimir Ivanov has updated the pull request incrementally with one
> additional commit since the last
On Wed, 26 Mar 2025 17:12:30 GMT, Naoto Sato wrote:
>> test/jdk/java/io/IO/IO.java line 166:
>>
>>> 164: var file = Path.of(System.getProperty("test.src", "."),
>>> "Output.java")
>>> 165: .toAbsolutePath().toString();
>>> 166: var pb =
>>> ProcessTools.createTe
On Wed, 26 Mar 2025 16:19:16 GMT, Viktor Klang wrote:
> I'm breaking this change out as a separate improvement, since it will not be
> generally possible to adjust these limits on the j.u.c primitives since they
> might already use a backing `long` to pack in information which needs to be
> up
On Wed, 26 Mar 2025 20:50:36 GMT, Chris Plummer wrote:
>> Calling ThreadGroupReference.groups() from an event handler can cause a
>> deadlock. Details in first comment. Tested with :jdk_lang on all supported
>> platforms and tier1, tier2, tier3, and tier5 svc testing.
>
> Chris Plummer has upda
On Wed, 26 Mar 2025 13:42:11 GMT, Severin Gehwolf wrote:
>> test/jdk/tools/jlink/runtimeImage/ModifiedFilesWithShaOverrideTest.java line
>> 32:
>>
>>> 30: * @requires (vm.compMode != "Xcomp" & os.maxMemory >= 2g & os.family
>>> == "linux")
>>> 31: * @library ../../lib /test/lib
>>> 32: * @e
I'm breaking this change out as a separate improvement, since it will not be
generally possible to adjust these limits on the j.u.c primitives since they
might already use a backing `long` to pack in information which needs to be
updated atomically (would require 128-bit atomics to widen them, a
On Wed, 26 Mar 2025 19:52:16 GMT, Doug Lea wrote:
>> src/java.base/share/classes/java/util/concurrent/ForkJoinPool.java line 3932:
>>
>>> 3930: * @since 25
>>> 3931: */
>>> 3932: public int getDelayedTaskCount() {
>>
>> @DougLea It would seem more consistent to have this return a
On Thu, 27 Mar 2025 07:23:07 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this doc-only change which proposes to improve
>> the API documentation of `DeflaterInputStream`, `DeflaterOutputStream`,
>> `InflaterInputStream` and `InflaterOutputStream` classes?
>>
>> As noted in https:/
On Thu, 27 Mar 2025 07:19:56 GMT, Jaikiran Pai wrote:
> I spoke to Lance and we went over some possible ways to word the text for
> these classes. Based on those inputs, I've now updated the PR. I think this
> captures the necessary details and at the same time keeps it concise.
I realize the
On Wed, 26 Mar 2025 20:57:47 GMT, Naoto Sato wrote:
>> Those system property values on Windows were derived from Windows'
>> `GetConsoleCP()` call, but they should have been taken from
>> `GetConsoleOutputCP()`. Replacing the incorrect call with the correct one
>> won't change any behavior, as
On Thu, 20 Mar 2025 12:38:00 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this doc-only change which proposes to improve
>> the API documentation of `DeflaterInputStream`, `DeflaterOutputStream`,
>> `InflaterInputStream` and `InflaterOutputStream` classes?
>>
>> As noted in https:/
> Can I please get a review of this doc-only change which proposes to improve
> the API documentation of `DeflaterInputStream`, `DeflaterOutputStream`,
> `InflaterInputStream` and `InflaterOutputStream` classes?
>
> As noted in https://bugs.openjdk.org/browse/JDK-8066583 some of the
> construct
On Wed, 26 Mar 2025 09:52:27 GMT, Joachim Kern wrote:
>> The test `testEcoFriendly()` checks if the launcher pollutes the
>> `LD_LIBRARY_PATH` environment variable.
>> Because aix and musl intentionally pollute the `LD_LIBRARY_PATH`, it does
>> not make sense to make this test somehow passing w
68 matches
Mail list logo
