Re: RFR: 8351290: Clarify integral only for vector operators [v2]

2025-03-25 Thread Ian Graves
> Updating Javadoc for vector operators with VO_NOFP flags, but no > corresponding "Integral only." note in docs. Ian Graves has updated the pull request incrementally with one additional commit since the last revision: Missing period - Changes: - all: https://git.openjdk.org/

Re: RFR: 8352730: RISC-V: Disable tests in qemu-user

2025-03-25 Thread Robbin Ehn
On Tue, 25 Mar 2025 14:19:55 GMT, Robbin Ehn wrote: > Hi, for you to consider. > > These tests constantly fails in qemu-user. > Either the require host to be same arch or they are very very slow in > emulation. > E.g. "ptrace(PTRACE_ATTACH, ..) failed for 405157: Function not implemented'" > f

Feedback on JEP 502: Stable Values (Preview)

2025-03-25 Thread David Vidal Escudero
Good day, I love this new feature, and it'll be really useful since I have lots of use cases at real work to try it on. However, I'd like to point out that a less verbose form of this feature would be to pass a Supplier in the StableValue.of method, something like: static final StableValue ORDER

Re: RFR: 8352184: Jtreg tests using CommandLineOptionTest.getVMTypeOption() and optionsvalidation.JVMOptionsUtils fail on static JDK [v3]

2025-03-25 Thread David Holmes
On Tue, 25 Mar 2025 15:25:56 GMT, Jiangli Zhou wrote: >> Please review following changes, thanks. >> >> - Add `static` to the vm_info for static JDK. The `-version` output now >> contains `static` on static JDK, e.g.: >> >> >> $ static-jdk/bin/java -version >> openjdk version "25-internal" 20

Re: RFR: 8346230: [perf] scalability issue for the specjvm2008::xml.transform workload [v4]

2025-03-25 Thread Joe Wang
On Mon, 20 Jan 2025 13:51:22 GMT, Alan Bateman wrote: >> Vladimir Ivanov has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8346230 [perf] scalability issue for the specjvm2008::xml.transform >> workload > > src/java.xml/share/classes/com/

Re: RFR: 8352716: (tz) Update Timezone Data to 2025b

2025-03-25 Thread Joe Wang
On Tue, 25 Mar 2025 16:52:28 GMT, Naoto Sato wrote: > Incorporating the latest IANA Time Zone Database (2025b). Manually confirmed > the newly introduced time zone stays at the same offset (-03) on/after > 2025-04-06: > > jshell> > ZoneId.of("America/Coyhaique").getRules().getValidOffsets(Loc

Re: RFR: 8351290: Clarify integral only for vector operators

2025-03-25 Thread Paul Sandoz
On Tue, 25 Mar 2025 20:44:31 GMT, Ian Graves wrote: > Updating Javadoc for vector operators with VO_NOFP flags, but no > corresponding "Integral only." note in docs. src/jdk.incubator.vector/share/classes/jdk/incubator/vector/VectorOperators.java line 455: > 453: /** Produce {@code -a}. *

Re: RFR: 8352730: RISC-V: Disable tests in qemu-user

2025-03-25 Thread Fei Yang
On Tue, 25 Mar 2025 14:19:55 GMT, Robbin Ehn wrote: > Hi, for you to consider. > > These tests constantly fails in qemu-user. > Either the require host to be same arch or they are very very slow in > emulation. > E.g. "ptrace(PTRACE_ATTACH, ..) failed for 405157: Function not implemented'" > f

Re: RFR: 8352088: Call of com.sun.jdi.ThreadReference.threadGroups() can lock up target VM

2025-03-25 Thread Jaikiran Pai
On Tue, 25 Mar 2025 20:36:28 GMT, Chris Plummer wrote: > Calling ThreadGroupReference.groups() from an event handler can cause a > deadlock. Details in first comment. Tested with :jdk_lang on all supported > platforms and tier1, tier2, tier3, and tier5 svc testing. src/java.base/share/classes/

RFR: 8352773: JVMTI should disable events during java upcalls

2025-03-25 Thread Chris Plummer
Calling ThreadGroupReference.groups() from an event handler can cause a deadlock. Details in first comment. Tested with :jdk_lang on all supported platforms and tier1, tier2, tier3, and tier5 svc testing. - Commit messages: - get rid of unused breakpoint event code - fix more jche

Re: RFR: 8352088: Call of com.sun.jdi.ThreadReference.threadGroups() can lock up target VM

2025-03-25 Thread Chris Plummer
On Tue, 25 Mar 2025 20:36:28 GMT, Chris Plummer wrote: > Calling ThreadGroupReference.groups() from an event handler can cause a > deadlock. Details in first comment. Tested with :jdk_lang on all supported > platforms and tier1, tier2, tier3, and tier5 svc testing. Sorry, I used the wrong bugI

Re: RFR: 8352533: Report useful IOExceptions when jspawnhelper fails

2025-03-25 Thread Volker Simonis
On Fri, 21 Mar 2025 10:00:26 GMT, Aleksey Shipilev wrote: > When jspawnhelper fails for whatever reason, but more prominently due to > [JDK-8325621](https://bugs.openjdk.org/browse/JDK-8325621), it will report > the errors into stdout, but not to the relevant `IOException`. So, if the > applic

Re: RFR: 8351565: Implement JEP 502: Stable Values (Preview) [v8]

2025-03-25 Thread Johannes Graham
On Tue, 25 Mar 2025 15:52:07 GMT, Per Minborg wrote: >> Implement JEP 502. >> >> The PR passes tier1-tier3 tests. > > Per Minborg has updated the pull request incrementally with one additional > commit since the last revision: > > Revamp toString() methods test/jdk/java/lang/StableValue/Sta

Re: RFR: 8351565: Implement JEP 502: Stable Values (Preview) [v8]

2025-03-25 Thread Johannes Graham
On Tue, 25 Mar 2025 15:52:07 GMT, Per Minborg wrote: >> Implement JEP 502. >> >> The PR passes tier1-tier3 tests. > > Per Minborg has updated the pull request incrementally with one additional > commit since the last revision: > > Revamp toString() methods src/java.base/share/classes/jdk/in

Re: RFR: 8352716: (tz) Update Timezone Data to 2025b

2025-03-25 Thread Sean Coffey
On Tue, 25 Mar 2025 16:52:28 GMT, Naoto Sato wrote: > Incorporating the latest IANA Time Zone Database (2025b). Manually confirmed > the newly introduced time zone stays at the same offset (-03) on/after > 2025-04-06: > > jshell> > ZoneId.of("America/Coyhaique").getRules().getValidOffsets(Loc

Re: RFR: 8351290: Clarify integral only for vector operators [v2]

2025-03-25 Thread Paul Sandoz
On Tue, 25 Mar 2025 21:56:24 GMT, Ian Graves wrote: >> Updating Javadoc for vector operators with VO_NOFP flags, but no >> corresponding "Integral only." note in docs. > > Ian Graves has updated the pull request incrementally with one additional > commit since the last revision: > > Missing

Re: RFR: 8346230: [perf] scalability issue for the specjvm2008::xml.transform workload [v4]

2025-03-25 Thread Joe Wang
On Fri, 14 Mar 2025 01:28:34 GMT, Vladimir Ivanov wrote: >> The HashMap for caching was deleted. Now it use only ThreadLocal variable >> without synchronization. >> According to the specjvm2008::xml.transform workload the performance for low >> threads counts was not affected and improved for h

Re: RFR: 8351290: Clarify integral only for vector operators [v2]

2025-03-25 Thread Chen Liang
On Tue, 25 Mar 2025 21:56:24 GMT, Ian Graves wrote: >> Updating Javadoc for vector operators with VO_NOFP flags, but no >> corresponding "Integral only." note in docs. > > Ian Graves has updated the pull request incrementally with one additional > commit since the last revision: > > Missing

Re: RFR: 8352689: Allow for hash sum overrides when linking from the run-time image [v2]

2025-03-25 Thread Severin Gehwolf
> Please review this enhancement which adds a hidden `jlink` option > `--sha-overrides` that can be used to provide alternative hash sums for files > in an image. Please see the bug for use-cases as to why this is needed. This > patch allows for the `--sha-overrides` option to be either specifie

Withdrawn: 8350617: Improve MethodHandles.tableSwitch and remove intrinsicData

2025-03-25 Thread Chen Liang
On Tue, 25 Feb 2025 02:45:46 GMT, Chen Liang wrote: > Remove the intrinsicData field. We can obtain this from the customized MH > when we spin ultra-customized lambda forms. In the long run, we aim to remove > this intrinsic if there is no regression for call site sharing. > > The existing tab

RFR: 8351290: Clarify integral only for vector operators

2025-03-25 Thread Ian Graves
Updating Javadoc for vector operators with VO_NOFP flags, but no corresponding "Integral only." note in docs. - Commit messages: - JDK-8351290: Clarify integral only for vector operators Changes: https://git.openjdk.org/jdk/pull/24237/files Webrev: https://webrevs.openjdk.org/?re

Re: RFR: 8352489: Relax jspawnhelper version checks to informative

2025-03-25 Thread Aleksey Shipilev
On Thu, 20 Mar 2025 11:00:01 GMT, Severin Gehwolf wrote: >> src/java.base/unix/native/jspawnhelper/jspawnhelper.c line 160: >> >>> 158: >>> 159: if (strcmp(argv[1], VERSION_STRING) != 0) { >>> 160: fprintf(stdout, "Incorrect Java version: %s\n", argv[1]); >> >> Don't you want to ke

Re: RFR: 5061061: SimpleDateFormat: unspecified behavior for reserved pattern letter [v2]

2025-03-25 Thread Roger Riggs
On Mon, 24 Mar 2025 23:13:48 GMT, Justin Lu wrote: >> Please review this specification update for `SimpleDateFormat` which >> explicitly specifies the behavior for 'reserved' pattern letters. This is a >> specification update and has the potential low risk of making an >> implementation non-co

Re: RFR: 8319447: Improve performance of delayed task handling [v12]

2025-03-25 Thread Doug Lea
On Tue, 25 Mar 2025 12:06:30 GMT, Alan Bateman wrote: >> src/java.base/share/classes/java/util/concurrent/ForkJoinPool.java line 3507: >> >>> 3505: >>> 3506: /** >>> 3507: * Submits a one-shot task that becomes enabled after the given >> >> If the javadoc for the new methods from the

Re: RFR: 8351565: Implement JEP 502: Stable Values (Preview) [v8]

2025-03-25 Thread Paul Sandoz
On Tue, 25 Mar 2025 15:52:07 GMT, Per Minborg wrote: >> Implement JEP 502. >> >> The PR passes tier1-tier3 tests. > > Per Minborg has updated the pull request incrementally with one additional > commit since the last revision: > > Revamp toString() methods src/java.base/share/classes/java/l

Re: RFR: 8319447: Improve performance of delayed task handling [v13]

2025-03-25 Thread Doug Lea
> (Copied from https://bugs.openjdk.org/browse/JDK-8319447) > > The problems addressed by this CR/PR are that ScheduledThreadPoolExecutor is > both ill-suited for many (if not most) of its applications, and is a > performance bottleneck (as seen especially in Loom and CompletableFuture > usages

Re: RFR: 8352533: Report useful IOExceptions when jspawnhelper fails

2025-03-25 Thread Dan Lutker
On Tue, 25 Mar 2025 19:38:27 GMT, Aleksey Shipilev wrote: >> src/java.base/unix/native/libjava/ProcessImpl_md.c line 324: >> >>> 322: #define SPAWN_HELPER_INTERNAL_ERROR_MSG "\n" \ >>> 323: "Possible reasons:\n" \ >>> 324: " - Spawn helper ran into JDK version or configuration problems\n" \

Re: RFR: 8352533: Report useful IOExceptions when jspawnhelper fails

2025-03-25 Thread Aleksey Shipilev
On Tue, 25 Mar 2025 19:35:36 GMT, Dan Lutker wrote: >> When jspawnhelper fails for whatever reason, but more prominently due to >> [JDK-8325621](https://bugs.openjdk.org/browse/JDK-8325621), it will report >> the errors into stdout, but not to the relevant `IOException`. So, if the >> applicat

Re: RFR: 8352533: Report useful IOExceptions when jspawnhelper fails

2025-03-25 Thread Dan Lutker
On Fri, 21 Mar 2025 10:00:26 GMT, Aleksey Shipilev wrote: > When jspawnhelper fails for whatever reason, but more prominently due to > [JDK-8325621](https://bugs.openjdk.org/browse/JDK-8325621), it will report > the errors into stdout, but not to the relevant `IOException`. So, if the > applic

Re: RFR: 8319447: Improve performance of delayed task handling [v12]

2025-03-25 Thread Doug Lea
On Tue, 25 Mar 2025 16:41:41 GMT, Viktor Klang wrote: >> Doug Lea has updated the pull request with a new target base due to a merge >> or a rebase. The incremental webrev excludes the unrelated changes brought >> in by the merge/rebase. The pull request contains 47 additional commits >> since

Re: RFR: 8319447: Improve performance of delayed task handling [v12]

2025-03-25 Thread Doug Lea
On Tue, 25 Mar 2025 16:40:57 GMT, Viktor Klang wrote: >> Doug Lea has updated the pull request with a new target base due to a merge >> or a rebase. The incremental webrev excludes the unrelated changes brought >> in by the merge/rebase. The pull request contains 47 additional commits >> since

Re: RFR: 8319447: Improve performance of delayed task handling [v12]

2025-03-25 Thread Doug Lea
On Tue, 25 Mar 2025 16:38:55 GMT, Viktor Klang wrote: >> Doug Lea has updated the pull request with a new target base due to a merge >> or a rebase. The incremental webrev excludes the unrelated changes brought >> in by the merge/rebase. The pull request contains 47 additional commits >> since

Re: RFR: 8334322: Misleading values of keys in jpackage resource bundle

2025-03-25 Thread Alexander Matveev
On Tue, 25 Mar 2025 03:19:39 GMT, Alexey Semenyuk wrote: > Replace `error.invalid-value-for-package-name` and > `error.invalid-value-for-package-name.advice` l10n keys with a pair for rpm > packaging: > - `error.rpm-invalid-value-for-package-name` > - `error.rpm-invalid-value-for-package-name

Re: RFR: 8319447: Improve performance of delayed task handling [v12]

2025-03-25 Thread Doug Lea
On Tue, 25 Mar 2025 15:40:08 GMT, Viktor Klang wrote: >> Doug Lea has updated the pull request with a new target base due to a merge >> or a rebase. The incremental webrev excludes the unrelated changes brought >> in by the merge/rebase. The pull request contains 47 additional commits >> since

Re: RFR: 8319447: Improve performance of delayed task handling [v12]

2025-03-25 Thread Doug Lea
On Tue, 25 Mar 2025 15:35:52 GMT, Viktor Klang wrote: >> Doug Lea has updated the pull request with a new target base due to a merge >> or a rebase. The incremental webrev excludes the unrelated changes brought >> in by the merge/rebase. The pull request contains 47 additional commits >> since

Re: RFR: 8319447: Improve performance of delayed task handling [v12]

2025-03-25 Thread Doug Lea
On Tue, 25 Mar 2025 15:30:22 GMT, Viktor Klang wrote: >> Doug Lea has updated the pull request with a new target base due to a merge >> or a rebase. The incremental webrev excludes the unrelated changes brought >> in by the merge/rebase. The pull request contains 47 additional commits >> since

Re: RFR: 8352016: Improve java/lang/RuntimeTests/RuntimeExitLogTest.java [v2]

2025-03-25 Thread Roger Riggs
On Fri, 21 Mar 2025 09:06:14 GMT, KIRIYAMA Takuya wrote: >> test/jdk/java/lang/RuntimeTests/ExitLogging-FINER.properties line 8: >> >>> 6: >>> 7: java.util.logging.ConsoleHandler.level = ALL >>> 8: java.lang.Runtime.level = FINER >> >> It is a waste of resources to test every combination of lo

Re: RFR: 8319447: Improve performance of delayed task handling [v12]

2025-03-25 Thread Doug Lea
On Tue, 25 Mar 2025 15:14:56 GMT, Viktor Klang wrote: >> Doug Lea has updated the pull request with a new target base due to a merge >> or a rebase. The incremental webrev excludes the unrelated changes brought >> in by the merge/rebase. The pull request contains 47 additional commits >> since

Re: RFR: 8352689: Allow for hash sum overrides when linking from the run-time image [v2]

2025-03-25 Thread Severin Gehwolf
On Tue, 25 Mar 2025 17:43:07 GMT, Severin Gehwolf wrote: >> Please review this enhancement which adds a hidden `jlink` option >> `--sha-overrides` that can be used to provide alternative hash sums for >> files in an image. Please see the bug for use-cases as to why this is >> needed. This patc

Re: RFR: 8352689: Allow for hash sum overrides when linking from the run-time image [v2]

2025-03-25 Thread Severin Gehwolf
On Tue, 25 Mar 2025 17:43:07 GMT, Severin Gehwolf wrote: >> Please review this enhancement which adds a hidden `jlink` option >> `--sha-overrides` that can be used to provide alternative hash sums for >> files in an image. Please see the bug for use-cases as to why this is >> needed. This patc

Re: RFR: 8352689: Allow for hash sum overrides when linking from the run-time image [v2]

2025-03-25 Thread Severin Gehwolf
On Tue, 25 Mar 2025 13:51:10 GMT, Christoph Langer wrote: > The only review thing I could find were the copyright years which need > updates. I've fixed copyright years in the latest update. - PR Comment: https://git.openjdk.org/jdk/pull/24190#issuecomment-2752051896

Re: RFR: 8352184: Jtreg tests using CommandLineOptionTest.getVMTypeOption() and optionsvalidation.JVMOptionsUtils fail on static JDK [v3]

2025-03-25 Thread Jiangli Zhou
> Please review following changes, thanks. > > - Add `static` to the vm_info for static JDK. The `-version` output now > contains `static` on static JDK, e.g.: > > > $ static-jdk/bin/java -version > openjdk version "25-internal" 2025-09-16 > OpenJDK Runtime Environment (fastdebug build > 25-in

RFR: 8352716: (tz) Update Timezone Data to 2025b

2025-03-25 Thread Naoto Sato
Incorporating the latest IANA Time Zone Database (2025b). Manually confirmed the newly introduced time zone stays at the same offset (-03) on/after 2025-04-06: jshell> ZoneId.of("America/Coyhaique").getRules().getValidOffsets(LocalDateTime.of(2025, 4, 6, 0, 0)) $198 ==> [-03:00] -

Re: RFR: 8319447: Improve performance of delayed task handling [v12]

2025-03-25 Thread Viktor Klang
On Sat, 22 Mar 2025 11:09:03 GMT, Doug Lea wrote: >> (Copied from https://bugs.openjdk.org/browse/JDK-8319447) >> >> The problems addressed by this CR/PR are that ScheduledThreadPoolExecutor is >> both ill-suited for many (if not most) of its applications, and is a >> performance bottleneck (a

Re: RFR: 8351565: Implement JEP 502: Stable Values (Preview) [v8]

2025-03-25 Thread Per Minborg
On Tue, 25 Mar 2025 15:52:07 GMT, Per Minborg wrote: >> Implement JEP 502. >> >> The PR passes tier1-tier3 tests. > > Per Minborg has updated the pull request incrementally with one additional > commit since the last revision: > > Revamp toString() methods I have rewritten all the `toString

Integrated: 8346948: Update CLDR to Version 47.0

2025-03-25 Thread Naoto Sato
On Wed, 19 Mar 2025 17:29:20 GMT, Naoto Sato wrote: > Upgrading the CLDR to version 47.0. A corresponding CSR has also been drafted. This pull request has now been integrated. Changeset: 993eae4a Author:Naoto Sato URL: https://git.openjdk.org/jdk/commit/993eae4aa591ec9610b9d8bc03382

Re: RFR: 8346948: Update CLDR to Version 47.0 [v2]

2025-03-25 Thread Naoto Sato
On Wed, 19 Mar 2025 17:48:20 GMT, Naoto Sato wrote: >> Upgrading the CLDR to version 47.0. A corresponding CSR has also been >> drafted. > > Naoto Sato has updated the pull request incrementally with one additional > commit since the last revision: > > Copyright year/bugid update Thanks for

Re: RFR: 5061061: SimpleDateFormat: unspecified behavior for reserved pattern letter [v2]

2025-03-25 Thread Naoto Sato
On Mon, 24 Mar 2025 23:13:48 GMT, Justin Lu wrote: >> Please review this specification update for `SimpleDateFormat` which >> explicitly specifies the behavior for 'reserved' pattern letters. This is a >> specification update and has the potential low risk of making an >> implementation non-co

Re: RFR: 8351565: Implement JEP 502: Stable Values (Preview) [v8]

2025-03-25 Thread Per Minborg
> Implement JEP 502. > > The PR passes tier1-tier3 tests. Per Minborg has updated the pull request incrementally with one additional commit since the last revision: Revamp toString() methods - Changes: - all: https://git.openjdk.org/jdk/pull/23972/files - new: https://git.op

Re: RFR: 8319447: Improve performance of delayed task handling [v12]

2025-03-25 Thread Viktor Klang
On Sat, 22 Mar 2025 11:09:03 GMT, Doug Lea wrote: >> (Copied from https://bugs.openjdk.org/browse/JDK-8319447) >> >> The problems addressed by this CR/PR are that ScheduledThreadPoolExecutor is >> both ill-suited for many (if not most) of its applications, and is a >> performance bottleneck (a

Re: RFR: 8319447: Improve performance of delayed task handling [v12]

2025-03-25 Thread Viktor Klang
On Sat, 22 Mar 2025 11:09:03 GMT, Doug Lea wrote: >> (Copied from https://bugs.openjdk.org/browse/JDK-8319447) >> >> The problems addressed by this CR/PR are that ScheduledThreadPoolExecutor is >> both ill-suited for many (if not most) of its applications, and is a >> performance bottleneck (a

Re: RFR: 8319447: Improve performance of delayed task handling [v12]

2025-03-25 Thread Viktor Klang
On Sat, 22 Mar 2025 11:09:03 GMT, Doug Lea wrote: >> (Copied from https://bugs.openjdk.org/browse/JDK-8319447) >> >> The problems addressed by this CR/PR are that ScheduledThreadPoolExecutor is >> both ill-suited for many (if not most) of its applications, and is a >> performance bottleneck (a

Re: RFR: 8352536: Add overloads to parse and build class files from/to MemorySegment [v3]

2025-03-25 Thread David M . Lloyd
> Provide method overloads to the ClassFile interface of the > java.lang.classfile API which allow parsing of classes found in memory > segments, as well as allowing built class files to be output to them. David M. Lloyd has updated the pull request incrementally with two additional commits sin

Re: RFR: 8352184: Jtreg tests using CommandLineOptionTest.getVMTypeOption() and optionsvalidation.JVMOptionsUtils fail on static JDK [v2]

2025-03-25 Thread Jiangli Zhou
On Tue, 25 Mar 2025 05:16:36 GMT, David Holmes wrote: >> Jiangli Zhou has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Allocate memory for vm_info string using NEW_C_HEAP_ARRAY. > > src/hotspot/share/runtime/abstract_vm_version.cpp line 1

Re: RFR: 8352642: Set zipinfo-time=false when constructing zipfs FileSystem in com.sun.tools.javac.file.JavacFileManager$ArchiveContainer for better performance

2025-03-25 Thread Jan Lahoda
On Mon, 24 Mar 2025 23:15:06 GMT, Jason Zaugg wrote: >> I wonder if there's some suspicion of a particular problem in the other >> branch, or other reason to not add the flag there as well. I would expect >> the default should be to add it to both branches, unless there's a fairly >> strong re

Re: RFR: 8319447: Improve performance of delayed task handling [v12]

2025-03-25 Thread Viktor Klang
On Sat, 22 Mar 2025 11:09:03 GMT, Doug Lea wrote: >> (Copied from https://bugs.openjdk.org/browse/JDK-8319447) >> >> The problems addressed by this CR/PR are that ScheduledThreadPoolExecutor is >> both ill-suited for many (if not most) of its applications, and is a >> performance bottleneck (a

Integrated: 8351897: Extra closing curly brace typos in Javadoc

2025-03-25 Thread Archie Cobbs
On Thu, 13 Mar 2025 01:21:54 GMT, Archie Cobbs wrote: > This PR fixes minor Javadoc typos in a few `java.base` classes. Extra curly > braces have been sneaking in. This pull request has now been integrated. Changeset: fe03e2ec Author:Archie Cobbs URL: https://git.openjdk.org/jdk/co

Re: RFR: 8351565: Implement JEP 502: Stable Values (Preview) [v6]

2025-03-25 Thread Luca Kellermann
On Fri, 21 Mar 2025 16:19:17 GMT, Per Minborg wrote: > > Comments on visual noise and side effects in `toString`. > > `renderWrapped` is clever for a single stable value, but it makes for a > > very noisy display string, with confusing doubly-nested `[]`, for composite > > stable values. I'm ta

RFR: 8352730: RISC-V: Disable tests in qemu-user

2025-03-25 Thread Robbin Ehn
Hi, for you to consider. These tests constantly fails in qemu-user. Either the require host to be same arch or they are very very slow in emulation. E.g. "ptrace(PTRACE_ATTACH, ..) failed for 405157: Function not implemented'" for SA tests. This is the initial set of tests, there are many more, b

Re: RFR: 8352689: Allow for hash sum overrides when linking from the run-time image

2025-03-25 Thread Christoph Langer
On Mon, 24 Mar 2025 11:02:15 GMT, Severin Gehwolf wrote: > Please review this enhancement which adds a hidden `jlink` option > `--sha-overrides` that can be used to provide alternative hash sums for files > in an image. Please see the bug for use-cases as to why this is needed. This > patch al

Re: RFR: 8343110: Add getChars(int, int, char[], int) to CharSequence and CharBuffer [v3]

2025-03-25 Thread Alan Bateman
On Mon, 24 Mar 2025 11:55:27 GMT, Markus KARG wrote: >> This Pull Request proposes an implementation for >> [JDK-8343110](https://bugs.openjdk.org/browse/JDK-8343110): Adding the new >> method `public void getChars(int srcBegin, int srcEnd, char[] dst, int >> dstBegin)` to the `CharSequence` i

Integrated: 8352509: Update jdk.test.lib.SecurityTools jar method to accept List parameter

2025-03-25 Thread Mikhail Yankelevich
On Tue, 25 Mar 2025 11:56:37 GMT, Mikhail Yankelevich wrote: > Updating `jdk.test.lib.SecurityTools` class to have jar method accept > `List` parameter similar to `keytool` methods. > Currently this only accept String parameter, which is error prone with > missing space This pull request has

Re: RFR: 8352509: Update jdk.test.lib.SecurityTools jar method to accept List parameter [v2]

2025-03-25 Thread Weijun Wang
On Tue, 25 Mar 2025 13:00:44 GMT, Mikhail Yankelevich wrote: >> Updating `jdk.test.lib.SecurityTools` class to have jar method accept >> `List` parameter similar to `keytool` methods. >> Currently this only accept String parameter, which is error prone with >> missing space > > Mikhail Yankele

Re: RFR: 8352509: Update jdk.test.lib.SecurityTools jar method to accept List parameter [v2]

2025-03-25 Thread duke
On Tue, 25 Mar 2025 13:00:44 GMT, Mikhail Yankelevich wrote: >> Updating `jdk.test.lib.SecurityTools` class to have jar method accept >> `List` parameter similar to `keytool` methods. >> Currently this only accept String parameter, which is error prone with >> missing space > > Mikhail Yankele

RFR: 8352509: Update jdk.test.lib.SecurityTools jar method to accept List parameter

2025-03-25 Thread Mikhail Yankelevich
Updating `jdk.test.lib.SecurityTools` class to have jar method accept `List` parameter similar to `keytool` methods. Currently this only accept String parameter, which is error prone with missing space - Commit messages: - Update jdk.test.lib.SecurityTools jar method to accept List

Re: RFR: 8343110: Add getChars(int, int, char[], int) to CharSequence and CharBuffer

2025-03-25 Thread Markus KARG
On Sun, 23 Mar 2025 08:42:55 GMT, Chen Liang wrote: >> This Pull Request proposes an implementation for >> [JDK-8343110](https://bugs.openjdk.org/browse/JDK-8343110): Adding the new >> method `public void getChars(int srcBegin, int srcEnd, char[] dst, int >> dstBegin)` to the `CharSequence` in

Re: RFR: 8319447: Improve performance of delayed task handling [v12]

2025-03-25 Thread Alan Bateman
On Mon, 24 Mar 2025 20:03:47 GMT, Joe Darcy wrote: >> Doug Lea has updated the pull request with a new target base due to a merge >> or a rebase. The incremental webrev excludes the unrelated changes brought >> in by the merge/rebase. The pull request contains 47 additional commits >> since th

Re: RFR: 8342868: Errors related to unused code on Windows after 8339120 in core libs [v2]

2025-03-25 Thread Julian Waters
On Thu, 31 Oct 2024 05:43:11 GMT, Julian Waters wrote: >> After 8339120, gcc began catching many different instances of unused code in >> the Windows specific codebase. Some of these seem to be bugs. I've taken the >> effort to mark out all the relevant globals and locals that trigger the >> u

RFR: 8315130: java.lang.IllegalAccessError when processing classlist to create CDS archive

2025-03-25 Thread Timofei Pushkin
If a base class is package-private then its subclasses should have the same package name and defining class loader, otherwise `IllegalAccessError` is thrown when linking a subclass. Currently when dumping a static archive separate `URLClassLoader`s are used for each unregistered classes' source.

Re: RFR: 8352046: Test testEcoFriendly() in jdk tools launcher ExecutionEnvironment.java for AIX and Linux/musl is brittle [v2]

2025-03-25 Thread Joachim Kern
> The test `testEcoFriendly()` checks if the launcher pollutes the > `LD_LIBRARY_PATH` environment variable. > Because aix and musl intentionally pollute the `LD_LIBRARY_PATH`, it does not > make sense to make this test somehow passing with crude workarounds, which > even do not work in any case

Re: RFR: 8346948: Update CLDR to Version 47.0 [v2]

2025-03-25 Thread Justin Lu
On Wed, 19 Mar 2025 17:48:20 GMT, Naoto Sato wrote: >> Upgrading the CLDR to version 47.0. A corresponding CSR has also been >> drafted. > > Naoto Sato has updated the pull request incrementally with one additional > commit since the last revision: > > Copyright year/bugid update Spec chang