> On Mar 4, 2025, at 10:20 AM, Alexey Semenyuk
> wrote:
>
>
>
> On 3/4/2025 11:06 AM, Michael Hall wrote:
>>> Good point about `CFBundleGetInfoString`. Maybe jpackage should set this
>>> field with the value of `--description` option. Another finding!
>>>
>>> As for editing "Info.plist" fr
> On Mar 4, 2025, at 10:06 AM, Michael Hall wrote:
>
>>>
>> Good point about `CFBundleGetInfoString`. Maybe jpackage should set this
>> field with the value of `--description` option. Another finding!
>>
>> As for editing "Info.plist" from the runtime source, if the directory
>> referenced
On Mon, 24 Feb 2025 16:54:59 GMT, Alexey Semenyuk wrote:
> - Fix the warning message about the custom installation directory location
> jpackage issues for DMG runtime packaging.
> - Don't issue the warning when the `--install-dir` value equals the default
> installation directory location.
>
On Sun, 23 Feb 2025 10:20:23 GMT, Kim Barrett wrote:
> I've made a prototype that adds Cleaner.waitForCleaning() and changes
> Bits.reserveMemory() to use it.
>
> https://github.com/openjdk/jdk/compare/master...kimbarrett:openjdk-jdk:wait-for-cleaning?expand=1
These caught my eye during my rea
On Mon, 24 Feb 2025 23:45:37 GMT, Chen Liang wrote:
>> LF editor spins classes, this avoids the spinning overhead and should speed
>> up non-capturing lambdas too.
>>
>> There may need to be additional intrinsic work for MH combinator lf bytecode
>> generation.
>
> Chen Liang has updated the p
On Thu, 27 Feb 2025 14:17:30 GMT, Alexey Semenyuk wrote:
> Add a test to verify jpackage is using a custom MSI condition blocking
> package installation depending on the version of Windows where the package
> installer runs. Support for this MSI condition was added in
> [JDK-8150442](https://b
On Mon, 3 Mar 2025 13:33:05 GMT, Sean Mullan wrote:
> Please review this fix to a test that fails when run with --enable-preview.
> This fix is to add all the necessary utility classes imported by the test to
> the JAR file, and not just the test classes.
The core reflection used by the launch
On Sun, 22 Oct 2023 17:26:52 GMT, Laurent Bourgès wrote:
>> * improved mixed insertion sort (makes whole sorting faster)
>> * introduced Radix which sort shows several times boost of performance and
>> has linear complexity instead of n*ln(n)
>> * improved merging sort for almost sorted data
>>
On Mon, 3 Mar 2025 20:24:54 GMT, Vladimir Ivanov wrote:
> test setup was updated to generate data of requested size.
Update to regular cycle template. Thanks
-
PR Comment: https://git.openjdk.org/jdk/pull/23873#issuecomment-2698720228
> test setup was updated to generate data of requested size.
Vladimir Ivanov has updated the pull request incrementally with one additional
commit since the last revision:
JDK-8350811 [JMH] test foreign.StrLenTest failed with
StringIndexOutOfBoundsException for size=451
-
Change
On Mon, 3 Mar 2025 13:33:05 GMT, Sean Mullan wrote:
> Please review this fix to a test that fails when run with --enable-preview.
> This fix is to add all the necessary utility classes imported by the test to
> the JAR file, and not just the test classes.
This pull request has been closed with
On Mon, 3 Mar 2025 13:33:05 GMT, Sean Mullan wrote:
> Please review this fix to a test that fails when run with --enable-preview.
> This fix is to add all the necessary utility classes imported by the test to
> the JAR file, and not just the test classes.
I am withdrawing this PR for now and m
On Wed, 26 Feb 2025 13:50:52 GMT, Jan Lahoda wrote:
> This is a patch to finalize the module imports feature. Please see:
> https://bugs.openjdk.org/browse/JDK-8344700
looks sensible
test/langtools/tools/javac/modules/EdgeCases.java line 1190:
> 1188:
> 1189: List expected = List.of(
On Mon, 3 Mar 2025 15:24:05 GMT, Chen Liang wrote:
> After a call to `ClassValue.remove`, a `ClassValue` can still install a value
> that is computed with information that is not up-to-date with the remove
> call. This is demonstrated in the test case, where an innocuous
> `ClassValue.get` cal
On Tue, 4 Mar 2025 18:12:48 GMT, Justin Lu wrote:
>> Please review this PR and associated CSR which disallows passing null to 4
>> `DecimalFormat` prefix/suffix setter methods.
>>
>> Currently these setters do not check the input String for null. When the
>> prefix/suffix is null, any such Dec
> Please review this PR and associated CSR which disallows passing null to 4
> `DecimalFormat` prefix/suffix setter methods.
>
> Currently these setters do not check the input String for null. When the
> prefix/suffix is null, any such DecimalFormat instances are effectively
> non-functional as
On Tue, 25 Feb 2025 21:51:15 GMT, Claes Redestad wrote:
>> Chen Liang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> We no longer load DelegateMH as we no longer rebind
>
> Just got back home. Some comments inline, will need to run some
> Hi all,
>
> please review this change that implements (currently Draft) JEP: G1:
> Improve Application Throughput with a More Efficient Write-Barrier.
>
> The reason for posting this early is that this is a large change, and the JEP
> process is already taking very long with no end in sight
On Wed, 26 Feb 2025 22:18:17 GMT, Justin Lu wrote:
> Please review this PR which clarifies some behavior regarding NumberFormat
> grouping specifically in the grouping related methods.
>
> Please see the corresponding CSR for further detail. Note that an alternative
> would be to specify this
On Tue, 4 Mar 2025 16:00:46 GMT, Thomas Schatzl wrote:
>> src/hotspot/share/gc/g1/g1ConcurrentRefine.hpp line 116:
>>
>>> 114: SwapGlobalCT,// Swap global card table.
>>> 115: SwapJavaThreadsCT, // Swap java thread's card tables.
>>> 116: SwapGCThreadsCT,
>>
> Good point about `CFBundleGetInfoString`. Maybe jpackage should set this
> field with the value of `--description` option. Another finding!
>
> As for editing "Info.plist" from the runtime source, if the directory
> referenced from `--runtime-image` option is a valid bundle, i.e. has
> "C
On Tue, 4 Mar 2025 16:04:00 GMT, Thomas Schatzl wrote:
>> src/hotspot/share/gc/g1/g1ConcurrentRefineThread.cpp line 219:
>>
>>> 217: // The young gen revising mechanism reads the predictor and the
>>> values set
>>> 218: // here. Avoid inconsistencies by locking.
>>> 219: Mute
On Tue, 4 Mar 2025 15:56:05 GMT, Thomas Schatzl wrote:
> It's fast anyway.
To clarify: If you have multiple refinement rounds between two garbage
collections, the time to clear the young gen cards is almost noise compared to
the actual refinement effort. Like two magnitudes faster.
--
On 3/4/2025 11:06 AM, Michael Hall wrote:
Good point about `CFBundleGetInfoString`. Maybe jpackage should set this field
with the value of `--description` option. Another finding!
As for editing "Info.plist" from the runtime source, if the directory referenced from `--runtime-image` option i
On Tue, 4 Mar 2025 15:33:29 GMT, Albert Mingkun Yang wrote:
>> Thomas Schatzl has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> iwalulya review
>> * comments for variables tracking to-collection-set and just dirtied
>> cards after GC/
On Tue, 4 Mar 2025 15:16:17 GMT, Albert Mingkun Yang wrote:
>> Thomas Schatzl has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> iwalulya review
>> * comments for variables tracking to-collection-set and just dirtied
>> cards after GC/
On Sat, 15 Feb 2025 21:27:56 GMT, Archie Cobbs wrote:
>> Please review this patch which removes unnecessary `@SuppressWarnings`
>> annotations.
>
> Archie Cobbs has updated the pull request with a new target base due to a
> merge or a rebase. The pull request now contains 22 commits:
>
> - Me
On Tue, 4 Mar 2025 11:56:56 GMT, Thomas Schatzl wrote:
>> Hi all,
>>
>> please review this change that implements (currently Draft) JEP: G1:
>> Improve Application Throughput with a More Efficient Write-Barrier.
>>
>> The reason for posting this early is that this is a large change, and the
On 3/3/2025 9:58 PM, Michael Hall wrote:
On Mar 3, 2025, at 1:51 PM, Michael Hall wrote:
On Mar 3, 2025, at 1:37 PM, Alexey Semenyuk
wrote:
Hi Michael,
Thank you for the detailed report! I filed [1] ticket that, I hope,
captures all findings from your report. Let me know if anythin
On Sat, 15 Feb 2025 21:27:56 GMT, Archie Cobbs wrote:
>> Please review this patch which removes unnecessary `@SuppressWarnings`
>> annotations.
>
> Archie Cobbs has updated the pull request with a new target base due to a
> merge or a rebase. The pull request now contains 22 commits:
>
> - Me
On Tue, 4 Feb 2025 12:35:50 GMT, SendaoYan wrote:
> Hi all,
>
> Several JMH tests fails "cannot access class
> jdk.internal.vm.ContinuationScope (in module java.base) because module
> java.base does not export jdk.internal.vm to unnamed module". This PR add VM
> option `--add-exports=java.bas
On Tue, 4 Mar 2025 14:17:59 GMT, Chen Liang wrote:
> The LambdaForm will be only used for non-customized bytecode (which cannot
> fully inline anyways)
True, without customization the cases holder in the current implementation will
not be a constant, so we can never inline the cases for shared
On Tue, 4 Mar 2025 14:25:45 GMT, Jorn Vernee wrote:
> as we skipped generating the intrinsic
Huh, why? As I understand, intrinsics are bound on NamedFunction; the
NamedFunction to select a MH should be still there in a MH chain.
-
PR Comment: https://git.openjdk.org/jdk/pull/23763
On Tue, 4 Mar 2025 14:26:19 GMT, Chen Liang wrote:
>> src/java.base/share/classes/java/lang/invoke/InvokerBytecodeGenerator.java
>> line 628:
>>
>>> 626: continue;
>>> 627: }
>>> 628:
On Mon, 24 Feb 2025 23:45:37 GMT, Chen Liang wrote:
>> LF editor spins classes, this avoids the spinning overhead and should speed
>> up non-capturing lambdas too.
>>
>> There may need to be additional intrinsic work for MH combinator lf bytecode
>> generation.
>
> Chen Liang has updated the p
On Tue, 4 Mar 2025 14:09:03 GMT, Chen Liang wrote:
>> src/java.base/share/classes/java/lang/invoke/LambdaForm.java line 1658:
>>
>>> 1656: var carrier = argument(0, L_TYPE).withConstraint(species); //
>>> BMH bound with data
>>> 1657: Name[] constNames = new Name[] { carrier, ne
On Tue, 4 Mar 2025 14:10:36 GMT, Jorn Vernee wrote:
>> Remove the intrinsicData field. We can obtain this from the customized MH
>> when we spin ultra-customized lambda forms. In the long run, we aim to
>> remove this intrinsic if there is no regression for call site sharing.
>>
>> The existin
On Tue, 4 Mar 2025 14:33:27 GMT, Jorn Vernee wrote:
>> In that case, won't the root form be customized and the table switch names
>> be inlined into the root form?
>
> The root would e.g. have a constant BMH pointing at a _shared_ tableSwitch
> LF. So, the BMH fields would be seen as constant a
On Tue, 4 Mar 2025 14:11:28 GMT, Jorn Vernee wrote:
>> src/java.base/share/classes/java/lang/invoke/MethodHandles.java line 7664:
>>
>>> 7662: if (mh.type() != expectedType)
>>> 7663: throw new IllegalArgumentException(
>>> 7664: "Some targets do n
On Tue, 4 Mar 2025 13:42:16 GMT, Jorn Vernee wrote:
>> Remove the intrinsicData field. We can obtain this from the customized MH
>> when we spin ultra-customized lambda forms. In the long run, we aim to
>> remove this intrinsic if there is no regression for call site sharing.
>>
>> The existin
On Tue, 25 Feb 2025 02:45:46 GMT, Chen Liang wrote:
> Remove the intrinsicData field. We can obtain this from the customized MH
> when we spin ultra-customized lambda forms. In the long run, we aim to remove
> this intrinsic if there is no regression for call site sharing.
>
> The existing tab
On Tue, 4 Mar 2025 14:12:05 GMT, Jorn Vernee wrote:
> the LambdaForm will just have a single call site for all the cases, whereas
> the intrinsic does emit a call per case?
Yes. The LambdaForm will be only used for non-customized bytecode (which cannot
fully inline anyways) or interpretation.
On Tue, 4 Mar 2025 13:35:50 GMT, Jorn Vernee wrote:
>> I reviewed the other use of `intrinsicData`, `tableSwitch`. I believe the
>> intrinsic is actually a regression by growing the bytecode size - we should
>> just select a MH via hash table lookup and invoke that MH, given all MHs in
>> that
On Tue, 4 Mar 2025 11:56:50 GMT, Jorn Vernee wrote:
>> Chen Liang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> We no longer load DelegateMH as we no longer rebind
>
> src/java.base/share/classes/java/lang/invoke/LambdaForm.java line 1
On Tue, 25 Feb 2025 02:45:46 GMT, Chen Liang wrote:
> The existing tableSwitch combinator's LF is unnecessarily complex. This patch
> also simplifies the tableSwitch combinator.
You're gonna have to explain this. Looking at the code, I think the
optimization here is that, the LambdaForm will j
On Mon, 24 Feb 2025 22:08:53 GMT, Chen Liang wrote:
> we should just select a MH via hash table lookup and invoke that MH
I had something like this in an early prototype of the `tableSwitch`
combinator, but it does not work, as it prevents the method handle calls for
each case from being inlin
On Mon, 24 Feb 2025 23:45:37 GMT, Chen Liang wrote:
>> LF editor spins classes, this avoids the spinning overhead and should speed
>> up non-capturing lambdas too.
>>
>> There may need to be additional intrinsic work for MH combinator lf bytecode
>> generation.
>
> Chen Liang has updated the p
Sorry, forgot to link the thread.
https://old.reddit.com/r/java/comments/1j2pr78/
And here is the comment in question.
https://old.reddit.com/r/java/comments/1j2pr78/compact_source_files_and_instance_main_methods_jep/mfy9dof/
Hello Amber Dev Team and Core Libs Dev Team,
Another reddit discussion popped up today about IO.println(), and one of
the comments mentioned that they wanted something along the lines of this.
IO.println(num1, num2, num3); //prints out "1 2 3"
I proposed that maybe a better option would be a Str
> Hi all,
>
> please review this change that implements (currently Draft) JEP: G1:
> Improve Application Throughput with a More Efficient Write-Barrier.
>
> The reason for posting this early is that this is a large change, and the JEP
> process is already taking very long with no end in sight
On Tue, 4 Mar 2025 10:06:37 GMT, Ivan Walulya wrote:
>> Thomas Schatzl has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> * iwalulya review 2
>> * G1ConcurrentRefineWorkState -> G1ConcurrentRefineSweepState
>> * some additional docu
On Tue, 4 Mar 2025 10:15:18 GMT, Jaikiran Pai wrote:
> I believe the proposed change here to package the necessary class files in
> the JAR file, so that they are available when launching java with that JAR
> file in the classpath, is correct.
I just realized one thing - this `OutputAnalyzer`
This is a patch to finalize the module imports feature. Please see:
https://bugs.openjdk.org/browse/JDK-8344700
-
Commit messages:
- Cleanup.
- Cleanup.
- Finalizing module imports.
Changes: https://git.openjdk.org/jdk/pull/23801/files
Webrev: https://webrevs.openjdk.org/?repo=j
On Fri, 28 Feb 2025 20:40:37 GMT, Sergey Chernyshev
wrote:
>> Cgroup V1 subsustem fails to initialize mounted controllers properly in
>> certain cases, that may lead to controllers left undetected/inactive. We
>> observed the behavior in CloudFoundry deployments, it affects also host
>> syste
On Tue, 4 Mar 2025 09:57:56 GMT, Thomas Schatzl wrote:
>> Hi all,
>>
>> please review this change that implements (currently Draft) JEP: G1:
>> Improve Application Throughput with a More Efficient Write-Barrier.
>>
>> The reason for posting this early is that this is a large change, and the
On Mon, 3 Mar 2025 20:24:54 GMT, Vladimir Ivanov wrote:
> test setup was updated to generate data of requested size.
Looks good. Just 1 minor question
test/micro/org/openjdk/bench/java/lang/foreign/ToCStringTest.java line 100:
> 98: mollit anim id est laborum.
> 99:
> Hi all,
>
> please review this change that implements (currently Draft) JEP: G1:
> Improve Application Throughput with a More Efficient Write-Barrier.
>
> The reason for posting this early is that this is a large change, and the JEP
> process is already taking very long with no end in sight
On Tue, 4 Mar 2025 10:37:47 GMT, Martin Doerr wrote:
> I got an error while testing java/foreign/TestUpcallStress.java on
> linuxaarch64 with this PR:
>
> ```
> # Internal Error
> (/openjdk-jdk-linux_aarch64-dbg/jdk/src/hotspot/share/gc/g1/g1CardTable.cpp:56),
> pid=19044, tid=19159
> # gua
On Fri, 28 Feb 2025 20:40:37 GMT, Sergey Chernyshev
wrote:
>> Cgroup V1 subsustem fails to initialize mounted controllers properly in
>> certain cases, that may lead to controllers left undetected/inactive. We
>> observed the behavior in CloudFoundry deployments, it affects also host
>> syste
On Tue, 4 Mar 2025 09:57:56 GMT, Thomas Schatzl wrote:
>> Hi all,
>>
>> please review this change that implements (currently Draft) JEP: G1:
>> Improve Application Throughput with a More Efficient Write-Barrier.
>>
>> The reason for posting this early is that this is a large change, and the
On Mon, 3 Mar 2025 13:33:05 GMT, Sean Mullan wrote:
> Please review this fix to a test that fails when run with --enable-preview.
> This fix is to add all the necessary utility classes imported by the test to
> the JAR file, and not just the test classes.
The description in the JBS issue wasn'
On Tue, 4 Mar 2025 09:52:40 GMT, Thomas Schatzl wrote:
>> src/hotspot/share/gc/g1/g1ConcurrentRefine.hpp line 84:
>>
>>> 82: // Tracks the current refinement state from idle to completion (and
>>> reset back
>>> 83: // to idle).
>>> 84: class G1ConcurrentRefineWorkState {
>>
>> G1ConcurrentRef
On Mon, 3 Mar 2025 18:50:37 GMT, Ivan Walulya wrote:
>> Thomas Schatzl has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> * fix comment (trailing whitespace)
>> * another assert when snapshotting at a safepoint.
>
> src/hotspot/share/gc/g
> Hi all,
>
> please review this change that implements (currently Draft) JEP: G1:
> Improve Application Throughput with a More Efficient Write-Barrier.
>
> The reason for posting this early is that this is a large change, and the JEP
> process is already taking very long with no end in sight
On Tue, 4 Mar 2025 08:26:10 GMT, Thomas Schatzl wrote:
>> src/hotspot/share/gc/g1/g1CollectionSet.cpp line 310:
>>
>>> 308: verify_young_cset_indices();
>>> 309:
>>> 310: size_t card_rs_length =
>>> _policy->analytics()->predict_card_rs_length(in_young_only_phase);
>>
>> Why are we using
On Tue, 4 Mar 2025 08:36:58 GMT, Thomas Schatzl wrote:
>> `cards_still_refer_to_cset` refers to cards that were found to have already
>> been marked as `to-collection-set`. Renamed to
>> `_cards_already_refer_to_cset`, would that be okay?
>
> Fwiw, this particular counter is just for statistics
> Hi all,
>
> please review this change that implements (currently Draft) JEP: G1:
> Improve Application Throughput with a More Efficient Write-Barrier.
>
> The reason for posting this early is that this is a large change, and the JEP
> process is already taking very long with no end in sight
> Hi all,
>
> please review this change that implements (currently Draft) JEP: G1:
> Improve Application Throughput with a More Efficient Write-Barrier.
>
> The reason for posting this early is that this is a large change, and the JEP
> process is already taking very long with no end in sight
On Tue, 4 Mar 2025 08:22:03 GMT, Thomas Schatzl wrote:
>> src/hotspot/share/gc/g1/g1ConcurrentRefineStats.hpp line 43:
>>
>>> 41: size_t _cards_clean;// Number of cards found clean.
>>> 42: size_t _cards_not_parsable; // Number of cards we could not
>>> parse and lef
On Mon, 3 Mar 2025 15:19:20 GMT, Albert Mingkun Yang wrote:
> Can you elaborate on what the "special handling" would be, if we don's set
> "claimed" for non-committed regions?
the iteration code, would for every region check whether the region is actually
committed or not.
The `heap_region_it
On Mon, 3 Mar 2025 18:28:48 GMT, Ivan Walulya wrote:
> Why are we using a prediction here?
Quickly checking again, do we have the actual count here from somewhere?
> Additionally, won't this prediction also include cards from the old gen
> regions in case of mixed gcs? How do we reconcile that
On Mon, 3 Mar 2025 20:02:16 GMT, Ivan Walulya wrote:
>> Thomas Schatzl has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> * fix comment (trailing whitespace)
>> * another assert when snapshotting at a safepoint.
>
> src/hotspot/share/gc/g
72 matches
Mail list logo
