Method `checkMaskFromIndexSize` is called by some vector masked APIs like
`fromArray/intoArray/fromMemorySegment/...`. It is used to check whether the
index of any active lanes in a mask will reach out of the boundary of the given
Array/MemorySegment. This function should be force inlined, or a
On Wed, 26 Feb 2025 18:29:58 GMT, Galder Zamarreño wrote:
>>> > Re: [#20098
>>> > (comment)](https://github.com/openjdk/jdk/pull/20098#issuecomment-2671144644)
>>> > - I was trying to think what could be causing this.
>>>
>>> Maybe it is an issue with probabilities? Do you know at what point (
On Wed, 26 Feb 2025 12:13:59 GMT, Liam Miller-Cushon wrote:
>> Nicole Xu has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - 8349944: [JMH] sun.misc.UnsafeOps cannot access class
>> jdk.internal.misc.Unsafe
>>
>>The UnsafeOps JMH
On Fri, 21 Feb 2025 07:01:42 GMT, Nicole Xu wrote:
>> The UnsafeOps JMH benchmark fails with the following error:
>>
>> ```
>> java.lang.IllegalAccessError: class
>> org.openjdk.bench.sun.misc.UnsafeOps (in unnamed module @0x520a3426) cannot
>> access class jdk.internal.misc.Unsafe
>
> I don’t get that if I delete the existing dmg first.
>
> Full verbose output at…
>
> http://mikehall.pairserver.com/rt.txt
That output is from when I specified the path into the jdk image. It did open
this time but still not a useable runtime I don’t think.
Using the path to the parent di
> On Feb 26, 2025, at 8:54 PM, Michael Hall wrote:
>
>
>
>> On Feb 26, 2025, at 8:51 PM, Michael Hall wrote:
>>
>>
>>
>>> On Feb 26, 2025, at 8:36 PM, Alexey Semenyuk wrote:
>>>
>>> On Wed, 26 Feb 2025 23:27:46 GMT, Michael Hall wrote:
>>>
My opinion would still be that the warni
- Fixed by increasing test timeout. Fix verified on host which reproduced issue.
-
Commit messages:
- 8347139: [macos] Test tools/jpackage/share/InOutPathTest.java failed:
"execution error: Finder got an error: AppleEvent timed out."
Changes: https://git.openjdk.org/jdk/pull/23816/
> On Feb 26, 2025, at 8:51 PM, Michael Hall wrote:
>
>
>
>> On Feb 26, 2025, at 8:36 PM, Alexey Semenyuk wrote:
>>
>> On Wed, 26 Feb 2025 23:27:46 GMT, Michael Hall wrote:
>>
>>> My opinion would still be that the warning should always be used since the
>>> parameter isn?t valid in this
> On Feb 26, 2025, at 8:36 PM, Alexey Semenyuk wrote:
>
> On Wed, 26 Feb 2025 23:27:46 GMT, Michael Hall wrote:
>
>> My opinion would still be that the warning should always be used since the
>> parameter isn?t valid in this usage and not doing anything. If my
>> understanding is in fact c
On Wed, 26 Feb 2025 23:27:46 GMT, Michael Hall wrote:
> My opinion would still be that the warning should always be used since the
> parameter isn?t valid in this usage and not doing anything. If my
> understanding is in fact correct. Not a strong objection though.
Understood. We don't have co
On Wed, 26 Feb 2025 07:04:58 GMT, Nicole Xu wrote:
>> Suite `MaskedLogicOpts.maskedLogicOperationsLong512()` failed on both x86
>> and AArch64 with the following error:
>>
>>
>> java.lang.IndexOutOfBoundsException: Index 252 out of bounds for length 249
>>
>>
>> The variable `long256_arr_idx
On Mon, 17 Feb 2025 10:43:36 GMT, Emanuel Peter wrote:
>> Hi @eme64, do you see any risks here? Would you please help to review the
>> patch? Thanks.
>
> @xyyNicole @jatin-bhateja I think it is reasonable to just fix the benchmark
> so that it still has the same behaviour, just without the out-
On Wed, 26 Feb 2025 16:25:46 GMT, Vladimir Ivanov wrote:
> Yes, exceptions reported for runs with size=1024. The test support max
> size=512 and have no checks for passed params.
The change makes sense to me. Thanks for your fixing!
-
PR Comment: https://git.openjdk.org/jdk/pull/2
On Tue, 25 Feb 2025 19:06:05 GMT, Vladimir Ivanov wrote:
> Array initialization by parameter was added. Extra constant was used to align
> cycle step with used arrays.
Marked as reviewed by xgong (Committer).
-
PR Review: https://git.openjdk.org/jdk/pull/23783#pullrequestreview-26
On Mon, 24 Feb 2025 05:50:40 GMT, Jaikiran Pai wrote:
> Can I please get a review of this test-only change which proposes to address
> an intermittent failure in the
> `test/jdk/java/util/zip/ZipFile/TestCleaner.java` test?
>
> This test does operations on Inflater/Deflater/ZipFile and closes
> On Feb 26, 2025, at 3:59 PM, Alexey Semenyuk wrote:
>
> On Tue, 25 Feb 2025 16:14:22 GMT, Alexey Semenyuk
> wrote:
>
>>> - Fix the warning message about the custom installation directory location
>>> jpackage issues for DMG runtime packaging.
>>> - Don't issue the warning when the `--inst
Please review this PR which clarifies some behavior regarding NumberFormat
grouping specifically in the grouping related methods.
Please see the corresponding CSR for further detail. Note that an alternative
would be to specify this at the DecimalFormat level, allowing NumberFormat
subclasses t
On Tue, 25 Feb 2025 16:14:22 GMT, Alexey Semenyuk wrote:
>> - Fix the warning message about the custom installation directory location
>> jpackage issues for DMG runtime packaging.
>> - Don't issue the warning when the `--install-dir` value equals the default
>> installation directory location
On Tue, 25 Feb 2025 16:14:22 GMT, Alexey Semenyuk wrote:
>> - Fix the warning message about the custom installation directory location
>> jpackage issues for DMG runtime packaging.
>> - Don't issue the warning when the `--install-dir` value equals the default
>> installation directory location
On Wed, 26 Feb 2025 20:13:42 GMT, Chen Liang wrote:
>> Simplify the layout access var handles to be direct in some common cases.
>> Also made `VarHandle::isAccessModeSupported` report if an access mode is
>> supported for a VH.
>>
>> Reduces the instructions to execute this code in a simple ma
On Wed, 26 Feb 2025 20:13:42 GMT, Chen Liang wrote:
>> Simplify the layout access var handles to be direct in some common cases.
>> Also made `VarHandle::isAccessModeSupported` report if an access mode is
>> supported for a VH.
>>
>> Reduces the instructions to execute this code in a simple ma
On Wed, 26 Feb 2025 17:26:41 GMT, Jorn Vernee wrote:
>> Chen Liang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Review remarks, dates, some more simplifications
>
> src/java.base/share/classes/jdk/internal/foreign/abi/SharedUtils.java
> Simplify the layout access var handles to be direct in some common cases.
> Also made `VarHandle::isAccessModeSupported` report if an access mode is
> supported for a VH.
>
> Reduces the instructions to execute this code in a simple main by 47%:
>
> long[] arr = new long[8];
> var ms = Memory
On Wed, 26 Feb 2025 19:48:10 GMT, Justin Lu wrote:
>> Please review this PR which prevents an `AIOOBE` from leaking out when
>> `java.util.Calendar.Builder` is used to build a Japanese calendar with an
>> era value too large.
>>
>> Note that we don't check under `BEFORE_MEIJI`/0 as historicall
On Wed, 26 Feb 2025 17:23:02 GMT, Jorn Vernee wrote:
>> src/java.base/share/classes/jdk/internal/foreign/LayoutPath.java line 216:
>>
>>> 214: } else {
>>> 215: // simpler adaptation
>>> 216: handle = MethodHandles.insertCoordinates(handle, 2,
>>> offset);
On Wed, 26 Feb 2025 17:18:16 GMT, Jorn Vernee wrote:
>> Chen Liang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Review remarks, dates, some more simplifications
>
> src/java.base/share/classes/java/lang/invoke/X-VarHandleSegmentView.j
> Please review this PR which prevents an `AIOOBE` from leaking out when
> `java.util.Calendar.Builder` is used to build a Japanese calendar with an era
> value too large.
>
> Note that we don't check under `BEFORE_MEIJI`/0 as historically Japanese
> calendar ignores negative values during norm
On Wed, 26 Feb 2025 19:23:06 GMT, Naoto Sato wrote:
>> Justin Lu has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Naoto - correct comment regarding REIWA, add test case for IAE check w/
>> additional era via sys prop
>
> test/jdk/java/ut
On Wed, 26 Feb 2025 18:26:15 GMT, Justin Lu wrote:
>> Please review this PR which prevents an `AIOOBE` from leaking out when
>> `java.util.Calendar.Builder` is used to build a Japanese calendar with an
>> era value too large.
>>
>> Note that we don't check under `BEFORE_MEIJI`/0 as historicall
As long as Xalan is contained in OpenJDK, it should be updated. It makes
no sense to provide XSL 1 still, but not XSL 2 or 3.
A different question is whether that means that the source code must be
copied into OpenJDK, or if it wouldn't be enough to instead bundle the
original JAR from Apache,
On Wed, 26 Feb 2025 17:20:47 GMT, Naoto Sato wrote:
>> Justin Lu has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Naoto - correct comment regarding REIWA, add test case for IAE check w/
>> additional era via sys prop
>
> Looks good to me
On Wed, 26 Feb 2025 11:32:57 GMT, Galder Zamarreño wrote:
> > That said: if we know that it is only in the high-probability cases, then
> > we can address those separately. I would not consider it a blocking issue,
> > as long as we file the follow-up RFE for int/max scalar case with high
> >
> Please review this PR which prevents an `AIOOBE` from leaking out when
> `java.util.Calendar.Builder` is used to build a Japanese calendar with an era
> value too large.
>
> Note that we don't check under `BEFORE_MEIJI`/0 as historically Japanese
> calendar ignores negative values during norm
On Fri, 21 Feb 2025 20:14:19 GMT, Chen Liang wrote:
>> Simplify the layout access var handles to be direct in some common cases.
>> Also made `VarHandle::isAccessModeSupported` report if an access mode is
>> supported for a VH.
>>
>> Reduces the instructions to execute this code in a simple ma
On Fri, 21 Feb 2025 20:14:19 GMT, Chen Liang wrote:
>> Simplify the layout access var handles to be direct in some common cases.
>> Also made `VarHandle::isAccessModeSupported` report if an access mode is
>> supported for a VH.
>>
>> Reduces the instructions to execute this code in a simple ma
On Fri, 21 Feb 2025 20:14:19 GMT, Chen Liang wrote:
>> Simplify the layout access var handles to be direct in some common cases.
>> Also made `VarHandle::isAccessModeSupported` report if an access mode is
>> supported for a VH.
>>
>> Reduces the instructions to execute this code in a simple ma
On Wed, 26 Feb 2025 17:22:13 GMT, Jorn Vernee wrote:
>> Chen Liang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Review remarks, dates, some more simplifications
>
> src/java.base/share/classes/jdk/internal/foreign/LayoutPath.java line
On Fri, 21 Feb 2025 20:14:19 GMT, Chen Liang wrote:
>> Simplify the layout access var handles to be direct in some common cases.
>> Also made `VarHandle::isAccessModeSupported` report if an access mode is
>> supported for a VH.
>>
>> Reduces the instructions to execute this code in a simple ma
On Tue, 25 Feb 2025 23:58:21 GMT, Justin Lu wrote:
> Please review this PR which prevents an `AIOOBE` from leaking out when
> `java.util.Calendar.Builder` is used to build a Japanese calendar with an era
> value too large.
>
> Note that we don't check under `BEFORE_MEIJI`/0 as historically Jap
On Wed, 26 Feb 2025 16:41:40 GMT, Mikhail Yankelevich wrote:
>> Core reflection's generic signature parsing system is used for many aspects,
>> including annotations and enclosing methods, yet it is under-tested. It is
>> better for us to set up tests to ensure that sensitive error behaviors of
On Wed, 26 Feb 2025 16:59:39 GMT, Jorn Vernee wrote:
>> src/java.base/share/classes/java/lang/invoke/VarForm.java line 150:
>>
>>> 148: String methodName = value.methodName();
>>> 149: MethodType type =
>>> methodType_table[value.at.ordinal()].insertParameterTypes(0,
>>> VarHan
On Fri, 21 Feb 2025 10:05:36 GMT, Maurizio Cimadamore
wrote:
>> Chen Liang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Review remarks, dates, some more simplifications
>
> src/java.base/share/classes/java/lang/invoke/VarForm.java li
On Tue, 25 Feb 2025 23:50:01 GMT, Chen Liang wrote:
> Core reflection's generic signature parsing system is used for many aspects,
> including annotations and enclosing methods, yet it is under-tested. It is
> better for us to set up tests to ensure that sensitive error behaviors of
> core ref
On Thu, 19 Dec 2024 00:36:44 GMT, Brian Burkhalter wrote:
> Modify the implementation of `java.io.File` so that it correctly handles the
> empty path `""`.
This pull request has now been integrated.
Changeset: 9477c705
Author:Brian Burkhalter
URL:
https://git.openjdk.org/jdk/commit
On Tue, 25 Feb 2025 19:06:05 GMT, Vladimir Ivanov wrote:
> Array initialization by parameter was added. Extra constant was used to align
> cycle step with used arrays.
Yes, exceptions reported for runs with size=1024. The test support max size=512
and have no checks for passed params.
---
Hi Alan,
I've just seen this mail from you. Apologies for a delayed response.
My mail box has had few issues due to the volume of mails that I get
from mailing lists.
On Sun, Feb 2, 2025 at 9:38 PM Alan Bateman wrote:
> The stats for that branch suggest 5,845 changed files with 234,372 addi
While testing a bit with a minimal JVM, it has been noticed that some java/lang
jtreg tests use jfr but do not declare it with a "requires vm.hasJFR" ; that
leads to test errors in a JVM setup with no JFR .
-
Commit messages:
- JDK-8350786
Changes: https://git.openjdk.org/jdk/pull
On Wed, 26 Feb 2025 13:30:56 GMT, Viktor Klang wrote:
>> src/java.base/share/classes/java/util/concurrent/ForkJoinPool.java line 3131:
>>
>>> 3129: if ((p = (cp = common).parallelism) < 2)
>>> 3130: U.compareAndSetInt(cp, PARALLELISM, p, 2);
>>> 3131: return cp;
>>
>
On Mon, 24 Feb 2025 05:50:40 GMT, Jaikiran Pai wrote:
> Can I please get a review of this test-only change which proposes to address
> an intermittent failure in the
> `test/jdk/java/util/zip/ZipFile/TestCleaner.java` test?
>
> This test does operations on Inflater/Deflater/ZipFile and closes
On Mon, 24 Feb 2025 16:21:33 GMT, He-Pin(kerr) wrote:
>> Motivation:
>> When a user passes a wrong parameter, the current implementation throws an
>> IllegalArgumentException with an error message `null`, which is not helpful.
>>
>> Modification:
>> Add detail error messages.
>>
>> Result:
>>
On Mon, 24 Feb 2025 16:21:33 GMT, He-Pin(kerr) wrote:
>> Motivation:
>> When a user passes a wrong parameter, the current implementation throws an
>> IllegalArgumentException with an error message `null`, which is not helpful.
>>
>> Modification:
>> Add detail error messages.
>>
>> Result:
>>
On Wed, 26 Feb 2025 10:13:12 GMT, Alan Bateman wrote:
>> Doug Lea has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Standardize parameter checking
>
> src/java.base/share/classes/java/util/concurrent/ForkJoinPool.java line 3131:
>
>> 3129
On Wed, 26 Feb 2025 05:00:09 GMT, Chen Liang wrote:
>> As we advance, converting older JDK code to use the relatively new FFM API
>> requires system calls that can provide `errno` and the likes to explicitly
>> allocate a `MemorySegment` to capture potential error states. This can lead
>> to n
On Tue, 25 Feb 2025 08:27:26 GMT, Per Minborg wrote:
> As we advance, converting older JDK code to use the relatively new FFM API
> requires system calls that can provide `errno` and the likes to explicitly
> allocate a `MemorySegment` to capture potential error states. This can lead
> to nega
As we advance, converting older JDK code to use the relatively new FFM API
requires system calls that can provide `errno` and the likes to explicitly
allocate a `MemorySegment` to capture potential error states. This can lead to
negative performance implications if not designed carefully and als
On Wed, 26 Feb 2025 10:13:12 GMT, Alan Bateman wrote:
>> Doug Lea has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Standardize parameter checking
>
> src/java.base/share/classes/java/util/concurrent/ForkJoinPool.java line 3131:
>
>> 3129
On Fri, 21 Feb 2025 07:01:42 GMT, Nicole Xu wrote:
>> The UnsafeOps JMH benchmark fails with the following error:
>>
>> ```
>> java.lang.IllegalAccessError: class
>> org.openjdk.bench.sun.misc.UnsafeOps (in unnamed module @0x520a3426) cannot
>> access class jdk.internal.misc.Unsafe
On Fri, 7 Feb 2025 12:39:24 GMT, Galder Zamarreño wrote:
>> This patch intrinsifies `Math.max(long, long)` and `Math.min(long, long)` in
>> order to help improve vectorization performance.
>>
>> Currently vectorization does not kick in for loops containing either of
>> these calls because of t
On Tue, 25 Feb 2025 00:00:23 GMT, Paul Sandoz wrote:
>> Thanks for pointing that out. Typically, ARRAYLEN is almost always a POT
>> value, which is also assumed by many other benchmarks. Are we realistically
>> going to test with an ARRAYLEN of 30?
>>
>> I think the POT assumption is reasonab
On Sun, 23 Feb 2025 15:26:48 GMT, Doug Lea wrote:
>> (Copied from https://bugs.openjdk.org/browse/JDK-8319447)
>>
>> The problems addressed by this CR/PR are that ScheduledThreadPoolExecutor is
>> both ill-suited for many (if not most) of its applications, and is a
>> performance bottleneck (a
On Mon, 24 Feb 2025 08:44:00 GMT, Tagir F. Valeev wrote:
> It appears that the benchmark was erroneous. The combination of "tailMap"
> mode and comparator = true didn't work correctly, as the comparator is
> descending. This PR changes the benchmark to use headMap instead of tailMap
> in compa
61 matches
Mail list logo
