On Wed, 5 Feb 2025 17:41:22 GMT, Coleen Phillimore wrote:
>> src/java.base/share/classes/java/lang/Class.java line 239:
>>
>>> 237: * generated.
>>> 238: */
>>> 239: private Class(ClassLoader loader, Class arrayComponentType,
>>> ProtectionDomain pd) {
>>
>> If this constructor i
On Wed, 5 Feb 2025 16:14:41 GMT, Viktor Klang wrote:
> This change is likely going to need some extra verbiage in the spec for
> mapConcurrent, and thus a CSR.
> This behavior aligns mapConcurrent with how parallel streams work in
> conjunction with interruptions of the caller thread.
src/java
On Wed, 5 Feb 2025 20:23:05 GMT, Dean Long wrote:
>> Name Cnt Base Error Test Error Unit Change
>> getAppArrayModifiers 30 0.923 ± 0.004 1.260 ± 0.001 ns/op 0.73x (p
>> = 0.000*)
>> getAppArrayModifiersFinal 30 0.922 ± 0.000 1.260 ± 0.001 ns/op 0.73x (p
On Thu, 6 Feb 2025 01:32:51 GMT, David Holmes wrote:
> This reverts commit 61465883b465a184e31e7a03e2603d29ab4815a4.
>
> JDK-8348190: Framework for tracing makefile inclusion and parsing
>
> The above issue caused problems in the Oracle closed builds and so needs to
> be backed out until that
On Thu, 6 Feb 2025 01:32:51 GMT, David Holmes wrote:
> This reverts commit 61465883b465a184e31e7a03e2603d29ab4815a4.
>
> JDK-8348190: Framework for tracing makefile inclusion and parsing
>
> The above issue caused problems in the Oracle closed builds and so needs to
> be backed out until that
On Thu, 6 Feb 2025 02:48:21 GMT, Mikael Vidstedt wrote:
>> This reverts commit 61465883b465a184e31e7a03e2603d29ab4815a4.
>>
>> JDK-8348190: Framework for tracing makefile inclusion and parsing
>>
>> The above issue caused problems in the Oracle closed builds and so needs to
>> be backed out un
On Thu, 6 Feb 2025 02:01:47 GMT, Joe Darcy wrote:
>> This reverts commit 61465883b465a184e31e7a03e2603d29ab4815a4.
>>
>> JDK-8348190: Framework for tracing makefile inclusion and parsing
>>
>> The above issue caused problems in the Oracle closed builds and so needs to
>> be backed out until th
On Wed, 5 Feb 2025 23:51:09 GMT, Alexey Semenyuk wrote:
> Move junit tests to `share` subfolder.
>
> Adjust `TEST.properties` to grant full access to classes in all
> `jdk.jpackage` module packages. Otherwise, jtreg picks access config from the
> parent
> [`TEST.properties`](https://github.co
> Added a test case to JLinkOptionsTest to test that jpackage doesn't bind
> services in app's runtime by default.
>
> The test builds two app images for the same app. One with the default jlink
> options and another with `--bind-services` jlink option. The test compares
> module lists from bot
On Wed, 5 Feb 2025 23:51:09 GMT, Alexey Semenyuk wrote:
> Move junit tests to `share` subfolder.
>
> Adjust `TEST.properties` to grant full access to classes in all
> `jdk.jpackage` module packages. Otherwise, jtreg picks access config from the
> parent
> [`TEST.properties`](https://github.co
On Wed, 5 Feb 2025 21:25:56 GMT, Justin Lu wrote:
> Please review this PR which removes _sun.util.locale.ParseStatus_ which is a
> Locale helper class used for parsing language tags.
>
> Such usages should be replaced by _java.text.ParsePosition_ which has almost
> 1 to 1 behavior. Note that
On Thu, 6 Feb 2025 01:32:51 GMT, David Holmes wrote:
> This reverts commit 61465883b465a184e31e7a03e2603d29ab4815a4.
>
> JDK-8348190: Framework for tracing makefile inclusion and parsing
>
> The above issue caused problems in the Oracle closed builds and so needs to
> be backed out until that
This reverts commit 61465883b465a184e31e7a03e2603d29ab4815a4.
JDK-8348190: Framework for tracing makefile inclusion and parsing
The above issue caused problems in the Oracle closed builds and so needs to be
backed out until that is addressed.
Thanks.
-
Commit messages:
- Revert "
Move junit tests to `share` subfolder.
Adjust `TEST.properties` to grant full access to classes in all `jdk.jpackage`
module packages. Otherwise, jtreg picks access config from the parent
[`TEST.properties`](https://github.com/openjdk/jdk/blob/aad6664bb6d2b311b3e0cb056afaa9b6534bdbbb/test/jdk/to
On Wed, 5 Feb 2025 23:51:09 GMT, Alexey Semenyuk wrote:
> Move junit tests to `share` subfolder.
>
> Adjust `TEST.properties` to grant full access to classes in all
> `jdk.jpackage` module packages. Otherwise, jtreg picks access config from the
> parent
> [`TEST.properties`](https://github.co
`MethodHandles.byteArrayViewVarHandle` exposes checked multi-byte access to
byte arrays via VarHandle. This larger access speeds up many operations, yet it
cannot be used in early bootstrap, and as a result, people tend to use `Unsafe`
which can threaten memory safety of the Java Platform.
To p
On Fri, 10 Jan 2025 03:25:01 GMT, Nicole Xu wrote:
>> I am a member of Nvidia Java compiler team.
>
>> I am a member of Nvidia Java compiler team.
>
> BTW, Nvidia has signed the OCA recently. Please help to check. Thanks.
@xyyNicole I see this has been in OCA-verify mode for 2 weeks. I reached
Suite MaskedLogicOpts.maskedLogicOperationsLong512() failed on both x86 and
AArch64 with the following error:
java.lang.IndexOutOfBoundsException: Index 252 out of bounds for length 249
The variable `long256_arr_idx` is misused when indexing 'LongVector l2, l3,
l4, l5' in function `maskedLog
On Wed, 8 Jan 2025 09:04:47 GMT, Nicole Xu wrote:
> Suite MaskedLogicOpts.maskedLogicOperationsLong512() failed on both x86 and
> AArch64 with the following error:
>
>
> java.lang.IndexOutOfBoundsException: Index 252 out of bounds for length 249
>
>
> The variable `long256_arr_idx` is misuse
On Wed, 8 Jan 2025 09:08:55 GMT, Nicole Xu wrote:
> I am a member of Nvidia Java compiler team.
BTW, Nvidia has signed the OCA recently. Please help to check. Thanks.
-
PR Comment: https://git.openjdk.org/jdk/pull/22963#issuecomment-2581667116
On Wed, 8 Jan 2025 09:04:47 GMT, Nicole Xu wrote:
> Suite MaskedLogicOpts.maskedLogicOperationsLong512() failed on both x86 and
> AArch64 with the following error:
>
>
> java.lang.IndexOutOfBoundsException: Index 252 out of bounds for length 249
>
>
> The variable `long256_arr_idx` is misuse
On Wed, 5 Feb 2025 03:34:59 GMT, Alexey Semenyuk wrote:
> Run app launchers in jpackage tests with retries on Linux only. Run them
> without retries on other platforms.
>
> Supplementary remove `HelloApp.AppOutputVerifier.removePathEnvVar()`
> function. It sets an unused member field and is a
> Added a test case to JLinkOptionsTest to test that jpackage doesn't bind
> services in app's runtime by default.
>
> The test builds two app images for the same app. One with the default jlink
> options and another with `--bind-services` jlink option. The test compares
> module lists from bot
On Wed, 5 Feb 2025 17:06:57 GMT, Shaojin Wen wrote:
>> This is an optimization for decimal Integer.parseInt and Long.parseLong,
>> which improves performance by about 10%. The optimization includes:
>> 1. Improve performance by parsing 2 numbers at a time, which has performance
>> improvements
On Wed, 5 Feb 2025 22:51:45 GMT, Naoto Sato wrote:
>> Please review this PR which removes _sun.util.locale.ParseStatus_ which is
>> a Locale helper class used for parsing language tags.
>>
>> Such usages should be replaced by _java.text.ParsePosition_ which has almost
>> 1 to 1 behavior. Note
On Wed, 5 Feb 2025 21:25:56 GMT, Justin Lu wrote:
> Please review this PR which removes _sun.util.locale.ParseStatus_ which is a
> Locale helper class used for parsing language tags.
>
> Such usages should be replaced by _java.text.ParsePosition_ which has almost
> 1 to 1 behavior. Note that
On Wed, 5 Feb 2025 03:34:59 GMT, Alexey Semenyuk wrote:
> Run app launchers in jpackage tests with retries on Linux only. Run them
> without retries on other platforms.
>
> Supplementary remove `HelloApp.AppOutputVerifier.removePathEnvVar()`
> function. It sets an unused member field and is a
On Wed, 5 Feb 2025 20:09:51 GMT, Alexey Semenyuk wrote:
>> Added a test case to JLinkOptionsTest to test that jpackage doesn't bind
>> services in app's runtime by default.
>>
>> The test builds two app images for the same app. One with the default jlink
>> options and another with `--bind-ser
On Thu, 12 Dec 2024 10:16:01 GMT, Viktor Klang wrote:
>> @viktorklang-ora `@Stable` is not about how the field was set, but about the
>> JIT observing a non-default value at compile time. If it observes a
>> non-default value, it can treat it as a compile time constant.
>
> @DanHeidinga Great
On Tue, 4 Feb 2025 14:43:51 GMT, Coleen Phillimore wrote:
>> The Class.getModifiers() method is implemented as a native method in
>> java.lang.Class to access a field that we've calculated when creating the
>> mirror. The field is final after that point. The VM doesn't need it
>> anymore, so
On Tue, 4 Feb 2025 14:43:51 GMT, Coleen Phillimore wrote:
>> The Class.getModifiers() method is implemented as a native method in
>> java.lang.Class to access a field that we've calculated when creating the
>> mirror. The field is final after that point. The VM doesn't need it
>> anymore, so
On Tue, 4 Feb 2025 14:43:51 GMT, Coleen Phillimore wrote:
>> The Class.getModifiers() method is implemented as a native method in
>> java.lang.Class to access a field that we've calculated when creating the
>> mirror. The field is final after that point. The VM doesn't need it
>> anymore, so
Please review this PR which removes _sun.util.locale.ParseStatus_ which is a
Locale helper class used for parsing language tags.
Such usages should be replaced by _java.text.ParsePosition_ which has almost 1
to 1 behavior. Note that this cleanup changes the exception message in
`Locale.caseFol
On Wed, 5 Feb 2025 19:42:02 GMT, Coleen Phillimore wrote:
>> test/micro/org/openjdk/bench/java/lang/reflect/Clazz.java line 73:
>>
>>> 71: public int getAppArrayModifiers() {
>>> 72: return clazzArray.getClass().getModifiers();
>>> 73: }
>>
>> I'm guessing this is the benchmark
On Wed, 5 Feb 2025 19:44:54 GMT, Alexey Semenyuk wrote:
>> test/jdk/tools/jpackage/share/JLinkOptionsTest.java line 175:
>>
>>> 173: .setExecutable(cmd.appLauncherPath().toAbsolutePath())
>>> 174: .addArguments("--print-modules")
>>> 175: .executeA
> Added a test case to JLinkOptionsTest to test that jpackage doesn't bind
> services in app's runtime by default.
>
> The test builds two app images for the same app. One with the default jlink
> options and another with `--bind-services` jlink option. The test compares
> module lists from bot
On Wed, 5 Feb 2025 01:10:39 GMT, Dean Long wrote:
>> Coleen Phillimore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix copyright and param name
>
> test/micro/org/openjdk/bench/java/lang/reflect/Clazz.java line 73:
>
>> 71: publ
On Thu, 23 Jan 2025 15:23:37 GMT, Kevin Walls wrote:
> java.util.logging.LoggingMXBean and
> java.util.logging.LogManager::getLoggingMXBean are deprecated since
> JDK-8139982 in JDK 9.
>
> These deprecations should be uprated to state they are for future removal.
>
> java.util.logging.Logging
On Wed, 5 Feb 2025 03:34:59 GMT, Alexey Semenyuk wrote:
> Run app launchers in jpackage tests with retries on Linux only. Run them
> without retries on other platforms.
>
> Supplementary remove `HelloApp.AppOutputVerifier.removePathEnvVar()`
> function. It sets an unused member field and is a
On Wed, 5 Feb 2025 03:25:46 GMT, Alexander Matveev wrote:
>> Added a test case to JLinkOptionsTest to test that jpackage doesn't bind
>> services in app's runtime by default.
>>
>> The test builds two app images for the same app. One with the default jlink
>> options and another with `--bind-s
On Wed, 5 Feb 2025 17:57:29 GMT, Coleen Phillimore wrote:
>> This change removes the native call and injected field for ProtectionDomain
>> in the java.lang.Class instance, and moves the field to be declared in Java.
>> Tested with tier1-4.
>
> Coleen Phillimore has updated the pull request incr
On Wed, 5 Feb 2025 17:57:29 GMT, Coleen Phillimore wrote:
>> This change removes the native call and injected field for ProtectionDomain
>> in the java.lang.Class instance, and moves the field to be declared in Java.
>> Tested with tier1-4.
>
> Coleen Phillimore has updated the pull request incr
Oh good call!
I forgot to check what parallel streams do upon interruption (didn't think
they do any blocking calls, but at least the main thread must block).
On Wed, Feb 5, 2025 at 8:18 AM Viktor Klang wrote:
> Hi Jige,
>
> I opened an issue to track the concern, and I have proposed a change w
On Tue, 28 Jan 2025 19:39:45 GMT, Chen Liang wrote:
>> Shaojin Wen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> error message
>
> Ran tier 1-3 for latest commit as of comment. No failure besides a known one
> in serviceability.
@lia
> Some AccessFlag parsing methods throw IAE because a flag mask is not valid in
> a location. However, there is no easy way to check what flag mask bits or
> what flags are valid for a location. We need such APIs to check, specific to
> each class file format version.
>
> Also in the investigat
On Wed, 5 Feb 2025 10:57:14 GMT, Severin Gehwolf wrote:
> > @JoeWang-Java Have you seen https://git.openjdk.org/jdk/pull/22425?
>
> Just mentioning since it looks like a duplicate proposal.
Indeed, I missed that. The right procedure to take over an issue is to ask the
person assigned to the bu
On Thu, 28 Nov 2024 01:09:47 GMT, Zheng Feng wrote:
> …String)
>
> This bug seems from the improper handling of package and class name
> initialization in `XSLTC` since there is a default value of `_packageName`
> with `die.verwandlung`. This fix is just adjusting to call `setPackageName`
>
> This change removes the native call and injected field for ProtectionDomain
> in the java.lang.Class instance, and moves the field to be declared in Java.
> Tested with tier1-4.
Coleen Phillimore has updated the pull request incrementally with three
additional commits since the last revision:
On Wed, 5 Feb 2025 05:35:58 GMT, David Holmes wrote:
>> Coleen Phillimore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix test that knows which fields are hidden from reflection in jvmci.
>
> src/java.base/share/classes/java/lang/Cla
> This is an optimization for decimal Integer.parseInt and Long.parseLong,
> which improves performance by about 10%. The optimization includes:
> 1. Improve performance by parsing 2 numbers at a time, which has performance
> improvements for numbers with length >= 3.
> 2. It uses charAt(0) for t
On Wed, 5 Feb 2025 16:48:06 GMT, Raffaello Giulietti
wrote:
>> src/java.base/share/classes/jdk/internal/util/DecimalDigits.java line 143:
>>
>>> 141: * @return If both characters are numbers, return d0 * 10 + d1,
>>> otherwise return -1
>>> 142: */
>>> 143: @ForceInline
>>
>> Ca
> This PR proposes to add some `@ForceInline` annotations in the `Module` class
> in order to assist inlining of FFM var/method handles.
>
> Tested and passed tier1-3
Per Minborg has updated the pull request incrementally with two additional
commits since the last revision:
- Remove reformatt
> This is an optimization for decimal Integer.parseInt and Long.parseLong,
> which improves performance by about 10%. The optimization includes:
> 1. Improve performance by parsing 2 numbers at a time, which has performance
> improvements for numbers with length >= 3.
> 2. It uses charAt(0) for t
On Wed, 5 Feb 2025 12:03:36 GMT, Raffaello Giulietti
wrote:
>> Shaojin Wen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fix JdbExprTest
>
> src/java.base/share/classes/jdk/internal/util/DecimalDigits.java line 143:
>
>> 141: *
On Wed, 5 Feb 2025 16:21:47 GMT, Shaojin Wen wrote:
>> This is an optimization for decimal Integer.parseInt and Long.parseLong,
>> which improves performance by about 10%. The optimization includes:
>> 1. Improve performance by parsing 2 numbers at a time, which has performance
>> improvements
On Thu, 2 Jan 2025 17:13:17 GMT, David M. Lloyd wrote:
> When loading services by class loader
> (`ServiceLoader.load(Class,ClassLoader)`), the module layers bound to the
> given class loader are searched for services, along with the layers bound to
> class loader's parent, and so on. For non-
> This is an optimization for decimal Integer.parseInt and Long.parseLong,
> which improves performance by about 10%. The optimization includes:
> 1. Improve performance by parsing 2 numbers at a time, which has performance
> improvements for numbers with length >= 3.
> 2. It uses charAt(0) for t
This change is likely going to need some extra verbiage in the spec for
mapConcurrent, and thus a CSR.
This behavior aligns mapConcurrent with how parallel streams work in
conjunction with interruptions of the caller thread.
-
Commit messages:
- Enabling the async interruption test
On Wed, 5 Feb 2025 15:51:25 GMT, Daniel Fuchs wrote:
>> java.util.logging.LoggingMXBean and
>> java.util.logging.LogManager::getLoggingMXBean are deprecated since
>> JDK-8139982 in JDK 9.
>>
>> These deprecations should be uprated to state they are for future removal.
>>
>> java.util.logging.
Hi Jige,
I opened an issue to track the concern, and I have proposed a change which
seems to align well with how parallel streams behave under caller thread
interruption.
I've opened the following PR for review:
https://github.com/openjdk/jdk/pull/23467
If you are able to make a local OpenJDK
On Thu, 23 Jan 2025 15:23:37 GMT, Kevin Walls wrote:
> java.util.logging.LoggingMXBean and
> java.util.logging.LogManager::getLoggingMXBean are deprecated since
> JDK-8139982 in JDK 9.
>
> These deprecations should be uprated to state they are for future removal.
>
> java.util.logging.Logging
Thanks Viktor!
I understand the problem.
The main reason I asked is because I want to understand how the core Java
team thinks of throwing an unchecked exception.
As explained above, I consider losing cancellability a big deal, a deal
breaker even. And I thought throwing unchecked is more accept
On Tue, 4 Feb 2025 22:59:55 GMT, Shaojin Wen wrote:
>> Shaojin Wen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fx comments
>
> Thanks @RogerRiggs, your suggestion is great, I have fixed it, please help me
> review it again.
> > @we
> This PR proposes to add some `@ForceInline` annotations in the `Module` class
> in order to assist inlining of FFM var/method handles.
>
> Tested and passed tier1-3
Per Minborg has updated the pull request incrementally with one additional
commit since the last revision:
Rename method and
> This PR proposes to add some `@ForceInline` annotations in the `Module` class
> in order to assist inlining of FFM var/method handles.
>
> Tested and passed tier1-3
Per Minborg has updated the pull request incrementally with one additional
commit since the last revision:
Revert change
---
On Wed, 5 Feb 2025 10:20:11 GMT, Per Minborg wrote:
>> This PR proposes to add some `@ForceInline` annotations in the `Module`
>> class in order to assist inlining of FFM var/method handles.
>>
>> Tested and passed tier1-3
>
> src/java.base/share/classes/java/lang/Module.java line 488:
>
>> 48
On Wed, 5 Feb 2025 10:17:09 GMT, Per Minborg wrote:
> This PR proposes to add some `@ForceInline` annotations in the `Module` class
> in order to assist inlining of FFM var/method handles.
>
> Tested and passed tier1-3
src/java.base/share/classes/java/lang/Module.java line 344:
> 342: }
>
On Wed, 5 Feb 2025 12:58:49 GMT, Shaojin Wen wrote:
>> This is an optimization for decimal Integer.parseInt and Long.parseLong,
>> which improves performance by about 10%. The optimization includes:
>> 1. Improve performance by parsing 2 numbers at a time, which has performance
>> improvements
On Wed, 5 Feb 2025 08:59:10 GMT, SendaoYan wrote:
> Hi all,
>
> This PR add `/native` keyword in the test header for FFM tests. The `/native`
> keyword will make run the related tests by jtreg standalone more friendly.
>
> I runed all the FFM tests without `-nativepath` argument and find the f
On Tue, 4 Feb 2025 09:46:48 GMT, Per Minborg wrote:
> This PR proposes to clarify the documentation for `Arena.ofConfined()`. It is
> proposed to say that segments allocated from the returned `Arena` can _only_
> be accessed by the thread that created the `Arena` in the first place.
This pull
On Wed, 5 Feb 2025 12:17:42 GMT, Raffaello Giulietti
wrote:
>> Shaojin Wen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fix JdbExprTest
>
> src/java.base/share/classes/jdk/internal/util/DecimalDigits.java line 175:
>
>> 173:
This PR proposes to add some `@ForceInline` annotations in the `Module` class
in order to assist inlining of FFM var/method handles.
Tested and passed tier1-3
-
Commit messages:
- Add @ForceInline annotations and restructure some methods
Changes: https://git.openjdk.org/jdk/pull/2
On Wed, 5 Feb 2025 10:17:09 GMT, Per Minborg wrote:
> This PR proposes to add some `@ForceInline` annotations in the `Module` class
> in order to assist inlining of FFM var/method handles.
>
> Tested and passed tier1-3
src/java.base/share/classes/java/lang/Module.java line 281:
> 279:
> This is an optimization for decimal Integer.parseInt and Long.parseLong,
> which improves performance by about 10%. The optimization includes:
> 1. Improve performance by parsing 2 numbers at a time, which has performance
> improvements for numbers with length >= 3.
> 2. It uses charAt(0) for t
On Wed, 5 Feb 2025 00:19:31 GMT, Shaojin Wen wrote:
>> This is an optimization for decimal Integer.parseInt and Long.parseLong,
>> which improves performance by about 10%. The optimization includes:
>> 1. Improve performance by parsing 2 numbers at a time, which has performance
>> improvements
On Wed, 5 Feb 2025 10:47:27 GMT, Severin Gehwolf wrote:
> @JoeWang-Java Have you seen https://git.openjdk.org/jdk/pull/22425?
Just mentioning since it looks like a duplicate proposal.
-
PR Comment: https://git.openjdk.org/jdk/pull/23446#issuecomment-2636402802
On Tue, 4 Feb 2025 18:30:34 GMT, Joe Wang wrote:
> Fix an issue where the translet-name is incorrectly set when the package-name
> is also specified.
@JoeWang-Java Have you seen https://git.openjdk.org/jdk/pull/22425?
-
PR Comment: https://git.openjdk.org/jdk/pull/23446#issuecomme
On Sat, 25 Jan 2025 02:32:56 GMT, Quan Anh Mai wrote:
>> But the address is immediately converted to memory segment using
>> MemorySegment::ofAddress, which is what the linker does anyway?
>
> Only the return value of `CALLOC` is converted to `MemorySegment` in an
> equivalent way, I believe pa
On Tue, 4 Feb 2025 09:46:48 GMT, Per Minborg wrote:
> This PR proposes to clarify the documentation for `Arena.ofConfined()`. It is
> proposed to say that segments allocated from the returned `Arena` can _only_
> be accessed by the thread that created the `Arena` in the first place.
Marked as
On Wed, 5 Feb 2025 08:59:10 GMT, SendaoYan wrote:
> Hi all,
>
> This PR add `/native` keyword in the test header for FFM tests. The `/native`
> keyword will make run the related tests by jtreg standalone more friendly.
>
> I runed all the FFM tests without `-nativepath` argument and find the f
Hi all,
This PR add `/native` keyword in the test header for FFM tests. The `/native`
keyword will make run the related tests by jtreg standalone more friendly.
I runed all the FFM tests without `-nativepath` argument and find the fail
tests. This will find all the FFM tests which missing '/nat
81 matches
Mail list logo
