On Fri, 24 Jan 2025 10:58:24 GMT, Hannes Wallnöfer wrote:
>> Please review a doc-only change to mostly add missing `@serial` javadoc
>> tags. This is a sub-task of [JDK-8286931] to allow us to re-enable the
>> javadoc `-serialwarn` option in the JDK doc build, which has been disabled
>> since
On Thu, 30 Jan 2025 10:42:43 GMT, Nizar Benalla wrote:
> Hi all,
>
> This pull request contains a backport of commit
> [22069ff4](https://github.com/openjdk/jdk/commit/22069ff42b7e5c3058415ef9b6e0b50b9d2c16ef)
> from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
>
> The commit be
On Thu, 30 Jan 2025 10:42:43 GMT, Nizar Benalla wrote:
> Hi all,
>
> This pull request contains a backport of commit
> [22069ff4](https://github.com/openjdk/jdk/commit/22069ff42b7e5c3058415ef9b6e0b50b9d2c16ef)
> from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
>
> The commit be
> Update the specification of `java.io.File.exists()` to match its behavior,
> which seems correct in the context of how the empty abstract pathname is
> documented elsewhere in the class.
Brian Burkhalter has updated the pull request incrementally with one additional
commit since the last revi
On Thu, 30 Jan 2025 18:40:28 GMT, Brian Burkhalter wrote:
>> The change made for
>> [JDK-8003887](https://bugs.openjdk.org/browse/JDK-8003887) updated
>> `File.getCanonicalPath` to resolve symbolic links on Windows, but its
>> specification was not modified to reflect this. Here it is proposed
On Fri, 31 Jan 2025 00:19:38 GMT, Justin Lu wrote:
> New changes and CSR looks good.
Thanks for the reviews!
-
PR Comment: https://git.openjdk.org/jdk/pull/23371#issuecomment-2626013516
On Windows, for `File.getFreeSpace` return the same value as returned by
`File.getUsableSpace`.
-
Commit messages:
- 8349092: File.getFreeSpace violates specification if quotas are in effect
(win)
Changes: https://git.openjdk.org/jdk/pull/23377/files
Webrev: https://webrevs.open
> From: "Glavo"
> To: "core-libs-dev"
> Sent: Thursday, January 30, 2025 4:22:00 PM
> Subject: All classes in jdk.internal.random are not serializable
> Hi,
> My friend was migrating from Random to RandomGenerator, but he ran into a
> roadblock:
> Random is serializable, but those new implementa
Please review this PR which improves the performance of cut-over date checking
when the user supplies a properties override via the `java.util.currency.data`
sys prop. Replacing the `SimpleDateFormat` with a _java.time_ alternative has
better performance. It should be noted that this method is o
> The change made for
> [JDK-8003887](https://bugs.openjdk.org/browse/JDK-8003887) updated
> `File.getCanonicalPath` to resolve symbolic links on Windows, but its
> specification was not modified to reflect this. Here it is proposed to
> correct that omission.
Brian Burkhalter has updated the
On Thu, 16 Jan 2025 22:21:26 GMT, Justin Lu wrote:
> Please review this PR and CSR which adds a method to _java.util.Currency_
> which returns a stream of the available Currencies.
>
> The motivation can be found in the CSR.
This pull request has now been integrated.
Changeset: f05c53c2
Autho
On Wed, 29 Jan 2025 18:35:31 GMT, Justin Lu wrote:
>> Please review this PR and CSR which adds a method to _java.util.Currency_
>> which returns a stream of the available Currencies.
>>
>> The motivation can be found in the CSR.
>
> Justin Lu has updated the pull request with a new target base
On Thu, 30 Jan 2025 18:06:51 GMT, Justin Lu wrote:
> [...], but the copyright year bump looks backwards.
You're correct: that's lame. I didn't search far enough for `4,`. Thanks, will
fix.
-
PR Comment: https://git.openjdk.org/jdk/pull/23371#issuecomment-2625227664
On Thu, 30 Jan 2025 15:58:37 GMT, Brian Burkhalter wrote:
>> The change made for
>> [JDK-8003887](https://bugs.openjdk.org/browse/JDK-8003887) updated
>> `File.getCanonicalPath` to resolve symbolic links on Windows, but its
>> specification was not modified to reflect this. Here it is proposed
On Thu, 30 Jan 2025 16:54:16 GMT, Alan Bateman wrote:
>> @kimbarrett Do you have a change coming to allow waitForPendingReferences be
>> used by WB? I assume this will at least add a comment to the method (or
>> whatever it changes to) to make it clear that it's for testing.
>
>> @AlanBateman I
On Thu, 30 Jan 2025 08:36:34 GMT, Alan Bateman wrote:
>> src/java.base/share/classes/java/nio/Bits.java line 146:
>>
>>> 144: }
>>> 145:
>>> 146: if (canary == null || canary.isDead()) {
>>
>> If we're keeping Reference.waitForPendingReferences, why not continue
On Thu, 30 Jan 2025 08:36:34 GMT, Alan Bateman wrote:
>> src/java.base/share/classes/java/nio/Bits.java line 146:
>>
>>> 144: }
>>> 145:
>>> 146: if (canary == null || canary.isDead()) {
>>
>> If we're keeping Reference.waitForPendingReferences, why not continue
On Thu, 14 Nov 2024 05:32:34 GMT, Shaojin Wen wrote:
> The type of the Unsafe base offset constant is int, which may cause overflow
> when adding int offsets, such as 8343925 (PR #22012). 8343984 (PR #22027)
> fixes most of the offset overflows in JDK, but ArraysSupport and CRC32C are
> still
> The change made for
> [JDK-8003887](https://bugs.openjdk.org/browse/JDK-8003887) updated
> `File.getCanonicalPath` to resolve symbolic links on Windows, but its
> specification was not modified to reflect this. Here it is proposed to
> correct that omission.
Brian Burkhalter has updated the
The change made for [JDK-8003887](https://bugs.openjdk.org/browse/JDK-8003887)
updated `File.getCanonicalPath` to resolve symbolic links on Windows, but its
specification was not modified to reflect this. Here it is proposed to correct
that omission.
-
Commit messages:
- 8349006:
Hi,
My friend was migrating from Random to RandomGenerator, but he ran into a
roadblock:
Random is serializable, but those new implementations of
RandomGenerator are not serializable.
Was this an oversight or an evaluated decision?
Is it possible to make them serializable?
Glavo
See the JBS issue.
Mark the implementation of `MemorySegment::reinterpret` with `@ForceInline` so
that we prevent `Reflection.getCallerClass` from falling back to a slow stack
walk.
This is a leftover from an earlier performance investigation, in which we
observed `reinterpret` not being inlin
On Thu, 30 Jan 2025 00:37:16 GMT, Shaojin Wen wrote:
>> The type of the Unsafe base offset constant is int, which may cause overflow
>> when adding int offsets, such as 8343925 (PR #22012). 8343984 (PR #22027)
>> fixes most of the offset overflows in JDK, but ArraysSupport and CRC32C are
>> st
On Tue, 28 Jan 2025 16:11:53 GMT, Shaojin Wen wrote:
> ZoneOffset.MINUTES_15_CACHE uses AtomicReferenceArray to replace
> ConcurrentMap to avoid object allocation caused by boxing from int to Integer
> during access.
This pull request has now been integrated.
Changeset: 3f8a8754
Author:Sh
On Wed, 29 Jan 2025 16:15:51 GMT, Jorn Vernee wrote:
> See the JBS issue.
>
> Mark the implementation of `MemorySegment::reinterpret` with `@ForceInline`
> so that we prevent `Reflection.getCallerClass` from falling back to a slow
> stack walk.
>
> This is a leftover from an earlier performan
> By removing the redundant code logic in
> DateTimeFormatterBuilder$InstantPrinterParser#formatTo, the codeSize can be
> reduced and the performance can be improved.
Shaojin Wen has updated the pull request incrementally with one additional
commit since the last revision:
do not import stat
On Thu, 30 Jan 2025 10:42:43 GMT, Nizar Benalla wrote:
> Hi all,
>
> This pull request contains a backport of commit
> [22069ff4](https://github.com/openjdk/jdk/commit/22069ff42b7e5c3058415ef9b6e0b50b9d2c16ef)
> from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
>
> The commit be
On Thu, 30 Jan 2025 14:20:36 GMT, Shaojin Wen wrote:
>> By removing the redundant code logic in
>> DateTimeFormatterBuilder$InstantPrinterParser#formatTo, the codeSize can be
>> reduced and the performance can be improved.
>
> Shaojin Wen has updated the pull request incrementally with one addi
On Mon, 27 Jan 2025 22:06:58 GMT, Jorn Vernee wrote:
> Currently, to free the memory allocated in a confined arena, we keep track of
> a list of 'cleanup actions', stored in linked list format in a so-called
> `ResourceList`, attached to the scope of the arena. When the scope is closed,
> we l
On Thu, 30 Jan 2025 14:22:04 GMT, Johannes Graham wrote:
>> Shaojin Wen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> remove unused import
>
> src/java.base/share/classes/jdk/internal/util/DateTimeHelper.java line 26:
>
>> 24: * ques
On Thu, 30 Jan 2025 14:20:36 GMT, Shaojin Wen wrote:
>> By removing the redundant code logic in
>> DateTimeFormatterBuilder$InstantPrinterParser#formatTo, the codeSize can be
>> reduced and the performance can be improved.
>
> Shaojin Wen has updated the pull request incrementally with one addi
> Can I please get a review of this change, which simplifies the interaction
> between the `java` launcher's native code with the
> `sun.launcher.LauncherHelper`?
>
> As noted in https://bugs.openjdk.org/browse/JDK-8341184, this proposed change
> reduces the back and forth between the launcher
> By removing the redundant code logic in
> DateTimeFormatterBuilder$InstantPrinterParser#formatTo, the codeSize can be
> reduced and the performance can be improved.
Shaojin Wen has updated the pull request incrementally with one additional
commit since the last revision:
remove unused impo
> By removing the redundant code logic in
> DateTimeFormatterBuilder$InstantPrinterParser#formatTo, the codeSize can be
> reduced and the performance can be improved.
Shaojin Wen has updated the pull request incrementally with one additional
commit since the last revision:
copyright
---
> By removing the redundant code logic in
> DateTimeFormatterBuilder$InstantPrinterParser#formatTo, the codeSize can be
> reduced and the performance can be improved.
Shaojin Wen has updated the pull request with a new target base due to a merge
or a rebase. The incremental webrev excludes the
On Wed, 29 Jan 2025 06:23:25 GMT, Jatin Bhateja wrote:
>> Some more minor comments below. Rest of the PR looks good to me.
>
> Hi @sviswa7 , your comments have been addressed.
@jatin-bhateja Launched testing again 🚀
-
PR Comment: https://git.openjdk.org/jdk/pull/22754#issuecomment-
On Wed, 29 Jan 2025 06:26:41 GMT, Jatin Bhateja wrote:
>> Hi All,
>>
>> This patch adds C2 compiler support for various Float16 operations added by
>> [PR#22128](https://github.com/openjdk/jdk/pull/22128)
>>
>> Following is the summary of changes included with this patch:-
>>
>> 1. Detection
> Hi All,
>
> This patch adds C2 compiler support for various Float16 operations added by
> [PR#22128](https://github.com/openjdk/jdk/pull/22128)
>
> Following is the summary of changes included with this patch:-
>
> 1. Detection of various Float16 operations through inline expansion or
> patt
Hi all,
This pull request contains a backport of commit
[22069ff4](https://github.com/openjdk/jdk/commit/22069ff42b7e5c3058415ef9b6e0b50b9d2c16ef)
from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
The commit being backported was authored by Nizar Benalla on 30 Jan 2025 and
was re
On Wed, 29 Jan 2025 06:23:25 GMT, Jatin Bhateja wrote:
>> Some more minor comments below. Rest of the PR looks good to me.
>
> Hi @sviswa7 , your comments have been addressed.
The updates look good, thanks @jatin-bhateja !
Running one more round of testing to verify copyright etc.
On Wed, 29 Jan 2025 16:03:38 GMT, Nizar Benalla wrote:
> Two groups of broken links appeared in the latest JDK docs, broken links to
> man pages and broken ietf links.
>
> - The windows tools markdown files were not being converted to HTML because
> they were placed under `windows/man` rather
On Wed, 29 Jan 2025 16:03:38 GMT, Nizar Benalla wrote:
> Two groups of broken links appeared in the latest JDK docs, broken links to
> man pages and broken ietf links.
>
> - The windows tools markdown files were not being converted to HTML because
> they were placed under `windows/man` rather
> Continue to complete PR #16006 and PR #21593 to improve BigDecimal::toString
> and BigDecimal::toPlainString performance and reduce duplicate code
Shaojin Wen has updated the pull request incrementally with one additional
commit since the last revision:
remove getChars(long, int, char[])
-
On Mon, 20 Jan 2025 07:56:49 GMT, Axel Boldt-Christmas
wrote:
> The proposed change here is the following:
> 1. Move the `vmdependencies` list head from the `Context` to the `CallSite`
> object
> 2. Remove the Context object and its corresponding cleaner
>
> (1.) fixes the crash. (2.) is bec
On Wed, 29 Jan 2025 23:52:40 GMT, Kim Barrett wrote:
>> Aleksey Shipilev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Revert waitForReferenceProcessing removals, see JDK-8305186
>
> src/java.base/share/classes/java/nio/Bits.java line
On Sun, 26 Jan 2025 07:30:22 GMT, Alan Bateman wrote:
>>> Testing is still clean on my side. I would appreciate if folks can run this
>>> through their CIs.
>>>
>>> I am planning to integrate this on Monday, as long as we discover no new
>>> issues.
>>
>> Did the change to
>> `test/jdk/sun/s
On Wed, 29 Jan 2025 19:56:00 GMT, Aleksey Shipilev wrote:
>> DirectByteBuffers are still using old `jdk.internal.ref.Cleaner`
>> implementation. That implementation carries a doubly-linked list, and so
>> makes DBB suffer from the same issue fixed for generic
>> `java.lang.ref.Cleaner` users w
On Mon, 20 Jan 2025 07:56:49 GMT, Axel Boldt-Christmas
wrote:
> The proposed change here is the following:
> 1. Move the `vmdependencies` list head from the `Context` to the `CallSite`
> object
> 2. Remove the Context object and its corresponding cleaner
>
> (1.) fixes the crash. (2.) is bec
48 matches
Mail list logo
