> ZoneOffset.MINUTES_15_CACHE uses AtomicReferenceArray to replace
> ConcurrentMap to avoid object allocation caused by boxing from int to Integer
> during access.
Shaojin Wen has updated the pull request incrementally with one additional
commit since the last revision:
rename to test_quarte
> ZoneOffset.MINUTES_15_CACHE uses AtomicReferenceArray to replace
> ConcurrentMap to avoid object allocation caused by boxing from int to Integer
> during access.
Shaojin Wen has updated the pull request incrementally with one additional
commit since the last revision:
simplify test
--
On Wed, 29 Jan 2025 00:36:54 GMT, Sandhya Viswanathan
wrote:
>> Jatin Bhateja has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Updating typos in comments
>
> Some more minor comments below. Rest of the PR looks good to me.
Hi @sviswa7 ,
> Hi All,
>
> This patch adds C2 compiler support for various Float16 operations added by
> [PR#22128](https://github.com/openjdk/jdk/pull/22128)
>
> Following is the summary of changes included with this patch:-
>
> 1. Detection of various Float16 operations through inline expansion or
> patt
On Tue, 28 Jan 2025 23:53:01 GMT, Naoto Sato wrote:
>> Shaojin Wen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> from @liach
>
> The change looks good to me. Maybe you could write a test case for all the
> quarters that indeed return
> ZoneOffset.MINUTES_15_CACHE uses AtomicReferenceArray to replace
> ConcurrentMap to avoid object allocation caused by boxing from int to Integer
> during access.
Shaojin Wen has updated the pull request incrementally with one additional
commit since the last revision:
add test for quarter
On Tue, 28 Jan 2025 01:24:43 GMT, Shaojin Wen wrote:
>> This is an optimization for decimal Integer.parseInt and Long.parseLong,
>> which improves performance by about 10%. The optimization includes:
>> 1. Improve performance by parsing 2 numbers at a time, which has performance
>> improvements
On Tue, 28 Jan 2025 06:26:11 GMT, Jatin Bhateja wrote:
>> Hi All,
>>
>> This patch adds C2 compiler support for various Float16 operations added by
>> [PR#22128](https://github.com/openjdk/jdk/pull/22128)
>>
>> Following is the summary of changes included with this patch:-
>>
>> 1. Detection
On Tue, 28 Jan 2025 17:06:24 GMT, Shaojin Wen wrote:
>> ZoneOffset.MINUTES_15_CACHE uses AtomicReferenceArray to replace
>> ConcurrentMap to avoid object allocation caused by boxing from int to
>> Integer during access.
>
> Shaojin Wen has updated the pull request incrementally with one additio
On Tue, 28 Jan 2025 17:06:24 GMT, Shaojin Wen wrote:
>> ZoneOffset.MINUTES_15_CACHE uses AtomicReferenceArray to replace
>> ConcurrentMap to avoid object allocation caused by boxing from int to
>> Integer during access.
>
> Shaojin Wen has updated the pull request incrementally with one additio
On Tue, 28 Jan 2025 22:42:00 GMT, Alexey Semenyuk wrote:
> Reapply [JDK-8348348](https://bugs.openjdk.org/browse/JDK-8348348)
This pull request has now been integrated.
Changeset: 5e81fa6a
Author:Alexey Semenyuk
URL:
https://git.openjdk.org/jdk/commit/5e81fa6a1f53e3efb93f32ee44eff20
On Tue, 28 Jan 2025 22:56:51 GMT, Jiangli Zhou wrote:
> Is the actual change addressing the compilation issue in closed repo?
Yes.
> If so, is it to properly add -Zc:preprocessor?
No. The fix was to add missing `DEF_STATIC_JNI_OnLoad` define.
-
PR Comment: https://git.openjdk.org
On Tue, 28 Jan 2025 22:42:00 GMT, Alexey Semenyuk wrote:
> Reapply [JDK-8348348](https://bugs.openjdk.org/browse/JDK-8348348)
Marked as reviewed by jiangli (Reviewer).
Looks good.
@alexeysemenyukoracle, Is the actual change addressing the compilation issue in
closed repo? If so, is it to prop
On Tue, 28 Jan 2025 22:42:00 GMT, Alexey Semenyuk wrote:
> Reapply [JDK-8348348](https://bugs.openjdk.org/browse/JDK-8348348)
@jianglizhou, @jerboaa, @kevinrushforth please review. This PR will be
integrated after integrating a patch to the closed Oracle JDK build so it will
not result in the
On Tue, 28 Jan 2025 22:42:00 GMT, Alexey Semenyuk wrote:
> Reapply [JDK-8348348](https://bugs.openjdk.org/browse/JDK-8348348)
This looks good. I confirm that this is the correct backout patch
for[JDK-834](https://bugs.openjdk.org/browse/JDK-834), thus resotring
the fix for[JDK-8348348]
Reapply [JDK-8348348](https://bugs.openjdk.org/browse/JDK-8348348)
-
Commit messages:
- JDK-8348892: Properly fix compilation error for zip_util.c on Windows
Changes: https://git.openjdk.org/jdk/pull/23344/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=23344&range=00
Iss
On Tue, 28 Jan 2025 17:17:07 GMT, Shaojin Wen wrote:
> This PR removes OctalDigits as it is no longer used after the removal of
> StringTemplate.
Removal of burdens is always good.
-
Marked as reviewed by liach (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/23338#pullreq
This PR removes OctalDigits as it is no longer used after the removal of
StringTemplate.
-
Commit messages:
- remove OctalDigits
Changes: https://git.openjdk.org/jdk/pull/23338/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=23338&range=00
Issue: https://bugs.openjdk.org
On Thu, 23 Jan 2025 02:50:46 GMT, Justin Lu wrote:
>> Please review this PR and CSR which adds a method to _java.util.Currency_
>> which returns a stream of the available Currencies.
>>
>> The motivation can be found in the CSR.
>
> Justin Lu has updated the pull request with a new target base
On Thu, 23 Jan 2025 02:49:49 GMT, Justin Lu wrote:
> Please review this PR and CSR which add a pair of methods to
> _java.util.TimeZone_ that return a stream of the available IDs. See the CSR
> for the motivation.
>
> A number of existing tests are modified to use the new methods. See
> _test
On Fri, 24 Jan 2025 18:00:06 GMT, Justin Lu wrote:
>> Please review this PR and CSR which add a pair of methods to
>> _java.util.TimeZone_ that return a stream of the available IDs. See the CSR
>> for the motivation.
>>
>> A number of existing tests are modified to use the new methods. See
>>
On Mon, 20 Jan 2025 07:56:49 GMT, Axel Boldt-Christmas
wrote:
> The proposed change here is the following:
> 1. Move the `vmdependencies` list head from the `Context` to the `CallSite`
> object
> 2. Remove the Context object and its corresponding cleaner
>
> (1.) fixes the crash. (2.) is bec
On Tue, 28 Jan 2025 14:49:45 GMT, Shaojin Wen wrote:
> Expand DIGITS length to 128 and eliminate array bounds checking by using &
> 0x7F when accessing DIGITS
Marked as reviewed by rgiulietti (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/23335#pullrequestreview-2579409
On Tue, 28 Jan 2025 20:07:17 GMT, Kevin Rushforth wrote:
> A Mach5 job I submitted passed
@kevinrushforth Thanks!
-
PR Comment: https://git.openjdk.org/jdk/pull/23340#issuecomment-2619970106
On Tue, 28 Jan 2025 19:22:52 GMT, Jiangli Zhou wrote:
> Please review this workaround for the compiler error on Windows. This error
> occurs in closed build with custom make logic that uses zip_util.c. The error
> indicates `DEF_STATIC_JNI_OnLoad` is not defined, thus disable the macro on
> Wi
On Tue, 28 Jan 2025 19:22:52 GMT, Jiangli Zhou wrote:
> Please review this workaround for the compiler error on Windows. This error
> occurs in closed build with custom make logic that uses zip_util.c. The error
> indicates `DEF_STATIC_JNI_OnLoad` is not defined, thus disable the macro on
> Wi
On Thu, 19 Dec 2024 00:36:44 GMT, Brian Burkhalter wrote:
> Update the specification of `java.io.File.exists()` to match its behavior,
> which seems correct in the context of how the empty abstract pathname is
> documented elsewhere in the class.
Commit 9d6d910 removes the change of specificat
> Update the specification of `java.io.File.exists()` to match its behavior,
> which seems correct in the context of how the empty abstract pathname is
> documented elsewhere in the class.
Brian Burkhalter has updated the pull request incrementally with one additional
commit since the last revi
On Tue, 28 Jan 2025 20:08:54 GMT, Alexey Semenyuk wrote:
> I believe it complained about the way DEF_STATIC_JNI_OnLoad is defined. That
> is why disabling the usage of DEF_STATIC_JNI_OnLoad fixes the problem.
That probably describes the issue more clear. Thumbs up.
-
PR Comment: h
On Tue, 28 Jan 2025 19:22:52 GMT, Jiangli Zhou wrote:
> Please review this workaround for the compiler error on Windows. This error
> occurs in closed build with custom make logic that uses zip_util.c. The error
> indicates `DEF_STATIC_JNI_OnLoad` is not defined, thus disable the macro on
> Wi
On Fri, 24 Jan 2025 10:58:24 GMT, Hannes Wallnöfer wrote:
>> Please review a doc-only change to mostly add missing `@serial` javadoc
>> tags. This is a sub-task of [JDK-8286931] to allow us to re-enable the
>> javadoc `-serialwarn` option in the JDK doc build, which has been disabled
>> since
On Tue, 28 Jan 2025 19:54:21 GMT, Alexey Semenyuk wrote:
> > zip_util.c(94): error C2054: expected '(' to follow 'DEF_STATIC_JNI_OnLoad'
>
> It doesn't look like it complains about undefined DEF_STATIC_JNI_OnLoad
The compilation error I saw did.
A Mach5 job I submitted passed in one case where
On Tue, 28 Jan 2025 19:22:52 GMT, Jiangli Zhou wrote:
> Please review this workaround for the compiler error on Windows. This error
> occurs in closed build with custom make logic that uses zip_util.c. The error
> indicates `DEF_STATIC_JNI_OnLoad` is not defined, thus disable the macro on
> Wi
On Tue, 28 Jan 2025 19:22:52 GMT, Jiangli Zhou wrote:
> zip_util.c(94): error C2054: expected '(' to follow 'DEF_STATIC_JNI_OnLoad'
It doesn't look like it complains about undefined DEF_STATIC_JNI_OnLoad
-
PR Comment: https://git.openjdk.org/jdk/pull/23340#issuecomment-2619931580
On Tue, 28 Jan 2025 19:22:52 GMT, Jiangli Zhou wrote:
> Please review this workaround for the compiler error on Windows. This error
> occurs in closed build with custom make logic that uses zip_util.c. The error
> indicates `DEF_STATIC_JNI_OnLoad` is not defined, thus disable the macro on
> Wi
On Tue, 28 Jan 2025 01:24:43 GMT, Shaojin Wen wrote:
>> This is an optimization for decimal Integer.parseInt and Long.parseLong,
>> which improves performance by about 10%. The optimization includes:
>> 1. Improve performance by parsing 2 numbers at a time, which has performance
>> improvements
On Tue, 28 Jan 2025 14:49:45 GMT, Shaojin Wen wrote:
> Expand DIGITS length to 128 and eliminate array bounds checking by using &
> 0x7F when accessing DIGITS
Ran tests tier 1-3, no failure besides a known serviceability one.
-
PR Comment: https://git.openjdk.org/jdk/pull/23335#is
On Tue, 28 Jan 2025 19:22:52 GMT, Jiangli Zhou wrote:
> Please review this workaround for the compiler error on Windows. This error
> occurs in closed build with custom make logic that uses zip_util.c. The error
> indicates `DEF_STATIC_JNI_OnLoad` is not defined, thus disable the macro on
> Wi
On Tue, 28 Jan 2025 19:22:52 GMT, Jiangli Zhou wrote:
> Please review this workaround for the compiler error on Windows. This error
> occurs in closed build with custom make logic that uses zip_util.c. The error
> indicates `DEF_STATIC_JNI_OnLoad` is not defined, thus disable the macro on
> Wi
Please review this workaround for the compiler error on Windows. This error
occurs in closed build with custom make logic that uses zip_util.c. The error
indicates `DEF_STATIC_JNI_OnLoad` is not defined, thus disable the macro on
Windows for now until the cause is fully understood.
[2025-01-28
On Fri, 24 Jan 2025 23:56:46 GMT, Justin Lu wrote:
> Please review this PR which improves the time measurement for cut-over time
> comparisons when building the available set of currencies in
> _java.util.Currency._ Currently, a new time was measured for each special
> case currency. This PR u
On Mon, 27 Jan 2025 18:30:39 GMT, Justin Lu wrote:
>> Please review this PR which improves the time measurement for cut-over time
>> comparisons when building the available set of currencies in
>> _java.util.Currency._ Currently, a new time was measured for each special
>> case currency. This
> ZoneOffset.MINUTES_15_CACHE uses AtomicReferenceArray to replace
> ConcurrentMap to avoid object allocation caused by boxing from int to Integer
> during access.
Shaojin Wen has updated the pull request incrementally with one additional
commit since the last revision:
Update src/java.base/
On Thu, 23 Jan 2025 02:50:46 GMT, Justin Lu wrote:
>> Please review this PR and CSR which adds a method to _java.util.Currency_
>> which returns a stream of the available Currencies.
>>
>> The motivation can be found in the CSR.
>
> Justin Lu has updated the pull request with a new target base
> ZoneOffset.MINUTES_15_CACHE uses AtomicReferenceArray to replace
> ConcurrentMap to avoid object allocation caused by boxing from int to Integer
> during access.
Shaojin Wen has updated the pull request incrementally with one additional
commit since the last revision:
from @liach
On Thu, 23 Jan 2025 02:11:29 GMT, Jiangli Zhou wrote:
> Please review this trivial cleanup that removes the #ifdef STATIC_BUILD
> around DEF_STATIC_JNI_OnLoad from zip_util.c. Thanks.
Looks good. `DEF_STATIC_JNI_OnLoad` will do the right thing based on the
`STATIC_BUILD` define here:
https://g
> ZoneOffset.MINUTES_15_CACHE uses AtomicReferenceArray to replace
> ConcurrentMap to avoid object allocation caused by boxing from int to Integer
> during access.
Shaojin Wen has updated the pull request incrementally with one additional
commit since the last revision:
from @liach
On Tue, 28 Jan 2025 16:44:17 GMT, Shaojin Wen wrote:
>> ZoneOffset.MINUTES_15_CACHE uses AtomicReferenceArray to replace
>> ConcurrentMap to avoid object allocation caused by boxing from int to
>> Integer during access.
>
> Shaojin Wen has updated the pull request incrementally with two additio
On Tue, 28 Jan 2025 16:11:53 GMT, Shaojin Wen wrote:
> ZoneOffset.MINUTES_15_CACHE uses AtomicReferenceArray to replace
> ConcurrentMap to avoid object allocation caused by boxing from int to Integer
> during access.
src/java.base/share/classes/java/time/ZoneOffset.java line 139:
> 137:
> 13
On Thu, 23 Jan 2025 02:11:29 GMT, Jiangli Zhou wrote:
> Please review this trivial cleanup that removes the #ifdef STATIC_BUILD
> around DEF_STATIC_JNI_OnLoad from zip_util.c. Thanks.
This pull request has now been integrated.
Changeset: 81032560
Author:Jiangli Zhou
URL:
https://gi
> ZoneOffset.MINUTES_15_CACHE uses AtomicReferenceArray to replace
> ConcurrentMap to avoid object allocation caused by boxing from int to Integer
> during access.
Shaojin Wen has updated the pull request incrementally with two additional
commits since the last revision:
- simplify
- MINUTES
On Tue, 28 Jan 2025 16:24:57 GMT, Severin Gehwolf wrote:
>> Please review this trivial cleanup that removes the #ifdef STATIC_BUILD
>> around DEF_STATIC_JNI_OnLoad from zip_util.c. Thanks.
>
> Looks good. `DEF_STATIC_JNI_OnLoad` will do the right thing based on the
> `STATIC_BUILD` define here:
ZoneOffset.MINUTES_15_CACHE uses AtomicReferenceArray to replace ConcurrentMap
to avoid object allocation caused by boxing from int to Integer during access.
-
Commit messages:
- Update src/java.base/share/classes/java/time/ZoneOffset.java
- MINUTES_15_CACHE use AtomicReferenceArra
On Thu, 23 Jan 2025 02:50:46 GMT, Justin Lu wrote:
>> Please review this PR and CSR which adds a method to _java.util.Currency_
>> which returns a stream of the available Currencies.
>>
>> The motivation can be found in the CSR.
>
> Justin Lu has updated the pull request with a new target base
On Tue, 28 Jan 2025 14:49:45 GMT, Shaojin Wen wrote:
> Expand DIGITS length to 128 and eliminate array bounds checking by using &
> 0x7F when accessing DIGITS
Simple optimization, unfortunately this is a nice feature of the JVM not
properly exposed in the language or libraries.
-
On Tue, 28 Jan 2025 14:49:45 GMT, Shaojin Wen wrote:
> Expand DIGITS length to 128 and eliminate array bounds checking by using &
> 0x7F when accessing DIGITS
Can we rename this to have a more descriptive title, like "Eliminate array
bound checks in DecimalDigits"?
-
PR Comment:
On Thu, 23 Jan 2025 17:36:11 GMT, Matthias Ernst wrote:
>> Certain signatures for foreign function calls (e.g. HVA return by value)
>> require allocation of an intermediate buffer to adapt the FFM's to the
>> native stub's calling convention. In the current implementation, this buffer
>> is ma
Expand DIGITS length to 128 and eliminate array bounds checking by using & 0x7F
when accessing DIGITS
-
Commit messages:
- & 0x7f
Changes: https://git.openjdk.org/jdk/pull/23335/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=23335&range=00
Issue: https://bugs.openjdk.or
On Tue, 28 Jan 2025 14:49:45 GMT, Shaojin Wen wrote:
> Expand DIGITS length to 128 and eliminate array bounds checking by using &
> 0x7F when accessing DIGITS
This minor change achieves a ~3-5% performance improvement on MacBook M1 Pro.
## 1. Script
git remote add wenshao g...@github.com:wen
On Mon, 27 Jan 2025 22:03:41 GMT, Alexey Semenyuk wrote:
> Rework pointer arithmetic to avoid null pointer
This pull request has now been integrated.
Changeset: fb066cae
Author:Alexey Semenyuk
URL:
https://git.openjdk.org/jdk/commit/fb066caea8a6bbf5b7a6fbe1ca51282e2c7c1ff2
Stats:
On Mon, 27 Jan 2025 06:03:17 GMT, Shaojin Wen wrote:
>> src/java.base/share/classes/java/math/BigDecimal.java line 3538:
>>
>>> 3536: return (signum < 0 ? "-0." : "0.").concat(intString);
>>> 3537: } else if (insertionPoint > 0) { /* Point goes inside intVal
>>> */
>>> 3538:
On Sun, 26 Jan 2025 19:31:08 GMT, Johannes Graham wrote:
>> Continue to complete PR #16006 and PR #21593 to improve BigDecimal::toString
>> and BigDecimal::toPlainString performance and reduce duplicate code
>
> src/java.base/share/classes/java/math/BigDecimal.java line 3538:
>
>> 3536:
On Sat, 25 Jan 2025 07:25:40 GMT, Shaojin Wen wrote:
> Continue to complete PR #16006 and PR #21593 to improve BigDecimal::toString
> and BigDecimal::toPlainString performance and reduce duplicate code
src/java.base/share/classes/java/math/BigDecimal.java line 3538:
> 3536: return
On Sat, 25 Jan 2025 07:25:40 GMT, Shaojin Wen wrote:
> Continue to complete PR #16006 and PR #21593 to improve BigDecimal::toString
> and BigDecimal::toPlainString performance and reduce duplicate code
The performance numbers as follows. In the smallScale2EngineeringToString and
smallScale2Lay
On Sat, 25 Jan 2025 07:25:40 GMT, Shaojin Wen wrote:
> Continue to complete PR #16006 and PR #21593 to improve BigDecimal::toString
> and BigDecimal::toPlainString performance and reduce duplicate code
A great cleanup that consolidates scale2, unscaledAbsString, and unscaledString.
---
Continue to complete PR #16006 and PR #21593 to improve BigDecimal::toString
and BigDecimal::toPlainString performance and reduce duplicate code
-
Commit messages:
- simplify and comments
- simplify
- simplify
- code style
- revert change
- bug fix
- bug fix
- refactor
- Rev
66 matches
Mail list logo
