Re: RFR: 8344332: (bf) Migrate DirectByteBuffer to use java.lang.ref.Cleaner [v9]

2025-01-25 Thread Alan Bateman
On Fri, 24 Jan 2025 22:01:59 GMT, Brent Christian wrote: > Testing is still clean on my side. I would appreciate if folks can run this > through their CIs. > > I am planning to integrate this on Monday, as long as we discover no new > issues. I ran it through our CI and we seem to have a few

Re: RFR: 8343191: Cgroup v1 subsystem fails to set subsystem path [v8]

2025-01-25 Thread Jonas
On Tue, 3 Dec 2024 10:06:39 GMT, Sergey Chernyshev wrote: >> Sergey Chernyshev has updated the pull request incrementally with three >> additional commits since the last revision: >> >> - update cgroup v1 in metrics >> - Apply suggestions from code review >> >>Co-authored-by: Severin

Re: RFR: 8344168: Change Unsafe base offset from int to long [v5]

2025-01-25 Thread Shaojin Wen
> The type of the Unsafe base offset constant is int, which may cause overflow > when adding int offsets, such as 8343925 (PR #22012). 8343984 (PR #22027) > fixes most of the offset overflows in JDK, but ArraysSupport and CRC32C are > still unfixed. > > @liach proposed the idea of ​​changing th

Re: RFR: 4452735: Add GZIPOutputStream constructor to specify Deflater [v3]

2025-01-25 Thread Archie Cobbs
On Fri, 24 Jan 2025 20:57:15 GMT, Eirik Bjørsnøs wrote: > A tangential concern when allowing a custom deflater / inflater is to > document the resposibility for resource management. I've added a Javadoc blurb to that effect in 3807de16b70. Something similar (once the verbiage is agreed upon) s

Re: RFR: 4452735: Add GZIPOutputStream constructor to specify Deflater [v4]

2025-01-25 Thread Archie Cobbs
> The class `GZIPOutputStream` extends `DeflaterOutputStream`, which is logical > because the GZIP encoding is based on ZLIB "deflate" encoding. > > However, while `DeflaterOutputStream` provides constructors that take a > custom `Deflater` argument supplied by the caller, `GZIPOutputStream` has

Re: Factory methods for SequencedSet and SequencedMap

2025-01-25 Thread forax
> From: "Rafael Winterhalter" > To: "Remi Forax" > Cc: "core-libs-dev" , "joe darcy" > > Sent: Tuesday, January 21, 2025 10:17:35 AM > Subject: Re: Factory methods for SequencedSet and SequencedMap > Wouldn't this already be possible with today's union types? > static & SequencedSet> S of(E..

Re: RFR: 8342807: Update links in java.base to use https:// [v3]

2025-01-25 Thread Thomas Stuefe
On Tue, 21 Jan 2025 06:51:10 GMT, Thomas Stuefe wrote: >>> In ProcessImpl_md.c, we have adopted the Posix APIs and semantics for >>> process handling. I suggest removing the "unofficial" link, it does not >>> include useful information at this point and is fragile. >>> >>> The current behavior