> From: "Rafael Winterhalter"
> To: "core-libs-dev"
> Sent: Thursday, January 16, 2025 8:13:17 AM
> Subject: Factory methods for SequencedSet and SequencedMap
> Hello,
Hello,
> I am happily taking SequencedSet and SequencedMap into use, but one
> inconvenience I encounter is the lack of facto
On Wed, 15 Jan 2025 23:48:33 GMT, Leonid Mesnik wrote:
> There few compiler warning disabled in the testlibary build.
> They should be fixed or localized and removed from build to prevent new
> possible issues.
>
> The main goal is to avoid new such issues in the testlibrary.
> Tested with tie
On Wed, 15 Jan 2025 16:13:04 GMT, Magnus Ihse Bursie wrote:
>> The idea.sh script which creates a configuration for IDEA does at some point
>> call a makefile, to extract information from the build system. However, this
>> is done in an ad-hoc manner that does not fit properly in the build syst
Hello,
I am happily taking SequencedSet and SequencedMap into use, but one
inconvenience I encounter is the lack of factory methods for the two.
In code where many (initial) collections have zero or one element (for
later aggregation), I now write Set.of()/Set.of(one) and
Map.of()/Map.of(key, val
On Wed, 15 Jan 2025 23:48:33 GMT, Leonid Mesnik wrote:
> There few compiler warning disabled in the testlibary build.
> They should be fixed or localized and removed from build to prevent new
> possible issues.
>
> The main goal is to avoid new such issues in the testlibrary.
> Tested with tie
There few compiler warning disabled in the testlibary build.
They should be fixed or localized and removed from build to prevent new
possible issues.
The main goal is to avoid new such issues in the testlibrary.
Tested with tier1-5 to ensure that all tests were passed.
-
Commit mes
On Fri, 19 Jul 2024 15:16:01 GMT, Lance Andersen wrote:
>>> I understand the request here, but is there a current use case for needing
>>> a custom Deflater?
>>
>> I think the primary use case is when you want to set a non-default
>> compression level, e.g., "best" or "fast". This is a pretty
On Wed, 15 Jan 2025 16:13:04 GMT, Magnus Ihse Bursie wrote:
>> The idea.sh script which creates a configuration for IDEA does at some point
>> call a makefile, to extract information from the build system. However, this
>> is done in an ad-hoc manner that does not fit properly in the build syst
On Thu, 14 Nov 2024 12:22:36 GMT, Magnus Ihse Bursie wrote:
> In several (most? all?) of the build system files, the copyright header
> includes the classpath exception. This makes no sense, and should be removed.
>
> I have removed the classpath exception from makefiles, autoconf, shell
> sc
On Wed, 15 Jan 2025 21:26:49 GMT, Brian Burkhalter wrote:
>> Fix the means of determining whether an exception is to be expected in the
>> Windows test.
>
> Brian Burkhalter has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8347740: Change W
On Tue, 14 Jan 2025 22:15:07 GMT, Brian Burkhalter wrote:
>> Fix the means of determining whether an exception is to be expected in the
>> Windows test.
>
> Brian Burkhalter has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8347740: Minor cl
> Fix the means of determining whether an exception is to be expected in the
> Windows test.
Brian Burkhalter has updated the pull request incrementally with one additional
commit since the last revision:
8347740: Change Windows exceptionExpected to be based on build number
-
Ch
On Wed, 15 Jan 2025 16:13:04 GMT, Magnus Ihse Bursie wrote:
>> The idea.sh script which creates a configuration for IDEA does at some point
>> call a makefile, to extract information from the build system. However, this
>> is done in an ad-hoc manner that does not fit properly in the build syst
On Wed, 15 Jan 2025 16:13:04 GMT, Magnus Ihse Bursie wrote:
>> The idea.sh script which creates a configuration for IDEA does at some point
>> call a makefile, to extract information from the build system. However, this
>> is done in an ad-hoc manner that does not fit properly in the build syst
On Thu, 5 Dec 2024 16:24:29 GMT, Scott Marlow wrote:
> I am getting the `Duplication annotation for class` error as mentioned in
> https://hibernate.atlassian.net/browse/HHH-18901. The current error message
> does not include the application class name (e.g. container) that the
> specified an
On Wed, 15 Jan 2025 15:51:49 GMT, Per Minborg wrote:
> > So, as we foresee the adoption of the FFM API in the JDK internals, we will
> > use such a mechanism for system calls like `fopen`, `socket`, and the like.
> > See #22307 for example.
>
> Sorry I still don't see where you do the actual na
On Wed, 15 Jan 2025 16:09:36 GMT, Per Minborg wrote:
>> Going forward, converting older JDK code to use the relatively new FFM API
>> requires system calls that can provide `errno` and the likes to explicitly
>> allocate a MemorySegment to capture potential error states. This can lead to
>> ne
On Wed, 15 Jan 2025 07:19:12 GMT, David Holmes wrote:
>> Brian Burkhalter has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8347740: Minor clean up
>
> test/jdk/java/io/File/createTempFile/SpecialTempFile.java line 117:
>
>> 115:
>> 116:
On Fri, 10 Jan 2025 23:05:13 GMT, Naoto Sato wrote:
> The use of [three-letter time zone
> IDs](https://download.java.net/java/early_access/jdk24/docs/api/java.base/java/util/TimeZone.html#three-letter-time-zone-ids-heading)
> has long been deprecated. For their actual removal in the future, ma
On Fri, 10 Jan 2025 23:05:13 GMT, Naoto Sato wrote:
> The use of [three-letter time zone
> IDs](https://download.java.net/java/early_access/jdk24/docs/api/java.base/java/util/TimeZone.html#three-letter-time-zone-ids-heading)
> has long been deprecated. For their actual removal in the future, ma
On Wed, 15 Jan 2025 16:56:57 GMT, Brian Burkhalter wrote:
>> test/jdk/java/io/File/createTempFile/SpecialTempFile.java line 117:
>>
>>> 115:
>>> 116: String[] nameElements = osName.split(" ");
>>> 117: int nameVers =
>>> Integer.valueOf(nameElements[nameElements.length - 1]);
>
On Wed, 15 Jan 2025 16:26:26 GMT, Maurizio Cimadamore
wrote:
> We should probably also ask somebody with Windows
Hey, don't forget about me! How do I test this, just set up an IDEA Workspace
as instructed in the docs?
-
PR Comment: https://git.openjdk.org/jdk/pull/23140#issuecomm
On Wed, 15 Jan 2025 16:40:10 GMT, Julian Waters wrote:
> > We should probably also ask somebody with Windows
>
> Hey, don't forget about me! How do I test this, just set up an IDEA Workspace
> as instructed in the docs?
Yes, that would be the case. E.g. run `sh bin/idea.sh java.base` or someth
On Wed, 15 Jan 2025 15:34:30 GMT, Magnus Ihse Bursie wrote:
> @mcimadamore Can you please verify that the IDEA generation still works
> properly? I've tried it locally and it seems fine to me, but I'd like you to
> verify it as well.
I will take a look. Thanks for the headsup. We should probab
On Wed, 15 Jan 2025 16:09:36 GMT, Per Minborg wrote:
>> Going forward, converting older JDK code to use the relatively new FFM API
>> requires system calls that can provide `errno` and the likes to explicitly
>> allocate a MemorySegment to capture potential error states. This can lead to
>> ne
On Wed, 15 Jan 2025 16:09:36 GMT, Per Minborg wrote:
>> Going forward, converting older JDK code to use the relatively new FFM API
>> requires system calls that can provide `errno` and the likes to explicitly
>> allocate a MemorySegment to capture potential error states. This can lead to
>> ne
On Wed, 15 Jan 2025 15:33:14 GMT, Magnus Ihse Bursie wrote:
> The idea.sh script which creates a configuration for IDEA does at some point
> call a makefile, to extract information from the build system. However, this
> is done in an ad-hoc manner that does not fit properly in the build system.
> The idea.sh script which creates a configuration for IDEA does at some point
> call a makefile, to extract information from the build system. However, this
> is done in an ad-hoc manner that does not fit properly in the build system.
>
> I ran into this as a problem when trying to implement an
> Going forward, converting older JDK code to use the relatively new FFM API
> requires system calls that can provide `errno` and the likes to explicitly
> allocate a MemorySegment to capture potential error states. This can lead to
> negative performance implications if not designed carefully a
On Tue, 14 Jan 2025 12:29:11 GMT, David Holmes wrote:
> > So, as we foresee the adoption of the FFM API in the JDK internals, we will
> > use such a mechanism for system calls like `fopen`, `socket`, and the like.
> > See #22307 for example.
>
> Sorry I still don't see where you do the actual n
On Thu, 5 Dec 2024 16:24:29 GMT, Scott Marlow wrote:
> I am getting the `Duplication annotation for class` error as mentioned in
> https://hibernate.atlassian.net/browse/HHH-18901. The current error message
> does not include the application class name (e.g. container) that the
> specified an
On Wed, 15 Jan 2025 15:33:14 GMT, Magnus Ihse Bursie wrote:
> The idea.sh script which creates a configuration for IDEA does at some point
> call a makefile, to extract information from the build system. However, this
> is done in an ad-hoc manner that does not fit properly in the build system.
The idea.sh script which creates a configuration for IDEA does at some point
call a makefile, to extract information from the build system. However, this is
done in an ad-hoc manner that does not fit properly in the build system.
I ran into this as a problem when trying to implement another chan
> Going forward, converting older JDK code to use the relatively new FFM API
> requires system calls that can provide `errno` and the likes to explicitly
> allocate a MemorySegment to capture potential error states. This can lead to
> negative performance implications if not designed carefully a
On Thu, 9 Jan 2025 17:32:39 GMT, Severin Gehwolf wrote:
> During code review of
> [JDK-8346239](https://bugs.openjdk.org/browse/JDK-8346239) a few comments
> were made after the PR integrated. This follow-up patch cleans this up and
> adds a unit test for the `JimageDiffGenerator` class.
>
>
On Fri, 10 Jan 2025 14:58:36 GMT, Severin Gehwolf wrote:
>> During code review of
>> [JDK-8346239](https://bugs.openjdk.org/browse/JDK-8346239) a few comments
>> were made after the PR integrated. This follow-up patch cleans this up and
>> adds a unit test for the `JimageDiffGenerator` class.
On Thu, 5 Dec 2024 16:24:29 GMT, Scott Marlow wrote:
> I am getting the `Duplication annotation for class` error as mentioned in
> https://hibernate.atlassian.net/browse/HHH-18901. The current error message
> does not include the application class name (e.g. container) that the
> specified an
This PR reverts the fix from
[JDK-8339166](https://bugs.openjdk.org/browse/JDK-8339166) because it increases
the runtime of the test a lot.
Instead a full gc is requested via the whitebox api. This solves the issues
(see bug description) and it is also clearer and more reliable that allocating
On Tue, 14 Jan 2025 06:39:22 GMT, Alan Bateman wrote:
> > There's a contributor PR from the java bugs submitter at #23050, I wonder
> > what we should do in this case.
>
> The PR has the "oca" label so we can't look or comment on it.
:O People from Oracle aren't allowed to look at work from un
On Thu, 29 Aug 2024 15:52:41 GMT, Claes Redestad wrote:
> LGTM. On my M1 MacBook this increase total runtime of `make test
> TEST=.../HiddenClassUnloading.java` by 8-9s, which seems acceptable to ensure
> it's stable and fit for purpose on all platforms.
@cl4es in my tests with a fastdebug bui
On Fri, 10 Jan 2025 14:58:36 GMT, Severin Gehwolf wrote:
>> During code review of
>> [JDK-8346239](https://bugs.openjdk.org/browse/JDK-8346239) a few comments
>> were made after the PR integrated. This follow-up patch cleans this up and
>> adds a unit test for the `JimageDiffGenerator` class.
> Going forward, converting older JDK code to use the relatively new FFM API
> requires system calls that can provide `errno` and the likes to explicitly
> allocate a MemorySegment to capture potential error states. This can lead to
> negative performance implications if not designed carefully a
On Thu, 19 Dec 2024 10:46:03 GMT, Per Minborg wrote:
> This PR proposes to clean up all the imports in the FFM lib (excluding tests).
>
> Passes tier1-tier3
This pull request has now been integrated.
Changeset: d4e5ec27
Author:Per Minborg
URL:
https://git.openjdk.org/jdk/commit/d4e
On Wed, 15 Jan 2025 08:55:04 GMT, Maurizio Cimadamore
wrote:
> Did you also do a pass on microbenchmarks and tests? Or will that be a
> separate effort (probably better) ?
https://bugs.openjdk.org/browse/JDK-8347814
-
PR Comment: https://git.openjdk.org/jdk/pull/22827#issuecommen
> Going forward, converting older JDK code to use the relatively new FFM API
> requires system calls that can provide `errno` and the likes to explicitly
> allocate a MemorySegment to capture potential error states. This can lead to
> negative performance implications if not designed carefully a
> Going forward, converting older JDK code to use the relatively new FFM API
> requires system calls that can provide `errno` and the likes to explicitly
> allocate a MemorySegment to capture potential error states. This can lead to
> negative performance implications if not designed carefully a
> Going forward, converting older JDK code to use the relatively new FFM API
> requires system calls that can provide `errno` and the likes to explicitly
> allocate a MemorySegment to capture potential error states. This can lead to
> negative performance implications if not designed carefully a
On Fri, 10 Jan 2025 13:32:39 GMT, Alan Bateman wrote:
> The thread-per-task-executor returned by
> Executors.newVirtualThreadPerTaskExecutor will terminate without waiting for
> threads that are still executing cancelled tasks. This is different to
> ThreadPoolExecutor and ForkJoinPool that wa
On Thu, 9 Jan 2025 11:47:15 GMT, Per Minborg wrote:
>> This PR proposes to clean up all the imports in the FFM lib (excluding
>> tests).
>>
>> Passes tier1-tier3
>
> Per Minborg has updated the pull request with a new target base due to a
> merge or a rebase. The incremental webrev excludes th
49 matches
Mail list logo
