On Tue, 14 Jan 2025 22:15:07 GMT, Brian Burkhalter wrote:
>> Fix the means of determining whether an exception is to be expected in the
>> Windows test.
>
> Brian Burkhalter has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8347740: Minor cl
On Wed, 15 Jan 2025 05:14:51 GMT, Henry Jen wrote:
> jimage use the same code to parse command line options, the resource bundle
> for jimage also need update.
This pull request has now been integrated.
Changeset: a3be97e2
Author:Henry Jen
URL:
https://git.openjdk.org/jdk/commit/a3
On Wed, 15 Jan 2025 05:14:51 GMT, Henry Jen wrote:
> jimage use the same code to parse command line options, the resource bundle
> for jimage also need update.
LGTM. Thanks
-
Marked as reviewed by dholmes (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/23123#pullrequestre
On Wed, 15 Jan 2025 04:27:14 GMT, Chen Liang wrote:
> The new API specification for class file attributes link to non-SE modules of
> jdk.compiler and jdk.jlink, which caused docs build failure for SE docs. This
> patch removes those links and replace them with plain module name references.
Th
On Wed, 15 Jan 2025 04:57:03 GMT, Chen Liang wrote:
>> The new API specification for class file attributes link to non-SE modules
>> of jdk.compiler and jdk.jlink, which caused docs build failure for SE docs.
>> This patch removes those links and replace them with plain module name
>> referenc
On Wed, 15 Jan 2025 04:57:03 GMT, Chen Liang wrote:
>> The new API specification for class file attributes link to non-SE modules
>> of jdk.compiler and jdk.jlink, which caused docs build failure for SE docs.
>> This patch removes those links and replace them with plain module name
>> referenc
jimage use the same code to parse command line options, the resource bundle for
jimage also need update.
-
Commit messages:
- 8347761: Test tools/jimage/JImageExtractTest.java fails after JDK-8303884
Changes: https://git.openjdk.org/jdk/pull/23123/files
Webrev: https://webrevs.op
On Wed, 15 Jan 2025 04:53:46 GMT, Chen Liang wrote:
>> The new API specification for class file attributes link to non-SE modules
>> of jdk.compiler and jdk.jlink, which caused docs build failure for SE docs.
>> This patch removes those links and replace them with plain module name
>> referenc
> The new API specification for class file attributes link to non-SE modules of
> jdk.compiler and jdk.jlink, which caused docs build failure for SE docs. This
> patch removes those links and replace them with plain module name references.
Chen Liang has updated the pull request incrementally wi
On Wed, 15 Jan 2025 04:53:46 GMT, Chen Liang wrote:
>> The new API specification for class file attributes link to non-SE modules
>> of jdk.compiler and jdk.jlink, which caused docs build failure for SE docs.
>> This patch removes those links and replace them with plain module name
>> referenc
On Wed, 15 Jan 2025 04:27:14 GMT, Chen Liang wrote:
> The new API specification for class file attributes link to non-SE modules of
> jdk.compiler and jdk.jlink, which caused docs build failure for SE docs. This
> patch removes those links and replace them with plain module name references.
Ma
On Wed, 15 Jan 2025 04:27:14 GMT, Chen Liang wrote:
> The new API specification for class file attributes link to non-SE modules of
> jdk.compiler and jdk.jlink, which caused docs build failure for SE docs. This
> patch removes those links and replace them with plain module name references.
Ch
The new API specification for class file attributes link to non-SE modules of
jdk.compiler and jdk.jlink, which caused docs build failure for SE docs. This
patch removes those links and replace them with plain module name references.
-
Commit messages:
- 8347762: ClassFile attribut
On Wed, 8 Jan 2025 09:08:11 GMT, Per Minborg wrote:
> > Do we have a sense on how easy would it be, moving forward, to preserve the
> > "correct" order of imports? E.g. if I add a new one using IntelliJ
> > autocompletion, where would it end up? Has this patch been generated using
> > the IDE'
On Fri, 10 Jan 2025 07:32:24 GMT, Chen Liang wrote:
> Improve documentation for `class` file attributes. This include better
> specification for user attributes, some more general information about
> attributes, such as the usage of non-JVMS attributes, and updated some
> attribute information
On Wed, 15 Jan 2025 00:20:02 GMT, Chen Liang wrote:
>> Improve documentation for `class` file attributes. This include better
>> specification for user attributes, some more general information about
>> attributes, such as the usage of non-JVMS attributes, and updated some
>> attribute informa
On Tue, 14 Jan 2025 09:23:35 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this enhancement which proposes to enhance
>> `java.util.zip.Deflater/Inflater` classes to now implement `AutoCloseable`?
>>
>> The actual work for this was done a few years back when we discussed the
>> prop
On Wed, 12 Jun 2024 10:45:30 GMT, Jaikiran Pai wrote:
> Can I please get a review of this enhancement which proposes to enhance
> `java.util.zip.Deflater/Inflater` classes to now implement `AutoCloseable`?
>
> The actual work for this was done a few years back when we discussed the
> proposed
On Wed, 15 Jan 2025 00:20:02 GMT, Chen Liang wrote:
>> Improve documentation for `class` file attributes. This include better
>> specification for user attributes, some more general information about
>> attributes, such as the usage of non-JVMS attributes, and updated some
>> attribute informa
On Tue, 14 Jan 2025 13:07:27 GMT, Jatin Bhateja wrote:
> Given the above observations passing 3 additional box arguments to intrinsic
> and returning a box value needs additional changes in the compiler while
> minor re-structuring in Java implementation packed with in the glue logic
> looks l
> Improve documentation for `class` file attributes. This include better
> specification for user attributes, some more general information about
> attributes, such as the usage of non-JVMS attributes, and updated some
> attribute information in the base package too, such as Annotation and
> Si
On Tue, 3 Dec 2024 19:59:56 GMT, Henry Jen wrote:
> Improving option value handling to support passing argument value starts with
> "--".
>
> Before the fix, in following example, --add-modules will be considered as
> another option for JLink instead of argument value for --add-options.
> --ad
On Thu, 5 Dec 2024 16:24:29 GMT, Scott Marlow wrote:
> I am getting the `Duplication annotation for class` error as mentioned in
> https://hibernate.atlassian.net/browse/HHH-18901. The current error message
> does not include the application class name (e.g. container) that the
> specified an
On Tue, 14 Jan 2025 16:57:13 GMT, Henry Jen wrote:
>> Improving option value handling to support passing argument value starts
>> with "--".
>>
>> Before the fix, in following example, --add-modules will be considered as
>> another option for JLink instead of argument value for --add-options.
On Tue, 14 Jan 2025 09:06:21 GMT, Yasumasa Suenaga wrote:
>> Henry Jen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Use different error message for ambiguous gnu-style options as value
>
> It's better, thanks!
@YaSuenag Will need you
> Fix the means of determining whether an exception is to be expected in the
> Windows test.
Brian Burkhalter has updated the pull request incrementally with one additional
commit since the last revision:
8347740: Minor clean up
-
Changes:
- all: https://git.openjdk.org/jdk/pu
On Tue, 14 Jan 2025 21:47:06 GMT, Brian Burkhalter wrote:
> Fix the means of determining whether an exception is to be expected in the
> Windows test.
The test has been verified to pass on Windows 10 and 11 and on Windows Server
2016, 2019, and 2022.
-
PR Comment: https://git.ope
Fix the means of determining whether an exception is to be expected in the
Windows test.
-
Commit messages:
- 8347740: java/io/File/createTempFile/SpecialTempFile.java failing
Changes: https://git.openjdk.org/jdk/pull/23117/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=2
On Mon, 13 Jan 2025 21:38:04 GMT, Justin Lu wrote:
> Please review this PR which removes a leftover `doPrivileged` call in the
> Currency test, _CheckDataVersion.java_.
This pull request has now been integrated.
Changeset: 02d24934
Author:Justin Lu
URL:
https://git.openjdk.org/jdk/
On Tue, 14 Jan 2025 15:59:42 GMT, Per Minborg wrote:
>> Going forward, converting older JDK code to use the relatively new FFM API
>> requires system calls that can provide `errno` and the likes to explicitly
>> allocate a MemorySegment to capture potential error states. This can lead to
>> ne
On Fri, 13 Dec 2024 00:00:26 GMT, Vladimir Ivanov wrote:
> The double check needs less time vs enter to 'synchronize' block when it not
> needed. This patch for the xml.validation workload for runs with 112 threads
> reports ~2.5% improvement on the server with Xeon 8480:
> orig: 1T - 433.64 op
On Fri, 13 Dec 2024 02:18:35 GMT, Vladimir Ivanov wrote:
>> The double check needs less time vs enter to 'synchronize' block when it not
>> needed. This patch for the xml.validation workload for runs with 112 threads
>> reports ~2.5% improvement on the server with Xeon 8480:
>> orig: 1T - 433.6
On Fri, 13 Dec 2024 02:18:35 GMT, Vladimir Ivanov wrote:
>> The double check needs less time vs enter to 'synchronize' block when it not
>> needed. This patch for the xml.validation workload for runs with 112 threads
>> reports ~2.5% improvement on the server with Xeon 8480:
>> orig: 1T - 433.6
On Fri, 10 Jan 2025 14:58:36 GMT, Severin Gehwolf wrote:
>> During code review of
>> [JDK-8346239](https://bugs.openjdk.org/browse/JDK-8346239) a few comments
>> were made after the PR integrated. This follow-up patch cleans this up and
>> adds a unit test for the `JimageDiffGenerator` class.
On Sat, Jan 11, 2025 at 12:09 AM John Rose wrote:
> https://bugs.openjdk.org/browse/JDK-8285871
> Math.multiplyHigh and multiply on same inputs can be computed faster if
> their computation is shared
>
I must admit it seemed odd to me that there was a `multiplyHigh` without a
corresponding `mult
On Tue, 14 Jan 2025 09:23:35 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this enhancement which proposes to enhance
>> `java.util.zip.Deflater/Inflater` classes to now implement `AutoCloseable`?
>>
>> The actual work for this was done a few years back when we discussed the
>> prop
On Thu, 9 Jan 2025 22:44:15 GMT, Naoto Sato wrote:
>> A simple refinement to the test makes diagnosing failures easier.
>
> Naoto Sato has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Addresses review comments
Thanks for the reviews!
-
On Thu, 9 Jan 2025 18:28:19 GMT, Naoto Sato wrote:
> A simple refinement to the test makes diagnosing failures easier.
This pull request has now been integrated.
Changeset: 06ff4c17
Author:Naoto Sato
URL:
https://git.openjdk.org/jdk/commit/06ff4c17bdfab9e7aa323425cb18dfdc963aa972
St
On Tue, 14 Jan 2025 09:23:35 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this enhancement which proposes to enhance
>> `java.util.zip.Deflater/Inflater` classes to now implement `AutoCloseable`?
>>
>> The actual work for this was done a few years back when we discussed the
>> prop
On Fri, 10 Jan 2025 14:58:36 GMT, Severin Gehwolf wrote:
>> During code review of
>> [JDK-8346239](https://bugs.openjdk.org/browse/JDK-8346239) a few comments
>> were made after the PR integrated. This follow-up patch cleans this up and
>> adds a unit test for the `JimageDiffGenerator` class.
On Wed, 18 Dec 2024 02:38:28 GMT, Liam Miller-Cushon wrote:
> Please consider this fix for
> [JDK-8323740](https://bugs.openjdk.org/browse/JDK-8323740), which avoids an
> `ExceptionInInitializerError` in the class initializer of
> `XMLDocumentFragmentScannerImpl` and other classes that have a
On Tue, 14 Jan 2025 16:57:13 GMT, Henry Jen wrote:
>> Improving option value handling to support passing argument value starts
>> with "--".
>>
>> Before the fix, in following example, --add-modules will be considered as
>> another option for JLink instead of argument value for --add-options.
> Improving option value handling to support passing argument value starts with
> "--".
>
> Before the fix, in following example, --add-modules will be considered as
> another option for JLink instead of argument value for --add-options.
> --add-options --add-modules=jdk.incubator.concurrent
> -
On Fri, 10 Jan 2025 14:57:09 GMT, Severin Gehwolf wrote:
>> Please review this fix for cgroups-based metrics reporting in the
>> `jdk.internal.platform` package. This fix is supposed to address wrong
>> reporting of certain limits if the limits aren't set at the leaf nodes.
>>
>> For example,
On Mon, 13 Jan 2025 22:40:27 GMT, Joe Darcy wrote:
> Get IEEE 754 added as an external standard in JDK 24's docs too.
This pull request has now been integrated.
Changeset: f45a23ca
Author:Joe Darcy
URL:
https://git.openjdk.org/jdk/commit/f45a23cabdcf43e1ae82e34a64f04df87a40d415
Stat
> Going forward, converting older JDK code to use the relatively new FFM API
> requires system calls that can provide `errno` and the likes to explicitly
> allocate a MemorySegment to capture potential error states. This can lead to
> negative performance implications if not designed carefully a
> This is an optimization for decimal Integer.parseInt and Long.parseLong,
> which improves performance by about 10%. The optimization includes:
> 1. Improve performance by parsing 2 numbers at a time, which has performance
> improvements for numbers with length >= 3.
> 2. It uses charAt(0) for t
On Sun, 5 Jan 2025 11:01:18 GMT, Shaojin Wen wrote:
>> This is an optimization for decimal Integer.parseInt and Long.parseLong,
>> which improves performance by about 10%. The optimization includes:
>> 1. Improve performance by parsing 2 numbers at a time, which has performance
>> improvements
On Mon, 13 Jan 2025 21:58:43 GMT, Henry Jen wrote:
> Sort services provided by a module to ensure reproduce same result.
This pull request has now been integrated.
Changeset: dfd215b7
Author:Henry Jen
URL:
https://git.openjdk.org/jdk/commit/dfd215b7e9e40526006448369c8847aadfe0926b
S
> Please consider this fix for
> [JDK-8323740](https://bugs.openjdk.org/browse/JDK-8323740), which avoids an
> `ExceptionInInitializerError` in the class initializer of
> `XMLDocumentFragmentScannerImpl` and other classes that have a circular
> dependency on `jdk.xml.internal.JdkXmlUtils`. The
On Tue, 14 Jan 2025 10:55:54 GMT, Viktor Klang wrote:
>> Seems sensible to improve this given that it can be tricky to figure out
>> which parameter caused the exception to be thrown.
>
> Viktor Klang has updated the pull request incrementally with one additional
> commit since the last revisio
On Tue, 14 Jan 2025 11:03:38 GMT, Viktor Klang wrote:
> Hi all,
>
> This pull request contains a backport of commit
> [450636ae](https://github.com/openjdk/jdk/commit/450636ae28b84ded083b6861c6cba85fbf87e16e)
> from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
>
> The commit bei
On Mon, 13 Jan 2025 16:51:02 GMT, Paul Sandoz wrote:
>> Hi @PaulSandoz , In the current scheme we are passing unboxed carriers to
>> intrinsic entry point, in the fallback implementation carrier type is first
>> converted to floating point value using Float.float16ToFloat API which
>> expects
On Mon, 13 Jan 2025 11:07:11 GMT, Per Minborg wrote:
>> Going forward, converting older JDK code to use the relatively new FFM API
>> requires system calls that can provide `errno` and the likes to explicitly
>> allocate a MemorySegment to capture potential error states. This can lead to
>> ne
On Tue, 14 Jan 2025 09:23:35 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this enhancement which proposes to enhance
>> `java.util.zip.Deflater/Inflater` classes to now implement `AutoCloseable`?
>>
>> The actual work for this was done a few years back when we discussed the
>> prop
On Tue, 14 Jan 2025 11:03:38 GMT, Viktor Klang wrote:
> Hi all,
>
> This pull request contains a backport of commit
> [450636ae](https://github.com/openjdk/jdk/commit/450636ae28b84ded083b6861c6cba85fbf87e16e)
> from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
>
> The commit bei
Hi all,
This pull request contains a backport of commit
[450636ae](https://github.com/openjdk/jdk/commit/450636ae28b84ded083b6861c6cba85fbf87e16e)
from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
The commit being backported was authored by Viktor Klang on 13 Jan 2025 and was
rev
On Mon, 13 Jan 2025 12:59:06 GMT, Viktor Klang wrote:
> Backport to jdk24 of https://bugs.openjdk.org/browse/JDK-8347274
This pull request has been closed without being integrated.
-
PR: https://git.openjdk.org/jdk/pull/23068
On Mon, 13 Jan 2025 12:59:06 GMT, Viktor Klang wrote:
> Backport to jdk24 of https://bugs.openjdk.org/browse/JDK-8347274
Opening a new PR as something didn't go right with this manual backport.
-
PR Comment: https://git.openjdk.org/jdk/pull/23068#issuecomment-2589611975
On Mon, 13 Jan 2025 19:20:41 GMT, He-Pin(kerr) wrote:
>> Backport to jdk24 of https://bugs.openjdk.org/browse/JDK-8347274
>
> Does this fix the OOM problem?
>
>
> import java.util.stream.Gatherers;
> import java.util.stream.IntStream;
>
> /**
> * TODO: description of this file
> *
> * @auth
> Seems sensible to improve this given that it can be tricky to figure out
> which parameter caused the exception to be thrown.
Viktor Klang has updated the pull request incrementally with one additional
commit since the last revision:
Updates the ThreadPoolExecutorTest.java to assert the exc
On Mon, 13 Jan 2025 11:29:06 GMT, Christian Stein wrote:
>> Please review this change request enabling native access in source launch
>> mode when using a modular setup.
>>
>> The change comes in two parts:
>> 1. Prevent warnings of unknown modules being emitted from module bootstrap
>> for us
On Mon, 6 Jan 2025 16:35:59 GMT, Christian Stein wrote:
> Please review this change request enabling native access in source launch
> mode when using a modular setup.
>
> The change comes in two parts:
> 1. Prevent warnings of unknown modules being emitted from module bootstrap
> for user modu
On Fri, 10 Jan 2025 13:32:39 GMT, Alan Bateman wrote:
> The thread-per-task-executor returned by
> Executors.newVirtualThreadPerTaskExecutor will terminate without waiting for
> threads that are still executing cancelled tasks. This is different to
> ThreadPoolExecutor and ForkJoinPool that wa
On Fri, 10 Jan 2025 14:58:36 GMT, Severin Gehwolf wrote:
>> During code review of
>> [JDK-8346239](https://bugs.openjdk.org/browse/JDK-8346239) a few comments
>> were made after the PR integrated. This follow-up patch cleans this up and
>> adds a unit test for the `JimageDiffGenerator` class.
On Mon, 13 Jan 2025 08:14:08 GMT, Adam Sotona wrote:
>> There are no more consumers of ASM library except for hotspot tests.
>> This patch moves ASM library from java.base module to the hotspot test
>> libraries location and fixes the tests.
>>
>> Please review.
>>
>> Thanks,
>> Adam
>
> Adam
On Tue, 7 Jan 2025 12:49:40 GMT, Adam Sotona wrote:
> There are no more consumers of ASM library except for hotspot tests.
> This patch moves ASM library from java.base module to the hotspot test
> libraries location and fixes the tests.
>
> Please review.
>
> Thanks,
> Adam
This pull request
On Tue, 14 Jan 2025 09:17:59 GMT, Jaikiran Pai wrote:
>> I believe an `@implSpec` only restricts the implementation of this immediate
>> method, such as those seen on default methods, and has no impact on the
>> overrides. If we need to specify something for overrides to abide to, I
>> believe
On Tue, 14 Jan 2025 08:28:38 GMT, Chen Liang wrote:
>> src/java.base/share/classes/java/util/zip/Deflater.java line 66:
>>
>>> 64: * {@code try}-with-resources statement. The {@linkplain
>>> Deflater#close() close() method} simply
>>> 65: * calls {@code end()}. Subclasses should override {@li
> Can I please get a review of this enhancement which proposes to enhance
> `java.util.zip.Deflater/Inflater` classes to now implement `AutoCloseable`?
>
> The actual work for this was done a few years back when we discussed the
> proposed approaches and then I raised a RFR. At that time I could
On Mon, 13 Jan 2025 18:19:59 GMT, Henry Jen wrote:
>> Improving option value handling to support passing argument value starts
>> with "--".
>>
>> Before the fix, in following example, --add-modules will be considered as
>> another option for JLink instead of argument value for --add-options.
> Can I please get a review of this enhancement which proposes to enhance
> `java.util.zip.Deflater/Inflater` classes to now implement `AutoCloseable`?
>
> The actual work for this was done a few years back when we discussed the
> proposed approaches and then I raised a RFR. At that time I could
On Tue, 14 Jan 2025 06:35:04 GMT, Alan Bateman wrote:
>> Jaikiran Pai has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fix javadoc tag ordering - "@throws" after "@return"
>
> src/java.base/share/classes/java/util/zip/Deflater.java line 5
On Tue, 14 Jan 2025 05:07:55 GMT, Galder Zamarreño wrote:
>> @galderz So you want me to review again?
>
> @eme64 I've fixed the test issue, it's ready to be reviewed
@galderz I ran some testing on our side, feel free to ping me in 1-2 days for
the results.
-
PR Comment: https://gi
On Tue, 14 Jan 2025 07:31:08 GMT, Per Minborg wrote:
>> src/java.base/share/classes/jdk/internal/foreign/CaptureStateUtil.java line
>> 214:
>>
>>> 212: // Used reflectively by `getAsIntHandle(MemoryLayout layout)`
>>> 213: private static int getStateAsInt(VarHandle handle) {
>>> 214:
On Tue, 14 Jan 2025 05:07:55 GMT, Galder Zamarreño wrote:
>> @galderz So you want me to review again?
>
> @eme64 I've fixed the test issue, it's ready to be reviewed
@galderz I don't remember from above, but did you ever run the Long Min/Max
benchmarks from this?
https://github.com/openjdk/jdk/
On Tue, 14 Jan 2025 08:29:25 GMT, Emanuel Peter wrote:
>> Galder Zamarreño has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Make sure it runs with cpus with either avx512 or asimd
>
> test/hotspot/jtreg/compiler/loopopts/superword/MinMaxR
On Mon, 13 Jan 2025 17:12:31 GMT, Galder Zamarreño wrote:
>> This patch intrinsifies `Math.max(long, long)` and `Math.min(long, long)` in
>> order to help improve vectorization performance.
>>
>> Currently vectorization does not kick in for loops containing either of
>> these calls because of
On Tue, 14 Jan 2025 08:18:57 GMT, Alan Bateman wrote:
>> Jaikiran Pai has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fix javadoc tag ordering - "@throws" after "@return"
>
> src/java.base/share/classes/java/util/zip/Deflater.java line 6
On Mon, 13 Jan 2025 17:12:31 GMT, Galder Zamarreño wrote:
>> This patch intrinsifies `Math.max(long, long)` and `Math.min(long, long)` in
>> order to help improve vectorization performance.
>>
>> Currently vectorization does not kick in for loops containing either of
>> these calls because of
On Wed, 8 Jan 2025 06:01:55 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this enhancement which proposes to enhance
>> `java.util.zip.Deflater/Inflater` classes to now implement `AutoCloseable`?
>>
>> The actual work for this was done a few years back when we discussed the
>> propo
81 matches
Mail list logo
