Some AccessFlag parsing methods throw IAE because a flag mask is not valid in a
location. However, there is no easy way to check what flag mask bits or what
flags are valid for a location. We need such APIs to check, specific to each
class file format version.
Also in the investigation, it's no
On Mon, 13 Jan 2025 11:06:36 GMT, Maurizio Cimadamore
wrote:
>> Per Minborg has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Clean up benchmark
>> - Fix allocation problem in benchmark
>
> src/java.base/share/classes/jdk/internal/fore
On Tue, 14 Jan 2025 06:29:36 GMT, David Holmes wrote:
> Where do you actually make the native call and grab the errno/last-error
> value?
So, as we foresee the adoption of the FFM API in the JDK internals, we will use
such a mechanism for system calls like `fopen`, `socket`, and the like.
Se
On Sat, 11 Jan 2025 07:29:32 GMT, Alan Bateman wrote:
>> test/jdk/java/util/concurrent/ThreadPerTaskExecutor/ThreadPerTaskExecutorTest.java
>> line 306:
>>
>>> 304: stop.await();
>>> 305: return null;
>>> 306: });
>>
>> One (additional?) option would be to obtai
On Fri, 10 Jan 2025 13:32:39 GMT, Alan Bateman wrote:
> The thread-per-task-executor returned by
> Executors.newVirtualThreadPerTaskExecutor will terminate without waiting for
> threads that are still executing cancelled tasks. This is different to
> ThreadPoolExecutor and ForkJoinPool that wa
On Fri, 10 Jan 2025 14:16:44 GMT, Viktor Klang wrote:
>> The thread-per-task-executor returned by
>> Executors.newVirtualThreadPerTaskExecutor will terminate without waiting for
>> threads that are still executing cancelled tasks. This is different to
>> ThreadPoolExecutor and ForkJoinPool tha
The thread-per-task-executor returned by
Executors.newVirtualThreadPerTaskExecutor will terminate without waiting for
threads that are still executing cancelled tasks. This is different to
ThreadPoolExecutor and ForkJoinPool that wait for the threads to finish
executing the cancelled tasks. Not
On Mon, 13 Jan 2025 21:58:43 GMT, Henry Jen wrote:
> Sort services provided by a module to ensure reproduce same result.
Marked as reviewed by alanb (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/23088#pullrequestreview-2548918741
On Mon, 13 Jan 2025 16:28:52 GMT, Viktor Klang wrote:
> Seems sensible to improve this given that it can be tricky to figure out
> which parameter caused the exception to be thrown.
> There's a contributor PR from the java bugs submitter at #23050, I wonder
> what we should do in this case.
T
On Mon, 13 Jan 2025 11:07:11 GMT, Per Minborg wrote:
>> Going forward, converting older JDK code to use the relatively new FFM API
>> requires system calls that can provide `errno` and the likes to explicitly
>> allocate a MemorySegment to capture potential error states. This can lead to
>> ne
On Wed, 8 Jan 2025 06:01:55 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this enhancement which proposes to enhance
>> `java.util.zip.Deflater/Inflater` classes to now implement `AutoCloseable`?
>>
>> The actual work for this was done a few years back when we discussed the
>> propo
On Mon, 13 Jan 2025 21:58:43 GMT, Henry Jen wrote:
> Sort services provided by a module to ensure reproduce same result.
LGTM
-
Marked as reviewed by iklam (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/23088#pullrequestreview-2548864954
On Fri, 13 Dec 2024 02:18:35 GMT, Vladimir Ivanov wrote:
>> The double check needs less time vs enter to 'synchronize' block when it not
>> needed. This patch for the xml.validation workload for runs with 112 threads
>> reports ~2.5% improvement on the server with Xeon 8480:
>> orig: 1T - 433.6
On Fri, 20 Dec 2024 19:27:00 GMT, Liam Miller-Cushon wrote:
>> Please consider this fix for
>> [JDK-8323740](https://bugs.openjdk.org/browse/JDK-8323740), which avoids an
>> `ExceptionInInitializerError` in the class initializer of
>> `XMLDocumentFragmentScannerImpl` and other classes that hav
On Mon, 13 Jan 2025 22:40:27 GMT, Joe Darcy wrote:
> Get IEEE 754 added as an external standard in JDK 24's docs too.
Marked as reviewed by iris (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/23091#pullrequestreview-2548836665
On Thu, 9 Jan 2025 12:18:48 GMT, Emanuel Peter wrote:
>> @eme64 aarch64 work for this is now complete. I tweaked the `applyIf`
>> condition `MinMaxRed_Long` to make sure `MaxVectorSize` is 32 or higher. I
>> verified this on both Graviton 3 (256 bit register, `MaxVectorSize=32`) and
>> an AVX-
On Mon, 13 Jan 2025 21:58:43 GMT, Henry Jen wrote:
> Sort services provided by a module to ensure reproduce same result.
Seems reasonable.
Thanks for fixing.
-
Marked as reviewed by dholmes (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/23088#pullrequestreview-2548790485
On Wed, 11 Dec 2024 22:30:32 GMT, Shaojin Wen wrote:
>> This PR is a resubmission after PR #21593 was rolled back, and the unsafe
>> offset overflow issue has been fixed.
>>
>> 1) Move getChars methods of StringLatin1 and StringUTF16 to DecimalDigits to
>> reduce duplication.
>>
>> 2) HexDigi
On Mon, 14 Oct 2024 20:31:51 GMT, Kevin Bourrillion wrote:
> 8342566: Improve javadoc of java.lang.annotation.ElementType
This pull request has been closed without being integrated.
-
PR: https://git.openjdk.org/jdk/pull/21506
On Fri, 10 Jan 2025 23:05:13 GMT, Naoto Sato wrote:
> The use of [three-letter time zone
> IDs](https://download.java.net/java/early_access/jdk24/docs/api/java.base/java/util/TimeZone.html#three-letter-time-zone-ids-heading)
> has long been deprecated. For their actual removal in the future, ma
Hi Kevin,
I’m surprised you even noticed the methods.
I develop and maintain a collection library, in which I copied
checkPositionIndex because it is really commonly used by me.
I searched my library and found that checkPositionIndex has more than a
hundred use cases in my library.
And basicall
On Wed, 4 Dec 2024 14:57:22 GMT, SendaoYan wrote:
> Hi all,
> The file src/java.base/share/native/libjli/java.c generate compile warning
> by gcc14 with gcc options `-fsanitize=undefined -O2`, and make jdk build
> error when configure with option `--enable-ubsan`. So I think it's necessory
>
On Mon, 16 Dec 2024 12:47:13 GMT, SendaoYan wrote:
>> Hi all,
>> The file src/java.base/share/native/libjli/java.c generate compile warning
>> by gcc14 with gcc options `-fsanitize=undefined -O2`, and make jdk build
>> error when configure with option `--enable-ubsan`. So I think it's necessor
On Fri, 10 Jan 2025 23:05:13 GMT, Naoto Sato wrote:
> The use of [three-letter time zone
> IDs](https://download.java.net/java/early_access/jdk24/docs/api/java.base/java/util/TimeZone.html#three-letter-time-zone-ids-heading)
> has long been deprecated. For their actual removal in the future, ma
On Thu, 9 Jan 2025 22:44:15 GMT, Naoto Sato wrote:
>> A simple refinement to the test makes diagnosing failures easier.
>
> Naoto Sato has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Addresses review comments
Marked as reviewed by joehw (R
On Mon, 13 Jan 2025 22:40:27 GMT, Joe Darcy wrote:
> Get IEEE 754 added as an external standard in JDK 24's docs too.
Looks fine.
-
Marked as reviewed by bpb (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/23091#pullrequestreview-2548245622
On Mon, 13 Jan 2025 22:40:27 GMT, Joe Darcy wrote:
> Get IEEE 754 added as an external standard in JDK 24's docs too.
Marked as reviewed by liach (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/23091#pullrequestreview-2548223777
On Mon, 13 Jan 2025 23:12:18 GMT, Justin Lu wrote:
>> Please review this PR which removes a leftover `doPrivileged` call in the
>> Currency test, _CheckDataVersion.java_.
>
> Justin Lu has updated the pull request incrementally with one additional
> commit since the last revision:
>
> reflec
I tend to name such an item a "cursor position" as termed in ListIterator; I
used the same term for Label in the ClassFile API.
I indeed think this API would be useful: List.add, List.listIterator,
TypeDescriptor.OfMethod.insertParameterTypes, getting labels in a code array
for class files...
_
On Mon, 13 Jan 2025 22:44:39 GMT, Naoto Sato wrote:
>> Justin Lu has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> reflect review
>
> test/jdk/java/util/Currency/CheckDataVersion.java line 79:
>
>> 77: } catch (IOException ioe
> Please review this PR which removes a leftover `doPrivileged` call in the
> Currency test, _CheckDataVersion.java_.
Justin Lu has updated the pull request incrementally with one additional commit
since the last revision:
reflect review
-
Changes:
- all: https://git.openjdk.o
On Mon, 13 Jan 2025 21:38:04 GMT, Justin Lu wrote:
> Please review this PR which removes a leftover `doPrivileged` call in the
> Currency test, _CheckDataVersion.java_.
test/jdk/java/util/Currency/CheckDataVersion.java line 79:
> 77: } catch (IOException ioe) {
> 78:
Get IEEE 754 added as an external standard in JDK 24's docs too.
-
Commit messages:
- Backport 7c883c284de4fa1cb55f4fd4cf4dc9115bee5e65
Changes: https://git.openjdk.org/jdk/pull/23091/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=23091&range=00
Issue: https://bugs.openj
Sort services provided by a module to ensure reproduce same result.
-
Commit messages:
- 8347376: tools/jlink/runtimeImage/JavaSEReproducibleTest.java and
PackagedModulesVsRuntimeImageLinkTest.java failed after JDK-8321413
Changes: https://git.openjdk.org/jdk/pull/23088/files
Web
Please review this PR which removes a leftover `doPrivileged` call in the
Currency test, _CheckDataVersion.java_.
-
Commit messages:
- init
Changes: https://git.openjdk.org/jdk/pull/23087/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=23087&range=00
Issue: https://bugs.
On Mon, 13 Jan 2025 08:14:08 GMT, Adam Sotona wrote:
>> There are no more consumers of ASM library except for hotspot tests.
>> This patch moves ASM library from java.base module to the hotspot test
>> libraries location and fixes the tests.
>>
>> Please review.
>>
>> Thanks,
>> Adam
>
> Adam
Oh hey, I named those Guava methods. :-) This was my attempt to promote the
terms “position indexes vs. element indexes” and hope that the idea caught
on... which I’d say it still never has. I’m surprised you even noticed the
methods.
The notion is that “element indexes” are the buckets and “po
On Sat, 28 Dec 2024 18:43:30 GMT, Martin Doerr wrote:
> [JDK-8317545](https://bugs.openjdk.org/browse/JDK-8317545) introduced code
> for supporting 4 Byte aligned doubles:
> https://github.com/openjdk/jdk/blob/60e0730a3ba26180d0eb2cd278e389c3e70fec5f/src/java.base/share/classes/jdk/internal/for
On Fri, 20 Dec 2024 13:11:15 GMT, Magnus Ihse Bursie wrote:
>> make/common/modules/LauncherCommon.gmk line 162:
>>
>>> 160: -framework ApplicationServices \
>>> 161: -framework Cocoa \
>>> 162: -framework Security, \
>>
>> What happened to all of these? Were they n
On Mon, 13 Jan 2025 17:28:33 GMT, Joe Darcy wrote:
> Redo the work done in JDK-8285977 to use the `@spec` tag so that the IEEE
> floating-point standard gets listed as one of the external specifications.
This pull request has now been integrated.
Changeset: 7c883c28
Author:Joe Darcy
URL:
On Fri, 10 Jan 2025 23:05:13 GMT, Naoto Sato wrote:
> The use of [three-letter time zone
> IDs](https://download.java.net/java/early_access/jdk24/docs/api/java.base/java/util/TimeZone.html#three-letter-time-zone-ids-heading)
> has long been deprecated. For their actual removal in the future, ma
Currently the java.util.Objects provide the method `checkIndex(int, int)`
for checking indexes.
It is convenient, but cannot be used to implement methods such as
List::add(int, E) because these methods accept an index pointing to the end
of the collection.
So is it possible to add a new method to O
On Mon, 13 Jan 2025 12:59:06 GMT, Viktor Klang wrote:
> Backport to jdk24 of https://bugs.openjdk.org/browse/JDK-8347274
Does this fix the OOM problem?
import java.util.stream.Gatherers;
import java.util.stream.IntStream;
/**
* TODO: description of this file
*
* @author 虎鸣
*/
public class
On Fri, 10 Jan 2025 23:05:13 GMT, Naoto Sato wrote:
> The use of [three-letter time zone
> IDs](https://download.java.net/java/early_access/jdk24/docs/api/java.base/java/util/TimeZone.html#three-letter-time-zone-ids-heading)
> has long been deprecated. For their actual removal in the future, ma
The use of [three-letter time zone
IDs](https://download.java.net/java/early_access/jdk24/docs/api/java.base/java/util/TimeZone.html#three-letter-time-zone-ids-heading)
has long been deprecated. For their actual removal in the future, making the
runtime emit warnings for using those IDs would be
On Mon, 13 Jan 2025 16:28:52 GMT, Viktor Klang wrote:
> Seems sensible to improve this given that it can be tricky to figure out
> which parameter caused the exception to be thrown.
https://github.com/openjdk/jdk/pull/23050
There is already a pr for this:)
As I encountered this in production
On Mon, 13 Jan 2025 18:19:59 GMT, Henry Jen wrote:
>> Improving option value handling to support passing argument value starts
>> with "--".
>>
>> Before the fix, in following example, --add-modules will be considered as
>> another option for JLink instead of argument value for --add-options.
On Mon, 13 Jan 2025 11:29:06 GMT, Christian Stein wrote:
>> Please review this change request enabling native access in source launch
>> mode when using a modular setup.
>>
>> The change comes in two parts:
>> 1. Prevent warnings of unknown modules being emitted from module bootstrap
>> for us
On Mon, 13 Jan 2025 16:28:52 GMT, Viktor Klang wrote:
> Seems sensible to improve this given that it can be tricky to figure out
> which parameter caused the exception to be thrown.
There's a contributor PR from the java bugs submitter at
https://github.com/openjdk/jdk/pull/23050, I wonder wha
> Improving option value handling to support passing argument value starts with
> "--".
>
> Before the fix, in following example, --add-modules will be considered as
> another option for JLink instead of argument value for --add-options.
> --add-options --add-modules=jdk.incubator.concurrent
> -
On Thu, 9 Jan 2025 00:27:15 GMT, Brian Burkhalter wrote:
> Change the test as done in #22957 for
> [JDK-8346671](https://bugs.openjdk.org/browse/JDK-8346671).
This pull request has now been integrated.
Changeset: b0c131e8
Author:Brian Burkhalter
URL:
https://git.openjdk.org/jdk/com
On Thu, 9 Jan 2025 00:27:15 GMT, Brian Burkhalter wrote:
> Change the test as done in #22957 for
> [JDK-8346671](https://bugs.openjdk.org/browse/JDK-8346671).
Change verified by "faking" OS name in the test.
-
PR Comment: https://git.openjdk.org/jdk/pull/22994#issuecomment-2587845
On Mon, 13 Jan 2025 16:28:52 GMT, Viktor Klang wrote:
> Seems sensible to improve this given that it can be tricky to figure out
> which parameter caused the exception to be thrown.
Looks fine, just wondering if the tests for IAE should check there is a message.
-
Marked as review
On Mon, 13 Jan 2025 17:28:33 GMT, Joe Darcy wrote:
> Redo the work done in JDK-8285977 to use the `@spec` tag so that the IEEE
> floating-point standard gets listed as one of the external specifications.
Marked as reviewed by iris (Reviewer).
-
PR Review: https://git.openjdk.org/j
On Mon, 13 Jan 2025 17:28:33 GMT, Joe Darcy wrote:
> Redo the work done in JDK-8285977 to use the `@spec` tag so that the IEEE
> floating-point standard gets listed as one of the external specifications.
Looks fine.
-
Marked as reviewed by bpb (Reviewer).
PR Review: https://git.o
Redo the work done in JDK-8285977 to use the `@spec` tag so that the IEEE
floating-point standard gets listed as one of the external specifications.
-
Commit messages:
- JDK-8347605: Use spec tag to refer to IEEE 754 standard
Changes: https://git.openjdk.org/jdk/pull/23082/files
> This patch intrinsifies `Math.max(long, long)` and `Math.min(long, long)` in
> order to help improve vectorization performance.
>
> Currently vectorization does not kick in for loops containing either of these
> calls because of the following error:
>
>
> VLoop::check_preconditions: failed:
On Fri, 10 Jan 2025 20:50:20 GMT, Chen Liang wrote:
> This is a non-clean backport of bcefab5e55d4527a38dcab550581a734c1564608,
> because afe543414f58a04832d4f07dea1d64954a0b which fixes a Javadoc link
> error was also included in this backport. This backports Javadoc
> improvements to th
On Fri, 10 Jan 2025 20:50:20 GMT, Chen Liang wrote:
> This is a non-clean backport of bcefab5e55d4527a38dcab550581a734c1564608,
> because afe543414f58a04832d4f07dea1d64954a0b which fixes a Javadoc link
> error was also included in this backport. This backports Javadoc
> improvements to th
On Fri, 10 Jan 2025 20:25:06 GMT, Chen Liang wrote:
>> Improve documentation for `class` file attributes. This include better
>> specification for user attributes, some more general information about
>> attributes, such as the usage of non-JVMS attributes, and updated some
>> attribute informa
On Mon, 13 Jan 2025 08:14:08 GMT, Adam Sotona wrote:
>> There are no more consumers of ASM library except for hotspot tests.
>> This patch moves ASM library from java.base module to the hotspot test
>> libraries location and fixes the tests.
>>
>> Please review.
>>
>> Thanks,
>> Adam
>
> Adam
On Mon, 13 Jan 2025 09:02:24 GMT, Jatin Bhateja wrote:
>> Uncertain on what bits, but i am guessing it's mostly related to the
>> fallback code in the lambda. To avoid the intrinsics operating on Float16
>> instances we instead "unpack" the carrier (16bits) values and pass those as
>> argument
On Mon, 13 Jan 2025 16:28:52 GMT, Viktor Klang wrote:
> Seems sensible to improve this given that it can be tricky to figure out
> which parameter caused the exception to be thrown.
Thanks for doing this. Looks good to me.
-
PR Comment: https://git.openjdk.org/jdk/pull/23081#issue
On Wed, 18 Dec 2024 15:00:13 GMT, Roger Riggs wrote:
> SM Cleanup of common test library test/lib/...:
>
> Remove unnecessary catches of SecurityException
> Remove AccessController and doPrivileged from SimpleSSLContext and
> ProcessTools.
This pull request has now been integrated.
Changeset:
Seems sensible to improve this given that it can be tricky to figure out which
parameter caused the exception to be thrown.
-
Commit messages:
- Addresses IAE and NPE messages for ThreadPoolExecutor
Changes: https://git.openjdk.org/jdk/pull/23081/files
Webrev: https://webrevs.ope
On Mon, 13 Jan 2025 16:28:52 GMT, Viktor Klang wrote:
> Seems sensible to improve this given that it can be tricky to figure out
> which parameter caused the exception to be thrown.
@DougLea This is the PR I was talking about earlier today.
-
PR Comment: https://git.openjdk.org/jd
On Mon, 16 Dec 2024 12:47:13 GMT, SendaoYan wrote:
>> Hi all,
>> The file src/java.base/share/native/libjli/java.c generate compile warning
>> by gcc14 with gcc options `-fsanitize=undefined -O2`, and make jdk build
>> error when configure with option `--enable-ubsan`. So I think it's necessor
On Mon, 13 Jan 2025 08:14:08 GMT, Adam Sotona wrote:
>> There are no more consumers of ASM library except for hotspot tests.
>> This patch moves ASM library from java.base module to the hotspot test
>> libraries location and fixes the tests.
>>
>> Please review.
>>
>> Thanks,
>> Adam
>
> Adam
On Thu, 9 Jan 2025 12:18:48 GMT, Emanuel Peter wrote:
>> @eme64 aarch64 work for this is now complete. I tweaked the `applyIf`
>> condition `MinMaxRed_Long` to make sure `MaxVectorSize` is 32 or higher. I
>> verified this on both Graviton 3 (256 bit register, `MaxVectorSize=32`) and
>> an AVX-
On Mon, 16 Dec 2024 12:47:13 GMT, SendaoYan wrote:
>> Hi all,
>> The file src/java.base/share/native/libjli/java.c generate compile warning
>> by gcc14 with gcc options `-fsanitize=undefined -O2`, and make jdk build
>> error when configure with option `--enable-ubsan`. So I think it's necessor
On Thu, 9 Jan 2025 12:18:48 GMT, Emanuel Peter wrote:
>> @eme64 aarch64 work for this is now complete. I tweaked the `applyIf`
>> condition `MinMaxRed_Long` to make sure `MaxVectorSize` is 32 or higher. I
>> verified this on both Graviton 3 (256 bit register, `MaxVectorSize=32`) and
>> an AVX-
On Mon, 13 Jan 2025 12:59:06 GMT, Viktor Klang wrote:
> Backport to jdk24 of https://bugs.openjdk.org/browse/JDK-8347274
Marked as reviewed by alanb (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/23068#pullrequestreview-2546813506
On Mon, 13 Jan 2025 13:24:10 GMT, Alan Bateman wrote:
>> Backport to jdk24 of https://bugs.openjdk.org/browse/JDK-8347274
>
> Did you use "/backport" or is this a manual back port?
@AlanBateman I did a manual backport since there was a merge conflict (on the
copyright notice change).
-
On Mon, 13 Jan 2025 10:47:41 GMT, Severin Gehwolf wrote:
>> (Getting into marginal returns on comments here, so my apologies for
>> nitpicking)
>>
>> The loop could be simplified even further...
>>
>> while (true) {
>> int bytesRead1 = is1.readNBytes(buf1, 0, buf1.length);
>> int bytes
On Sat, 28 Dec 2024 18:43:30 GMT, Martin Doerr wrote:
> [JDK-8317545](https://bugs.openjdk.org/browse/JDK-8317545) introduced code
> for supporting 4 Byte aligned doubles:
> https://github.com/openjdk/jdk/blob/60e0730a3ba26180d0eb2cd278e389c3e70fec5f/src/java.base/share/classes/jdk/internal/for
On Sat, 28 Dec 2024 18:43:30 GMT, Martin Doerr wrote:
> [JDK-8317545](https://bugs.openjdk.org/browse/JDK-8317545) introduced code
> for supporting 4 Byte aligned doubles:
> https://github.com/openjdk/jdk/blob/60e0730a3ba26180d0eb2cd278e389c3e70fec5f/src/java.base/share/classes/jdk/internal/for
On Mon, 13 Jan 2025 13:58:43 GMT, Matthias Baesken wrote:
> looks okay, guess you have to adjust the COPYRIGHT year now to 2025 .
Only if I make more modifications. No files were changed in 2025. The update
script says "No files were changed".
But, thanks for the review!
-
PR Comm
On Sat, 28 Dec 2024 18:43:30 GMT, Martin Doerr wrote:
> [JDK-8317545](https://bugs.openjdk.org/browse/JDK-8317545) introduced code
> for supporting 4 Byte aligned doubles:
> https://github.com/openjdk/jdk/blob/60e0730a3ba26180d0eb2cd278e389c3e70fec5f/src/java.base/share/classes/jdk/internal/for
On Mon, 13 Jan 2025 12:59:06 GMT, Viktor Klang wrote:
> Backport to jdk24 of https://bugs.openjdk.org/browse/JDK-8347274
Did you use "/backport" or is this a manual back port?
-
PR Comment: https://git.openjdk.org/jdk/pull/23068#issuecomment-2587096942
On Mon, 13 Jan 2025 08:14:08 GMT, Adam Sotona wrote:
>> There are no more consumers of ASM library except for hotspot tests.
>> This patch moves ASM library from java.base module to the hotspot test
>> libraries location and fixes the tests.
>>
>> Please review.
>>
>> Thanks,
>> Adam
>
> Adam
On Thu, 5 Dec 2024 18:44:06 GMT, Brian Burkhalter wrote:
>> This proposed change would move the native objects required for NIO file
>> interaction from the libnio native library to the libjava native library on
>> Linux, macOS, and Windows.
>
> Brian Burkhalter has updated the pull request wit
Backport to jdk24 of https://bugs.openjdk.org/browse/JDK-8347274
-
Commit messages:
- 8347274: Gatherers.mapConcurrent exhibits undesired behavior under variable
delays, interruption, and finishing
Changes: https://git.openjdk.org/jdk/pull/23068/files
Webrev: https://webrevs.open
On Thu, 12 Sep 2024 15:43:32 GMT, Alan Bateman wrote:
>>> Thanks for making the changes. LGTM, assuming that tests still pass.
>>
>> The tests passed the JDK tiers 1-3 tests on Linux, macOS, and Windows. In
>> any case, I will run another round of tests before integrating.
>
>> The tests passed
On Tue, 17 Dec 2024 15:41:51 GMT, Magnus Ihse Bursie wrote:
> When the static launcher was introduced in
> [JDK-8339480](https://bugs.openjdk.org/browse/JDK-8339480), due to time and
> resource constraints, it was only working properly on Linux and macOS, while
> the Windows port compiled but
On Thu, 12 Sep 2024 15:43:32 GMT, Alan Bateman wrote:
>>> Thanks for making the changes. LGTM, assuming that tests still pass.
>>
>> The tests passed the JDK tiers 1-3 tests on Linux, macOS, and Windows. In
>> any case, I will run another round of tests before integrating.
>
>> The tests passed
On Mon, 13 Jan 2025 07:52:08 GMT, Adam Sotona wrote:
> Is there a way to pre-compile a test library and point related tests (or
> maybe all hotspot tests) to the library jar?
My initial thought was just to add the jar to the classpath, but maybe it is
better to use an explicit `@library` tag.
On Wed, 8 Jan 2025 20:29:03 GMT, Christian Stein wrote:
>> Please review this change request enabling native access in source launch
>> mode when using a modular setup.
>>
>> The change comes in two parts:
>> 1. Prevent warnings of unknown modules being emitted from module bootstrap
>> for use
> Please review this change request enabling native access in source launch
> mode when using a modular setup.
>
> The change comes in two parts:
> 1. Prevent warnings of unknown modules being emitted from module bootstrap
> for user module not being present in the boot layer: `java.c` and
> `M
On Wed, 8 Jan 2025 20:29:03 GMT, Christian Stein wrote:
>> Please review this change request enabling native access in source launch
>> mode when using a modular setup.
>>
>> The change comes in two parts:
>> 1. Prevent warnings of unknown modules being emitted from module bootstrap
>> for use
On Mon, 13 Jan 2025 10:11:27 GMT, Per Minborg wrote:
>> Going forward, converting older JDK code to use the relatively new FFM API
>> requires system calls that can provide `errno` and the likes to explicitly
>> allocate a MemorySegment to capture potential error states. This can lead to
>> ne
> Going forward, converting older JDK code to use the relatively new FFM API
> requires system calls that can provide `errno` and the likes to explicitly
> allocate a MemorySegment to capture potential error states. This can lead to
> negative performance implications if not designed carefully a
On Thu, 9 Jan 2025 19:39:34 GMT, Archie Cobbs wrote:
>> Severin Gehwolf has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Review feedback
>
> (Getting into marginal returns on comments here, so my apologies for
> nitpicking)
>
> The loop
On Thu, 9 Jan 2025 10:13:52 GMT, Viktor Klang wrote:
> The following patch updates Gatherers.mapConcurrent to limit work-in-progress
> (on-going and completed-unpushed) to the `maxConcurrency` so that
> head-of-line blocking does not cause completed-unpushed work to grow
> unbounded.
>
> This
On Fri, 10 Jan 2025 09:41:34 GMT, Alan Bateman wrote:
>> Per Minborg has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Clean up benchmark
>> - Fix allocation problem in benchmark
>
> src/java.base/share/classes/jdk/internal/foreign/Capt
> Going forward, converting older JDK code to use the relatively new FFM API
> requires system calls that can provide `errno` and the likes to explicitly
> allocate a MemorySegment to capture potential error states. This can lead to
> negative performance implications if not designed carefully a
> Going forward, converting older JDK code to use the relatively new FFM API
> requires system calls that can provide `errno` and the likes to explicitly
> allocate a MemorySegment to capture potential error states. This can lead to
> negative performance implications if not designed carefully a
On Mon, 9 Dec 2024 12:57:22 GMT, Severin Gehwolf wrote:
> Please review these changes to jpackage in light of [JEP
> 493](https://openjdk.org/jeps/493). When this feature is enabled, then some
> of the `jpackage` tests fail. The failures fall into the following categories:
>
> - `ALL-DEFAULT`
On Thu, 9 Jan 2025 19:22:35 GMT, Paul Sandoz wrote:
>> src/jdk.incubator.vector/share/classes/jdk/incubator/vector/Float16.java
>> line 1434:
>>
>>> 1432: return float16ToRawShortBits(valueOf(product +
>>> float16ToFloat(f16c)));
>>> 1433: });
>>> 1434:
On Thu, 9 Jan 2025 13:13:30 GMT, Emanuel Peter wrote:
>> Jatin Bhateja has refreshed the contents of this pull request, and previous
>> commits have been removed. The incremental views will show differences
>> compared to the previous content of the PR. The pull request contains one
>> new com
> Hi All,
>
> This patch adds C2 compiler support for various Float16 operations added by
> [PR#22128](https://github.com/openjdk/jdk/pull/22128)
>
> Following is the summary of changes included with this patch:-
>
> 1. Detection of various Float16 operations through inline expansion or
> patt
1 - 100 of 105 matches
Mail list logo
