Re: RFR: 8346986: Remove ASM from java.base [v7]

2025-01-12 Thread Adam Sotona
On Mon, 13 Jan 2025 07:40:06 GMT, Adam Sotona wrote: >> There are no more consumers of ASM library except for hotspot tests. >> This patch moves ASM library from java.base module to the hotspot test >> libraries location and fixes the tests. >> >> Please review. >> >> Thanks, >> Adam > > Adam

Integrated: 8347270: Remove unix_getParentPidAndTimings, unix_getChildren and unix_getCmdlineAndUserInfo

2025-01-12 Thread Matthias Baesken
On Thu, 9 Jan 2025 16:47:18 GMT, Matthias Baesken wrote: > The functions unix_getParentPidAndTimings and unix_getCmdlineAndUserInfo in > src/java.base/unix/native/libjava/ProcessHandleImpl_unix.c used to hold an > implementation that was shared between Solaris and AIX. Linux and MacOS > alread

Re: RFR: 8347270: Remove unix_getParentPidAndTimings, unix_getChildren and unix_getCmdlineAndUserInfo [v3]

2025-01-12 Thread Matthias Baesken
On Fri, 10 Jan 2025 11:22:31 GMT, Matthias Baesken wrote: >> The functions unix_getParentPidAndTimings and unix_getCmdlineAndUserInfo in >> src/java.base/unix/native/libjava/ProcessHandleImpl_unix.c used to hold an >> implementation that was shared between Solaris and AIX. Linux and MacOS >> a

Re: RFR: 8346986: Remove ASM from java.base [v7]

2025-01-12 Thread Adam Sotona
> There are no more consumers of ASM library except for hotspot tests. > This patch moves ASM library from java.base module to the hotspot test > libraries location and fixes the tests. > > Please review. > > Thanks, > Adam Adam Sotona has updated the pull request incrementally with one additio

Re: RFR: 8342466: Improve API documentation for java.lang.classfile.attribute [v2]

2025-01-12 Thread Adam Sotona
On Fri, 10 Jan 2025 20:25:06 GMT, Chen Liang wrote: >> Improve documentation for `class` file attributes. This include better >> specification for user attributes, some more general information about >> attributes, such as the usage of non-JVMS attributes, and updated some >> attribute informa

Re: RFR: 8346986: Remove ASM from java.base [v3]

2025-01-12 Thread Alan Bateman
On Fri, 10 Jan 2025 15:39:20 GMT, Adam Sotona wrote: >> Adam Sotona has updated the pull request incrementally with one additional >> commit since the last revision: >> >> removed jdk.internal package prefix from asm > > Thanks for the reviews. I'll update the copyright years and run again ti

Re: RFR: 8347124: Clean tests with --enable-linkable-runtime [v3]

2025-01-12 Thread David Holmes
On Thu, 9 Jan 2025 10:18:35 GMT, Severin Gehwolf wrote: >> Please review this trivial test-only patch in support of running tests on >> JEP 493 enabled builds. Both tests use the `ToolProvider` API so as to run >> `jlink` in-process of the test JVM which includes module patches (as in - >> use

Re: RFR: 8346986: Remove ASM from java.base [v6]

2025-01-12 Thread David Holmes
On Fri, 10 Jan 2025 16:12:54 GMT, Adam Sotona wrote: >> There are no more consumers of ASM library except for hotspot tests. >> This patch moves ASM library from java.base module to the hotspot test >> libraries location and fixes the tests. >> >> Please review. >> >> Thanks, >> Adam > > Adam

[jdk24] RFR: 8347302: Mark test tools/jimage/JImageToolTest.java as flagless

2025-01-12 Thread SendaoYan
Hi all, This pull request contains a backport of commit [e7e8f60c](https://github.com/openjdk/jdk/commit/e7e8f60c9bedd5622525cc4339300b438eedc9fd) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. Test test/jdk/tools/jimage/JImageToolTest.java ignore vm flags and should be marked

Re: RFR: 8342682: Errors related to unused code on Windows after 8339120 in dt_shmem jdwp security and jpackage [v7]

2025-01-12 Thread Julian Waters
On Mon, 11 Nov 2024 09:51:35 GMT, Julian Waters wrote: >> After 8339120, gcc began catching many different instances of unused code in >> the Windows specific codebase. Some of these seem to be bugs. I've taken the >> effort to mark out all the relevant globals and locals that trigger the >> u