On 13 Dec 2024, at 5:22, Raffaello Giulietti wrote:
> For your specific multiplication use case you might try with
>
> long high = Math.multiplyHigh(a, b);
> long low = a * b;
> if (high == 0) return low;
> return "the big integer consisting of high and low";
>
> It might be possible that the mult
On Fri, Jan 10, 2025 at 8:48 PM Charles Oliver Nutter
wrote:
> This pasted weirdly... but it doesn't matter because there's an additional
> flaw: it will reject *all* negative results because the high 64 bits will
> be non-zero.
>
This version passes all my tests:
if ((high == 0 && low >= 0) //
On Wed, 8 Jan 2025 00:40:04 GMT, Henry Jen wrote:
>> Improving option value handling to support passing argument value starts
>> with "--".
>>
>> Before the fix, in following example, --add-modules will be considered as
>> another option for JLink instead of argument value for --add-options.
>
On Fri, Jan 10, 2025 at 8:31 PM Charles Oliver Nutter
wrote:
> long high = Math.multiplyHigh(value, other);
> long low = value * other;
> if (high == 0 && low >= 0 || value < 0 || high == 0 && other < 0) {
> return asFixnum(context, low);
> }
>
This pasted weirdly... but it doesn't matter be
On Fri, Dec 13, 2024 at 7:22 AM Raffaello Giulietti <
raffaello.giulie...@oracle.com> wrote:
> long high = Math.multiplyHigh(a, b);
> long low = a * b;
> if (high == 0) return low;
> return "the big integer consisting of high and low";
>
There's a flaw in this logic: the overflowed multiplication
On Fri, 10 Jan 2025 17:10:03 GMT, Roger Riggs wrote:
>> SM Cleanup of common test library test/lib/...:
>>
>> Remove unnecessary catches of SecurityException
>> Remove AccessController and doPrivileged from SimpleSSLContext and
>> ProcessTools.
>
> Roger Riggs has updated the pull request incre
> The Type and AnnotatedType hierarchies have been enigmatic to new users:
> users have no clue how to categorize arbitrary type objects, when it is safe
> to cast to more specific types, and the exact conditions for method contracts.
>
> A manifest is [JDK-8306039](https://bugs.openjdk.org/brow
On Sun, 29 Dec 2024 01:06:36 GMT, Chen Liang wrote:
>> Chen Liang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Problems with owner type, kevin suggestions
>
> src/java.base/share/classes/java/lang/reflect/ParameterizedType.java line 1
On Mon, 6 Jan 2025 18:26:54 GMT, Chen Liang wrote:
> `javax.lang.model.SourceVersion` has a series of comments describing the new
> language features present in each source version. Similar comments for the
> `ClassFileFormatVersion` would be helpful, so readers no longer need to
> search thro
On Wed, 8 Jan 2025 05:51:12 GMT, Chen Liang wrote:
>> `javax.lang.model.SourceVersion` has a series of comments describing the new
>> language features present in each source version. Similar comments for the
>> `ClassFileFormatVersion` would be helpful, so readers no longer need to
>> search
On Thu, 9 Jan 2025 03:29:21 GMT, David Holmes wrote:
> > Joe and David, can you look at this updated versioning that uses the core
> > libraries since scheme?
>
> Yep that looks fine. Thanks.
I think it is fine it its current form, but would be better also listing the
class file format versio
On Wed, 8 Jan 2025 05:51:12 GMT, Chen Liang wrote:
>> `javax.lang.model.SourceVersion` has a series of comments describing the new
>> language features present in each source version. Similar comments for the
>> `ClassFileFormatVersion` would be helpful, so readers no longer need to
>> search
This is a non-clean backport of bcefab5e55d4527a38dcab550581a734c1564608,
because afe543414f58a04832d4f07dea1d64954a0b which fixes a Javadoc link
error was also included in this backport. This backports Javadoc improvements
to the ClassFile API committed to mainline back to 24, the finaliza
On Fri, 10 Jan 2025 20:25:06 GMT, Chen Liang wrote:
>> Improve documentation for `class` file attributes. This include better
>> specification for user attributes, some more general information about
>> attributes, such as the usage of non-JVMS attributes, and updated some
>> attribute informa
> Improve documentation for `class` file attributes. This include better
> specification for user attributes, some more general information about
> attributes, such as the usage of non-JVMS attributes, and updated some
> attribute information in the base package too, such as Annotation and
> Si
On Fri, 10 Jan 2025 12:15:33 GMT, Adam Sotona wrote:
>> Improve documentation for `class` file attributes. This include better
>> specification for user attributes, some more general information about
>> attributes, such as the usage of non-JVMS attributes, and updated some
>> attribute inform
On Wed, 8 Jan 2025 23:29:49 GMT, Alexey Semenyuk wrote:
> `JPackageCommand.ignoreFakeRuntime()` method mistakenly tests if Java runtime
> configured for the current jpackage command is a valid Java runtime.
>
> It must test the runtime configured for jpackage tests with
> `jdk.jpackage.test.ru
On Wed, 8 Jan 2025 23:45:53 GMT, Alexey Semenyuk wrote:
> Look up different patterns in WiX output based on the version of the WiX.
This pull request has now been integrated.
Changeset: 10f7142d
Author:Alexey Semenyuk
URL:
https://git.openjdk.org/jdk/commit/10f7142dce296fedbb4d94537
On Wed, 8 Jan 2025 22:29:04 GMT, Alexey Semenyuk wrote:
> - Don't remove the `PATH` variable from the environment when running app
> launchers in jpackage tests;
> - Fix tests that use `Executor` rather than `HelloApp` class to run app
> launchers: apply the same changes to the environment as w
On Thu, 19 Dec 2024 16:27:30 GMT, Magnus Ihse Bursie wrote:
> We need to raise the abstraction of the SetupBuildLauncher API, to prepare
> for static launchers. We should specify the desired outcome, not what flags
> we should add. This can be seen as the last part of
> [JDK-8141444](https://b
On Fri, 10 Jan 2025 11:22:31 GMT, Matthias Baesken wrote:
>> The functions unix_getParentPidAndTimings and unix_getCmdlineAndUserInfo in
>> src/java.base/unix/native/libjava/ProcessHandleImpl_unix.c used to hold an
>> implementation that was shared between Solaris and AIX. Linux and MacOS
>> a
On Thu, 9 Jan 2025 00:27:15 GMT, Brian Burkhalter wrote:
> Change the test as done in #22957 for
> [JDK-8346671](https://bugs.openjdk.org/browse/JDK-8346671).
Withholding integration until this change is verified on Windows Server 2025.
-
PR Comment: https://git.openjdk.org/jdk/pu
On Fri, 10 Jan 2025 11:22:31 GMT, Matthias Baesken wrote:
>> The functions unix_getParentPidAndTimings and unix_getCmdlineAndUserInfo in
>> src/java.base/unix/native/libjava/ProcessHandleImpl_unix.c used to hold an
>> implementation that was shared between Solaris and AIX. Linux and MacOS
>> a
> SM Cleanup of common test library test/lib/...:
>
> Remove unnecessary catches of SecurityException
> Remove AccessController and doPrivileged from SimpleSSLContext and
> ProcessTools.
Roger Riggs has updated the pull request incrementally with one additional
commit since the last revision:
On Fri, 10 Jan 2025 15:39:20 GMT, Adam Sotona wrote:
> Jtreg seems to have no problems to use ASM as a declared library.
Whan you say "no problems", I guess you are referring to the pass rate of the
tests. But how does it affect the runtime spent doing testing?
I must insist that "just moving"
On Thu, 9 Jan 2025 00:05:30 GMT, Leonid Mesnik wrote:
> Test
> test/jdk/tools/jimage/JImageToolTest.java
> ignore vm flags and should be marked as flagless.
>
> It is needed to don't try to run this test with virtual test thread factory.
This pull request has now been integrated.
Changeset: e7
On Fri, 10 Jan 2025 07:32:24 GMT, Chen Liang wrote:
> Improve documentation for `class` file attributes. This include better
> specification for user attributes, some more general information about
> attributes, such as the usage of non-JVMS attributes, and updated some
> attribute information
On Tue, 22 Oct 2024 19:29:43 GMT, Eirik Bjørsnøs wrote:
>> FWIW: I don't believe a change to a link in a comment in an internal class
>> requires a CSR.
>> For PortConfig.java - it would be good to have someone involved in the AIX
>> port comment on the proposed changes.
>> Removing the obsole
Hi,
I recently finished a deep-dive through the code in java.util.stream, and
came across a few corners that stuck out to me as being odd, in a "small
missed opportunity" kind of way. I figured I'd raise them here just in case
any are legitimate, or I could get some better insight. I am looking at
On Fri, 10 Jan 2025 16:06:32 GMT, Jaikiran Pai wrote:
> [...] retain the previous order and first check for the suffix and if it's
> not .java, only then do a stat system call.
I started with that oder (before
https://github.com/openjdk/jdk/pull/21910/commits/f0bd01d393a5d88e8b33723b7b4ca16379
> There are no more consumers of ASM library except for hotspot tests.
> This patch moves ASM library from java.base module to the hotspot test
> libraries location and fixes the tests.
>
> Please review.
>
> Thanks,
> Adam
Adam Sotona has updated the pull request incrementally with one additio
On Thu, 9 Jan 2025 09:20:51 GMT, Christian Stein wrote:
>> Please review this change that improves the launcher mode detection by
>> reading the initial two characters from the started file for being a shebang
>> script. It addresses the reported confusing error messages and also supports
>> m
> There are no more consumers of ASM library except for hotspot tests.
> This patch moves ASM library from java.base module to the hotspot test
> libraries location and fixes the tests.
>
> Please review.
>
> Thanks,
> Adam
Adam Sotona has updated the pull request incrementally with one additio
On Wed, 18 Dec 2024 21:07:14 GMT, Roger Riggs wrote:
>> SM Cleanup of common test library test/lib/...:
>>
>> Remove unnecessary catches of SecurityException
>> Remove AccessController and doPrivileged from SimpleSSLContext and
>> ProcessTools.
>
> Roger Riggs has updated the pull request incre
On Wed, 18 Dec 2024 21:07:14 GMT, Roger Riggs wrote:
>> SM Cleanup of common test library test/lib/...:
>>
>> Remove unnecessary catches of SecurityException
>> Remove AccessController and doPrivileged from SimpleSSLContext and
>> ProcessTools.
>
> Roger Riggs has updated the pull request incre
> There are no more consumers of ASM library except for hotspot tests.
> This patch moves ASM library from java.base module to the hotspot test
> libraries location and fixes the tests.
>
> Please review.
>
> Thanks,
> Adam
Adam Sotona has updated the pull request incrementally with one additio
On Thu, 9 Jan 2025 08:40:37 GMT, Adam Sotona wrote:
>> There are no more consumers of ASM library except for hotspot tests.
>> This patch moves ASM library from java.base module to the hotspot test
>> libraries location and fixes the tests.
>>
>> Please review.
>>
>> Thanks,
>> Adam
>
> Adam S
> Going forward, converting older JDK code to use the relatively new FFM API
> requires system calls that can provide `errno` and the likes to explicitly
> allocate a MemorySegment to capture potential error states. This can lead to
> negative performance implications if not designed carefully a
> During code review of
> [JDK-8346239](https://bugs.openjdk.org/browse/JDK-8346239) a few comments
> were made after the PR integrated. This follow-up patch cleans this up and
> adds a unit test for the `JimageDiffGenerator` class.
>
> Testing:
> - [x] GHA
> - [x] tools/jlink tests (including
> Please review this fix for cgroups-based metrics reporting in the
> `jdk.internal.platform` package. This fix is supposed to address wrong
> reporting of certain limits if the limits aren't set at the leaf nodes.
>
> For example, on cg v2, the memory limit interface file is `memory.max`.
> Co
On Fri, 10 Jan 2025 07:30:04 GMT, Peter Levart wrote:
> [JDK-8169880](https://bugs.openjdk.org/browse/JDK-8169880) removed a
> debugging option to disable caching of reflective data in java.lang.Class,
> which had a consequence that now Class#reflectiveData method guarantees to
> return a non-
On Fri, 10 Jan 2025 13:14:36 GMT, Sean Mullan wrote:
>> src/java.base/share/classes/jdk/internal/jimage/BasicImageReader.java line
>> 112:
>>
>>> 110: opts.add(StandardOpenOption.READ);
>>> 111: // No lambdas during bootstrap
>>> 112: AccessController.doPrivi
On Fri, 10 Jan 2025 08:22:37 GMT, Chen Liang wrote:
>> Here is a fix for https://bugs.openjdk.org/browse/JDK-8316882.
>>
>> Following discussion in nio-dev a while ago, I have opted to add a new
>> `NOT_INTERRUPTIBLE` open option, superseding
>> `FileChannelImpl#setUninterruptible`.
>
> src/ja
On Thu, 9 Jan 2025 08:40:37 GMT, Adam Sotona wrote:
>> There are no more consumers of ASM library except for hotspot tests.
>> This patch moves ASM library from java.base module to the hotspot test
>> libraries location and fixes the tests.
>>
>> Please review.
>>
>> Thanks,
>> Adam
>
> Adam S
> The functions unix_getParentPidAndTimings and unix_getCmdlineAndUserInfo in
> src/java.base/unix/native/libjava/ProcessHandleImpl_unix.c used to hold an
> implementation that was shared between Solaris and AIX. Linux and MacOS
> already had specific implementations. After the removal of the So
On Thu, 9 Jan 2025 20:16:16 GMT, Christian Stein wrote:
> I cannot think of any other useful options in addition to the ones handled in
> [RelevantJavacOptions.java](https://github.com/openjdk/jdk/blob/master/src/jdk.compiler/share/classes/com/sun/tools/javac/launcher/RelevantJavacOptions.java)
On Wed, 8 Jan 2025 20:29:03 GMT, Christian Stein wrote:
>> Please review this change request enabling native access in source launch
>> mode when using a modular setup.
>>
>> The change comes in two parts:
>> 1. Prevent warnings of unknown modules being emitted from module bootstrap
>> for use
On Fri, 10 Jan 2025 10:43:24 GMT, Matthias Baesken wrote:
> Hi Christoph, I adjusted the COPYRIGHT info and removed unix_getChildren .
> Regarding 'Solaris' mentioning in this file , I removed that one too but a
> grep shows there are plenty of Solaris comments etc. in the codebase.
Looks good
On Fri, 10 Jan 2025 10:43:35 GMT, Matthias Baesken wrote:
>> The functions unix_getParentPidAndTimings and unix_getCmdlineAndUserInfo in
>> src/java.base/unix/native/libjava/ProcessHandleImpl_unix.c used to hold an
>> implementation that was shared between Solaris and AIX. Linux and MacOS
>> a
> Going forward, converting older JDK code to use the relatively new FFM API
> requires system calls that can provide `errno` and the likes to explicitly
> allocate a MemorySegment to capture potential error states. This can lead to
> negative performance implications if not designed carefully a
On Thu, 9 Jan 2025 16:47:18 GMT, Matthias Baesken wrote:
> The functions unix_getParentPidAndTimings and unix_getCmdlineAndUserInfo in
> src/java.base/unix/native/libjava/ProcessHandleImpl_unix.c used to hold an
> implementation that was shared between Solaris and AIX. Linux and MacOS
> alread
> The functions unix_getParentPidAndTimings and unix_getCmdlineAndUserInfo in
> src/java.base/unix/native/libjava/ProcessHandleImpl_unix.c used to hold an
> implementation that was shared between Solaris and AIX. Linux and MacOS
> already had specific implementations. After the removal of the So
On Thu, 9 Jan 2025 15:43:59 GMT, Viktor Klang wrote:
>> src/java.base/share/classes/java/util/stream/Gatherers.java line 392:
>>
>>> 390: while (proceed
>>> 391: && (current = wip.peekFirst()) != null
>>> 392: && (current.isDone
On Thu, 9 Jan 2025 15:46:56 GMT, Viktor Klang wrote:
>> The following patch updates Gatherers.mapConcurrent to limit
>> work-in-progress (on-going and completed-unpushed) to the `maxConcurrency`
>> so that head-of-line blocking does not cause completed-unpushed work to grow
>> unbounded.
>>
>
On Wed, 8 Jan 2025 00:40:04 GMT, Henry Jen wrote:
>> Improving option value handling to support passing argument value starts
>> with "--".
>>
>> Before the fix, in following example, --add-modules will be considered as
>> another option for JLink instead of argument value for --add-options.
>
On Thu, 9 Jan 2025 18:51:09 GMT, Henry Jen wrote:
>> Severin Gehwolf has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Review feedback
>
> src/jdk.jlink/share/classes/jdk/tools/jlink/internal/runtimelink/JimageDiffGenerator.java
> line 13
On Thu, 9 Jan 2025 19:39:34 GMT, Archie Cobbs wrote:
> The loop could be simplified even further...
Done it the latest update.
-
PR Comment: https://git.openjdk.org/jdk/pull/23014#issuecomment-2582276780
> During code review of
> [JDK-8346239](https://bugs.openjdk.org/browse/JDK-8346239) a few comments
> were made after the PR integrated. This follow-up patch cleans this up and
> adds a unit test for the `JimageDiffGenerator` class.
>
> Testing:
> - [x] GHA
> - [x] tools/jlink tests (including
On Wed, 8 Jan 2025 14:24:25 GMT, Severin Gehwolf wrote:
> Please review this trivial test-only patch in support of running tests on JEP
> 493 enabled builds. Both tests use the `ToolProvider` API so as to run
> `jlink` in-process of the test JVM which includes module patches (as in -
> uses `-
On Thu, 9 Jan 2025 10:18:35 GMT, Severin Gehwolf wrote:
>> Please review this trivial test-only patch in support of running tests on
>> JEP 493 enabled builds. Both tests use the `ToolProvider` API so as to run
>> `jlink` in-process of the test JVM which includes module patches (as in -
>> use
On Tue, 26 Nov 2024 15:04:51 GMT, Per Minborg wrote:
> Going forward, converting older JDK code to use the relatively new FFM API
> requires system calls that can provide `errno` and the likes to explicitly
> allocate a MemorySegment to capture potential error states. This can lead to
> negati
On Fri, 10 Jan 2025 08:28:58 GMT, Peter Levart wrote:
>> [JDK-8169880](https://bugs.openjdk.org/browse/JDK-8169880) removed a
>> debugging option to disable caching of reflective data in java.lang.Class,
>> which had a consequence that now Class#reflectiveData method guarantees to
>> return a
Going forward, converting older JDK code to use the relatively new FFM API
requires system calls that can provide `errno` and the likes to explicitly
allocate a MemorySegment to capture potential error states. This can lead to
negative performance implications if not designed carefully and also
On Tue, 26 Nov 2024 15:04:51 GMT, Per Minborg wrote:
> Going forward, converting older JDK code to use the relatively new FFM API
> requires system calls that can provide `errno` and the likes to explicitly
> allocate a MemorySegment to capture potential error states. This can lead to
> negati
On Fri, 10 Jan 2025 08:28:58 GMT, Peter Levart wrote:
>> [JDK-8169880](https://bugs.openjdk.org/browse/JDK-8169880) removed a
>> debugging option to disable caching of reflective data in java.lang.Class,
>> which had a consequence that now Class#reflectiveData method guarantees to
>> return a
On Wed, 18 Dec 2024 21:07:14 GMT, Roger Riggs wrote:
>> SM Cleanup of common test library test/lib/...:
>>
>> Remove unnecessary catches of SecurityException
>> Remove AccessController and doPrivileged from SimpleSSLContext and
>> ProcessTools.
>
> Roger Riggs has updated the pull request incre
On Thu, 9 Jan 2025 09:20:51 GMT, Christian Stein wrote:
>> Please review this change that improves the launcher mode detection by
>> reading the initial two characters from the started file for being a shebang
>> script. It addresses the reported confusing error messages and also supports
>> m
> [JDK-8169880](https://bugs.openjdk.org/browse/JDK-8169880) removed a
> debugging option to disable caching of reflective data in java.lang.Class,
> which had a consequence that now Class#reflectiveData method guarantees to
> return a non-null result. Existing callers of that method were left i
On Wed, 25 Dec 2024 23:55:18 GMT, Bruno Ploumhans wrote:
> Here is a fix for https://bugs.openjdk.org/browse/JDK-8316882.
>
> Following discussion in nio-dev a while ago, I have opted to add a new
> `NOT_INTERRUPTIBLE` open option, superseding
> `FileChannelImpl#setUninterruptible`.
src/java.
On Fri, 10 Jan 2025 07:30:04 GMT, Peter Levart wrote:
> [JDK-8169880](https://bugs.openjdk.org/browse/JDK-8169880) removed a
> debugging option to disable caching of reflective data in java.lang.Class,
> which had a consequence that now Class#reflectiveData method guarantees to
> return a non-
70 matches
Mail list logo
