Improve documentation for `class` file attributes. This include better
specification for user attributes, some more general information about
attributes, such as the usage of non-JVMS attributes, and updated some
attribute information in the base package too, such as Annotation and Signature.
A
[JDK-8169880](https://bugs.openjdk.org/browse/JDK-8169880) removed a debugging
option to disable caching of reflective data in java.lang.Class, which had a
consequence that now Class#reflectiveData method guarantees to return a
non-null result. Existing callers of that method were left intact an
On Thu, 9 Jan 2025 16:47:18 GMT, Matthias Baesken wrote:
> The functions unix_getParentPidAndTimings and unix_getCmdlineAndUserInfo in
> src/java.base/unix/native/libjava/ProcessHandleImpl_unix.c used to hold an
> implementation that was shared between Solaris and AIX. Linux and MacOS
> alread
On Thu, 9 Jan 2025 22:44:15 GMT, Naoto Sato wrote:
>> A simple refinement to the test makes diagnosing failures easier.
>
> Naoto Sato has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Addresses review comments
Marked as reviewed by jlu (Com
On Thu, 9 Jan 2025 21:43:57 GMT, Justin Lu wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Addresses review comments
>
> test/jdk/tools/jlink/plugins/IncludeLocalesPluginTest.java line 417:
>
>> 415: helper
> A simple refinement to the test makes diagnosing failures easier.
Naoto Sato has updated the pull request incrementally with one additional
commit since the last revision:
Addresses review comments
-
Changes:
- all: https://git.openjdk.org/jdk/pull/23016/files
- new: https:
On Wed, 8 Jan 2025 23:45:53 GMT, Alexey Semenyuk wrote:
> Look up different patterns in WiX output based on the version of the WiX.
Looks good.
-
Marked as reviewed by almatvee (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/22989#pullrequestreview-2541076743
On Thu, 9 Jan 2025 18:28:19 GMT, Naoto Sato wrote:
> A simple refinement to the test makes diagnosing failures easier.
Looked through the changes and the swap to a JUnit ParameterizedTest looks good
to me.
test/jdk/tools/jlink/plugins/IncludeLocalesPluginTest.java line 417:
> 415: hel
On Thu, 9 Jan 2025 08:40:37 GMT, Adam Sotona wrote:
>> There are no more consumers of ASM library except for hotspot tests.
>> This patch moves ASM library from java.base module to the hotspot test
>> libraries location and fixes the tests.
>>
>> Please review.
>>
>> Thanks,
>> Adam
>
> Adam S
On Thu, 9 Jan 2025 08:40:37 GMT, Adam Sotona wrote:
>> There are no more consumers of ASM library except for hotspot tests.
>> This patch moves ASM library from java.base module to the hotspot test
>> libraries location and fixes the tests.
>>
>> Please review.
>>
>> Thanks,
>> Adam
>
> Adam S
On Thu, 9 Jan 2025 08:40:37 GMT, Adam Sotona wrote:
>> There are no more consumers of ASM library except for hotspot tests.
>> This patch moves ASM library from java.base module to the hotspot test
>> libraries location and fixes the tests.
>>
>> Please review.
>>
>> Thanks,
>> Adam
>
> Adam S
On Thu, 9 Jan 2025 08:40:37 GMT, Adam Sotona wrote:
>> There are no more consumers of ASM library except for hotspot tests.
>> This patch moves ASM library from java.base module to the hotspot test
>> libraries location and fixes the tests.
>>
>> Please review.
>>
>> Thanks,
>> Adam
>
> Adam S
On Thu, 9 Jan 2025 20:06:49 GMT, Alan Bateman wrote:
> Do you expect any other options that the source launcher might need to
> handle? Right now, there are warnings when the module or package name is not
> in modules in the boot layer. There other CLI options would be very advanced
> so assum
On Thu, 9 Jan 2025 00:27:15 GMT, Brian Burkhalter wrote:
> Change the test as done in #22957 for
> [JDK-8346671](https://bugs.openjdk.org/browse/JDK-8346671).
Marked as reviewed by lancea (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/22994#pullrequestreview-2540788054
On Thu, 9 Jan 2025 18:25:16 GMT, Severin Gehwolf wrote:
>> During code review of
>> [JDK-8346239](https://bugs.openjdk.org/browse/JDK-8346239) a few comments
>> were made after the PR integrated. This follow-up patch cleans this up and
>> adds a unit test for the `JimageDiffGenerator` class.
>
On Thu, 9 Jan 2025 13:23:19 GMT, Emanuel Peter wrote:
>> Jatin Bhateja has refreshed the contents of this pull request, and previous
>> commits have been removed. The incremental views will show differences
>> compared to the previous content of the PR. The pull request contains one
>> new com
On Thu, 9 Jan 2025 18:25:16 GMT, Severin Gehwolf wrote:
>> During code review of
>> [JDK-8346239](https://bugs.openjdk.org/browse/JDK-8346239) a few comments
>> were made after the PR integrated. This follow-up patch cleans this up and
>> adds a unit test for the `JimageDiffGenerator` class.
>
A simple refinement to the test makes diagnosing failures easier.
-
Commit messages:
- initial commit
Changes: https://git.openjdk.org/jdk/pull/23016/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=23016&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8347146
Stats:
On Thu, 9 Jan 2025 17:49:23 GMT, Henry Jen wrote:
>> Severin Gehwolf has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Review feedback
>
> src/jdk.jlink/share/classes/jdk/tools/jlink/internal/runtimelink/JimageDiffGenerator.java
> line 13
On Thu, 9 Jan 2025 17:44:05 GMT, Archie Cobbs wrote:
>> Severin Gehwolf has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Review feedback
>
> src/jdk.jlink/share/classes/jdk/tools/jlink/internal/runtimelink/JimageDiffGenerator.java
> line
> During code review of
> [JDK-8346239](https://bugs.openjdk.org/browse/JDK-8346239) a few comments
> were made after the PR integrated. This follow-up patch cleans this up and
> adds a unit test for the `JimageDiffGenerator` class.
>
> Testing:
> - [ ] GHA
> - [x] tools/jlink tests (including
On Wed, 8 Jan 2025 00:40:04 GMT, Henry Jen wrote:
>> Improving option value handling to support passing argument value starts
>> with "--".
>>
>> Before the fix, in following example, --add-modules will be considered as
>> another option for JLink instead of argument value for --add-options.
>
On Thu, 9 Jan 2025 17:32:39 GMT, Severin Gehwolf wrote:
> During code review of
> [JDK-8346239](https://bugs.openjdk.org/browse/JDK-8346239) a few comments
> were made after the PR integrated. This follow-up patch cleans this up and
> adds a unit test for the `JimageDiffGenerator` class.
>
>
On Thu, 19 Dec 2024 20:48:18 GMT, Martin Balao wrote:
>> Martin Balao has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase.
>
> Added a non-goal to the JEP to indicate that secu
On Thu, 9 Jan 2025 17:32:39 GMT, Severin Gehwolf wrote:
> During code review of
> [JDK-8346239](https://bugs.openjdk.org/browse/JDK-8346239) a few comments
> were made after the PR integrated. This follow-up patch cleans this up and
> adds a unit test for the `JimageDiffGenerator` class.
>
>
On Mon, 16 Sep 2024 17:50:52 GMT, Henry Jen wrote:
> This PR split out large array/set construction into separate factory methods
> to avoid oversized method trying to construct several of those.
>
> In order to do that, we will need to generate those help methods on demand in
> the class buil
During code review of
[JDK-8346239](https://bugs.openjdk.org/browse/JDK-8346239) a few comments were
made after the PR integrated. This follow-up patch cleans this up and adds a
unit test for the `JimageDiffGenerator` class.
Testing:
- [ ] GHA
- [x] tools/jlink tests (including the new one).
T
On Thu, 19 Dec 2024 18:14:39 GMT, Severin Gehwolf wrote:
> Please review this fairly simple change to improve how the
> `JimageDiffGenerator` works. The original implementation is pretty naive and
> read all bytes into memory and then compared them. This improved version only
> reads bytes on
On Thu, 9 Jan 2025 16:47:18 GMT, Matthias Baesken wrote:
> The functions unix_getParentPidAndTimings and unix_getCmdlineAndUserInfo in
> src/java.base/unix/native/libjava/ProcessHandleImpl_unix.c used to hold an
> implementation that was shared between Solaris and AIX. Linux and MacOS
> alread
On Thu, 9 Jan 2025 16:47:18 GMT, Matthias Baesken wrote:
> The functions unix_getParentPidAndTimings and unix_getCmdlineAndUserInfo in
> src/java.base/unix/native/libjava/ProcessHandleImpl_unix.c used to hold an
> implementation that was shared between Solaris and AIX. Linux and MacOS
> alread
The functions unix_getParentPidAndTimings and unix_getCmdlineAndUserInfo in
src/java.base/unix/native/libjava/ProcessHandleImpl_unix.c used to hold an
implementation that was shared between Solaris and AIX. Linux and MacOS already
had specific implementations. After the removal of the Solaris po
On Thu, 9 Jan 2025 11:37:17 GMT, Joachim Kern wrote:
>> The test java/lang/ProcessHandle/InfoTest.java still fails sporadically on
>> AIX. The test exclusion was removed through
>> [JDK-8211847](https://bugs.openjdk.org/browse/JDK-8211847) under the
>> assumption the problem was gone. But it t
On Thu, 9 Jan 2025 11:37:17 GMT, Joachim Kern wrote:
>> The test java/lang/ProcessHandle/InfoTest.java still fails sporadically on
>> AIX. The test exclusion was removed through
>> [JDK-8211847](https://bugs.openjdk.org/browse/JDK-8211847) under the
>> assumption the problem was gone. But it t
On Thu, 9 Jan 2025 15:23:18 GMT, Alan Bateman wrote:
>> Viktor Klang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Addresses PR review feedback
>
> src/java.base/share/classes/java/util/stream/Gatherers.java line 392:
>
>> 390:
> The following patch updates Gatherers.mapConcurrent to limit work-in-progress
> (on-going and completed-unpushed) to the `maxConcurrency` so that
> head-of-line blocking does not cause completed-unpushed work to grow
> unbounded.
>
> This also simplifies interruption handling to ignore-and-re
On Thu, 9 Jan 2025 10:13:52 GMT, Viktor Klang wrote:
> The following patch updates Gatherers.mapConcurrent to limit work-in-progress
> (on-going and completed-unpushed) to the `maxConcurrency` so that
> head-of-line blocking does not cause completed-unpushed work to grow
> unbounded.
>
> This
On Thu, 9 Jan 2025 11:37:17 GMT, Joachim Kern wrote:
>> The test java/lang/ProcessHandle/InfoTest.java still fails sporadically on
>> AIX. The test exclusion was removed through
>> [JDK-8211847](https://bugs.openjdk.org/browse/JDK-8211847) under the
>> assumption the problem was gone. But it t
On Wed, 8 Jan 2025 11:53:43 GMT, Joachim Kern wrote:
> The test java/lang/ProcessHandle/InfoTest.java still fails sporadically on
> AIX. The test exclusion was removed through
> [JDK-8211847](https://bugs.openjdk.org/browse/JDK-8211847) under the
> assumption the problem was gone. But it turne
On Thu, 9 Jan 2025 03:38:48 GMT, David Holmes wrote:
>> Severin Gehwolf has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Copyright and @comment
>
> Pardon my ignorance, but in neither of these tests is it evident to me that
> "patched mo
On Fri, 3 Jan 2025 20:42:15 GMT, Jatin Bhateja wrote:
>> Hi All,
>>
>> This patch adds C2 compiler support for various Float16 operations added by
>> [PR#22128](https://github.com/openjdk/jdk/pull/22128)
>>
>> Following is the summary of changes included with this patch:-
>>
>> 1. Detection o
On Mon, 16 Dec 2024 18:42:48 GMT, Joe Darcy wrote:
>> Jatin Bhateja has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Adding more test points
>
> src/java.base/share/classes/jdk/internal/vm/vector/Float16Math.java line 35:
>
>> 33: * The
On Thu, 9 Jan 2025 13:14:13 GMT, Emanuel Peter wrote:
>> Jatin Bhateja has refreshed the contents of this pull request, and previous
>> commits have been removed. The incremental views will show differences
>> compared to the previous content of the PR. The pull request contains one
>> new com
On Thu, 9 Jan 2025 11:37:17 GMT, Joachim Kern wrote:
>> The test java/lang/ProcessHandle/InfoTest.java still fails sporadically on
>> AIX. The test exclusion was removed through
>> [JDK-8211847](https://bugs.openjdk.org/browse/JDK-8211847) under the
>> assumption the problem was gone. But it t
On Wed, 18 Dec 2024 09:12:55 GMT, Joakim Nordström
wrote:
> Could I get a review of this fix to refine the warnings printed by `libjsig`
> when using the deprecated `signal()`/`sigset()` functions?
>
> Currently the libjsig library supports chaining `signal()` and `sigset()`.
> With these fun
On Thu, 9 Jan 2025 12:03:55 GMT, Galder Zamarreño wrote:
>> @galderz Nice, thanks for the updates. I gave the patch a quick scan and I
>> think it looks really good. Just ping me again when you are done with your
>> aarch64 investigations, and you think I should review again :)
>
> @eme64 aarch
On Thu, 9 Jan 2025 01:25:09 GMT, David Holmes wrote:
>> Joakim Nordström has updated the pull request incrementally with three
>> additional commits since the last revision:
>>
>> - Merge
>> - Copyright year. Doc updated. Comments revised.
>> - Merge
>
> Okay looks good! Thanks
>
> I'll dru
On Wed, 8 Jan 2025 11:03:06 GMT, Joakim Nordström
wrote:
>> Could I get a review of this fix to refine the warnings printed by `libjsig`
>> when using the deprecated `signal()`/`sigset()` functions?
>>
>> Currently the libjsig library supports chaining `signal()` and `sigset()`.
>> With these
On Thu, 9 Jan 2025 11:37:17 GMT, Joachim Kern wrote:
>> The test java/lang/ProcessHandle/InfoTest.java still fails sporadically on
>> AIX. The test exclusion was removed through
>> [JDK-8211847](https://bugs.openjdk.org/browse/JDK-8211847) under the
>> assumption the problem was gone. But it t
On Wed, 18 Dec 2024 06:22:56 GMT, Emanuel Peter wrote:
>> @eme64 I've addressed all your comments except aarch64 testing. `asimd` is
>> not enough, you need `sve` for this, but I'm yet to make it work even with
>> `sve`, something's up and need to debug it further.
>>
>> @jaskarth FYI I've adj
On Wed, 8 Jan 2025 19:41:42 GMT, Hannes Wallnöfer wrote:
> Please review a doc-only change to add missing `@serial` javadoc tags in
> module `java.base`. This is a sub-task of [JDK-8286931] to allow us to
> re-enable the javadoc `-serialwarn` option in the JDK doc build, which has
> been disab
> This patch intrinsifies `Math.max(long, long)` and `Math.min(long, long)` in
> order to help improve vectorization performance.
>
> Currently vectorization does not kick in for loops containing either of these
> calls because of the following error:
>
>
> VLoop::check_preconditions: failed:
> This PR proposes to clean up all the imports in the FFM lib (excluding tests).
>
> Passes tier1-tier3
Per Minborg has updated the pull request with a new target base due to a merge
or a rebase. The incremental webrev excludes the unrelated changes brought in
by the merge/rebase. The pull requ
On Thu, 9 Jan 2025 10:29:32 GMT, Martin Doerr wrote:
>> Joachim Kern has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - remove extra white space
>> - omit unused variable
>
> src/java.base/aix/native/libjava/ProcessHandleImpl_aix.c line
> The test java/lang/ProcessHandle/InfoTest.java still fails sporadically on
> AIX. The test exclusion was removed through
> [JDK-8211847](https://bugs.openjdk.org/browse/JDK-8211847) under the
> assumption the problem was gone. But it turned out that it was wrong.
>
> We can see an exception l
On Fri, 3 Jan 2025 08:48:37 GMT, Emanuel Peter wrote:
>> That's right. Neoverse V2 is 4 pipes of 128 bits, V1 is 2 pipes of 256 bits.
>> That comment is "interesting". Maybe it should be tunable by the back end.
>> Given that Neoverse V2 can issue 4 SVE operations per clock cycle, it might
>> s
> This PR proposes to clean up all the imports in the FFM lib (excluding tests).
>
> Passes tier1-tier3
Per Minborg has updated the pull request with a new target base due to a merge
or a rebase. The incremental webrev excludes the unrelated changes brought in
by the merge/rebase. The pull requ
> See the JBS bug for some details.
Raffaello Giulietti has updated the pull request with a new target base due to
a merge or a rebase. The incremental webrev excludes the unrelated changes
brought in by the merge/rebase. The pull request contains seven additional
commits since the last revisio
> This patch intrinsifies `Math.max(long, long)` and `Math.min(long, long)` in
> order to help improve vectorization performance.
>
> Currently vectorization does not kick in for loops containing either of these
> calls because of the following error:
>
>
> VLoop::check_preconditions: failed:
On Wed, 8 Jan 2025 14:14:29 GMT, Matthias Baesken wrote:
> I created https://bugs.openjdk.org/browse/JDK-8347270 8347270: Remove
> unix_getParentPidAndTimings after JDK-8346880
I massaged the bug a little bit. But I still think this could all be done in
this PR.
-
PR Comment: htt
On Wed, 8 Jan 2025 13:51:53 GMT, Joachim Kern wrote:
> > > Seems, that we were the only remainding users of
> > > unix_getParentPidAndTimings(). Should I remove the orphant?
> >
> >
> > I would be in favor of removing it (in this PR or separate).
>
> OK agree, but in a separate PR. Could you
On Wed, 8 Jan 2025 13:41:52 GMT, Matthias Baesken wrote:
> > Seems, that we were the only remainding users of
> > unix_getParentPidAndTimings(). Should I remove the orphant?
>
> I would be in favor of removing it (in this PR or separate).
OK agree, but in a separate PR. Could you please create
On Wed, 8 Jan 2025 12:47:58 GMT, Joachim Kern wrote:
> Seems, that we were the only remainding users of
> unix_getParentPidAndTimings(). Should I remove the orphant?
I would be in favor of removing it (in this PR or separate).
-
PR Comment: https://git.openjdk.org/jdk/pull/22966#
On Wed, 8 Jan 2025 12:21:21 GMT, Matthias Baesken wrote:
> > The /proc//psinfo file is evaluated to obtain the cpu time
>
> Do you mean` /proc//psinfo` ?
Strange, the < pid > is there, but not displayed, maybe interpreted as special
characters.
I let the string interpreted as code. This helps.
On Wed, 8 Jan 2025 11:53:43 GMT, Joachim Kern wrote:
> The test java/lang/ProcessHandle/InfoTest.java still fails sporadically on
> AIX. The test exclusion was removed through
> [JDK-8211847](https://bugs.openjdk.org/browse/JDK-8211847) under the
> assumption the problem was gone. But it turne
On Wed, 8 Jan 2025 11:53:43 GMT, Joachim Kern wrote:
> The test java/lang/ProcessHandle/InfoTest.java still fails sporadically on
> AIX. The test exclusion was removed through
> [JDK-8211847](https://bugs.openjdk.org/browse/JDK-8211847) under the
> assumption the problem was gone. But it turne
The test java/lang/ProcessHandle/InfoTest.java still fails sporadically on AIX.
The test exclusion was removed through
[JDK-8211847](https://bugs.openjdk.org/browse/JDK-8211847) under the assumption
the problem was gone. But it turned out that it was wrong.
We can see an exception like:
java.l
On Wed, 8 Jan 2025 11:03:06 GMT, Joakim Nordström
wrote:
>> Could I get a review of this fix to refine the warnings printed by `libjsig`
>> when using the deprecated `signal()`/`sigset()` functions?
>>
>> Currently the libjsig library supports chaining `signal()` and `sigset()`.
>> With these
On Wed, 8 Jan 2025 11:03:06 GMT, Joakim Nordström
wrote:
>> Could I get a review of this fix to refine the warnings printed by `libjsig`
>> when using the deprecated `signal()`/`sigset()` functions?
>>
>> Currently the libjsig library supports chaining `signal()` and `sigset()`.
>> With these
On Thu, 9 Jan 2025 00:05:30 GMT, Leonid Mesnik wrote:
> Test
> test/jdk/tools/jimage/JImageToolTest.java
> ignore vm flags and should be marked as flagless.
>
> It is needed to don't try to run this test with virtual test thread factory.
Marked as reviewed by shade (Reviewer).
-
P
On Thu, 9 Jan 2025 10:18:35 GMT, Severin Gehwolf wrote:
>> Please review this trivial test-only patch in support of running tests on
>> JEP 493 enabled builds. Both tests use the `ToolProvider` API so as to run
>> `jlink` in-process of the test JVM which includes module patches (as in -
>> use
On Wed, 8 Jan 2025 14:56:55 GMT, Severin Gehwolf wrote:
>> Please review this trivial test-only patch in support of running tests on
>> JEP 493 enabled builds. Both tests use the `ToolProvider` API so as to run
>> `jlink` in-process of the test JVM which includes module patches (as in -
>> use
The following patch updates Gatherers.mapConcurrent to limit work-in-progress
(on-going and completed-unpushed) to the `maxConcurrency` so that head-of-line
blocking does not cause completed-unpushed work to grow unbounded.
This also simplifies interruption handling to ignore-and-restore, which
> Please review this trivial test-only patch in support of running tests on JEP
> 493 enabled builds. Both tests use the `ToolProvider` API so as to run
> `jlink` in-process of the test JVM which includes module patches (as in -
> uses `--patch-module`) which is not supported for JEP 493 enabled
On Fri, 20 Dec 2024 13:25:43 GMT, Severin Gehwolf wrote:
> Clean backport of [JDK-8345259](https://bugs.openjdk.org/browse/JDK-8345259)
> to JDK 24 which has JEP 493.
This pull request has now been integrated.
Changeset: 7d4fa781
Author:Severin Gehwolf
URL:
https://git.openjdk.org/
On Wed, 8 Jan 2025 15:08:31 GMT, Severin Gehwolf wrote:
> Clean backport of a test follow-up for #22849 targeting JDK 24. Please
> review! Thanks in advance.
This pull request has now been integrated.
Changeset: c033806b
Author:Severin Gehwolf
URL:
https://git.openjdk.org/jdk/commi
On Thu, 19 Dec 2024 18:14:39 GMT, Severin Gehwolf wrote:
> Please review this fairly simple change to improve how the
> `JimageDiffGenerator` works. The original implementation is pretty naive and
> read all bytes into memory and then compared them. This improved version only
> reads bytes on
> Please review this change that improves the launcher mode detection by
> reading the initial two characters from the started file for being a shebang
> script. It addresses the reported confusing error messages and also supports
> more shebang line variations. Including those line variations t
On Wed, 8 Jan 2025 19:41:42 GMT, Hannes Wallnöfer wrote:
> Please review a doc-only change to add missing `@serial` javadoc tags in
> module `java.base`. This is a sub-task of [JDK-8286931] to allow us to
> re-enable the javadoc `-serialwarn` option in the JDK doc build, which has
> been disab
On Thu, 9 Jan 2025 00:05:30 GMT, Leonid Mesnik wrote:
> Test
> test/jdk/tools/jimage/JImageToolTest.java
> ignore vm flags and should be marked as flagless.
>
> It is needed to don't try to run this test with virtual test thread factory.
Marked as reviewed by alanb (Reviewer).
-
P
> There are no more consumers of ASM library except for hotspot tests.
> This patch moves ASM library from java.base module to the hotspot test
> libraries location and fixes the tests.
>
> Please review.
>
> Thanks,
> Adam
Adam Sotona has updated the pull request incrementally with one additio
> Please review this change that improves the launcher mode detection by
> reading the initial two characters from the started file for being a shebang
> script. It addresses the reported confusing error messages and also supports
> more shebang line variations. Including those line variations t
On Thu, 9 Jan 2025 03:38:48 GMT, David Holmes wrote:
> Pardon my ignorance, but in neither of these tests is it evident to me that
> "patched modules" are being used. Where does that arise?
jtreg patches java.base to add JTRegModuleHelper so not compatible that uses
that using jlink "in-proces
On Wed, 8 Jan 2025 07:21:36 GMT, Adam Sotona wrote:
>> There are no more consumers of ASM library except for hotspot tests.
>> This patch moves ASM library from java.base module to the hotspot test
>> libraries location and fixes the tests.
>>
>> Please review.
>>
>> Thanks,
>> Adam
>
> Adam S
On Wed, 8 Jan 2025 22:14:21 GMT, David Holmes wrote:
> Moving the ASM library requires modifying every single test that uses it.
Right, as without it there will be warnings due to jtreg launching tests to
export packages that aren't in java.base. There may also be a few tests that
use launch c
84 matches
Mail list logo
