On Wed, 8 Jan 2025 06:02:38 GMT, Chen Liang wrote:
> The anchor is `refkinds` instead of `refKinds`.
I only ran the failed test and confirmed it works. It's a bit late for me, so
if some other committer is interested and has verified there are no new
failures feel free to integrate.
-
> There are no more consumers of ASM library except for hotspot tests.
> This patch moves ASM library from java.base module to the hotspot test
> libraries location and fixes the tests.
>
> Please review.
>
> Thanks,
> Adam
Adam Sotona has updated the pull request incrementally with one additio
On Wed, 8 Jan 2025 06:02:38 GMT, Chen Liang wrote:
> The anchor is `refkinds` instead of `refKinds`.
Looks good and trivial to me.
-
Marked as reviewed by jpai (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/22961#pullrequestreview-2536185329
On Tue, 7 Jan 2025 12:49:40 GMT, Adam Sotona wrote:
> There are no more consumers of ASM library except for hotspot tests.
> This patch moves ASM library from java.base module to the hotspot test
> libraries location and fixes the tests.
>
> Please review.
>
> Thanks,
> Adam
so you if add asm
On Wed, 8 Jan 2025 01:14:00 GMT, David Holmes wrote:
> It is not appropriate for anything outside the platform modules to claim to
> be part of `jdk.internal`. In fact I'm surprised we are even allowed to add
> to that from outside the module!
There's nothing to prohibit this, it's just surpri
On Wed, 8 Jan 2025 06:57:04 GMT, Alan Bateman wrote:
>
> you can revert the changes that we have in the jdk repo so it goes back to
> .org.objectweb.asm
that represents a refactoring with >1200 changes in >250 files across multiple
repositories
-
PR Comment: https://git.openjdk.
On Tue, 7 Jan 2025 22:19:22 GMT, Adam Sotona wrote:
> Despite the 265 modified files is this PR trying to be minimalistic.
> Repackaging of the library would be far more complex and would affect
> significantly more files, including the library itself. I would recommend to
> invest that effort
On Wed, 8 Jan 2025 01:45:48 GMT, Leonid Mesnik wrote:
>> There are no more consumers of ASM library except for hotspot tests.
>> This patch moves ASM library from java.base module to the hotspot test
>> libraries location and fixes the tests.
>>
>> Please review.
>>
>> Thanks,
>> Adam
>
> I th
> Can I please get a review of this enhancement which proposes to enhance
> `java.util.zip.Deflater/Inflater` classes to now implement `AutoCloseable`?
>
> The actual work for this was done a few years back when we discussed the
> proposed approaches and then I raised a RFR. At that time I could
The anchor is `refkinds` instead of `refKinds`.
-
Commit messages:
- 8347163: Javadoc error in ConstantPoolBuilder after JDK-8342468
Changes: https://git.openjdk.org/jdk/pull/22961/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=22961&range=00
Issue: https://bugs.openjdk.
On Tue, 7 Jan 2025 20:37:32 GMT, Roger Riggs wrote:
>> Jaikiran Pai has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> change "@since" to 25
>
> src/java.base/share/classes/java/util/zip/Deflater.java line 815:
>
>> 813: * than {@link
> `javax.lang.model.SourceVersion` has a series of comments describing the new
> language features present in each source version. Similar comments for the
> `ClassFileFormatVersion` would be helpful, so readers no longer need to
> search through the JVMS to find changes in new versions.
Chen L
On Mon, 18 Nov 2024 19:59:16 GMT, Chen Liang wrote:
> Improve documentation for constant pool entries. This include some models
> for those entries, symbolic descriptors, and some general guidance in package
> summary.
>
> APIDiff: https://cr.openjdk.org/~liach/apidiff/cf-consts/
> Javadoc: h
On Mon, 6 Jan 2025 21:41:17 GMT, Chen Liang wrote:
>> Improve documentation for constant pool entries. This include some models
>> for those entries, symbolic descriptors, and some general guidance in
>> package summary.
>>
>> APIDiff: https://cr.openjdk.org/~liach/apidiff/cf-consts/
>> Javad
On Tue, 7 Jan 2025 12:49:40 GMT, Adam Sotona wrote:
> There are no more consumers of ASM library except for hotspot tests.
> This patch moves ASM library from java.base module to the hotspot test
> libraries location and fixes the tests.
>
> Please review.
>
> Thanks,
> Adam
I think it is mak
On Thu, 31 Oct 2024 07:15:16 GMT, Taizo Kurashige wrote:
> To resolve java/io/File/GetXSpace.java failure, I fix libGetXSpace.c to use
> Cygwin’s `df` to get the size for comparison if the test target drive is a
> CD-ROM drive.
>
> As described in JDK-8343342, GetDiskSpaceInformationW can't g
On Mon, 23 Dec 2024 13:18:09 GMT, Taizo Kurashige wrote:
>> To resolve java/io/File/GetXSpace.java failure, I fix libGetXSpace.c to use
>> Cygwin’s `df` to get the size for comparison if the test target drive is a
>> CD-ROM drive.
>>
>> As described in JDK-8343342, GetDiskSpaceInformationW ca
On Tue, 7 Jan 2025 20:19:53 GMT, Alan Bateman wrote:
>> There are no more consumers of ASM library except for hotspot tests.
>> This patch moves ASM library from java.base module to the hotspot test
>> libraries location and fixes the tests.
>>
>> Please review.
>>
>> Thanks,
>> Adam
>
> Movin
On Tue, 7 Jan 2025 12:49:40 GMT, Adam Sotona wrote:
> There are no more consumers of ASM library except for hotspot tests.
> This patch moves ASM library from java.base module to the hotspot test
> libraries location and fixes the tests.
>
> Please review.
>
> Thanks,
> Adam
Test libraries be
On Mon, 23 Dec 2024 13:18:09 GMT, Taizo Kurashige wrote:
>> To resolve java/io/File/GetXSpace.java failure, I fix libGetXSpace.c to use
>> Cygwin’s `df` to get the size for comparison if the test target drive is a
>> CD-ROM drive.
>>
>> As described in JDK-8343342, GetDiskSpaceInformationW ca
On Mon, 23 Dec 2024 13:18:09 GMT, Taizo Kurashige wrote:
>> To resolve java/io/File/GetXSpace.java failure, I fix libGetXSpace.c to use
>> Cygwin’s `df` to get the size for comparison if the test target drive is a
>> CD-ROM drive.
>>
>> As described in JDK-8343342, GetDiskSpaceInformationW ca
> Improving option value handling to support passing argument value starts with
> "--".
>
> Before the fix, in following example, --add-modules will be considered as
> another option for JLink instead of argument value for --add-options.
> --add-options --add-modules=jdk.incubator.concurrent
> -
On Mon, 23 Dec 2024 13:18:09 GMT, Taizo Kurashige wrote:
>> To resolve java/io/File/GetXSpace.java failure, I fix libGetXSpace.c to use
>> Cygwin’s `df` to get the size for comparison if the test target drive is a
>> CD-ROM drive.
>>
>> As described in JDK-8343342, GetDiskSpaceInformationW ca
On Tue, 7 Jan 2025 12:49:40 GMT, Adam Sotona wrote:
> There are no more consumers of ASM library except for hotspot tests.
> This patch moves ASM library from java.base module to the hotspot test
> libraries location and fixes the tests.
>
> Please review.
>
> Thanks,
> Adam
I've decided to m
On Tue, 7 Jan 2025 10:45:09 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this enhancement which proposes to enhance
>> `java.util.zip.Deflater/Inflater` classes to now implement `AutoCloseable`?
>>
>> The actual work for this was done a few years back when we discussed the
>> propo
On Tue, 16 Jul 2024 18:02:57 GMT, Chen Liang wrote:
> In annotated types, local and inner class types should be annotated as
> "top-level" types. For example, in the test here
>
> public static Class getLocalsMember() {
> class Local {
> class Member {
>
On Tue, 7 Jan 2025 10:45:09 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this enhancement which proposes to enhance
>> `java.util.zip.Deflater/Inflater` classes to now implement `AutoCloseable`?
>>
>> The actual work for this was done a few years back when we discussed the
>> propo
On Tue, 7 Jan 2025 10:45:09 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this enhancement which proposes to enhance
>> `java.util.zip.Deflater/Inflater` classes to now implement `AutoCloseable`?
>>
>> The actual work for this was done a few years back when we discussed the
>> propo
On Mon, 11 Nov 2024 11:55:27 GMT, Per Minborg wrote:
> This PR proposes to add a new `MemorySegment::fill" benchmark where the byte
> size of the segments varies.
This pull request has been closed without being integrated.
-
PR: https://git.openjdk.org/jdk/pull/22010
On Tue, 7 Jan 2025 18:27:31 GMT, Naoto Sato wrote:
> Long overdue cleanup, especially the old `javazic` tool, which has been
> maintenance burden for some time.
Marked as reviewed by rriggs (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/22955#pullrequestreview-253530375
On Tue, 7 Jan 2025 12:49:40 GMT, Adam Sotona wrote:
> There are no more consumers of ASM library except for hotspot tests.
> This patch moves ASM library from java.base module to the hotspot test
> libraries location and fixes the tests.
>
> Please review.
>
> Thanks,
> Adam
Moving it to test
There are no more consumers of ASM library except for hotspot tests.
This patch moves ASM library from java.base module to the hotspot test
libraries location and fixes the tests.
Please review.
Thanks,
Adam
-
Commit messages:
- fixed TestMHUnloaded
- patching hotspot tests
- re
On Tue, 7 Jan 2025 10:44:22 GMT, Per Minborg wrote:
> This PR proposes to eliminate the capturing of `this` in the cleanup action
> of `AbstractMemorySegment::reinterpretInternal`.
As a matter of style, I believe there is something to be said for writing out
cleaning actions as static nested c
On Tue, 7 Jan 2025 18:27:31 GMT, Naoto Sato wrote:
> Long overdue cleanup, especially the old `javazic` tool, which has been
> maintenance burden for some time.
Thanks for taking care of this long-overdue removal!
-
Marked as reviewed by iris (Reviewer).
PR Review: https://git.op
Long overdue cleanup, especially the old `javazic` tool, which has been
maintenance burden for some time.
-
Commit messages:
- initial commit
Changes: https://git.openjdk.org/jdk/pull/22955/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=22955&range=00
Issue: https://bug
On Fri, 20 Dec 2024 18:18:48 GMT, Mandy Chung wrote:
>> Clean backport of [JDK-8345259](https://bugs.openjdk.org/browse/JDK-8345259)
>> to JDK 24 which has JEP 493.
>
> I created https://bugs.openjdk.org/browse/JDK-8345259. Looks like the tests
> need update.
> I think the bug you mean @mlchu
I’m a bit confused about how the macOS implementation of JDK uses Objective-C
memory management.
Does it use ARC?
I’m guessing it does, because I see dealloc methods that clear pointer
variables without first releasing them.
However, if I put an Xcode breakpoint on -[MTLLayer dealloc], the bre
On Fri, 20 Dec 2024 18:12:17 GMT, Naoto Sato wrote:
>> Clarifying the documentation of `DateTimeFormatterBuilder.appendZoneId()`
>> and similar methods to align the description with the behavior, in which
>> `ZoneOffset` is only parsed from the formatter for offset texts without any
>> prefixe
On Thu, 19 Dec 2024 22:12:52 GMT, Naoto Sato wrote:
> Clarifying the documentation of `DateTimeFormatterBuilder.appendZoneId()` and
> similar methods to align the description with the behavior, in which
> `ZoneOffset` is only parsed from the formatter for offset texts without any
> prefixes. C
On Tue, 7 Jan 2025 04:43:58 GMT, Joe Darcy wrote:
>> src/java.base/share/classes/java/lang/reflect/ClassFileFormatVersion.java
>> line 58:
>>
>>> 56: * 2: ACC_STRICT modifier
>>> 57: * 3: no changes
>>> 58: * 4: no changes
>>
>> The version mapping can be tricky here: is "1"
On Tue, 7 Jan 2025 14:05:19 GMT, Severin Gehwolf wrote:
>> Please review these changes to jpackage in light of [JEP
>> 493](https://openjdk.org/jeps/493). When this feature is enabled, then some
>> of the `jpackage` tests fail. The failures fall into the following
>> categories:
>>
>> - `ALL-
On Thu, 19 Dec 2024 10:46:03 GMT, Per Minborg wrote:
> This PR proposes to clean up all the imports in the FFM lib (excluding tests).
>
> Passes tier1-tier3
copyrights should say 2025
Do we have a sense on how easy would it be, moving forward, to preserve the
"correct" order of imports? E.g.
On Thu, 19 Dec 2024 09:48:23 GMT, Per Minborg wrote:
> This PR proposes to improve the current `MemorySegment.toString()` method
> from:
>
> `MemorySegment{ address: 0x6264c540, byteSize: 8 }`
>
> to
>
> `MemorySegment{ native, address: 0x6264c540, byteSize: 8}`
>
> Tests passes tier
Hi all,
This pull request contains a backport of commit
[4d8fb807](https://github.com/openjdk/jdk/commit/4d8fb80732fd17352c36254c6dfc1be5dbfbacf1)
from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
The commit being backported was authored by SendaoYan on 7 Jan 2025 and was
reviewe
On Mon, 6 Jan 2025 09:12:01 GMT, SendaoYan wrote:
> Hi all,
> This PR add JVM option `jvmArgs={"--add-modules=jdk.incubator.vector"}` for
> test/micro/org/openjdk/bench/jdk/incubator/vector/SpiltReplicate.java, to fix
> test bug which cause jmh test fails 'java.lang.NoClassDefFoundError:
> j
On Mon, 6 Jan 2025 09:12:01 GMT, SendaoYan wrote:
> Hi all,
> This PR add JVM option `jvmArgs={"--add-modules=jdk.incubator.vector"}` for
> test/micro/org/openjdk/bench/jdk/incubator/vector/SpiltReplicate.java, to fix
> test bug which cause jmh test fails 'java.lang.NoClassDefFoundError:
> j
On Tue, 7 Jan 2025 14:05:19 GMT, Severin Gehwolf wrote:
>> Please review these changes to jpackage in light of [JEP
>> 493](https://openjdk.org/jeps/493). When this feature is enabled, then some
>> of the `jpackage` tests fail. The failures fall into the following
>> categories:
>>
>> - `ALL-
On Mon, 6 Jan 2025 21:41:17 GMT, Chen Liang wrote:
>> Improve documentation for constant pool entries. This include some models
>> for those entries, symbolic descriptors, and some general guidance in
>> package summary.
>>
>> APIDiff: https://cr.openjdk.org/~liach/apidiff/cf-consts/
>> Javad
On Mon, 6 Jan 2025 04:27:23 GMT, David Holmes wrote:
>> Could I get a review of this fix to refine the warnings printed by `libjsig`
>> when using the deprecated `signal()`/`sigset()` functions?
>>
>> Currently the libjsig library supports chaining `signal()` and `sigset()`.
>> With these func
On Tue, 7 Jan 2025 14:05:19 GMT, Severin Gehwolf wrote:
>> Please review these changes to jpackage in light of [JEP
>> 493](https://openjdk.org/jeps/493). When this feature is enabled, then some
>> of the `jpackage` tests fail. The failures fall into the following
>> categories:
>>
>> - `ALL-
> Please review these changes to jpackage in light of [JEP
> 493](https://openjdk.org/jeps/493). When this feature is enabled, then some
> of the `jpackage` tests fail. The failures fall into the following categories:
>
> - `ALL-DEFAULT` notion from `jpackage` which includes all modules that exp
On Tue, 7 Jan 2025 12:58:12 GMT, Per Minborg wrote:
>> This PR proposes to improve the current `MemorySegment.toString()` method
>> from:
>>
>> `MemorySegment{ address: 0x6264c540, byteSize: 8 }`
>>
>> to
>>
>> `MemorySegment{ native, address: 0x6264c540, byteSize: 8}`
>>
>> Tests pa
> This PR proposes to improve the current `MemorySegment.toString()` method
> from:
>
> `MemorySegment{ address: 0x6264c540, byteSize: 8 }`
>
> to
>
> `MemorySegment{ native, address: 0x6264c540, byteSize: 8}`
>
> Tests passes tier1-tier3
Per Minborg has updated the pull request incre
> This PR proposes to improve the current `MemorySegment.toString()` method
> from:
>
> `MemorySegment{ address: 0x6264c540, byteSize: 8 }`
>
> to
>
> `MemorySegment{ native, address: 0x6264c540, byteSize: 8}`
>
> Tests passes tier1-tier3
Per Minborg has updated the pull request incre
> This PR proposes to improve the current `MemorySegment.toString()` method
> from:
>
> `MemorySegment{ address: 0x6264c540, byteSize: 8 }`
>
> to
>
> `MemorySegment{ native, address: 0x6264c540, byteSize: 8}`
>
> Tests passes tier1-tier3
Per Minborg has updated the pull request incre
> This PR proposes to improve the current `MemorySegment.toString()` method
> from:
>
> `MemorySegment{ address: 0x6264c540, byteSize: 8 }`
>
> to
>
> `MemorySegment{ native, address: 0x6264c540, byteSize: 8}`
>
> Tests passes tier1-tier3
Per Minborg has updated the pull request incre
On Tue, 7 Jan 2025 11:30:13 GMT, Per Minborg wrote:
>> This PR proposes to improve the current `MemorySegment.toString()` method
>> from:
>>
>> `MemorySegment{ address: 0x6264c540, byteSize: 8 }`
>>
>> to
>>
>> `MemorySegment{ native, address: 0x6264c540, byteSize: 8}`
>>
>> Tests pa
On Tue, 7 Jan 2025 10:44:22 GMT, Per Minborg wrote:
> This PR proposes to eliminate the capturing of `this` in the cleanup action
> of `AbstractMemorySegment::reinterpretInternal`.
Please test this extensively. There is a non-zero chance that some tests (esp.
in later tiers) might be relying o
On Tue, 7 Jan 2025 10:44:22 GMT, Per Minborg wrote:
> This PR proposes to eliminate the capturing of `this` in the cleanup action
> of `AbstractMemorySegment::reinterpretInternal`.
Looks good.
-
Marked as reviewed by mcimadamore (Reviewer).
PR Review: https://git.openjdk.org/jdk/
> This PR proposes to improve the current `MemorySegment.toString()` method
> from:
>
> `MemorySegment{ address: 0x6264c540, byteSize: 8 }`
>
> to
>
> `MemorySegment{ native, address: 0x6264c540, byteSize: 8}`
>
> Tests passes tier1-tier3
Per Minborg has updated the pull request with
On Fri, 20 Dec 2024 18:18:48 GMT, Mandy Chung wrote:
>> Clean backport of [JDK-8345259](https://bugs.openjdk.org/browse/JDK-8345259)
>> to JDK 24 which has JEP 493.
>
> I created https://bugs.openjdk.org/browse/JDK-8345259. Looks like the tests
> need update.
I think the bug you mean @mlchung
This PR proposes to eliminate the capturing of `this` in the cleanup action of
`AbstractMemorySegment::reinterpretInternal`.
-
Commit messages:
- Prevent capturing of _this_
Changes: https://git.openjdk.org/jdk/pull/22943/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=229
> Can I please get a review of this enhancement which proposes to enhance
> `java.util.zip.Deflater/Inflater` classes to now implement `AutoCloseable`?
>
> The actual work for this was done a few years back when we discussed the
> proposed approaches and then I raised a RFR. At that time I could
On Fri, 20 Dec 2024 07:53:07 GMT, Matthias Baesken wrote:
>> Please review this fairly simple change to improve how the
>> `JimageDiffGenerator` works. The original implementation is pretty naive and
>> read all bytes into memory and then compared them. This improved version
>> only reads byte
On Mon, 2 Dec 2024 16:55:23 GMT, Roger Riggs wrote:
>> Jaikiran Pai has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 22 additional
>> commits sin
> Can I please get a review of this enhancement which proposes to enhance
> `java.util.zip.Deflater/Inflater` classes to now implement `AutoCloseable`?
>
> The actual work for this was done a few years back when we discussed the
> proposed approaches and then I raised a RFR. At that time I could
On Fri, 3 Jan 2025 10:29:31 GMT, Matthias Baesken wrote:
> When starting :tier1 jdk jtreg tests with
> /jtreg_latest/bin/jtreg
> this error is show when running ubsanized binaries on macOS aarch64 (XCode
> 13.1 and 15.4 show this)
>
> src/java.base/unix/native/libjava/ProcessImpl_md.c:561:40: r
On Fri, 3 Jan 2025 10:29:31 GMT, Matthias Baesken wrote:
> When starting :tier1 jdk jtreg tests with
> /jtreg_latest/bin/jtreg
> this error is show when running ubsanized binaries on macOS aarch64 (XCode
> 13.1 and 15.4 show this)
>
> src/java.base/unix/native/libjava/ProcessImpl_md.c:561:40: r
68 matches
Mail list logo
