On Thu, 2 Jan 2025 21:11:04 GMT, Archie Cobbs wrote:
>> Please review this patch which removes unnecessary `@SuppressWarnings`
>> annotations.
>
> Archie Cobbs has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Update @LastModified tags.
Mar
On Thu, 2 Jan 2025 21:11:04 GMT, Archie Cobbs wrote:
>> Please review this patch which removes unnecessary `@SuppressWarnings`
>> annotations.
>
> Archie Cobbs has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Update @LastModified tags.
Mar
On Mon, 23 Dec 2024 06:15:58 GMT, Henry Jen wrote:
>> This PR split out large array/set construction into separate factory methods
>> to avoid oversized method trying to construct several of those.
>>
>> In order to do that, we will need to generate those help methods on demand
>> in the class
On Wed, 25 Dec 2024 02:34:16 GMT, Qizheng Xing wrote:
>> This patch fixes unmatched brackets in some files, mostly in comments, docs
>> and man pages.
>
> Qizheng Xing has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Revert fix in the CTW M
On Wed, 25 Dec 2024 02:34:16 GMT, Qizheng Xing wrote:
>> This patch fixes unmatched brackets in some files, mostly in comments, docs
>> and man pages.
>
> Qizheng Xing has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Revert fix in the CTW M
On Wed, 6 Nov 2024 14:15:42 GMT, jengebr wrote:
> This change optimizes the runtime of `Class.getMethod(String, Class[])` by
> reducing the cost of the existing search logic. Specifically, while
> iterating across each Method to find a match (existing logic) it now compares
> parameter count
On Mon, 30 Dec 2024 21:25:20 GMT, Alexey Semenyuk wrote:
> Skip the test (throw `jtreg.SkippedException`) if the volume that owns the
> test's work directory doesn't support DOS file names.
Looks good. Did you check behavior of jpackage when it is executed without
support for DOS file names fr
On Thu, 2 Jan 2025 21:11:04 GMT, Archie Cobbs wrote:
>> Please review this patch which removes unnecessary `@SuppressWarnings`
>> annotations.
>
> Archie Cobbs has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Update @LastModified tags.
Mar
On Thu, 2 Jan 2025 19:56:16 GMT, Archie Cobbs wrote:
>> Please review this patch which removes unnecessary `@SuppressWarnings`
>> annotations.
>
> Archie Cobbs has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Revert changes under src/java.d
> Please review this patch which removes unnecessary `@SuppressWarnings`
> annotations.
Archie Cobbs has updated the pull request incrementally with one additional
commit since the last revision:
Update @LastModified tags.
-
Changes:
- all: https://git.openjdk.org/jdk/pull/218
On Thu, 2 Jan 2025 19:56:16 GMT, Archie Cobbs wrote:
>> Please review this patch which removes unnecessary `@SuppressWarnings`
>> annotations.
>
> Archie Cobbs has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Revert changes under src/java.d
On Thu, 2 Jan 2025 19:51:19 GMT, Andrey Turbanov wrote:
>> Naoto Sato has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains five additional
>> commits
> Please review this patch which removes unnecessary `@SuppressWarnings`
> annotations.
Archie Cobbs has updated the pull request incrementally with one additional
commit since the last revision:
Revert changes under src/java.desktop (to be moved into a separate PR).
-
Changes:
On Thu, 2 Jan 2025 19:16:41 GMT, Naoto Sato wrote:
> Looks like some files in java.desktop package are also modified. Just
> wondering they may not be seen by client folks as the title mentions
> core-libs.
Yeah my attempt to split this up was not perfect. I did have a separate,
earlier PR (#
On Thu, 2 Jan 2025 18:11:53 GMT, Naoto Sato wrote:
>> The change made in
>> [JDK-8288723](https://bugs.openjdk.org/browse/JDK-8288723) seems innocuous,
>> but it caused this performance regression. Partially reverting the change
>> (ones that involve `computeIfAbsent()`) to the original. Provi
On Thu, 2 Jan 2025 18:11:53 GMT, Naoto Sato wrote:
>> The change made in
>> [JDK-8288723](https://bugs.openjdk.org/browse/JDK-8288723) seems innocuous,
>> but it caused this performance regression. Partially reverting the change
>> (ones that involve `computeIfAbsent()`) to the original. Provi
On Thu, 2 Jan 2025 19:05:53 GMT, Archie Cobbs wrote:
>> Please review this patch which removes unnecessary `@SuppressWarnings`
>> annotations.
>
> Archie Cobbs has updated the pull request with a new target base due to a
> merge or a rebase. The pull request now contains 17 commits:
>
> - Bum
> Please review this patch which removes unnecessary `@SuppressWarnings`
> annotations.
Archie Cobbs has updated the pull request with a new target base due to a merge
or a rebase. The pull request now contains 17 commits:
- Bump copyright year to 2025.
- Merge branch 'master' into SuppressWa
On Thu, 5 Dec 2024 17:45:32 GMT, Mandy Chung wrote:
>> --style argument still could be a real jlink argument, better check would be
>> to see if that's a valid jlink option rather than just "--".
>> The other alternative would be like what proposed by @YaSuenag, simply take
>> the next token a
On Wed, 25 Dec 2024 02:34:16 GMT, Qizheng Xing wrote:
>> This patch fixes unmatched brackets in some files, mostly in comments, docs
>> and man pages.
>
> Qizheng Xing has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Revert fix in the CTW M
On Thu, 2 Jan 2025 18:11:53 GMT, Naoto Sato wrote:
>> The change made in
>> [JDK-8288723](https://bugs.openjdk.org/browse/JDK-8288723) seems innocuous,
>> but it caused this performance regression. Partially reverting the change
>> (ones that involve `computeIfAbsent()`) to the original. Provi
> The class `GZIPOutputStream` extends `DeflaterOutputStream`, which is logical
> because the GZIP encoding is based on ZLIB "deflate" encoding.
>
> However, while `DeflaterOutputStream` provides constructors that take a
> custom `Deflater` argument supplied by the caller, `GZIPOutputStream` has
> The change made in [JDK-8288723](https://bugs.openjdk.org/browse/JDK-8288723)
> seems innocuous, but it caused this performance regression. Partially
> reverting the change (ones that involve `computeIfAbsent()`) to the original.
> Provided a benchmark that iterates the call to `ZoneOffset.ofT
On Mon, 30 Dec 2024 17:44:11 GMT, Brett Okken wrote:
>> Indeed, just noticed that both `computeIfAbsent` and `putIfAbsent` may
>> acquire the lock when the key is present, while `get` never acquires a lock
>> for read-only access.
>>
>> Maybe the implementation was written back when locking wa
On Sat, 21 Dec 2024 00:59:53 GMT, Chen Liang wrote:
>> test/micro/org/openjdk/bench/java/time/ZoneOffsetBench.java line 49:
>>
>>> 47: public void ofTotalSeconds() {
>>> 48: for (int i = 0; i < 1_000; i++) {
>>> 49: ZoneOffset.ofTotalSeconds(0);
>>
>> This benchmark meth
On Thu, 2 Jan 2025 17:13:17 GMT, David M. Lloyd wrote:
> When loading services by class loader
> (`ServiceLoader.load(Class,ClassLoader)`), the module layers bound to the
> given class loader are searched for services, along with the layers bound to
> class loader's parent, and so on. For non-
When loading services by class loader
(`ServiceLoader.load(Class,ClassLoader)`), the module layers bound to the given
class loader are searched for services, along with the layers bound to class
loader's parent, and so on. For non-hierarchical class loader arrangements,
this breaks down because
On Wed, 18 Dec 2024 18:03:50 GMT, David M. Lloyd wrote:
>> Custom module layers allow for lazy loading, late binding, and full
>> customization of module dependencies through the `Controller` API. However,
>> it is not possible for custom layer users to late-bind services, which has
>> prevent
On Tue, 17 Dec 2024 16:29:13 GMT, David M. Lloyd wrote:
> Custom module layers allow for lazy loading, late binding, and full
> customization of module dependencies through the `Controller` API. However,
> it is not possible for custom layer users to late-bind services, which has
> prevented s
On Mon, 2 Dec 2024 16:50:20 GMT, Liam Miller-Cushon wrote:
>> This change overrides mutator methods in the implementation returned by
>> `Map.of().entrySet()` to throw `UnsupportedOperationException`.
>
> Liam Miller-Cushon has updated the pull request with a new target base due to
> a merge or
> From: "Viktor Klang"
> To: "Remi Forax" , "core-libs-dev"
>
> Sent: Thursday, January 2, 2025 12:26:08 PM
> Subject: Re: [External] : Gatherers.fold()
> Hi Rémi,
Happy new year,
>>Thinking a little more, i do not understand why fold takes a Supplier as first
>>parameter and not just a value
Hi Rémi,
>Thinking a little more, i do not understand why fold takes a Supplier as first
>parameter and not just a value given that the Gatherer is created with
>ofSequential().
If it didn't take a supplier then the resulting Gatherer could never be reused
(including composition). I.e. The use
On Mon, 30 Dec 2024 21:25:20 GMT, Alexey Semenyuk wrote:
> Skip the test (throw `jtreg.SkippedException`) if the volume that owns the
> test's work directory doesn't support DOS file names.
> alexeysemenyukoracle
I added the patch to our build/test queue .
-
PR Comment: https://g
33 matches
Mail list logo
