On Wed, 25 Dec 2024 02:34:16 GMT, Qizheng Xing wrote:
>> This patch fixes unmatched brackets in some source files.
>
> Qizheng Xing has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Revert fix in the CTW Makefile.
Looks good.
-
On Mon, 23 Dec 2024 19:42:34 GMT, Kim Barrett wrote:
>> I strongly suggest avoiding omnibus changes like this when possible (which it
>> is here). Just because it's all about one "kind" of change doesn't make it a
>> cohesive change. This is touching many distinct areas of the JDK, and several
>>
> This patch fixes unmatched brackets in some source files.
Qizheng Xing has updated the pull request incrementally with one additional
commit since the last revision:
Revert fix in the CTW Makefile.
-
Changes:
- all: https://git.openjdk.org/jdk/pull/22861/files
- new: https:
On Tue, 24 Dec 2024 22:22:28 GMT, Kim Barrett wrote:
>> Only this small piece would be appropriate for backport to 24. I suggest
>> splitting this out into its own bug,
>> fixing it in isolation, and backporting that.
>
> The purpose of this Makefile seems to be to build ctw.jar. So far as I ca
On Tue, 24 Dec 2024 03:26:23 GMT, Qizheng Xing wrote:
>> This patch fixes unmatched brackets in some source files.
>
> Qizheng Xing has updated the pull request incrementally with three additional
> commits since the last revision:
>
> - Update `hotspot-unit-tests.md` and HTML (using Pandoc 2.
On Tue, 24 Dec 2024 20:27:37 GMT, Kim Barrett wrote:
>> Hmm, apparently this is not run as part of tier 1-3, which I ran in my
>> patch. I wonder how this test is run. And it means this patch needs to be
>> backported to 24.
>
> Only this small piece would be appropriate for backport to 24.
On Tue, 24 Dec 2024 15:45:24 GMT, Chen Liang wrote:
>> I've tested this by running `make`, and the previous Makefile reports an
>> error like file `test/lib/jtreg/SkippedException.java)` not found. So this
>> fix is necessary.
>>
>> I also checked the git log, this change was introduced in
>>
On Tue, 24 Dec 2024 03:28:31 GMT, Qizheng Xing wrote:
>> test/hotspot/jtreg/testlibrary/ctw/Makefile line 50:
>>
>>> 48: $(TESTLIBRARY_DIR)/jdk/test/lib/util \
>>> 49: $(TESTLIBRARY_DIR)/jtreg \
>>> 50: -maxdepth 1 -name '*.java')
>>
>> I wonder why this hasn't caused problems and b
On Tue, 24 Dec 2024 03:26:23 GMT, Qizheng Xing wrote:
>> This patch fixes unmatched brackets in some source files.
>
> Qizheng Xing has updated the pull request incrementally with three additional
> commits since the last revision:
>
> - Update `hotspot-unit-tests.md` and HTML (using Pandoc 2.
On Tue, 24 Dec 2024 03:26:23 GMT, Qizheng Xing wrote:
>> This patch fixes unmatched brackets in some source files.
>
> Qizheng Xing has updated the pull request incrementally with three additional
> commits since the last revision:
>
> - Update `hotspot-unit-tests.md` and HTML (using Pandoc 2.
On Wed, 18 Dec 2024 23:02:34 GMT, Brian Burkhalter wrote:
> So I don't see any difference between a physical drive and a mounted ISO file
> with respect to this test.
I understood that the test fails on both the physical CD drive and the mounted
ISO file.
In my environment, testing with a mou
11 matches
Mail list logo
