Re: RFR: 8321413: IllegalArgumentException: Code length outside the allowed range while creating a jlink image [v14]

2024-12-20 Thread Mandy Chung
On Fri, 20 Dec 2024 23:23:55 GMT, Henry Jen wrote: >> src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/SystemModulesPlugin.java >> line 1216: >> >>> 1214: // and is load from the cache array with >>> 1215: // dedupSetValues[index] >>> 1216:

Re: RFR: 8345668: ZoneOffset.ofTotalSeconds performance regression [v3]

2024-12-20 Thread Chen Liang
On Sat, 21 Dec 2024 00:54:34 GMT, Chen Liang wrote: >> Naoto Sato has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fixed compile error > > test/micro/org/openjdk/bench/java/time/ZoneOffsetBench.java line 49: > >> 47: public void ofTo

Re: RFR: 8345668: ZoneOffset.ofTotalSeconds performance regression [v3]

2024-12-20 Thread Chen Liang
On Fri, 20 Dec 2024 21:06:16 GMT, Naoto Sato wrote: >> The change made in >> [JDK-8288723](https://bugs.openjdk.org/browse/JDK-8288723) seems innocuous, >> but it caused this performance regression. Partially reverting the change >> (ones that involve `computeIfAbsent()`) to the original. Prov

Re: RFR: 8345668: ZoneOffset.ofTotalSeconds performance regression [v3]

2024-12-20 Thread Chen Liang
On Fri, 20 Dec 2024 23:59:30 GMT, Shaojin Wen wrote: >> Hi Shaojin, >> Thanks for the suggestion, but I am not planning to improve the code more >> than backing out the offending fix at this time. (btw, cache size would be >> 149 as 18:00 and -18:00 are inclusive) > > Can I submit a PR to make

Re: RFR: 8345668: ZoneOffset.ofTotalSeconds performance regression [v3]

2024-12-20 Thread Shaojin Wen
On Fri, 20 Dec 2024 23:46:57 GMT, Naoto Sato wrote: >> For example: >> >> static final AtomicReferenceArray MINUTES_15_CACHE = new >> AtomicReferenceArray<>(37 * 4); >> >> public static ZoneOffset ofTotalSeconds(int totalSeconds) { >> // ... >> int minutes15Rem = totalSecon

Re: RFR: 8345668: ZoneOffset.ofTotalSeconds performance regression [v3]

2024-12-20 Thread Naoto Sato
On Fri, 20 Dec 2024 23:07:47 GMT, Shaojin Wen wrote: >> src/java.base/share/classes/java/time/ZoneOffset.java line 428: >> >>> 426: if (totalSeconds % (15 * SECONDS_PER_MINUTE) == 0) { >>> 427: Integer totalSecs = totalSeconds; >>> 428: ZoneOffset result = SECONDS

Re: RFR: 8343342: java/io/File/GetXSpace.java fails on Windows with CD-ROM drive [v8]

2024-12-20 Thread Brian Burkhalter
On Fri, 13 Dec 2024 10:10:16 GMT, Taizo Kurashige wrote: >> To resolve java/io/File/GetXSpace.java failure, I fix libGetXSpace.c to use >> Cygwin’s `df` to get the size for comparison if the test target drive is a >> CD-ROM drive. >> >> As described in JDK-8343342, GetDiskSpaceInformationW ca

Re: RFR: 8321413: IllegalArgumentException: Code length outside the allowed range while creating a jlink image [v14]

2024-12-20 Thread Henry Jen
On Fri, 20 Dec 2024 22:20:16 GMT, Mandy Chung wrote: >> Henry Jen has updated the pull request with a new target base due to a merge >> or a rebase. The incremental webrev excludes the unrelated changes brought >> in by the merge/rebase. The pull request contains 16 additional commits >> since

Re: RFR: 8345668: ZoneOffset.ofTotalSeconds performance regression [v3]

2024-12-20 Thread Shaojin Wen
On Fri, 20 Dec 2024 23:05:06 GMT, Shaojin Wen wrote: >> Naoto Sato has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fixed compile error > > src/java.base/share/classes/java/time/ZoneOffset.java line 428: > >> 426: if (totalSecond

Re: RFR: 8345668: ZoneOffset.ofTotalSeconds performance regression [v3]

2024-12-20 Thread Shaojin Wen
On Fri, 20 Dec 2024 21:06:16 GMT, Naoto Sato wrote: >> The change made in >> [JDK-8288723](https://bugs.openjdk.org/browse/JDK-8288723) seems innocuous, >> but it caused this performance regression. Partially reverting the change >> (ones that involve `computeIfAbsent()`) to the original. Prov

Re: RFR: 8175709: DateTimeFormatterBuilder.appendZoneId() has misleading JavaDoc [v2]

2024-12-20 Thread Roger Riggs
On Fri, 20 Dec 2024 18:12:17 GMT, Naoto Sato wrote: >> Clarifying the documentation of `DateTimeFormatterBuilder.appendZoneId()` >> and similar methods to align the description with the behavior, in which >> `ZoneOffset` is only parsed from the formatter for offset texts without any >> prefixe

Re: RFR: 8321413: IllegalArgumentException: Code length outside the allowed range while creating a jlink image [v14]

2024-12-20 Thread Mandy Chung
On Thu, 19 Dec 2024 19:14:04 GMT, Henry Jen wrote: >> This PR split out large array/set construction into separate factory methods >> to avoid oversized method trying to construct several of those. >> >> In order to do that, we will need to generate those help methods on demand >> in the class

Re: RFR: 8321413: IllegalArgumentException: Code length outside the allowed range while creating a jlink image [v3]

2024-12-20 Thread Mandy Chung
On Fri, 4 Oct 2024 18:13:11 GMT, Henry Jen wrote: >> src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/SystemModulesPlugin.java >> line 1714: >> >>> 1712: } >>> 1713: >>> 1714: class SetReference> implements >>> Comparable> { >> >> The class name `SetRefere

Re: RFR: 8345668: ZoneOffset.ofTotalSeconds performance regression [v3]

2024-12-20 Thread Naoto Sato
> The change made in [JDK-8288723](https://bugs.openjdk.org/browse/JDK-8288723) > seems innocuous, but it caused this performance regression. Partially > reverting the change (ones that involve `computeIfAbsent()`) to the original. > Provided a benchmark that iterates the call to `ZoneOffset.ofT

Re: RFR: 8345668: ZoneOffset.ofTotalSeconds performance regression [v2]

2024-12-20 Thread Naoto Sato
> The change made in [JDK-8288723](https://bugs.openjdk.org/browse/JDK-8288723) > seems innocuous, but it caused this performance regression. Partially > reverting the change (ones that involve `computeIfAbsent()`) to the original. > Provided a benchmark that iterates the call to `ZoneOffset.ofT

Re: RFR: 8345668: ZoneOffset.ofTotalSeconds performance regression [v2]

2024-12-20 Thread Naoto Sato
On Fri, 20 Dec 2024 20:25:28 GMT, Roger Riggs wrote: >> Naoto Sato has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Update src/java.base/share/classes/java/time/ZoneOffset.java >> >> Co-authored-by: Roger Riggs > > src/java.base/sha

Re: RFR: 8345668: ZoneOffset.ofTotalSeconds performance regression

2024-12-20 Thread Roger Riggs
On Fri, 20 Dec 2024 19:55:06 GMT, Naoto Sato wrote: > The change made in [JDK-8288723](https://bugs.openjdk.org/browse/JDK-8288723) > seems innocuous, but it caused this performance regression. Partially > reverting the change (ones that involve `computeIfAbsent()`) to the original. > Provided

Re: RFR: 8346739: jpackage tests failed after JDK-8345259

2024-12-20 Thread Mandy Chung
On Fri, 20 Dec 2024 19:02:38 GMT, Mandy Chung wrote: > A few jpackage tests invoke `jlink --add-modules ALL-MODULE-PATH` without > `--module-path` and they now fail because of JDK-8345259 which requires > `--module-path` to be set when `ALL-MODULE-PATH` is used. The fix is to add > `--add-mod

Re: RFR: 8346739: jpackage tests failed after JDK-8345259

2024-12-20 Thread Mandy Chung
On Fri, 20 Dec 2024 19:02:38 GMT, Mandy Chung wrote: > A few jpackage tests invoke `jlink --add-modules ALL-MODULE-PATH` without > `--module-path` and they now fail because of JDK-8345259 which requires > `--module-path` to be set when `ALL-MODULE-PATH` is used. The fix is to add > `--add-mod

Integrated: 8346739: jpackage tests failed after JDK-8345259

2024-12-20 Thread Mandy Chung
On Fri, 20 Dec 2024 19:02:38 GMT, Mandy Chung wrote: > A few jpackage tests invoke `jlink --add-modules ALL-MODULE-PATH` without > `--module-path` and they now fail because of JDK-8345259 which requires > `--module-path` to be set when `ALL-MODULE-PATH` is used. The fix is to add > `--add-mod

Re: RFR: 8346739: jpackage tests failed after JDK-8345259

2024-12-20 Thread Alexey Semenyuk
On Fri, 20 Dec 2024 19:02:38 GMT, Mandy Chung wrote: > A few jpackage tests invoke `jlink --add-modules ALL-MODULE-PATH` without > `--module-path` and they now fail because of JDK-8345259 which requires > `--module-path` to be set when `ALL-MODULE-PATH` is used. The fix is to add > `--add-mod

RFR: 8345668: ZoneOffset.ofTotalSeconds performance regression

2024-12-20 Thread Naoto Sato
The change made in [JDK-8288723](https://bugs.openjdk.org/browse/JDK-8288723) seems innocuous, but it caused this performance regression. Partially reverting the change (ones that involve `computeIfAbsent()`) to the original. Provided a benchmark that iterates the call to `ZoneOffset.ofTotalSeco

Re: RFR: 8346739: jpackage tests failed after JDK-8345259

2024-12-20 Thread Kevin Rushforth
On Fri, 20 Dec 2024 19:02:38 GMT, Mandy Chung wrote: > A few jpackage tests invoke `jlink --add-modules ALL-MODULE-PATH` without > `--module-path` and they now fail because of JDK-8345259 which requires > `--module-path` to be set when `ALL-MODULE-PATH` is used. The fix is to add > `--add-mod

Re: RFR: 8346739: jpackage tests failed after JDK-8345259

2024-12-20 Thread Kevin Rushforth
On Fri, 20 Dec 2024 19:02:38 GMT, Mandy Chung wrote: > A few jpackage tests invoke `jlink --add-modules ALL-MODULE-PATH` without > `--module-path` and they now fail because of JDK-8345259 which requires > `--module-path` to be set when `ALL-MODULE-PATH` is used. The fix is to add > `--add-mod

Re: RFR: 8323740: java.lang.ExceptionInInitializerError when trying to load XML classes in wrong order [v2]

2024-12-20 Thread Liam Miller-Cushon
> Please consider this fix for > [JDK-8323740](https://bugs.openjdk.org/browse/JDK-8323740), which avoids an > `ExceptionInInitializerError` in the class initializer of > `XMLDocumentFragmentScannerImpl` and other classes that have a circular > dependency on `jdk.xml.internal.JdkXmlUtils`. The

Re: RFR: 8346739: jpackage tests failed after JDK-8345259

2024-12-20 Thread Kevin Rushforth
On Fri, 20 Dec 2024 19:02:38 GMT, Mandy Chung wrote: > A few jpackage tests invoke `jlink --add-modules ALL-MODULE-PATH` without > `--module-path` and they now fail because of JDK-8345259 which requires > `--module-path` to be set when `ALL-MODULE-PATH` is used. The fix is to add > `--add-mod

RFR: 8346739: jpackage tests failed after JDK-8345259

2024-12-20 Thread Mandy Chung
A few jpackage tests invoke `jlink --add-modules ALL-MODULE-PATH` without `--module-path` and they now fail because of JDK-8345259 which requires `--module-path` to be set when `ALL-MODULE-PATH` is used. The fix is to add `--add-modules $JAVA_HOME/jmods` which was the default before JDK-8345259

Re: [jdk24] RFR: 8345259: Disallow ALL-MODULE-PATH without explicit --module-path

2024-12-20 Thread Mandy Chung
On Fri, 20 Dec 2024 13:25:43 GMT, Severin Gehwolf wrote: > Clean backport of [JDK-8345259](https://bugs.openjdk.org/browse/JDK-8345259) > to JDK 24 which has JEP 493. I created https://bugs.openjdk.org/browse/JDK-8345259. Looks like the tests need update. - PR Comment: https://g

[jdk24] Integrated: 8344611: Add missing classpath exception

2024-12-20 Thread Sorna Sarathi N
On Tue, 17 Dec 2024 07:49:31 GMT, Sorna Sarathi N wrote: > Hi all, > > This pull request contains a backport of commit > [458979d8](https://github.com/openjdk/jdk/commit/458979d83ac784273263b54516369d79764010dd) > from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit

Re: RFR: 8175709: DateTimeFormatterBuilder.appendZoneId() has misleading JavaDoc [v2]

2024-12-20 Thread Naoto Sato
On Fri, 20 Dec 2024 17:09:26 GMT, Roger Riggs wrote: >> Naoto Sato has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Reflects review comments > > src/java.base/share/classes/java/time/format/DateTimeFormatterBuilder.java > line 1154: > >

Re: RFR: 8175709: DateTimeFormatterBuilder.appendZoneId() has misleading JavaDoc [v2]

2024-12-20 Thread Naoto Sato
> Clarifying the documentation of `DateTimeFormatterBuilder.appendZoneId()` and > similar methods to align the description with the behavior, in which > `ZoneOffset` is only parsed from the formatter for offset texts without any > prefixes. Corresponding CSR has also been drafted. Naoto Sato ha

Re: RFR: 8024695: new File("").exists() returns false whereas it is the current working directory

2024-12-20 Thread Alan Bateman
On Fri, 20 Dec 2024 17:27:25 GMT, Brian Burkhalter wrote: > > Instead maybe we should look into the implications of fixing it. > > Does "fixing it" intend aligning it with the NIO behavior? Yes, but I think it requires working through the implications as it may be changing long standing behavi

Re: RFR: 8345259: Disallow ALL-MODULE-PATH without explicit --module-path [v14]

2024-12-20 Thread Mandy Chung
On Thu, 19 Dec 2024 21:30:10 GMT, Severin Gehwolf wrote: >> Please review this extension to #22609 which now disallows `ALL-MODULE-PATH` >> without explicit `--module-path` option or a non-existent module path. In >> addition, this fixes a bug mentioned in #22609 when `ALL-MODULE-PATH` and >>

Re: [jdk24] RFR: 8345259: Disallow ALL-MODULE-PATH without explicit --module-path

2024-12-20 Thread Alan Bateman
On Fri, 20 Dec 2024 13:25:43 GMT, Severin Gehwolf wrote: > Clean backport of [JDK-8345259](https://bugs.openjdk.org/browse/JDK-8345259) > to JDK 24 which has JEP 493. Hold off on integrating this into jdk24 until some issues with jpackage tests are figured out, I think we have some failures in

Re: RFR: 8024695: new File("").exists() returns false whereas it is the current working directory

2024-12-20 Thread Brian Burkhalter
On Fri, 20 Dec 2024 17:03:47 GMT, Alan Bateman wrote: > Instead maybe we should look into the implications of fixing it. Does "fixing it" intend aligning it with the NIO behavior? - PR Comment: https://git.openjdk.org/jdk/pull/22821#issuecomment-2557428786

Re: RFR: 8175709: DateTimeFormatterBuilder.appendZoneId() has misleading JavaDoc

2024-12-20 Thread Roger Riggs
On Thu, 19 Dec 2024 22:12:52 GMT, Naoto Sato wrote: > Clarifying the documentation of `DateTimeFormatterBuilder.appendZoneId()` and > similar methods to align the description with the behavior, in which > `ZoneOffset` is only parsed from the formatter for offset texts without any > prefixes. C

Re: RFR: 8024695: new File("").exists() returns false whereas it is the current working directory

2024-12-20 Thread Alan Bateman
On Thu, 19 Dec 2024 17:17:54 GMT, Brian Burkhalter wrote: > It is the same on macOS and presumably other Unix variants where the `access` > system call will always fail for `""`. I have not checked older versions. It's likely the same for other syscalls too, e.g. new File("").list(). Right now

Re: RFR: 8307513: C2: intrinsify Math.max(long,long) and Math.min(long,long) [v6]

2024-12-20 Thread Andrew Haley
On Fri, 20 Dec 2024 15:42:14 GMT, Fei Gao wrote: >> Galder Zamarreño has updated the pull request incrementally with five >> additional commits since the last revision: >> >> - Added comment around the assertions >> - Adjust min/max identity IR test expectations after changes >> - Fix style

Re: RFR: 8307513: C2: intrinsify Math.max(long,long) and Math.min(long,long) [v6]

2024-12-20 Thread Fei Gao
On Tue, 17 Dec 2024 18:12:24 GMT, Galder Zamarreño wrote: >> This patch intrinsifies `Math.max(long, long)` and `Math.min(long, long)` in >> order to help improve vectorization performance. >> >> Currently vectorization does not kick in for loops containing either of >> these calls because of

Re: RFR: 8346669: Increase abstraction in SetupBuildLauncher and remove extra args

2024-12-20 Thread Magnus Ihse Bursie
On Fri, 20 Dec 2024 14:31:04 GMT, Julian Waters wrote: >> We need to raise the abstraction of the SetupBuildLauncher API, to prepare >> for static launchers. We should specify the desired outcome, not what flags >> we should add. This can be seen as the last part of >> [JDK-8141444](https://bu

Request for Enhancement: java.io.Writer.of(Appendable) as an efficient alternative to java.io.StringWriter

2024-12-20 Thread Markus KARG
Dear Sirs, JDK 24 comes with Reader.of(CharSequence), now let's provide the symmetrical counterpart Writer.of(Appendable) in JDK 25! :-) For performance reasons, hereby I like to propose the new public factory method Writer.of(Appendable). This will provide the same benefits for writing, tha

[jdk24] Integrated: 8346128: Comparison build fails due to difference in LabelTarget.html

2024-12-20 Thread Nizar Benalla
On Fri, 20 Dec 2024 10:21:17 GMT, Nizar Benalla wrote: > Hi all, > > This pull request contains a backport of commit > [2a68f741](https://github.com/openjdk/jdk/commit/2a68f741884e73c9ed8e5222e57f5ecb088b3cf7) > from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit be

Re: [jdk24] RFR: 8346128: Comparison build fails due to difference in LabelTarget.html

2024-12-20 Thread Nizar Benalla
On Fri, 20 Dec 2024 10:21:17 GMT, Nizar Benalla wrote: > Hi all, > > This pull request contains a backport of commit > [2a68f741](https://github.com/openjdk/jdk/commit/2a68f741884e73c9ed8e5222e57f5ecb088b3cf7) > from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit be

Re: RFR: 8346669: Increase abstraction in SetupBuildLauncher and remove extra args

2024-12-20 Thread Julian Waters
On Thu, 19 Dec 2024 16:27:30 GMT, Magnus Ihse Bursie wrote: > We need to raise the abstraction of the SetupBuildLauncher API, to prepare > for static launchers. We should specify the desired outcome, not what flags > we should add. This can be seen as the last part of > [JDK-8141444](https://b

Re: RFR: 8302293: jar --create fails with IllegalArgumentException if archive name is shorter than 3 characters [v2]

2024-12-20 Thread Lance Andersen
On Fri, 20 Dec 2024 14:15:14 GMT, Jaikiran Pai wrote: >> Can I please get a review for this change which proposes to fix the issue >> noted in https://bugs.openjdk.org/browse/JDK-8302293? >> >> As noted in the issue, when creating a temporary file during the "jar >> --create" operation, if the

Re: RFR: 8302293: jar --create fails with IllegalArgumentException if archive name is shorter than 3 characters [v2]

2024-12-20 Thread Jaikiran Pai
> Can I please get a review for this change which proposes to fix the issue > noted in https://bugs.openjdk.org/browse/JDK-8302293? > > As noted in the issue, when creating a temporary file during the "jar > --create" operation, if the original file name is lesser than 3 characters, > the tempo

Re: [jdk24] RFR: 8346128: Comparison build fails due to difference in LabelTarget.html

2024-12-20 Thread Chen Liang
On Fri, 20 Dec 2024 10:21:17 GMT, Nizar Benalla wrote: > Hi all, > > This pull request contains a backport of commit > [2a68f741](https://github.com/openjdk/jdk/commit/2a68f741884e73c9ed8e5222e57f5ecb088b3cf7) > from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit be

Re: [jdk24] RFR: 8345259: Disallow ALL-MODULE-PATH without explicit --module-path

2024-12-20 Thread Severin Gehwolf
On Fri, 20 Dec 2024 13:25:43 GMT, Severin Gehwolf wrote: > Clean backport of [JDK-8345259](https://bugs.openjdk.org/browse/JDK-8345259) > to JDK 24 which has JEP 493. @mlchung The JDK 24 backport to the stabilization tree. Thanks in advance for the review! - PR Comment: https://g

Re: RFR: 8346669: Increase abstraction in SetupBuildLauncher and remove extra args

2024-12-20 Thread Erik Joelsson
On Thu, 19 Dec 2024 16:27:30 GMT, Magnus Ihse Bursie wrote: > We need to raise the abstraction of the SetupBuildLauncher API, to prepare > for static launchers. We should specify the desired outcome, not what flags > we should add. This can be seen as the last part of > [JDK-8141444](https://b

Re: RFR: 8346377: Properly support static builds for Windows [v2]

2024-12-20 Thread Erik Joelsson
On Fri, 20 Dec 2024 13:11:22 GMT, Magnus Ihse Bursie wrote: >> When the static launcher was introduced in >> [JDK-8339480](https://bugs.openjdk.org/browse/JDK-8339480), due to time and >> resource constraints, it was only working properly on Linux and macOS, while >> the Windows port compiled

[jdk24] RFR: 8345259: Disallow ALL-MODULE-PATH without explicit --module-path

2024-12-20 Thread Severin Gehwolf
Clean backport of [JDK-8345259](https://bugs.openjdk.org/browse/JDK-8345259) to JDK 24 which has JEP 493. - Commit messages: - Backport bcb1bdaae772c752d54939dae3a0d95892acc228 Changes: https://git.openjdk.org/jdk/pull/22849/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=

Re: RFR: 8346669: Increase abstraction in SetupBuildLauncher and remove extra args

2024-12-20 Thread Magnus Ihse Bursie
On Thu, 19 Dec 2024 22:00:09 GMT, Erik Joelsson wrote: > I'm not convinced this level of abstraction makes things better. It adds > quite a bit of overhead for adding additional customization options for when > adding new launchers. Could you elaborate more on why this is needed? I could have

Re: RFR: 8346669: Increase abstraction in SetupBuildLauncher and remove extra args

2024-12-20 Thread Magnus Ihse Bursie
On Thu, 19 Dec 2024 21:57:38 GMT, Erik Joelsson wrote: >> We need to raise the abstraction of the SetupBuildLauncher API, to prepare >> for static launchers. We should specify the desired outcome, not what flags >> we should add. This can be seen as the last part of >> [JDK-8141444](https://bu

Re: RFR: 8346377: Properly support static builds for Windows [v2]

2024-12-20 Thread Magnus Ihse Bursie
On Thu, 19 Dec 2024 21:52:10 GMT, Phil Race wrote: >> Magnus Ihse Bursie has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Fix comment > > src/java.desktop/windows/native/libawt/windows/awt_Mlib.cpp line 53: > >> 51: */ >> 52:

Re: RFR: 8346377: Properly support static builds for Windows [v2]

2024-12-20 Thread Magnus Ihse Bursie
On Thu, 19 Dec 2024 22:10:29 GMT, Erik Joelsson wrote: >> Magnus Ihse Bursie has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Fix comment > > src/hotspot/os/windows/os_windows.cpp line 316: > >> 314: } >> 315: >> 316: //

Re: RFR: 8346377: Properly support static builds for Windows [v2]

2024-12-20 Thread Magnus Ihse Bursie
On Fri, 20 Dec 2024 13:05:53 GMT, Magnus Ihse Bursie wrote: >> src/java.desktop/windows/native/libawt/windows/awt_Mlib.cpp line 53: >> >>> 51: */ >>> 52: if (JVM_IsStaticallyLinked()) { >>> 53: hDLL = ::GetModuleHandle(NULL); >> >> So this returns a handle to the pr

Re: RFR: 8346377: Properly support static builds for Windows [v2]

2024-12-20 Thread Magnus Ihse Bursie
> When the static launcher was introduced in > [JDK-8339480](https://bugs.openjdk.org/browse/JDK-8339480), due to time and > resource constraints, it was only working properly on Linux and macOS, while > the Windows port compiled but did not work. Now the time has come to fix that. > > Most of

Re: RFR: 8346377: Properly support static builds for Windows

2024-12-20 Thread Magnus Ihse Bursie
On Thu, 19 Dec 2024 21:48:27 GMT, Phil Race wrote: >> When the static launcher was introduced in >> [JDK-8339480](https://bugs.openjdk.org/browse/JDK-8339480), due to time and >> resource constraints, it was only working properly on Linux and macOS, while >> the Windows port compiled but did n

Re: RFR: 8316804: Gracefully handle the case where --release is not specified last [v3]

2024-12-20 Thread Alan Bateman
On Fri, 20 Dec 2024 12:18:46 GMT, Christian Stein wrote: >> test/jdk/tools/jar/ReleaseBeforeFiles.java line 26: >> >>> 24: /* >>> 25: * @test >>> 26: * @bug 8167237 8316804 >> >> Have you looked at multiRelease/Basic.java, that might be a better place for >> this. > > Yes, looked at it and t

Re: RFR: 8345259: Disallow ALL-MODULE-PATH without explicit --module-path [v12]

2024-12-20 Thread Severin Gehwolf
On Fri, 20 Dec 2024 11:47:28 GMT, Alan Bateman wrote: > > @AlanBateman OK for you too? Thanks! > > So --limit-modules && --add-modules ALL-MODULE-PATH is an error, as is > --add-modules ALL-MODULE-PATH without specifying --module-path. Happy with > that. I don't have time to go through the tes

Integrated: 8345259: Disallow ALL-MODULE-PATH without explicit --module-path

2024-12-20 Thread Severin Gehwolf
On Mon, 2 Dec 2024 18:25:22 GMT, Severin Gehwolf wrote: > Please review this extension to #22609 which now disallows `ALL-MODULE-PATH` > without explicit `--module-path` option or a non-existent module path. In > addition, this fixes a bug mentioned in #22609 when `ALL-MODULE-PATH` and > `--li

Re: RFR: 8345259: Disallow ALL-MODULE-PATH without explicit --module-path [v12]

2024-12-20 Thread Severin Gehwolf
On Fri, 20 Dec 2024 12:33:59 GMT, Severin Gehwolf wrote: > whether the man page needs update. If you think that's needed then I'm fine to follow up with it. I don't think that's warranted. There will be a release note. - PR Comment: https://git.openjdk.org/jdk/pull/22494#issuecomm

Re: RFR: 8316804: Gracefully handle the case where --release is not specified last [v3]

2024-12-20 Thread Alan Bateman
On Wed, 18 Dec 2024 15:37:12 GMT, Jaikiran Pai wrote: > @AlanBateman @LanceAndersen do you think this proposal is OK? Right now, the section in the man page for --release $N is when creating a MR JAR. Using --describe-module with --release $N is a useful combination as I might have a module-i

Re: RFR: 8316804: Gracefully handle the case where --release is not specified last [v3]

2024-12-20 Thread Christian Stein
On Fri, 20 Dec 2024 12:13:13 GMT, Alan Bateman wrote: >> Christian Stein has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Add two more valid use-cases > > test/jdk/tools/jar/ReleaseBeforeFiles.java line 26: > >> 24: /* >> 25: * @test >>

Re: RFR: 8316804: Gracefully handle the case where --release is not specified last [v3]

2024-12-20 Thread Alan Bateman
On Thu, 12 Dec 2024 07:44:50 GMT, Christian Stein wrote: >> Please review this change for the `jar` tool to gracefully handle the case >> where `--release` is not specified as the last arguments. >> >> Prior to this commit, operation modes `-d --describe-module` and >> `--validate` expected to

Re: RFR: 8345259: Disallow ALL-MODULE-PATH without explicit --module-path [v12]

2024-12-20 Thread Alan Bateman
On Wed, 18 Dec 2024 19:34:47 GMT, Alan Bateman wrote: >> Severin Gehwolf has updated the pull request incrementally with three >> additional commits since the last revision: >> >> - Fix comment >> - Revert "Catch case of module not in dependency tree" >> >>This reverts commit bfac4465

Re: [jdk24] RFR: 8346128: Comparison build fails due to difference in LabelTarget.html

2024-12-20 Thread Hannes Wallnöfer
On Fri, 20 Dec 2024 10:21:17 GMT, Nizar Benalla wrote: > Hi all, > > This pull request contains a backport of commit > [2a68f741](https://github.com/openjdk/jdk/commit/2a68f741884e73c9ed8e5222e57f5ecb088b3cf7) > from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit be

[jdk24] RFR: 8346128: Comparison build fails due to difference in LabelTarget.html

2024-12-20 Thread Nizar Benalla
Hi all, This pull request contains a backport of commit [2a68f741](https://github.com/openjdk/jdk/commit/2a68f741884e73c9ed8e5222e57f5ecb088b3cf7) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Nizar Benalla on 20 Dec 2024 and was re

Re: RFR: 8346128: Comparison build fails due to difference in LabelTarget.html

2024-12-20 Thread Nizar Benalla
On Thu, 19 Dec 2024 16:48:33 GMT, Nizar Benalla wrote: > Please review this doc-only patch to fix an issue that causes the > cmp-baseline build to fail. > > The snippet in `LabelTrget.java` showed a highly rare non deterministism in > javadoc snippet generation, which will be fixed in > [JDK-

Integrated: 8346667: Doccheck: warning about missing before

2024-12-20 Thread Nizar Benalla
On Thu, 19 Dec 2024 16:48:27 GMT, Nizar Benalla wrote: > Please review this doc-only patch to avoid some unwanted failures in our HTML > checks. > > Javadoc wraps everything under `@param` in a ``, so having an `h2` tag > there trips some of our tests that use html validators (html-tidy and s

Re: RFR: 8346667: Doccheck: warning about missing before [v2]

2024-12-20 Thread Nizar Benalla
On Thu, 19 Dec 2024 17:26:50 GMT, Nizar Benalla wrote: >> Please review this doc-only patch to avoid some unwanted failures in our >> HTML checks. >> >> Javadoc wraps everything under `@param` in a ``, so having an `h2` tag >> there trips some of our tests that use html validators (html-tidy

Integrated: 8346128: Comparison build fails due to difference in LabelTarget.html

2024-12-20 Thread Nizar Benalla
On Thu, 19 Dec 2024 16:48:33 GMT, Nizar Benalla wrote: > Please review this doc-only patch to fix an issue that causes the > cmp-baseline build to fail. > > The snippet in `LabelTrget.java` showed a highly rare non deterministism in > javadoc snippet generation, which will be fixed in > [JDK-

Re: RFR: 8346609: Improve MemorySegment.toString

2024-12-20 Thread Maurizio Cimadamore
On Thu, 19 Dec 2024 17:41:29 GMT, Jorn Vernee wrote: > I would find it reasonable to add `isAlive=true/false` to that, but it's not > a property of the MS itself, but of the scope that it is attached to, so I'm > not sure. And even for liveness, the fact that this info could be updated concurr

Gatherers.fold()

2024-12-20 Thread Remi Forax
Hello Victor, for the Advent of code of yesterday [1], i've this code golfing solution (the full code is here [2]) var input = ...; class Node { final HashMap map = new HashMap<>(); boolean end; } var root = new Node(); Arrays.stream(input.substring(0, input.indexOf('\n')).spli

Re: RFR: 8345259: Disallow ALL-MODULE-PATH without explicit --module-path [v12]

2024-12-20 Thread Severin Gehwolf
On Wed, 18 Dec 2024 19:34:47 GMT, Alan Bateman wrote: >> Severin Gehwolf has updated the pull request incrementally with three >> additional commits since the last revision: >> >> - Fix comment >> - Revert "Catch case of module not in dependency tree" >> >>This reverts commit bfac4465

Re: RFR: 8345259: Disallow ALL-MODULE-PATH without explicit --module-path [v14]

2024-12-20 Thread Severin Gehwolf
On Thu, 19 Dec 2024 23:17:00 GMT, Mandy Chung wrote: > Looks good. This PR uncovers unanticipated issues and thanks for looking at > them thoroughly. Thanks for the thorough reviews as well! - PR Comment: https://git.openjdk.org/jdk/pull/22494#issuecomment-2556614008

Re: RFR: 8346239: Improve memory efficiency of JimageDiffGenerator

2024-12-20 Thread Severin Gehwolf
On Fri, 20 Dec 2024 07:53:07 GMT, Matthias Baesken wrote: > Hi Severin, I added it to our build/test queue. Thanks, Matthias! - PR Comment: https://git.openjdk.org/jdk/pull/22835#issuecomment-2556610466

Re: RFR: 8346239: Improve memory efficiency of JimageDiffGenerator

2024-12-20 Thread Severin Gehwolf
On Fri, 20 Dec 2024 02:12:27 GMT, Fei Yang wrote: > Yes, I can confirm that it works on my linux-aarch64 platform. Great! Thanks! Thank you! - PR Comment: https://git.openjdk.org/jdk/pull/22835#issuecomment-2556609682