On Thu, 19 Dec 2024 02:29:07 GMT, Weijun Wang wrote:
> Just curious, if I disable the `CKM_CONCATENATE_DATA_AND_BASE` mechanism in
> the config file, then `addIKM(data).addIKM(key)` still works. I guess that's
> because the config only applies to JCA/JCE algorithms but not internal
> implement
On Wed, 18 Dec 2024 14:00:53 GMT, Weijun Wang wrote:
>> `Asserts.assertNotEquals` shows "expected 12345 to not equal 12345" which
>> sounds redundant, just say "expected not equals but was 12345".
>>
>> `Asserts.assertEqualsByteArray` uses the words "expected... to equal...".
>> Modify it to f
On Wed, 18 Dec 2024 14:00:53 GMT, Weijun Wang wrote:
>> `Asserts.assertNotEquals` shows "expected 12345 to not equal 12345" which
>> sounds redundant, just say "expected not equals but was 12345".
>>
>> `Asserts.assertEqualsByteArray` uses the words "expected... to equal...".
>> Modify it to f
On Wed, 18 Dec 2024 13:56:14 GMT, Weijun Wang wrote:
>> Also, it's not about "the same byte array", but more like "the same bytes"
>> or have equal values, right? This applies to other methods as well.
>
> Correct, I'll fix.
>
> As for its usages (in `ML_KEM_Test.java` etc), I'll be happy to fi
On Wed, 18 Dec 2024 23:22:20 GMT, Martin Balao wrote:
>> We would like to propose an implementation of the HKDF algorithms for
>> SunPKCS11, aligned with the KDF API proposed for JDK 24 (see [JEP 478: Key
>> Derivation Function API
>> (Preview)](https://bugs.openjdk.org/browse/JDK-8189808)).
>
On Thu, 12 Dec 2024 09:08:28 GMT, SendaoYan wrote:
> Hi all,
> Trivial fix to problemlist
> vmTestbase/vm/mlvm/indy/func/jvmti/mergeCP_indy2manySame_a/TestDescription.java
> in virtual thread mode to make less test noisy, it's supplement for PR
> https://github.com/openjdk/jdk/pull/21417
This
On Thu, 12 Dec 2024 09:08:28 GMT, SendaoYan wrote:
> Hi all,
> Trivial fix to problemlist
> vmTestbase/vm/mlvm/indy/func/jvmti/mergeCP_indy2manySame_a/TestDescription.java
> in virtual thread mode to make less test noisy, it's supplement for PR
> https://github.com/openjdk/jdk/pull/21417
Than
On Thu, 19 Dec 2024 00:11:34 GMT, Weijun Wang wrote:
>> Generic is a native PKCS11 key type (`CKK_GENERIC_SECRET`) that could have
>> been added to SunPKCS11 before, irrespective of HKDF. It's convenient for
>> the test to have key material in the token and test consolidation (IKM or
>> salt).
Update the specification of `java.io.File.exists()` to match its behavior,
which seems correct in the context of how the empty abstract pathname is
documented elsewhere in the class.
-
Commit messages:
- 8024695: new File("").exists() returns false whereas it is the current
workin
On Thu, 19 Dec 2024 00:36:44 GMT, Brian Burkhalter wrote:
> Update the specification of `java.io.File.exists()` to match its behavior,
> which seems correct in the context of how the empty abstract pathname is
> documented elsewhere in the class.
A CSR label will be added if this approach is d
On Wed, 18 Dec 2024 23:31:55 GMT, Martin Balao wrote:
>> src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/SunPKCS11.java
>> line 737:
>>
>>> 735: m(CKM_CHACHA20_POLY1305));
>>> 736: d(SKF, "Generic", P11SecretKeyFactory,
>>> 737: m(CKM_GENE
On Wed, 18 Dec 2024 22:48:04 GMT, Weijun Wang wrote:
>> Martin Balao has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Unused import removed.
>>
>> Co-authored-by: Martin Balao Alonso
>> Co-authored-by: Francisco Ferrari Bihurriet
On Wed, 18 Dec 2024 21:33:29 GMT, Sean Mullan wrote:
>> We included SHA1 because there could be a legacy use case to support and
>> it's part of the test vectors for RFC 5869 (HMAC-based Extract-and-Expand
>> Key Derivation Function (HKDF)). We don't recommend using it, and will
>> probably fi
> We would like to propose an implementation of the HKDF algorithms for
> SunPKCS11, aligned with the KDF API proposed for JDK 24 (see [JEP 478: Key
> Derivation Function API
> (Preview)](https://bugs.openjdk.org/browse/JDK-8189808)).
>
> This implementation will be under the _Preview_ umbrella
On Tue, 17 Dec 2024 23:40:58 GMT, Taizo Kurashige wrote:
> Could you tell me what the result would be if you tested using a virtual
> drive with the iso file mounted instead of a physical CD drive and disk?
I mounted an ISO file on `D:`. Command line execution of `df` in Cygwin:
$ df D:\\
File
On Wed, 18 Dec 2024 19:56:02 GMT, Martin Balao wrote:
>> We would like to propose an implementation of the HKDF algorithms for
>> SunPKCS11, aligned with the KDF API proposed for JDK 24 (see [JEP 478: Key
>> Derivation Function API
>> (Preview)](https://bugs.openjdk.org/browse/JDK-8189808)).
>
On Wed, 18 Dec 2024 00:30:37 GMT, Brian Burkhalter wrote:
> Also, can you tell me the version of Cygwin (output of “uname -r”)?
$ uname -r
3.4.8-1.x86_64
-
PR Comment: https://git.openjdk.org/jdk/pull/21799#issuecomment-2552410033
On Tue, 17 Dec 2024 21:43:09 GMT, Calvin Cheung wrote:
> A simple fix for removing an unused variable in fallbacklinker.c. This is
> needed for building zero jvm variant on macosx-x64.
>
> Testing:
>
> - [x] tier1
> - [x] zero jvm variant build on macosx-x64
This pull request has now been int
On Tue, 17 Dec 2024 21:43:09 GMT, Calvin Cheung wrote:
> A simple fix for removing an unused variable in fallbacklinker.c. This is
> needed for building zero jvm variant on macosx-x64.
>
> Testing:
>
> - [x] tier1
> - [x] zero jvm variant build on macosx-x64
Thanks all for the review.
--
On Tue, 17 Dec 2024 21:43:09 GMT, Calvin Cheung wrote:
> A simple fix for removing an unused variable in fallbacklinker.cpp. This is
> needed for building zero jvm variant on macosx-x64.
>
> Testing:
>
> - [x] tier1
> - [x] zero jvm variant build on macosx-x64
Okay on addressing the error han
On Wed, 18 Dec 2024 19:50:26 GMT, Martin Balao wrote:
>> src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/SunPKCS11.java
>> line 1092:
>>
>>> 1090: m(CKM_HKDF_DERIVE, CKM_HKDF_DATA));
>>> 1091: d(KDF, "HKDF-SHA512", P11KDF, m(CKM_SHA512_HMAC),
>>> 1092:
On Wed, 18 Dec 2024 14:58:26 GMT, Roger Riggs wrote:
> Continuing SM removal cleanup of tests for test/jdk/java/beans and
> test/jdk/java/io/Serializable.
> Removing doPrivileged, Permissions, and SecurityException.
This pull request has now been integrated.
Changeset: 55906692
Author:Rog
> SM Cleanup of common test library test/lib/...:
>
> Remove unnecessary catches of SecurityException
> Remove AccessController and doPrivileged from SimpleSSLContext and
> ProcessTools.
Roger Riggs has updated the pull request incrementally with one additional
commit since the last revision:
> We would like to propose an implementation of the HKDF algorithms for
> SunPKCS11, aligned with the KDF API proposed for JDK 24 (see [JEP 478: Key
> Derivation Function API
> (Preview)](https://bugs.openjdk.org/browse/JDK-8189808)).
>
> This implementation will be under the _Preview_ umbrella
On Wed, 18 Dec 2024 16:38:39 GMT, Weijun Wang wrote:
> I have never been a PKCS11 expert, but the code looks fine to me. The
> `import` line at the beginning of `CK_HKDF_PARAMS.java` is useless.
Thanks for your review. Unused import removed.
> src/jdk.crypto.cryptoki/share/classes/sun/security
On Thu, 12 Dec 2024 04:14:22 GMT, Martin Balao wrote:
>> We would like to propose an implementation of the HKDF algorithms for
>> SunPKCS11, aligned with the KDF API proposed for JDK 24 (see [JEP 478: Key
>> Derivation Function API
>> (Preview)](https://bugs.openjdk.org/browse/JDK-8189808)).
>
On Wed, 18 Dec 2024 19:11:12 GMT, Severin Gehwolf wrote:
>> Please review this extension to #22609 which now disallows `ALL-MODULE-PATH`
>> without explicit `--module-path` option or a non-existent module path. In
>> addition, this fixes a bug mentioned in #22609 when `ALL-MODULE-PATH` and
>>
On Wed, 18 Dec 2024 19:11:12 GMT, Severin Gehwolf wrote:
>> Please review this extension to #22609 which now disallows `ALL-MODULE-PATH`
>> without explicit `--module-path` option or a non-existent module path. In
>> addition, this fixes a bug mentioned in #22609 when `ALL-MODULE-PATH` and
>>
On Tue, 17 Dec 2024 11:45:56 GMT, Severin Gehwolf wrote:
>> Please review this extension to #22609 which now disallows `ALL-MODULE-PATH`
>> without explicit `--module-path` option or a non-existent module path. In
>> addition, this fixes a bug mentioned in #22609 when `ALL-MODULE-PATH` and
>>
On Thu, 12 Dec 2024 04:14:22 GMT, Martin Balao wrote:
>> We would like to propose an implementation of the HKDF algorithms for
>> SunPKCS11, aligned with the KDF API proposed for JDK 24 (see [JEP 478: Key
>> Derivation Function API
>> (Preview)](https://bugs.openjdk.org/browse/JDK-8189808)).
>
On Wed, 18 Dec 2024 19:11:12 GMT, Severin Gehwolf wrote:
>> Please review this extension to #22609 which now disallows `ALL-MODULE-PATH`
>> without explicit `--module-path` option or a non-existent module path. In
>> addition, this fixes a bug mentioned in #22609 when `ALL-MODULE-PATH` and
>>
On Wed, 18 Dec 2024 19:11:12 GMT, Severin Gehwolf wrote:
>> Please review this extension to #22609 which now disallows `ALL-MODULE-PATH`
>> without explicit `--module-path` option or a non-existent module path. In
>> addition, this fixes a bug mentioned in #22609 when `ALL-MODULE-PATH` and
>>
On Wed, 18 Dec 2024 18:25:36 GMT, Severin Gehwolf wrote:
> Only if the `$JAVA_HOME/jmods` folder is also added to the module path.
> Existing behaviour is like this:
Never mind. That's what JDK-8345573 changed.
I've reverted the eager configuration checking.
-
PR Comment: https:/
> Please review this extension to #22609 which now disallows `ALL-MODULE-PATH`
> without explicit `--module-path` option or a non-existent module path. In
> addition, this fixes a bug mentioned in #22609 when `ALL-MODULE-PATH` and
> `--limit-modules` are used in combination. It failed earlier an
On Wed, 18 Dec 2024 17:06:02 GMT, Magnus Ihse Bursie wrote:
>> In several (most? all?) of the build system files, the copyright header
>> includes the classpath exception. This makes no sense, and should be
>> removed.
>>
>> I have removed the classpath exception from makefiles, autoconf, she
On Wed, 18 Dec 2024 14:58:26 GMT, Roger Riggs wrote:
> Continuing SM removal cleanup of tests for test/jdk/java/beans and
> test/jdk/java/io/Serializable.
> Removing doPrivileged, Permissions, and SecurityException.
Beans changes look fine
-
Marked as reviewed by prr (Reviewer).
On Wed, 18 Dec 2024 17:27:24 GMT, Weijun Wang wrote:
> Will this ever happen?
>
> https://github.com/openjdk/jdk/blob/020255a72dc374ba0bdd44772047f14a8bfe69a9/test/lib/jdk/test/lib/jfr/TestClassLoader.java#L63
Yes, (my first pass removed the exception handling and tests failed).
A SecurityExcep
On Wed, 18 Dec 2024 16:22:51 GMT, Quan Anh Mai wrote:
> Hi,
>
> This patch adds the missing null checks to the shuffle arguments of the
> various `rearrangeTemplate` method. For all other API points, we null check
> arguments by calling `check` on them. As `rearrange` implementations cast the
On Wed, 18 Dec 2024 17:51:08 GMT, Paul Sandoz wrote:
>> Looks good, thanks for fixing.
>>
>> This is really a bug rather than an enhancement. In the package JavaDoc we
>> state:
>>> * For every class in this package,
>>> * unless specified otherwise, any method arguments of reference
>>> * type
On Thu, 12 Dec 2024 09:08:28 GMT, SendaoYan wrote:
> Hi all,
> Trivial fix to problemlist
> vmTestbase/vm/mlvm/indy/func/jvmti/mergeCP_indy2manySame_a/TestDescription.java
> in virtual thread mode to make less test noisy, it's supplement for PR
> https://github.com/openjdk/jdk/pull/21417
Good
On Wed, 18 Dec 2024 14:58:26 GMT, Roger Riggs wrote:
> Continuing SM removal cleanup of tests for test/jdk/java/beans and
> test/jdk/java/io/Serializable.
> Removing doPrivileged, Permissions, and SecurityException.
Marked as reviewed by lancea (Reviewer).
-
PR Review: https://gi
On Wed, 18 Dec 2024 18:01:24 GMT, Mandy Chung wrote:
> ```
> $ jlink --add-modules ALL-MODULE-PATH --module-path build/jmods
> --limit-modules jdk.net --output ./build/test-img
> ```
>
> This creates an image with jdk.net and its transitive dependences which is
> the existing behavior, right?
> Custom module layers allow for lazy loading, late binding, and full
> customization of module dependencies through the `Controller` API. However,
> it is not possible for custom layer users to late-bind services, which has
> prevented some popular application containers from moving to use Java
On Tue, 17 Dec 2024 11:45:56 GMT, Severin Gehwolf wrote:
>> Please review this extension to #22609 which now disallows `ALL-MODULE-PATH`
>> without explicit `--module-path` option or a non-existent module path. In
>> addition, this fixes a bug mentioned in #22609 when `ALL-MODULE-PATH` and
>>
On Wed, 18 Dec 2024 17:44:02 GMT, Paul Sandoz wrote:
>> Hi,
>>
>> This patch adds the missing null checks to the shuffle arguments of the
>> various `rearrangeTemplate` method. For all other API points, we null check
>> arguments by calling `check` on them. As `rearrange` implementations cast
On Wed, 18 Dec 2024 17:44:02 GMT, Paul Sandoz wrote:
>> Hi,
>>
>> This patch adds the missing null checks to the shuffle arguments of the
>> various `rearrangeTemplate` method. For all other API points, we null check
>> arguments by calling `check` on them. As `rearrange` implementations cast
On Wed, 18 Dec 2024 16:22:51 GMT, Quan Anh Mai wrote:
> Hi,
>
> This patch adds the missing null checks to the shuffle arguments of the
> various `rearrangeTemplate` method. For all other API points, we null check
> arguments by calling `check` on them. As `rearrange` implementations cast the
On Mon, 16 Dec 2024 20:33:38 GMT, Naoto Sato wrote:
> A very minor test fix.
This pull request has now been integrated.
Changeset: f7f2b42e
Author:Naoto Sato
URL:
https://git.openjdk.org/jdk/commit/f7f2b42e106c916fc1740aa0fd88ceed31260710
Stats: 1 line in 1 file changed: 1 ins;
On Mon, 16 Dec 2024 20:33:38 GMT, Naoto Sato wrote:
> A very minor test fix.
Thanks for the reviews!
-
PR Comment: https://git.openjdk.org/jdk/pull/22773#issuecomment-2551894609
On Wed, 18 Dec 2024 17:01:30 GMT, Roger Riggs wrote:
>> SM Cleanup of common test library test/lib/...:
>>
>> Remove unnecessary catches of SecurityException
>> Remove AccessController and doPrivileged from SimpleSSLContext and
>> ProcessTools.
>
> Roger Riggs has updated the pull request incre
> Custom module layers allow for lazy loading, late binding, and full
> customization of module dependencies through the `Controller` API. However,
> it is not possible for custom layer users to late-bind services, which has
> prevented some popular application containers from moving to use Java
On Tue, 17 Dec 2024 00:08:10 GMT, Paul Sandoz wrote:
> This pull request contains a backport of commit
> [31c3b191](https://github.com/openjdk/jdk/commit/31c3b191745b5c97ae4e757323355fb9831da9fe)
> from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
>
> The commit being backported
On Wed, 18 Dec 2024 17:01:30 GMT, Roger Riggs wrote:
>> SM Cleanup of common test library test/lib/...:
>>
>> Remove unnecessary catches of SecurityException
>> Remove AccessController and doPrivileged from SimpleSSLContext and
>> ProcessTools.
>
> Roger Riggs has updated the pull request incre
> In several (most? all?) of the build system files, the copyright header
> includes the classpath exception. This makes no sense, and should be removed.
>
> I have removed the classpath exception from makefiles, autoconf, shell
> scripts, properties files, configuration files, IDE support file
> SM Cleanup of common test library test/lib/...:
>
> Remove unnecessary catches of SecurityException
> Remove AccessController and doPrivileged from SimpleSSLContext and
> ProcessTools.
Roger Riggs has updated the pull request incrementally with one additional
commit since the last revision:
On Wed, 18 Dec 2024 15:00:13 GMT, Roger Riggs wrote:
> SM Cleanup of common test library test/lib/...:
>
> Remove unnecessary catches of SecurityException
> Remove AccessController and doPrivileged from SimpleSSLContext and
> ProcessTools.
LGTM
test/lib/jdk/test/lib/net/SimpleHttpServer.java
On Thu, 12 Dec 2024 04:14:22 GMT, Martin Balao wrote:
>> We would like to propose an implementation of the HKDF algorithms for
>> SunPKCS11, aligned with the KDF API proposed for JDK 24 (see [JEP 478: Key
>> Derivation Function API
>> (Preview)](https://bugs.openjdk.org/browse/JDK-8189808)).
>
On Wed, 18 Dec 2024 16:15:51 GMT, Calvin Cheung wrote:
>> We can not return to native code here in case of an error. We should
>> terminate the process instead.
>>
>> The same should really also be done in case the call to
>> `CallStaticVoidMethod` below throws an exception. This was a leftove
On Tue, 17 Dec 2024 21:43:09 GMT, Calvin Cheung wrote:
> A simple fix for removing an unused variable in fallbacklinker.cpp. This is
> needed for building zero jvm variant on macosx-x64.
>
> Testing:
>
> - [x] tier1
> - [x] zero jvm variant build on macosx-x64
Marked as reviewed by jvernee (R
Hi,
This patch adds the missing null checks to the shuffle arguments of the various
`rearrangeTemplate` method. For all other API points, we null check arguments
by calling `check` on them. As `rearrange` implementations cast the argument to
the concrete type, there is no need for species check
On Wed, 18 Dec 2024 11:58:37 GMT, Jorn Vernee wrote:
>> How about the following?
>>
>>
>> jint result = (*VM)->AttachCurrentThreadAsDaemon(VM, (void**) &env, NULL);
>> if (result != JNI_OK) {
>> fprintf(stderr, "do_upcall trying to attach thread returned %d", result);
>> return;
>>
On Wed, 18 Dec 2024 15:37:12 GMT, Jaikiran Pai wrote:
> Interestingly, neither the help text nor the jar tool specification
> https://docs.oracle.com/en/java/javase/23/docs/specs/man/jar.html states
> anywhere that the --release option is supported by the --describe-module or
> the --validate
On Thu, 12 Dec 2024 07:44:50 GMT, Christian Stein wrote:
>> Please review this change for the `jar` tool to gracefully handle the case
>> where `--release` is not specified as the last arguments.
>>
>> Prior to this commit, operation modes `-d --describe-module` and
>> `--validate` expected to
On Thu, 12 Dec 2024 07:44:50 GMT, Christian Stein wrote:
>> Please review this change for the `jar` tool to gracefully handle the case
>> where `--release` is not specified as the last arguments.
>>
>> Prior to this commit, operation modes `-d --describe-module` and
>> `--validate` expected to
On Wed, 18 Dec 2024 07:54:05 GMT, Alan Bateman wrote:
> No objection to the change but is this only an issue when something is
> reflectively load java.xml internal classes? Can it arise when using just the
> exported/supported API?
I don't know a way to reproduce it using the supported API, t
On Thu, 12 Dec 2024 07:44:50 GMT, Christian Stein wrote:
>> Please review this change for the `jar` tool to gracefully handle the case
>> where `--release` is not specified as the last arguments.
>>
>> Prior to this commit, operation modes `-d --describe-module` and
>> `--validate` expected to
On Thu, 12 Dec 2024 07:44:50 GMT, Christian Stein wrote:
>> Please review this change for the `jar` tool to gracefully handle the case
>> where `--release` is not specified as the last arguments.
>>
>> Prior to this commit, operation modes `-d --describe-module` and
>> `--validate` expected to
On Thu, 12 Dec 2024 07:44:50 GMT, Christian Stein wrote:
>> Please review this change for the `jar` tool to gracefully handle the case
>> where `--release` is not specified as the last arguments.
>>
>> Prior to this commit, operation modes `-d --describe-module` and
>> `--validate` expected to
On Wed, 18 Dec 2024 15:00:13 GMT, Roger Riggs wrote:
> SM Cleanup of common test library test/lib/...:
>
> Remove unnecessary catches of SecurityException
> Remove AccessController and doPrivileged from SimpleSSLContext and
> ProcessTools.
Looks good. I see some more in `test/lib/jdk/test/lib/
SM Cleanup of common test library test/lib/...:
Remove unnecessary catches of SecurityException
Remove AccessController and doPrivileged from SimpleSSLContext and ProcessTools.
-
Commit messages:
- 8346468: SM cleanup of common test library
Changes: https://git.openjdk.org/jdk/pull
Continuing SM removal cleanup of tests for test/jdk/java/beans and
test/jdk/java/io/Serializable.
Removing doPrivileged, Permissions, and SecurityException.
-
Commit messages:
- 8346570: SM cleanup of tests for Beans and Serialization
Changes: https://git.openjdk.org/jdk/pull/2281
On Mon, 16 Dec 2024 20:24:20 GMT, Tim Prinzing wrote:
>> Adds a JFR event for socket connect operations.
>>
>> Existing tests TestSocketEvents and TestSocketChannelEvents modified to also
>> check for connect events.
>
> Tim Prinzing has updated the pull request incrementally with one additiona
On Wed, 18 Dec 2024 02:37:05 GMT, Valerie Peng wrote:
>> test/lib/jdk/test/lib/Asserts.java line 244:
>>
>>> 242: * @see #assertEqualsByteArray(byte[], byte[], String)
>>> 243: */
>>> 244: public static void assertEqualsByteArray(byte[] expected, byte[]
>>> actual) {
>>
>> Based
> `Asserts.assertNotEquals` shows "expected 12345 to not equal 12345" which
> sounds redundant, just say "expected not equals but was 12345".
>
> `Asserts.assertEqualsByteArray` uses the words "expected... to equal...".
> Modify it to follow the `assertEquals` style ""expected... but was...".
W
On Wed, 18 Dec 2024 10:00:53 GMT, Jan Lahoda wrote:
> Hi all,
>
> This pull request contains a backport of commit
> [d50b725a](https://github.com/openjdk/jdk/commit/d50b725ac0f228f5b04dd68c123c7f6b263c0d02)
> from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
>
> The commit being
On Wed, 18 Dec 2024 10:00:53 GMT, Jan Lahoda wrote:
> Hi all,
>
> This pull request contains a backport of commit
> [d50b725a](https://github.com/openjdk/jdk/commit/d50b725ac0f228f5b04dd68c123c7f6b263c0d02)
> from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
>
> The commit being
On Wed, 18 Dec 2024 07:37:49 GMT, Calvin Cheung wrote:
>> Agree with David here. Generally I comment out unused code errors rather
>> than outright remove them for this very reason. Also fallbackLinker doesn't
>> seem to be a C++ file?
>
> How about the following?
>
>
> jint result = (*VM)-
On Tue, 17 Dec 2024 22:28:10 GMT, Mandy Chung wrote:
> > So this means `--limit-modules` has no meaning when `ALL-MODULE-PATH` is
> > specified. It will be ignored.
>
> I can't tell how it will be ignored. Maybe missing something.
>
> The transitive dependences of the modules specified to `--l
On Tue, 17 Dec 2024 22:24:47 GMT, Mandy Chung wrote:
> The combination of ALL-MODULE-PATH and `--limit-modules` indeed needs time to
> discuss. As the tests work with the current fix, we should separate this
> issue and revisit this in the future.
Thanks, yes that would be good.
> I have revi
On Wed, 18 Dec 2024 10:00:53 GMT, Jan Lahoda wrote:
> Hi all,
>
> This pull request contains a backport of commit
> [d50b725a](https://github.com/openjdk/jdk/commit/d50b725ac0f228f5b04dd68c123c7f6b263c0d02)
> from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
>
> The commit being
Hi all,
This pull request contains a backport of commit
[d50b725a](https://github.com/openjdk/jdk/commit/d50b725ac0f228f5b04dd68c123c7f6b263c0d02)
from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
The commit being backported was authored by Jan Lahoda on 18 Dec 2024 and was
revie
On Fri, 22 Nov 2024 13:42:32 GMT, Jan Lahoda wrote:
> There is a new preview language feature, `requires transitive java.base;`.
> And the `java.se` module is permitted to use the feature, without being
> marked as preview (i.e. the `java.se` module participates in preview). This
> is currentl
On Fri, 22 Nov 2024 13:42:32 GMT, Jan Lahoda wrote:
> There is a new preview language feature, `requires transitive java.base;`.
> And the `java.se` module is permitted to use the feature, without being
> marked as preview (i.e. the `java.se` module participates in preview). This
> is currentl
On Wed, 18 Dec 2024 09:12:55 GMT, Joakim Nordström
wrote:
> Could I get a review of this fix to refine the warnings printed by `libjsig`
> when using the deprecated `signal()`/`sigset()` functions?
>
> Currently the libjsig library supports chaining `signal()` and `sigset()`.
> With these fun
Could I get a review of this fix to refine the warnings printed by `libjsig`
when using the deprecated `signal()`/`sigset()` functions?
Currently the libjsig library supports chaining `signal()` and `sigset()`. With
these functions being deprecated, `libjsig` warns when a program calls either
f
On Sat, 14 Dec 2024 06:29:36 GMT, liyazzi wrote:
>> For two cases:
>>
>> 1. When the ImageReaderFactory was loaded by local jdk,that means the
>> ImageReaderFactory was loaded by boot class loader,then init the `Path
>> BOOT_MODULES_JIMAGE` by using `sun.nio.fs.DefaultFileSystemProvider` which
On Sun, 15 Dec 2024 09:46:07 GMT, Alan Bateman wrote:
> The bigger question is whether specification of FileSystems.getDefault should
> be revised to specify how it should work when the default file system
> provider is deployed as a module (which would cover the case where there the
> provide
On Tue, 17 Dec 2024 15:07:26 GMT, Weijun Wang wrote:
>> `Asserts.assertNotEquals` shows "expected 12345 to not equal 12345" which
>> sounds redundant, just say "expected not equals but was 12345".
>>
>> `Asserts.assertEqualsByteArray` uses the words "expected... to equal...".
>> Modify it to f
88 matches
Mail list logo
