Re: RFR: 8323740: java.lang.ExceptionInInitializerError when trying to load XML classes in wrong order

2024-12-17 Thread Alan Bateman
On Wed, 18 Dec 2024 02:38:28 GMT, Liam Miller-Cushon wrote: > Please consider this fix for > [JDK-8323740](https://bugs.openjdk.org/browse/JDK-8323740), which avoids an > `ExceptionInInitializerError` in the class initializer of > `XMLDocumentFragmentScannerImpl` and other classes that have a

Re: RFR: 8346132: fallbacklinker.cpp failed compilation due to unused variable

2024-12-17 Thread Calvin Cheung
On Wed, 18 Dec 2024 05:21:55 GMT, Julian Waters wrote: >> src/java.base/share/native/libfallbackLinker/fallbackLinker.c line 168: >> >>> 166: // attach thread >>> 167: JNIEnv* env; >>> 168: (*VM)->AttachCurrentThreadAsDaemon(VM, (void**) &env, NULL); >> >> I think the variable should be u

Withdrawn: 8342206: Convenience method to check if a ClassEntry matches a ClassDesc

2024-12-17 Thread duke
On Tue, 15 Oct 2024 17:34:53 GMT, Chen Liang wrote: > Currently, to efficiently check if a `ClassEntry`, such as one from an > `InvokeInstruction`, is of a particular class, we use such a pattern (as seen > in JEP 486 [Appendix](https://openjdk.org/jeps/486#Appendix)): > > inst.owner().name().

Re: RFR: 8307513: C2: intrinsify Math.max(long,long) and Math.min(long,long)

2024-12-17 Thread Emanuel Peter
On Tue, 17 Dec 2024 18:20:36 GMT, Galder Zamarreño wrote: >> @galderz Yes, there is significant duplication, sadly. Often there were old >> tests there, but then one comes along and sees that one wants to have more >> comprehensive tests. So one adds it, but does not feel 100% comfortable >> r

Re: RFR: 8307513: C2: intrinsify Math.max(long,long) and Math.min(long,long) [v6]

2024-12-17 Thread Emanuel Peter
On Tue, 17 Dec 2024 18:12:24 GMT, Galder Zamarreño wrote: >> This patch intrinsifies `Math.max(long, long)` and `Math.min(long, long)` in >> order to help improve vectorization performance. >> >> Currently vectorization does not kick in for loops containing either of >> these calls because of

Re: RFR: 8344647: Make java.se participate in the preview language feature `requires transitive java.base`

2024-12-17 Thread Joe Darcy
On Fri, 22 Nov 2024 13:42:32 GMT, Jan Lahoda wrote: > There is a new preview language feature, `requires transitive java.base;`. > And the `java.se` module is permitted to use the feature, without being > marked as preview (i.e. the `java.se` module participates in preview). This > is currentl

Re: RFR: 8346132: fallbacklinker.cpp failed compilation due to unused variable

2024-12-17 Thread Julian Waters
On Wed, 18 Dec 2024 04:39:49 GMT, David Holmes wrote: >> A simple fix for removing an unused variable in fallbacklinker.cpp. This is >> needed for building zero jvm variant on macosx-x64. >> >> Testing: >> >> - [x] tier1 >> - [x] zero jvm variant build on macosx-x64 > > src/java.base/share/nat

Re: RFR: 8346132: fallbacklinker.cpp failed compilation due to unused variable

2024-12-17 Thread David Holmes
On Tue, 17 Dec 2024 21:43:09 GMT, Calvin Cheung wrote: > A simple fix for removing an unused variable in fallbacklinker.cpp. This is > needed for building zero jvm variant on macosx-x64. > > Testing: > > - [x] tier1 > - [x] zero jvm variant build on macosx-x64 Changes requested by dholmes (Re

Re: [jdk24] RFR: 8346174: UMAX/UMIN are missing from XXXVector::reductionOperations

2024-12-17 Thread Jatin Bhateja
On Tue, 17 Dec 2024 00:08:10 GMT, Paul Sandoz wrote: > This pull request contains a backport of commit > [31c3b191](https://github.com/openjdk/jdk/commit/31c3b191745b5c97ae4e757323355fb9831da9fe) > from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported

Re: RFR: 8315487: Security Providers Filter [v17]

2024-12-17 Thread Martin Balao
On Wed, 18 Dec 2024 00:35:38 GMT, Xue-Lei Andrew Fan wrote: > Not to mention the performance impact. I am not sure if you mean the performance impact of having to make sure that the Filter is not set, or the performance impact of having the Filter disabled. For the latter, there won't be any i

RFR: 8323740: java.lang.ExceptionInInitializerError when trying to load XML classes in wrong order

2024-12-17 Thread Liam Miller-Cushon
Please consider this fix for [JDK-8323740](https://bugs.openjdk.org/browse/JDK-8323740), which avoids an `ExceptionInInitializerError` in the class initializer of `XMLDocumentFragmentScannerImpl` and other classes that have a circular dependency on `jdk.xml.internal.JdkXmlUtils`. The change bre

Re: RFR: 8340493: Fix some Asserts failure messages [v2]

2024-12-17 Thread Valerie Peng
On Wed, 18 Dec 2024 02:16:55 GMT, Valerie Peng wrote: >> Weijun Wang has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains three additional >> commits

Re: RFR: 8340493: Fix some Asserts failure messages [v2]

2024-12-17 Thread Valerie Peng
On Tue, 17 Dec 2024 15:07:26 GMT, Weijun Wang wrote: >> `Asserts.assertNotEquals` shows "expected 12345 to not equal 12345" which >> sounds redundant, just say "expected not equals but was 12345". >> >> `Asserts.assertEqualsByteArray` uses the words "expected... to equal...". >> Modify it to f

Re: RFR: 8315487: Security Providers Filter [v17]

2024-12-17 Thread Francisco Ferrari Bihurriet
On Wed, 18 Dec 2024 00:35:38 GMT, Xue-Lei Andrew Fan wrote: >> Martin Balao has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains one additional >> co

Withdrawn: 8342807: Update links in java.base to use https://

2024-12-17 Thread duke
On Tue, 22 Oct 2024 10:19:23 GMT, Eirik Bjørsnøs wrote: > Please review this cleanup PR which updates a total of 12 links to external > documentation or references in `java.base` to use https instead of plain text > http. > > Links in `java.security` and `share/data/tzdata` are excluded from t

Re: RFR: 8315487: Security Providers Filter [v17]

2024-12-17 Thread Xue-Lei Andrew Fan
On Tue, 17 Dec 2024 17:57:02 GMT, Martin Balao wrote: >> In addition to the goals, scope, motivation, specification and requirement >> notes in [JDK-8315487](https://bugs.openjdk.org/browse/JDK-8315487), we >> would like to describe the most relevant decisions taken during the >> implementatio

Re: RFR: 8343342: java/io/File/GetXSpace.java fails on Windows with CD-ROM drive [v8]

2024-12-17 Thread Brian Burkhalter
On Tue, 17 Dec 2024 23:40:58 GMT, Taizo Kurashige wrote: > I'm sorry, but I would like to know what the output looks like when you run > the df command on a virtual drive with the iso file mounted. I can investigate that tomorrow, Pacific Time. As I recall, an earlier version _did_ work with t

Re: RFR: 8343342: java/io/File/GetXSpace.java fails on Windows with CD-ROM drive [v8]

2024-12-17 Thread Taizo Kurashige
On Fri, 13 Dec 2024 21:10:31 GMT, Brian Burkhalter wrote: > It fails for me on a Windows 11 laptop with an external CD drive with a CD > inserted. On Cygwin the df command gives: Could you tell me what the result would be if you tested using a virtual drive with the iso file mounted instead of

Re: [jdk24] RFR: 8345327: JDK 24 RDP1 L10n resource files update

2024-12-17 Thread Damon Nguyen
On Mon, 16 Dec 2024 23:15:11 GMT, Justin Lu wrote: > Hi all, > > This pull request contains a backport of commit > [fd0207d5](https://github.com/openjdk/jdk/commit/fd0207d59309ae1af9539580f5bfcbc7627789cb) > from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being

Re: RFR: 8315487: Security Providers Filter [v17]

2024-12-17 Thread Martin Balao
On Tue, 17 Dec 2024 21:24:16 GMT, Xue-Lei Andrew Fan wrote: > Then, please redefine the scope and purpose of this feature. It is just a > part of the solution. Xuelei I see it differently. It's a solution for the problem that we think it is worth addressing from the JDK/JCA perspective. It's n

Re: RFR: 8315487: Security Providers Filter [v17]

2024-12-17 Thread Martin Balao
On Tue, 17 Dec 2024 22:13:09 GMT, Xue-Lei Andrew Fan wrote: > Sorry, I meant BCFIPS provider as linked in the URL I provided. Which may not > be able to use putService as it needs to support back to Java 1.5, IIRC. > Xuelei BCFIPS works too (tested on `bc-fips-2.0.0.jar`). In this case, the fi

Re: RFR: 8345259: Disallow ALL-MODULE-PATH without explicit --module-path [v11]

2024-12-17 Thread Mandy Chung
On Tue, 17 Dec 2024 11:45:56 GMT, Severin Gehwolf wrote: >> Please review this extension to #22609 which now disallows `ALL-MODULE-PATH` >> without explicit `--module-path` option or a non-existent module path. In >> addition, this fixes a bug mentioned in #22609 when `ALL-MODULE-PATH` and >>

Re: RFR: 8345259: Disallow ALL-MODULE-PATH without explicit --module-path [v11]

2024-12-17 Thread Mandy Chung
On Tue, 17 Dec 2024 11:45:56 GMT, Severin Gehwolf wrote: >> Please review this extension to #22609 which now disallows `ALL-MODULE-PATH` >> without explicit `--module-path` option or a non-existent module path. In >> addition, this fixes a bug mentioned in #22609 when `ALL-MODULE-PATH` and >>

Re: RFR: 8315487: Security Providers Filter [v17]

2024-12-17 Thread Xue-Lei Andrew Fan
On Tue, 17 Dec 2024 17:57:02 GMT, Martin Balao wrote: >> In addition to the goals, scope, motivation, specification and requirement >> notes in [JDK-8315487](https://bugs.openjdk.org/browse/JDK-8315487), we >> would like to describe the most relevant decisions taken during the >> implementatio

Re: RFR: 8328119: Support HKDF in SunPKCS11 (Preview) [v5]

2024-12-17 Thread Weijun Wang
On Thu, 12 Dec 2024 04:14:22 GMT, Martin Balao wrote: >> We would like to propose an implementation of the HKDF algorithms for >> SunPKCS11, aligned with the KDF API proposed for JDK 24 (see [JEP 478: Key >> Derivation Function API >> (Preview)](https://bugs.openjdk.org/browse/JDK-8189808)). >

RFR: 8346132: fallbacklinker.cpp failed compilation due to unused variable

2024-12-17 Thread Calvin Cheung
A simple fix for removing an unused variable in fallbacklinker.cpp. This is needed for building zero jvm variant on macosx-x64. Testing: - [x] tier1 - [x] zero jvm variant build on macosx-x64 - Commit messages: - 8346132: fallbacklinker.cpp failed compilation due to unused variabl

Re: RFR: 8315487: Security Providers Filter [v17]

2024-12-17 Thread Xue-Lei Andrew Fan
On Tue, 17 Dec 2024 17:57:02 GMT, Martin Balao wrote: >> In addition to the goals, scope, motivation, specification and requirement >> notes in [JDK-8315487](https://bugs.openjdk.org/browse/JDK-8315487), we >> would like to describe the most relevant decisions taken during the >> implementatio

Integrated: 8346151: Add transformer error logging to VerifyLocalVariableTableOnRetransformTest

2024-12-17 Thread Alex Menkov
On Fri, 13 Dec 2024 02:21:42 GMT, Alex Menkov wrote: > In some circumstances ClassFileTransformer.transform can get > ClassCircularityError or LinkageError concatenating strings (see JDK-8264667, > JDK-8262002). > VerifyLocalVariableTableOnRetransformTest fails sometimes on Oracle CI. > The fix

Re: RFR: 8345259: Disallow ALL-MODULE-PATH without explicit --module-path

2024-12-17 Thread Severin Gehwolf
On Tue, 17 Dec 2024 18:42:22 GMT, Mandy Chung wrote: > I propose to implement as described in > https://openjdk.org/jeps/261#Limiting-the-observable-modules -- to limit the > observable modules to those in the transitive closure of the named modules > plus the modules specified via the `--add-

Re: RFR: 8345259: Disallow ALL-MODULE-PATH without explicit --module-path

2024-12-17 Thread Mandy Chung
On Fri, 6 Dec 2024 18:33:06 GMT, Mandy Chung wrote: >> Please review this extension to #22609 which now disallows `ALL-MODULE-PATH` >> without explicit `--module-path` option or a non-existent module path. In >> addition, this fixes a bug mentioned in #22609 when `ALL-MODULE-PATH` and >> `--li

Re: RFR: 8307513: C2: intrinsify Math.max(long,long) and Math.min(long,long)

2024-12-17 Thread Galder Zamarreño
On Thu, 12 Dec 2024 12:03:11 GMT, Emanuel Peter wrote: >>> @galderz Thanks for taking this task on! Had a quick look at it. So >>> auto-vectorization in SuperWord should now be working, right? If yes: >>> >>> It would be nice if you tested both for `IRNode.MIN_VL` and >>> `IRNode.MIN_REDUCTION

Re: RFR: 8307513: C2: intrinsify Math.max(long,long) and Math.min(long,long) [v6]

2024-12-17 Thread Galder Zamarreño
> This patch intrinsifies `Math.max(long, long)` and `Math.min(long, long)` in > order to help improve vectorization performance. > > Currently vectorization does not kick in for loops containing either of these > calls because of the following error: > > > VLoop::check_preconditions: failed:

Re: Proposal: jar option to disable compression for selected file extensions

2024-12-17 Thread Lance Andersen
Hi Eirik, I think this proposal has merit. Outside of info-zip, are you aware of any other zip tool that does something similar? 7zip, WinZip and compress do not appear to offer similar functionality. On Dec 16, 2024, at 6:38 AM, Eirik Bjørsnøs wrote: Hi, I would like to socialize the idea

Re: RFR: 8315487: Security Providers Filter [v17]

2024-12-17 Thread Martin Balao
> In addition to the goals, scope, motivation, specification and requirement > notes in [JDK-8315487](https://bugs.openjdk.org/browse/JDK-8315487), we would > like to describe the most relevant decisions taken during the implementation > of this enhancement. These notes are organized by feature,

Re: RFR: 8346300: Add @Test annotation to TCKZoneId.test_constant_OLD_IDS_POST_2024b test

2024-12-17 Thread Naoto Sato
On Tue, 17 Dec 2024 07:59:53 GMT, Alan Bateman wrote: >> A very minor test fix. > > test/jdk/java/time/tck/java/time/TCKZoneId.java line 99: > >> 97: // SHORT_IDS >> 98: >> //--- >> 99: @Test > > A passing comment

Re: [jdk24] RFR: 8345327: JDK 24 RDP1 L10n resource files update

2024-12-17 Thread Naoto Sato
On Mon, 16 Dec 2024 23:15:11 GMT, Justin Lu wrote: > Hi all, > > This pull request contains a backport of commit > [fd0207d5](https://github.com/openjdk/jdk/commit/fd0207d59309ae1af9539580f5bfcbc7627789cb) > from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being

Re: RFR: 8315487: Security Providers Filter [v13]

2024-12-17 Thread Anthony Scarpino
On Tue, 17 Dec 2024 02:50:21 GMT, Xue-Lei Andrew Fan wrote: > I agree that this proposal cannot solve all situation. But can it address the > situations that FIPS approval can be granted? Otherwise, this proposal might > just look great but no one can use it. @martinuy mostly answered your que

Re: RFR: 8069345: (fs) FileTreeWalker throws NotDirectoryException on file junction points [v3]

2024-12-17 Thread Brian Burkhalter
On Tue, 17 Dec 2024 08:02:09 GMT, Alan Bateman wrote: > I realize you've added a comment to continue to this PR I only committed a merge from master. > but I think is going to require significant effort to audit just about every > scenario to work through potential inconsistencies. It's not cl

Re: RFR: 8342103: C2 compiler support for Float16 type and associated scalar operations [v5]

2024-12-17 Thread Emanuel Peter
On Mon, 16 Dec 2024 14:19:49 GMT, Jatin Bhateja wrote: >>> > Can you quickly summarize what tests you have, and what they test? >>> >>> Patch includes functional and performance tests, as per your suggestions IR >>> framework-based tests now cover various special cases for constant folding >>>

Re: RFR: 8342103: C2 compiler support for Float16 type and associated scalar operations [v3]

2024-12-17 Thread Emanuel Peter
On Tue, 17 Dec 2024 11:05:18 GMT, Jatin Bhateja wrote: >> src/hotspot/share/opto/divnode.cpp line 840: >> >>> 838: if (g_isnan(t1->getf()) || g_isnan(t2->getf())) { >>> 839: return TypeH::make(NAN); >>> 840: } >> >> I'm a little confused here. We are working with nodes that have type >

Re: RFR: 8342103: C2 compiler support for Float16 type and associated scalar operations [v3]

2024-12-17 Thread Emanuel Peter
On Tue, 17 Dec 2024 11:05:27 GMT, Jatin Bhateja wrote: >> Are we sure that the rounding behaviour of float is the correct behaviour >> for Float16? I would like to see some examples where rounding matters. > > FP16 has 11 bits precision and FP32 has 24 bit precision, thus as per [2P > rule ](ht

Re: RFR: 8342103: C2 compiler support for Float16 type and associated scalar operations [v3]

2024-12-17 Thread Emanuel Peter
On Tue, 17 Dec 2024 11:06:17 GMT, Jatin Bhateja wrote: >> test/hotspot/jtreg/compiler/c2/irTests/TestFloat16ScalarOperations.java line >> 275: >> >>> 273: @IR(counts = {IRNode.ADD_HF, " 0 ", IRNode.REINTERPRET_S2HF, " 0 >>> ", IRNode.REINTERPRET_HF2S, " 0 "}, >>> 274: applyIfCPUFea

Re: RFR: 8342103: C2 compiler support for Float16 type and associated scalar operations [v3]

2024-12-17 Thread Emanuel Peter
On Tue, 17 Dec 2024 11:06:13 GMT, Jatin Bhateja wrote: >> src/hotspot/share/opto/convertnode.cpp line 282: >> >>> 280: return new ReinterpretHF2SNode(binop); >>> 281: } >>> 282: } >> >> Where are the constant folding tests for this? > > This is the core idealization logic which infe

Re: RFR: 8342103: C2 compiler support for Float16 type and associated scalar operations [v3]

2024-12-17 Thread Emanuel Peter
On Tue, 17 Dec 2024 11:06:07 GMT, Jatin Bhateja wrote: >> We would need all sorts of conversion with Float16 <-> short. With Float16 >> constant and variable values. And also with short constant and variable >> values. > > Yes, there are multiple test points in newly added test which receive >

Re: RFR: 8307513: C2: intrinsify Math.max(long,long) and Math.min(long,long) [v4]

2024-12-17 Thread Galder Zamarreño
On Fri, 29 Nov 2024 11:26:10 GMT, Emanuel Peter wrote: >> Galder Zamarreño has updated the pull request with a new target base due to >> a merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains 30 additional >> comm

Re: RFR: 8315487: Security Providers Filter [v13]

2024-12-17 Thread Martin Balao
On Sun, 15 Dec 2024 07:18:02 GMT, Xue-Lei Andrew Fan wrote: > > It's only the combination of a Provider that overrides > > getService/getServices + does not call putService/put + overrides > > newInstance without calling its parent + uses a non-Java SE service type > > that would be unfiltered

RFR: 8346439: Allow late binding of module services in custom layers

2024-12-17 Thread David M . Lloyd
Custom module layers allow for lazy loading, late binding, and full customization of module dependencies through the `Controller` API. However, it is not possible for custom layer users to late-bind services, which has prevented some popular application containers from moving to use Java modules

Re: RFR: 8336881: [Linux] Support for hierarchical limits for Metrics [v13]

2024-12-17 Thread Severin Gehwolf
On Tue, 19 Nov 2024 13:37:25 GMT, Severin Gehwolf wrote: >> Please review this fix for cgroups-based metrics reporting in the >> `jdk.internal.platform` package. This fix is supposed to address wrong >> reporting of certain limits if the limits aren't set at the leaf nodes. >> >> For example,

Re: RFR: 8340493: Fix some Asserts failure messages [v2]

2024-12-17 Thread Weijun Wang
> `Asserts.assertNotEquals` shows "expected 12345 to not equal 12345" which > sounds redundant, just say "expected not equals but was 12345". > > `Asserts.assertEqualsByteArray` uses the words "expected... to equal...". > Modify it to follow the `assertEquals` style ""expected... but was...". W

Re: RFR: 8340493: Fix some Asserts failure messages [v2]

2024-12-17 Thread Weijun Wang
On Tue, 17 Dec 2024 12:57:08 GMT, Daniel Jeliński wrote: >> Are those calls from me? I know I haven't followed this pattern and I'm >> thinking about fixing them later. >> >> The reason I want to make this change is to make it consistent with the >> current `assertEquals` method that shows " e

Re: RFR: 8336881: [Linux] Support for hierarchical limits for Metrics [v14]

2024-12-17 Thread Severin Gehwolf
> Please review this fix for cgroups-based metrics reporting in the > `jdk.internal.platform` package. This fix is supposed to address wrong > reporting of certain limits if the limits aren't set at the leaf nodes. > > For example, on cg v2, the memory limit interface file is `memory.max`. > Co

Integrated: 8346432: java.lang.foreign.Linker comment typo

2024-12-17 Thread Jan Kratochvil
On Tue, 17 Dec 2024 13:45:02 GMT, Jan Kratochvil wrote: > There are 2 typos and I find the API a bit complex so it does not help a new > perplexed user of the API to be additionally confused by typos. This pull request has now been integrated. Changeset: a5503fb6 Author:Jan Kratochvil Co

Re: RFR: 8340493: Fix some Asserts failure messages

2024-12-17 Thread Weijun Wang
On Tue, 17 Dec 2024 12:57:43 GMT, Daniel Jeliński wrote: >> test/lib/jdk/test/lib/Asserts.java line 448: >> >>> 446: if ((lhs == rhs) || (lhs != null && lhs.equals(rhs))) { >>> 447: msg = Objects.toString(msg, "assertNotEquals") >>> 448: + ": expected not

Re: RFR: 8346432: java.lang.foreign.Linker comment typo

2024-12-17 Thread duke
On Tue, 17 Dec 2024 13:45:02 GMT, Jan Kratochvil wrote: > There are 2 typos and I find the API a bit complex so it does not help a new > perplexed user of the API to be additionally confused by typos. @jankratochvil Your change (at version c2f74d95ef3bd6c32eb24a4656fe164ff131a679) is now read

Re: RFR: 8315487: Security Providers Filter [v16]

2024-12-17 Thread Martin Balao
On Fri, 6 Dec 2024 19:56:07 GMT, Martin Balao wrote: >> In addition to the goals, scope, motivation, specification and requirement >> notes in [JDK-8315487](https://bugs.openjdk.org/browse/JDK-8315487), we >> would like to describe the most relevant decisions taken during the >> implementation

Re: RFR: 8346432: java.lang.foreign.Linker comment typo

2024-12-17 Thread Jorn Vernee
On Tue, 17 Dec 2024 13:45:02 GMT, Jan Kratochvil wrote: > There are 2 typos and I find the API a bit complex so it does not help a new > perplexed user of the API to be additionally confused by typos. Looks good, thanks for fixing - Marked as reviewed by jvernee (Reviewer). PR R

Re: RFR: 8346432: java.lang.foreign.Linker comment typo

2024-12-17 Thread Jan Kratochvil
On Tue, 17 Dec 2024 13:45:02 GMT, Jan Kratochvil wrote: > There are 2 typos and I find the API a bit complex so it does not help a new > perplexed user of the API to be additionally confused by typos. @JornVernee - PR Comment: https://git.openjdk.org/jdk/pull/22792#issuecomment-2

Re: RFR: 8345185: Update jpackage to not include service bindings by default [v3]

2024-12-17 Thread Severin Gehwolf
On Tue, 17 Dec 2024 13:37:00 GMT, Alexey Semenyuk wrote: > Looks good. Thank you! Thanks for the review! - PR Comment: https://git.openjdk.org/jdk/pull/22644#issuecomment-2548538306

RFR: 8346432: java.lang.foreign.Linker comment typo

2024-12-17 Thread Jan Kratochvil
There are 2 typos and I find the API a bit complex so it does not help a new perplexed user of the API to be additionally confused by typos. - Commit messages: - 8346432: java.lang.foreign.Linker comment typo Changes: https://git.openjdk.org/jdk/pull/22792/files Webrev: https://w

Re: RFR: 8345185: Update jpackage to not include service bindings by default [v3]

2024-12-17 Thread Alexey Semenyuk
On Tue, 17 Dec 2024 09:53:18 GMT, Severin Gehwolf wrote: >> Please review these changes to jpackage in light of [JEP >> 493](https://openjdk.org/jeps/493). When this feature is enabled, then some >> of the `jpackage` tests fail. The failures fall into the following >> categories: >> >> - `ALL

Re: RFR: 8340493: Fix some Asserts failure messages

2024-12-17 Thread Daniel Jeliński
On Mon, 16 Dec 2024 22:32:39 GMT, Valerie Peng wrote: >> `Asserts.assertNotEquals` shows "expected 12345 to not equal 12345" which >> sounds redundant, just say "expected not equals but was 12345". >> >> `Asserts.assertEqualsByteArray` uses the words "expected... to equal...". >> Modify it to

Re: RFR: 8340493: Fix some Asserts failure messages

2024-12-17 Thread Daniel Jeliński
On Tue, 17 Dec 2024 00:48:58 GMT, Weijun Wang wrote: >> test/lib/jdk/test/lib/Asserts.java line 272: >> >>> 270: msg = Objects.toString(msg, "assertEqualsByteArray") >>> 271: + ": expected " + HexFormat.of().formatHex(lhs) >>> 272: + " but was

Re: RFR: 8345259: Disallow ALL-MODULE-PATH without explicit --module-path [v11]

2024-12-17 Thread Severin Gehwolf
> Please review this extension to #22609 which now disallows `ALL-MODULE-PATH` > without explicit `--module-path` option or a non-existent module path. In > addition, this fixes a bug mentioned in #22609 when `ALL-MODULE-PATH` and > `--limit-modules` are used in combination. It failed earlier an

Re: RFR: 8345185: Update jpackage to not include service bindings by default [v2]

2024-12-17 Thread Severin Gehwolf
On Tue, 17 Dec 2024 03:03:13 GMT, Alexey Semenyuk wrote: >> Severin Gehwolf has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains seven additional >>

Re: RFR: 8345259: Disallow ALL-MODULE-PATH without explicit --module-path [v10]

2024-12-17 Thread Alan Bateman
On Mon, 16 Dec 2024 17:23:15 GMT, Severin Gehwolf wrote: >> Please review this extension to #22609 which now disallows `ALL-MODULE-PATH` >> without explicit `--module-path` option or a non-existent module path. In >> addition, this fixes a bug mentioned in #22609 when `ALL-MODULE-PATH` and >>

Re: RFR: 8342103: C2 compiler support for Float16 type and associated scalar operations [v3]

2024-12-17 Thread Jatin Bhateja
On Tue, 17 Dec 2024 07:15:35 GMT, Emanuel Peter wrote: >> Jatin Bhateja has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Adding more test points > > src/hotspot/share/opto/convertnode.cpp line 282: > >> 280: return new ReinterpretH

Re: RFR: 8342103: C2 compiler support for Float16 type and associated scalar operations [v3]

2024-12-17 Thread Jatin Bhateja
On Tue, 17 Dec 2024 07:22:45 GMT, Emanuel Peter wrote: >> src/hotspot/share/opto/convertnode.cpp line 960: >> >>> 958: } >>> 959: return TypeInt::SHORT; >>> 960: } >> >> Do we have tests for these constant folding operations? > > We would need all sorts of conversion with Float16 <-> short.

Re: RFR: 8342103: C2 compiler support for Float16 type and associated scalar operations [v5]

2024-12-17 Thread Jatin Bhateja
> Hi All, > > This patch adds C2 compiler support for various Float16 operations added by > [PR#22128](https://github.com/openjdk/jdk/pull/22128) > > Following is the summary of changes included with this patch:- > > 1. Detection of various Float16 operations through inline expansion or > patt

Re: RFR: 8345259: Disallow ALL-MODULE-PATH without explicit --module-path [v8]

2024-12-17 Thread Severin Gehwolf
On Mon, 16 Dec 2024 19:07:51 GMT, Mandy Chung wrote: >> jlink --add-modules ALL-MODULE-PATH --limit-modules jdk.jfr --module-path >> jmods --output all-mods-limit-mods.image >> >> >> The set of observable modules only has `java.base` and `jdk.jfr` because of >> `--limit-modules`. Hence `com

Integrated: 8345506: jar --validate may lead to java.nio.file.FileAlreadyExistsException

2024-12-17 Thread Jaikiran Pai
On Fri, 13 Dec 2024 13:17:39 GMT, Jaikiran Pai wrote: > Can I please get a review of this change which proposes to address the issue > reported in https://bugs.openjdk.org/browse/JDK-8345506? > > The `jar` tool has several operations which take `--file` as a parameter. The > value for that opt

Re: RFR: 8345506: jar --validate may lead to java.nio.file.FileAlreadyExistsException [v2]

2024-12-17 Thread Jaikiran Pai
On Tue, 17 Dec 2024 08:04:17 GMT, Alan Bateman wrote: >> Thank you Lance for the review. Alan, is it OK to proceed with this current >> change or do you think we should pursue the `REPLACE_EXISTING` option here? > > I don't object to what you have, it's the mixing of old and new APIs that > jum

Re: RFR: 8345185: Update jpackage to not include service bindings by default [v3]

2024-12-17 Thread Severin Gehwolf
> Please review these changes to jpackage in light of [JEP > 493](https://openjdk.org/jeps/493). When this feature is enabled, then some > of the `jpackage` tests fail. The failures fall into the following categories: > > - `ALL-DEFAULT` notion from `jpackage` which includes all modules that exp

Integrated: 8346120: VirtualThreadPinned event recorded for Object.wait may have wrong duration or may record second event

2024-12-17 Thread Alan Bateman
On Thu, 12 Dec 2024 17:09:09 GMT, Alan Bateman wrote: > A jdk.VirtualPinnedEvent JFR event is recorded by Object::wait when a virtual > thread waits in Object.wait while pinned. The posting of the event in > ObjectMonitor::wait is done after waiting but it can block again in > enter/ReenterI b

[jdk24] RFR: 8346069: Add missing Classpath exception statements

2024-12-17 Thread Sorna Sarathi N
Hi all, This pull request contains a backport of [openjdk/jdk#22704](https://github.com/openjdk/jdk/pull/22704.) The commit being backported was authored by Sorna Sarathi on 13 Dec 2024 and was reviewed by Amit Kumar, Alexey Semenyuk, Iris Clark and Kevin Rushforth. Thanks! - Com

Re: RFR: 8345506: jar --validate may lead to java.nio.file.FileAlreadyExistsException [v2]

2024-12-17 Thread Alan Bateman
On Tue, 17 Dec 2024 04:05:36 GMT, Jaikiran Pai wrote: >> Hello Alan, I had thought about that, but then I looked at the >> implementation of `Files.copy(...)` with `REPLACE_EXISTING`. If that option >> is specified, the `Files.copy(...)` implementation first deletes the >> existing file: >> >

Re: RFR: 8069345: (fs) FileTreeWalker throws NotDirectoryException on file junction points [v3]

2024-12-17 Thread Alan Bateman
On Tue, 17 Dec 2024 00:57:22 GMT, Brian Burkhalter wrote: >> Improve support for Windows directory junctions. > > Brian Burkhalter has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/re

Re: RFR: 8342103: C2 compiler support for Float16 type and associated scalar operations [v3]

2024-12-17 Thread Jatin Bhateja
On Tue, 17 Dec 2024 00:14:39 GMT, Paul Sandoz wrote: >> src/jdk.incubator.vector/share/classes/jdk/incubator/vector/Float16.java >> line 1415: >> >>> 1413: // double; not necessary to widen to double before the >>> 1414: // multiply. >>> 1415: short fa = float16ToRawShor

Re: RFR: 8342103: C2 compiler support for Float16 type and associated scalar operations [v4]

2024-12-17 Thread Jatin Bhateja
> Hi All, > > This patch adds C2 compiler support for various Float16 operations added by > [PR#22128](https://github.com/openjdk/jdk/pull/22128) > > Following is the summary of changes included with this patch:- > > 1. Detection of various Float16 operations through inline expansion or > patt

Re: RFR: 8346300: Add @Test annotation to TCKZoneId.test_constant_OLD_IDS_POST_2024b test

2024-12-17 Thread Alan Bateman
On Mon, 16 Dec 2024 20:33:38 GMT, Naoto Sato wrote: > A very minor test fix. test/jdk/java/time/tck/java/time/TCKZoneId.java line 99: > 97: // SHORT_IDS > 98: > //--- > 99: @Test A passing comment is that I person

[jdk24] RFR: 8344611: Add missing classpath exception

2024-12-17 Thread Sorna Sarathi N
Hi all, This pull request contains a backport of commit [458979d8](https://github.com/openjdk/jdk/commit/458979d83ac784273263b54516369d79764010dd) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Sorna Sarathi on 9 Dec 2024 and was rev