On Mon, 16 Dec 2024 14:23:16 GMT, Jatin Bhateja wrote:
>> Hi All,
>>
>> This patch adds C2 compiler support for various Float16 operations added by
>> [PR#22128](https://github.com/openjdk/jdk/pull/22128)
>>
>> Following is the summary of changes included with this patch:-
>>
>> 1. Detection
On Tue, 17 Dec 2024 07:16:37 GMT, Emanuel Peter wrote:
>> Jatin Bhateja has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Adding more test points
>
> src/hotspot/share/opto/convertnode.cpp line 960:
>
>> 958: }
>> 959: return TypeInt:
On Thu, 14 Nov 2024 11:57:52 GMT, Christian Stein wrote:
> Please review this change ensuring all targeted classes in a MR-JAR file
> should target the same or a lower classfile version. The [JAR File
> Specification](https://docs.oracle.com/javase/9/docs/specs/jar/jar.html#Multi-release)
> of
On Mon, 16 Dec 2024 14:23:26 GMT, Christian Stein wrote:
>> Please review this change ensuring all targeted classes in a MR-JAR file
>> should target the same or a lower classfile version. The [JAR File
>> Specification](https://docs.oracle.com/javase/9/docs/specs/jar/jar.html#Multi-release)
>>
On Mon, 16 Dec 2024 12:17:17 GMT, Alan Bateman wrote:
>> A jdk.VirtualPinnedEvent JFR event is recorded by Object::wait when a
>> virtual thread waits in Object.wait while pinned. The posting of the event
>> in ObjectMonitor::wait is done after waiting but it can block again in
>> enter/Reente
On Fri, 13 Dec 2024 13:41:52 GMT, Jaikiran Pai wrote:
>> src/jdk.jartool/share/classes/sun/tools/jar/Main.java line 435:
>>
>>> 433: file = createTemporaryFile("tmpJar", ".jar");
>>> 434: try (InputStream in = new
>>> FileInputStream(FileDescriptor.in)) {
It's not that I *don't* want to use version numbers, it's that in general
it doesn't account for these sorts of constraints. When I can use jmod
describe and see "oh it can only be used with a java.xml that has this
exact hash" but can't look in my bucket of java.xmls and say which ones
have that h
If you don't wish to use version numbers, why not generate a SHA256 hash
of each module instead?
--
Regards,
Peter
On 17/12/2024 1:34 pm, Ethan McCue wrote:
That might be useful, but it is not closer to what I am looking for.
I am treating it as a constraint that the repository be able to
That might be useful, but it is not closer to what I am looking for.
I am treating it as a constraint that the repository be able to hold
java.base, java.xml,etc. That those modules are tightly coupled is
information I don't want to lose.
If I have @corretto/java.base and @adoptium/java.base I ca
On Mon, 16 Dec 2024 20:21:06 GMT, Severin Gehwolf wrote:
>> Please review these changes to jpackage in light of [JEP
>> 493](https://openjdk.org/jeps/493). When this feature is enabled, then some
>> of the `jpackage` tests fail. The failures fall into the following
>> categories:
>>
>> - `ALL
On Mon, 16 Dec 2024 20:41:04 GMT, Anthony Scarpino
wrote:
> > > It's only the combination of a Provider that overrides
> > > getService/getServices + does not call putService/put + overrides
> > > newInstance without calling its parent + uses a non-Java SE service type
> > > that would be unf
> Improve support for Windows directory junctions.
Brian Burkhalter has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev excludes the unrelated changes
brought in by the merge/rebase. The pull request contains three additional
commits since the
On Mon, 16 Dec 2024 22:31:36 GMT, Valerie Peng wrote:
>> `Asserts.assertNotEquals` shows "expected 12345 to not equal 12345" which
>> sounds redundant, just say "expected not equals but was 12345".
>>
>> `Asserts.assertEqualsByteArray` uses the words "expected... to equal...".
>> Modify it to
On Mon, 16 Dec 2024 22:28:55 GMT, Valerie Peng wrote:
>> `Asserts.assertNotEquals` shows "expected 12345 to not equal 12345" which
>> sounds redundant, just say "expected not equals but was 12345".
>>
>> `Asserts.assertEqualsByteArray` uses the words "expected... to equal...".
>> Modify it to
On Mon, 16 Dec 2024 14:23:16 GMT, Jatin Bhateja wrote:
>> Hi All,
>>
>> This patch adds C2 compiler support for various Float16 operations added by
>> [PR#22128](https://github.com/openjdk/jdk/pull/22128)
>>
>> Following is the summary of changes included with this patch:-
>>
>> 1. Detection
On Mon, 16 Dec 2024 18:47:50 GMT, Joe Darcy wrote:
>> Jatin Bhateja has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Adding more test points
>
> src/jdk.incubator.vector/share/classes/jdk/incubator/vector/Float16.java line
> 1415:
>
>>
This pull request contains a backport of commit
[31c3b191](https://github.com/openjdk/jdk/commit/31c3b191745b5c97ae4e757323355fb9831da9fe)
from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
The commit being backported was authored by Paul Sandoz on 16 Dec 2024 and was
reviewed by Q
Hi all,
This pull request contains a backport of commit
[fd0207d5](https://github.com/openjdk/jdk/commit/fd0207d59309ae1af9539580f5bfcbc7627789cb)
from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
The commit being backported was authored by Justin Lu on 16 Dec 2024 and was
review
On Sun, 20 Oct 2024 23:15:44 GMT, Shaojin Wen wrote:
> Set the default value of DirectCodeBuilder::handlers to Null to reduce
> overhead in scenarios where there is no handler.
This pull request has been closed without being integrated.
-
PR: https://git.openjdk.org/jdk/pull/21598
On Fri, 20 Sep 2024 00:33:39 GMT, Weijun Wang wrote:
> `Asserts.assertNotEquals` shows "expected 12345 to not equal 12345" which
> sounds redundant, just say "expected not equals but was 12345".
>
> `Asserts.assertEqualsByteArray` uses the words "expected... to equal...".
> Modify it to follow
On Fri, 20 Sep 2024 00:33:39 GMT, Weijun Wang wrote:
> `Asserts.assertNotEquals` shows "expected 12345 to not equal 12345" which
> sounds redundant, just say "expected not equals but was 12345".
>
> `Asserts.assertEqualsByteArray` uses the words "expected... to equal...".
> Modify it to follow
On Mon, 16 Dec 2024 21:07:33 GMT, Roger Riggs wrote:
> The bug title and PR title could be a bit more informative about what test is
> affected
Good point. Renamed both titles
-
PR Comment: https://git.openjdk.org/jdk/pull/22773#issuecomment-2546853302
On Mon, 16 Dec 2024 14:23:26 GMT, Christian Stein wrote:
>> Please review this change ensuring all targeted classes in a MR-JAR file
>> should target the same or a lower classfile version. The [JAR File
>> Specification](https://docs.oracle.com/javase/9/docs/specs/jar/jar.html#Multi-release)
>>
On Mon, 16 Dec 2024 20:33:38 GMT, Naoto Sato wrote:
> A very minor test fix.
The bug title and PR title could be a bit more informative about what test is
affected
-
Marked as reviewed by rriggs (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/22773#pullrequestreview-25073
On Thu, 5 Dec 2024 22:36:12 GMT, Justin Lu wrote:
> Please review this PR which contains the open L10n drop changes for RDP1.
>
> I recommend viewing the improved diffs which are built out by Jon's tool
> here: https://cr.openjdk.org/~jlu/output/. As always, I can not confirm the
> correctnes
On Mon, 16 Dec 2024 19:23:55 GMT, Justin Lu wrote:
>> Please review this PR which contains the open L10n drop changes for RDP1.
>>
>> I recommend viewing the improved diffs which are built out by Jon's tool
>> here: https://cr.openjdk.org/~jlu/output/. As always, I can not confirm the
>> corr
On Fri, 13 Dec 2024 23:07:53 GMT, Alex Menkov wrote:
>> In some circumstances ClassFileTransformer.transform can get
>> ClassCircularityError or LinkageError concatenating strings (see
>> JDK-8264667, JDK-8262002).
>> VerifyLocalVariableTableOnRetransformTest fails sometimes on Oracle CI.
>> Th
A very minor test fix.
-
Commit messages:
- added @Test
Changes: https://git.openjdk.org/jdk/pull/22773/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=22773&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8346300
Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod
On Mon, 16 Dec 2024 20:33:38 GMT, Naoto Sato wrote:
> A very minor test fix.
Marked as reviewed by lancea (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/22773#pullrequestreview-2507320144
On Sun, 15 Dec 2024 09:15:10 GMT, Xue-Lei Andrew Fan wrote:
> > It's only the combination of a Provider that overrides
> > getService/getServices + does not call putService/put + overrides
> > newInstance without calling its parent + uses a non-Java SE service type
> > that would be unfiltered
> Adds a JFR event for socket connect operations.
>
> Existing tests TestSocketEvents and TestSocketChannelEvents modified to also
> check for connect events.
Tim Prinzing has updated the pull request incrementally with one additional
commit since the last revision:
Refactored connect except
On Thu, 12 Dec 2024 09:48:45 GMT, Daniel Fuchs wrote:
>> Tim Prinzing has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> requests fixes
>>
>> - Use IOException.toString() instead of getMessage() in case it's empty
>> - Attempts to te
On 16/12/2024 11:38, Eirik Bjørsnøs wrote:
Hi,
I would like to socialize the idea of adding a new option to the jar
tool to disable ZIP compression for selected file extensions.
The jar tool currently supports disabling ZIP compression altogether
for an archive using the -0 --no-compress opt
On Mon, 9 Dec 2024 18:24:44 GMT, Severin Gehwolf wrote:
>> I meant the use of `jdk.internal.module.ModulePath` can be replaced with
>> public API in `JLinkBundlerHelper.java`. Sorry for the confusion.
>>
>> Can test if jlink tool is available as an alternative to importing
>> `jdk.tools.jlink.
On Mon, 9 Dec 2024 18:17:28 GMT, Severin Gehwolf wrote:
>> test/jdk/tools/jpackage/share/BasicTest.java line 323:
>>
>>> 321:return;
>>> 322: }
>>> 323: }
>>
>> The better alternative would be to use `@ParameterSupplier` annotation
>> instead of the list of
On Mon, 9 Dec 2024 12:57:22 GMT, Severin Gehwolf wrote:
> Please review these changes to jpackage in light of [JEP
> 493](https://openjdk.org/jeps/493). When this feature is enabled, then some
> of the `jpackage` tests fail. The failures fall into the following categories:
>
> - `ALL-DEFAULT`
> Please review these changes to jpackage in light of [JEP
> 493](https://openjdk.org/jeps/493). When this feature is enabled, then some
> of the `jpackage` tests fail. The failures fall into the following categories:
>
> - `ALL-DEFAULT` notion from `jpackage` which includes all modules that exp
On Mon, 16 Dec 2024 19:07:51 GMT, Mandy Chung wrote:
>> jlink --add-modules ALL-MODULE-PATH --limit-modules jdk.jfr --module-path
>> jmods --output all-mods-limit-mods.image
>>
>>
>> The set of observable modules only has `java.base` and `jdk.jfr` because of
>> `--limit-modules`. Hence `com
On Mon, 16 Dec 2024 19:20:54 GMT, Justin Lu wrote:
>> Please review this PR which contains the open L10n drop changes for RDP1.
>>
>> I recommend viewing the improved diffs which are built out by Jon's tool
>> here: https://cr.openjdk.org/~jlu/output/. As always, I can not confirm the
>> corr
> Please review this PR which contains the open L10n drop changes for RDP1.
>
> I recommend viewing the improved diffs which are built out by Jon's tool
> here: https://cr.openjdk.org/~jlu/output/. As always, I can not confirm the
> correctness on the quality of the translations themselves.
>
On Fri, 13 Dec 2024 18:12:29 GMT, Mandy Chung wrote:
> JEP 343 & JEP 392 both specify that jpackage by default does not include
> service providers unless `--bind-services` is included. This should be fixed
> to match the JEP and there is no difference in behavior with a linkable
> runtime or
Chen Lian wrote:
> can you showcase any related ruby behavior using this model?
The use case is normal Ruby integer math: there's only one Integer type
that is backed either by 64-bit(ish) fixnums (wrapping a Java long) and
arbitrary precision bignums (wrapping BigInteger).
The logic in JRuby is
On Mon, 16 Dec 2024 18:55:38 GMT, Mandy Chung wrote:
>>> But this would be for a different bug so as to prevent scope-creep.
>>
>> Filed https://bugs.openjdk.org/browse/JDK-8346299 for this.
>
> jlink --add-modules ALL-MODULE-PATH --limit-modules jdk.jfr --module-path
> jmods --output all-mods-
On Mon, 16 Dec 2024 18:40:19 GMT, Severin Gehwolf wrote:
>>> A different question would be what should happen if the module specified in
>>> `--limit-modules` is **not** in the dependency graph of ALL-MODULE-PATH
>>> modules.
>>
>> This seems a good candidate for an error as it's unexpected, I
On Fri, 13 Dec 2024 18:42:27 GMT, Paul Sandoz wrote:
> Add functional support for unsigned min/max reductions on vectors.
>
> We also need to ensure that the `reductionCoerced` intrinsic bails out when
> there is no reduction operation for the lanewise operation. When intrinsic
> support is ad
On Mon, 16 Dec 2024 14:23:16 GMT, Jatin Bhateja wrote:
>> Hi All,
>>
>> This patch adds C2 compiler support for various Float16 operations added by
>> [PR#22128](https://github.com/openjdk/jdk/pull/22128)
>>
>> Following is the summary of changes included with this patch:-
>>
>> 1. Detection
On Mon, 16 Dec 2024 14:23:16 GMT, Jatin Bhateja wrote:
>> Hi All,
>>
>> This patch adds C2 compiler support for various Float16 operations added by
>> [PR#22128](https://github.com/openjdk/jdk/pull/22128)
>>
>> Following is the summary of changes included with this patch:-
>>
>> 1. Detection
On Mon, 16 Dec 2024 16:53:33 GMT, Severin Gehwolf wrote:
> But this would be for a different bug so as to prevent scope-creep.
Filed https://bugs.openjdk.org/browse/JDK-8346299 for this.
-
PR Review Comment: https://git.openjdk.org/jdk/pull/22494#discussion_r1887323080
On Sat, 14 Dec 2024 12:22:15 GMT, Eirik Bjørsnøs wrote:
> Please review this cleanup PR which removes a property and a code comment
> left behind after the `jar --normalize` feature was removed in JDK 14.
>
> The feature was deprecated in JDK-8199871 and removed in JDK-8234542, along
> with r
On Sat, 14 Dec 2024 12:22:15 GMT, Eirik Bjørsnøs wrote:
> Please review this cleanup PR which removes a property and a code comment
> left behind after the `jar --normalize` feature was removed in JDK 14.
>
> The feature was deprecated in JDK-8199871 and removed in JDK-8234542, along
> with r
On Fri, 13 Dec 2024 08:35:11 GMT, Volker Simonis wrote:
>> In the past, the Graal Compiler used `sun.misc.Unsafe` but these usages were
>> recently changed to `jdk.internal.misc.Unsafe` [1]. We should therefor
>> export `jdk.internal.misc` to `jdk.graal.compiler` which is an upgradeable
>> mod
> Please review this extension to #22609 which now disallows `ALL-MODULE-PATH`
> without explicit `--module-path` option or a non-existent module path. In
> addition, this fixes a bug mentioned in #22609 when `ALL-MODULE-PATH` and
> `--limit-modules` are used in combination. It failed earlier an
On Sun, 15 Dec 2024 09:23:47 GMT, Alan Bateman wrote:
>>> We don't usually touch the translated resources. [...] For removal then
>>> it's probably okay.
>>
>> What's your recommendation here? Happy to revert changes to translated
>> files, keeping the delete in `jar.properties`, if so desirab
On Mon, 16 Dec 2024 15:15:25 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which proposes to address the issue
>> reported in https://bugs.openjdk.org/browse/JDK-8345506?
>>
>> The `jar` tool has several operations which take `--file` as a parameter.
>> The value for tha
On Sun, 15 Dec 2024 17:48:06 GMT, Lance Andersen wrote:
> Hi all,
>
> This pull request contains a backport of commit
> [ab1dbd40](https://github.com/openjdk/jdk/commit/ab1dbd4089a1a15bdf1b6b39994d5b1faacc40ab)
> from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
>
> The
On Mon, 16 Dec 2024 13:44:03 GMT, Severin Gehwolf wrote:
> A different question would be what should happen if the module specified in
> `--limit-modules` is **not** in the dependency graph of ALL-MODULE-PATH
> modules.
This seems a good candidate for an error as it's unexpected, IMO. I'll add
> Can I please get a review of this change which proposes to address the issue
> reported in https://bugs.openjdk.org/browse/JDK-8345506?
>
> The `jar` tool has several operations which take `--file` as a parameter. The
> value for that option is a JAR file path. The `jar` operation is then run
On Mon, Dec 16, 2024 at 5:39 AM Eirik Bjørsnøs wrote:
> I propose that we add a new option, tentatively named "--no-compress-ext",
> which would take a colon-separated list of file extensions to disable ZIP
> compression for:
>
> jar --create --file archive.jar --no-compress-ext=.jpg:.png:.gz -C
> Please review this change ensuring all targeted classes in a MR-JAR file
> should target the same or a lower classfile version. The [JAR File
> Specification](https://docs.oracle.com/javase/9/docs/specs/jar/jar.html#Multi-release)
> of JavaSE 9 reads:
>
>> A class file under a versioned direc
On Mon, 16 Dec 2024 09:03:38 GMT, Emanuel Peter wrote:
> > > Can you quickly summarize what tests you have, and what they test?
> >
> >
> > Patch includes functional and performance tests, as per your suggestions IR
> > framework-based tests now cover various special cases for constant folding
> Hi All,
>
> This patch adds C2 compiler support for various Float16 operations added by
> [PR#22128](https://github.com/openjdk/jdk/pull/22128)
>
> Following is the summary of changes included with this patch:-
>
> 1. Detection of various Float16 operations through inline expansion or
> patt
Hi Davide,
Good to know the problem has been solved. I'm not sure it got solved in
the right way, though :)
Would you mind trying another fix? Instead of altering LD_LIBRARY_PATH
env var, remove _JPACKAGE_LAUNCHER env var from the environment in the
ProcessBuilder:
---
ProcessBuilder process
> Please review this extension to #22609 which now disallows `ALL-MODULE-PATH`
> without explicit `--module-path` option or a non-existent module path. In
> addition, this fixes a bug mentioned in #22609 when `ALL-MODULE-PATH` and
> `--limit-modules` are used in combination. It failed earlier an
On Fri, 13 Dec 2024 18:40:31 GMT, Mandy Chung wrote:
> This PR changes to find the root modules from the paths specified in
> --module-path only.
Yes, but in this case modules on the module path contain modules that require
`jdk.jfr`:
$ jmod describe
./build/linux-x86_64-server-release/test
On Wed, 4 Dec 2024 16:04:01 GMT, SendaoYan wrote:
>> Hi all,
>> The file src/java.base/share/native/libjli/java.c generate compile warning
>> by gcc14 with gcc options `-fsanitize=undefined -O2`, and make jdk build
>> error when configure with option `--enable-ubsan`. So I think it's necessory
> Hi all,
> The file src/java.base/share/native/libjli/java.c generate compile warning
> by gcc14 with gcc options `-fsanitize=undefined -O2`, and make jdk build
> error when configure with option `--enable-ubsan`. So I think it's necessory
> to make gcc quiet and make jdk build normally with
> Please review this change ensuring all targeted classes in a MR-JAR file
> should target the same or a lower classfile version. The [JAR File
> Specification](https://docs.oracle.com/javase/9/docs/specs/jar/jar.html#Multi-release)
> of JavaSE 9 reads:
>
>> A class file under a versioned direc
> A jdk.VirtualPinnedEvent JFR event is recorded by Object::wait when a virtual
> thread waits in Object.wait while pinned. The posting of the event in
> ObjectMonitor::wait is done after waiting but it can block again in
> enter/ReenterI before it re-acquires. If that happens then the event dur
On Wed, 4 Dec 2024 16:04:01 GMT, SendaoYan wrote:
>> Hi all,
>> The file src/java.base/share/native/libjli/java.c generate false positive
>> compile warning by gcc14 with gcc options `-fsanitize=undefined -O2`, and
>> make jdk build error when configure with option `--enable-asan
>> --enable-
On Sat, 14 Dec 2024 12:22:15 GMT, Eirik Bjørsnøs wrote:
> Please review this cleanup PR which removes a property and a code comment
> left behind after the `jar --normalize` feature was removed in JDK 14.
>
> The feature was deprecated in JDK-8199871 and removed in JDK-8234542, along
> with r
Hi,
I would like to socialize the idea of adding a new option to the jar tool
to disable ZIP compression for selected file extensions.
The jar tool currently supports disabling ZIP compression altogether for an
archive using the -0 --no-compress options.
However, different file types have differ
On Wed, 11 Dec 2024 19:29:13 GMT, Quan Anh Mai wrote:
>> Hi,
>>
>> This patch improves the performance of a typical `Arena::allocate` in
>> several ways:
>>
>> - Delay the creation of the NativeMemorySegmentImpl. This avoids the merge
>> of the instance with the one obtained from the call in
On Fri, 13 Dec 2024 18:44:55 GMT, Mandy Chung wrote:
>> Severin Gehwolf has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Test cleanup
>> - Only use the combined list when creating the finder
>
> test/jdk/tools/jlink/basic/AllModulePath
On Fri, 13 Dec 2024 18:51:18 GMT, Mandy Chung wrote:
>> How about `newScopedFinder()`?
>
> Best to leave out renaming when in doubt - either `newModuleFinder` or
> `limitFinder`.
OK. I'll go with `limitFinder`.
-
PR Review Comment: https://git.openjdk.org/jdk/pull/22494#discussion
> See the JBS bug for some details.
Raffaello Giulietti has updated the pull request incrementally with one
additional commit since the last revision:
Redacted comments.
-
Changes:
- all: https://git.openjdk.org/jdk/pull/22737/files
- new: https://git.openjdk.org/jdk/pull/227
On Fri, 13 Dec 2024 15:13:02 GMT, Severin Gehwolf wrote:
> This is a clean backport of JDK-8345573 to the stabilization repo branch of
> JDK 24 GA.
This pull request has now been integrated.
Changeset: 6e8aad1a
Author:Severin Gehwolf
URL:
https://git.openjdk.org/jdk/commit/6e8aad1a
On Fri, 13 Dec 2024 15:13:02 GMT, Severin Gehwolf wrote:
> This is a clean backport of JDK-8345573 to the stabilization repo branch of
> JDK 24 GA.
Thank you!
-
PR Comment: https://git.openjdk.org/jdk/pull/22738#issuecomment-2545078159
On Mon, 16 Dec 2024 08:32:32 GMT, Jatin Bhateja wrote:
> > Can you quickly summarize what tests you have, and what they test?
>
> Patch includes functional and performance tests, as per your suggestions IR
> framework-based tests now cover various special cases for constant folding
> transform
On Sun, 15 Dec 2024 21:57:12 GMT, j3graham wrote:
>> Raffaello Giulietti has updated the pull request with a new target base due
>> to a merge or a rebase. The incremental webrev excludes the unrelated
>> changes brought in by the merge/rebase. The pull request contains five
>> additional comm
On Mon, 16 Dec 2024 07:22:04 GMT, Emanuel Peter wrote:
> Can you quickly summarize what tests you have, and what they test?
Patch includes functional and performance tests, as per your suggestions IR
framework-based tests now cover various special cases for constant folding
transformation. Le
> Hi All,
>
> This patch adds C2 compiler support for various Float16 operations added by
> [PR#22128](https://github.com/openjdk/jdk/pull/22128)
>
> Following is the summary of changes included with this patch:-
>
> 1. Detection of various Float16 operations through inline expansion or
> patt
On Mon, 16 Dec 2024 08:13:48 GMT, Jatin Bhateja wrote:
>> Paul Sandoz has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Merge checks
>
> LGTM.
> @jatin-bhateja You may want to implement reduction intrinsics for these
> operations.
Thank
On Fri, 13 Dec 2024 21:25:48 GMT, Paul Sandoz wrote:
>> Add functional support for unsigned min/max reductions on vectors.
>>
>> We also need to ensure that the `reductionCoerced` intrinsic bails out when
>> there is no reduction operation for the lanewise operation. When intrinsic
>> support
83 matches
Mail list logo
