Re: RFR: 8346232: Remove leftovers of the jar --normalize feature

2024-12-15 Thread Alan Bateman
On Sat, 14 Dec 2024 12:22:15 GMT, Eirik Bjørsnøs wrote: > Please review this cleanup PR which removes a property and a code comment > left behind after the `jar --normalize` feature was removed in JDK 14. > > The feature was deprecated in JDK-8199871 and removed in JDK-8234542, along > with r

Re: RFR: 8346120: VirtualThreadPinned event recorded for Object.wait may have wrong duration or may record second event [v3]

2024-12-15 Thread Alan Bateman
On Sun, 15 Dec 2024 21:15:52 GMT, David Holmes wrote: >> Alan Bateman has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains seven additional >> commit

Re: RFR: 8346120: VirtualThreadPinned event recorded for Object.wait may have wrong duration or may record second event [v3]

2024-12-15 Thread Alan Bateman
On Sun, 15 Dec 2024 21:18:44 GMT, David Holmes wrote: > So to be clear ... you want one pinned event, the duration of which spans the > wait and the monitor reentry. If we are pinned for the wait then we must be > pinned for the reentry for the same reason, so no need to report the same > thin

Re: API for determining the hash of a module

2024-12-15 Thread Alan Bateman
On 16/12/2024 02:12, Ethan McCue wrote: I am experimenting with making a package repository where modules are the artifacts (bundled as JMODs) and not jars. In this context we lack information about what version a particular module requires or what provider to get that module from. What I *can*

Re: RFR: 8342103: C2 compiler support for Float16 type and associated scalar operations

2024-12-15 Thread Emanuel Peter
On Sun, 15 Dec 2024 18:05:02 GMT, Jatin Bhateja wrote: > Hi All, > > This patch adds C2 compiler support for various Float16 operations added by > [PR#22128](https://github.com/openjdk/jdk/pull/22128) > > Following is the summary of changes included with this patch:- > > 1. Detection of vario

Re: RFR: 8341184: Clean up the interaction between the launcher native code and the LauncherHelper [v13]

2024-12-15 Thread Jaikiran Pai
> Can I please get a review of this change, which simplifies the interaction > between the `java` launcher's native code with the > `sun.launcher.LauncherHelper`? > > As noted in https://bugs.openjdk.org/browse/JDK-8341184, this proposed change > reduces the back and forth between the launcher

Re: API for determining the hash of a module

2024-12-15 Thread Ethan McCue
I am experimenting with making a package repository where modules are the artifacts (bundled as JMODs) and not jars. In this context we lack information about what version a particular module requires or what provider to get that module from. What I *can* do is say "if you use this java.base, you m

Re: RFR: 8343829: Unify decimal and hexadecimal parsing in FloatingDecimal [v3]

2024-12-15 Thread j3graham
On Fri, 13 Dec 2024 16:06:53 GMT, Raffaello Giulietti wrote: >> See the JBS bug for some details. > > Raffaello Giulietti has updated the pull request with a new target base due > to a merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. Th

Re: RFR: 8346120: VirtualThreadPinned event recorded for Object.wait may have wrong duration or may record second event [v3]

2024-12-15 Thread David Holmes
On Sat, 14 Dec 2024 16:27:19 GMT, Alan Bateman wrote: >> A jdk.VirtualPinnedEvent JFR event is recorded by Object::wait when a >> virtual thread waits in Object.wait while pinned. The posting of the event >> in ObjectMonitor::wait is done after waiting but it can block again in >> enter/Reente

Re: [jdk24] RFR: 8346202: Correct typo in SQLPermission

2024-12-15 Thread Iris Clark
On Sun, 15 Dec 2024 17:48:06 GMT, Lance Andersen wrote: > Hi all, > > This pull request contains a backport of commit > [ab1dbd40](https://github.com/openjdk/jdk/commit/ab1dbd4089a1a15bdf1b6b39994d5b1faacc40ab) > from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The

Re: RFR: 8342103: C2 compiler support for Float16 type and associated scalar operations

2024-12-15 Thread Jatin Bhateja
On Sun, 15 Dec 2024 18:05:02 GMT, Jatin Bhateja wrote: > Hi All, > > This patch adds C2 compiler support for various Float16 operations added by > [PR#22128](https://github.com/openjdk/jdk/pull/22128) > > Following is the summary of changes included with this patch:- > > 1. Detection of vario

RFR: 8342103: C2 compiler support for Float16 type and associated scalar operations

2024-12-15 Thread Jatin Bhateja
Hi All, This patch adds C2 compiler support for various Float16 operations added by [PR#22128](https://github.com/openjdk/jdk/pull/22128) Following is the summary of changes included with this patch:- 1. Detection of various Float16 operations through inline expansion or pattern folding ideali

Withdrawn: 8342103: C2 compiler support for Float16 type and associated operations

2024-12-15 Thread Jatin Bhateja
On Mon, 14 Oct 2024 11:40:01 GMT, Jatin Bhateja wrote: > Hi All, > > This patch adds C2 compiler support for various Float16 operations added by > [PR#22128](https://github.com/openjdk/jdk/pull/22128) > > Following is the summary of changes included with this patch:- > > 1. Detection of vario

[jdk24] RFR: 8346202: Correct typo in SQLPermission

2024-12-15 Thread Lance Andersen
Hi all, This pull request contains a backport of commit [ab1dbd40](https://github.com/openjdk/jdk/commit/ab1dbd4089a1a15bdf1b6b39994d5b1faacc40ab) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Lance Andersen on 15 Dec 2024 a

Integrated: 8346202: Correct typo in SQLPermission

2024-12-15 Thread Lance Andersen
On Fri, 13 Dec 2024 16:54:05 GMT, Lance Andersen wrote: > Please review this trivial PR which removes `(See below)` which was missed > during the SQLPermission update as part of the updates for [JEP 486: > Permanently Disable the Security Manager](https://openjdk.org/jeps/486) > > I have con

Re: RFR: 8331467: ImageReaderFactory can cause a ClassNotFoundException if the default FileSystemProvider is not the system-default provider [v7]

2024-12-15 Thread Alan Bateman
On Sat, 14 Dec 2024 06:29:36 GMT, liyazzi wrote: >> For two cases: >> >> 1. When the ImageReaderFactory was loaded by local jdk,that means the >> ImageReaderFactory was loaded by boot class loader,then init the `Path >> BOOT_MODULES_JIMAGE` by using `sun.nio.fs.DefaultFileSystemProvider` which

Re: RFR: 8346232: Remove leftovers of the jar --normalize feature

2024-12-15 Thread Alan Bateman
On Sun, 15 Dec 2024 08:52:12 GMT, Eirik Bjørsnøs wrote: > What's your recommendation here? Happy to revert changes to translated files, > keeping the delete in `jar.properties`, if so desirable. > > This would rely on Oracle's translation update process catching the remval > and update it, ide

Re: RFR: 8315487: Security Providers Filter [v13]

2024-12-15 Thread Xue-Lei Andrew Fan
On Sun, 15 Dec 2024 07:18:02 GMT, Xue-Lei Andrew Fan wrote: > It's only the combination of a Provider that overrides getService/getServices > + does not call putService/put + overrides newInstance without calling its > parent + uses a non-Java SE service type that would be unfiltered. FYI, Jav

Re: RFR: 8346232: Remove leftovers of the jar --normalize feature

2024-12-15 Thread Eirik Bjørsnøs
On Sun, 15 Dec 2024 08:40:24 GMT, Alan Bateman wrote: >> Please review this cleanup PR which removes a property and a code comment >> left behind after the `jar --normalize` feature was removed in JDK 14. >> >> The feature was deprecated in JDK-8199871 and removed in JDK-8234542, along >> wit

Re: RFR: 8346232: Remove leftovers of the jar --normalize feature

2024-12-15 Thread Alan Bateman
On Sat, 14 Dec 2024 12:22:15 GMT, Eirik Bjørsnøs wrote: > Please review this cleanup PR which removes a property and a code comment > left behind after the `jar --normalize` feature was removed in JDK 14. > > The feature was deprecated in JDK-8199871 and removed in JDK-8234542, along > with r