On Tue, 10 Dec 2024 07:09:33 GMT, Jatin Bhateja wrote:
>> Quan Anh Mai has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> adverb order
>
> src/jdk.incubator.vector/share/classes/jdk/incubator/vector/Byte128Vector.java
> line 822:
>
>> 820
On Mon, 9 Dec 2024 14:12:19 GMT, Quan Anh Mai wrote:
>> Hi,
>>
>> This is just a redo of https://github.com/openjdk/jdk/pull/13093. mostly
>> just the revert of the backout.
>>
>> Regarding the related issues:
>>
>> - [JDK-8306008](https://bugs.openjdk.org/browse/JDK-8306008) and
>> [JDK-830
On Mon, 9 Dec 2024 14:12:19 GMT, Quan Anh Mai wrote:
>> Hi,
>>
>> This is just a redo of https://github.com/openjdk/jdk/pull/13093. mostly
>> just the revert of the backout.
>>
>> Regarding the related issues:
>>
>> - [JDK-8306008](https://bugs.openjdk.org/browse/JDK-8306008) and
>> [JDK-830
On Mon, 9 Dec 2024 14:12:19 GMT, Quan Anh Mai wrote:
>> Hi,
>>
>> This is just a redo of https://github.com/openjdk/jdk/pull/13093. mostly
>> just the revert of the backout.
>>
>> Regarding the related issues:
>>
>> - [JDK-8306008](https://bugs.openjdk.org/browse/JDK-8306008) and
>> [JDK-830
On Fri, 6 Dec 2024 00:43:29 GMT, Damon Nguyen wrote:
>> That's because the English source file had an update to introduce those
>> double single quotes. (See
>> https://cr.openjdk.org/~jlu/output/src/jdk.compiler/share/classes/com/sun/tools/javac/resources/javac.html).
>> It's just being updat
On Thu, 5 Dec 2024 22:36:12 GMT, Justin Lu wrote:
> Please review this PR which contains the open L10n drop changes for RDP1.
>
> I recommend viewing the improved diffs which are built out by Jon's tool
> here: https://cr.openjdk.org/~jlu/output/. As always, I can not confirm the
> correctnes
On Thu, 5 Dec 2024 22:36:12 GMT, Justin Lu wrote:
> Please review this PR which contains the open L10n drop changes for RDP1.
>
> I recommend viewing the improved diffs which are built out by Jon's tool
> here: https://cr.openjdk.org/~jlu/output/. As always, I can not confirm the
> correctnes
On Mon, 9 Dec 2024 15:42:57 GMT, Magnus Ihse Bursie wrote:
>> Some files have been modified in 2024, but the copyright year has not been
>> properly updated. This should be fixed.
>>
>> I have located these modified files using:
>>
>> git log --since="Jan 1" --name-only --pretty=format: | sor
On Mon, 9 Dec 2024 19:18:56 GMT, Archie Cobbs wrote:
>> Please review this patch which removes unnecessary `@SuppressWarnings`
>> annotations.
>
> Archie Cobbs has updated the pull request with a new target base due to a
> merge or a rebase. The pull request now contains 15 commits:
>
> - Rem
On Mon, 9 Dec 2024 12:57:22 GMT, Severin Gehwolf wrote:
> Please review these changes to jpackage in light of [JEP
> 493](https://openjdk.org/jeps/493). When this feature is enabled, then some
> of the `jpackage` tests fail. The failures fall into the following categories:
>
> - `ALL-DEFAULT`
On Mon, 9 Dec 2024 15:45:42 GMT, Magnus Ihse Bursie wrote:
>> That git query isn't correct for all the files in the repo. In particular,
>> the copyrights on third party files are NOT updated uniformly when new
>> versions are applied. In particular, XML files are NOT updated.
>
>> That git que
> Some files have been modified in 2024, but the copyright year has not been
> properly updated. This should be fixed.
>
> I have located these modified files using:
>
> git log --since="Jan 1" --name-only --pretty=format: | sort -u > file.list
>
> and then run a script to update the copyright
> Please review this extension to #22609 which now disallows `ALL-MODULE-PATH`
> without explicit `--module-path` option. In addition this fixes a bug
> mentioned in #22609 when `ALL-MODULE-PATH` and `--limit-modules` are used in
> combination it failed earlier and passes now due to alignment of
On Mon, 9 Dec 2024 19:16:59 GMT, Alexey Semenyuk wrote:
> > You can create custom runtimes from it, just not include jdk.jlink in the
> > output image that you generate.
>
> I understand "the output image" will not have jdk.jlink part. Does this mean
> there will be no "jlink" tool in "the out
On Mon, 9 Dec 2024 20:38:18 GMT, Eirik Bjørsnøs wrote:
>> Magnus Ihse Bursie has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Revert mistaken changes to binary file
>
> src/jdk.httpserver/share/classes/sun/net/httpserver/simpleserver/reso
On Mon, 9 Dec 2024 13:02:15 GMT, Magnus Ihse Bursie wrote:
> Some files have been modified in 2024, but the copyright year has not been
> properly updated. This should be fixed.
>
> I have located these modified files using:
>
> git log --since="Jan 1" --name-only --pretty=format: | sort -u >
FWIW, when I've thought about the topic of copyright and licenses
before, I think there are several aspects that can be separated.
One is a syntactic-only check, as the in-flight Skara PR may provide. I
think having a syntactic-only check is Skara is reasonable.
A semantic check is "does file
On Fri, 15 Nov 2024 11:53:00 GMT, Adam Sotona wrote:
>> Class-File API is leaving preview.
>> This is a removal of all `@PreviewFeature` annotations from Class-File API.
>> It also bumps all `@since` tags and removes
>> `jdk.internal.javac.PreviewFeature.Feature.CLASSFILE_API`.
>>
>> Please rev
On Mon, 9 Dec 2024 17:22:14 GMT, Roger Riggs wrote:
> Replace broken getProperty with Boolean.getBoolean.
>
> Manual testing confirms trace messages are enabled with
> `-Dresource.bundle.debug=true`
Marked as reviewed by eirbjo (Committer).
-
PR Review: https://git.openjdk.org/jd
On Mon, 9 Dec 2024 13:02:15 GMT, Magnus Ihse Bursie wrote:
> Some files have been modified in 2024, but the copyright year has not been
> properly updated. This should be fixed.
>
> I have located these modified files using:
>
> git log --since="Jan 1" --name-only --pretty=format: | sort -u >
On Mon, 9 Dec 2024 15:42:57 GMT, Magnus Ihse Bursie wrote:
>> Some files have been modified in 2024, but the copyright year has not been
>> properly updated. This should be fixed.
>>
>> I have located these modified files using:
>>
>> git log --since="Jan 1" --name-only --pretty=format: | sor
On Mon, 9 Dec 2024 17:22:14 GMT, Roger Riggs wrote:
> Replace broken getProperty with Boolean.getBoolean.
>
> Manual testing confirms trace messages are enabled with
> `-Dresource.bundle.debug=true`
Marked as reviewed by lancea (Reviewer).
-
PR Review: https://git.openjdk.org/jdk
OK thanks. Apologies for getting confused, I'm not familiar with the skara
code so I'm not always sure what I'm looking at.
I personally think Skara shouldn't do that, but it is a topic that might be
> worth discussing for a future Enhancement.
I think it's a good idea, but only to the extent th
On Mon, 9 Dec 2024 12:57:22 GMT, Severin Gehwolf wrote:
> Please review these changes to jpackage in light of [JEP
> 493](https://openjdk.org/jeps/493). When this feature is enabled, then some
> of the `jpackage` tests fail. The failures fall into the following categories:
>
> - `ALL-DEFAULT`
> Please review this patch which removes unnecessary `@SuppressWarnings`
> annotations.
Archie Cobbs has updated the pull request with a new target base due to a merge
or a rebase. The pull request now contains 15 commits:
- Remove more unnecessary suppressions.
- Merge branch 'master' into S
On Mon, 9 Dec 2024 19:00:28 GMT, Mandy Chung wrote:
> The jpackage tool packages a Java application into a platform-specific
> package with all necessary dependencies
It can package a runtime, not only an app in the native package.
> I hardly see how ALL-DEFAULT and ALL-MODULE-PATH tokens are
Hi Davide,
An app launcher generated by jpackage runs `rpm` and `dpkg` queries to
detect the package that owns it.
Why does it need to know the name of the package? The app launcher needs
to locate the corresponding ".cfg" (.cfg) file in the
app image to read the startup configuration. If you
On Mon, 9 Dec 2024 12:57:22 GMT, Severin Gehwolf wrote:
> Please review these changes to jpackage in light of [JEP
> 493](https://openjdk.org/jeps/493). When this feature is enabled, then some
> of the `jpackage` tests fail. The failures fall into the following categories:
>
> - `ALL-DEFAULT`
> Please review this bug fix for using `jlink` when linking from the run-time
> image. For regular JDK builds which include the `jmods` folder, that path is
> automatically added as the `--module-path` when not otherwise specified on
> the command line. For JDK builds with JEP 493 enabled, the `
No, The Skara PR in question isn't proposing to do this. Rather it is
checking that _if_ the Copyright header is updated, it is syntactically
correct.
It would be an item for further discussion to have Skara actually get
into the business of whether the copyright header should be updated and
On Mon, 9 Dec 2024 18:26:13 GMT, Alexey Semenyuk wrote:
> > The question is how useful do users see the need to have jdk.jlink part
> > when they don't use the --runtime-image option and jpackage
>
> If they don't use `--runtime-image` option, and jdk.jlink module is not
> available there is n
On Fri, 15 Nov 2024 11:53:00 GMT, Adam Sotona wrote:
>> Class-File API is leaving preview.
>> This is a removal of all `@PreviewFeature` annotations from Class-File API.
>> It also bumps all `@since` tags and removes
>> `jdk.internal.javac.PreviewFeature.Feature.CLASSFILE_API`.
>>
>> Please rev
On Wed, Dec 4, 2024 at 3:47 PM Eirik Bjørsnøs wrote:
> The OpenJDK includes many boolean flags in the form of system properties.
> These toggle different behavior such as debug logging, verification,
> caching, compatibility and conditional features.
>
To learn more about how the JDK uses boole
On Fri, 6 Dec 2024 15:11:20 GMT, Chen Liang wrote:
> Hi all,
>
> This pull request contains a backport of commit
> [49664195](https://github.com/openjdk/jdk/commit/496641955041c5e48359e6256a4a61812653d900)
> from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
>
> This is a test-on
On Fri, 6 Dec 2024 15:11:20 GMT, Chen Liang wrote:
> Hi all,
>
> This pull request contains a backport of commit
> [49664195](https://github.com/openjdk/jdk/commit/496641955041c5e48359e6256a4a61812653d900)
> from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
>
> This is a test-on
Bleh, ignore my comment. I didn't realize the PR#1702 you referenced is
already proposing doing this!
-Archie
On Mon, Dec 9, 2024 at 10:45 AM Archie Cobbs wrote:
> Thanks for working on this... something of a thankless task :)
>
> I'm sure you've considered this but I'll ask anyway. Would it ma
> Please review this bug fix for using `jlink` when linking from the run-time
> image. For regular JDK builds which include the `jmods` folder, that path is
> automatically added as the `--module-path` when not otherwise specified on
> the command line. For JDK builds with JEP 493 enabled, the `
> Please review this fix for JEP 493 enabled JDKs related to the
> `--limit-modules` option. The existing jlink `bindservices` tests cover this
> issue. Previously they didn't run on a JEP 493 enabled JDK, since `jmods`
> folder is missing for them.
>
> The gist of the issue is that multiple `M
On Mon, 9 Dec 2024 18:15:32 GMT, Severin Gehwolf wrote:
> Technically it could be part, but it's just not allowed (yet) by policy
Maybe relax the policy given it causes inconvenience already? :-)
-
PR Comment: https://git.openjdk.org/jdk/pull/22644#issuecomment-2529021849
On Mon, 9 Dec 2024 18:15:24 GMT, Alexey Semenyuk wrote:
>> @alexeysemenyukoracle Do you mean it would be OK to re-define `ALL-DEFAULT`
>> to not include `jdk.jlink` for runtime images? Would that be OK in general
>> for `jpackage`?
>
> I meant the use of `jdk.internal.module.ModulePath` can be
On Mon, 9 Dec 2024 14:12:19 GMT, Quan Anh Mai wrote:
>> Hi,
>>
>> This is just a redo of https://github.com/openjdk/jdk/pull/13093. mostly
>> just the revert of the backout.
>>
>> Regarding the related issues:
>>
>> - [JDK-8306008](https://bugs.openjdk.org/browse/JDK-8306008) and
>> [JDK-830
On Mon, 9 Dec 2024 18:09:21 GMT, Adam Sotona wrote:
>> Class-File API lost debug printing capability with removal of the
>> `j.l.classfile.components.ClassPrinter` in JDK-8345343.
>> This PR adds `j.l.classfile.CompoundElement::toDebugString` method to
>> restore the capability.
>>
>> Please r
On Mon, 9 Dec 2024 17:43:45 GMT, Severin Gehwolf wrote:
>>> If we change how jpackage defines ALL-DEFAULT we could reduce it
>>
>> I agree. jpackage can define ` ALL-DEFAULT` using public API, no need to use
>> internal API.
>
> @alexeysemenyukoracle Do you mean it would be OK to re-define `AL
On Mon, 9 Dec 2024 18:00:31 GMT, Alexey Semenyuk wrote:
> > The proposal is to not include jdk.jlink and jdk.jpackage by default on a
> > JDK build with JEP 493 enabled
>
> jpackage can use external runtime through `--runtime-image` cli option and
> not invoke jlink.
>
> Would you consider ad
On Mon, 9 Dec 2024 18:06:16 GMT, Adam Sotona wrote:
>> Class-File API lost debug printing capability with removal of the
>> `j.l.classfile.components.ClassPrinter` in JDK-8345343.
>> This PR adds `j.l.classfile.CompoundElement::toDebugString` method to
>> restore the capability.
>>
>> Please r
> Class-File API lost debug printing capability with removal of the
> `j.l.classfile.components.ClassPrinter` in JDK-8345343.
> This PR adds `j.l.classfile.CompoundElement::toDebugString` method to restore
> the capability.
>
> Please review.
>
> Thank you,
> Adam
Adam Sotona has updated the p
On Fri, 15 Nov 2024 14:35:26 GMT, Adam Sotona wrote:
>> Adam Sotona has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 12 commits:
>>
>> - Merge remote-tracking branch 'openjdk/master' into JDK-8334714-final
>>
>># Conflicts
On Mon, 9 Dec 2024 12:57:22 GMT, Severin Gehwolf wrote:
> The proposal is to not include jdk.jlink and jdk.jpackage by default on a JDK
> build with JEP 493 enabled
jpackage can use external runtime through `--runtime-image` cli option and not
invoke jlink.
Would you consider adding an error
On Fri, 6 Dec 2024 15:11:20 GMT, Chen Liang wrote:
> Hi all,
>
> This pull request contains a backport of commit
> [49664195](https://github.com/openjdk/jdk/commit/496641955041c5e48359e6256a4a61812653d900)
> from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
>
> This is a test-on
On Mon, 9 Dec 2024 17:31:37 GMT, Alexey Semenyuk wrote:
>> Yes, I feared this might be a concern. If we change how `jpackage` defines
>> `ALL-DEFAULT` we could reduce it. The remaining use would be the case for
>> issuing a warning for missing `jmods` directory, for which it's probably not
>>
On Mon, 9 Dec 2024 12:57:22 GMT, Severin Gehwolf wrote:
> Please review these changes to jpackage in light of [JEP
> 493](https://openjdk.org/jeps/493). When this feature is enabled, then some
> of the `jpackage` tests fail. The failures fall into the following categories:
>
> - `ALL-DEFAULT`
On Mon, 9 Dec 2024 15:42:57 GMT, Magnus Ihse Bursie wrote:
>> Some files have been modified in 2024, but the copyright year has not been
>> properly updated. This should be fixed.
>>
>> I have located these modified files using:
>>
>> git log --since="Jan 1" --name-only --pretty=format: | sor
On Mon, 9 Dec 2024 16:01:21 GMT, Adam Sotona wrote:
>> Class-File API lost debug printing capability with removal of the
>> `j.l.classfile.components.ClassPrinter` in JDK-8345343.
>> This PR adds `j.l.classfile.CompoundElement::toDebugString` method to
>> restore the capability.
>>
>> Please r
On Fri, 6 Dec 2024 15:44:39 GMT, Severin Gehwolf wrote:
> Please review this fix for JEP 493 enabled JDKs related to the
> `--limit-modules` option. The existing jlink `bindservices` tests cover this
> issue. Previously they didn't run on a JEP 493 enabled JDK, since `jmods`
> folder is missin
On Mon, 9 Dec 2024 13:30:59 GMT, Severin Gehwolf wrote:
> If we change how jpackage defines ALL-DEFAULT we could reduce it
I agree. jpackage can define ` ALL-DEFAULT` using public API, no need to use
internal API.
-
PR Review Comment: https://git.openjdk.org/jdk/pull/22644#discus
Replace broken getProperty with Boolean.getBoolean.
Manual testing confirms trace messages are enabled with
`-Dresource.bundle.debug=true`
-
Commit messages:
- 8345818: Fix SM cleanup of parsing of System property resource.bundle.debug
Changes: https://git.openjdk.org/jdk/pull/226
Thanks for working on this... something of a thankless task :)
I'm sure you've considered this but I'll ask anyway. Would it make (more or
less) sense to try and enforce the policy on the front-end?
By that I mean adding another checkbox requirement to skara's handling of
PR's: "🔲 Change must upd
On Mon, 9 Dec 2024 08:58:19 GMT, Eirik Bjørsnøs wrote:
>>> Seems like we could simply use
>>> `Boolean.getBoolean("resource.bundle.debug")` instead?
>>
>> Naoto may know the history on this property. It may have been introduced for
>> debugging when working on the RB implementation or maybe it
On Mon, 9 Dec 2024 15:58:01 GMT, Adam Sotona wrote:
>> Class-File API lost debug printing capability with removal of the
>> `j.l.classfile.components.ClassPrinter` in JDK-8345343.
>> This PR adds `j.l.classfile.CompoundElement::toDebugString` method to
>> restore the capability.
>>
>> Please r
> Class-File API lost debug printing capability with removal of the
> `j.l.classfile.components.ClassPrinter` in JDK-8345343.
> This PR adds `j.l.classfile.CompoundElement::toDebugString` method to restore
> the capability.
>
> Please review.
>
> Thank you,
> Adam
Adam Sotona has updated the p
Some further observations.
- This arguably makes it harder for the auto-vectorize to access the SVML/SLEEF
functionality. However, in comes cases, we cannot guarantee the same guarantees
(IIRC mainly around monotonicity) as the scalar operations in Math.
- There is an open bug to adjust the sim
On Mon, 9 Dec 2024 15:16:10 GMT, Roger Riggs wrote:
> That git query isn't correct for all the files in the repo. In particular,
> the copyrights on third party files are NOT updated uniformly when new
> versions are applied. In particular, XML files are NOT updated.
I'm not sure I understand
> Some files have been modified in 2024, but the copyright year has not been
> properly updated. This should be fixed.
>
> I have located these modified files using:
>
> git log --since="Jan 1" --name-only --pretty=format: | sort -u > file.list
>
> and then run a script to update the copyright
On Mon, 9 Dec 2024 15:26:00 GMT, Kevin Walls wrote:
> I also meant to note that there are updates to binaries,
> src/java.base/share/classes/jdk/internal/icu/impl/data/icudt76b/... which
> maybe isn't intentional, or I just don't understand?
That was certainly not intentional! I'm not sure how
On Mon, 9 Dec 2024 13:03:06 GMT, Magnus Ihse Bursie wrote:
>> Some files have been modified in 2024, but the copyright year has not been
>> properly updated. This should be fixed.
>>
>> I have located these modified files using:
>>
>> git log --since="Jan 1" --name-only --pretty=format: | sor
On Mon, 9 Dec 2024 06:24:21 GMT, Shaojin Wen wrote:
>> This PR is a resubmission after PR #21593 was rolled back, and the unsafe
>> offset overflow issue has been fixed.
>>
>> 1) Move getChars methods of StringLatin1 and StringUTF16 to DecimalDigits to
>> reduce duplication.
>>
>> 2) HexDigit
On Mon, 9 Dec 2024 13:03:06 GMT, Magnus Ihse Bursie wrote:
>> Some files have been modified in 2024, but the copyright year has not been
>> properly updated. This should be fixed.
>>
>> I have located these modified files using:
>>
>> git log --since="Jan 1" --name-only --pretty=format: | sor
On Thu, 5 Dec 2024 16:24:29 GMT, Scott Marlow wrote:
> I am getting the `Duplication annotation for class` error as mentioned in
> https://hibernate.atlassian.net/browse/HHH-18901. The current error message
> does not include the application class name (e.g. container) that the
> specified an
On Thu, 5 Dec 2024 16:24:29 GMT, Scott Marlow wrote:
> I am getting the `Duplication annotation for class` error as mentioned in
> https://hibernate.atlassian.net/browse/HHH-18901. The current error message
> does not include the application class name (e.g. container) that the
> specified an
On Thu, 5 Dec 2024 16:24:29 GMT, Scott Marlow wrote:
> I am getting the `Duplication annotation for class` error as mentioned in
> https://hibernate.atlassian.net/browse/HHH-18901. The current error message
> does not include the application class name (e.g. container) that the
> specified an
On Thu, 5 Dec 2024 16:24:29 GMT, Scott Marlow wrote:
> I am getting the `Duplication annotation for class` error as mentioned in
> https://hibernate.atlassian.net/browse/HHH-18901. The current error message
> does not include the application class name (e.g. container) that the
> specified an
On Mon, 9 Dec 2024 14:39:25 GMT, Emanuel Peter wrote:
>> @eme64 I think this PR is orthogonal to the concern you are having. Either
>> we need to refactor the expansion to lowering, then modify this PR to match
>> the semantics, or we integrate this PR first, then do the lowering refactor
>> o
On Mon, 9 Dec 2024 14:23:07 GMT, Eirik Bjørsnøs wrote:
> Just to be abundantly clear, should the API description state that the exact
> format of the debug string is unspecified and subject to change?
I thought the word "debug" already conveys that. You should leave this comment
in CSR review
On Mon, 9 Dec 2024 14:15:16 GMT, Quan Anh Mai wrote:
>> @merykitty Ok. Is there a chance we could wait for that additional phase to
>> arrive then, and only do this refactor here afterward? I'd also be ok with a
>> follow up RFE - it would just have to be filed and be clear who will take
>> ca
On Thu, 5 Dec 2024 23:27:38 GMT, Scott Marlow wrote:
>>> I made a quick test for this, but you might not want to include it if you
>>> aim to backport this improvement to LTS releases as it uses the
>>> recently-finalized ClassFile API.
>>
>> Excellent, I'm +1000 for adding your test, thank yo
On Fri, 6 Dec 2024 14:59:47 GMT, Jorn Vernee wrote:
>> Might be a mistake, TestMatrix is the manual test.
>
> TestUpcallStress.java was supposed to run in tier4, which is a catch-all for
> any test not run in lower tiers:
>
>
> # Everything not in other tiers
> tier4 = \
> / \
>-:tier1
> Hi,
>
> This is just a redo of https://github.com/openjdk/jdk/pull/13093. mostly just
> the revert of the backout.
>
> Regarding the related issues:
>
> - [JDK-8306008](https://bugs.openjdk.org/browse/JDK-8306008) and
> [JDK-8309531](https://bugs.openjdk.org/browse/JDK-8309531) have been fix
> @AlanBateman @mahendrachhipa @bwhuang-us @serhiysachkov @mcimadamore
> @JornVernee
>
> adding as manual tests
Ivan Šipka has updated the pull request incrementally with one additional
commit since the last revision:
TestUpcallStress is a jtreg manual test now
-
Changes:
-
On Mon, 9 Dec 2024 12:31:54 GMT, liyazzi wrote:
>> For two cases:
>>
>> 1. When the ImageReaderFactory was loaded by local jdk,that means the
>> ImageReaderFactory was loaded by boot class loader,then init the `Path
>> BOOT_MODULES_JIMAGE` by using `sun.nio.fs.DefaultFileSystemProvider` which
On Thu, 5 Dec 2024 23:27:38 GMT, Scott Marlow wrote:
>>> I made a quick test for this, but you might not want to include it if you
>>> aim to backport this improvement to LTS releases as it uses the
>>> recently-finalized ClassFile API.
>>
>> Excellent, I'm +1000 for adding your test, thank yo
On Mon, 9 Dec 2024 12:59:24 GMT, Adam Sotona wrote:
>> Class-File API lost debug printing capability with removal of the
>> `j.l.classfile.components.ClassPrinter` in JDK-8345343.
>> This PR adds `j.l.classfile.CompoundElement::toDebugString` method to
>> restore the capability.
>>
>> Please r
On Mon, 9 Dec 2024 13:59:29 GMT, Emanuel Peter wrote:
>> @eme64 Yes I have thought about that. My idea is that once phase lowering is
>> ready we will move the expansion there (#21599) . This removes the need to
>> have a standalone method that checks if `LoadShuffleNode` is needed. The
>> cur
On Mon, 9 Dec 2024 12:59:24 GMT, Adam Sotona wrote:
>> Class-File API lost debug printing capability with removal of the
>> `j.l.classfile.components.ClassPrinter` in JDK-8345343.
>> This PR adds `j.l.classfile.CompoundElement::toDebugString` method to
>> restore the capability.
>>
>> Please r
On Mon, 9 Dec 2024 13:03:06 GMT, Magnus Ihse Bursie wrote:
>> Some files have been modified in 2024, but the copyright year has not been
>> properly updated. This should be fixed.
>>
>> I have located these modified files using:
>>
>> git log --since="Jan 1" --name-only --pretty=format: | sor
On Mon, 9 Dec 2024 13:55:46 GMT, Quan Anh Mai wrote:
>> Ok, looks better.
>>
>> I've thought about this a little. And I am wondering if we cannot make the
>> use of Rearrange generally easier.
>>
>> What if we want to use the `VectorRearrangeNode` elsewhere?
>> One would assume that one could
On Mon, 9 Dec 2024 13:47:10 GMT, Emanuel Peter wrote:
>> Quan Anh Mai has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> address reviews
>
> Ok, looks better.
>
> I've thought about this a little. And I am wondering if we cannot make the
On Fri, 6 Dec 2024 17:22:33 GMT, Paul Sandoz wrote:
>> @sviswa7 @PaulSandoz @eme64 @jatin-bhateja Thanks for taking a look, I have
>> merged the PR with a more recent master and resolved the sematic difference
>> with newly added intrinsics, too.
>
> @merykitty do you want me to initiate tier 1
On Mon, 9 Dec 2024 13:33:11 GMT, Quan Anh Mai wrote:
>> Hi,
>>
>> This is just a redo of https://github.com/openjdk/jdk/pull/13093. mostly
>> just the revert of the backout.
>>
>> Regarding the related issues:
>>
>> - [JDK-8306008](https://bugs.openjdk.org/browse/JDK-8306008) and
>> [JDK-830
On Mon, 9 Dec 2024 12:57:22 GMT, Severin Gehwolf wrote:
> Please review these changes to jpackage in light of [JEP
> 493](https://openjdk.org/jeps/493). When this feature is enabled, then some
> of the `jpackage` tests fail. The failures fall into the following categories:
>
> - `ALL-DEFAULT`
On Mon, 9 Dec 2024 08:10:20 GMT, Emanuel Peter wrote:
>> Quan Anh Mai has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> add comment, extract cast into local variable
>
> src/hotspot/share/opto/vectornode.hpp line 1696:
>
>> 1694: // shuff
On Mon, 9 Dec 2024 13:21:31 GMT, Alan Bateman wrote:
>> Please review these changes to jpackage in light of [JEP
>> 493](https://openjdk.org/jeps/493). When this feature is enabled, then some
>> of the `jpackage` tests fail. The failures fall into the following
>> categories:
>>
>> - `ALL-DEF
> Hi,
>
> This is just a redo of https://github.com/openjdk/jdk/pull/13093. mostly just
> the revert of the backout.
>
> Regarding the related issues:
>
> - [JDK-8306008](https://bugs.openjdk.org/browse/JDK-8306008) and
> [JDK-8309531](https://bugs.openjdk.org/browse/JDK-8309531) have been fix
On Mon, 9 Dec 2024 13:03:06 GMT, Magnus Ihse Bursie wrote:
>> Some files have been modified in 2024, but the copyright year has not been
>> properly updated. This should be fixed.
>>
>> I have located these modified files using:
>>
>> git log --since="Jan 1" --name-only --pretty=format: | sor
Some files have been modified in 2024, but the copyright year has not been
properly updated. This should be fixed.
I have located these modified files using:
git log --since="Jan 1" --name-only --pretty=format: | sort -u > file.list
and then run a script to update the copyright year to 2024 on
I felt responsibility for the .github files, and wanted to check if
there were more build system files needed updating. So I ran a more
comprehensive script, and discovered a *lot* more files that needed
updating. Like a thousand or so...
I have opened a series of issues starting at
https://b
> Some files have been modified in 2024, but the copyright year has not been
> properly updated. This should be fixed.
>
> I have located these modified files using:
>
> git log --since="Jan 1" --name-only --pretty=format: | sort -u > file.list
>
> and then run a script to update the copyright
Please review these changes to jpackage in light of [JEP
493](https://openjdk.org/jeps/493). When this feature is enabled, then some of
the `jpackage` tests fail. The failures fall into the following categories:
- `ALL-DEFAULT` notion from `jpackage` which includes all modules that export
an AP
Apart this,
in the current state I think jpackage is simply not suited to be used in
conjunction with snaps and strictly confined containers
because it simply don't do what is supposed to do.
launching a jpackaged app and get the java command output is something
clearly broken from the jpackag
> Class-File API lost debug printing capability with removal of the
> `j.l.classfile.components.ClassPrinter` in JDK-8345343.
> This PR adds `j.l.classfile.CompoundElement::toDebugString` method to restore
> the capability.
>
> Please review.
>
> Thank you,
> Adam
Adam Sotona has updated the p
On Fri, 6 Dec 2024 18:33:33 GMT, Jorn Vernee wrote:
>> Hi,
>>
>> This patch improves the performance of a typical `Arena::allocate` in
>> several ways:
>>
>> - Delay the creation of the NativeMemorySegmentImpl. This avoids the merge
>> of the instance with the one obtained from the call in th
1 - 100 of 116 matches
Mail list logo
