Re: RFR: 8344246: Unnecessary Hashtable usage in EventSupport.notifiers

2024-12-08 Thread Andrey Turbanov
On Tue, 5 Nov 2024 08:28:10 GMT, Andrey Turbanov wrote: > The field `com.sun.jndi.ldap.EventSupport#notifiers` is always accessed under > `lock`. It means extra synchronization from `Hashtable` is not needed. > Subtle difference in Hashtable vs Hashmap behavior is that Hashtable doesn't > allow

Re: RFR: 8343962: [REDO] Move getChars to DecimalDigits [v4]

2024-12-08 Thread Shaojin Wen
> This PR is a resubmission after PR #21593 was rolled back, and the unsafe > offset overflow issue has been fixed. > > 1) Move getChars methods of StringLatin1 and StringUTF16 to DecimalDigits to > reduce duplication. > > 2) HexDigits and OctalDigits also include getCharsLatin1 and getCharsUTF

Re: JPackage does very weird things and it doesn't work with SNAP

2024-12-08 Thread David Holmes
On 9/12/2024 1:21 pm, David Alayachew wrote: > If it's one of the expected ones, things will proceed normally. There are expected segfaults in libjvm? Sorry, I am 100% ignorant about this subject. I just wanted to know if that was the intended meaning. Yes there is a deliberate segfault dur

Re: JPackage does very weird things and it doesn't work with SNAP

2024-12-08 Thread David Alayachew
> If it's one of the expected ones, things will proceed normally. There are expected segfaults in libjvm? Sorry, I am 100% ignorant about this subject. I just wanted to know if that was the intended meaning. On Sun, Dec 8, 2024, 3:46 PM Kim Barrett wrote: > On 12/8/24 1:56 PM, Davide Perini wr

Integrated: 8344611: Add missing classpath exception

2024-12-08 Thread Sorna Sarathi
On Wed, 20 Nov 2024 10:46:54 GMT, Sorna Sarathi wrote: > This PR adds missing Classpath exception in several files. > > JBS Issue: [JDK-8334611](https://bugs.openjdk.org/browse/JDK-8344611) This pull request has now been integrated. Changeset: 458979d8 Author:Sorna Sarathi Committer: Davi

Re: JPackage does very weird things and it doesn't work with SNAP

2024-12-08 Thread Kim Barrett
On 12/8/24 1:56 PM, Davide Perini wrote: I tried attaching gdb, but it’s clear that jvm doesn’t like debuggers attached. Right from the start it got sigstop handlers invoked, and then a segfault in libjvm. I can't comment on the rest of your message, but I might be able to help with this. T

Bitmasks instead of boolean[] for vector masks

2024-12-08 Thread Philippe Marschall
Hello I was trying out the Vector API and was surprised by the amount of boolean[] allocations the code made. The code is here [1]. With JDK 23 on an AMD Ryzen 7 PRO 5750GE (preferred size 256 bit) allocations were: - about 1 million ByteVector.ByteMasks with a shallow size of 18 MB - about 2 m

JPackage does very weird things and it doesn't work with SNAP

2024-12-08 Thread Davide Perini
Hi there... I have a JDK23 app that is packaged with jpackage. I am running this app in Snapcraft. It works well but I cannot restart it for a very weird problem. When I try to restart it with a simple code like this: ``` ArrayList cmdOutput = new ArrayList<>();     try {     **_Pro

Re: RFR: 8343962: [REDO] Move getChars to DecimalDigits [v3]

2024-12-08 Thread Shaojin Wen
On Sun, 8 Dec 2024 08:51:34 GMT, Shaojin Wen wrote: >> This PR is a resubmission after PR #21593 was rolled back, and the unsafe >> offset overflow issue has been fixed. >> >> 1) Move getChars methods of StringLatin1 and StringUTF16 to DecimalDigits to >> reduce duplication. >> >> 2) HexDigit

Re: RFR: 8344611: Add missing classpath exception

2024-12-08 Thread duke
On Wed, 20 Nov 2024 10:46:54 GMT, Sorna Sarathi wrote: > This PR adds missing Classpath exception in several files. > > JBS Issue: [JDK-8334611](https://bugs.openjdk.org/browse/JDK-8344611) @Sorna-Sarathi Your change (at version 84398ccf8d3ee2b584dfaeaed094d109f89108b4) is now ready to be spo

Re: RFR: 8343962: [REDO] Move getChars to DecimalDigits [v3]

2024-12-08 Thread Shaojin Wen
> This PR is a resubmission after PR #21593 was rolled back, and the unsafe > offset overflow issue has been fixed. > > 1) Move getChars methods of StringLatin1 and StringUTF16 to DecimalDigits to > reduce duplication. > > 2) HexDigits and OctalDigits also include getCharsLatin1 and getCharsUTF