On Tue, 3 Dec 2024 19:59:56 GMT, Henry Jen wrote:
> Improving option value handling to support passing argument value starts with
> "--".
>
> Before the fix, in following example, --add-modules will be considered as
> another option for JLink instead of argument value for --add-options.
> --ad
On Thu, 5 Dec 2024 04:38:04 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which proposes to address
>> https://bugs.openjdk.org/browse/JDK-8341551?
>>
>> The primary work in this PR is the specification of the previously existing
>> `sun.misc.URLClassPath.disableJarChec
On Wed, 4 Dec 2024 10:21:57 GMT, Raffaello Giulietti
wrote:
>> `jdk.internal.math.FloatingDecimal` parsing is mostly exercised on inputs
>> produced by `Float.toString` and `Double.toString`, but should be extended
>> on more random inputs.
>
> Raffaello Giulietti has updated the pull request
On Fri, 29 Sep 2023 18:51:07 GMT, Shaojin Wen wrote:
>> Raffaello Giulietti has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Uppercase JLA.
>
> src/java.base/share/classes/jdk/internal/math/FloatToDecimal.java line 508:
>
>> 506:
> Can I please get a review of this change which proposes to address
> https://bugs.openjdk.org/browse/JDK-8341551?
>
> The primary work in this PR is the specification of the previously existing
> `sun.misc.URLClassPath.disableJarChecking` system property and how the
> internal implementation
> Add jlink plugins to allow branding change for java.vendor, java.vm.vendor
> and java.vendor.url.
>
> The jlink plugin will change the value in java.lang.VersionProps, which will
> set those property values. The `java.vm.vendor` was initialized by VM with
> value set at build time, and then l
On Sat, 23 Nov 2024 13:41:24 GMT, Piotr Tarsa wrote:
> Could you add some code that disables the AVX512 version on Zen4, but keeps
> it enabled on Zen5 and future Zen architectures?
Or as you suggest
[here](https://github.com/intel/x86-simd-sort/issues/6#issuecomment-2506476505)
revert to AVX
On Wed, 4 Dec 2024 03:38:59 GMT, Alexey Semenyuk wrote:
> - Add missing resource keys to Windows property files;
> - Fix the code to throw `ConfigException` if the service installer
> executable is required but not available instead of throwing the exception
> only when it is not found in the
On Wed, 4 Dec 2024 19:06:20 GMT, Stuart Marks wrote:
> Convert the RMI NewThreadAction class into a couple static methods on
> RuntimeUtil. Also remove a couple unnecessary qualified exports from
> java.base to java.rmi.
This pull request has now been integrated.
Changeset: 8a3c100c
Author:
On Wed, 4 Dec 2024 19:48:03 GMT, Roger Riggs wrote:
>> Stuart Marks has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Make thread group fields final.
>
> src/java.rmi/share/classes/sun/rmi/runtime/RuntimeUtil.java line 60:
>
>> 58: *
On Wed, 4 Dec 2024 22:35:08 GMT, Stuart Marks wrote:
>> Convert the RMI NewThreadAction class into a couple static methods on
>> RuntimeUtil. Also remove a couple unnecessary qualified exports from
>> java.base to java.rmi.
>
> Stuart Marks has updated the pull request incrementally with one ad
> Convert the RMI NewThreadAction class into a couple static methods on
> RuntimeUtil. Also remove a couple unnecessary qualified exports from
> java.base to java.rmi.
Stuart Marks has updated the pull request incrementally with one additional
commit since the last revision:
Make thread grou
On Tue, 3 Dec 2024 17:36:35 GMT, Aleksei Efimov wrote:
> JNDI dependency on the `java.applet.Applet` has been removed in JDK9 with
> [JDK-8051422](https://bugs.openjdk.org/browse/JDK-8051422). It made the
> `Context.APPLET` environment property obsolete and to be ignored when
> `javax.naming.I
It appears that skara is case-sensitive, and it treats the uppercase I as a
regular comment instead of a bot command.
From: core-libs-dev on behalf of Aleksei
Efimov
Sent: Wednesday, December 4, 2024 3:19 PM
To: core-libs-dev@openjdk.org
Subject: Re: RFR: 83403
On Tue, 3 Dec 2024 17:36:35 GMT, Aleksei Efimov wrote:
> JNDI dependency on the `java.applet.Applet` has been removed in JDK9 with
> [JDK-8051422](https://bugs.openjdk.org/browse/JDK-8051422). It made the
> `Context.APPLET` environment property obsolete and to be ignored when
> `javax.naming.I
On Mon, 18 Nov 2024 07:41:31 GMT, Justin Lu wrote:
> Please review this PR and corresponding CSR which includes a wide range of
> specification improvements for java.util.Locale. See the CSR for further
> detail. Other changes/suggestions are welcomed to be included as part of this
> change.
>
On Tue, 3 Dec 2024 02:29:16 GMT, Justin Lu wrote:
>> Please review this PR and corresponding CSR which includes a wide range of
>> specification improvements for java.util.Locale. See the CSR for further
>> detail. Other changes/suggestions are welcomed to be included as part of
>> this change
> The Type and AnnotatedType hierarchies have been enigmatic to new users:
> users have no clue how to categorize arbitrary type objects, when it is safe
> to cast to more specific types, and the exact conditions for method contracts.
>
> A manifest is [JDK-8306039](https://bugs.openjdk.org/brow
On Wed, 4 Dec 2024 16:46:17 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which proposes to address
>> https://bugs.openjdk.org/browse/JDK-8341551?
>>
>> The primary work in this PR is the specification of the previously existing
>> `sun.misc.URLClassPath.disableJarChec
On Wed, 4 Dec 2024 03:49:00 GMT, Alexey Semenyuk wrote:
> 8333572: Update jpackage.md with info related to WiX v4 and v5 support
This pull request has now been integrated.
Changeset: 9740c1df
Author:Alexey Semenyuk
URL:
https://git.openjdk.org/jdk/commit/9740c1df6f0469ae80f012dbaf43
On Wed, 4 Dec 2024 19:06:20 GMT, Stuart Marks wrote:
> Convert the RMI NewThreadAction class into a couple static methods on
> RuntimeUtil. Also remove a couple unnecessary qualified exports from
> java.base to java.rmi.
src/java.rmi/share/classes/sun/rmi/runtime/RuntimeUtil.java line 60:
> 5
On Wed, 4 Dec 2024 03:49:00 GMT, Alexey Semenyuk wrote:
> 8333572: Update jpackage.md with info related to WiX v4 and v5 support
Looks good.
-
Marked as reviewed by almatvee (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/22534#pullrequestreview-2479750211
On Wed, 4 Dec 2024 17:52:59 GMT, Alexey Semenyuk wrote:
>> - Add missing resource keys to Windows property files;
>> - Fix the code to throw `ConfigException` if the service installer
>> executable is required but not available instead of throwing the exception
>> only when it is not found in
On Wed, 4 Dec 2024 19:23:47 GMT, Roger Riggs wrote:
>> Convert the RMI NewThreadAction class into a couple static methods on
>> RuntimeUtil. Also remove a couple unnecessary qualified exports from
>> java.base to java.rmi.
>
> Looks good, thanks for the cleanup
@RogerRiggs Thanks, I'll integra
On Wed, 4 Dec 2024 19:00:33 GMT, Henry Jen wrote:
>> In fact, VM no longer sets this property. This should be updated to simply
>> do `props.put`.
>
> It is just for compatibility with other VM implementation. We don't set the
> property in hotspot with this PR.
Is it part of the implementat
On Wed, 4 Dec 2024 19:06:20 GMT, Stuart Marks wrote:
> Convert the RMI NewThreadAction class into a couple static methods on
> RuntimeUtil. Also remove a couple unnecessary qualified exports from
> java.base to java.rmi.
Looks good, thanks for the cleanup
-
Marked as reviewed by
> Accommodate compensations when checking for missed signals; add a better test
> for this.
Doug Lea has updated the pull request with a new target base due to a merge or
a rebase. The incremental webrev excludes the unrelated changes brought in by
the merge/rebase. The pull request contains fi
On Wed, 4 Dec 2024 15:40:03 GMT, Sean Mullan wrote:
> The internal `ProtectionDomain.doIntersectionPrivilege` methods can be
> removed as all dependencies have been removed in post JEP 486 cleanup issues.
This pull request has now been integrated.
Changeset: de3a218a
Author:Sean Mullan
UR
Convert the RMI NewThreadAction class into a couple static methods on
RuntimeUtil. Also remove a couple unnecessary qualified exports from java.base
to java.rmi.
-
Commit messages:
- 8344461: clean up NewThreadAction
Changes: https://git.openjdk.org/jdk/pull/22557/files
Webrev:
On Wed, 4 Dec 2024 01:28:36 GMT, Taizo Kurashige wrote:
>> To resolve java/io/File/GetXSpace.java failure, I fix libGetXSpace.c to use
>> Cygwin’s `df` to get the size for comparison if the test target drive is a
>> CD-ROM drive.
>>
>> As described in JDK-8343342, GetDiskSpaceInformationW can
On Wed, 4 Dec 2024 07:31:24 GMT, Henry Jen wrote:
>> Add jlink plugins to allow branding change for java.vendor, java.vm.vendor
>> and java.vendor.url.
>>
>> The jlink plugin will change the value in java.lang.VersionProps, which will
>> set those property values. The `java.vm.vendor` was init
On Wed, 4 Dec 2024 18:27:45 GMT, Mandy Chung wrote:
>> src/java.base/share/classes/java/lang/VersionProps.java.template line 128:
>>
>>> 126:
>>> 127: // In case VM is not yet set this property
>>> 128: props.putIfAbsent("java.vm.vendor", VENDOR_VM);
>>
>> Can this system prope
On Wed, 4 Dec 2024 07:31:24 GMT, Henry Jen wrote:
>> Add jlink plugins to allow branding change for java.vendor, java.vm.vendor
>> and java.vendor.url.
>>
>> The jlink plugin will change the value in java.lang.VersionProps, which will
>> set those property values. The `java.vm.vendor` was init
> Accommodate compensations when checking for missed signals; add a better test
> for this.
Doug Lea has updated the pull request with a new target base due to a merge or
a rebase. The incremental webrev excludes the unrelated changes brought in by
the merge/rebase. The pull request contains fo
On Wed, 4 Dec 2024 16:05:02 GMT, Viktor Klang wrote:
>> Accommodate compensations when checking for missed signals; add a better
>> test for this.
>
> src/java.base/share/classes/java/util/concurrent/ForkJoinPool.java line 2016:
>
>> 2014: return awaitWork(w, p); // block,
On Wed, 4 Dec 2024 07:31:24 GMT, Henry Jen wrote:
>> Add jlink plugins to allow branding change for java.vendor, java.vm.vendor
>> and java.vendor.url.
>>
>> The jlink plugin will change the value in java.lang.VersionProps, which will
>> set those property values. The `java.vm.vendor` was init
> Improve the documentation for classfile instructions. Includes links to all
> opcodes, usage notes for instructions, and other various fixes.
>
> API Diff:
> https://cr.openjdk.org/~liach/apidiff/cf-instr/java.base/module-summary.html
> Javadoc:
> https://cr.openjdk.org/~liach/javadoc/cf-inst
On Wed, 4 Dec 2024 18:24:26 GMT, Mandy Chung wrote:
>> Henry Jen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Clean up adapting review comments
>
> src/java.base/share/classes/java/lang/VersionProps.java.template line 128:
>
>> 126:
On Thu, 21 Nov 2024 10:24:28 GMT, Daniel Fuchs wrote:
>> This PR remove usage of SecurityManager, doPrivileges, etc... from
>> `java.logging` and `java.base/jdk.internal.logger`
>>
>> Only notable hack - Logger.checkPermission() no longer checks permissions,
>> but has been renamed into `ensur
On Wed, 4 Dec 2024 07:31:24 GMT, Henry Jen wrote:
>> Add jlink plugins to allow branding change for java.vendor, java.vm.vendor
>> and java.vendor.url.
>>
>> The jlink plugin will change the value in java.lang.VersionProps, which will
>> set those property values. The `java.vm.vendor` was init
On Wed, 4 Dec 2024 18:03:42 GMT, Mandy Chung wrote:
>> Henry Jen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Clean up adapting review comments
>
> make/autoconf/spec.gmk.template line 276:
>
>> 274:
>> 275: ifneq ($(COMPANY_NAME),
On Wed, 4 Dec 2024 17:52:59 GMT, Alexey Semenyuk wrote:
>> - Add missing resource keys to Windows property files;
>> - Fix the code to throw `ConfigException` if the service installer
>> executable is required but not available instead of throwing the exception
>> only when it is not found in
On Wed, 4 Dec 2024 07:31:24 GMT, Henry Jen wrote:
>> Add jlink plugins to allow branding change for java.vendor, java.vm.vendor
>> and java.vendor.url.
>>
>> The jlink plugin will change the value in java.lang.VersionProps, which will
>> set those property values. The `java.vm.vendor` was init
On Wed, 4 Dec 2024 17:49:16 GMT, Pavel Rappo wrote:
>> Prepare for JDK 25.
>
> Pavel Rappo has updated the pull request with a new target base due to a
> merge or a rebase. The pull request now contains 14 commits:
>
> - Merge branch 'master' into 8342979
> - Update --release 24 symbol inform
>
> There are at least three issues at play here:
>
> a: Some flags use inconsistent, confusing, controversial or
> less-than-perfect interpretations
> b: Some flags use identical interpretations, yet their evaluation happens
> in copy-pasted code spread across the code base
> c: Some flags use ide
On Wed, 4 Dec 2024 16:48:57 GMT, Naoto Sato wrote:
>> Should I revert changes in `WinResources_*.properties` files?
>
> Yes, please.
Done
-
PR Review Comment: https://git.openjdk.org/jdk/pull/22533#discussion_r1870021873
> - Add missing resource keys to Windows property files;
> - Fix the code to throw `ConfigException` if the service installer
> executable is required but not available instead of throwing the exception
> only when it is not found in the resource directory;
> - Fix `JPackageStringBundle.getForm
On Wed, 4 Dec 2024 14:23:07 GMT, Chen Liang wrote:
> Over the years there have been significant rounds of cleanup to try and keep
> the classfile API as focussed and true to its underlying functional core as
> possible. One of the side-effects of such cleanups was to move higher-level
> functi
> Prepare for JDK 25.
Pavel Rappo has updated the pull request with a new target base due to a merge
or a rebase. The pull request now contains 14 commits:
- Merge branch 'master' into 8342979
- Update --release 24 symbol information for JDK 24 build 26
The macOS/AArch64 build 26 was ta
On Wed, 4 Dec 2024 09:31:14 GMT, Emanuel Peter wrote:
>> Found this while cleaning up x86_32 code for removal.
>>
>> In our current code there is a block added by
>> [JDK-8076373](https://bugs.openjdk.org/browse/JDK-8076373):
>> https://github.com/openjdk/jdk/blob/3b21a298c29d88720f6bfb2dc1f330
>
> Practically, if we wanted to change such long standing behaviors
> in order to align on a new consistent handling for all the boolean
> properties.
>
There are at least three issues at play here:
a: Some flags use inconsistent, confusing, controversial or
less-than-perfect interpretations
b:
On Wed, 4 Dec 2024 14:23:07 GMT, Chen Liang wrote:
> Over the years there have been significant rounds of cleanup to try and keep
> the classfile API as focussed and true to its underlying functional core as
> possible. One of the side-effects of such cleanups was to move higher-level
> functi
Hi Eirik,
Yes, the situation we're in is far from perfect. I've never been a big
fan of considering that an empty value means "true": if you're going
to pass a System property, you can go the extra mile and supply
its value too, which should make the intent uncontroversial. Note that
not passing
On Wed, 4 Dec 2024 16:46:14 GMT, Eirik Bjørsnøs wrote:
>> We're stuck with the property name for compatibility, and the usage within
>> the class is fairly limited.
>> Generally, it is easier to understand the behavior having a feature that is
>> enabled not a disable that is disabled.
>> $0.02
On Wed, 4 Dec 2024 16:46:17 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which proposes to address
>> https://bugs.openjdk.org/browse/JDK-8341551?
>>
>> The primary work in this PR is the specification of the previously existing
>> `sun.misc.URLClassPath.disableJarChec
On Wed, 4 Dec 2024 16:46:13 GMT, Alexey Semenyuk wrote:
>> src/jdk.jpackage/windows/classes/jdk/jpackage/internal/resources/WinResources_zh_CN.properties
>> line 61:
>>
>>> 59: error.short-path-conv-fail=Failed to get short version of "{0}" path
>>> 60: error.missing-service-installer='service-
On Wed, 4 Dec 2024 16:40:42 GMT, Roger Riggs wrote:
>> Hello Eirik, I have received similar inputs in other places when discussing
>> this change. I myself had to think a few times on which naming to follow
>> here to make it easier to understand the code. I'll consider your and other
>> input
On Wed, 4 Dec 2024 16:40:17 GMT, Naoto Sato wrote:
>> Alexey Semenyuk has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains two additional
>> commits
On Wed, 4 Dec 2024 16:35:09 GMT, Roger Riggs wrote:
>> Jaikiran Pai has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Lance's suggestion - better comment on the method
>
> src/java.base/share/classes/jdk/internal/loader/URLClassPath.java l
On Wed, 4 Dec 2024 16:35:19 GMT, Jaikiran Pai wrote:
>> src/java.base/share/classes/jdk/internal/loader/URLClassPath.java line 89:
>>
>>> 87: // JAR check is disabled by default and will be enabled only if
>>> the "disable JAR check"
>>> 88: // system property has been set to "f
> Can I please get a review of this change which proposes to address
> https://bugs.openjdk.org/browse/JDK-8341551?
>
> The primary work in this PR is the specification of the previously existing
> `sun.misc.URLClassPath.disableJarChecking` system property and how the
> internal implementation
On Wed, 4 Dec 2024 05:14:55 GMT, Alexey Semenyuk wrote:
>> - Add missing resource keys to Windows property files;
>> - Fix the code to throw `ConfigException` if the service installer
>> executable is required but not available instead of throwing the exception
>> only when it is not found in
On Thu, 28 Nov 2024 18:22:24 GMT, Aleksey Shipilev wrote:
> Found this while cleaning up x86_32 code for removal.
>
> In our current code there is a block added by
> [JDK-8076373](https://bugs.openjdk.org/browse/JDK-8076373):
> https://github.com/openjdk/jdk/blob/3b21a298c29d88720f6bfb2dc1f3305
On Wed, 4 Dec 2024 09:42:59 GMT, Aleksey Shipilev wrote:
>> Found this while cleaning up x86_32 code for removal.
>>
>> In our current code there is a block added by
>> [JDK-8076373](https://bugs.openjdk.org/browse/JDK-8076373):
>> https://github.com/openjdk/jdk/blob/3b21a298c29d88720f6bfb2dc1f
On Wed, 4 Dec 2024 16:28:58 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which proposes to address
>> https://bugs.openjdk.org/browse/JDK-8341551?
>>
>> The primary work in this PR is the specification of the previously existing
>> `sun.misc.URLClassPath.disableJarChec
On Wed, 4 Dec 2024 16:25:47 GMT, Eirik Bjørsnøs wrote:
>> Jaikiran Pai has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> improve code comment
>
> src/java.base/share/classes/jdk/internal/loader/URLClassPath.java line 89:
>
>> 87:
On Wed, 4 Dec 2024 16:12:39 GMT, Lance Andersen wrote:
>> Jaikiran Pai has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> improve code comment
>
> src/java.base/share/classes/jdk/internal/loader/URLClassPath.java line 657:
>
>> 655:
On Wed, 4 Dec 2024 16:24:55 GMT, Sean Mullan wrote:
>> The internal `ProtectionDomain.doIntersectionPrivilege` methods can be
>> removed as all dependencies have been removed in post JEP 486 cleanup issues.
>
> Sean Mullan has updated the pull request incrementally with one additional
> commit
On Wed, 4 Dec 2024 15:46:28 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which proposes to address
>> https://bugs.openjdk.org/browse/JDK-8341551?
>>
>> The primary work in this PR is the specification of the previously existing
>> `sun.misc.URLClassPath.disableJarChec
> Can I please get a review of this change which proposes to address
> https://bugs.openjdk.org/browse/JDK-8341551?
>
> The primary work in this PR is the specification of the previously existing
> `sun.misc.URLClassPath.disableJarChecking` system property and how the
> internal implementation
On Wed, 4 Dec 2024 14:50:11 GMT, Aleksey Shipilev wrote:
>> This fix looks correct by looking on original changes.
>>
>> Yes, special Interpreter's code for these methods is only generated for
>> x86_32 in `templateInterpreterGenerator_x86_32.cpp`.
>
>> I just launched testing, I don't think @
> The internal `ProtectionDomain.doIntersectionPrivilege` methods can be
> removed as all dependencies have been removed in post JEP 486 cleanup issues.
Sean Mullan has updated the pull request incrementally with one additional
commit since the last revision:
Add # to linkplain link.
---
On Wed, 4 Dec 2024 15:58:41 GMT, Jaikiran Pai wrote:
>> test/jdk/jdk/internal/loader/URLClassPath/JarCheckTest.java line 60:
>>
>>> 58: * @run junit/othervm -Dsun.misc.URLClassPath.disableJarChecking
>>> JarCheckTest
>>> 59: * @run junit/othervm -Dsun.misc.URLClassPath.disableJarChecking=true
On Wed, 4 Dec 2024 14:23:07 GMT, Chen Liang wrote:
> Over the years there have been significant rounds of cleanup to try and keep
> the classfile API as focussed and true to its underlying functional core as
> possible. One of the side-effects of such cleanups was to move higher-level
> functi
On Wed, 4 Dec 2024 15:46:28 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which proposes to address
>> https://bugs.openjdk.org/browse/JDK-8341551?
>>
>> The primary work in this PR is the specification of the previously existing
>> `sun.misc.URLClassPath.disableJarChec
> Hi all,
> The file src/java.base/share/native/libjli/java.c generate false positive
> compile warning by gcc14 with gcc options `-fsanitize=undefined -O2`, and
> make jdk build error when configure with option `--enable-asan`. So I think
> it's necessory to disable the false positive compile
On Wed, 4 Dec 2024 14:03:58 GMT, Doug Lea wrote:
> Accommodate compensations when checking for missed signals; add a better test
> for this.
src/java.base/share/classes/java/util/concurrent/ForkJoinPool.java line 2016:
> 2014: return awaitWork(w, p); // block, drop, or ex
On Wed, 4 Dec 2024 09:42:59 GMT, Aleksey Shipilev wrote:
>> Found this while cleaning up x86_32 code for removal.
>>
>> In our current code there is a block added by
>> [JDK-8076373](https://bugs.openjdk.org/browse/JDK-8076373):
>> https://github.com/openjdk/jdk/blob/3b21a298c29d88720f6bfb2dc1f
On Wed, 4 Dec 2024 15:53:37 GMT, Weijun Wang wrote:
> I see in `SharedSecrets` these 2 imports are useless. Not sure if you want to
> take this chance to remove them as well.
>
> ```
> import java.io.PrintStream;
> import java.io.PrintWriter;
> ```
Sure. Fixed.
-
PR Comment: http
> The internal `ProtectionDomain.doIntersectionPrivilege` methods can be
> removed as all dependencies have been removed in post JEP 486 cleanup issues.
Sean Mullan has updated the pull request incrementally with one additional
commit since the last revision:
Remove unused imports.
-
On Wed, 4 Dec 2024 15:59:44 GMT, Sean Mullan wrote:
>> The internal `ProtectionDomain.doIntersectionPrivilege` methods can be
>> removed as all dependencies have been removed in post JEP 486 cleanup issues.
>
> Sean Mullan has updated the pull request incrementally with one additional
> commit
On Wed, 4 Dec 2024 14:53:19 GMT, Daniel Fuchs wrote:
>> Jaikiran Pai has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> improve code comment
>
> test/jdk/jdk/internal/loader/URLClassPath/JarCheckTest.java line 60:
>
>> 58: * @run junit/ot
On Wed, 4 Dec 2024 15:40:03 GMT, Sean Mullan wrote:
> The internal `ProtectionDomain.doIntersectionPrivilege` methods can be
> removed as all dependencies have been removed in post JEP 486 cleanup issues.
I see in `SharedSecrets` these 2 imports are useless. Not sure if you want to
take this c
On Wed, 4 Dec 2024 15:46:28 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which proposes to address
>> https://bugs.openjdk.org/browse/JDK-8341551?
>>
>> The primary work in this PR is the specification of the previously existing
>> `sun.misc.URLClassPath.disableJarChec
On Wed, 4 Dec 2024 15:40:21 GMT, Jaikiran Pai wrote:
> Hello @sendaoYan, what exact version of `gcc` is this?
Hi, the gcc version is gcc14.2.0
> gcc -v
Using built-in specs.
COLLECT_GCC=gcc
COLLECT_LTO_WRAPPER=/home/yansendao/software/gcc/gcc-14.2.0-binary/bin/../libexec/gcc/x86_64-pc-linux-gn
On Wed, 4 Dec 2024 14:03:58 GMT, Doug Lea wrote:
> Accommodate compensations when checking for missed signals; add a better test
> for this.
Thanks for the fix, Doug, and thanks for the reproducer test, @AlanBateman!
Having a look at the patch now 👍
-
PR Comment: https://git.open
> Can I please get a review of this change which proposes to address
> https://bugs.openjdk.org/browse/JDK-8341551?
>
> The primary work in this PR is the specification of the previously existing
> `sun.misc.URLClassPath.disableJarChecking` system property and how the
> internal implementation
The internal `ProtectionDomain.doIntersectionPrivilege` methods can be removed
as all dependencies have been removed in post JEP 486 cleanup issues.
-
Commit messages:
- Initial cleanup.
Changes: https://git.openjdk.org/jdk/pull/22548/files
Webrev: https://webrevs.openjdk.org/?re
On Wed, 4 Dec 2024 14:57:22 GMT, SendaoYan wrote:
> Hi all,
> The file src/java.base/share/native/libjli/java.c generate false positive
> compile warning by gcc14 with gcc options `-fsanitize=undefined -O2`, and
> make jdk build error when configure with option `--enable-asan`. So I think
> i
On Wed, 4 Dec 2024 14:03:58 GMT, Doug Lea wrote:
> Accommodate compensations when checking for missed signals; add a better test
> for this.
test/jdk/java/lang/Thread/virtual/Starvation.java line 1:
> 1: /* @test
Suggestion:
/*
* Copyright (c) 2024, Oracle and/or its affiliates. All rights
On Wed, 4 Dec 2024 14:48:55 GMT, Aleksey Shipilev wrote:
>> test/hotspot/jtreg/compiler/c2/irTests/TestFPConversion.java line 33:
>>
>>> 31: * @summary Test that code generation for FP conversion works as
>>> intended
>>> 32: * @library /test/lib /
>>> 33: * @requires os.arch != "x86" & os.a
Hi Eirik,
Yes, its a long standing and inconsistent area of deferred maintenance.
Most of the individual cases are not used enough to warrant making the
(in many cases) incompatible change and breaking some
application/library somewhere.
Interesting, you did not mention Boolean.getBoolean(Str
Hi all,
The file src/java.base/share/native/libjli/java.c generate false positive
compile warning by gcc14 with gcc options `-fsanitize=undefined -O2`, and make
jdk build error when configure with option `--enable-asan`. So I think it's
necessory to disable the false positive compile warning to
> This PR proposes to fix a performance regression (on x64 platforms) for
> 32-bit strings introduced by
> [JDK-8345120](https://bugs.openjdk.org/browse/JDK-8345120).
>
> The PR also fixes a performance regression in the benchmarks caused by using
> the wrong type for `MemorySegment`.
>
> Regr
On Wed, 4 Dec 2024 14:06:38 GMT, Emanuel Peter wrote:
>> Aleksey Shipilev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Disable IR tests on IA32
>
> test/hotspot/jtreg/compiler/c2/irTests/TestFPConversion.java line 33:
>
>> 31: * @su
> After changing `BigInteger.sqrt()` algorithm, this can be also used to speed
> up `BigDecimal.sqrt()` implementation. Here is how I made it.
>
> The main steps of the algorithm are as follows:
> first argument reduce the value to an integer using the following relations:
>
> x = y * 10 ^ exp
>
On Tue, 3 Dec 2024 03:10:51 GMT, Vladimir Kozlov wrote:
>> Aleksey Shipilev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Disable IR tests on IA32
>
> This fix looks correct by looking on original changes.
>
> Yes, special Interprete
Hi,
The OpenJDK includes many boolean flags in the form of system properties.
These toggle different behavior such as debug logging, verification,
caching, compatibility and conditional features.
A common interpretation is to evaluate a property as true if it is set and
either blank or equal to "
On Wed, 4 Dec 2024 14:23:07 GMT, Chen Liang wrote:
> Over the years there have been significant rounds of cleanup to try and keep
> the classfile API as focussed and true to its underlying functional core as
> possible. One of the side-effects of such cleanups was to move higher-level
> functi
Over the years there have been significant rounds of cleanup to try and keep
the classfile API as focussed and true to its underlying functional core as
possible. One of the side-effects of such cleanups was to move higher-level
functionalities from the root classfile API package `java.lang.clas
1 - 100 of 133 matches
Mail list logo
