On Tue, 3 Dec 2024 at 18:37, Louis Wasserman wrote:
> To add some more data, from taking a sample, at least a third of usages in
> Google's codebase were using it incorrectly in the way we've described.
I just checked, and only a few days ago I made this error (in a test
case, where it is less n
On Tue, 3 Dec 2024 17:36:35 GMT, Aleksei Efimov wrote:
> JNDI dependency on the `java.applet.Applet` has been removed in JDK9 with
> [JDK-8051422](https://bugs.openjdk.org/browse/JDK-8051422). It made the
> `Context.APPLET` environment property obsolete and to be ignored when
> `javax.naming.I
> Add jlink plugins to allow branding change for java.vendor, java.vm.vendor
> and java.vendor.url.
>
> The jlink plugin will change the value in java.lang.VersionProps, which will
> set those property values. The `java.vm.vendor` was initialized by VM with
> value set at build time, and then l
On Wed, 4 Dec 2024 07:03:22 GMT, Emanuel Peter wrote:
> One question: Could we add an IR test that would show that no interpreter
> stubs are emitted, but instead whatever it is now emitting?
We could, but let's not do this in this PR. I already jumped the gun here a
little with adding a bench
On Wed, 4 Dec 2024 06:15:56 GMT, Henry Jen wrote:
>> Or are you assuming/expecting the VersionProps value is null unless being
>> overridden? You could initialize the VersionProps value to be the same as
>> what VENDOR is at build time and always use it to set the
>> Abstract_VM_Version field
On Tue, 3 Dec 2024 07:10:16 GMT, Aleksey Shipilev wrote:
>> This fix looks correct by looking on original changes.
>>
>> Yes, special Interpreter's code for these methods is only generated for
>> x86_32 in `templateInterpreterGenerator_x86_32.cpp`.
>
>> This fix looks correct by looking on ori
On Wed, 4 Dec 2024 06:04:09 GMT, David Holmes wrote:
>> src/hotspot/share/runtime/abstract_vm_version.cpp line 132:
>>
>>> 130:
>>> 131: static const char vm_vendor_string[sizeof(VENDOR) < VENDOR_PADDING ?
>>> VENDOR_PADDING : sizeof(VENDOR)] = VENDOR;
>>> 132: const char* Abstract_VM_Version:
On Wed, 4 Dec 2024 05:59:31 GMT, David Holmes wrote:
>> Henry Jen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Set java.vm.vendor from VersionProps.java
>
> src/hotspot/share/runtime/abstract_vm_version.cpp line 132:
>
>> 130:
>> 13
On Wed, 4 Dec 2024 05:24:15 GMT, Henry Jen wrote:
>> Add jlink plugins to allow branding change for java.vendor, java.vm.vendor
>> and java.vendor.url.
>>
>> The jlink plugin will change the value in java.lang.VersionProps, which will
>> set those property values. The `java.vm.vendor` was init
> The notification that finalize is complete should be done after printing the
> message because in Xcomp mode there might be a significant delay at the
> println so the object hasn't actually been finalized yet.
Tom Rodriguez has updated the pull request with a new target base due to a
merge o
On Wed, 4 Dec 2024 05:24:15 GMT, Henry Jen wrote:
>> Add jlink plugins to allow branding change for java.vendor, java.vm.vendor
>> and java.vendor.url.
>>
>> The jlink plugin will change the value in java.lang.VersionProps, which will
>> set those property values. The `java.vm.vendor` was init
On Wed, 4 Dec 2024 05:24:15 GMT, Henry Jen wrote:
>> Add jlink plugins to allow branding change for java.vendor, java.vm.vendor
>> and java.vendor.url.
>>
>> The jlink plugin will change the value in java.lang.VersionProps, which will
>> set those property values. The `java.vm.vendor` was init
> Add jlink plugins to allow branding change for java.vendor, java.vm.vendor
> and java.vendor.url.
>
> The jlink plugin will change the value in java.lang.VersionProps, which will
> set those property values. The `java.vm.vendor` was initialized by VM with
> value set at build time, and then l
> - Add missing resource keys to Windows property files;
> - Fix the code to throw `ConfigException` if the service installer
> executable is required but not available instead of throwing the exception
> only when it is not found in the resource directory;
> - Fix `JPackageStringBundle.getForm
On Wed, 4 Dec 2024 03:49:00 GMT, Alexey Semenyuk wrote:
> 8333572: Update jpackage.md with info related to WiX v4 and v5 support
@sashamatveev ptal
-
PR Comment: https://git.openjdk.org/jdk/pull/22534#issuecomment-2516117476
8333572: Update jpackage.md with info related to WiX v4 and v5 support
-
Commit messages:
- 8333572: Update jpackage.md with info related to WiX v4 and v5 support
Changes: https://git.openjdk.org/jdk/pull/22534/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=22534&range=00
On Wed, 4 Dec 2024 03:38:59 GMT, Alexey Semenyuk wrote:
> - Add missing resource keys to Windows property files;
> - Fix the code to throw `ConfigException` if the service installer
> executable is required but not available instead of throwing the exception
> only when it is not found in the
On Tue, 3 Dec 2024 02:22:15 GMT, Joe Wang wrote:
> Add test for JDK-8344800 W3C DTDs and XSDs in the built-in Catalog
This pull request has now been integrated.
Changeset: 447f8d49
Author:Joe Wang
URL:
https://git.openjdk.org/jdk/commit/447f8d49963fef59d36c464c4b31bff79ef02de3
Stats
- Add missing resource keys to Windows property files;
- Fix the code to throw `ConfigException` if the service installer executable
is required but not available instead of throwing the exception only when it is
not found in the resource directory;
- Fix `JPackageStringBundle.getFormattedStrin
On Tue, 3 Dec 2024 01:04:30 GMT, Joe Wang wrote:
> Disables XSLT and XPath Extension Functions by default, setting
> jdk.xml.enableExtensionFunctions to false.
>
> Adjusted tests accordingly.
This pull request has now been integrated.
Changeset: 7ec36bb7
Author:Joe Wang
URL:
https
On Tue, 3 Dec 2024 10:43:20 GMT, Christian Stein wrote:
>> Please review this follow-up PR to improve `java`'s manpage section about
>> wildcards in argument files: the confusing sentence is now removed.
>>
>> This is a cleanup of commit
>> https://github.com/openjdk/jdk/commit/5cb0d438231383d
> To resolve java/io/File/GetXSpace.java failure, I fix libGetXSpace.c to use
> Cygwin’s `df` to get the size for comparison if the test target drive is a
> CD-ROM drive.
>
> As described in JDK-8343342, GetDiskSpaceInformationW can't get information
> about the size of the CD-ROM drive.
> Ge
On Tue, 3 Dec 2024 18:49:43 GMT, Raffaello Giulietti
wrote:
> `jdk.internal.math.FloatingDecimal` parsing is mostly exercised on inputs
> produced by `Float.toString` and `Double.toString`, but should be extended on
> more random inputs.
test/jdk/jdk/internal/math/FloatingDecimal/TestRandomFl
On Mon, 2 Dec 2024 16:50:20 GMT, Liam Miller-Cushon wrote:
>> This change overrides mutator methods in the implementation returned by
>> `Map.of().entrySet()` to throw `UnsupportedOperationException`.
>
> Liam Miller-Cushon has updated the pull request with a new target base due to
> a merge or
On Mon, 2 Dec 2024 23:55:00 GMT, Chen Liang wrote:
> The java.lang.classfile.components package was underused and had almost no
> usage feedback; as a result, it did not caught attention during the preview
> process of the Class-File API, until the late adoption when Class-File API is
> sure t
On Thu, 31 Oct 2024 07:15:16 GMT, Taizo Kurashige wrote:
> To resolve java/io/File/GetXSpace.java failure, I fix libGetXSpace.c to use
> Cygwin’s `df` to get the size for comparison if the test target drive is a
> CD-ROM drive.
>
> As described in JDK-8343342, GetDiskSpaceInformationW can't g
On Tue, 3 Dec 2024 12:34:20 GMT, Alan Bateman wrote:
>> A connection failure introduces a latency in the application, so probably
>> best to have such an event durational as well.
>
> @egahlin The updated PR proposes two duration events: jdk.SocketConnect for
> when a connection is established,
On Mon, 2 Dec 2024 22:44:52 GMT, Chen Liang wrote:
> The java.lang.classfile.components package was underused and had almost no
> usage feedback; as a result, it did not caught attention during the preview
> process of the Class-File API, until the late adoption when Class-File API is
> sure t
On Mon, 2 Dec 2024 22:44:52 GMT, Chen Liang wrote:
> The java.lang.classfile.components package was underused and had almost no
> usage feedback; as a result, it did not caught attention during the preview
> process of the Class-File API, until the late adoption when Class-File API is
> sure t
> Add jlink plugins to allow branding change for java.vendor, java.vm.vendor
> and java.vendor.url.
>
> The jlink plugin will change the value in java.lang.VersionProps, which will
> set those property values. The `java.vm.vendor` was initialized by VM with
> value set at build time, and then l
On Tue, 3 Dec 2024 20:42:08 GMT, Joe Wang wrote:
>> Add test for JDK-8344800 W3C DTDs and XSDs in the built-in Catalog
>
> Joe Wang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> remove unnecessary checks
Looks good
-
Marked
On Tue, 3 Dec 2024 19:55:58 GMT, Joe Wang wrote:
>> Disables XSLT and XPath Extension Functions by default, setting
>> jdk.xml.enableExtensionFunctions to false.
>>
>> Adjusted tests accordingly.
>
> Joe Wang has updated the pull request incrementally with one additional
> commit since the las
Short answer: deprecation is a way to mark an API element such that it
generates warnings when used. One variant of deprecation indicates the
API element is intended to be removed in some future, unspecified, release.
Longer answer: see around slide 62 of
"Contributing to OpenJDK: Participatin
On Tue, 12 Nov 2024 11:00:36 GMT, Severin Gehwolf wrote:
> Please review this fix to how patched modules are being handled when linking
> from the run-time image. During review of
> [JDK-8311302](https://bugs.openjdk.org/browse/JDK-8311302) it was pointed out
> that module patching should be d
> Add test for JDK-8344800 W3C DTDs and XSDs in the built-in Catalog
Joe Wang has updated the pull request incrementally with one additional commit
since the last revision:
remove unnecessary checks
-
Changes:
- all: https://git.openjdk.org/jdk/pull/22506/files
- new: https:/
On Tue, 2 Jul 2024 12:20:17 GMT, Yasumasa Suenaga wrote:
> We cannot pass GNU style options like `--enable-preview` to `jlink
> --add-option`. It is hard to use for complex application.
>
> We have workaround for this issue (see JBS), but I think it is better to fix
> on JDK side.
The propose
On Tue, 3 Dec 2024 17:23:40 GMT, Roger Riggs wrote:
>> Joe Wang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fix error message and inline windows check
>
> src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/runtime/Err
On Tue, 3 Dec 2024 02:22:15 GMT, Joe Wang wrote:
> Add test for JDK-8344800 W3C DTDs and XSDs in the built-in Catalog
Marked as reviewed by rriggs (Reviewer).
test/jaxp/javax/xml/jaxp/unittest/common/jdkcatalog/JDKCatalogTest.java line
217:
> 215: if (line.contains(SYSTEM_ID)) {
>
Improving plugin option value handling to support passing argument value starts
with "--".
Before the fix, in following example, --add-modules will be considered as
another option for JLink instead of argument value for --add-options.
--add-options --add-modules=jdk.incubator.concurrent
--add-op
On Tue, 3 Dec 2024 02:22:15 GMT, Joe Wang wrote:
> Add test for JDK-8344800 W3C DTDs and XSDs in the built-in Catalog
Looks OK. As this is a new test, I would have preferred this to be a junit
test, but lets get this back given where we are for 24 and can address
afterwards
-
Ma
On Tue, 3 Dec 2024 12:52:33 GMT, Jorn Vernee wrote:
> Followup to bump copyright years that were missed in:
> https://github.com/openjdk/jdk/pull/22327
This pull request has now been integrated.
Changeset: 157a4341
Author:Jorn Vernee
URL:
https://git.openjdk.org/jdk/commit/157a4341
> In addition to the goals, scope, motivation, specification and requirement
> notes in [JDK-8315487](https://bugs.openjdk.org/browse/JDK-8315487), we would
> like to describe the most relevant decisions taken during the implementation
> of this enhancement. These notes are organized by feature,
> Disables XSLT and XPath Extension Functions by default, setting
> jdk.xml.enableExtensionFunctions to false.
>
> Adjusted tests accordingly.
Joe Wang has updated the pull request incrementally with one additional commit
since the last revision:
fix error message and inline windows check
-
On Mon, 2 Dec 2024 18:25:22 GMT, Severin Gehwolf wrote:
> Please review this bug fix for using `jlink` when linking from the run-time
> image. For regular JDK builds which include the `jmods` folder, that path is
> automatically added as the `--module-path` when not otherwise specified on
> th
`jdk.internal.math.FloatingDecimal` parsing is mostly exercised on inputs
produced by `Float.toString` and `Double.toString`, but should be extended on
more random inputs.
-
Commit messages:
- Switched to parameterized tests.
- 8345403: Add more randomized tests to better cover Fl
On Tue, 3 Dec 2024 14:42:37 GMT, Severin Gehwolf wrote:
>> Please review this fix to how patched modules are being handled when linking
>> from the run-time image. During review of
>> [JDK-8311302](https://bugs.openjdk.org/browse/JDK-8311302) it was pointed
>> out that module patching should b
On Tue, 3 Dec 2024 18:49:43 GMT, Raffaello Giulietti
wrote:
> `jdk.internal.math.FloatingDecimal` parsing is mostly exercised on inputs
> produced by `Float.toString` and `Double.toString`, but should be extended on
> more random inputs.
All aspects of a syntactically correct input should be
On Tue, 3 Dec 2024 18:01:18 GMT, Mandy Chung wrote:
> > ALL-MODULE-PATH means all observable modules on the module path but here,
> > it's all observable modules minus jdk.jlink or any module that directly
> > requires jdk.jlink. This is hard to reason about, and not exactly right
> > either b
On Tue, 3 Dec 2024 17:53:44 GMT, Alan Bateman wrote:
> > @AlanBateman OK with this too?
>
> ModuleBootstap is the place to initialize the module system and setup the
> boot layer. The ModuleBootstrap.patcher() method is there for its buddy
> SystemModuleFinders, it should not be public. So I s
I think we certainly presumed this would be a deprecation, not a deletion.
To add some more data, from taking a sample, at least a third of usages in
Google's codebase were using it incorrectly in the way we've described.
On Mon, Dec 2, 2024 at 9:20 PM David Alayachew
wrote:
> Thanks Joe.
>
> O
For store method, I wish it was:
1. Null comment, meant no comment and no date.
2. Empty comment, meant date only.
3. Not blank comment, meant comment line and date.
However, too late to change that behavior.
It would be nice if the JDK had a FilterWriter implementation that decorated a
Writer t
On Tue, 3 Dec 2024 15:26:32 GMT, Alan Bateman wrote:
> ALL-MODULE-PATH means all observable modules on the module path but here,
> it's all observable modules minus jdk.jlink or any module that directly
> requires jdk.jlink. This is hard to reason about, and not exactly right
> either because
On Sat, 30 Nov 2024 01:09:50 GMT, Chen Liang wrote:
> Can you try raise this problem in this mailing list
> https://mail.openjdk.org/mailman/listinfo/classfile-api-dev?
Thanks for [mentioning it on the
list](https://mail.openjdk.org/pipermail/classfile-api-dev/2024-December/000613.html)
and i
On Tue, 3 Dec 2024 17:33:09 GMT, Severin Gehwolf wrote:
> @AlanBateman OK with this too?
ModuleBootstap is the place to initialize the module system and setup the boot
layer. The ModuleBootstrap.patcher() method is there for its buddy
SystemModuleFinders, it should not be public. So I suppose
On Tue, 3 Dec 2024 11:42:41 GMT, Lance Andersen wrote:
>> Joe Wang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> uncomment a test in XSLTFunctionsTest
>
> test/jaxp/javax/xml/jaxp/unittest/transform/XSLTFunctionsTest.java line 162:
>
> Disables XSLT and XPath Extension Functions by default, setting
> jdk.xml.enableExtensionFunctions to false.
>
> Adjusted tests accordingly.
Joe Wang has updated the pull request incrementally with one additional commit
since the last revision:
uncomment a test in XSLTFunctionsTest
--
On Tue, 3 Dec 2024 16:59:19 GMT, Chen Liang wrote:
>> Chen Liang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix AnnotationDefaultTest
>
> Thanks for the reviews!
@liach thanks :)
-
PR Comment: https://git.openjdk.org/
JNDI dependency on the `java.applet.Applet` has been removed in JDK9 with
[JDK-8051422](https://bugs.openjdk.org/browse/JDK-8051422). It made the
`Context.APPLET` environment property obsolete and to be ignored when
`javax.naming.InitialContext` is created.
The proposed change removes `javax.na
On Tue, 3 Dec 2024 17:24:51 GMT, Mandy Chung wrote:
> LGTM
Thanks for the review, @mlchung!
-
PR Comment: https://git.openjdk.org/jdk/pull/22037#issuecomment-2515184653
On Tue, 3 Dec 2024 14:42:37 GMT, Severin Gehwolf wrote:
>> Please review this fix to how patched modules are being handled when linking
>> from the run-time image. During review of
>> [JDK-8311302](https://bugs.openjdk.org/browse/JDK-8311302) it was pointed
>> out that module patching should b
On Tue, 3 Dec 2024 01:04:30 GMT, Joe Wang wrote:
> Disables XSLT and XPath Extension Functions by default, setting
> jdk.xml.enableExtensionFunctions to false.
>
> Adjusted tests accordingly.
src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/runtime/ErrorMessages.java
line 28
On Tue, 3 Dec 2024 17:01:06 GMT, Severin Gehwolf wrote:
>> I think the issue is not the default value, but the special treatment with
>> default value. Is there a reason we didn't set COMPANY_NAME to "N/A" as in
>> branding.conf?
>> https://github.com/openjdk/jdk/blame/master/make/autoconf/spec
On Tue, 3 Dec 2024 14:42:37 GMT, Severin Gehwolf wrote:
>> Please review this fix to how patched modules are being handled when linking
>> from the run-time image. During review of
>> [JDK-8311302](https://bugs.openjdk.org/browse/JDK-8311302) it was pointed
>> out that module patching should b
On Wed, 20 Nov 2024 02:59:54 GMT, Justin Lu wrote:
> Please review this PR which keeps the IANA language subtag registry data up
> to date with release _2024-11-19_.
>
> The changes are trivial and Locale tests pass as expected.
This pull request has now been integrated.
Changeset: 9267dfa6
A
On Wed, 20 Nov 2024 02:59:54 GMT, Justin Lu wrote:
> Please review this PR which keeps the IANA language subtag registry data up
> to date with release _2024-11-19_.
>
> The changes are trivial and Locale tests pass as expected.
Thanks for the reviews.
-
PR Comment: https://git.o
On Tue, 3 Dec 2024 15:12:10 GMT, Daniel Fuchs wrote:
>> Tim Prinzing has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> split socket connect failure out to its own event.
>
> src/jdk.jfr/share/conf/jfr/default.jfc line 746:
>
>> 744:
On Tue, 3 Dec 2024 16:29:52 GMT, Henry Jen wrote:
> Instead of default to "N/A", personally I think "OpenJDK" as an organization
> can be used?
OpenJDK is a source only distribution. As such vendor being set to OpenJDK for
the binary doesn't make sense. It's the downstream distro shipping the
On Mon, 2 Dec 2024 16:50:13 GMT, Chen Liang wrote:
> Change the return type of PoolEntry and AnnotationValue tags to int, as in
> TypeAnnotation TargetType and StackMapFrameInfo frameType. The main impact
> is that AnnotationValue tags should be converted to char before printing now.
>
> Plea
On Mon, 2 Dec 2024 18:06:53 GMT, Chen Liang wrote:
>> Change the return type of PoolEntry and AnnotationValue tags to int, as in
>> TypeAnnotation TargetType and StackMapFrameInfo frameType. The main impact
>> is that AnnotationValue tags should be converted to char before printing now.
>>
>>
The java.lang.classfile.components package was underused and had almost no
usage feedback; as a result, it did not caught attention during the preview
process of the Class-File API, until the late adoption when Class-File API is
sure to become finalized. In the previous rounds of reviews by othe
On Mon, 2 Dec 2024 23:55:00 GMT, Chen Liang wrote:
> The java.lang.classfile.components package was underused and had almost no
> usage feedback; as a result, it did not caught attention during the preview
> process of the Class-File API, until the late adoption when Class-File API is
> sure t
On Mon, 2 Dec 2024 23:55:00 GMT, Chen Liang wrote:
> The java.lang.classfile.components package was underused and had almost no
> usage feedback; as a result, it did not caught attention during the preview
> process of the Class-File API, until the late adoption when Class-File API is
> sure t
On Tue, 3 Dec 2024 01:04:30 GMT, Joe Wang wrote:
> Disables XSLT and XPath Extension Functions by default, setting
> jdk.xml.enableExtensionFunctions to false.
>
> Adjusted tests accordingly.
Overall Looks good Joe
please see the comment below
test/jaxp/javax/xml/jaxp/unittest/transform/XSLT
On Sat, 23 Nov 2024 08:36:03 GMT, Alan Bateman wrote:
>> Tim Prinzing has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Added more tests for socket connect events.
>>
>> - SocketAdapter connect
>> - SocketAdapter connect with except
On Tue, 3 Dec 2024 15:40:02 GMT, Tim Prinzing wrote:
>> Adds a JFR event for socket connect operations.
>>
>> Existing tests TestSocketEvents and TestSocketChannelEvents modified to also
>> check for connect events.
>
> Tim Prinzing has updated the pull request with a new target base due to a
On Tue, 3 Dec 2024 00:40:24 GMT, Tim Prinzing wrote:
>> Adds a JFR event for socket connect operations.
>>
>> Existing tests TestSocketEvents and TestSocketChannelEvents modified to also
>> check for connect events.
>
> Tim Prinzing has updated the pull request incrementally with one additional
On Tue, 3 Dec 2024 14:28:22 GMT, Magnus Ihse Bursie wrote:
>> src/java.base/share/classes/java/lang/VersionProps.java.template line 131:
>>
>>> 129: // Default branding.conf value is "N/A", which did not affect
>>> java.vm.vendor
>>> 130: if (! VENDOR_VM.equals("N/A")) {
>>> 131
On Wed, 16 Oct 2024 16:56:38 GMT, Brian Burkhalter wrote:
> Modify the `handleAvailable` native code path to ignore an
> `ERROR_INVALID_FUNCTION` encountered by `PeekNamedPipe` and update an
> existing test to verify this change.
This pull request has now been integrated.
Changeset: 3eaa7615
On Mon, 2 Dec 2024 20:12:39 GMT, Roger Riggs wrote:
> Remove sun/security/action/GetPropertyAction.java and all uses.
>
> Dependent on PR#22418
This pull request has now been integrated.
Changeset: fcf185c8
Author:Roger Riggs
URL:
https://git.openjdk.org/jdk/commit/fcf185c8b425a698
On Mon, 2 Dec 2024 18:06:53 GMT, Chen Liang wrote:
>> Change the return type of PoolEntry and AnnotationValue tags to int, as in
>> TypeAnnotation TargetType and StackMapFrameInfo frameType. The main impact
>> is that AnnotationValue tags should be converted to char before printing now.
>>
>>
On Tue, 3 Dec 2024 14:11:45 GMT, Viktor Klang wrote:
> Excluding this test under Loom until the best fix has been decided upon
This pull request has now been integrated.
Changeset: 2be27e15
Author:Viktor Klang
URL:
https://git.openjdk.org/jdk/commit/2be27e1545a36628eef063d5a20c5e1f2
On Tue, 3 Dec 2024 15:26:32 GMT, Alan Bateman wrote:
> I'm in two minds as to whether we should do anything here.
So am I. The main motivation is that this no longer works with JEP 493 is
enabled (no `jmods` dir):
$ bin/jlink --add-modules ALL-MODULE-PATH --output all-mods
Without looking a
On Mon, 2 Dec 2024 17:41:30 GMT, Coleen Phillimore wrote:
> Putting generated LambdaForm$MH and $DMH in non-class space seems to cause
> excess dependency checking for c2 compiled code and shows a performance
> regression in a new JMH performance test for MethodHandles (to be checked in
> at a
On Mon, 2 Dec 2024 17:41:30 GMT, Coleen Phillimore wrote:
> Putting generated LambdaForm$MH and $DMH in non-class space seems to cause
> excess dependency checking for c2 compiled code and shows a performance
> regression in a new JMH performance test for MethodHandles (to be checked in
> at a
Dumb question...
It seems like the thing with updating copyright years in source files could
be better automated. At least, couldn't there be a test that fails if you
forget?
FWIW my little updater script says that these files still need to be
updated to 2024:
.github/actions/config/action.yml
.
> Adds a JFR event for socket connect operations.
>
> Existing tests TestSocketEvents and TestSocketChannelEvents modified to also
> check for connect events.
Tim Prinzing has updated the pull request with a new target base due to a merge
or a rebase. The pull request now contains 11 commits:
On Mon, 2 Dec 2024 17:41:30 GMT, Coleen Phillimore wrote:
> Putting generated LambdaForm$MH and $DMH in non-class space seems to cause
> excess dependency checking for c2 compiled code and shows a performance
> regression in a new JMH performance test for MethodHandles (to be checked in
> at a
On Mon, 2 Dec 2024 18:25:22 GMT, Severin Gehwolf wrote:
> Please review this bug fix for using `jlink` when linking from the run-time
> image. For regular JDK builds which include the `jmods` folder, that path is
> automatically added as the `--module-path` when not otherwise specified on
> th
On Mon, 2 Dec 2024 17:41:30 GMT, Coleen Phillimore wrote:
> Putting generated LambdaForm$MH and $DMH in non-class space seems to cause
> excess dependency checking for c2 compiled code and shows a performance
> regression in a new JMH performance test for MethodHandles (to be checked in
> at a
On Mon, 2 Dec 2024 19:05:10 GMT, Mandy Chung wrote:
> > The long-term plan would be to not need this at all. If we were to use the
> > jrt FS throughout in JRTArchive I think module patches won't matter and
> > wouldn't populate to the resulting image and this could get removed. But
> > that w
On Tue, 3 Dec 2024 14:53:41 GMT, Eirik Bjørsnøs wrote:
>> Roger Riggs has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Remove an obsolete comment related to long ago removed useNewThrowable
>
> src/java.base/share/classes/java/lang/StackS
On Tue, 3 Dec 2024 14:11:45 GMT, Viktor Klang wrote:
> Excluding this test under Loom until the best fix has been decided upon
Marked as reviewed by alanb (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/22514#pullrequestreview-2475949046
On Tue, 3 Dec 2024 14:45:22 GMT, Roger Riggs wrote:
>> Remove sun/security/action/GetPropertyAction.java and all uses.
>>
>> Dependent on PR#22418
>
> Roger Riggs has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Remove an obsolete comment r
Excluding this test under Loom until the best fix has been decided upon
-
Commit messages:
- Excluding OOMEInStampedLock.java from being executed using a virtual thread
factory
Changes: https://git.openjdk.org/jdk/pull/22514/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=
On Tue, 3 Dec 2024 14:45:22 GMT, Roger Riggs wrote:
>> Remove sun/security/action/GetPropertyAction.java and all uses.
>>
>> Dependent on PR#22418
>
> Roger Riggs has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Remove an obsolete comment r
On Tue, 3 Dec 2024 09:40:39 GMT, Eirik Bjørsnøs wrote:
>> Roger Riggs has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 15 commits:
>>
>> - Merge branch 'master' into 8345325-sm-remove-getpropertyaction
>> - Remove unused import o
> Remove sun/security/action/GetPropertyAction.java and all uses.
>
> Dependent on PR#22418
Roger Riggs has updated the pull request incrementally with one additional
commit since the last revision:
Remove an obsolete comment related to long ago removed useNewThrowable
-
Changes
> Please review this fix to how patched modules are being handled when linking
> from the run-time image. During review of
> [JDK-8311302](https://bugs.openjdk.org/browse/JDK-8311302) it was pointed out
> that module patching should be detected earlier and the link should get
> aborted in that
> This PR proposes to correct errors in the `MemorySegment::getString`
> documentation.
>
> There is a test in
> https://github.com/openjdk/jdk/pull/22451/files#diff-13a3535a65f1e0664e98bd2584196eb9d9a0ada951fd2dabfac8a484263235d8R271
> that actually tests an Exception with the correct message
On Tue, 3 Dec 2024 14:18:09 GMT, Per Minborg wrote:
> Headers are not compliant after
> [JDK-8345164](https://bugs.openjdk.org/browse/JDK-8345164) (a `,` is missing)
This pull request has now been integrated.
Changeset: eac00f6d
Author:Per Minborg
URL:
https://git.openjdk.org/jdk/c
1 - 100 of 136 matches
Mail list logo
