On Mon, 2 Dec 2024 22:51:55 GMT, Roger Riggs wrote:
>> Remove sun/security/action/GetPropertyAction.java and all uses.
>>
>> Dependent on PR#22418
>
> Roger Riggs has updated the pull request with a new target base due to a
> merge or a rebase. The pull request now contains 15 commits:
>
> -
> See the bug for more discussion and reproducer. This PR replaces the ad-hoc
> linked list with segmented list of arrays. Arrays are easy targets for GC.
> There are possible improvements here, most glaring is parallelism that is
> currently knee-capped by global synchronization. The synchroniz
On Wed, 27 Nov 2024 15:59:17 GMT, Alan Bateman wrote:
> Adds `jcmd Thread.vthread_scheduler` to print the virtual thread
> scheduler and `jcmd Thread.vthread_pollers` to print the I/O pollers
> that support virtual threads doing blocking network I/O operations.
>
> This is a subset of the di
On Tue, 3 Dec 2024 03:10:51 GMT, Vladimir Kozlov wrote:
> This fix looks correct by looking on original changes.
Thank you! I need one more (R)eviewer :)
-
PR Comment: https://git.openjdk.org/jdk/pull/22446#issuecomment-2513723257
On Mon, 2 Dec 2024 23:55:00 GMT, Chen Liang wrote:
> The java.lang.classfile.components package was underused and had almost no
> usage feedback; as a result, it did not caught attention during the preview
> process of the Class-File API, until the late adoption when Class-File API is
> sure t
On Mon, 2 Dec 2024 18:54:33 GMT, Alan Bateman wrote:
>> src/java.base/share/classes/jdk/internal/misc/InnocuousThread.java line 31:
>>
>>> 29:
>>> 30: /**
>>> 31: * A thread that has no permissions, is not a member of any user-defined
>>
>> I think you can also remove the words "has no permis
On Mon, 2 Dec 2024 17:47:57 GMT, Daniel Fuchs wrote:
>> Jaikiran Pai has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 13 commits:
>>
>> - merge latest from master branch
>> - remove changes to
>> src/java.base/unix/classes/sun/s
> Can I please get a review of this change which removes usages of
> SecurityManager related APIs and some leftover related to SecurityManager
> changes?
>
> This addresses https://bugs.openjdk.org/browse/JDK-8345286. Most of these
> changes are trivial. The
> `src/java.base/linux/classes/jdk/
On Wed, 7 Aug 2024 00:02:46 GMT, Joe Darcy wrote:
>> First pass at adding some quality of implementation discussions around the
>> overridable methods of Object.
>
> Joe Darcy has updated the pull request with a new target base due to a merge
> or a rebase. The incremental webrev excludes the u
On Mon, 2 Dec 2024 14:25:12 GMT, Alan Bateman wrote:
>> Jaikiran Pai has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - remove unused import
>> - replace remaining Paths.get() with Path.of() in the updated files
>
> src/java.base/linux/c
On Wed, 24 Jul 2024 05:33:29 GMT, Joe Darcy wrote:
>> I would hope to spend as little space on this as possible, perhaps "This
>> method should avoid throwing or propagating any exceptions unless it
>> legitimately _cannot_ adhere to this contract."
>> (or shorter)
>
>> I would hope to spend as
Thanks Joe.
Ok, so deprecations are basically a super-regulated way to achieve a
certain amount of backwards incompatibility without breaking Java's core
promise?
On Mon, Dec 2, 2024, 11:17 PM Joseph D. Darcy wrote:
> There is a policy for managing deprecations:
>
>https://openjdk.org/jeps
On Tue, 3 Dec 2024 02:26:03 GMT, Justin Lu wrote:
>> src/java.base/share/classes/java/util/Locale.java line 76:
>>
>>> 74: * or cultural region. An API that requires a {@code Locale} to perform
>>> 75: * its task is locale-sensitive and uses the {@code Locale}
>>> 76: * to tailor information
There is a policy for managing deprecations:
https://openjdk.org/jeps/277
Most the incompatible step, actually removing the declaration in
question, if it occurs at all, would only occur after a warning period.
HTH,
-Joe
On 12/2/2024 6:24 PM, David Alayachew wrote:
As a data point of one,
On Tue, 3 Dec 2024 02:29:16 GMT, Justin Lu wrote:
>> Please review this PR and corresponding CSR which includes a wide range of
>> specification improvements for java.util.Locale. See the CSR for further
>> detail. Other changes/suggestions are welcomed to be included as part of
>> this change
On Thu, 31 Oct 2024 07:15:16 GMT, Taizo Kurashige wrote:
> To resolve java/io/File/GetXSpace.java failure, I fix libGetXSpace.c to use
> Cygwin’s `df` to get the size for comparison if the test target drive is a
> CD-ROM drive.
>
> As described in JDK-8343342, GetDiskSpaceInformationW can't g
On Mon, 2 Dec 2024 13:43:41 GMT, Severin Gehwolf wrote:
>> Jaikiran Pai has updated the pull request incrementally with four additional
>> commits since the last revision:
>>
>> - remove unnecessary space
>> - Path.of() instead of Paths.get()
>> - fix formatting of try-with-resources in Cgro
On Wed, 10 Jul 2024 22:33:54 GMT, Joe Darcy wrote:
> First pass at adding some quality of implementation discussions around the
> overridable methods of Object.
This pull request has been closed without being integrated.
-
PR: https://git.openjdk.org/jdk/pull/20128
On Thu, 28 Nov 2024 18:22:24 GMT, Aleksey Shipilev wrote:
> Found this while cleaning up x86_32 code for removal.
>
> In our current code there is a block added by
> [JDK-8076373](https://bugs.openjdk.org/browse/JDK-8076373):
> https://github.com/openjdk/jdk/blob/3b21a298c29d88720f6bfb2dc1f3305
On Mon, 2 Dec 2024 23:00:20 GMT, Joe Darcy wrote:
>> Justin Lu has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> reflect review
>
> src/java.base/share/classes/java/util/Locale.java line 76:
>
>> 74: * or cultural region. An API that req
> Please review this PR and corresponding CSR which includes a wide range of
> specification improvements for java.util.Locale. See the CSR for further
> detail. Other changes/suggestions are welcomed to be included as part of this
> change.
>
> APIDiff:
> https://cr.openjdk.org/~jlu/8341923_a
On Mon, 2 Dec 2024 04:19:08 GMT, Jaikiran Pai wrote:
> Can I please get a review of this trivial typo fix in the javadoc of
> `javax.sql.rowset.BaseRowSet#setBigDecimal()` method?
>
> As noted in https://bugs.openjdk.org/browse/JDK-8345279, the javadoc
> incorrectly mentions `java.lang.BigDeci
On Mon, 2 Dec 2024 04:19:08 GMT, Jaikiran Pai wrote:
> Can I please get a review of this trivial typo fix in the javadoc of
> `javax.sql.rowset.BaseRowSet#setBigDecimal()` method?
>
> As noted in https://bugs.openjdk.org/browse/JDK-8345279, the javadoc
> incorrectly mentions `java.lang.BigDeci
As a data point of one, we use all of the abovementioned constants
regularly for my day job. In total, we have maybe a couple thousand
instances of that constant being referenced. Ripping out wouldn't be too
painful as long as I was told exactly what the replacements were, but I
wouldn't be thrille
Add test for JDK-8344800 W3C DTDs and XSDs in the built-in Catalog
-
Commit messages:
- 8345353: Test for JDK-8344800 W3C DTDs and XSDs in the built-in Catalog
Changes: https://git.openjdk.org/jdk/pull/22506/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=22506&range=00
I
On Mon, 2 Dec 2024 22:51:55 GMT, Roger Riggs wrote:
>> Remove sun/security/action/GetPropertyAction.java and all uses.
>>
>> Dependent on PR#22418
>
> Roger Riggs has updated the pull request with a new target base due to a
> merge or a rebase. The pull request now contains 15 commits:
>
> -
Draft for preliminary review. Writing CSR right now.
-
Commit messages:
- 8345344: Hide java.lang.classfile.components package to implementation
Changes: https://git.openjdk.org/jdk/pull/22503/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=22503&range=00
Issue: https://b
On Wed, 16 Oct 2024 16:56:38 GMT, Brian Burkhalter wrote:
> Modify the `handleAvailable` native code path to ignore an
> `ERROR_INVALID_FUNCTION` encountered by `PeekNamedPipe` and update an
> existing test to verify this change.
Ping ...
-
PR Comment: https://git.openjdk.org/jdk
On Mon, 2 Dec 2024 22:51:55 GMT, Roger Riggs wrote:
>> Remove sun/security/action/GetPropertyAction.java and all uses.
>>
>> Dependent on PR#22418
>
> Roger Riggs has updated the pull request with a new target base due to a
> merge or a rebase. The pull request now contains 15 commits:
>
> -
Hmm. I understand the motivation here and the asymmetry with the
integral types, but on the whole I don't think deprecating {Float,
Double}.MIN_VALUE and recommending use of a differently-named field with
the same value would be a net improvement.
-Joe
On 12/2/2024 3:17 PM, Éamonn McManus wro
Disables XSLT and XPath Extension Functions by default, setting
jdk.xml.enableExtensionFunctions to false.
Adjusted tests accordingly.
-
Commit messages:
- 8343001: Adjust XSLT and XPath Extension Function Property
Changes: https://git.openjdk.org/jdk/pull/22504/files
Webrev: ht
On Mon, 2 Dec 2024 16:11:57 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which removes usages of
>> SecurityManager related APIs and some leftover related to SecurityManager
>> changes?
>>
>> This addresses https://bugs.openjdk.org/browse/JDK-8345286. Most of these
>>
On Mon, 2 Dec 2024 22:57:01 GMT, Pavel Rappo wrote:
>> Prepare for JDK 25.
>
> Pavel Rappo has updated the pull request with a new target base due to a
> merge or a rebase. The pull request now contains 13 commits:
>
> - Update --release 24 symbol information for JDK 24 build 26
>
>The
> Adds a JFR event for socket connect operations.
>
> Existing tests TestSocketEvents and TestSocketChannelEvents modified to also
> check for connect events.
Tim Prinzing has updated the pull request incrementally with one additional
commit since the last revision:
split socket connect fail
On Mon, 2 Dec 2024 05:26:30 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this enhancement which proposes to enhance
>> `java.util.zip.Deflater/Inflater` classes to now implement `AutoCloseable`?
>>
>> The actual work for this was done a few years back when we discussed the
>> propo
On Mon, 2 Dec 2024 14:26:08 GMT, Maurizio Cimadamore
wrote:
>> As this is an internal API, I tried to keep it as similar as possible to the
>> other bulk operations. But as you say, the value used here for the last
>> parameter is always `segment.byteSize()`. We could easily change it. What's
I think in our internal review, we've been nervous about the ambiguity of
whether MAX_NEGATIVE_VALUE has the smallest nonzero absolute value, or the
largest finite absolute value. Forcing users to negate sidesteps the issue.
On Mon, Dec 2, 2024 at 3:25 PM Archie Cobbs wrote:
> Having been bitte
On Fri, 15 Nov 2024 22:17:10 GMT, Chen Liang wrote:
> When core reflection was migrated to be implemented by Method Handles,
> somehow, the method handles are not used for native methods, which are
> generally linkable by method handles. This causes significant performance
> regressions when
On Mon, 2 Dec 2024 19:45:15 GMT, Chen Liang wrote:
>> When core reflection was migrated to be implemented by Method Handles,
>> somehow, the method handles are not used for native methods, which are
>> generally linkable by method handles. This causes significant performance
>> regressions wh
Having been bitten by this bug myself, I would vote yes on this one.
For symmetry's sake, I would think there should be four new constants - for
{MIN,MAX}_{POSITIVE,NEGATIVE}_VALUE - and that both of {MIN,MAX}_VALUE
should be deprecated.
-Archie
On Mon, Dec 2, 2024 at 5:18 PM Éamonn McManus wro
On Fri, 29 Nov 2024 18:53:52 GMT, Nizar Benalla wrote:
>> Can I please get a review for this PR that add tests to verify the value of
>> `@since` tags to the Tools area modules. The test is described in this
>> [email](https://mail.openjdk.org/pipermail/jdk-dev/2024-October/009474.html).
>> Th
> Can I please get a review for this PR that add tests to verify the value of
> `@since` tags to the Tools area modules. The test is described in this
> [email](https://mail.openjdk.org/pipermail/jdk-dev/2024-October/009474.html).
> This issue is similar to JDK-8341399, JDK-8331051 and JDK-83434
At Google, we've had several issues over the years relating to
Double.MIN_VALUE. People have not unreasonably supposed that
Double.MIN_VALUE has the same relationship to Double.MAX_VALUE as
Integer.MIN_VALUE has to Integer.MAX_VALUE. So they think that
Double.MIN_VALUE is the (finite) negative numb
On Mon, 2 Dec 2024 19:59:51 GMT, David Holmes wrote:
>> I agree. This is to minimize change on behavior.
>>
>> Not sure what kind of requirement is there for java.vm.vendor, would it be
>> OK for VM not the set this value and wait until loading of VersionProps
>> class?
>>
>> The update is n
On Mon, 2 Dec 2024 19:52:36 GMT, David Holmes wrote:
>> Add jlink plugins to allow branding change for java.vendor, java.vm.vendor
>> and java.vendor.url.
>>
>> The jlink plugin will change the value in java.lang.VersionProps, which will
>> set those property values. The `java.vm.vendor` was i
On Thu, 7 Nov 2024 21:38:28 GMT, Henry Jen wrote:
> Add jlink plugins to allow branding change for java.vendor, java.vm.vendor
> and java.vendor.url.
>
> The jlink plugin will change the value in java.lang.VersionProps, which will
> set those property values. The `java.vm.vendor` was initializ
On Mon, 2 Dec 2024 22:51:55 GMT, Roger Riggs wrote:
>> Remove sun/security/action/GetPropertyAction.java and all uses.
>>
>> Dependent on PR#22418
>
> Roger Riggs has updated the pull request with a new target base due to a
> merge or a rebase. The pull request now contains 15 commits:
>
> -
On Thu, 21 Nov 2024 06:53:58 GMT, Justin Lu wrote:
>> Please review this PR and corresponding CSR which includes a wide range of
>> specification improvements for java.util.Locale. See the CSR for further
>> detail. Other changes/suggestions are welcomed to be included as part of
>> this chang
On Tue, 26 Nov 2024 17:17:09 GMT, Magnus Ihse Bursie wrote:
>> As a prerequisite for Hermetic Java, we need a statically linked `java`
>> launcher. It should behave like the normal, dynamically linked `java`
>> launcher, except that all JDK native libraries should be statically, not
>> dynamic
> Prepare for JDK 25.
Pavel Rappo has updated the pull request with a new target base due to a merge
or a rebase. The pull request now contains 13 commits:
- Update --release 24 symbol information for JDK 24 build 26
The macOS/AArch64 build 26 was taken from https://jdk.java.net/24/
- M
> Remove sun/security/action/GetPropertyAction.java and all uses.
>
> Dependent on PR#22418
Roger Riggs has updated the pull request with a new target base due to a merge
or a rebase. The pull request now contains 15 commits:
- Merge branch 'master' into 8345325-sm-remove-getpropertyaction
-
On Mon, 2 Dec 2024 22:02:54 GMT, Sean Mullan wrote:
> This includes a lot of changes already integrated in 8344397. Is that normal?
I believe this is due to GitHub's diff rendering when it detects a merge
conflict. It should go away once the conflict is fixed.
-
PR Comment: https
On Sat, 30 Nov 2024 09:53:25 GMT, Joe Wang wrote:
> Add DTDs and XSDs from the W3C specifications to the JDK built-in Catalog.
This pull request has now been integrated.
Changeset: 3a3bcd53
Author:Joe Wang
URL:
https://git.openjdk.org/jdk/commit/3a3bcd53d0b9aa55dcbc15de4d8278ce3258b
On Mon, 2 Dec 2024 20:47:16 GMT, Roger Riggs wrote:
>> Remove sun/security/action/GetPropertyAction.java and all uses.
>>
>> Dependent on PR#22418
>
> Roger Riggs has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - Remove unused import of Pr
On Mon, 2 Dec 2024 14:24:57 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which removes usages of
>> SecurityManager related APIs and some leftover related to SecurityManager
>> changes?
>>
>> This addresses https://bugs.openjdk.org/browse/JDK-8345286. Most of these
>>
On Mon, 2 Dec 2024 14:03:10 GMT, Jaikiran Pai wrote:
>> src/java.base/linux/classes/jdk/internal/platform/CgroupSubsystemController.java
>> line 70:
>>
>>> 68: String line = bufferedReader.readLine();
>>> 69: return line;
>>> 70: } catch (IOException e) {
>>
>>
> Can I please get a review of this change which removes usages of
> SecurityManager related APIs and some leftover related to SecurityManager
> changes?
>
> This addresses https://bugs.openjdk.org/browse/JDK-8345286. Most of these
> changes are trivial. The
> `src/java.base/linux/classes/jdk/
On Mon, 2 Dec 2024 14:17:10 GMT, Severin Gehwolf wrote:
> cgroups changes look good. Haven't looked at the other bits.
Thank you Severin.
> src/java.base/linux/classes/jdk/internal/platform/CgroupSubsystemController.java
> line 29:
>
>> 27: package jdk.internal.platform;
>> 28:
>> 29: import
On Fri, 22 Nov 2024 17:33:35 GMT, Aleksey Shipilev wrote:
>> See the bug for more discussion and reproducer. This PR replaces the ad-hoc
>> linked list with segmented list of arrays. Arrays are easy targets for GC.
>> There are possible improvements here, most glaring is parallelism that is
>>
On Tue, 19 Nov 2024 17:31:42 GMT, Naoto Sato wrote:
> Windows Java runtime has a mapping file /lib/tzmappings which maps Windows
> time zones to Java's time zones. The file is generated based on CLDR's
> windowsZones.xml, but in rare occasions, its update is out of sync with
> Windows updates.
> This change overrides mutator methods in the implementation returned by
> `Map.of().entrySet()` to throw `UnsupportedOperationException`.
Liam Miller-Cushon has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev excludes the unrelated changes
br
On Mon, 2 Dec 2024 14:24:25 GMT, Maurizio Cimadamore
wrote:
>> Per Minborg has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Improve docs
>
> test/jdk/java/foreign/TestStringEncoding.java line 263:
>
>> 261: for (var arena: a
On Mon, 2 Dec 2024 15:40:18 GMT, Per Minborg wrote:
>> This PR proposes to rewrite the `StringSupport::chunkedStrlen*` methods,
>> fixing a bug in the `short_strlen` variant for odd offsets (`offset % 2 !=
>> 0`).
>>
>> This PR also improves performance on modern hardware, as there is no need
On Mon, 2 Dec 2024 20:47:16 GMT, Roger Riggs wrote:
>> Remove sun/security/action/GetPropertyAction.java and all uses.
>>
>> Dependent on PR#22418
>
> Roger Riggs has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - Remove unused import of Pr
On Mon, 2 Dec 2024 00:37:45 GMT, Xue-Lei Andrew Fan wrote:
>> Martin Balao has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Undo SunNativeProvider provider changes. They will be implemented in
>> JDK-8345221.
>
> Thank you for the respon
> Can I please get a review of this change which removes usages of
> SecurityManager related APIs and some leftover related to SecurityManager
> changes?
>
> This addresses https://bugs.openjdk.org/browse/JDK-8345286. Most of these
> changes are trivial. The
> `src/java.base/linux/classes/jdk/
On Mon, 2 Dec 2024 20:40:23 GMT, Eirik Bjørsnøs wrote:
>> Yes, with Sean's changes in #22418, GetPropertyAction et.al. is deleted.
>
> @RogerRiggs Alan may have referred to the import of `java.util.Properties`.
Right, thanks
-
PR Review Comment: https://git.openjdk.org/jdk/pull/224
On Mon, 2 Dec 2024 20:28:13 GMT, Roger Riggs wrote:
>> src/java.base/share/classes/java/lang/invoke/MethodHandleNatives.java line
>> 710:
>>
>>> 708:
>>> 709: static {
>>> 710: Properties props = GetPropertyAction.privilegedGetProperties();
>>
>> This is probably the last usage of
On Mon, 2 Dec 2024 20:44:05 GMT, Roger Riggs wrote:
>> Remove sun/security/action/GetPropertyAction.java and all uses.
>>
>> Dependent on PR#22418
>
> Roger Riggs has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - Remove unused import of Pr
> Remove sun/security/action/GetPropertyAction.java and all uses.
>
> Dependent on PR#22418
Roger Riggs has updated the pull request incrementally with two additional
commits since the last revision:
- Remove unused import of Properties
- Update copyrights
Remove jdk/sun/security/action/Ge
On Wed, 13 Nov 2024 12:06:58 GMT, Alan Bateman wrote:
>> Changes for [JEP draft: Structured Concurrency (Fifth
>> Preview)](https://openjdk.org/jeps/8340343). The JEP isn't on the technical
>> roadmap yet. The proposal is to re-preview the API with some changes,
>> specifically:
>>
>> - A
>>
On Mon, 2 Dec 2024 20:12:39 GMT, Roger Riggs wrote:
> Remove sun/security/action/GetPropertyAction.java and all uses.
>
> Dependent on PR#22418
LGTM
-
Marked as reviewed by naoto (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/22497#pullrequestreview-2473841217
On Mon, 2 Dec 2024 20:19:23 GMT, Alan Bateman wrote:
>> Remove sun/security/action/GetPropertyAction.java and all uses.
>>
>> Dependent on PR#22418
>
> src/java.base/share/classes/java/lang/invoke/MethodHandleNatives.java line
> 710:
>
>> 708:
>> 709: static {
>> 710: Properties p
On Thu, 7 Nov 2024 21:38:28 GMT, Henry Jen wrote:
> Add jlink plugins to allow branding change for java.vendor, java.vm.vendor
> and java.vendor.url.
>
> The jlink plugin will change the value in java.lang.VersionProps, which will
> set those property values. The `java.vm.vendor` was initializ
On Mon, 2 Dec 2024 20:12:39 GMT, Roger Riggs wrote:
> Remove sun/security/action/GetPropertyAction.java and all uses.
>
> Dependent on PR#22418
src/java.base/share/classes/java/lang/invoke/MethodHandleNatives.java line 710:
> 708:
> 709: static {
> 710: Properties props = GetPrope
On Mon, 2 Dec 2024 20:12:39 GMT, Roger Riggs wrote:
> Remove sun/security/action/GetPropertyAction.java and all uses.
>
> Dependent on PR#22418
Changes Look Good Roger
-
Marked as reviewed by lancea (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/22497#pullrequestreview-2
On Mon, 2 Dec 2024 20:13:55 GMT, Joe Wang wrote:
>> Add DTDs and XSDs from the W3C specifications to the JDK built-in Catalog.
>
> Joe Wang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> value unnecessary for the ternary expression
Marked
On Mon, 2 Dec 2024 20:13:55 GMT, Joe Wang wrote:
>> Add DTDs and XSDs from the W3C specifications to the JDK built-in Catalog.
>
> Joe Wang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> value unnecessary for the ternary expression
Marked
On Mon, 2 Dec 2024 14:07:45 GMT, Severin Gehwolf wrote:
>> Is the catch for `UncheckedIOException` due to some previously known failure
>> resulting in the use of these APIs?
>
> Without using `Files.lines()` no `UncheckedIOException` would be thrown. Just
> `IOException` and `null` returned. T
On Mon, 2 Dec 2024 13:06:05 GMT, Severin Gehwolf wrote:
>> Jaikiran Pai has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Path.of() instead of Paths.get() in CgroupV2Subsystem.java
>
> src/java.base/linux/classes/jdk/internal/platform/cgro
Remove sun/security/action/GetPropertyAction.java and all uses.
Dependent on PR#22418
-
Depends on: https://git.openjdk.org/jdk/pull/22418
Commit messages:
- 8345325: SM cleanup of GetPropertyAction in java.base
Changes: https://git.openjdk.org/jdk/pull/22497/files
Webrev: https
On Mon, 2 Dec 2024 17:41:30 GMT, Coleen Phillimore wrote:
> Putting generated LambdaForm$MH and $DMH in non-class space seems to cause
> excess dependency checking for c2 compiled code and shows a performance
> regression in a new JMH performance test for MethodHandles (to be checked in
> at a
On Mon, 2 Dec 2024 19:44:02 GMT, Brian Burkhalter wrote:
>> Modify the `handleAvailable` native code path to ignore an
>> `ERROR_INVALID_FUNCTION` encountered by `PeekNamedPipe` and update an
>> existing test to verify this change.
>
> Brian Burkhalter has updated the pull request with a new ta
On Mon, 2 Dec 2024 18:14:42 GMT, Roger Riggs wrote:
>> Joe Wang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> list files vertically
>
> src/java.xml/share/classes/com/sun/org/apache/xerces/internal/impl/XMLEntityManager.java
> line 12
> Add DTDs and XSDs from the W3C specifications to the JDK built-in Catalog.
Joe Wang has updated the pull request incrementally with one additional commit
since the last revision:
value unnecessary for the ternary expression
-
Changes:
- all: https://git.openjdk.org/jdk/pull/2
On Tue, 19 Nov 2024 17:31:42 GMT, Naoto Sato wrote:
> Windows Java runtime has a mapping file /lib/tzmappings which maps Windows
> time zones to Java's time zones. The file is generated based on CLDR's
> windowsZones.xml, but in rare occasions, its update is out of sync with
> Windows updates.
On Tue, 3 Sep 2024 12:50:01 GMT, Magnus Ihse Bursie wrote:
> As a prerequisite for Hermetic Java, we need a statically linked `java`
> launcher. It should behave like the normal, dynamically linked `java`
> launcher, except that all JDK native libraries should be statically, not
> dynamically,
On Thu, 7 Nov 2024 21:38:28 GMT, Henry Jen wrote:
> Add jlink plugins to allow branding change for java.vendor, java.vm.vendor
> and java.vendor.url.
>
> The jlink plugin will change the value in java.lang.VersionProps, which will
> set those property values. The `java.vm.vendor` was initializ
On Mon, 2 Dec 2024 18:53:12 GMT, Henry Jen wrote:
>> src/hotspot/share/runtime/threads.cpp line 654:
>>
>>> 652: initialize_java_lang_classes(main_thread, CHECK_JNI_ERR);
>>> 653: // Update the java.vm.vendor property with
>>> java.lang.VersionProps.VM_VENDOR
>>> 654: Arguments::update_vm
On Mon, 2 Dec 2024 19:45:15 GMT, Chen Liang wrote:
>> When core reflection was migrated to be implemented by Method Handles,
>> somehow, the method handles are not used for native methods, which are
>> generally linkable by method handles. This causes significant performance
>> regressions wh
On Mon, 2 Dec 2024 16:11:57 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which removes usages of
>> SecurityManager related APIs and some leftover related to SecurityManager
>> changes?
>>
>> This addresses https://bugs.openjdk.org/browse/JDK-8345286. Most of these
>>
On Mon, 2 Dec 2024 12:43:20 GMT, Alan Bateman wrote:
>> Jaikiran Pai has updated the pull request incrementally with four additional
>> commits since the last revision:
>>
>> - remove unnecessary space
>> - Path.of() instead of Paths.get()
>> - fix formatting of try-with-resources in CgroupS
On Mon, 2 Dec 2024 19:25:46 GMT, Mandy Chung wrote:
>> Chen Liang has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains four additional
>> commits sin
On Wed, 27 Nov 2024 20:05:58 GMT, Severin Gehwolf wrote:
> The long-term plan would be to not need this at all. If we were to use the
> jrt FS throughout in JRTArchive I think module patches won't matter and
> wouldn't populate to the resulting image and this could get removed. But that
> woul
> When core reflection was migrated to be implemented by Method Handles,
> somehow, the method handles are not used for native methods, which are
> generally linkable by method handles. This causes significant performance
> regressions when reflecting native methods, even if their overrides may
On Mon, 2 Dec 2024 13:39:57 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which removes usages of
>> SecurityManager related APIs and some leftover related to SecurityManager
>> changes?
>>
>> This addresses https://bugs.openjdk.org/browse/JDK-8345286. Most of these
>>
> Modify the `handleAvailable` native code path to ignore an
> `ERROR_INVALID_FUNCTION` encountered by `PeekNamedPipe` and update an
> existing test to verify this change.
Brian Burkhalter has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev exc
Change the return type of PoolEntry and AnnotationValue tags to int, as in
TypeAnnotation TargetType and StackMapFrameInfo frameType. The main impact is
that AnnotationValue tags should be converted to char before printing now.
Please review the associated CSR for this hotfix as well.
Testing:
On Wed, 27 Nov 2024 17:23:10 GMT, Aleksey Shipilev wrote:
>> How about this:
>>
>>> ...the problem is in GC time hiccups to walk the large linked lists.
>>
>> Though, for this test, `CleanableList` itself is not being walked.
>>
>> Rather, `CleanableList` itself is a factor in as much as it ex
On Wed, 27 Nov 2024 01:04:06 GMT, Chen Liang wrote:
>> When core reflection was migrated to be implemented by Method Handles,
>> somehow, the method handles are not used for native methods, which are
>> generally linkable by method handles. This causes significant performance
>> regressions w
1 - 100 of 152 matches
Mail list logo
