Re: RFR: 8344800: Add W3C DTDs and XSDs to the JDK built-in Catalog [v2]

2024-11-30 Thread Alan Bateman
On Sat, 30 Nov 2024 19:43:52 GMT, Joe Wang wrote: >> src/java.xml/share/classes/module-info.java line 484: >> >>> 482: * >>> 483: * xhtml-attribs-1.xsd xhtml-copyright-1.xsd xhtml-datatypes-1.xsd >>> xhtml-framework-1.xsd >>> 484: * xhtml11-model-1.xsd xhtml11-modules-1.xsd xhtml11.xsd >>

Re: RFR: 8315487: Security Providers Filter [v9]

2024-11-30 Thread Martin Balao
On Sat, 30 Nov 2024 18:56:31 GMT, Xue-Lei Andrew Fan wrote: >> Hi @XueleiFan, >> >> Is not a goal of this proposal to allow different filter implementations, >> for this reason, there isn't a pluggable filter API design. The only >> publicly API exposed by the filter is the `jdk.security.provi

Re: RFR: 8344800: Add W3C DTDs and XSDs to the JDK built-in Catalog [v2]

2024-11-30 Thread Lance Andersen
On Sat, 30 Nov 2024 19:47:15 GMT, Joe Wang wrote: >> Add DTDs and XSDs from the W3C specifications to the JDK built-in Catalog. > > Joe Wang has updated the pull request incrementally with one additional > commit since the last revision: > > list files vertically Changes look good Joe than

Re: RFR: 8344800: Add W3C DTDs and XSDs to the JDK built-in Catalog [v2]

2024-11-30 Thread Joe Wang
On Sat, 30 Nov 2024 14:59:08 GMT, Alan Bateman wrote: >> Joe Wang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> list files vertically > > src/java.xml/share/classes/module-info.java line 484: > >> 482: * >> 483: * xhtml-attribs-1.x

Re: RFR: 8344800: Add W3C DTDs and XSDs to the JDK built-in Catalog [v2]

2024-11-30 Thread Joe Wang
> Add DTDs and XSDs from the W3C specifications to the JDK built-in Catalog. Joe Wang has updated the pull request incrementally with one additional commit since the last revision: list files vertically - Changes: - all: https://git.openjdk.org/jdk/pull/22465/files - new: htt

Re: RFR: 8315487: Security Providers Filter [v9]

2024-11-30 Thread Xue-Lei Andrew Fan
On Fri, 29 Nov 2024 19:22:57 GMT, Francisco Ferrari Bihurriet wrote: > ... We agree that this pull request is too large to review ... Thank you! > ... Is not a goal of this proposal to allow different filter implementations Got it. Thank you for the clarification. But, does it sound reason

Re: RFR: 8344800: Add W3C DTDs and XSDs to the JDK built-in Catalog

2024-11-30 Thread Alan Bateman
On Sat, 30 Nov 2024 09:53:25 GMT, Joe Wang wrote: > Add DTDs and XSDs from the W3C specifications to the JDK built-in Catalog. src/java.xml/share/classes/module-info.java line 484: > 482: * > 483: * xhtml-attribs-1.xsd xhtml-copyright-1.xsd xhtml-datatypes-1.xsd > xhtml-framework-1.xsd > 48

RFR: 8344800: Add W3C DTDs and XSDs to the JDK built-in Catalog

2024-11-30 Thread Joe Wang
Add DTDs and XSDs from the W3C specifications to the JDK built-in Catalog. - Commit messages: - fix whitespace - 8344800: Add W3C DTDs and XSDs to the JDK built-in Catalog Changes: https://git.openjdk.org/jdk/pull/22465/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=22465