On Fri, 29 Nov 2024 07:25:23 GMT, Jan Lahoda wrote:
>> Currently, running `java` without any parameters will lead to an output that
>> is a full `--help`, which is over 100 lines (on my computer at least), and
>> it feels overwhelming. And many people might actually want to run
>> JShell/REPL,
On Fri, 29 Nov 2024 07:25:23 GMT, Jan Lahoda wrote:
>> Currently, running `java` without any parameters will lead to an output that
>> is a full `--help`, which is over 100 lines (on my computer at least), and
>> it feels overwhelming. And many people might actually want to run
>> JShell/REPL,
> Currently, running `java` without any parameters will lead to an output that
> is a full `--help`, which is over 100 lines (on my computer at least), and it
> feels overwhelming. And many people might actually want to run JShell/REPL,
> not the `java` executable, but it is difficult find out a
On Thu, 28 Nov 2024 15:54:54 GMT, Alan Bateman wrote:
>> Adds `jcmd Thread.vthread_scheduler` to print the virtual thread
>> scheduler and `jcmd Thread.vthread_pollers` to print the I/O pollers
>> that support virtual threads doing blocking network I/O operations.
>>
>> This is a subset of t
On Thu, 28 Nov 2024 09:48:25 GMT, Severin Gehwolf wrote:
>> This PR adds missing Classpath exception in several files.
>>
>> JBS Issue: [JDK-8334611](https://bugs.openjdk.org/browse/JDK-8344611)
>
> src/java.base/share/native/libjava/ub.h
> src/jdk.jlink/share/classes/jdk/tools/jlink/internal/ru
On Tue, 24 Sep 2024 13:31:25 GMT, Eirik Bjørsnøs wrote:
> Please consider this PR which makes `ZipFileInflaterInputStream` release its
> `Inflater` instance back to the pool when observing that the stream has been
> fully consumed.
>
> This is motivated by the following observations:
>
> * Af
On Fri, 29 Nov 2024 01:09:16 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change, which simplifies the interaction
>> between the `java` launcher's native code with the
>> `sun.launcher.LauncherHelper`?
>>
>> As noted in https://bugs.openjdk.org/browse/JDK-8341184, this propo
On Mon, 30 Sep 2024 08:02:16 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change, which simplifies the interaction
> between the `java` launcher's native code with the
> `sun.launcher.LauncherHelper`?
>
> As noted in https://bugs.openjdk.org/browse/JDK-8341184, this proposed c
> Can I please get a review of this change, which simplifies the interaction
> between the `java` launcher's native code with the
> `sun.launcher.LauncherHelper`?
>
> As noted in https://bugs.openjdk.org/browse/JDK-8341184, this proposed change
> reduces the back and forth between the launcher
On Fri, 26 Jul 2024 14:20:07 GMT, Shaojin Wen wrote:
> By removing the redundant code logic in
> DateTimeFormatterBuilder$InstantPrinterParser#formatTo, the codeSize can be
> reduced and the performance can be improved.
This pull request has been closed without being integrated.
-
On Fri, 30 Aug 2024 07:27:11 GMT, Eirik Bjørsnøs wrote:
> Please review this PR with picks up on the excellent work done by
> @archiecobbs in #18385
>
> The proposed changes aim to solve two issues with the current
> `java.util.zip.GZIPInputStream`:
>
> * The class parses multiple concatenat
Found this while cleaning up x86_32 code for removal.
In our current code there is a block added by
[JDK-8076373](https://bugs.openjdk.org/browse/JDK-8076373):
https://github.com/openjdk/jdk/blob/3b21a298c29d88720f6bfb2dc1f3305b6a3db307/src/hotspot/share/compiler/compileBroker.cpp#L1451-L1473
Os
On Thu, 28 Nov 2024 18:22:24 GMT, Aleksey Shipilev wrote:
> Found this while cleaning up x86_32 code for removal.
>
> In our current code there is a block added by
> [JDK-8076373](https://bugs.openjdk.org/browse/JDK-8076373):
> https://github.com/openjdk/jdk/blob/3b21a298c29d88720f6bfb2dc1f3305
> After changing `BigInteger.sqrt()` algorithm, this can be also used to speed
> up `BigDecimal.sqrt()` implementation. Here is how I made it.
>
> The main steps of the algorithm are as follows:
> first argument reduce the value to an integer using the following relations:
>
> x = y * 10 ^ exp
>
On Thu, 28 Nov 2024 00:17:43 GMT, Aleksei Efimov wrote:
> The proposed change cleans-up `SecurityManager`, `doPriviledged`, and
> `AccessController` usages from `java.naming`, `jdk.naming.rmi` and
> `jdk.naming.dns` modules.
>
> One noteworthy change: The `java.naming.rmi.security.manager` JND
On Tue, 26 Nov 2024 20:48:24 GMT, Eirik Bjørsnøs wrote:
> Please consider this cleanup PR which makes the now package-protected
> `ModuleDescriptor` constructor private.
>
> This constructor is only accessed by the class itself via
> JavaLangModuleAccess. Making it private would express the in
On Thu, 28 Nov 2024 17:28:59 GMT, Aleksei Efimov wrote:
>> The proposed change cleans-up `SecurityManager`, `doPriviledged`, and
>> `AccessController` usages from `java.naming`, `jdk.naming.rmi` and
>> `jdk.naming.dns` modules.
>>
>> One noteworthy change: The `java.naming.rmi.security.manager
On Thu, 28 Nov 2024 17:26:04 GMT, Aleksei Efimov wrote:
>> The proposed change cleans-up `SecurityManager`, `doPriviledged`, and
>> `AccessController` usages from `java.naming`, `jdk.naming.rmi` and
>> `jdk.naming.dns` modules.
>>
>> One noteworthy change: The `java.naming.rmi.security.manager
> The proposed change cleans-up `SecurityManager`, `doPriviledged`, and
> `AccessController` usages from `java.naming`, `jdk.naming.rmi` and
> `jdk.naming.dns` modules.
>
> One noteworthy change: The `java.naming.rmi.security.manager` JNDI
> environment property can be used to setup the `Securi
On Thu, 28 Nov 2024 17:03:13 GMT, Alan Bateman wrote:
> Sean has hollowed out SecurityConstants in pull/22418 but had to leave
> GET_CLASSLOADER_PERMISSION because of this usage. There will be many rounds
> of cleanup so doesn't matter if it comes later. ALL_PERMISSION will probably
> be the l
On Tue, 26 Nov 2024 20:48:24 GMT, Eirik Bjørsnøs wrote:
> Please consider this cleanup PR which makes the now package-protected
> `ModuleDescriptor` constructor private.
>
> This constructor is only accessed by the class itself via
> JavaLangModuleAccess. Making it private would express the in
> After changing `BigInteger.sqrt()` algorithm, this can be also used to speed
> up `BigDecimal.sqrt()` implementation. Here is how I made it.
>
> The main steps of the algorithm are as follows:
> first argument reduce the value to an integer using the following relations:
>
> x = y * 10 ^ exp
>
On Thu, 28 Nov 2024 13:58:58 GMT, Aleksei Efimov wrote:
>> The proposed change cleans-up `SecurityManager`, `doPriviledged`, and
>> `AccessController` usages from `java.naming`, `jdk.naming.rmi` and
>> `jdk.naming.dns` modules.
>>
>> One noteworthy change: The `java.naming.rmi.security.manager
> After changing `BigInteger.sqrt()` algorithm, this can be also used to speed
> up `BigDecimal.sqrt()` implementation. Here is how I made it.
>
> The main steps of the algorithm are as follows:
> first argument reduce the value to an integer using the following relations:
>
> x = y * 10 ^ exp
>
On Thu, 28 Nov 2024 16:30:36 GMT, Alan Bateman wrote:
>> Aleksei Efimov has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Remove com.sun.jndi.ldap.VersionHelper
>
> src/java.naming/share/classes/com/sun/jndi/ldap/LdapDnsProviderService.jav
On Thu, 28 Nov 2024 13:58:58 GMT, Aleksei Efimov wrote:
>> The proposed change cleans-up `SecurityManager`, `doPriviledged`, and
>> `AccessController` usages from `java.naming`, `jdk.naming.rmi` and
>> `jdk.naming.dns` modules.
>>
>> One noteworthy change: The `java.naming.rmi.security.manager
On Thu, 28 Nov 2024 13:58:58 GMT, Aleksei Efimov wrote:
>> The proposed change cleans-up `SecurityManager`, `doPriviledged`, and
>> `AccessController` usages from `java.naming`, `jdk.naming.rmi` and
>> `jdk.naming.dns` modules.
>>
>> One noteworthy change: The `java.naming.rmi.security.manager
> In addition to the goals, scope, motivation, specification and requirement
> notes in [JDK-8315487](https://bugs.openjdk.org/browse/JDK-8315487), we would
> like to describe the most relevant decisions taken during the implementation
> of this enhancement. These notes are organized by feature,
On Thu, 28 Nov 2024 11:33:43 GMT, Jonathan Lampérth wrote:
> This PR includes a suggested change in behaviour of `javap -l` without `-v`
> or `-c`.
> Previously it was possible to print `LineNumberTable` and
> `LocalVariableTable` without disassembled code output. This didn't make much
> sense
On Thu, 28 Nov 2024 11:33:43 GMT, Jonathan Lampérth wrote:
> This PR includes a suggested change in behaviour of `javap -l` without `-v`
> or `-c`.
> Previously it was possible to print `LineNumberTable` and
> `LocalVariableTable` without disassembled code output. This didn't make much
> sense
On Thu, 28 Nov 2024 15:52:01 GMT, Alan Bateman wrote:
>> test/hotspot/jtreg/serviceability/dcmd/thread/VThreadCommandsTest.java line
>> 96:
>>
>>> 94: .shouldContain("Read I/O pollers:")
>>> 95: .shouldContain("Write I/O pollers:")
>>> 96: .should
On Thu, 28 Nov 2024 15:54:54 GMT, Alan Bateman wrote:
>> Adds `jcmd Thread.vthread_scheduler` to print the virtual thread
>> scheduler and `jcmd Thread.vthread_pollers` to print the I/O pollers
>> that support virtual threads doing blocking network I/O operations.
>>
>> This is a subset of t
On Thu, 28 Nov 2024 12:25:28 GMT, Doug Lea wrote:
>> This applies the same kinds of recovery on OOME (by spinning) and JVM
>> Exceptions (by cancelling) seen in AQS.
>
> Doug Lea has updated the pull request with a new target base due to a merge
> or a rebase. The incremental webrev excludes th
On Thu, 28 Nov 2024 14:21:50 GMT, Kevin Walls wrote:
>> Alan Bateman has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Improve regex for matching poller String representation
>
> test/hotspot/jtreg/serviceability/dcmd/thread/VThreadCommand
> Adds `jcmd Thread.vthread_scheduler` to print the virtual thread
> scheduler and `jcmd Thread.vthread_pollers` to print the I/O pollers
> that support virtual threads doing blocking network I/O operations.
>
> This is a subset of the diagnostics that we've had in the loom repo for a
> long
On Thu, 28 Nov 2024 12:25:28 GMT, Doug Lea wrote:
>> This applies the same kinds of recovery on OOME (by spinning) and JVM
>> Exceptions (by cancelling) seen in AQS.
>
> Doug Lea has updated the pull request with a new target base due to a merge
> or a rebase. The incremental webrev excludes th
On Sun, 22 Oct 2023 17:26:52 GMT, Laurent Bourgès wrote:
>> * improved mixed insertion sort (makes whole sorting faster)
>> * introduced Radix which sort shows several times boost of performance and
>> has linear complexity instead of n*ln(n)
>> * improved merging sort for almost sorted data
>>
> Allow `captureCallState` and `critical(true)` linker options to be combined.
> This allows passing a Java array to capture call state.
>
> One caveat is that the linker expects the memory to be aligned, which means
> that at least an `int[]` has to be used (i.e. `byte[]` will no work).
>
> Th
On Thu, 28 Nov 2024 15:09:43 GMT, Chen Liang wrote:
> Looks good. However, note that per our guide https://openjdk.org/guide, we
> usually integrate after about 24 hours to allow sufficient time for all
> reviewers. So I may sponsor later.
Oh my bad. Thanks for the heads-up!
-
PR
On Thu, 28 Nov 2024 11:33:43 GMT, Jonathan Lampérth wrote:
> This PR includes a suggested change in behaviour of `javap -l` without `-v`
> or `-c`.
> Previously it was possible to print `LineNumberTable` and
> `LocalVariableTable` without disassembled code output. This didn't make much
> sense
On Thu, 28 Nov 2024 11:33:43 GMT, Jonathan Lampérth wrote:
> This PR includes a suggested change in behaviour of `javap -l` without `-v`
> or `-c`.
> Previously it was possible to print `LineNumberTable` and
> `LocalVariableTable` without disassembled code output. This didn't make much
> sense
On Thu, 28 Nov 2024 11:33:43 GMT, Jonathan Lampérth wrote:
> This PR includes a suggested change in behaviour of `javap -l` without `-v`
> or `-c`.
> Previously it was possible to print `LineNumberTable` and
> `LocalVariableTable` without disassembled code output. This didn't make much
> sense
On Wed, 27 Nov 2024 15:59:17 GMT, Alan Bateman wrote:
> Adds `jcmd Thread.vthread_scheduler` to print the virtual thread
> scheduler and `jcmd Thread.vthread_pollers` to print the I/O pollers
> that support virtual threads doing blocking network I/O operations.
>
> This is a subset of the di
On Thu, 28 Nov 2024 12:19:25 GMT, Daniel Fuchs wrote:
> A few minor things were missed by JDK-8344235. Some unused variables can be
> removed, some @SuppressWranings are now redundant and some comments
> ,mentioning the access control context can be deleted.
This pull request has now been inte
On Thu, 28 Nov 2024 07:52:14 GMT, Alan Bateman wrote:
> Good cleanup. Maybe for a follow on PR but I assume VersionHelper can be
> removed. There's been several post JEP 486 removals that mean that
> createThread and loadClass shouldn't be needed now. Also isSerialDataAllowed
> could move to O
> The proposed change cleans-up `SecurityManager`, `doPriviledged`, and
> `AccessController` usages from `java.naming`, `jdk.naming.rmi` and
> `jdk.naming.dns` modules.
>
> One noteworthy change: The `java.naming.rmi.security.manager` JNDI
> environment property can be used to setup the `Securi
On Tue, 19 Nov 2024 13:37:25 GMT, Severin Gehwolf wrote:
>> Please review this fix for cgroups-based metrics reporting in the
>> `jdk.internal.platform` package. This fix is supposed to address wrong
>> reporting of certain limits if the limits aren't set at the leaf nodes.
>>
>> For example,
On Thu, 28 Nov 2024 12:06:13 GMT, Maurizio Cimadamore
wrote:
>> Allow `captureCallState` and `critical(true)` linker options to be combined.
>> This allows passing a Java array to capture call state.
>>
>> One caveat is that the linker expects the memory to be aligned, which means
>> that at
On Thu, 28 Nov 2024 12:19:25 GMT, Daniel Fuchs wrote:
> A few minor things were missed by JDK-8344235. Some unused variables can be
> removed, some @SuppressWranings are now redundant and some comments
> ,mentioning the access control context can be deleted.
Marked as reviewed by coffeys (Revi
On Thu, 28 Nov 2024 11:33:43 GMT, Jonathan Lampérth wrote:
> This PR includes a suggested change in behaviour of `javap -l` without `-v`
> or `-c`.
> Previously it was possible to print `LineNumberTable` and
> `LocalVariableTable` without disassembled code output. This didn't make much
> sense
On Wed, 27 Nov 2024 19:21:55 GMT, Maurizio Cimadamore
wrote:
>> src/java.base/share/classes/jdk/internal/foreign/abi/NativeEntryPoint.java
>> line 91:
>>
>>> 89: int checkIdx = 1;
>>> 90: if ((needsReturnBuffer && methodType.parameterType(checkIdx++)
>>> != long.class)
>>> 91:
On Thu, 28 Nov 2024 12:19:25 GMT, Daniel Fuchs wrote:
> A few minor things were missed by JDK-8344235. Some unused variables can be
> removed, some @SuppressWranings are now redundant and some comments
> ,mentioning the access control context can be deleted.
Looks fine.
-
Marked
> This applies the same kinds of recovery on OOME (by spinning) and JVM
> Exceptions (by cancelling) seen in AQS.
Doug Lea has updated the pull request with a new target base due to a merge or
a rebase. The incremental webrev excludes the unrelated changes brought in by
the merge/rebase. The pu
A few minor things were missed by JDK-8344235. Some unused variables can be
removed, some @SuppressWranings are now redundant and some comments ,mentioning
the access control context can be deleted.
-
Commit messages:
- 8345175: Further cleanup in java.logging and jdk.internal.logg
On Wed, 27 Nov 2024 16:27:34 GMT, Per Minborg wrote:
> This PR proposes to check for empty layouts in the fallback linker and then
> prevent them from being forwarded.
>
> Passes tier5 linker tests.
Marked as reviewed by jvernee (Reviewer).
test/jdk/java/foreign/TestLinker.java line 254:
> 2
On Fri, 22 Nov 2024 14:31:23 GMT, Jorn Vernee wrote:
> Allow `captureCallState` and `critical(true)` linker options to be combined.
> This allows passing a Java array to capture call state.
>
> One caveat is that the linker expects the memory to be aligned, which means
> that at least an `int[
On Fri, 22 Nov 2024 14:31:23 GMT, Jorn Vernee wrote:
> Allow `captureCallState` and `critical(true)` linker options to be combined.
> This allows passing a Java array to capture call state.
>
> One caveat is that the linker expects the memory to be aligned, which means
> that at least an `int[
> After changing `BigInteger.sqrt()` algorithm, this can be also used to speed
> up `BigDecimal.sqrt()` implementation. Here is how I made it.
>
> The main steps of the algorithm are as follows:
> first argument reduce the value to an integer using the following relations:
>
> x = y * 10 ^ exp
>
This PR includes a suggested change in behaviour of `javap -l` without `-v` or
`-c`.
Previously it was possible to print `LineNumberTable` and `LocalVariableTable`
without disassembled code output. This didn't make much sense, as there is no
context for this output. This PR proposes to output a
On Wed, 27 Nov 2024 15:59:17 GMT, Alan Bateman wrote:
> Adds `jcmd Thread.vthread_scheduler` to print the virtual thread
> scheduler and `jcmd Thread.vthread_pollers` to print the I/O pollers
> that support virtual threads doing blocking network I/O operations.
>
> This is a subset of the di
On Thu, 28 Nov 2024 00:04:53 GMT, Chen Liang wrote:
>> Adds `jcmd Thread.vthread_scheduler` to print the virtual thread
>> scheduler and `jcmd Thread.vthread_pollers` to print the I/O pollers
>> that support virtual threads doing blocking network I/O operations.
>>
>> This is a subset of the
On Tue, 26 Nov 2024 17:27:58 GMT, fabioromano1 wrote:
>> I don't get your point. Here's an example:
>>
>> BigDecimal.ONE.sqrt(new MathContext(2_000_000_000, RoundingMode.UP))
>> | Exception java.lang.ArithmeticException: Overflow
>> |at BigDecimal.sqrt (BigDecimal.java:2226)
>> |
Adds `jcmd Thread.vthread_scheduler` to print the virtual thread
scheduler and `jcmd Thread.vthread_pollers` to print the I/O pollers that
support virtual threads doing blocking network I/O operations.
This is a subset of the diagnostics that we've had in the loom repo for a long
time. @larry
On Wed, 20 Nov 2024 10:46:54 GMT, Sorna Sarathi wrote:
> This PR adds missing Classpath exception in several files.
>
> JBS Issue: [JDK-8334611](https://bugs.openjdk.org/browse/JDK-8344611)
This only adds information about the classpath exception copyright. So can't we
consider it trivial ? As
On Wed, 20 Nov 2024 10:46:54 GMT, Sorna Sarathi wrote:
> This PR adds missing Classpath exception in several files.
>
> JBS Issue: [JDK-8334611](https://bugs.openjdk.org/browse/JDK-8344611)
src/java.base/share/native/libjava/ub.h
src/jdk.jlink/share/classes/jdk/tools/jlink/internal/runtimelink/
On Sun, 6 Oct 2024 02:35:45 GMT, SendaoYan wrote:
> Hi all,
> The newly added test `java/foreign/TestUpcallStress.java` call
> `System.loadLibrary("TestUpcall")` load native library, so this test should
> mark as `/native`.
> The change has been verified locally, trivial fix, no risk.
This pul
On Sun, 6 Oct 2024 02:35:45 GMT, SendaoYan wrote:
> Hi all,
> The newly added test `java/foreign/TestUpcallStress.java` call
> `System.loadLibrary("TestUpcall")` load native library, so this test should
> mark as `/native`.
> The change has been verified locally, trivial fix, no risk.
Thanks a
On Wed, 27 Nov 2024 22:13:14 GMT, Maurizio Cimadamore
wrote:
> > While I don't disagree with the fix, there's several tests in this folder
> > that also depends on native libraries. Perhaps we should fix them all?
This PR only fixed this test since this test
`java/foreign/TestUpcallStress.jav
On Wed, 27 Nov 2024 15:29:48 GMT, Per Minborg wrote:
> This trivial PR proposes to use the parameter length for two tests as
> originally intended.
This pull request has now been integrated.
Changeset: 10333853
Author:Per Minborg
URL:
https://git.openjdk.org/jdk/commit/103338534f71
69 matches
Mail list logo
