Re: RFR: 8344908: URLClassPath should not propagate IllegalArgumentException when finding resources in classpath URLs [v3]

On Mon, 25 Nov 2024 13:55:30 GMT, Eirik Bjørsnøs wrote: >> Jaikiran Pai has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Alan's review - rename variable and drop final from test >> - Alan's review - no need for throws in method signatu

Re: RFR: 8342103: C2 compiler support for Float16 type and associated operations [v3]

On Mon, 25 Nov 2024 20:04:09 GMT, Jatin Bhateja wrote: >> Hi All, >> >> This patch adds C2 compiler support for various Float16 operations added by >> [PR#22128](https://github.com/openjdk/jdk/pull/22128) >> >> Following is the summary of changes included with this patch:- >> >> 1. Detection

Re: RFR: 8342103: C2 compiler support for Float16 type and associated operations [v2]

On Mon, 25 Nov 2024 19:55:27 GMT, Jatin Bhateja wrote: >> I heard no argument about why you did not split this up. Please do that in >> the future. It is hard to review well when there is this much code. If it is >> really necessary, then sure. Here it does not seem necessary to deliver all >>

Re: RFR: 8225763: Inflater and Deflater should implement AutoCloseable [v10]

On Tue, 26 Nov 2024 07:28:02 GMT, Jaikiran Pai wrote: >> Can I please get a review of this enhancement which proposes to enhance >> `java.util.zip.Deflater/Inflater` classes to now implement `AutoCloseable`? >> >> The actual work for this was done a few years back when we discussed the >> prop

Withdrawn: 8343703: Symbol name cleanups after JEP 479

On Tue, 26 Nov 2024 06:36:44 GMT, David Holmes wrote: > After JEP 479 ([JDK-8339783](https://bugs.openjdk.org/browse/JDK-8339783) was > integrated, the handling of certain symbol lookup code can be simplified. The > old code needed to support 32-bit Windows, where names had a trailing > `@`. W

Re: RFR: 8343703: Symbol name cleanups after JEP 479

On Tue, 26 Nov 2024 06:36:44 GMT, David Holmes wrote: > After JEP 479 ([JDK-8339783](https://bugs.openjdk.org/browse/JDK-8339783) was > integrated, the handling of certain symbol lookup code can be simplified. The > old code needed to support 32-bit Windows, where names had a trailing > `@`. W

Re: RFR: 8225763: Inflater and Deflater should implement AutoCloseable [v10]

> Can I please get a review of this enhancement which proposes to enhance > `java.util.zip.Deflater/Inflater` classes to now implement `AutoCloseable`? > > The actual work for this was done a few years back when we discussed the > proposed approaches and then I raised a RFR. At that time I could

Re: RFR: 8338445: jdk.internal.loader.URLClassPath may leak JarFile instance when dealing with unexpected Class-Path entry in manifest [v2]

On Tue, 27 Aug 2024 07:24:51 GMT, Alan Bateman wrote: > The tutorial for creating manifest files and adding Class-Path entry, I > think, is the more commonly visited one > https://docs.oracle.com/javase/tutorial/deployment/jar/downman.html (at least > that's the one I usually find in search re

Re: RFR: 8344882: (bf) Temporary direct buffers should not count against the upper limit on direct buffer memory [v4]

On Mon, 25 Nov 2024 19:55:46 GMT, Brian Burkhalter wrote: >> Make the memory used by internal temporary direct buffers not count towards >> the upper limit on direct buffer memory. > > Brian Burkhalter has updated the pull request incrementally with one > additional commit since the last revisi

Re: RFR: 8344908: URLClassPath should not propagate IllegalArgumentException when finding resources in classpath URLs [v4]

> Can I please get a review of this change that proposes to address the issue > noted in https://bugs.openjdk.org/browse/JDK-8344908? > > With this change, the URLClassPath will no longer propagate the > `IllegalArgumentException` thrown when constructing a resource loader. The > URL which caus

Re: RFR: 8337199: Add jcmd Thread.vthread_summary diagnostic command

On Tue, 26 Nov 2024 01:41:34 GMT, David Holmes wrote: >> c.f: >> [https://bugs.openjdk.org/browse/JDK-8339420](https://bugs.openjdk.org/browse/JDK-8339420) >> >> Summary >> --- >> >> Add `jcmd Thread.vthread_summary` to print summary information that is >> useful when trying to diagnose

RFR: 8343703: Symbol name cleanups after JEP 479

After JEP 479 ([JDK-8339783](https://bugs.openjdk.org/browse/JDK-8339783) was integrated, the handling of certain symbol lookup code can be simplified. The old code needed to support 32-bit Windows, where names had a trailing `@`. When this special case now is removed, some streamlining is poss

Re: RFR: 8337199: Add jcmd Thread.vthread_summary diagnostic command

On Tue, 26 Nov 2024 01:37:33 GMT, David Holmes wrote: >> c.f: >> [https://bugs.openjdk.org/browse/JDK-8339420](https://bugs.openjdk.org/browse/JDK-8339420) >> >> Summary >> --- >> >> Add `jcmd Thread.vthread_summary` to print summary information that is >> useful when trying to diagnose

Re: RFR: 8344611: Add missing classpath exception

On Wed, 20 Nov 2024 10:46:54 GMT, Sorna Sarathi wrote: > This PR adds missing Classpath exception in several files. > > JBS Issue: [JDK-8334611](https://bugs.openjdk.org/browse/JDK-8344611) ### Summary This PR fixes [JDK-8334611](https://bugs.openjdk.org/browse/JDK-8344611) and adds missing cl

Re: RFR: 8344954: Linker tests fails on BE platforms after JDK-8340205

On Mon, 25 Nov 2024 14:42:14 GMT, Per Minborg wrote: > This PR proposes to fix some tests that fails on big-endian platforms. fixes the issue for s390x as well. - Marked as reviewed by amitkumar (Committer). PR Review: https://git.openjdk.org/jdk/pull/22362#pullrequestreview-24602

Re: RFR: 8343427: Class file load hook crashes on archived classes from multi-release JARs [v6]

On Tue, 26 Nov 2024 03:38:25 GMT, Calvin Cheung wrote: >> Currently, when retrieving a ClassFileStream during runtime, we call into >> the zip library to retrieve the stream based only on a class name. This >> doesn't work well if the class is in a multi-release jar under a versioned >> direct

Re: RFR: 8343427: Class file load hook crashes on archived classes from multi-release JARs [v4]

On Tue, 26 Nov 2024 00:29:15 GMT, David Holmes wrote: >> I adapted the asserts from diagnosticCommand.cpp. I'm keeping the first >> assert. Is it ok? > > Both asserts are unnecessary. I've removed the assert. Will run some tests before integrating the fix. Please re-review when you have a chanc

Re: RFR: 8343427: Class file load hook crashes on archived classes from multi-release JARs [v6]

> Currently, when retrieving a ClassFileStream during runtime, we call into the > zip library to retrieve the stream based only on a class name. This doesn't > work well if the class is in a multi-release jar under a versioned directory > such as `META-INF/versions/9/Foo.class`. To address this

Re: Q: Why is java.lang.Runtime non-final?

Hello, On 11/22/2024 9:35 AM, Eirik Bjørsnøs wrote: On Fri, Nov 22, 2024 at 4:47 AM Joseph D. Darcy wrote: PS it would be a "small matter of programming" to write an annotation processor to find the not subclassable public classes in the JDK that were not marked final. Joe, your

Withdrawn: 8304674: File java.c compile error with -fsanitize=address -O0

On Mon, 25 Nov 2024 06:17:23 GMT, SendaoYan wrote: > Hi all, > File `src/java.base/share/native/libjli/java.c` compile `error: control > reaches end of non-void function [-Werror=return-type]` with gcc options > `-fsanitize=address -O0`. The function `int JavaMain(void* _args)` in this > file

Re: RFR: 8304674: File java.c compile error with -fsanitize=address -O0

On Tue, 26 Nov 2024 02:12:39 GMT, David Holmes wrote: > may trigger an unreachable statement warning in a smarter compiler. Agree. I will close this PR and the related issue as won't fix. - PR Comment: https://git.openjdk.org/jdk/pull/22355#issuecomment-2499500253

Re: RFR: 8304674: File java.c compile error with -fsanitize=address -O0

On Mon, 25 Nov 2024 06:17:23 GMT, SendaoYan wrote: > Hi all, > File `src/java.base/share/native/libjli/java.c` compile `error: control > reaches end of non-void function [-Werror=return-type]` with gcc options > `-fsanitize=address -O0`. The function `int JavaMain(void* _args)` in this > file

Re: RFR: 8337199: Add jcmd Thread.vthread_summary diagnostic command

On Tue, 26 Nov 2024 01:38:55 GMT, David Holmes wrote: >> c.f: >> [https://bugs.openjdk.org/browse/JDK-8339420](https://bugs.openjdk.org/browse/JDK-8339420) >> >> Summary >> --- >> >> Add `jcmd Thread.vthread_summary` to print summary information that is >> useful when trying to diagnose

Re: RFR: 8337199: Add jcmd Thread.vthread_summary diagnostic command

On Thu, 14 Nov 2024 21:34:08 GMT, Larry Cable wrote: > c.f: > [https://bugs.openjdk.org/browse/JDK-8339420](https://bugs.openjdk.org/browse/JDK-8339420) > > Summary > --- > > Add `jcmd Thread.vthread_summary` to print summary information that is > useful when trying to diagnose issues wi

Re: RFR: 8304674: File java.c compile error with -fsanitize=address -O0

On Mon, 25 Nov 2024 07:11:25 GMT, Jaikiran Pai wrote: > Do you mean that the `if (JNI_TRUE)` block which has the `return ret;` > wouldn't be used by the preprocessor when using `-O0`? I make a misunderstand for the do-while(false) loop prior. Actually the do-while(false) loop will execute at l

Re: RFR: 8304674: File java.c compile error with -fsanitize=address -O0

On Mon, 25 Nov 2024 07:08:56 GMT, David Holmes wrote: >> Hi all, >> File `src/java.base/share/native/libjli/java.c` compile `error: control >> reaches end of non-void function [-Werror=return-type]` with gcc options >> `-fsanitize=address -O0`. The function `int JavaMain(void* _args)` in this

Re: RFR: 8225763: Inflater and Deflater should implement AutoCloseable [v9]

On Fri, 22 Nov 2024 04:43:55 GMT, Jaikiran Pai wrote: >> Can I please get a review of this enhancement which proposes to enhance >> `java.util.zip.Deflater/Inflater` classes to now implement `AutoCloseable`? >> >> The actual work for this was done a few years back when we discussed the >> prop

Integrated: 8344337: SecurityManager cleanup in java.prefs module

On Tue, 19 Nov 2024 18:52:59 GMT, Brent Christian wrote: > Remove usages of SecurityManager, doPrivildged, and AccessController from the > java.prefs module. This pull request has now been integrated. Changeset: 4d4cef80 Author:Brent Christian URL: https://git.openjdk.org/jdk/commi

Re: RFR: 8343427: Class file load hook crashes on archived classes from multi-release JARs [v5]

On Mon, 25 Nov 2024 19:30:12 GMT, Calvin Cheung wrote: >> Currently, when retrieving a ClassFileStream during runtime, we call into >> the zip library to retrieve the stream based only on a class name. This >> doesn't work well if the class is in a multi-release jar under a versioned >> direct

Re: RFR: 8343427: Class file load hook crashes on archived classes from multi-release JARs [v4]

On Mon, 25 Nov 2024 19:26:40 GMT, Calvin Cheung wrote: >> src/hotspot/share/cds/filemap.cpp line 2718: >> >>> 2716: // The result should be a [B >>> 2717: assert(obj->is_typeArray(), "just checking"); >>> 2718: assert(TypeArrayKlass::cast(obj->klass())->element_type() == >>> T_BYTE, "just

Integrated: 8344275: tools/jpackage/windows/Win8301247Test.java fails on localized Windows platform

On Fri, 15 Nov 2024 09:43:15 GMT, Taizo Kurashige wrote: > To resolve tools/jpackage/windows/Win8301247Test.java failure, I made "wmic" > executed with "chcp 437". This ensures that the English message "No > Instance(s) Available." is output on localized windows platforms. > > I have referred

Re: RFR: 8344565: SM cleanup in jdk/internal and java/lang package private classes [v2]

> SM removal for internal implementation classes: > java.lang.CharacterName > java.lang.ref.Finalizer > jdk.internal.icu.impl.ICUBinary > jdk.internal.misc.ExtendedMapMode Roger Riggs has updated the pull request incrementally with one additional commit since the last revision:

Re: java.util.Properties: reproducible write

Hi Rafael, You might have missed the update added by JDK-8231640 Canonical property storage The comment string can be provided either by a separate method `store(Writer, String)` or by a system property. Regards, Roger On 11/25/24 4:53 PM, Rafael

java.util.Properties: reproducible write

Hello, I find the java.util.Properties class to be quite convenient when writing minor collections of key-values. One unfortunate implication of the store method is that it always contains a comment line with the current date. The comment is never deserialized when loading the file, but the file h

Re: RFR: 8344337: SecurityManager cleanup in java.prefs module [v6]

On Mon, 25 Nov 2024 21:02:35 GMT, Sean Mullan wrote: >> We want to `@SuppressWarnings("restricted")` the `loadLibrary()` call. IIUC, >> I can't `@SuppressWarnings` the static block, nor the call to >> `loadLibrary()`, so AFAICT that call needs to be in a separate, >> `@SuppressWarnings`-ed met

Re: RFR: 8344337: SecurityManager cleanup in java.prefs module [v6]

On Thu, 21 Nov 2024 20:41:36 GMT, Brent Christian wrote: >> Remove usages of SecurityManager, doPrivildged, and AccessController from >> the java.prefs module. > > Brent Christian has updated the pull request incrementally with one > additional commit since the last revision: > > spacing cha

Re: RFR: 8344337: SecurityManager cleanup in java.prefs module [v6]

On Mon, 25 Nov 2024 20:55:10 GMT, Brent Christian wrote: >> src/java.prefs/macosx/classes/java/util/prefs/MacOSXPreferencesFile.java >> line 87: >> >>> 85: @SuppressWarnings("restricted") >>> 86: private static void loadPrefsLib() { >>> 87: System.loadLibrary("prefs"); >> >> Wh

Re: RFR: 8344275: tools/jpackage/windows/Win8301247Test.java fails on localized Windows platform [v4]

On Wed, 20 Nov 2024 18:13:22 GMT, Alexey Semenyuk wrote: >> Taizo Kurashige has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Fix about size of cmdline > > Thank you for working on this patch! @alexeysemenyukoracle could you please spons

Re: RFR: 8344337: SecurityManager cleanup in java.prefs module [v6]

On Mon, 25 Nov 2024 19:11:02 GMT, Iris Clark wrote: >> Brent Christian has updated the pull request incrementally with one >> additional commit since the last revision: >> >> spacing changes > > src/java.prefs/macosx/classes/java/util/prefs/MacOSXPreferencesFile.java line > 87: > >> 85:

Re: RFR: 8035271: Incorrect indentation of LineNumberTable/LocalVariableTable/Exception table/LocalVariableTypeTable/StackMapTable/RuntimeVisibleTypeAnnotations in verbose mode

On Mon, 25 Nov 2024 12:57:18 GMT, Jonathan Lampérth wrote: > Very similar and related to: https://bugs.openjdk.org/browse/JDK-8034066 > > This PR includes changes to ensure the indentation of `LineNumberTable` and > `LocalVariableTable` behave in the same way both for the `javap -verbose` and

Re: RFR: 8344882: (bf) Temporary direct buffers should not count against the upper limit on direct buffer memory [v3]

On Mon, 25 Nov 2024 19:25:47 GMT, Alan Bateman wrote: >> Brian Burkhalter has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8344882: Remove DirectBuffer.temporary; rename JavaNioAccess temporary >> direct buffer allocation method > > src/

Re: RFR: 8342103: C2 compiler support for Float16 type and associated operations [v2]

On Mon, 25 Nov 2024 07:18:41 GMT, Emanuel Peter wrote: >> src/hotspot/share/opto/connode.cpp line 49: >> >>> 47: switch( t->basic_type() ) { >>> 48: case T_INT: return new ConINode( t->is_int() ); >>> 49: case T_SHORT: return new ConHNode( t->is_half_float_constant() >>> );

Re: RFR: 8342103: C2 compiler support for Float16 type and associated operations [v2]

On Mon, 25 Nov 2024 08:56:31 GMT, Emanuel Peter wrote: > I heard no argument about why you did not split this up. Please do that in > the future. It is hard to review well when there is this much code. If it is > really necessary, then sure. Here it does not seem necessary to deliver all > at

Re: RFR: 8342103: C2 compiler support for Float16 type and associated operations [v3]

> Hi All, > > This patch adds C2 compiler support for various Float16 operations added by > [PR#22128](https://github.com/openjdk/jdk/pull/22128) > > Following is the summary of changes included with this patch:- > > 1. Detection of various Float16 operations through inline expansion or > patt

Re: RFR: 8344882: (bf) Temporary direct buffers should not count against the upper limit on direct buffer memory [v4]

> Make the memory used by internal temporary direct buffers not count towards > the upper limit on direct buffer memory. Brian Burkhalter has updated the pull request incrementally with one additional commit since the last revision: 8344882: Remove vestigial import of Stable annotation -

Re: RFR: 8035271: Incorrect indentation of LineNumberTable/LocalVariableTable/Exception table/LocalVariableTypeTable/StackMapTable/RuntimeVisibleTypeAnnotations in verbose mode

On Mon, 25 Nov 2024 12:57:18 GMT, Jonathan Lampérth wrote: > Very similar and related to: https://bugs.openjdk.org/browse/JDK-8034066 > > This PR includes changes to ensure the indentation of `LineNumberTable` and > `LocalVariableTable` behave in the same way both for the `javap -verbose` and

Integrated: 8344898: SM cleanup of java.base sun/util calendar, locale, cldr, and resources

On Fri, 22 Nov 2024 23:05:11 GMT, Roger Riggs wrote: > Cleanup of doPrivileged in: > sun.util.calendar > sun.util.local/provider > sun.util.cldr > sun.util.resources This pull request has now been integrated. Changeset: df2d4c15 Author:Roger Riggs URL: https://git.op

Re: RFR: 8341402: BigDecimal's square root optimization [v23]

> After changing `BigInteger.sqrt()` algorithm, this can be also used to speed > up `BigDecimal.sqrt()` implementation. Here is how I made it. > > The main steps of the algorithm are as follows: > first argument reduce the value to an integer using the following relations: > > x = y * 10 ^ exp >

Re: RFR: 8343427: Class file load hook crashes on archived classes from multi-release JARs [v5]

> Currently, when retrieving a ClassFileStream during runtime, we call into the > zip library to retrieve the stream based only on a class name. This doesn't > work well if the class is in a multi-release jar under a versioned directory > such as `META-INF/versions/9/Foo.class`. To address this

Re: RFR: 8343427: Class file load hook crashes on archived classes from multi-release JARs [v4]

On Mon, 25 Nov 2024 04:11:20 GMT, David Holmes wrote: >> Calvin Cheung has updated the pull request incrementally with one additional >> commit since the last revision: >> >> update comments > > src/hotspot/share/cds/filemap.cpp line 2718: > >> 2716: // The result should be a [B >> 2717:

Re: RFR: 8344882: (bf) Temporary direct buffers should not count against the upper limit on direct buffer memory [v3]

On Mon, 25 Nov 2024 19:22:51 GMT, Brian Burkhalter wrote: >> Make the memory used by internal temporary direct buffers not count towards >> the upper limit on direct buffer memory. > > Brian Burkhalter has updated the pull request incrementally with one > additional commit since the last revisi

Re: RFR: 8344565: SM cleanup in jdk/internal and java/lang package private classes

On Mon, 25 Nov 2024 19:14:49 GMT, Roger Riggs wrote: > SM removal for internal implementation classes: > java.lang.CharacterName > java.lang.ref.Finalizer > jdk.internal.icu.impl.ICUBinary > jdk.internal.misc.ExtendedMapMode src/java.base/share/classes/java/lang/CharacterName.ja

Re: RFR: 8344565: SM cleanup in jdk/internal and java/lang package private classes

On Mon, 25 Nov 2024 19:14:49 GMT, Roger Riggs wrote: > SM removal for internal implementation classes: > java.lang.CharacterName > java.lang.ref.Finalizer > jdk.internal.icu.impl.ICUBinary > jdk.internal.misc.ExtendedMapMode src/java.base/share/classes/jdk/internal/misc/Extended

Re: RFR: 8344882: (bf) Temporary direct buffers should not count against the upper limit on direct buffer memory [v3]

> Make the memory used by internal temporary direct buffers not count towards > the upper limit on direct buffer memory. Brian Burkhalter has updated the pull request incrementally with one additional commit since the last revision: 8344882: Remove DirectBuffer.temporary; rename JavaNioAccess

Re: RFR: 8344882: (bf) Temporary direct buffers should not count against the upper limit on direct buffer memory [v2]

On Mon, 25 Nov 2024 19:10:17 GMT, Brian Burkhalter wrote: >> src/java.base/share/classes/java/nio/Direct-X-Buffer.java.template line 77: >> >>> 75: static final boolean UNALIGNED = Bits.unaligned(); >>> 76: >>> 77: private @Stable boolean temporary; // defaults to false >> >> Is this u

RFR: 8344565: SM cleanup in jdk/internal and java/lang package private classes

SM removal for internal implementation classes: java.lang.CharacterName java.lang.ref.Finalizer jdk.internal.icu.impl.ICUBinary jdk.internal.misc.ExtendedMapMode - Commit messages: - Refactored to remove additional doPrivileged calls - 8344565: SM cleanup in jdk/int

Re: RFR: 8344882: (bf) Temporary direct buffers should not count against the upper limit on direct buffer memory [v2]

On Mon, 25 Nov 2024 19:04:21 GMT, Alan Bateman wrote: >> Brian Burkhalter has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8344882: Do not create Cleaner for temporary buffers > > src/java.base/share/classes/java/nio/Direct-X-Buffer.java.

Re: RFR: 8344337: SecurityManager cleanup in java.prefs module [v6]

On Thu, 21 Nov 2024 20:41:36 GMT, Brent Christian wrote: >> Remove usages of SecurityManager, doPrivildged, and AccessController from >> the java.prefs module. > > Brent Christian has updated the pull request incrementally with one > additional commit since the last revision: > > spacing cha

Re: RFR: 8344882: (bf) Temporary direct buffers should not count against the upper limit on direct buffer memory [v2]

On Mon, 25 Nov 2024 18:51:48 GMT, Brian Burkhalter wrote: >> Make the memory used by internal temporary direct buffers not count towards >> the upper limit on direct buffer memory. > > Brian Burkhalter has updated the pull request incrementally with one > additional commit since the last revisi

Re: RFR: 8342380: Implement JEP 498: Warn upon Use of Memory-Access Methods in sun.misc.Unsafe [v3]

On Mon, 18 Nov 2024 09:42:20 GMT, Alan Bateman wrote: >> Change default value of the command line option >> --sun-misc-unsafe-memory-access from "allow" to "warn". > > Alan Bateman has updated the pull request with a new target base due to a > merge or a rebase. The pull request now contains si

Re: RFR: 8344895: SM cleanup of module java.xml [v2]

On Mon, 25 Nov 2024 16:46:56 GMT, Roger Riggs wrote: >> Updates to the java.xml module following the SecurityManager removal. >> Refactor to remove doPrivilege calls >> Refactor to eliminate dead code assuming getSecurityManager() == null >> Refactor to drop use of AccessControlContext >> Remove

Re: RFR: 8344882: (bf) Temporary direct buffers should not count against the upper limit on direct buffer memory [v2]

On Mon, 25 Nov 2024 18:51:48 GMT, Brian Burkhalter wrote: >> Make the memory used by internal temporary direct buffers not count towards >> the upper limit on direct buffer memory. > > Brian Burkhalter has updated the pull request incrementally with one > additional commit since the last revisi

Re: RFR: 8344911: Introduce test utility for asserting file open status

On Mon, 25 Nov 2024 17:38:55 GMT, Eirik Bjørsnøs wrote: > To the feature itself, it seems pretty complicated and invasive As for complexity, the feature consists of: * A Java agent `OpenFilesAgent`, containing 277 source code lines with: * A `main` method to package itself as a JAR for use wi

Re: RFR: 8344149: Remove usage of Security Manager from java.rmi [v2]

On Mon, 25 Nov 2024 10:16:34 GMT, Aleksei Efimov wrote: >> src/java.rmi/share/classes/sun/rmi/runtime/NewThreadAction.java line 30: >> >>> 28: import java.security.AccessController; >>> 29: import java.security.PrivilegedAction; >>> 30: import sun.security.util.SecurityConstants; >> >> Are ther

Re: RFR: 8344337: SecurityManager cleanup in java.prefs module [v6]

On Thu, 21 Nov 2024 20:41:36 GMT, Brent Christian wrote: >> Remove usages of SecurityManager, doPrivildged, and AccessController from >> the java.prefs module. > > Brent Christian has updated the pull request incrementally with one > additional commit since the last revision: > > spacing cha

Re: RFR: 8344882: (bf) Temporary direct buffers should not count against the upper limit on direct buffer memory [v2]

> Make the memory used by internal temporary direct buffers not count towards > the upper limit on direct buffer memory. Brian Burkhalter has updated the pull request incrementally with one additional commit since the last revision: 8344882: Do not create Cleaner for temporary buffers --

Re: RFR: 8344337: SecurityManager cleanup in java.prefs module [v6]

On Thu, 21 Nov 2024 20:41:36 GMT, Brent Christian wrote: >> Remove usages of SecurityManager, doPrivildged, and AccessController from >> the java.prefs module. > > Brent Christian has updated the pull request incrementally with one > additional commit since the last revision: > > spacing cha

Re: RFR: 8344895: SM cleanup of module java.xml [v2]

On Mon, 25 Nov 2024 16:46:56 GMT, Roger Riggs wrote: >> Updates to the java.xml module following the SecurityManager removal. >> Refactor to remove doPrivilege calls >> Refactor to eliminate dead code assuming getSecurityManager() == null >> Refactor to drop use of AccessControlContext >> Remove

Re: RFR: 8344337: SecurityManager cleanup in java.prefs module [v6]

On Thu, 21 Nov 2024 20:41:36 GMT, Brent Christian wrote: >> Remove usages of SecurityManager, doPrivildged, and AccessController from >> the java.prefs module. > > Brent Christian has updated the pull request incrementally with one > additional commit since the last revision: > > spacing cha

Re: RFR: 8337199: Add jcmd Thread.vthread_summary diagnostic command

On Thu, 14 Nov 2024 21:34:08 GMT, Larry Cable wrote: > c.f: > [https://bugs.openjdk.org/browse/JDK-8339420](https://bugs.openjdk.org/browse/JDK-8339420) > > Summary > --- > > Add `jcmd Thread.vthread_summary` to print summary information that is > useful when trying to diagnose issues wi

Re: RFR: 8344911: Introduce test utility for asserting file open status

On Mon, 25 Nov 2024 17:00:17 GMT, Roger Riggs wrote: > To the motivation, please list the tests that would be modified to use this > test feature. Thanks Roges! Yes, I realize this came a bit out of the blue. The test I have been looking at so far include: `test/jdk/java/net/URLClassLoader/R

Re: RFR: 8344882: (bf) Temporary direct buffers should not count against the upper limit on direct buffer memory

On Mon, 25 Nov 2024 17:21:31 GMT, Brian Burkhalter wrote: > At present the explicit deallocation uses the cleaner: Right but if we change this then you should find the "temporary" field goes away as it will be different deallocator. - PR Comment: https://git.openjdk.org/jdk/pull/2

Re: RFR: 8342979: Start of release updates for JDK 25 [v7]

On Mon, 25 Nov 2024 11:40:16 GMT, Pavel Rappo wrote: >> Prepare for JDK 25. > > Pavel Rappo has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull request contains 11 addi

Re: RFR: 4452735: Add GZIPOutputStream constructor to specify Deflater

On Wed, 17 Jul 2024 21:07:23 GMT, Archie Cobbs wrote: > The class `GZIPOutputStream` extends `DeflaterOutputStream`, which is logical > because the GZIP encoding is based on ZLIB "deflate" encoding. > > However, while `DeflaterOutputStream` provides constructors that take a > custom `Deflater`

Re: RFR: 4452735: Add GZIPOutputStream constructor to specify Deflater [v2]

> The class `GZIPOutputStream` extends `DeflaterOutputStream`, which is logical > because the GZIP encoding is based on ZLIB "deflate" encoding. > > However, while `DeflaterOutputStream` provides constructors that take a > custom `Deflater` argument supplied by the caller, `GZIPOutputStream` has

Re: RFR: 8344882: (bf) Temporary direct buffers should not count against the upper limit on direct buffer memory

On Sat, 23 Nov 2024 18:31:11 GMT, Alan Bateman wrote: > While you are there, can you also look into not creating a Cleaner for the > temporary direct buffers? They are explicitly deallocated when they can't be > returned to the TL cache or when the thread terminates (there is a hook in > threa

Re: RFR: 8344911: Introduce test utility for asserting file open status [v2]

> Please review this PR which adds a utility API in the test libraries to > assert whether a file is currently open. > > Several OpenJDK tests currently rely on approximations to check this, > including deletion (fails only on Windows), or checking `/proc//fd` > (Works only on Linux). These a

Re: RFR: 8344882: (bf) Temporary direct buffers should not count against the upper limit on direct buffer memory

On Mon, 25 Nov 2024 07:33:10 GMT, Per Minborg wrote: > Could we add some tests also? Do you have any suggestions? That the buffers do not affect the memory limit is implicitly tested by the tests associated with the issues linked in Jira. - PR Comment: https://git.openjdk.org/jdk/

Re: RFR: 4452735: Add GZIPOutputStream constructor to specify Deflater

On Wed, 17 Jul 2024 21:07:23 GMT, Archie Cobbs wrote: > The class `GZIPOutputStream` extends `DeflaterOutputStream`, which is logical > because the GZIP encoding is based on ZLIB "deflate" encoding. > > However, while `DeflaterOutputStream` provides constructors that take a > custom `Deflater`

Re: RFR: 8343004: Adjust JAXP limits

On Fri, 22 Nov 2024 23:17:17 GMT, Joe Wang wrote: > Adjust JAXP Limits. Limits are adjusted as specified in the CSR. > > Tests: > Updated the config test with the new settings. > > Removed obsolete tests Bug6309988.java and > Bug4674384_MAX_OCCURS_Test.java, and files used by these

Re: RFR: 8344235: Revisit SecurityManager usage in java.logging after JEP 486 and JEP 491 integration [v2]

On Mon, 25 Nov 2024 16:22:16 GMT, Sean Mullan wrote: >> Daniel Fuchs has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Review feedback > > src/java.base/share/classes/jdk/internal/logger/LazyLoggers.java line 346: > >> 344: //

Re: RFR: 8344911: Introduce test utility for asserting file open status

On Sat, 23 Nov 2024 15:47:53 GMT, Eirik Bjørsnøs wrote: > Please review this PR which adds a utility API in the test libraries to > assert whether a file is currently open. > > Several OpenJDK tests currently rely on approximations to check this, > including deletion (fails only on Windows),

Re: RFR: 8344773: SM cleanup in ForkJoinPool [v3]

> Complete the SM cleanup in java.util.concurrent that was deferred during > other FJP updates Doug Lea has updated the pull request incrementally with one additional commit since the last revision: Reinstate INITIAL_QUEUE_CAPACITY; clarify FJWT javadoc - Changes: - all: https

Re: RFR: 8344911: Introduce test utility for asserting file open status

On Sat, 23 Nov 2024 15:47:53 GMT, Eirik Bjørsnøs wrote: > Please review this PR which adds a utility API in the test libraries to > assert whether a file is currently open. > > Several OpenJDK tests currently rely on approximations to check this, > including deletion (fails only on Windows),

Re: RFR: 8337199: Add jcmd Thread.vthread_summary diagnostic command

On Thu, 14 Nov 2024 21:34:08 GMT, Larry Cable wrote: > c.f: > [https://bugs.openjdk.org/browse/JDK-8339420](https://bugs.openjdk.org/browse/JDK-8339420) > > Summary > --- > > Add `jcmd Thread.vthread_summary` to print summary information that is > useful when trying to diagnose issues wi

Re: RFR: 8344954: Linker tests fails on BE platforms after JDK-8340205

On Mon, 25 Nov 2024 14:42:14 GMT, Per Minborg wrote: > This PR proposes to fix some tests that fails on big-endian platforms. This fixes the test failures on AIX. - Marked as reviewed by mdoerr (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/22362#pullrequestreview-2458985

Integrated: 8344319: SM cleanup in jdk.dynalink module

On Fri, 15 Nov 2024 16:38:53 GMT, Roger Riggs wrote: > Refactor to remove use of SecurityManager This pull request has now been integrated. Changeset: 593a5898 Author:Roger Riggs URL: https://git.openjdk.org/jdk/commit/593a5898f93fd009197e89aba311268bc1a2e74e Stats: 233 lines in

Re: RFR: 8344895: SM cleanup of module java.xml [v2]

> Updates to the java.xml module following the SecurityManager removal. > Refactor to remove doPrivilege calls > Refactor to eliminate dead code assuming getSecurityManager() == null > Refactor to drop use of AccessControlContext > Remove (most) references to SecurityException > Remove error messa

Re: RFR: 8344235: Revisit SecurityManager usage in java.logging after JEP 486 and JEP 491 integration [v2]

On Thu, 21 Nov 2024 10:24:28 GMT, Daniel Fuchs wrote: >> This PR remove usage of SecurityManager, doPrivileges, etc... from >> `java.logging` and `java.base/jdk.internal.logger` >> >> Only notable hack - Logger.checkPermission() no longer checks permissions, >> but has been renamed into `ensur

RFR: 8344911: Introduce test utility for asserting file open status

Please review this PR which adds a utility API in the test libraries to assert whether a file is currently open. Several OpenJDK tests currently rely on approximations to check this, including deletion (fails only on Windows), or checking `/proc//fd` (Works only on Linux). These approximation

RFR: 8337199: Add jcmd Thread.vthread_summary diagnostic command

c.f: [https://bugs.openjdk.org/browse/JDK-8339420](https://bugs.openjdk.org/browse/JDK-8339420) Summary --- Add `jcmd Thread.vthread_summary` to print summary information that is useful when trying to diagnose issues with virtual threads. Problem --- The JDK is lacking tooling to di

Re: RFR: 8344908: URLClassPath should not propagate IllegalArgumentException when finding resources in classpath URLs [v3]

On Mon, 25 Nov 2024 08:24:07 GMT, Jaikiran Pai wrote: >> Can I please get a review of this change that proposes to address the issue >> noted in https://bugs.openjdk.org/browse/JDK-8344908? >> >> With this change, the URLClassPath will no longer propagate the >> `IllegalArgumentException` thro

Re: RFR: 8035271: Incorrect indentation of LineNumberTable/LocalVariableTable/Exception table/LocalVariableTypeTable/StackMapTable/RuntimeVisibleTypeAnnotations in verbose mode

On Mon, 25 Nov 2024 15:54:40 GMT, Jorn Vernee wrote: > > Add code header for only -l case? I also like this option, because it maintains the "nesting" of attributes - e.g. the main thing here is that LNT and LVT are attributes of Code, so they should be nested in there. One option could be to

Re: RFR: 8344773: SM cleanup in ForkJoinPool [v2]

On Mon, 25 Nov 2024 10:23:36 GMT, Viktor Klang wrote: >> Doug Lea has updated the pull request with a new target base due to a merge >> or a rebase. The incremental webrev excludes the unrelated changes brought >> in by the merge/rebase. The pull request contains four additional commits >> sin

Re: RFR: 8344419: Use StaticProperty in some JDK classes

On Mon, 18 Nov 2024 17:52:04 GMT, Per Minborg wrote: > This PR proposes to use `StaticProperty.javaHome()` instead of > `System.getPropoerty("java.home")` in some internal classes. Marked as reviewed by rriggs (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/22214#pullreq

Re: RFR: 8319993: Update Unicode Data Files to 16.0.0 [v2]

On Thu, 21 Nov 2024 20:42:57 GMT, Naoto Sato wrote: >> Updates the JDK to use the latest Unicode 16.0.0, which also updates the >> ICU4J along with it (8319992: Update ICU4J to Version 76.1). The >> corresponding CSR has already been approved. > > Naoto Sato has updated the pull request increme

Integrated: 8319993: Update Unicode Data Files to 16.0.0

On Tue, 29 Oct 2024 18:01:55 GMT, Naoto Sato wrote: > Updates the JDK to use the latest Unicode 16.0.0, which also updates the > ICU4J along with it (8319992: Update ICU4J to Version 76.1). The > corresponding CSR has already been approved. This pull request has now been integrated. Changeset

Re: RFR: 8035271: Incorrect indentation of LineNumberTable/LocalVariableTable/Exception table/LocalVariableTypeTable/StackMapTable/RuntimeVisibleTypeAnnotations in verbose mode

On Mon, 25 Nov 2024 12:57:18 GMT, Jonathan Lampérth wrote: > Add code header for only -l case? I think that is the right move. `LineNumberTable`, and others listed here: [Add code header for only -l case?](https://docs.oracle.com/javase/specs/jvms/se23/html/jvms-4.html#jvms-4.7-320) are/can b

Re: RFR: 8344895: SM cleanup of module java.xml

On Mon, 25 Nov 2024 07:45:01 GMT, Alan Bateman wrote: >> Updates to the java.xml module following the SecurityManager removal. >> Refactor to remove doPrivilege calls >> Refactor to eliminate dead code assuming getSecurityManager() == null >> Refactor to drop use of AccessControlContext >> Remov

Re: RFR: 8344898: SM cleanup of java.base sun/util calendar, locale, cldr, and resources [v2]

On Sat, 23 Nov 2024 03:09:02 GMT, Roger Riggs wrote: >> Cleanup of doPrivileged in: >> sun.util.calendar >> sun.util.local/provider >> sun.util.cldr >> sun.util.resources > > Roger Riggs has updated the pull request incrementally with one additional > commit since the last revisi

  1   2   >