Re: RFR: 8344912: Sharpen the return type of various internal methods in jdk.internal.foreign [v3]

2024-11-23 Thread Quan Anh Mai
> Hi, > > This patch sharpens the return types of various internal methods. This helps > the compiler to have better information when the corresponding methods are > not inlined. > > Please take a look and leave your reviews, thanks a lot. Quan Anh Mai has updated the pull request incrementall

Re: RFR: 8344882: (bf) Temporary direct buffers should not count against the upper limit on direct buffer memory

2024-11-23 Thread Alan Bateman
On Fri, 22 Nov 2024 23:44:11 GMT, Brian Burkhalter wrote: > Make the memory used by internal temporary direct buffers not count towards > the upper limit on direct buffer memory. While you are there, can you also look into not creating a Cleaner for the temporary direct buffers? They are expli

Re: RFR: 8344912: Sharpen the return type of various internal methods in jdk.internal.foreign [v2]

2024-11-23 Thread Quan Anh Mai
On Sat, 23 Nov 2024 17:27:43 GMT, Chen Liang wrote: >> Quan Anh Mai has refreshed the contents of this pull request, and previous >> commits have been removed. The incremental views will show differences >> compared to the previous content of the PR. The pull request contains one >> new commit

Re: RFR: 8344912: Sharpen the return type of various internal methods in jdk.internal.foreign [v2]

2024-11-23 Thread Quan Anh Mai
> Hi, > > This patch sharpens the return types of various internal methods. This helps > the compiler to have better information when the corresponding methods are > not inlined. > > Please take a look and leave your reviews, thanks a lot. Quan Anh Mai has refreshed the contents of this pull r

Re: RFR: 8344912: Sharpen the return type of various internal methods in jdk.internal.foreign

2024-11-23 Thread Chen Liang
On Sat, 23 Nov 2024 16:29:10 GMT, Quan Anh Mai wrote: > Hi, > > This patch sharpens the return types of various internal methods. This helps > the compiler to have better information when the corresponding methods are > not inlined. > > Please take a look and leave your reviews, thanks a lot.

RFR: 8344912: Sharpen the return type of various internal methods in jdk.internal.foreign

2024-11-23 Thread Quan Anh Mai
Hi, This patch sharpens the return types of various internal methods. This helps the compiler to have better information when the corresponding methods are not inlined. Please take a look and leave your reviews, thanks a lot. - Commit messages: - sharpen the return types of vario

Re: java fails under a path with 4-byte UTF-8 character & JDK-8258246

2024-11-23 Thread Jaikiran Pai
Hello Fabian, There are two issues here. The first is - if "java" is launched with a classpath containing a path which has emoji character in it then that leads to an exception causing the launch to fail. For example, if you have a "Foo.class" in /tmp/ascii-dir and you currently are in "" an

Re: RFR: 8341566: Add Reader.of(CharSequence) [v15]

2024-11-23 Thread Markus KARG
On Wed, 23 Oct 2024 08:58:30 GMT, Markus KARG wrote: >> This Pull Requests proposes an implementation for >> [JDK-8341566](https://bugs.openjdk.org/browse/JDK-8341566): Adding the new >> method `public static Reader Reader.of(CharSequence)` will return an >> anonymous, non-synchronized impleme

Re: RFR: 8344882: (bf) Temporary direct buffers should not count against the upper limit on direct buffer memory

2024-11-23 Thread Chen Liang
On Sat, 23 Nov 2024 01:09:30 GMT, Brian Burkhalter wrote: >> src/java.base/share/classes/java/nio/Direct-X-Buffer.java.template line 77: >> >>> 75: static final boolean UNALIGNED = Bits.unaligned(); >>> 76: >>> 77: private @Stable boolean temporary; // defaults to false >> >> Any reaso

Re: RFR: 8309130: x86_64 AVX512 intrinsics for Arrays.sort methods (int, long, float and double arrays) [v42]

2024-11-23 Thread Piotr Tarsa
On Thu, 5 Oct 2023 23:36:48 GMT, Srinivas Vamsi Parasa wrote: >> The goal is to develop faster sort routines for x86_64 CPUs by taking >> advantage of AVX512 instructions. This enhancement provides an order of >> magnitude speedup for Arrays.sort() using int, long, float and double arrays. >>

Re: RFR: 8317763: Follow-up to AVX512 intrinsics for Arrays.sort() PR [v5]

2024-11-23 Thread Piotr Tarsa
On Wed, 11 Oct 2023 20:58:23 GMT, Srinivas Vamsi Parasa wrote: >> The goal of this PR is to address the follow-up comments to the SIMD >> accelerated sort PR (#14227) which implemented AVX512 intrinsics for >> Arrays.sort() methods. >> The proposed changes are: >> >> 1) Restriction of the AVX

Re: RFR: 8344773: SM cleanup in ForkJoinPool

2024-11-23 Thread Alan Bateman
On Fri, 22 Nov 2024 14:13:19 GMT, Doug Lea wrote: > Complete the SM cleanup in java.util.concurrent that was deferred during > other FJP updates src/java.base/share/classes/java/util/concurrent/ForkJoinWorkerThread.java line 83: > 81: if (handler != null) > 82: super.setUn

Re: RFR: 8343191: Cgroup v1 subsystem fails to set subsystem path [v3]

2024-11-23 Thread Sergey Chernyshev
On Sat, 23 Nov 2024 00:06:26 GMT, Sergey Chernyshev wrote: > It looks like there's no way to see at this point, if we are in cgroup v1 or > v2 - if I am not mistaken. On the other hand, a type parameter can be added to `CgroupUtil::adjust_controller()`. Would you recommend doing so?

Re: RFR: 8341184: Clean up the interaction between the launcher native code and the LauncherHelper [v9]

2024-11-23 Thread Jaikiran Pai
> Can I please get a review of this change, which simplifies the interaction > between the `java` launcher's native code with the > `sun.launcher.LauncherHelper`? > > As noted in https://bugs.openjdk.org/browse/JDK-8341184, this proposed change > reduces the back and forth between the launcher

Re: RFR: 8310996: Add JFR event for connect operations [v5]

2024-11-23 Thread Alan Bateman
On Fri, 22 Nov 2024 20:32:50 GMT, Tim Prinzing wrote: >> Adds a JFR event for socket connect operations. >> >> Existing tests TestSocketEvents and TestSocketChannelEvents modified to also >> check for connect events. > > Tim Prinzing has updated the pull request incrementally with one additiona

Re: RFR: 8344865: SM cleanup in sun/reflect/annotation [v2]

2024-11-23 Thread Jaikiran Pai
On Fri, 22 Nov 2024 18:55:42 GMT, Roger Riggs wrote: >> Refactored doPrivileged and removed imports in sun.reflect.annotation >> classes: >> AnnotationInvocationHandler, AnnotationParser, AnnotationSupport, and >> AnnotationType. > > Roger Riggs has updated the pull request incrementally with o