> Cleanup of doPrivileged in:
> sun.util.calendar
> sun.util.local/provider
> sun.util.cldr
> sun.util.resources
Roger Riggs has updated the pull request incrementally with one additional
commit since the last revision:
Cleanups recommended by reviewer
-
Changes:
On Fri, 2 Aug 2024 08:21:42 GMT, SendaoYan wrote:
> Hi all,
> The test `com/sun/jndi/dns/ConfigTests/Timeout.java` fails with `-Xcomp
> -XX:TieredStopAtLevel=1` jvm options by fastdebug binary. In C1 mode and with
> debug binary, the JIT comple time longger than -Xmixed and release binary is
On Fri, 22 Nov 2024 06:59:45 GMT, Aleksey Shipilev wrote:
>> Would this be considered a benchmark of the GC's PhantomReference
>> management, then - deciding that all the `PhantomCleanerRef`s are still
>> reachable, perhaps?
>>
>> To measure `CleanableList`'s list manipulation at GC-time, a `T
On Sat, 23 Nov 2024 01:03:25 GMT, ExE Boss wrote:
>> Make the memory used by internal temporary direct buffers not count towards
>> the upper limit on direct buffer memory.
>
> src/java.base/share/classes/java/nio/Direct-X-Buffer.java.template line 77:
>
>> 75: static final boolean UNALIGNE
On Fri, 22 Nov 2024 23:44:11 GMT, Brian Burkhalter wrote:
> Make the memory used by internal temporary direct buffers not count towards
> the upper limit on direct buffer memory.
src/java.base/share/classes/java/nio/Direct-X-Buffer.java.template line 77:
> 75: static final boolean UNALIGNE
On Fri, 22 Nov 2024 16:48:04 GMT, Severin Gehwolf wrote:
> The added code in `CgroupUtil::adjust_controller` runs for cg v1 and cg v2
> when path adjustment is deemed needed. So I'm not clear why it's needed for
> cg v2
It looks like there's no way to see at this point, if we are in cgroup v1
On Fri, 22 Nov 2024 23:05:11 GMT, Roger Riggs wrote:
> Cleanup of doPrivileged in:
> sun.util.calendar
> sun.util.local/provider
> sun.util.cldr
> sun.util.resources
Thanks for the fix in this area. Looks good with a couple of minor nit
src/java.base/share/classes/sun/util/resou
On Fri, 22 Nov 2024 23:44:11 GMT, Brian Burkhalter wrote:
> Make the memory used by internal temporary direct buffers not count towards
> the upper limit on direct buffer memory.
This change should also fix
[JDK-8340728](https://bugs.openjdk.org/browse/JDK-8340728) and
[JDK-8342849](https://b
Make the memory used by internal temporary direct buffers not count towards the
upper limit on direct buffer memory.
-
Commit messages:
- 8344882: (bf) Temporary direct buffers should not count against the upper
limit on direct buffer memory
Changes: https://git.openjdk.org/jdk/pu
On Tue, 19 Nov 2024 22:31:28 GMT, Alexey Semenyuk wrote:
> Stop using internal AppImageFile, ApplicationLayout, and PackageFile classes
> in the tests. Replace them with stubs.
>
> Stop referencing IOUtils class from XmlUtils and PathUtils classes.
This pull request has now been integrated.
C
Adjust JAXP Limits. Limits are adjusted as specified in the CSR.
Tests:
Updated the config test with the new settings.
Removed obsolete tests Bug6309988.java and
Bug4674384_MAX_OCCURS_Test.java, and files used by these tests. These tests
verified legacy properties. They came into the
Cleanup of doPrivileged in:
sun.util.calendar
sun.util.local/provider
sun.util.cldr
sun.util.resources
-
Commit messages:
- 8344898: SM cleanup of java.base sun/util calendar, locale, clde, and
resources
Changes: https://git.openjdk.org/jdk/pull/22336/files
Webrev
On Thu, 21 Nov 2024 20:42:57 GMT, Naoto Sato wrote:
>> Updates the JDK to use the latest Unicode 16.0.0, which also updates the
>> ICU4J along with it (8319992: Update ICU4J to Version 76.1). The
>> corresponding CSR has already been approved.
>
> Naoto Sato has updated the pull request increme
> Adds a JFR event for socket connect operations.
>
> Existing tests TestSocketEvents and TestSocketChannelEvents modified to also
> check for connect events.
Tim Prinzing has updated the pull request incrementally with one additional
commit since the last revision:
Added more tests for sock
On Thu, 21 Nov 2024 20:42:57 GMT, Naoto Sato wrote:
>> Updates the JDK to use the latest Unicode 16.0.0, which also updates the
>> ICU4J along with it (8319992: Update ICU4J to Version 76.1). The
>> corresponding CSR has already been approved.
>
> Naoto Sato has updated the pull request increme
On Fri, 22 Nov 2024 18:55:42 GMT, Roger Riggs wrote:
>> Refactored doPrivileged and removed imports in sun.reflect.annotation
>> classes:
>> AnnotationInvocationHandler, AnnotationParser, AnnotationSupport, and
>> AnnotationType.
>
> Roger Riggs has updated the pull request incrementally with o
> Refactored doPrivileged and removed imports in sun.reflect.annotation classes:
> AnnotationInvocationHandler, AnnotationParser, AnnotationSupport, and
> AnnotationType.
Roger Riggs has updated the pull request incrementally with one additional
commit since the last revision:
Update copyrigh
On Fri, 22 Nov 2024 17:35:27 GMT, Roger Riggs wrote:
> Refactored doPrivileged and removed imports in sun.reflect.annotation classes:
> AnnotationInvocationHandler, AnnotationParser, AnnotationSupport, and
> AnnotationType.
Marked as reviewed by liach (Reviewer).
src/java.base/share/classes/su
On Fri, 22 Nov 2024 18:02:51 GMT, Roger Riggs wrote:
> java.base has a few exports to java.rmi that are no longer needed.
> sun.security.util, sun.security.provider, and sun.reflect.misc.
This pull request has been closed without being integrated.
-
PR: https://git.openjdk.org/jdk/
On Fri, 22 Nov 2024 18:02:51 GMT, Roger Riggs wrote:
> java.base has a few exports to java.rmi that are no longer needed.
> sun.security.util, sun.security.provider, and sun.reflect.misc.
To be handled with other SM updates in java.rmi.
-
PR Comment: https://git.openjdk.org/jdk/pul
I just observed that the java launcher fails to run (any) Java program
on macOS if executed from a working directory that contains a
character with a 4-byte UTF-8 encoding (say an emoji).
While it does seem related to JDK-8258246, which was considered to be
caused by more general issues with legac
On Wed, 20 Nov 2024 03:02:39 GMT, Justin Lu wrote:
> Please review this PR which removes the leftover ocurrences of incorrect JNI
> `ExceptionOccurred(env)` usage within _java.base_.
>
> This PR also includes 9 cases of `if (ExceptionOccurred(env) == NULL)`. While
> these occurrences are fine
On Wed, 20 Nov 2024 03:02:39 GMT, Justin Lu wrote:
> Please review this PR which removes the leftover ocurrences of incorrect JNI
> `ExceptionOccurred(env)` usage within _java.base_.
>
> This PR also includes 9 cases of `if (ExceptionOccurred(env) == NULL)`. While
> these occurrences are fine
On Fri, 22 Nov 2024 18:02:51 GMT, Roger Riggs wrote:
> java.base has a few exports to java.rmi that are no longer needed.
> sun.security.util, sun.security.provider, and sun.reflect.misc.
Good cleanup, assuming everything builds + tests.
-
Marked as reviewed by alanb (Reviewer).
P
java.base has a few exports to java.rmi that are no longer needed.
sun.security.util, sun.security.provider, and sun.reflect.misc.
-
Commit messages:
- 8344867: Cleanup unneded qualified exports to java.rmi
Changes: https://git.openjdk.org/jdk/pull/22329/files
Webrev: https://webr
On Mon, 18 Nov 2024 17:06:03 GMT, Nizar Benalla wrote:
> Can I get a review for this test only change to the Since Checker?
>
> I drop the distinction between classes and interfaces when generating ids and
> use a generic name "class" to describe both, as to not consider classes that
> get con
On Mon, 18 Nov 2024 17:06:03 GMT, Nizar Benalla wrote:
> Can I get a review for this test only change to the Since Checker?
>
> I drop the distinction between classes and interfaces when generating ids and
> use a generic name "class" to describe both, as to not consider classes that
> get con
On Thu, 21 Nov 2024 20:42:57 GMT, Naoto Sato wrote:
>> Updates the JDK to use the latest Unicode 16.0.0, which also updates the
>> ICU4J along with it (8319992: Update ICU4J to Version 76.1). The
>> corresponding CSR has already been approved.
>
> Naoto Sato has updated the pull request increme
On Fri, 22 Nov 2024 16:12:18 GMT, Viktor Klang wrote:
>> Aleksey Shipilev has updated the pull request with a new target base due to
>> a merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 17 additional
>> commi
Refactored doPrivileged and removed imports in sun.reflect.annotation classes:
AnnotationInvocationHandler, AnnotationParser, AnnotationSupport, and
AnnotationType.
-
Commit messages:
- 8344865: SM cleanup in sun/reflect/annotation
Changes: https://git.openjdk.org/jdk/pull/22328/fi
On Fri, Nov 22, 2024 at 4:47 AM Joseph D. Darcy
wrote:
> PS it would be a "small matter of programming" to write an annotation
> processor to find the not subclassable public classes in the JDK that were
> not marked final.
>
Joe, your bait was too hard to resist.
These are the non-final, not su
On Fri, 22 Nov 2024 17:04:38 GMT, Severin Gehwolf wrote:
>> Please review this simple patch which adds a new external system property
>> `jdk.patched` when the runtime has been patched with the `--patch-module`
>> switch. This is useful for two reasons: 1) it allows one to determine at
>> run-
> See the bug for more discussion and reproducer. This PR replaces the ad-hoc
> linked list with segmented list of arrays. Arrays are easy targets for GC.
> There are possible improvements here, most glaring is parallelism that is
> currently knee-capped by global synchronization. The synchroniz
On Fri, 22 Nov 2024 11:07:31 GMT, Alan Bateman wrote:
>> Calvin Cheung has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> @dholmes-ora comment
>
> src/java.base/share/classes/java/lang/ClassLoader.java line 1689:
>
>> 1687:
>> 1688: /
> Currently, when retrieving a ClassFileStream during runtime, we call into the
> zip library to retrieve the stream based only on a class name. This doesn't
> work well if the class is in a multi-release jar under a versioned directory
> such as `META-INF/versions/9/Foo.class`. To address this
> Please review this simple patch which adds a new external system property
> `jdk.patched` when the runtime has been patched with the `--patch-module`
> switch. This is useful for two reasons: 1) it allows one to determine at
> run-time whether or not `--patch-module` has been used (by querying
On Thu, 21 Nov 2024 10:29:32 GMT, Severin Gehwolf wrote:
> While at it, should there be additional guards to prevent applications from
> changing the value of this system property by doing
> `System.setProperty("jdk.patched")` at runtime?
The updated patch has a test for this. In a nutshell an
On Fri, 22 Nov 2024 10:24:12 GMT, Adam Sotona wrote:
> ClassPrinter prints `null` values as `String` "null" or as
> `String.valueOf(ConstantDescs.BSM_NULL_CONSTANT)`, based on context.
>
> This patch unifies handling of `null` values.
> They are now exclusively represented as `ConstantDescs.BSM
On Fri, 22 Nov 2024 13:00:14 GMT, Sergey Chernyshev
wrote:
>>> Here, `limit` at line 64 is not stored as a possible lowest limit, so if
>>> the inner group has lower limit than the outer group, it won't be detected
>>> (cg v2 is affected too).
>>
>> Good spot! How about this to fix it?
>>
>>
> Please review this simple patch which adds a new external system property
> `jdk.patched` when the runtime has been patched with the `--patch-module`
> switch. This is useful for two reasons: 1) it allows one to determine at
> run-time whether or not `--patch-module` has been used (by querying
On Thu, 21 Nov 2024 19:33:01 GMT, Aleksey Shipilev wrote:
>> See the bug for more discussion and reproducer. This PR replaces the ad-hoc
>> linked list with segmented list of arrays. Arrays are easy targets for GC.
>> There are possible improvements here, most glaring is parallelism that is
>>
On Thu, 21 Nov 2024 19:33:01 GMT, Aleksey Shipilev wrote:
>> See the bug for more discussion and reproducer. This PR replaces the ad-hoc
>> linked list with segmented list of arrays. Arrays are easy targets for GC.
>> There are possible improvements here, most glaring is parallelism that is
>>
On Fri, 22 Nov 2024 10:57:31 GMT, Severin Gehwolf wrote:
> One thing to note is that the new test requires root privileges (AFAIK). We
> should skip the test if we are being run as root.
The test works just like other docker tests, root privileges are not required.
In systems that can't run do
On Fri, 22 Nov 2024 04:43:55 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this enhancement which proposes to enhance
>> `java.util.zip.Deflater/Inflater` classes to now implement `AutoCloseable`?
>>
>> The actual work for this was done a few years back when we discussed the
>> prop
On Fri, 22 Nov 2024 14:19:57 GMT, Tobias Hartmann wrote:
> Some tests specify `-XX:+EnableX86ECoreOpts` which does not work well with
> `-Xcheck:jni` on Windows. Disable `CheckJNICalls` for now with these tests
> until [JDK-8344802](https://bugs.openjdk.org/browse/JDK-8344802) is fixed.
>
> Th
On Fri, 22 Nov 2024 14:21:50 GMT, Raffaello Giulietti
wrote:
> Not sure if you are planning to make other code changes before adding the
> tests? From my perspective, the current status of the code looks good.
No, I'm not planning to make other changes, I will add the tests soon.
On Fri, 22 Nov 2024 14:19:57 GMT, Tobias Hartmann wrote:
> Some tests specify `-XX:+EnableX86ECoreOpts` which does not work well with
> `-Xcheck:jni` on Windows. Disable `CheckJNICalls` for now with these tests
> until [JDK-8344802](https://bugs.openjdk.org/browse/JDK-8344802) is fixed.
>
> Th
On Fri, 22 Nov 2024 14:19:57 GMT, Tobias Hartmann wrote:
> Some tests specify `-XX:+EnableX86ECoreOpts` which does not work well with
> `-Xcheck:jni` on Windows. Disable `CheckJNICalls` for now with these tests
> until [JDK-8344802](https://bugs.openjdk.org/browse/JDK-8344802) is fixed.
>
> Th
Some tests specify `-XX:+EnableX86ECoreOpts` which does not work well with
`-Xcheck:jni` on Windows. Disable `CheckJNICalls` for now with these tests
until [JDK-8344802](https://bugs.openjdk.org/browse/JDK-8344802) is fixed.
Thanks,
Tobias
-
Commit messages:
- Disable it
- 834486
On Tue, 19 Nov 2024 19:48:25 GMT, Raffaello Giulietti
wrote:
>> Yes, indeed in this case the remainder is always needed, so invoking
>> `workingInt.sqrtAndRemainder()` is faster than checking
>> `!workingInt.equals(sqrt.multiply(sqrt))`, as it avoids the squaring of
>> `sqrt`.
>
> I see.
>
>
Complete the SM cleanup in java.util.concurrent that was deferred during other
FJP updates
-
Commit messages:
- Merge branch 'openjdk:master' into JDK-8344773
- Remove SecurityManager-related code; refactor resetThreadLocals
Changes: https://git.openjdk.org/jdk/pull/22324/files
There is a new preview language feature, `requires transitive java.base;`. And
the `java.se` module is permitted to use the feature, without being marked as
preview (i.e. the `java.se` module participates in preview). This is currently
implemented by the common "participates in preview" way, by
On Fri, 22 Nov 2024 10:54:34 GMT, Severin Gehwolf wrote:
> Good spot! How about this to fix it?
>
> ```
> jlong limit = mem->read_memory_limit_in_bytes(phys_mem);
> jlong lowest_limit = limit < 0 ? phys_mem: limit;
> ```
Make sense to me.
> I'm worried about the added complexity. 1.) Is this
On Thu, 21 Nov 2024 17:21:07 GMT, Andrew Haley wrote:
> Test bug.
>
> Another bug caused by the result of `Math.abs()` being negative. I also tried
> `floorMod()`, which would have been cleaner, but it increased the runtime of
> this extremely time-sensitive benchmark.
This pull request has n
On Fri, 22 Nov 2024 10:36:21 GMT, Rémi Forax wrote:
> Let say that the definition of Math.abs() is surprising
If anything is surprising, it's the definition of `%` . Which is compatible
with `/`, but otherwise useless.
-
PR Comment: https://git.openjdk.org/jdk/pull/22297#issuecom
I see your responses in the Reddit thread. Thanks again!
But yes, would love to be kept in the loop about any further developments
on this topic!
On Thu, Nov 21, 2024 at 9:12 AM Viktor Klang
wrote:
> Hi David,
>
> I might respond to the Reddit thread later, I need to wrap some other
> tasks up
On Fri, 1 Nov 2024 18:01:18 GMT, Raffaello Giulietti
wrote:
> Simplify tests.
This pull request has now been integrated.
Changeset: bf374c33
Author:Raffaello Giulietti
URL:
https://git.openjdk.org/jdk/commit/bf374c33f5cd5048cabe151050fada773b7d9458
Stats: 3198 lines in 5 files
On Thu, 21 Nov 2024 23:14:58 GMT, Calvin Cheung wrote:
>> Currently, when retrieving a ClassFileStream during runtime, we call into
>> the zip library to retrieve the stream based only on a class name. This
>> doesn't work well if the class is in a multi-release jar under a versioned
>> direct
On Fri, 22 Nov 2024 09:54:39 GMT, Sergey Chernyshev
wrote:
> Here, `limit` at line 64 is not stored as a possible lowest limit, so if the
> inner group has lower limit than the outer group, it won't be detected (cg v2
> is affected too).
Good spot! How about this to fix it?
jlong limit = me
On Fri, 22 Nov 2024 09:57:44 GMT, Sergey Chernyshev
wrote:
>> Cgroup V1 subsustem fails to initialize mounted controllers properly in
>> certain cases, that may lead to controllers left undetected/inactive. We
>> observed the behavior in CloudFoundry deployments, it affects also host
>> syste
On Thu, 21 Nov 2024 17:21:07 GMT, Andrew Haley wrote:
> Test bug.
>
> Another bug caused by the result of `Math.abs()` being negative. I also tried
> `floorMod()`, which would have been cleaner, but it increased the runtime of
> this extremely time-sensitive benchmark.
Let say that the defini
On Fri, 22 Nov 2024 10:27:17 GMT, ExE Boss wrote:
> Should the CSR FAQ be updated to remove references to jdk.*, or are there
> some jdk.* packages that require a CSR? As far as I can tell, none are
> exported.
The "Design principles" section of JEP 200 may be help. Standard modules, as in
ja
> Hi All,
>
> This patch adds C2 compiler support for various Float16 operations added by
> [PR#22128](https://github.com/openjdk/jdk/pull/22128)
>
> Following is the summary of changes included with this patch:-
>
> 1. Detection of various Float16 operations through inline expansion or
> patt
On Fri, 22 Nov 2024 04:23:26 GMT, Dean Long wrote:
> Should the CSR FAQ be updated to remove references to `jdk.*,` or are there
> some jdk.* packages that require a CSR? As far as I can tell, none are
> exported.
The `jdk.incubator.*` packages (such as `jdk.incubator.vector`) are exported.
-
ClassPrinter prints `null` values as `String` "null" or as
`String.valueOf(ConstantDescs.BSM_NULL_CONSTANT)`, based on context.
This patch unifies handling of `null` values.
They are now exclusively represented as `ConstantDescs.BSM_NULL_CONSTANT`.
In Json and Yaml format is `null` value printed
> Cgroup V1 subsustem fails to initialize mounted controllers properly in
> certain cases, that may lead to controllers left undetected/inactive. We
> observed the behavior in CloudFoundry deployments, it affects also host
> systems.
>
> The relevant /proc/self/mountinfo line is
>
>
> 2207 21
On Tue, 12 Nov 2024 23:29:47 GMT, Sergey Chernyshev
wrote:
>> src/java.base/linux/classes/jdk/internal/platform/cgroupv1/CgroupV1SubsystemController.java
>> line 46:
>>
>>> 44: }
>>> 45:
>>> 46: public void setPath(String cgroupPath) {
>>
>> This should behave the same as Hotspot and
67 matches
Mail list logo
