On Wed, 20 Nov 2024 14:26:27 GMT, Severin Gehwolf wrote:
> Please review this simple patch which adds a new external system property
> `jdk.patched` when the runtime has been patched with the `--patch-module`
> switch. This is useful for two reasons: 1) it allows one to determine at
> run-time
On Thu, 21 Nov 2024 05:42:09 GMT, Brent Christian wrote:
>> Aleksey Shipilev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Check all elements are removable after random test
>
> test/micro/org/openjdk/bench/java/lang/ref/CleanerGC.java
On Fri, 6 Sep 2024 06:26:47 GMT, Athijegannathan Sundararajan
wrote:
> fixed spelling to be consistent with the rest of the man page.
This pull request has been closed without being integrated.
-
PR: https://git.openjdk.org/jdk/pull/20882
On Fri, 6 Sep 2024 06:26:47 GMT, Athijegannathan Sundararajan
wrote:
> fixed spelling to be consistent with the rest of the man page.
closed because of conflicts
-
PR Comment: https://git.openjdk.org/jdk/pull/20882#issuecomment-2490229186
On Wed, 20 Nov 2024 22:43:44 GMT, Brent Christian wrote:
>> Remove usages of SecurityManager, doPrivildged, and AccessController from
>> the java.prefs module.
>
> Brent Christian has updated the pull request incrementally with one
> additional commit since the last revision:
>
> indentation
On Wed, 20 Nov 2024 18:20:04 GMT, Naoto Sato wrote:
>> Justin Lu has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> address Naoto's comments
>
> src/java.base/share/classes/java/util/Locale.java line 1256:
>
>> 1254:
>> 1255: /**
>> 1
> Please review this PR and corresponding CSR which includes a wide range of
> specification improvements for java.util.Locale. See the CSR for further
> detail. Other changes/suggestions are welcomed to be included as part of this
> change.
>
> APIDiff:
> https://cr.openjdk.org/~jlu/8341923_a
On Wed, 20 Nov 2024 22:43:44 GMT, Brent Christian wrote:
>> Remove usages of SecurityManager, doPrivildged, and AccessController from
>> the java.prefs module.
>
> Brent Christian has updated the pull request incrementally with one
> additional commit since the last revision:
>
> indentation
On Wed, 20 Nov 2024 19:39:58 GMT, Daniel Fuchs wrote:
> This PR remove usage of SecurityManager, doPrivileges, etc... from
> `java.logging` and `java.base/jdk.internal.logger`
>
> Only notable hack - Logger.checkPermission() no longer checks permissions,
> but has been renamed into `ensureLogM
On Tue, 19 Nov 2024 20:43:25 GMT, Sean Mullan wrote:
> Now that JEP 486 has been integrated, `java.security.jgss` and
> `jdk.security.jgss` module dependencies on `System.getSecurityManager` and
> `AccessController.doPrivileged*` can be removed.
>
> There is an undocumented property named "sun
On Wed, 20 Nov 2024 14:26:27 GMT, Severin Gehwolf wrote:
> Please review this simple patch which adds a new external system property
> `jdk.patched` when the runtime has been patched with the `--patch-module`
> switch. This is useful for two reasons: 1) it allows one to determine at
> run-time
On Wed, 20 Nov 2024 09:19:39 GMT, Aleksey Shipilev wrote:
>> See the bug for more discussion and reproducer. This PR replaces the ad-hoc
>> linked list with segmented list of arrays. Arrays are easy targets for GC.
>> There are possible improvements here, most glaring is parallelism that is
>>
> Can I please get a review of this change, which simplifies the interaction
> between the `java` launcher's native code with the
> `sun.launcher.LauncherHelper`?
>
> As noted in https://bugs.openjdk.org/browse/JDK-8341184, this proposed change
> reduces the back and forth between the launcher
On Thu, 21 Nov 2024 02:45:06 GMT, Chris Plummer wrote:
>> In JDK 16 we deprecated the old signal and sigset signal-chaining interfaces
>> under [JDK-8257572](https://bugs.openjdk.org/browse/JDK-8257572). The
>> deprecation warning was written to stdout but all other warnings go to
>> stderr. H
On Thu, 21 Nov 2024 04:32:50 GMT, Taizo Kurashige wrote:
>> To resolve tools/jpackage/windows/Win8301247Test.java failure, I made "wmic"
>> executed with "chcp 437". This ensures that the English message "No
>> Instance(s) Available." is output on localized windows platforms.
>>
>> I have refe
On Thu, 21 Nov 2024 04:32:50 GMT, Taizo Kurashige wrote:
>> To resolve tools/jpackage/windows/Win8301247Test.java failure, I made "wmic"
>> executed with "chcp 437". This ensures that the English message "No
>> Instance(s) Available." is output on localized windows platforms.
>>
>> I have refe
> To resolve tools/jpackage/windows/Win8301247Test.java failure, I made "wmic"
> executed with "chcp 437". This ensures that the English message "No
> Instance(s) Available." is output on localized windows platforms.
>
> I have referred to the following for how to use chcp:
> ・chcp | Microsoft L
On Thu, 21 Nov 2024 01:45:56 GMT, Brian Burkhalter wrote:
>> Remove some occurrences of `GetPropertyAction` overlooked in #22219 and
>> #22132.
>
> Brian Burkhalter has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8344659: System.getPropert
On Tue, 19 Nov 2024 17:15:22 GMT, Chen Liang wrote:
>> Okay, in that case it's probably fine - I assume there's also no easy way to
>> ensure in a test that all signature polymorphic methods are covered by these
>> checks?
>
> These checks are 1-1 to the JVMS 2.9.3/JLS 15.12.3, where definition
On Fri, 15 Nov 2024 22:17:10 GMT, Chen Liang wrote:
> When core reflection was migrated to be implemented by Method Handles,
> somehow, the method handles are not used for native methods, which are
> generally linkable by method handles. This causes significant performance
> regressions when
On Thu, 21 Nov 2024 01:45:56 GMT, Brian Burkhalter wrote:
>> Remove some occurrences of `GetPropertyAction` overlooked in #22219 and
>> #22132.
>
> Brian Burkhalter has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8344659: System.getPropert
On Tue, 19 Nov 2024 14:16:47 GMT, Chen Liang wrote:
>> When core reflection was migrated to be implemented by Method Handles,
>> somehow, the method handles are not used for native methods, which are
>> generally linkable by method handles. This causes significant performance
>> regressions w
On Wed, 20 Nov 2024 21:18:01 GMT, David Holmes wrote:
> In JDK 16 we deprecated the old signal and sigset signal-chaining interfaces
> under [JDK-8257572](https://bugs.openjdk.org/browse/JDK-8257572). The
> deprecation warning was written to stdout but all other warnings go to
> stderr. Having
On Mon, 14 Oct 2024 11:40:01 GMT, Jatin Bhateja wrote:
> Hi All,
>
> This patch adds C2 compiler support for various Float16 operations added by
> [PR#22128](https://github.com/openjdk/jdk/pull/22128)
>
> Following is the summary of changes included with this patch:-
>
> 1. Detection of vario
Unwrap calls using doPrivileged in jdk.unsupported sun.misc.Unsafe.
-
Commit messages:
- simplify declaration of INSTANCE
- 8344549: Cleanup AccessController in sun.misc.Unsafe
Changes: https://git.openjdk.org/jdk/pull/22242/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=
On Wed, 20 Nov 2024 01:47:34 GMT, Taizo Kurashige wrote:
>> To resolve tools/jpackage/windows/Win8301247Test.java failure, I made "wmic"
>> executed with "chcp 65001". This ensures that the encoding is UTF8 and that
>> the English message "No Instance(s) Available." is output on localized
>> w
In JDK 16 we deprecated the old signal and sigset signal-chaining interfaces
under [JDK-8257572](https://bugs.openjdk.org/browse/JDK-8257572). The
deprecation warning was written to stdout but all other warnings go to stderr.
Having the warning be on stdout causes interference with application o
> Remove some occurrences of `GetPropertyAction` overlooked in #22219 and
> #22132.
Brian Burkhalter has updated the pull request incrementally with one additional
commit since the last revision:
8344659: System.getProperty("sun.jnu.encoding") ->
StaticProperty.jnuEncoding()
-
On Tue, 19 Nov 2024 07:58:22 GMT, Justin Lu wrote:
>> Please review this PR and corresponding CSR which includes a wide range of
>> specification improvements for java.util.Locale. See the CSR for further
>> detail. Other changes/suggestions are welcomed to be included as part of
>> this chang
On Wed, 20 Nov 2024 23:34:22 GMT, Naoto Sato wrote:
>> Brian Burkhalter has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8344659: System.getProperty("sun.jnu.encoding") ->
>> StaticProperty.jnuEncoding()
>
> src/java.base/share/classes/s
On Wed, 20 Nov 2024 23:14:30 GMT, Lance Andersen wrote:
>> Remove some occurrences of `GetPropertyAction` overlooked in #22219 and
>> #22132.
>
> LGTM
@LanceAndersen , @naotoj Thanks for the reviews. I'll fiix Util.java and hold
off integrating until tomorrow.
-
PR Comment: https
On Wed, 20 Nov 2024 09:38:05 GMT, Jaikiran Pai wrote:
> Can I please get a review for this change which removes SecurityManager
> usages from `jdk.jlink` module? This addresses
> https://bugs.openjdk.org/browse/JDK-8344524.
>
> The internal class `jdk.tools.jlink.internal.JlinkPermission` too
On Wed, 20 Nov 2024 09:38:05 GMT, Jaikiran Pai wrote:
> Can I please get a review for this change which removes SecurityManager
> usages from `jdk.jlink` module? This addresses
> https://bugs.openjdk.org/browse/JDK-8344524.
>
> The internal class `jdk.tools.jlink.internal.JlinkPermission` too
On Mon, 14 Oct 2024 11:40:01 GMT, Jatin Bhateja wrote:
> Hi All,
>
> This patch adds C2 compiler support for various Float16 operations added by
> [PR#22128](https://github.com/openjdk/jdk/pull/22128)
>
> Following is the summary of changes included with this patch:-
>
> 1. Detection of vario
On Tue, 19 Nov 2024 20:43:25 GMT, Sean Mullan wrote:
> Now that JEP 486 has been integrated, `java.security.jgss` and
> `jdk.security.jgss` module dependencies on `System.getSecurityManager` and
> `AccessController.doPrivileged*` can be removed.
>
> There is an undocumented property named "sun
On Wed, 20 Nov 2024 22:36:12 GMT, Brian Burkhalter wrote:
> Remove some occurrences of `GetPropertyAction` overlooked in #22219 and
> #22132.
Changes in `java.io.Console` and `sun.nio.cs.GB18030` look good.
src/java.base/share/classes/sun/nio/fs/Util.java line 40:
> 38:
> 39: private sta
On Wed, 20 Nov 2024 22:36:12 GMT, Brian Burkhalter wrote:
> Remove some occurrences of `GetPropertyAction` overlooked in #22219 and
> #22132.
LGTM
-
Marked as reviewed by lancea (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/22285#pullrequestreview-2449890758
Remove some occurrences of `GetPropertyAction` overlooked in #22219 and #22132.
-
Commit messages:
- 8344659: Some uses of GetPropertyAction were not removed from java.io and
java.nio
Changes: https://git.openjdk.org/jdk/pull/22285/files
Webrev: https://webrevs.openjdk.org/?repo=
On Wed, 20 Nov 2024 23:03:43 GMT, Chen Liang wrote:
>> Improve the documentation for classfile instructions. Includes links to all
>> opcodes, usage notes for instructions, and other various fixes.
>>
>> API Diff:
>> https://cr.openjdk.org/~liach/apidiff/cf-instr/java.base/module-summary.html
On Tue, 19 Nov 2024 09:40:25 GMT, Adam Sotona wrote:
>> Chen Liang has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains six commits:
>>
>> - Further facelift
>> - Merge branch 'master' of https://github.com/openjdk/jdk into
>> docs/
> Improve the documentation for classfile instructions. Includes links to all
> opcodes, usage notes for instructions, and other various fixes.
>
> API Diff:
> https://cr.openjdk.org/~liach/apidiff/cf-instr/java.base/module-summary.html
> Javadoc:
> https://cr.openjdk.org/~liach/javadoc/cf-inst
On Mon, 11 Nov 2024 17:28:34 GMT, Maurizio Cimadamore
wrote:
> > Maybe we should also check that padding layouts have natural alignment? The
> > alignment of padding layouts can affect the alignment of the enclosing
> > container.
>
> This makes sense, but I wonder if that would require a cha
On Mon, 28 Oct 2024 13:53:58 GMT, Jorn Vernee wrote:
> There is a subtle race in `UpcallLinker::on_exit` between copying of the old
> frame anchor back into place, and the GC. Since this copy is not atomic, it
> may briefly appear as if a thread has no last Java frame, while still in the
> `_t
On Wed, 20 Nov 2024 22:43:44 GMT, Brent Christian wrote:
>> Remove usages of SecurityManager, doPrivildged, and AccessController from
>> the java.prefs module.
>
> Brent Christian has updated the pull request incrementally with one
> additional commit since the last revision:
>
> indentation
> Remove usages of SecurityManager, doPrivildged, and AccessController from the
> java.prefs module.
Brent Christian has updated the pull request incrementally with one additional
commit since the last revision:
indentation fixes
-
Changes:
- all: https://git.openjdk.org/jdk/p
On Tue, 19 Nov 2024 09:21:08 GMT, Raffaello Giulietti
wrote:
> While you are at it, it would be useful to add one test for each of the paths
> in the new algorithm (including the exception cases) in the existing
> [SquareRootTests](https://github.com/openjdk/jdk/blob/master/test/jdk/java/math/
On Wed, 20 Nov 2024 21:30:32 GMT, Mikael Vidstedt wrote:
>> In JDK 16 we deprecated the old signal and sigset signal-chaining interfaces
>> under [JDK-8257572](https://bugs.openjdk.org/browse/JDK-8257572). The
>> deprecation warning was written to stdout but all other warnings go to
>> stderr.
On Wed, 20 Nov 2024 21:18:01 GMT, David Holmes wrote:
> In JDK 16 we deprecated the old signal and sigset signal-chaining interfaces
> under [JDK-8257572](https://bugs.openjdk.org/browse/JDK-8257572). The
> deprecation warning was written to stdout but all other warnings go to
> stderr. Having
> Removed use of SecurityManager to check permissions.
> Relaxed defensive copying of byte arrays (due to lack of SM)
>
> Refresh of PR#22168 Including review comments made there.
Roger Riggs has updated the pull request incrementally with one additional
commit since the last revision:
Remove
On Wed, 20 Nov 2024 19:39:58 GMT, Daniel Fuchs wrote:
> This PR remove usage of SecurityManager, doPrivileges, etc... from
> `java.logging` and `java.base/jdk.internal.logger`
>
> Only notable hack - Logger.checkPermission() no longer checks permissions,
> but has been renamed into `ensureLogM
On Wed, 20 Nov 2024 19:42:58 GMT, Roger Riggs wrote:
> Removed use of SecurityManager to check permissions.
> Relaxed defensive copying of byte arrays (due to lack of SM)
>
> Refresh of PR#22168 Including review comments made there.
I agree with Daniel that LOGGERFINDER_PERMISSION and the speci
Removed use of SecurityManager to check permissions.
Relaxed defensive copying of byte arrays (due to lack of SM)
Refresh of PR#22168 Including review comments made there.
-
Commit messages:
- Refactor package private method `codeSource` into Module where it is used.
- Review sugge
On Wed, 20 Nov 2024 02:58:45 GMT, Justin Lu wrote:
>> src/java.base/share/classes/java/util/Locale.java line 144:
>>
>>> 142: * each indicating its own semantics, these values should be ordered
>>> 143: * by importance, with most important first, separated by
>>> 144: * underscore('_').
On Tue, 19 Nov 2024 19:33:18 GMT, kabutz wrote:
> See internal bug review 9077848
>
> This is a very small unimportant mistake in the naming of the documentation
> that does not match the code.
This pull request has now been integrated.
Changeset: da2d7a09
Author:Dr Heinz M. Kabutz
Commi
On Wed, 20 Nov 2024 19:42:58 GMT, Roger Riggs wrote:
> Removed use of SecurityManager to check permissions.
> Relaxed defensive copying of byte arrays (due to lack of SM)
>
> Refresh of PR#22168 Including review comments made there.
The changes to SystemLogger looks OK to me. Maybe you could ge
This PR remove usage of SecurityManager, doPrivileges, etc... from
`java.logging` and `java.base/jdk.internal.logger`
Only notable hack - Logger.checkPermission() no longer checks permissions, but
has been renamed into `ensureLogManagerInitialized()` in order to avoid
disturbing the initializat
On Tue, 19 Nov 2024 19:33:18 GMT, kabutz wrote:
> See internal bug review 9077848
>
> This is a very small unimportant mistake in the naming of the documentation
> that does not match the code.
@kabutz
Your change (at version 2817981d67c561580f262c049384be6f7fe6520f) is now ready
to be spons
On Wed, 25 Sep 2024 10:28:02 GMT, Eirik Bjørsnøs wrote:
> Please review this test-only PR which adds a micro benchmark exploring
> performance differences between reading entry data sequentially from a
> `ZipFile` and reading the same entries using `ZipInputStream` wrapping a
> `BufferedInputS
On Wed, 20 Nov 2024 13:46:49 GMT, Per Minborg wrote:
>> This PR prevents sequence layout with padding to be used with the Linker.
>
> Per Minborg has updated the pull request with a new target base due to a
> merge or a rebase. The incremental webrev excludes the unrelated changes
> brought in
Updates the JDK to use the latest Unicode 16.0.0, which also updates the ICU4J
along with it (8319992: Update ICU4J to Version 76.1). The corresponding CSR
has already been approved.
-
Commit messages:
- icu.md changes
- Merge branch 'master' into JDK-8319993-Unicode-16
- Merge b
On Wed, 20 Nov 2024 03:02:39 GMT, Justin Lu wrote:
> Please review this PR which removes the leftover ocurrences of incorrect JNI
> `ExceptionOccurred(env)` usage within _java.base_.
>
> This PR also includes 9 cases of `if (ExceptionOccurred(env) == NULL)`. While
> these occurrences are fine
On Wed, 20 Nov 2024 18:16:22 GMT, Severin Gehwolf wrote:
> Sorry about that. There weren't any major objections, so I moved forward as
> there was radio-silence for a while:
That's okay, my comment wasn't aimed at you, it was instead just observing that
there wasn't much feedback.
---
On Wed, 20 Nov 2024 18:02:35 GMT, Alan Bateman wrote:
> > yeah,I tested it a few mins ago.It works well in the situation mentioned in
> > the issue and in the normal situation, also when a remote/target jdk is
> > set. But I have a doubt, when only using the local jdk, no
> > remote/targetjdk,
On Wed, 20 Nov 2024 17:45:18 GMT, Alan Bateman wrote:
> I had hoped you would get more feedback on the proposal.
Sorry about that. There weren't any major objections, so I moved forward as
there was radio-silence for a while:
https://mail.openjdk.org/pipermail/core-libs-dev/2024-November/134623
On Wed, 20 Nov 2024 18:03:53 GMT, Brent Christian wrote:
>> Remove usages of SecurityManager, doPrivildged, and AccessController from
>> the java.prefs module.
>
> Brent Christian has updated the pull request incrementally with one
> additional commit since the last revision:
>
> fix indenta
On Wed, 20 Nov 2024 04:22:48 GMT, Taizo Kurashige wrote:
>> To resolve tools/jpackage/windows/Win8301247Test.java failure, I made "wmic"
>> executed with "chcp 437". This ensures that the English message "No
>> Instance(s) Available." is output on localized windows platforms.
>>
>> I have refe
> In addition to the goals, scope, motivation, specification and requirement
> notes in [JDK-8315487](https://bugs.openjdk.org/browse/JDK-8315487), we would
> like to describe the most relevant decisions taken during the implementation
> of this enhancement. These notes are organized by feature,
On Wed, 20 Nov 2024 03:03:22 GMT, Justin Lu wrote:
>> Please review this PR and corresponding CSR which includes a wide range of
>> specification improvements for java.util.Locale. See the CSR for further
>> detail. Other changes/suggestions are welcomed to be included as part of
>> this chang
On Thu, 14 Nov 2024 04:40:37 GMT, Alexey Semenyuk wrote:
> Fix `ResourceEditor` class to handle long paths.
>
> Based on https://github.com/openjdk/jdk/pull/9384 PR.
>
> This repairs app image building on Windows if the path to jpackage temp
> directory exceeds 260 (`MAX_PATH`) characters. MSI
On Tue, 19 Nov 2024 23:37:00 GMT, Brian Burkhalter wrote:
> I think the try-block at line 137 in FileSystemPreferences would be more
> readable if it were indented. I know it was not indented in the original,
> either.
Oh, yeah, I don't like that either. :(
Fixed; also added {}s.
Thanks.
On Wed, 20 Nov 2024 03:02:39 GMT, Justin Lu wrote:
> Please review this PR which removes the leftover ocurrences of incorrect JNI
> `ExceptionOccurred(env)` usage within _java.base_.
>
> This PR also includes 9 cases of `if (ExceptionOccurred(env) == NULL)`. While
> these occurrences are fine
On Wed, 20 Nov 2024 17:27:18 GMT, jyxzwd wrote:
> yeah,I tested it a few mins ago.It works well in the situation mentioned in
> the issue and in the normal situation, also when a remote/target jdk is set.
> But I have a doubt, when only using the local jdk, no remote/targetjdk, that
> is, Imag
> Remove usages of SecurityManager, doPrivildged, and AccessController from the
> java.prefs module.
Brent Christian has updated the pull request incrementally with one additional
commit since the last revision:
fix indentation, add braces
-
Changes:
- all: https://git.openjdk
On Wed, 20 Nov 2024 02:59:54 GMT, Justin Lu wrote:
> Please review this PR which keeps the IANA language subtag registry data up
> to date with release _2024-11-19_.
>
> The changes are trivial and Locale tests pass as expected.
Marked as reviewed by naoto (Reviewer).
-
PR Review
On Wed, 20 Nov 2024 07:20:32 GMT, Laurent Bourgès wrote:
> I will check today if any 'bad' pattern is remaining in the openjdk master
> source folder... to be sure.
>
> Maybe improving jni documentation would be great in another issue...
Thanks for checking @bourgesl. The JNI docs did in fact
On Wed, 20 Nov 2024 14:26:27 GMT, Severin Gehwolf wrote:
> Please review this simple patch which adds a new external system property
> `jdk.patched` when the runtime has been patched with the `--patch-module`
> switch. This is useful for two reasons: 1) it allows one to determine at
> run-time
On Tue, 19 Nov 2024 12:43:48 GMT, Alan Bateman wrote:
>>> concat the URLs to the resource in the modules and the class path
>>
>> Did you mean "concat the URLs of the " ?
>
> "of" or "to" will work here.
Done - I've now updated this comment.
-
PR Review Comment: https://git.op
On Wed, 20 Nov 2024 14:11:51 GMT, Alan Bateman wrote:
> I don't think we should be doing this. Did you try the direction of checking
> the defining class loader that I outlined in the previous comment?
yeah,I tested it a few mins ago.It works well in the situation mentioned in the
issue and in
> Please review this PR and corresponding CSR which includes a wide range of
> specification improvements for java.util.Locale. See the CSR for further
> detail. Other changes/suggestions are welcomed to be included as part of this
> change.
>
> APIDiff:
> https://cr.openjdk.org/~jlu/8341923_a
On Wed, 20 Nov 2024 09:38:05 GMT, Jaikiran Pai wrote:
> Can I please get a review for this change which removes SecurityManager
> usages from `jdk.jlink` module? This addresses
> https://bugs.openjdk.org/browse/JDK-8344524.
>
> The internal class `jdk.tools.jlink.internal.JlinkPermission` too
On Thu, 14 Nov 2024 16:11:13 GMT, Severin Gehwolf wrote:
>> Yes, I'm wondering if a JDK-specific (rather than standard) property could
>> be more widely useful as it would allow observability tools to know that the
>> JDK has been patched. It would be good to get wider input on this.
>
> @AlanB
On Tue, 12 Nov 2024 13:52:12 GMT, Severin Gehwolf wrote:
>> src/jdk.jlink/share/classes/jdk/tools/jlink/resources/jlink.properties line
>> 128:
>>
>>> 126: \ --keep-packaged-modules is not supported
>>> 127: err.runtime.link.modified.file={0} has been modified
>>> 128: err.runtime.link.patched.
> Please review this fix to how patched modules are being handled when linking
> from the run-time image. During review of
> [JDK-8311302](https://bugs.openjdk.org/browse/JDK-8311302) it was pointed out
> that module patching should be detected earlier and the link should get
> aborted in that
On Wed, 20 Nov 2024 16:40:43 GMT, Aleksei Efimov wrote:
>> src/jdk.naming.rmi/share/classes/module-info.java line 64:
>>
>>> 62: * location} specified in the reference can be supported by a custom
>>> implementation of {@link
>>> 63: * javax.naming.spi.ObjectFactoryBuilder}. If a location is
On Wed, 20 Nov 2024 16:25:56 GMT, Aleksei Efimov wrote:
>> This PR permanently disable remote code downloading in JNDI/LDAP and
>> JNDI/RMI JDK providers, and contains the following changes:
>> - The following two properties are removed:
>> - `com.sun.jndi.ldap.object.trustURLCodebase`
>>
On Wed, 20 Nov 2024 16:25:56 GMT, Aleksei Efimov wrote:
>> This PR permanently disable remote code downloading in JNDI/LDAP and
>> JNDI/RMI JDK providers, and contains the following changes:
>> - The following two properties are removed:
>> - `com.sun.jndi.ldap.object.trustURLCodebase`
>>
On Wed, 20 Nov 2024 16:31:44 GMT, Daniel Fuchs wrote:
>> Aleksei Efimov has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> change jdk.naming.rmi per Daniel's suggestion
>
> src/jdk.naming.rmi/share/classes/module-info.java line 64:
>
>> 62
On Mon, 18 Nov 2024 15:50:49 GMT, Jan Lahoda wrote:
>> Currently, running `java` without any parameters will lead to an output that
>> is a full `--help`, which is over 100 lines (on my computer at least), and
>> it feels overwhelming. And many people might actually want to run
>> JShell/REPL,
On Mon, 18 Nov 2024 19:22:33 GMT, Roger Riggs wrote:
>> Removed use of SecurityManager to check permissions.
>> Relaxed defensive copying of byte arrays (due to lack of SM)
>
> Roger Riggs has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Rev
On Fri, 15 Nov 2024 22:11:17 GMT, Roger Riggs wrote:
> Removed use of SecurityManager to check permissions.
> Relaxed defensive copying of byte arrays (due to lack of SM)
This pull request has been closed without being integrated.
-
PR: https://git.openjdk.org/jdk/pull/22168
> Removed use of SecurityManager to check permissions.
> Relaxed defensive copying of byte arrays (due to lack of SM)
Roger Riggs has updated the pull request with a new target base due to a merge
or a rebase. The incremental webrev excludes the unrelated changes brought in
by the merge/rebase.
> This PR permanently disable remote code downloading in JNDI/LDAP and JNDI/RMI
> JDK providers, and contains the following changes:
> - The following two properties are removed:
> - `com.sun.jndi.ldap.object.trustURLCodebase`
> - `com.sun.jndi.rmi.object.trustURLCodebase`
> - JNDIs object
On Wed, 20 Nov 2024 14:13:59 GMT, Daniel Fuchs wrote:
>> Aleksei Efimov has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Docs and comments update
>> - Revert VersionHelper.createThread removal
>
> src/jdk.naming.rmi/share/classes/modul
On Tue, 19 Nov 2024 16:27:54 GMT, Eirik Bjørsnøs wrote:
>> Magnus Ihse Bursie has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> It's somewhat nicer to use \\s instead of space character in regex
>
> Is the warning log when pandoc is not in
On Wed, 20 Nov 2024 14:46:46 GMT, Bhavana Kilambi wrote:
>> Hi All,
>>
>> This patch adds C2 compiler support for various Float16 operations added by
>> [PR#22128](https://github.com/openjdk/jdk/pull/22128)
>>
>> Following is the summary of changes included with this patch:-
>>
>> 1. Detectio
Please review this simple patch which adds a new external system property
`jdk.patched` when the runtime has been patched with the `--patch-module`
switch. This is useful for two reasons: 1) it allows one to determine at
runtime whether or not `--patch-module` has been used (by querying the said
> After changing `BigInteger.sqrt()` algorithm, this can be also used to speed
> up `BigDecimal.sqrt()` implementation. Here is how I made it.
>
> The main steps of the algorithm are as follows:
> first argument reduce the value to an integer using the following relations:
>
> x = y * 10 ^ exp
>
On Wed, 20 Nov 2024 10:46:54 GMT, Sorna Sarathi wrote:
> This PR adds missing Classpath exception in several files.
>
> JBS Issue: [JDK-8334611](https://bugs.openjdk.org/browse/JDK-8344611)
Do similar change for:
src/java.base/share/native/libjava/ub.h
src/jdk.jlink/share/classes/jdk/tools/jl
This PR adds missing Classpath exception in several files.
JBS Issue: [JDK-8334611](https://bugs.openjdk.org/browse/JDK-8344611)
-
Commit messages:
- Added classpath exception for some additional files
- Added missing classpath exception
Changes: https://git.openjdk.org/jdk/pull/2
On Wed, 20 Nov 2024 14:57:11 GMT, Jatin Bhateja wrote:
>> test/hotspot/jtreg/compiler/vectorization/TestFloat16VectorConvChain.java
>> line 44:
>>
>>> 42: @Test
>>> 43: @IR(applyIfCPUFeatureAnd = {"avx512_fp16", "false", "avx512vl",
>>> "true"}, counts = {IRNode.VECTOR_CAST_HF2F, IRNod
1 - 100 of 142 matches
Mail list logo
