On Mon, 18 Nov 2024 19:22:33 GMT, Roger Riggs wrote:
>> Removed use of SecurityManager to check permissions.
>> Relaxed defensive copying of byte arrays (due to lack of SM)
>
> Roger Riggs has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Rev
> This addresses tendencies in previous update to increase fencing, scanning,
> and signalling that can increase contention, and slow down performance
> especially on ARM platforms. It also uses more ARM-friendly constructions to
> reduce overhead (leading to several changes that all of the same
On Wed, 20 Nov 2024 03:02:39 GMT, Justin Lu wrote:
> Please review this PR which removes the leftover ocurrences of incorrect JNI
> `ExceptionOccurred(env)` usage within _java.base_.
>
> This PR also includes 9 cases of `if (ExceptionOccurred(env) == NULL)`. While
> these occurrences are fine
On Tue, 19 Nov 2024 23:16:38 GMT, Brent Christian wrote:
>> Remove usages of SecurityManager, doPrivildged, and AccessController from
>> the java.prefs module.
>
> Brent Christian has updated the pull request incrementally with one
> additional commit since the last revision:
>
> One more co
On Wed, 20 Nov 2024 03:02:39 GMT, Justin Lu wrote:
> Please review this PR which removes the leftover ocurrences of incorrect JNI
> `ExceptionOccurred(env)` usage within _java.base_.
>
> This PR also includes 9 cases of `if (ExceptionOccurred(env) == NULL)`. While
> these occurrences are fine
> Can I please get a review of this change which proposes to remove
> SecurityManager related API usages from `URLClassLoader` and its related
> `URLClassPath`? This addresses https://bugs.openjdk.org/browse/JDK-8344223.
>
> The `URLClassLoader.getPermissions()` method will need additional chang
On Tue, 19 Nov 2024 12:54:18 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which proposes to remove
>> SecurityManager related API usages from `URLClassLoader` and its related
>> `URLClassPath`? This addresses https://bugs.openjdk.org/browse/JDK-8344223.
>>
>> The `URLCl
See internal bug review 9077848
This is a very small unimportant mistake in the naming of the documentation
that does not match the code.
-
Commit messages:
- Made documentation match state field names WAIT and TIMED_WAIT
Changes: https://git.openjdk.org/jdk/pull/22253/files
Web
On Wed, 20 Nov 2024 03:02:39 GMT, Justin Lu wrote:
> Please review this PR which removes the leftover ocurrences of incorrect JNI
> `ExceptionOccurred(env)` usage within _java.base_.
>
> This PR also includes 9 cases of `if (ExceptionOccurred(env) == NULL)`. While
> these occurrences are fine
Remove usages of SecurityManager, doPrivildged, and AccessController from the
java.prefs module.
-
Commit messages:
- Remove SecMgr, etc usage from java.prefs
Changes: https://git.openjdk.org/jdk/pull/22252/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=22252&range=00
I
On Tue, 19 Nov 2024 16:42:47 GMT, Chen Liang wrote:
>> I think the main problem with annotation is that annotation creation needs
>> to use `java.lang.reflect.Proxy`, which is unavailable until module system
>> is initialized. Extra allocations are costs too, while checks here only
>> reuse ex
On Sun, 17 Nov 2024 15:33:02 GMT, Doug Lea wrote:
>> This addresses tendencies in previous update to increase fencing, scanning,
>> and signalling that can increase contention, and slow down performance
>> especially on ARM platforms. It also uses more ARM-friendly constructions to
>> reduce o
On Wed, 20 Nov 2024 04:22:48 GMT, Taizo Kurashige wrote:
>> To resolve tools/jpackage/windows/Win8301247Test.java failure, I made "wmic"
>> executed with "chcp 437". This ensures that the encoding is UTF8 and that
>> the English message "No Instance(s) Available." is output on localized
>> win
On Fri, 15 Nov 2024 14:23:36 GMT, Alexey Semenyuk wrote:
> I'm not sure "65001" is the right choice if the request is to get the output
> in English. Would "437" or "850" be more appropriate arguments for the "chcp"
> command?
After receiving your comment, I ran the chcp command on Windows Ser
On Fri, 15 Nov 2024 14:20:00 GMT, Alexey Semenyuk wrote:
>> Taizo Kurashige has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix indent
>
> test/jdk/tools/jpackage/helpers/jdk/jpackage/test/Executor.java line 344:
>
>> 342: c
On Wed, 20 Nov 2024 03:16:47 GMT, Alexey Semenyuk wrote:
>> Taizo Kurashige has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix indent
>
> test/jdk/tools/jpackage/helpers/jdk/jpackage/test/Executor.java line 344:
>
>> 342: private L
On Wed, 20 Nov 2024 02:59:54 GMT, Justin Lu wrote:
> Please review this PR which keeps the IANA language subtag registry data up
> to date with release _2024-11-19_.
>
> The changes are trivial and Locale tests pass as expected.
Marked as reviewed by iris (Reviewer).
-
PR Review:
On Wed, 20 Nov 2024 03:13:23 GMT, Alexey Semenyuk wrote:
>> Taizo Kurashige has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix indent
>
> test/jdk/tools/jpackage/helpers/jdk/jpackage/test/Executor.java line 487:
>
>> 485:
> To resolve tools/jpackage/windows/Win8301247Test.java failure, I made "wmic"
> executed with "chcp 65001". This ensures that the encoding is UTF8 and that
> the English message "No Instance(s) Available." is output on localized
> windows platforms.
>
> I have referred to the following for how
On Fri, 15 Nov 2024 13:25:01 GMT, Alexey Semenyuk wrote:
> The implementation may change, but the name of the function should remain the
> same.
That certainly makes sense. I changed setWinEnableUTF8 to
setWinRunWithEnglishOutput as you suggested.
> I'd run suppress the output of "chcp" comma
On Tue, 19 Nov 2024 20:30:11 GMT, Naoto Sato wrote:
>> Justin Lu has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> address Naoto's comments
>
> src/java.base/share/classes/java/util/Locale.java line 144:
>
>> 142: * each indicating its
On Wed, 20 Nov 2024 01:47:34 GMT, Taizo Kurashige wrote:
>> To resolve tools/jpackage/windows/Win8301247Test.java failure, I made "wmic"
>> executed with "chcp 65001". This ensures that the encoding is UTF8 and that
>> the English message "No Instance(s) Available." is output on localized
>> w
On Tue, 19 Nov 2024 22:07:10 GMT, Alexey Semenyuk wrote:
>> Fix `ResourceEditor` class to handle long paths.
>>
>> Based on https://github.com/openjdk/jdk/pull/9384 PR.
>>
>> This repairs app image building on Windows if the path to jpackage temp
>> directory exceeds 260 (`MAX_PATH`) character
Please review this PR which removes the leftover ocurrences of incorrect JNI
`ExceptionOccurred(env)` usage within _java.base_.
This PR also includes 9 cases of `if (ExceptionOccurred(env) == NULL)`. While
these occurrences are fine and were intentionally not removed during the first
pass, it
Please review this PR which keeps the IANA language subtag registry data up to
date with release _2024-11-19_.
The changes are trivial and Locale tests pass as expected.
-
Commit messages:
- init
Changes: https://git.openjdk.org/jdk/pull/22265/files
Webrev: https://webrevs.openj
On Tue, 19 Nov 2024 19:46:42 GMT, Naoto Sato wrote:
>> Justin Lu has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> address Chen's review; make other similar changes
>
> src/java.base/share/classes/java/util/Locale.java line 89:
>
>> 87:
> Please review this PR and corresponding CSR which includes a wide range of
> specification improvements for java.util.Locale. See the CSR for further
> detail. Other changes/suggestions are welcomed to be included as part of this
> change.
>
> APIDiff:
> https://cr.openjdk.org/~jlu/8341923_a
On Tue, 19 Nov 2024 23:55:33 GMT, Alexander Matveev
wrote:
>> Alexey Semenyuk has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Make path guaranteed to be long enough
>
> test/jdk/tools/jpackage/windows/WinLongPathTest.java line 38:
>
>>
Dial down GetStackTraceALotWhenBlocking and GetStackTraceALotWhenPinned as they
make slow progress when executed concurrently on under power systems.
GetStackTraceALotWhenBlocking has 3 busy threads, GetStackTraceALotWhenPinned
has two spinning threads. When they run concurrently in jdk/:tier1_p
On Fri, 15 Nov 2024 14:50:21 GMT, Magnus Ihse Bursie wrote:
>> Currently, the man pages are stored as troff (a text format) in the open
>> repo, and a content-wise identical copy is stored as markdown (another text
>> format) in the closed repo.
>>
>> Since markdown is preferred to troff in te
On Thu, 17 Oct 2024 21:33:03 GMT, Joe Darcy wrote:
>
> Before the work in this PR proceeds, I think the java.lang ->
> jdk.incubator.vector move of Float16 should occur first. This will allow
> leaner reviews and better API separation. I can get an updated PR of the move
> prepared within the
On Mon, 14 Oct 2024 11:40:01 GMT, Jatin Bhateja wrote:
> Hi All,
>
> This patch adds C2 compiler support for various Float16 operations added by
> [PR#22128](https://github.com/openjdk/jdk/pull/22128)
>
> Following is the summary of changes included with this patch:-
>
> 1. Detection of vario
On Fri, 15 Nov 2024 18:32:58 GMT, Roger Riggs wrote:
> This cleanup of the use of SecurityManager is in the jdk.unsupported module.
> Removed the permission check to call getReflectionFactory().
This pull request has now been integrated.
Changeset: ded01e43
Author:Roger Riggs
URL:
h
On Fri, 13 Sep 2024 20:41:27 GMT, Brian Burkhalter wrote:
>> This proposed change would move the native objects required for NIO file
>> interaction from the libnio native library to the libjava native library on
>> Linux, macOS, and Windows.
>
> Brian Burkhalter has updated the pull request in
> This proposed change would move the native objects required for NIO file
> interaction from the libnio native library to the libjava native library on
> Linux, macOS, and Windows.
Brian Burkhalter has updated the pull request with a new target base due to a
merge or a rebase. The pull request
On Tue, 19 Nov 2024 18:43:46 GMT, Raffaello Giulietti
wrote:
>> fabioromano1 has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Correct remainder checking
>
> src/java.base/share/classes/java/math/BigDecimal.java line 2200:
>
>> 2198:
On Fri, 25 Oct 2024 04:46:52 GMT, Jatin Bhateja wrote:
>> Hi Jatin, could you also include the idealization tests here -
>> test/hotspot/jtreg/compiler/c2/irTests/MulHFNodeIdealizationTests.java and
>> ConvF2HFIdealizationTests.java in this PR?
>
>> Hi Jatin, could you also include the idealiza
On Tue, 19 Nov 2024 19:53:45 GMT, Aleksey Shipilev wrote:
>> See the bug for more discussion and reproducer. This PR replaces the ad-hoc
>> linked list with segmented list of arrays. Arrays are easy targets for GC.
>> There are possible improvements here, most glaring is parallelism that is
>>
> To resolve tools/jpackage/windows/Win8301247Test.java failure, I made "wmic"
> executed with "chcp 65001". This ensures that the encoding is UTF8 and that
> the English message "No Instance(s) Available." is output on localized
> windows platforms.
>
> I have referred to the following for how
> To resolve tools/jpackage/windows/Win8301247Test.java failure, I made "wmic"
> executed with "chcp 65001". This ensures that the encoding is UTF8 and that
> the English message "No Instance(s) Available." is output on localized
> windows platforms.
>
> I have referred to the following for how
> Remove usages of SecurityManager, doPrivildged, and AccessController from the
> java.prefs module.
Brent Christian has updated the pull request incrementally with one additional
commit since the last revision:
remove commented code + other review feedback
-
Changes:
- all: h
On Tue, 19 Nov 2024 19:53:45 GMT, Aleksey Shipilev wrote:
>> See the bug for more discussion and reproducer. This PR replaces the ad-hoc
>> linked list with segmented list of arrays. Arrays are easy targets for GC.
>> There are possible improvements here, most glaring is parallelism that is
>>
On Tue, 19 Nov 2024 21:50:13 GMT, Archie Cobbs wrote:
>> Please review this patch which removes unnecessary `@SuppressWarnings`
>> annotations.
>
> Archie Cobbs has updated the pull request with a new target base due to a
> merge or a rebase. The pull request now contains 13 commits:
>
> - Re
On Wed, 23 Oct 2024 05:07:37 GMT, Julian Waters wrote:
> After 8339120, gcc began catching many different instances of unused code in
> the Windows specific codebase. Some of these seem to be bugs. I've taken the
> effort to mark out all the relevant globals and locals that trigger the
> unuse
On Tue, 19 Nov 2024 22:07:10 GMT, Alexey Semenyuk wrote:
>> Fix `ResourceEditor` class to handle long paths.
>>
>> Based on https://github.com/openjdk/jdk/pull/9384 PR.
>>
>> This repairs app image building on Windows if the path to jpackage temp
>> directory exceeds 260 (`MAX_PATH`) character
On Mon, 14 Oct 2024 16:42:24 GMT, Paul Sandoz wrote:
> We should move the `Float16` class to `jdk.incubator.vector` and relevant
> intrinsic stuff to `jdk.internal.vm.vector`, and we don't need the changes to
> `BigDecimal` and `BigInteger`.
To expand on that point, a few weeks back I took a l
On Tue, 19 Nov 2024 18:52:59 GMT, Brent Christian wrote:
> Remove usages of SecurityManager, doPrivildged, and AccessController from the
> java.prefs module.
A few classes need updated copyrights.
-
PR Comment: https://git.openjdk.org/jdk/pull/22252#issuecomment-2486583493
On Mon, 14 Oct 2024 11:40:01 GMT, Jatin Bhateja wrote:
> Hi All,
>
> This patch adds C2 compiler support for various Float16 operations added by
> [PR#22128](https://github.com/openjdk/jdk/pull/22128)
>
> Following is the summary of changes included with this patch:-
>
> 1. Detection of vario
On Tue, 19 Nov 2024 22:31:28 GMT, Alexey Semenyuk wrote:
> Stop using internal AppImageFile, ApplicationLayout, and PackageFile classes
> in the tests. Replace them with stubs.
>
> Stop referencing IOUtils class from XmlUtils and PathUtils classes.
@sashamatveev ptal
-
PR Comment
> Remove usages of SecurityManager, doPrivildged, and AccessController from the
> java.prefs module.
Brent Christian has updated the pull request incrementally with one additional
commit since the last revision:
One more comment removal; fix 1 indent
-
Changes:
- all: https://
On Tue, 19 Nov 2024 19:18:12 GMT, Lance Andersen wrote:
>> Remove usages of SecurityManager, doPrivildged, and AccessController from
>> the java.prefs module.
>
> src/java.prefs/unix/classes/java/util/prefs/FileSystemPreferences.java line
> 63:
>
>> 61: //};
>> 62: //AccessCont
Stop using internal AppImageFile, ApplicationLayout, and PackageFile classes in
the tests. Replace them with stubs.
Stop referencing IOUtils class from XmlUtils and PathUtils classes.
-
Commit messages:
- Minor improvements
- Make IOUtils class package-private
- Bugfix & cleanup
On Tue, 19 Nov 2024 18:52:59 GMT, Brent Christian wrote:
> Remove usages of SecurityManager, doPrivildged, and AccessController from the
> java.prefs module.
src/java.prefs/share/classes/java/util/prefs/Preferences.java line 40:
> 38: import java.util.ServiceConfigurationError;
> 39:
> 40: //
On Thu, 14 Nov 2024 18:24:59 GMT, Jatin Bhateja wrote:
>> This patch optimizes LongVector multiplication by inferring VPMUL[U]DQ
>> instruction for following IR pallets.
>>
>>
>>MulVL ( AndV SRC1, 0x) ( AndV SRC2, 0x)
>>MulVL (URShiftVL SRC1 , 32) (
> Fix `ResourceEditor` class to handle long paths.
>
> Based on https://github.com/openjdk/jdk/pull/9384 PR.
>
> This repairs app image building on Windows if the path to jpackage temp
> directory exceeds 260 (`MAX_PATH`) characters. MSI building is still broken
> and can NOT be repaired due to
On Tue, 19 Nov 2024 12:41:46 GMT, Sandhya Viswanathan
wrote:
>> ISA supports multiple flavors, the current scheme is in line with the wiring
>> of inputs done before matching.
>
> You could save some reg/reg movs with 231 flavor.
It will depend on the live ranges of the three inputs.
> Please review this patch which removes unnecessary `@SuppressWarnings`
> annotations.
Archie Cobbs has updated the pull request with a new target base due to a merge
or a rebase. The pull request now contains 13 commits:
- Remove more unnecessary @SuppressWarnings annotations.
- Merge branc
On Tue, 19 Nov 2024 16:54:04 GMT, Viktor Klang wrote:
>> Doug Lea has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Ensure InnocuousForkJoinWorkerThread usable with or without SecurityManager
>
> src/java.base/share/classes/java/util/concu
On Tue, 19 Nov 2024 20:43:25 GMT, Sean Mullan wrote:
> Now that JEP 486 has been integrated, `java.security.jgss` and
> `jdk.security.jgss` module dependencies on `System.getSecurityManager` and
> `AccessController.doPrivileged*` can be removed.
>
> There is an undocumented property named "sun
Now that JEP 486 has been integrated, `java.security.jgss` and
`jdk.security.jgss` module dependencies on `System.getSecurityManager` and
`AccessController.doPrivileged*` can be removed.
There is an undocumented property named "sun.security.krb5.autodeducerealm"
that can probably be removed as
On Mon, 18 Nov 2024 15:12:12 GMT, Magnus Ihse Bursie wrote:
>> As a prerequisite for Hermetic Java, we need a statically linked `java`
>> launcher. It should behave like the normal, dynamically linked `java`
>> launcher, except that all JDK native libraries should be statically, not
>> dynamic
On Tue, 19 Nov 2024 18:52:59 GMT, Brent Christian wrote:
> Remove usages of SecurityManager, doPrivildged, and AccessController from the
> java.prefs module.
src/java.prefs/share/classes/java/util/prefs/Preferences.java line 248:
> 246: }
> 247: }
> 248: return fact
> Fix `ResourceEditor` class to handle long paths.
>
> Based on https://github.com/openjdk/jdk/pull/9384 PR.
>
> This repairs app image building on Windows if the path to jpackage temp
> directory exceeds 260 (`MAX_PATH`) characters. MSI building is still broken
> and can NOT be repaired due to
On Tue, 19 Nov 2024 16:45:47 GMT, Hannes Greule wrote:
>> In fact, another solution I have contemplated is to update
>> `JavaLangInvokeAccess` implementations. 4 methods in it,
>> `unreflectConstructor`, `unreflectField`, `findVirtual`, and `findStatic`,
>> are exclusively used by core reflect
On Tue, 19 Nov 2024 16:52:44 GMT, Viktor Klang wrote:
>> Doug Lea has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Ensure InnocuousForkJoinWorkerThread usable with or without SecurityManager
>
> src/java.base/share/classes/java/util/concu
On Tue, 19 Nov 2024 19:22:44 GMT, Aleksei Efimov wrote:
>> This PR permanently disable remote code downloading in JNDI/LDAP and
>> JNDI/RMI JDK providers, and contains the following changes:
>> - The following two properties are removed:
>> - `com.sun.jndi.ldap.object.trustURLCodebase`
>>
On Mon, 18 Nov 2024 20:28:49 GMT, Brian Burkhalter wrote:
> Expunge the use of the `SecurityManager`, `AccessController`, and the like
> from the `java.io` package.
This pull request has now been integrated.
Changeset: 81e43114
Author:Brian Burkhalter
URL:
https://git.openjdk.org/j
Fix `ResourceEditor` class to handle long paths.
Based on https://github.com/openjdk/jdk/pull/9384 PR.
This repairs app image building on Windows if the path to jpackage temp
directory exceeds 260 (`MAX_PATH`) characters. MSI building is still broken and
can NOT be repaired due to WiX's limitat
On Thu, 14 Nov 2024 04:40:37 GMT, Alexey Semenyuk wrote:
> Fix `ResourceEditor` class to handle long paths.
>
> Based on https://github.com/openjdk/jdk/pull/9384 PR.
>
> This repairs app image building on Windows if the path to jpackage temp
> directory exceeds 260 (`MAX_PATH`) characters. MSI
On Tue, 19 Nov 2024 19:22:44 GMT, Aleksei Efimov wrote:
>> This PR permanently disable remote code downloading in JNDI/LDAP and
>> JNDI/RMI JDK providers, and contains the following changes:
>> - The following two properties are removed:
>> - `com.sun.jndi.ldap.object.trustURLCodebase`
>>
On Mon, 14 Oct 2024 15:32:41 GMT, Bhavana Kilambi wrote:
> Hi Jatin, could you also include the idealization tests here -
> test/hotspot/jtreg/compiler/c2/irTests/MulHFNodeIdealizationTests.java and
> ConvF2HFIdealizationTests.java in this PR?
Hi @Bhavana-Kilambi ,
I am in process of refining
On Tue, 19 Nov 2024 00:29:42 GMT, Sandhya Viswanathan
wrote:
>> Hi All,
>>
>> This patch adds C2 compiler support for various Float16 operations added by
>> [PR#22128](https://github.com/openjdk/jdk/pull/22128)
>>
>> Following is the summary of changes included with this patch:-
>>
>> 1. Det
On Wed, 16 Oct 2024 14:19:40 GMT, Bhavana Kilambi wrote:
>> Hi All,
>>
>> This patch adds C2 compiler support for various Float16 operations added by
>> [PR#22128](https://github.com/openjdk/jdk/pull/22128)
>>
>> Following is the summary of changes included with this patch:-
>>
>> 1. Detectio
On Tue, 19 Nov 2024 08:43:06 GMT, Jatin Bhateja wrote:
>> src/hotspot/cpu/x86/x86.ad line 11015:
>>
>>> 11013: ins_encode %{
>>> 11014: int vlen_enc = vector_length_encoding(this);
>>> 11015: __ evfmadd132ph($dst$$XMMRegister, $src2$$XMMRegister,
>>> $src1$$XMMRegister, vlen_enc);
>>
On Mon, 18 Nov 2024 23:11:20 GMT, Sandhya Viswanathan
wrote:
>> Hi All,
>>
>> This patch adds C2 compiler support for various Float16 operations added by
>> [PR#22128](https://github.com/openjdk/jdk/pull/22128)
>>
>> Following is the summary of changes included with this patch:-
>>
>> 1. Det
On Fri, 25 Oct 2024 04:46:52 GMT, Jatin Bhateja wrote:
>> Hi Jatin, could you also include the idealization tests here -
>> test/hotspot/jtreg/compiler/c2/irTests/MulHFNodeIdealizationTests.java and
>> ConvF2HFIdealizationTests.java in this PR?
>
>> Hi Jatin, could you also include the idealiza
On Mon, 14 Oct 2024 11:40:01 GMT, Jatin Bhateja wrote:
> Hi All,
>
> This patch adds C2 compiler support for various Float16 operations added by
> [PR#22128](https://github.com/openjdk/jdk/pull/22128)
>
> Following is the summary of changes included with this patch:-
>
> 1. Detection of vario
On Mon, 14 Oct 2024 11:40:01 GMT, Jatin Bhateja wrote:
> Hi All,
>
> This patch adds C2 compiler support for various Float16 operations added by
> [PR#22128](https://github.com/openjdk/jdk/pull/22128)
>
> Following is the summary of changes included with this patch:-
>
> 1. Detection of vario
On Mon, 14 Oct 2024 11:40:01 GMT, Jatin Bhateja wrote:
> Hi All,
>
> This patch adds C2 compiler support for various Float16 operations added by
> [PR#22128](https://github.com/openjdk/jdk/pull/22128)
>
> Following is the summary of changes included with this patch:-
>
> 1. Detection of vario
On Thu, 17 Oct 2024 21:35:40 GMT, Paul Sandoz wrote:
> > Before the work in this PR proceeds, I think the java.lang ->
> > jdk.incubator.vector move of Float16 should occur first. This will allow
> > leaner reviews and better API separation. I can get an updated PR of the
> > move prepared wit
On Mon, 14 Oct 2024 11:40:01 GMT, Jatin Bhateja wrote:
> Hi All,
>
> This patch adds C2 compiler support for various Float16 operations added by
> [PR#22128](https://github.com/openjdk/jdk/pull/22128)
>
> Following is the summary of changes included with this patch:-
>
> 1. Detection of vario
On Mon, 14 Oct 2024 11:40:01 GMT, Jatin Bhateja wrote:
> Hi All,
>
> This patch adds C2 compiler support for various Float16 operations added by
> [PR#22128](https://github.com/openjdk/jdk/pull/22128)
>
> Following is the summary of changes included with this patch:-
>
> 1. Detection of vario
Hi All,
This patch adds C2 compiler support for various Float16 operations added by
[PR#22128](https://github.com/openjdk/jdk/pull/22128)
Following is the summary of changes included with this patch:-
1. Detection of various Float16 operations through inline expansion or pattern
folding ideali
On Tue, 19 Nov 2024 19:19:51 GMT, Brent Christian wrote:
>> Aleksey Shipilev has updated the pull request with a new target base due to
>> a merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 13 additional
>> co
> See the bug for more discussion and reproducer. This PR replaces the ad-hoc
> linked list with segmented list of arrays. Arrays are easy targets for GC.
> There are possible improvements here, most glaring is parallelism that is
> currently knee-capped by global synchronization. The synchroniz
On Tue, 19 Nov 2024 19:02:09 GMT, fabioromano1 wrote:
>> src/java.base/share/classes/java/math/BigDecimal.java line 2253:
>>
>>> 2251:
>>> 2252: case UP, CEILING -> {
>>> 2253: BigInteger[] sqrtRem =
>>> workingInt.sqrtAndRemainder();
>>
>> Can't th
On Tue, 19 Nov 2024 18:52:59 GMT, Brent Christian wrote:
> Remove usages of SecurityManager, doPrivildged, and AccessController from the
> java.prefs module.
src/java.prefs/share/classes/java/util/prefs/AbstractPreferences.java line 1059:
> 1057: * preference tree.
> 1058: */
On Tue, 19 Nov 2024 19:26:03 GMT, Aleksey Shipilev wrote:
> > With SM removal, there is a doPrivileged call in Cleaner.java. Should that
> > be handled separately from this PR?
>
> Since this is not related to the problem at hand, I'd prefer to keep it out
> of this PR.
Actually, I wonder if
On Fri, 15 Nov 2024 12:17:47 GMT, Lance Andersen wrote:
>> Stuart in one of his review comments in this PR had noted that:
>>
>>> I think the class specification needs to be clearer about the positioning
>>> of end() and close(). The end() method has done the real work of "closing"
>>> since t
On Fri, 15 Nov 2024 11:15:28 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this enhancement which proposes to enhance
>> `java.util.zip.Deflater/Inflater` classes to now implement `AutoCloseable`?
>>
>> The actual work for this was done a few years back when we discussed the
>> prop
On Tue, 19 Nov 2024 15:50:07 GMT, Alexey Semenyuk wrote:
> Bad merge fix
This pull request has now been integrated.
Changeset: 7f672eb2
Author:Alexey Semenyuk
URL:
https://git.openjdk.org/jdk/commit/7f672eb266b76a9310dcf108f72adf2469e63dee
Stats: 3 lines in 1 file changed: 1 ins
On Tue, 19 Nov 2024 08:09:38 GMT, Aleksey Shipilev wrote:
>> See the bug for more discussion and reproducer. This PR replaces the ad-hoc
>> linked list with segmented list of arrays. Arrays are easy targets for GC.
>> There are possible improvements here, most glaring is parallelism that is
>>
> This PR permanently disable remote code downloading in JNDI/LDAP and JNDI/RMI
> JDK providers, and contains the following changes:
> - The following two properties are removed:
> - `com.sun.jndi.ldap.object.trustURLCodebase`
> - `com.sun.jndi.rmi.object.trustURLCodebase`
> - JNDIs object
On Tue, 19 Nov 2024 18:52:59 GMT, Brent Christian wrote:
> Remove usages of SecurityManager, doPrivildged, and AccessController from the
> java.prefs module.
Hi Brent,
There looks to be a lot of commented out code that should be removed as part of
your PR?
src/java.prefs/unix/classes/java/ut
On Tue, 19 Nov 2024 16:10:19 GMT, Viktor Klang wrote:
>> Doug Lea has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Ensure InnocuousForkJoinWorkerThread usable with or without SecurityManager
>
> src/java.base/share/classes/java/util/concu
On Tue, 19 Nov 2024 18:44:27 GMT, Raffaello Giulietti
wrote:
>> fabioromano1 has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Correct remainder checking
>
> src/java.base/share/classes/java/math/BigDecimal.java line 2253:
>
>> 2251:
>>
On Fri, 15 Nov 2024 01:12:34 GMT, Stuart Marks wrote:
> First cut at removal of Security Manager stuff from RMI.
>
> This covers just about every SM-related case in RMI, except for a bit of
> package checking in MarshalInputStream. This will be handled separately. It's
> covered by [JDK-834432
On Tue, 19 Nov 2024 08:09:38 GMT, Aleksey Shipilev wrote:
>> See the bug for more discussion and reproducer. This PR replaces the ad-hoc
>> linked list with segmented list of arrays. Arrays are easy targets for GC.
>> There are possible improvements here, most glaring is parallelism that is
>>
On Tue, 19 Nov 2024 14:44:40 GMT, fabioromano1 wrote:
>> After changing `BigInteger.sqrt()` algorithm, this can be also used to speed
>> up `BigDecimal.sqrt()` implementation. Here is how I made it.
>>
>> The main steps of the algorithm are as follows:
>> first argument reduce the value to an i
On Mon, 18 Nov 2024 13:41:49 GMT, Alexey Semenyuk wrote:
> Support using jpackage l10n keys instead of string values when examining
> jpackage error output.
This pull request has now been integrated.
Changeset: 0714114f
Author:Alexey Semenyuk
URL:
https://git.openjdk.org/jdk/commit
1 - 100 of 162 matches
Mail list logo
