RFR: 8341923: java.util.Locale class specification improvements

2024-11-17 Thread Justin Lu
Please review this PR and corresponding CSR which includes a wide range of specification improvements for java.util.Locale. See the CSR for further detail. Other changes/suggestions are welcomed to be included as part of this change. Alternatively the diffs can be viewed on the API diff link att

Re: RFR: 8344365: SecurityManager cleanups in java.sql and java.sql.rowset modules

2024-11-17 Thread Alan Bateman
On Sun, 17 Nov 2024 19:01:24 GMT, Eirik Bjørsnøs wrote: > Please review this PR which cleans up SecurityManager-related code in > `java.sql` and `java.sql.rowset` modules post JEP-486 > > There are quite a few changes to review, but all relatively straightforward: > > `DriverManager` > * Remov

Re: RFR: 8342469: Improve API documentation for java.lang.classfile.instruction [v3]

2024-11-17 Thread Chen Liang
On Mon, 18 Nov 2024 02:58:31 GMT, Chen Liang wrote: >> Improve the documentation for classfile instructions. Includes links to all >> opcodes, usage notes for instructions, and other various fixes. >> >> API Diff: >> https://cr.openjdk.org/~liach/apidiff/cf-instr/java.base/module-summary.html

Re: RFR: 8342469: Improve API documentation for java.lang.classfile.instruction [v3]

2024-11-17 Thread Chen Liang
> Improve the documentation for classfile instructions. Includes links to all > opcodes, usage notes for instructions, and other various fixes. Chen Liang has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains six commits: - Further faceli

Re: RFR: 8344056: Use markdown format for man pages [v4]

2024-11-17 Thread Iris Clark
On Fri, 15 Nov 2024 14:50:21 GMT, Magnus Ihse Bursie wrote: >> Currently, the man pages are stored as troff (a text format) in the open >> repo, and a content-wise identical copy is stored as markdown (another text >> format) in the closed repo. >> >> Since markdown is preferred to troff in te

Re: RFR: 8343237: Improve the copying of the available set of Currencies

2024-11-17 Thread Justin Lu
On Fri, 1 Nov 2024 23:17:01 GMT, Justin Lu wrote: > Please review this PR which is a small cleanup in > `Currency.getAvailableCurrencies()`. We can use the `HashSet` constructor > over `clone()` to make the defensive copy of the set of available currencies. > This gets rid of the unsightly unc

Integrated: 8343237: Improve the copying of the available set of Currencies

2024-11-17 Thread Justin Lu
On Fri, 1 Nov 2024 23:17:01 GMT, Justin Lu wrote: > Please review this PR which is a small cleanup in > `Currency.getAvailableCurrencies()`. We can use the `HashSet` constructor > over `clone()` to make the defensive copy of the set of available currencies. > This gets rid of the unsightly unc

Re: RFR: 8344336: SM cleanup of java.lang.System, Runtime, String, StackWalker

2024-11-17 Thread Chen Liang
On Fri, 15 Nov 2024 22:11:17 GMT, Roger Riggs wrote: > Removed use of SecurityManager to check permissions. > Relaxed defensive copying of byte arrays (due to lack of SM) src/java.base/share/classes/java/lang/String.java line 691: > 689: System.getSecurityManager() != null)

Integrated: 8343876: Enhancements to jpackage test lib

2024-11-17 Thread Alexey Semenyuk
On Sat, 9 Nov 2024 00:51:03 GMT, Alexey Semenyuk wrote: > Make jpackage test lib more practical. List of changes: > > Support multiple args and var args in `@Parameter` annotation: > > @Test > @Parameter({"12", "foo"}) > @Parameter({"-89", "bar", "more"}) > @Parameter({"-89", "bar", "more", "mo

RFR: 8178966: Don't swallow early bootstrap exceptions in Boolean.getBoolean, Integer.getInteger and Long.getLong

2024-11-17 Thread Eirik Bjørsnøs
Please review this PR which removes exceptional control flow in `Boolean::getBoolean`, `Integer::getInteger` and `Long::getLong`. These methods are catching `IllegalArgumentException` and `NullPointerException`, thrown by `System::getProperty` via `System::checkKey`. This PR replaces the except

RFR: 8344365: SecurityManager cleanups in java.sql and java.sql.rowset modules

2024-11-17 Thread Eirik Bjørsnøs
Please review this PR which cleans up SecurityManager-related code in `java.sql` and `java.sql.rowset` modules post JEP-486 There are quite a few changes to review, but all relatively straightforward: `DriverManager` * Remove `SecurityManager::checkPermission` calls in the `setLogWriter`, `setL