Trivial change to exclude the test from running with Xcomp flag.
The test fails because the number of GCs as reported by the MXBean doesn't
match the expected number. This is due to the additional GC happening due to
CodeCache crossing its threshold.
We could increase the code cache or restrict
On Sat, 16 Nov 2024 07:59:15 GMT, Alan Bateman wrote:
> The CSR for JEP 486 included all the API changes for the supported APIs. With
> this PR we are in grey area of "critical internal APIs" that are
> undocumented. We have been doing CSRs whenever we remove these anything from
> jdk.unsuppor
On Fri, 15 Nov 2024 16:38:53 GMT, Roger Riggs wrote:
> Refactor to remove use of SecurityManager
Hey Roger, thanks for doing this no doubt unglamorous maintenance task. I
reviewed it, and it mostly looks good, there's few things I thought about maybe
taking a step further (and one thing I'd pr
On Fri, 15 Nov 2024 19:30:06 GMT, Aleksey Shipilev wrote:
>> See the bug for more discussion and reproducer. This PR replaces the ad-hoc
>> linked list with segmented list of arrays. Arrays are easy targets for GC.
>> There are possible improvements here, most glaring is parallelism that is
>>
On Fri, 15 Nov 2024 19:30:06 GMT, Aleksey Shipilev wrote:
>> See the bug for more discussion and reproducer. This PR replaces the ad-hoc
>> linked list with segmented list of arrays. Arrays are easy targets for GC.
>> There are possible improvements here, most glaring is parallelism that is
>>
On Fri, 15 Nov 2024 15:43:08 GMT, Eirik Bjørsnøs wrote:
>> Please review this PR to clean up `RandomSupport`, `ClassFileDumper` and
>> `StaticProperty` in the `jdk.internal.util` namespace:
>>
>> * `RandomSupport` is updated to replace an `AccessController::doPrivileged`
>> call with `Boolean:
Refactor to remove use of SecurityManager
-
Commit messages:
- 8344319: SM cleanup in jdk.dynlink module
Changes: https://git.openjdk.org/jdk/pull/22152/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=22152&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8344319
Sta
On Fri, 15 Nov 2024 16:38:53 GMT, Roger Riggs wrote:
> Refactor to remove use of SecurityManager
Hello Roger, there's a typo in the JBS title (and thus this PR title too). The
module name should have been `jdk.dynalink`.
-
PR Comment: https://git.openjdk.org/jdk/pull/22152#issueco
> This addresses tendencies in previous update to increase fencing, scanning,
> and signalling that can increase contention, and slow down performance
> especially on ARM platforms. It also uses more ARM-friendly constructions to
> reduce overhead (leading to several changes that all of the same
On Fri, 15 Nov 2024 09:35:17 GMT, Eirik Bjørsnøs wrote:
> Please review this PR to clean up `RandomSupport`, `ClassFileDumper` and
> `StaticProperty` in the `jdk.internal.util` namespace:
>
> * `RandomSupport` is updated to replace an `AccessController::doPrivileged`
> call with `Boolean::getB
On Fri, 15 Nov 2024 16:38:20 GMT, Ioi Lam wrote:
>> This is an implementation of [JEP 483: Ahead-of-Time Class Loading &
>> Linking](https://openjdk.org/jeps/483).
>>
>>
>> Note: this is a combined PR of the following individual PRs
>> - https://github.com/openjdk/jdk/pull/20516
>> - https
On Fri, 15 Nov 2024 21:36:24 GMT, Eirik Bjørsnøs wrote:
> Please review this trivial cleanup PR which removes the nested static private
> class `System.CallersHolder`.
>
> This class was used pre JEP486 to track callers of
> `System::setSecurityManager` such that warnings were printed only onc
On Fri, 15 Nov 2024 00:07:07 GMT, Magnus Ihse Bursie wrote:
> The policy has long been to use Classpath Exception in the `src` and `make`
> directories, but not in the `test` directories. If you're changing the
> policy, you might want to check and update any documentation where the policy
> m
On Thu, 14 Nov 2024 17:19:02 GMT, Roger Riggs wrote:
>> After [JDK-8338411](https://bugs.openjdk.org/browse/JDK-8338411),
>> Serialization implementation dependencies on SecurityManager, doPrivildged,
>> and AccessController are removed.
>> Some refactoring to cleanup the remaining code is expe
On Fri, 15 Nov 2024 01:05:10 GMT, ExE Boss wrote:
>> Doesn't this break any apps that use these offsets? Aren't these fields
>> part of the public API of Unsafe, so changing them requires a CSR?
>
> @dean-long
>> Doesn't this break any apps that use these offsets? Aren't these fields part
>> o
On Fri, 15 Nov 2024 20:10:45 GMT, Doug Lea wrote:
> A side question: Are there now any situations in which Thread.interrupt can
> throw an exception? If not, a few more things in j.u.c and elsewhere could be
> simplified someday.
It's possible to extend Thread and override interrupt so in theo
On Fri, 15 Nov 2024 22:41:22 GMT, Eirik Bjørsnøs wrote:
>> Removed use of SecurityManager to check permissions.
>> Relaxed defensive copying of byte arrays (due to lack of SM)
>
> src/java.base/share/classes/java/lang/String.java line 843:
>
>> 841:
>> 842: // Trim the given byte array to t
On Fri, 15 Nov 2024 18:32:58 GMT, Roger Riggs wrote:
> This cleanup of the use of SecurityManager is in the jdk.unsupported module.
> Removed the permission check to call getReflectionFactory().
The CSR for JEP 486 included all the API changes for the supported APIs. With
this PR we are in grey
18 matches
Mail list logo
